Re: usb/serial/io_ti.c broken on BE systems

2014-02-18 Thread Ludovic
Johan Hovold writes: > Care to test the patch below (against usb-next) on both your LE and BE > machines? Thanks I'll try your patch next WE. I've patched the code in a similar way a few days ago, but I have strange problems: I can do a write and a read, but then I have to close the serial port o

Re: USB to Serial converter code pl2303

2014-02-18 Thread Johan Hovold
[ Please make sure to CC the linux-usb list as well. ] On Tue, Feb 18, 2014 at 02:57:45AM +0100, Magnus wrote: > After plugging in the plexgear adapter into my linux boxes: > Fedora 18, Debian 3.11.0-15-generic #25-Ubuntu and weezy it doesnt > send any commands to the servo controller chip on the

Re: usb/serial/io_ti.c broken on BE systems

2014-02-18 Thread Johan Hovold
On Tue, Feb 18, 2014 at 08:49:17AM +, Ludovic wrote: > Johan Hovold writes: > > Care to test the patch below (against usb-next) on both your LE and BE > > machines? > > Thanks I'll try your patch next WE. Great. > I've patched the code in a similar way a few days ago, but I have strange > p

Re: usbserial_generic, idVendor=1a28, idProduct=6010

2014-02-18 Thread Johan Hovold
On Sun, Feb 16, 2014 at 12:35:06PM +0100, Emanuel Koczwara wrote: > Hi, > > I have a device (thermal printer) which communicates through rs232. It > has also usb adapter/converter build-in. > > root@emanuel-laptop:/home/emanuel# lsusb > Bus 004 Device 004: ID 8086:0189 Intel Corp. > Bus 004 Devi

Re: [RFC 1/2] usb: gadget: zero: Add support for interrupt EP

2014-02-18 Thread Amit Virdi
Dear Andrezej, On 2/10/2014 7:15 PM, Andrzej Pietrasiewicz wrote: W dniu 10.02.2014 14:16, Amit Virdi pisze: Interrupt endpoints behave quite similar to the bulk endpoints with the difference that the endpoints expect data sending/reception request at particular intervals till the whole data ha

Re: [BUG] FL1009: xHCI host not responding to stop endpoint command.

2014-02-18 Thread Thomas Petazzoni
Dear Arnaud Ebalard, On Sat, 18 Jan 2014 22:49:17 +0100, Arnaud Ebalard wrote: > I started suspecting the introduction of MSI support in Marvell PCIe > host controller driver (FL1009 is on the PCIe bus) and compiled a > a 3.13.0-rc8 w/ CONFIG_PCI_MSI disabled (it was enabled in all my > previous

gadget support

2014-02-18 Thread Arturo Veras
hi all In my PC have the kernel linux usb gadget support enabled but when i try to load the module: sudo modprobe g_ether FATAL: Error inserting g_ether (/lib/modules/3.13.2/kernel/drivers/usb/gadget/g_ether.ko): No such device maybe my usb is not supported by the driver. I don't know. i have a N

[PATCH v2 3/3] usb: chipidea: msm: Initialize offset of the capability registers

2014-02-18 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Since commit 62bb84e (usb: gadget: ci13xxx: convert to platform device) start address of the capability registers is not passed correctly to udc_probe(). Fix this. Signed-off-by: Ivan T. Ivanov --- drivers/usb/chipidea/ci_hdrc_msm.c |1 + 1 file changed, 1 insertion(

[PATCH v2 0/3] usb: chipidea: msm: Clean and fix glue layer driver

2014-02-18 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Hi, This series intend to fix driver, which was broken for a while. It is used to create peripheral role device, which in coordination with phy-usb-msm driver will provide USB2.0 gadget support for Qualcomm targets. Changes since initial version. - Address comments fr

[PATCH v2 2/3] usb: chipidea: msm: Add device tree support

2014-02-18 Thread Ivan T. Ivanov
From: "Ivan T. Ivanov" Allows controller to be specified via device tree. Pass PHY phandle specified in DT to core driver. Signed-off-by: Ivan T. Ivanov --- drivers/usb/chipidea/ci_hdrc_msm.c | 23 ++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/drivers/

Re: [PATCH 0/7] usb: dwc2/s3c-hsotg: Combine drivers into a single DRD

2014-02-18 Thread Robert Baldyga
On 02/17/2014 09:18 AM, Robert Baldyga wrote: > On 02/17/2014 01:37 AM, Jingoo Han wrote: >> On Friday, February 14, 2014 6:44 PM, Robert Baldyga wrote: >>> On 02/13/2014 10:10 PM, dingu...@altera.com wrote: From: Dinh Nguyen Hello, This patch series combines the dwc2 host

[PATCH net-next 05/14] r8152: reduce the frequency of spin_lock

2014-02-18 Thread Hayes Wang
Replace getting one item from a list with getting the whole list one time. Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 47 ++- 1 file changed, 38 insertions(+), 9 deletions(-) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c

[PATCH net-next 14/14] r8152: support get_msglevel and set_msglevel

2014-02-18 Thread Hayes Wang
Support get_msglevel and set_msglevel. Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 16 1 file changed, 16 insertions(+) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index db98842..0654bd3 100644 --- a/drivers/net/usb/r8152.c +++ b/drivers/net/usb/r

[PATCH net-next 07/14] r8152: combine PHY reset with set_speed

2014-02-18 Thread Hayes Wang
PHY reset is necessary after some hw settings. However, it would cause the linking down, and so does the set_speed function. Combine the PHY reset with set_speed function. That could reduce the frequency of linking down and accessing the PHY register. Signed-off-by: Hayes Wang --- drivers/net/us

[PATCH net-next 13/14] r8152: set disable_hub_initiated_lpm

2014-02-18 Thread Hayes Wang
Set disable_hub_initiated_lpm = 1. Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index ff02d5d..db98842 100644 --- a/drivers/net/usb/r8152.c +++ b/drivers/net/usb/r8152.c @@ -3159,6 +315

[PATCH net-next 12/14] r8152: replace netif_rx with netif_receive_skb

2014-02-18 Thread Hayes Wang
Replace netif_rx with netif_receive_skb to avoid disabling irq frequently for increasing the efficiency. Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index 3ff11ed..ff02

[PATCH net-next 08/14] r8152: move some functions from probe to open

2014-02-18 Thread Hayes Wang
Add up method for rtl_ops and asign relative functions. Move clear_bp() and hw_phy_cfg() from init method to up method of rtl_ops. Call rtl_ops.up() for ndo_open() and rtl_ops.down for ndo_stop(). Replace allocating the memory in probe() with in ndo_open(). Signed-off-by: Hayes Wang --- drivers

[PATCH net-next 03/14] r8152: replace some types from int to bool

2014-02-18 Thread Hayes Wang
Modify the following functions. - r8153_u1u2en - r8153_u2p3en - r8153_power_cut_en Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index 2d5e761..

[PATCH net-next 11/14] r8152: disable teredo for RTL8152

2014-02-18 Thread Hayes Wang
Disable teredo for RTL8152 by default. Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index f303549..3ff11ed 100644 --- a/drivers/net/usb/r8152.c +++ b/drivers/net/usb/r8152.c @@ -2021,6

[PATCH net-next 10/14] r8152: support runtime suspend

2014-02-18 Thread Hayes Wang
Support runtime suspend for RTL8152 and RTL8153. Move tx_bottom() from tasklet to delayed_work. That avoids to transmit tx packets after calling autosuspend. Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 181 ++-- 1 file changed, 158 inserti

[PATCH net-next 06/14] r8152: clear BMCR_PDOWN

2014-02-18 Thread Hayes Wang
Modify the method of enabling the PHY to clear BMCR_PDOWN only. Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index 2a778fa..c7bae39 100644 --- a/drivers

[PATCH net-next 09/14] r8152: support WOL

2014-02-18 Thread Hayes Wang
Support WOL for RTL8152 and RTL8153. Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 118 ++-- 1 file changed, 105 insertions(+), 13 deletions(-) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index 828572a..5d520be 100644 ---

[PATCH net-next 04/14] r8152: load the default MAC address

2014-02-18 Thread Hayes Wang
Except for RTL_VER_01, replace loading the MAC address from PLA_IDR with from PLA_BACKUP. The default MAC address may be modified by the other OS, so the PLA_IDR may be not the default MAC address. The data in the PLA_BACKUP address of the RTL_VER_01 may be destoryed, so load MAC address from PLA_

[PATCH net-next 00/14] r8152: improvement and new features

2014-02-18 Thread Hayes Wang
Change some flows or behavior to improve the efficiency or make the code readable. Besides, support WOL and runtime suspend. Hayes Wang (14): r8152: move some functions r8152: add three functions r8152: replace some types from int to bool r8152: load the default MAC address r8152: reduce

[PATCH net-next 02/14] r8152: add three functions

2014-02-18 Thread Hayes Wang
Replace some codes with the following three functions. - rtl_drop_queued_tx - rxdy_gated_en - r8152_power_cut_en Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 99 + 1 file changed, 51 insertions(+), 48 deletions(-) diff --git a/driver

[PATCH net-next 01/14] r8152: move some functions

2014-02-18 Thread Hayes Wang
Move the following functions which is for the further coding. - rtl_clear_bp - r8153_clear_bp - r8153_teredo_off - r8152b_disable_aldps - r8152b_enable_aldps - r8152b_hw_phy_cfg Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 106 1

Re: [PATCH v2 2/3] usb: chipidea: msm: Add device tree support

2014-02-18 Thread Josh Cartwright
Hey Ivan- Nit below. On Tue, Feb 18, 2014 at 03:21:20PM +0200, Ivan T. Ivanov wrote: > From: "Ivan T. Ivanov" > > Allows controller to be specified via device tree. > Pass PHY phandle specified in DT to core driver. > > Signed-off-by: Ivan T. Ivanov > --- > drivers/usb/chipidea/ci_hdrc_msm.c

Re: gadget support

2014-02-18 Thread Andrzej Pietrasiewicz
W dniu 18.02.2014 14:15, Arturo Veras pisze: hi all In my PC have the kernel linux usb gadget support enabled but when i Why do you have usb gadget support in a PC in the first place? What are you trying to achieve? What you could achieve is for example to make your PC act as a mass storage dev

Re: USB 3380 using net2280 driver

2014-02-18 Thread Felipe Balbi
Hi, *always* Cc the mailing list please. On Mon, Feb 17, 2014 at 04:43:11PM -0800, Amit Uttamchandani wrote: > I was looking at the changes for net2280.c and saw your name come up in > a few of the more recent changes. I wanted to know, are you aware of > support for PLXs USB 338o using this net2

Re: [PATCH] usb: host: xhci-plat: Use module_platform_driver()

2014-02-18 Thread Felipe Balbi
On Fri, Jan 31, 2014 at 02:27:09AM -0200, Fabio Estevam wrote: > From: Fabio Estevam > > Using module_platform_driver() can make the code simpler. > > Signed-off-by: Fabio Estevam Acked-by: Felipe Balbi > --- > Build-tested only > > drivers/usb/host/xhci-plat.c | 11 +-- > 1 file c

Re: [PATCH v7 03/12] mfd: omap-usb-host: Use clock names as per function for reference clocks

2014-02-18 Thread Roger Quadros
On 02/14/2014 03:33 PM, Lee Jones wrote: Use a meaningful name for the reference clocks so that it indicates the function. CC: Lee Jones CC: Samuel Ortiz Signed-off-by: Roger Quadros --- drivers/mfd/omap-usb-host.c | 6 +++--- 1 file changed, 3 inse

Re: [PATCH v2 1/2] usb: host: xhci-plat: Use module_platform_driver()

2014-02-18 Thread Felipe Balbi
On Fri, Jan 31, 2014 at 02:29:52AM -0200, Fabio Estevam wrote: > From: Fabio Estevam > > Using module_platform_driver() can make the code simpler. > > Signed-off-by: Fabio Estevam Acked-by: Felipe Balbi > --- > Build-tested only > > Changes since v1: > - Mark the patch as 1/2 > > drivers/

Re: [PATCH Resend 2/2] usb: gadget: s3c-hsudc: Remove unused label

2014-02-18 Thread Felipe Balbi
On Mon, Feb 03, 2014 at 01:59:39PM +0530, Sachin Kamat wrote: > Fixes the following compilation warning: > drivers/usb/gadget/s3c-hsudc.c: In function ‘s3c_hsudc_probe’: > drivers/usb/gadget/s3c-hsudc.c:1347:1: warning: label ‘err_add_device’ > defined but not used [-Wunused-label] > > Signed-off-

Re: [PATCH v2 2/2] usb: host: xhci-plat: Fix build warning when !CONFIG_PM

2014-02-18 Thread Felipe Balbi
On Fri, Jan 31, 2014 at 02:29:53AM -0200, Fabio Estevam wrote: > From: Fabio Estevam > > Building keystone_defconfig leads to the following build warnings: > > drivers/usb/host/xhci-plat.c:203:12: warning: 'xhci_plat_suspend' defined but > not used [-Wunused-function] > drivers/usb/host/xhci-pl

Re: [PATCH Resend 1/2] usb: gadget: s3c2410_udc: Fix build error

2014-02-18 Thread Felipe Balbi
On Mon, Feb 03, 2014 at 01:59:38PM +0530, Sachin Kamat wrote: > Pass value instead of address as expected by 'usb_ep_set_maxpacket_limit'. > Fixes the following compilation error introduced by commit e117e742d310 > ("usb: gadget: add "maxpacket_limit" field to struct usb_ep"): > > drivers/usb/gadg

Re: Remove dependency on BROKEN from drives/usb/musb/da8xx.c glue

2014-02-18 Thread Felipe Balbi
On Mon, Feb 03, 2014 at 11:57:32AM +0100, Christian Riesch wrote: > Hi, > > commit 787f5627bec80094db487bfcb401e9744f181aed > usb: musb: make davinci and da8xx glues depend on BROKEN > Signed-off-by: Felipe Balbi > > adds a dependency of the drivers/usb/musb/da8xx.c driver to BROKEN. > > I have

Re: [PATCH] USB: gadget: remove unused parameter from udc_stop in usb_gadget_ops

2014-02-18 Thread Felipe Balbi
On Tue, Dec 17, 2013 at 09:40:35AM +0100, Robert Baldyga wrote: > This patch removes parameter struct usb_gadget_driver* from udc_stop() > function > in struct usb_gadget_ops. This parameter is useless in udc_stop() function, > and > UDC drivers can work well without it, so removeing it makes cod

Re: [PATCH v2] usb: dwc3: fix wrong bit mask in dwc3_event_devt

2014-02-18 Thread Felipe Balbi
Hi, On Tue, Jan 07, 2014 at 05:45:50PM +0800, Huang Rui wrote: > Per dwc3 2.70a spec in the Device-Specific Event (DEVT), the field of > Event Information Bits(EvtInfo) uses [24:16] bits, and it has 9 bits > not 8 bits. And the following reserved field uses [31:25] bits not > [31:24] bits, and it

Re: [PATCH 1/6] usb: gadget: gr_udc: Make struct platform_device variable name clearer

2014-02-18 Thread Felipe Balbi
On Thu, Jan 09, 2014 at 11:54:13AM +0100, Andreas Larsson wrote: > Rename struct platform_device pointers from ofdev to pdev for clarity. > Suggested by Mark Rutland. > > Signed-off-by: Andreas Larsson > --- > drivers/usb/gadget/gr_udc.c | 18 +- > 1 file changed, 9 insertions(

Re: USB 3380 using net2280 driver

2014-02-18 Thread Kevin Cernekee
On Tue, Feb 18, 2014 at 7:12 AM, Felipe Balbi wrote: > On Mon, Feb 17, 2014 at 04:43:11PM -0800, Amit Uttamchandani wrote: >> I was looking at the changes for net2280.c and saw your name come up in >> a few of the more recent changes. I wanted to know, are you aware of >> support for PLXs USB 338o

Re: [PATCH v7 03/12] mfd: omap-usb-host: Use clock names as per function for reference clocks

2014-02-18 Thread Lee Jones
> Use a meaningful name for the reference clocks so that it indicates the > function. > > CC: Lee Jones > CC: Samuel Ortiz > Signed-off-by: Roger Quadros > --- > drivers/mfd/omap-usb-host.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(

Re: [PATCH 2/2] USB: at91: using USBA_NR_DMAS for DMA channels

2014-02-18 Thread Felipe Balbi
On Fri, Jan 17, 2014 at 10:59:25AM +0800, Bo Shen wrote: > When the SoC is earlier than sama5d3 SoC, which have the same number > endpoints and DMAs. However for sama5d3 SoC, it has different number > for endpoints and DMAs. So, define USBA_NR_DMAs for DMA channels > > Signed-off-by: Bo Shen > --

Re: [PATCH v4 1/2] usb: musb: dsps, debugfs files

2014-02-18 Thread Felipe Balbi
On Fri, Jan 17, 2014 at 10:22:35AM +0100, Markus Pargmann wrote: > debugfs files to show the contents of important dsps registers. > > Signed-off-by: Markus Pargmann > --- > drivers/usb/musb/musb_dsps.c | 54 > > 1 file changed, 54 insertions(+) > >

Re: [PATCH v2] usb: phy: msm: fix compilation errors when !CONFIG_PM_SLEEP

2014-02-18 Thread Felipe Balbi
On Fri, Jan 17, 2014 at 12:26:50PM -0600, Josh Cartwright wrote: > On Fri, Jan 17, 2014 at 11:58:51AM -0600, Josh Cartwright wrote: > > Both the PM_RUNTIME and PM_SLEEP callbacks call into the common > > msm_otg_{suspend,resume} routines, however these routines are only being > > built when CONFIG_

Re: [PATCH v2 1/6] usb: otg-fsm: add HNP polling operation function.

2014-02-18 Thread Felipe Balbi
On Mon, Jan 20, 2014 at 10:00:15AM +0800, Li Jun wrote: > This patch adds HNP polling operation function for OTG fsm. > > Signed-off-by: Li Jun > --- > drivers/usb/phy/phy-fsm-usb.c |2 ++ > include/linux/usb/otg-fsm.h |9 + > 2 files changed, 11 insertions(+), 0 deletions(-) >

Re: [PATCH v2] usb: phy: msm: fix compilation errors when !CONFIG_PM_SLEEP

2014-02-18 Thread Josh Cartwright
On Tue, Feb 18, 2014 at 10:24:16AM -0600, Felipe Balbi wrote: > On Fri, Jan 17, 2014 at 12:26:50PM -0600, Josh Cartwright wrote: > > On Fri, Jan 17, 2014 at 11:58:51AM -0600, Josh Cartwright wrote: > > > Both the PM_RUNTIME and PM_SLEEP callbacks call into the common > > > msm_otg_{suspend,resume}

Re: [PATCH] usb: musb: correct use of schedule_delayed_work()

2014-02-18 Thread Felipe Balbi
On Wed, Feb 05, 2014 at 03:34:18PM +0100, Daniel Mack wrote: > schedule_delayed_work() takes the delay in jiffies, not msecs. > > This bug slipped in with the recent reset logic cleanup > (8ed1fb790ea: "usb: musb: finish suspend/reset work independently from > musb_hub_control()"). > > Signed-off

[PATCH RESEND v3] usb: phy: msm: fix compilation errors when !CONFIG_PM_SLEEP

2014-02-18 Thread Josh Cartwright
Both the PM_RUNTIME and PM_SLEEP callbacks call into the common msm_otg_{suspend,resume} routines, however these routines are only being built when CONFIG_PM_SLEEP. In addition, msm_otg_{suspend,resume} also depends on msm_hsusb_config_vddcx(), which is only built when CONFIG_PM_SLEEP. Fix the CO

Re: [PATCH] usb: musb: correct use of schedule_delayed_work()

2014-02-18 Thread Daniel Mack
On 02/18/2014 05:33 PM, Felipe Balbi wrote: > On Wed, Feb 05, 2014 at 03:34:18PM +0100, Daniel Mack wrote: >> schedule_delayed_work() takes the delay in jiffies, not msecs. >> >> This bug slipped in with the recent reset logic cleanup >> (8ed1fb790ea: "usb: musb: finish suspend/reset work independe

Re: [PATCH] usb: gadget: fix NULL pointer dereference

2014-02-18 Thread Felipe Balbi
On Fri, Jan 17, 2014 at 05:04:55PM +0100, Michal Nazarewicz wrote: > On Thu, Jan 16 2014, Andrzej Pietrasiewicz wrote: > > Fix possible NULL pointer dereference introduced in > > > > 219580e64f035bb9018dbb08d340f90b0ac50f8c > > usb: f_fs: check quirk to pad epout buf size when not aligned to > > ma

Re: [PATCH] usb: gadget: fix NULL pointer dereference

2014-02-18 Thread Felipe Balbi
On Tue, Feb 18, 2014 at 10:40:12AM -0600, Felipe Balbi wrote: > On Fri, Jan 17, 2014 at 05:04:55PM +0100, Michal Nazarewicz wrote: > > On Thu, Jan 16 2014, Andrzej Pietrasiewicz wrote: > > > Fix possible NULL pointer dereference introduced in > > > > > > 219580e64f035bb9018dbb08d340f90b0ac50f8c > >

Re: [PATCH v2] usb: phy: msm: fix compilation errors when !CONFIG_PM_SLEEP

2014-02-18 Thread Felipe Balbi
On Tue, Feb 18, 2014 at 10:33:21AM -0600, Josh Cartwright wrote: > On Tue, Feb 18, 2014 at 10:24:16AM -0600, Felipe Balbi wrote: > > On Fri, Jan 17, 2014 at 12:26:50PM -0600, Josh Cartwright wrote: > > > On Fri, Jan 17, 2014 at 11:58:51AM -0600, Josh Cartwright wrote: > > > > Both the PM_RUNTIME an

Re: [PATCH] usb: musb: correct use of schedule_delayed_work()

2014-02-18 Thread Felipe Balbi
On Tue, Feb 18, 2014 at 05:41:12PM +0100, Daniel Mack wrote: > On 02/18/2014 05:33 PM, Felipe Balbi wrote: > > On Wed, Feb 05, 2014 at 03:34:18PM +0100, Daniel Mack wrote: > >> schedule_delayed_work() takes the delay in jiffies, not msecs. > >> > >> This bug slipped in with the recent reset logic c

Re: [PATCH v9 01/12] usb: doc: phy-mxs: Add more compatible strings

2014-02-18 Thread Felipe Balbi
On Fri, Dec 27, 2013 at 10:38:30AM +0800, Peter Chen wrote: > Add "fsl,imx6q-usbphy" for imx6dq and imx6dl, add > "fsl,imx6sl-usbphy" for imx6sl. > > Signed-off-by: Peter Chen anybody from DT to give me an Acked-by ? -- balbi signature.asc Description: Digital signature

Re: [PATCH v9 11/12] usb: phy-mxs: Add system suspend/resume API

2014-02-18 Thread Felipe Balbi
On Fri, Dec 27, 2013 at 10:38:40AM +0800, Peter Chen wrote: > We need this to keep PHY's power on or off during the system > suspend mode. If we need to enable USB wakeup, then we > must keep PHY's power being on during the system suspend mode. > Otherwise, we need to keep PHY's power being off to

Re: [PATCH v2 2/3] usb: chipidea: msm: Add device tree support

2014-02-18 Thread Sergei Shtylyov
Hello. On 02/18/2014 04:21 PM, Ivan T. Ivanov wrote: From: "Ivan T. Ivanov" Allows controller to be specified via device tree. Pass PHY phandle specified in DT to core driver. Signed-off-by: Ivan T. Ivanov --- drivers/usb/chipidea/ci_hdrc_msm.c | 23 ++- 1 file

Re: [PATCH] u_ether: move receiving to RX workqueue

2014-02-18 Thread Felipe Balbi
Hi, On Mon, Feb 17, 2014 at 02:26:54PM +0800, Clanlab (Taiwan) Linux Project wrote: > @@ -1168,5 +1191,23 @@ void gether_disconnect(struct gether *link) > } > EXPORT_SYMBOL(gether_disconnect); > > +static int __init gether_init(void) > +{ > + gether_wq = create_singlethread_workqueue("get

Re: [PATCH v4 1/2] usb: musb: dsps, debugfs files

2014-02-18 Thread Greg KH
On Tue, Feb 18, 2014 at 10:20:54AM -0600, Felipe Balbi wrote: > On Fri, Jan 17, 2014 at 10:22:35AM +0100, Markus Pargmann wrote: > > debugfs files to show the contents of important dsps registers. > > > > Signed-off-by: Markus Pargmann > > --- > > drivers/usb/musb/musb_dsps.c | 54 > > +

Re: [EHCI Debug Port] Linux fails to setup EHCI debug port

2014-02-18 Thread Greg KH
On Tue, Feb 18, 2014 at 02:46:00PM +0800, Lu, Baolu wrote: > Hi list, > > Linux kernel (3.12.8) fails to setup EHCI debug port on my Sandy Bridge > server. This seems to be a normal thing as I tried on other machines and got > the same result. Do you have a EHCI debug connector to attach to it?

Re: [EHCI Debug Port] Linux fails to setup EHCI debug port

2014-02-18 Thread Felipe Balbi
On Tue, Feb 18, 2014 at 09:01:29AM -0800, Greg KH wrote: > On Tue, Feb 18, 2014 at 02:46:00PM +0800, Lu, Baolu wrote: > > Hi list, > > > > Linux kernel (3.12.8) fails to setup EHCI debug port on my Sandy Bridge > > server. This seems to be a normal thing as I tried on other machines and got > > th

Re: [PATCH v4 1/2] usb: musb: dsps, debugfs files

2014-02-18 Thread Felipe Balbi
On Tue, Feb 18, 2014 at 08:59:11AM -0800, Greg KH wrote: > On Tue, Feb 18, 2014 at 10:20:54AM -0600, Felipe Balbi wrote: > > On Fri, Jan 17, 2014 at 10:22:35AM +0100, Markus Pargmann wrote: > > > debugfs files to show the contents of important dsps registers. > > > > > > Signed-off-by: Markus Parg

Re: [PATCH v2 2/3] usb: chipidea: msm: Add device tree support

2014-02-18 Thread Ivan T. Ivanov
Hi, On Tue, 2014-02-18 at 20:53 +0300, Sergei Shtylyov wrote: > Hello. > > On 02/18/2014 04:21 PM, Ivan T. Ivanov wrote: > > > From: "Ivan T. Ivanov" > > > Allows controller to be specified via device tree. > > Pass PHY phandle specified in DT to core driver. > > > Signed-off-by: Ivan T. I

Re: [PATCH v2 2/3] usb: chipidea: msm: Add device tree support

2014-02-18 Thread Ivan T. Ivanov
On Tue, 2014-02-18 at 08:08 -0600, Josh Cartwright wrote: > Hey Ivan- > > Nit below. > > On Tue, Feb 18, 2014 at 03:21:20PM +0200, Ivan T. Ivanov wrote: > > > > +static struct of_device_id msm_ci_dt_match[] = { > > const? > Thanks, will do. Regards, Ivan > > + { .compatible = "qcom,ci-

Re: [PATCH net-next 07/14] r8152: combine PHY reset with set_speed

2014-02-18 Thread Florian Fainelli
Hi Hayes, 2014-02-18 5:49 GMT-08:00 Hayes Wang : > PHY reset is necessary after some hw settings. However, it would > cause the linking down, and so does the set_speed function. Combine > the PHY reset with set_speed function. That could reduce the frequency > of linking down and accessing the PHY

Re: [PATCH] usb: musb: correct use of schedule_delayed_work()

2014-02-18 Thread Daniel Mack
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/18/2014 05:44 PM, Felipe Balbi wrote: > On Tue, Feb 18, 2014 at 05:41:12PM +0100, Daniel Mack wrote: >> On 02/18/2014 05:33 PM, Felipe Balbi wrote: >>> On Wed, Feb 05, 2014 at 03:34:18PM +0100, Daniel Mack wrote: schedule_delayed_work() take

Re: [PATCH] usb: musb: correct use of schedule_delayed_work()

2014-02-18 Thread Felipe Balbi
On Tue, Feb 18, 2014 at 06:22:57PM +0100, Daniel Mack wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 02/18/2014 05:44 PM, Felipe Balbi wrote: > > On Tue, Feb 18, 2014 at 05:41:12PM +0100, Daniel Mack wrote: > >> On 02/18/2014 05:33 PM, Felipe Balbi wrote: > >>> On Wed, Feb 05, 201

Re: [PATCH v4 1/2] usb: musb: dsps, debugfs files

2014-02-18 Thread Greg KH
On Tue, Feb 18, 2014 at 11:03:35AM -0600, Felipe Balbi wrote: > On Tue, Feb 18, 2014 at 08:59:11AM -0800, Greg KH wrote: > > On Tue, Feb 18, 2014 at 10:20:54AM -0600, Felipe Balbi wrote: > > > On Fri, Jan 17, 2014 at 10:22:35AM +0100, Markus Pargmann wrote: > > > > debugfs files to show the content

Re: [PATCH v2 2/3] usb: chipidea: msm: Add device tree support

2014-02-18 Thread Sergei Shtylyov
On 02/18/2014 08:14 PM, Ivan T. Ivanov wrote: From: "Ivan T. Ivanov" Allows controller to be specified via device tree. Pass PHY phandle specified in DT to core driver. Signed-off-by: Ivan T. Ivanov --- drivers/usb/chipidea/ci_hdrc_msm.c | 23 ++- 1 file change

Re: USB 3380 using net2280 driver

2014-02-18 Thread Amit Uttamchandani
On Tue, Feb 18, 2014 at 07:55:13AM -0800, Kevin Cernekee wrote: > On Tue, Feb 18, 2014 at 7:12 AM, Felipe Balbi wrote: > > On Mon, Feb 17, 2014 at 04:43:11PM -0800, Amit Uttamchandani wrote: > >> I was looking at the changes for net2280.c and saw your name come up in > >> a few of the more recent

Re: [PATCH v4 1/2] usb: musb: dsps, debugfs files

2014-02-18 Thread Felipe Balbi
Hi, On Tue, Feb 18, 2014 at 09:30:21AM -0800, Greg KH wrote: > > > > > +static int dsps_musb_dbg_init(struct musb *musb, struct dsps_glue > > > > > *glue) > > > > > +{ > > > > > + struct dentry *root; > > > > > + struct dentry *file; > > > > > + char buf[128]; > > > > > + > > > > > +

Re: [PATCH v2] usb/xhci: fix compilation warning when !CONFIG_PCI && !CONFIG_PM

2014-02-18 Thread David Cohen
Hi Sarah, On Mon, Jan 06, 2014 at 07:02:19PM -0800, David Cohen wrote: > When CONFIG_PCI and CONFIG_PM are not selected, xhci.c gets this > warning: > drivers/usb/host/xhci.c:409:13: warning: ‘xhci_msix_sync_irqs’ defined > but not used [-Wunused-function] > > It happens due to lack of __maybe_un

Re: [PATCH v2] usb/xhci: fix compilation warning when !CONFIG_PCI && !CONFIG_PM

2014-02-18 Thread Felipe Balbi
On Tue, Feb 18, 2014 at 10:00:30AM -0800, David Cohen wrote: > Hi Sarah, > > On Mon, Jan 06, 2014 at 07:02:19PM -0800, David Cohen wrote: > > When CONFIG_PCI and CONFIG_PM are not selected, xhci.c gets this > > warning: > > drivers/usb/host/xhci.c:409:13: warning: ‘xhci_msix_sync_irqs’ defined > >

Re: [RESEND] [PATCH] xhci: Switch Intel Lynx Point ports to EHCI on shutdown.

2014-02-18 Thread Sarah Sharp
Sorry for the delay in reviewing this. It helps me if you don't make the patch in-reply-to a months old thread. :) I'll take a look at this shortly. Sarah Sharp On Tue, Feb 18, 2014 at 09:42:39AM +0200, Denis Turischev wrote: > The same issue like with Panther Point chipsets. If the USB ports a

Re: [PATCH v2] usb/xhci: fix compilation warning when !CONFIG_PCI && !CONFIG_PM

2014-02-18 Thread David Cohen
On Tue, Feb 18, 2014 at 12:47:41PM -0600, Felipe Balbi wrote: > On Tue, Feb 18, 2014 at 10:00:30AM -0800, David Cohen wrote: > > Hi Sarah, > > > > On Mon, Jan 06, 2014 at 07:02:19PM -0800, David Cohen wrote: > > > When CONFIG_PCI and CONFIG_PM are not selected, xhci.c gets this > > > warning: > >

Re: [OPW] USB subsystem questions

2014-02-18 Thread Valentina Manea
Hi, On Sun, Feb 16, 2014 at 12:42 AM, Alan Stern wrote: > > That's true when it is invoked from userspace. It can also be invoked > directly by a kernel driver; in that case no file is needed. > I managed to get it working but I think what I did is rather flawed. The problem is where I get tha

Re: [PATCH v4 13/14] usb: force warm reset to break resume livelock

2014-02-18 Thread Sarah Sharp
On Tue, Feb 11, 2014 at 07:29:40PM -0800, Julius Werner wrote: > >> I believe I am seeing a "polling livelock" scenario as described by Julius. > > > > Julius was talking about what happens when the host controller itself > > gets reset (and therefore remembers nothing about any device) whereas > >

Re: v3.14-rc2+ WARNING: CPU: 0 PID: 24108 at fs/sysfs/group.c:216 sysfs_remove_group+0xa3/0xb0()

2014-02-18 Thread Alan Stern
On Tue, 18 Feb 2014, [windows-1252] Michal �mucr wrote: > On 17.2.2014 20:48, Alan Stern wrote: > > > > This isn't a USB problem. > > > Hello, > > I'm experiencing very similar messages after every disconnection of USB > soundcard (snd-usb-audio module). During searching for other similar > occ

Re: [PATCH] usb: mark *hci_pci irqs with IRQF_NO_THREAD

2014-02-18 Thread Alan Stern
On Tue, 18 Feb 2014, Stanislaw Gruszka wrote: > On Mon, Feb 17, 2014 at 09:48:14AM -0500, Alan Stern wrote: > > On Mon, 17 Feb 2014, Stanislaw Gruszka wrote: > > > > > There is threadirqs kenel boot option which allow to force interrupt > > > routines to be performed as thread. > > > > > > USB

Re: [BUG] FL1009: xHCI host not responding to stop endpoint command.

2014-02-18 Thread Arnaud Ebalard
Hi Thomas, Thomas Petazzoni writes: > Dear Arnaud Ebalard, > > On Sat, 18 Jan 2014 22:49:17 +0100, Arnaud Ebalard wrote: > >> I started suspecting the introduction of MSI support in Marvell PCIe >> host controller driver (FL1009 is on the PCIe bus) and compiled a >> a 3.13.0-rc8 w/ CONFIG_PCI_MS

Re: [PATCH v4 13/14] usb: force warm reset to break resume livelock

2014-02-18 Thread Felipe Balbi
Hi, + Paul as he might have better details about the Synopsys core host-side implementation On Tue, Feb 18, 2014 at 12:42:53PM -0800, Sarah Sharp wrote: > On Tue, Feb 11, 2014 at 07:29:40PM -0800, Julius Werner wrote: > > >> I believe I am seeing a "polling livelock" scenario as described by > >

RE: [PATCH 0/7] usb: dwc2/s3c-hsotg: Combine drivers into a single DRD

2014-02-18 Thread Dinh Nguyen
On Fri, 2014-02-14 at 22:50 +, Paul Zimmerman wrote: > > From: Jingoo Han [mailto:jg1@samsung.com] > > Sent: Thursday, February 13, 2014 11:46 PM > > > > On Friday, February 14, 2014 2:27 PM, Peter Chen wrote: > > > On Thu, Feb 13, 2014 at 03:10:40PM -0600, dingu...@altera.com wrote: > > >

Re: [BUG] FL1009: xHCI host not responding to stop endpoint command.

2014-02-18 Thread Thomas Petazzoni
Dear Arnaud Ebalard, On Tue, 18 Feb 2014 21:54:31 +0100, Arnaud Ebalard wrote: > > I finally got some idea: your kernel 3.13-rc7 lacks a very important > > fix we did in the irqchip driver MSI handling. You really need to have > > http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/com

Re: [PATCH 0/7] usb: dwc2/s3c-hsotg: Combine drivers into a single DRD

2014-02-18 Thread Felipe Balbi
Hi, On Tue, Feb 18, 2014 at 03:14:25PM -0600, Dinh Nguyen wrote: > On Fri, 2014-02-14 at 22:50 +, Paul Zimmerman wrote: > > > From: Jingoo Han [mailto:jg1@samsung.com] > > > Sent: Thursday, February 13, 2014 11:46 PM > > > > > > On Friday, February 14, 2014 2:27 PM, Peter Chen wrote: > >

Re: [PATCH v2 2/3] usb: chipidea: msm: Add device tree support

2014-02-18 Thread Courtney Cavin
On Tue, Feb 18, 2014 at 07:31:55PM +0100, Sergei Shtylyov wrote: > On 02/18/2014 08:14 PM, Ivan T. Ivanov wrote: > > >>> From: "Ivan T. Ivanov" > > >>> Allows controller to be specified via device tree. > >>> Pass PHY phandle specified in DT to core driver. > > >>> Signed-off-by: Ivan T. Ivanov

RE: [PATCH 0/7] usb: dwc2/s3c-hsotg: Combine drivers into a single DRD

2014-02-18 Thread Paul Zimmerman
> From: Dinh Nguyen [mailto:dingu...@altera.com] > Sent: Tuesday, February 18, 2014 1:14 PM > > On Fri, 2014-02-14 at 22:50 +, Paul Zimmerman wrote: > > > From: Jingoo Han [mailto:jg1@samsung.com] > > > Sent: Thursday, February 13, 2014 11:46 PM > > > > > > On Friday, February 14, 2014 2:2

Re: [PATCH net-next 00/14] r8152: improvement and new features

2014-02-18 Thread David Miller
From: Hayes Wang Date: Tue, 18 Feb 2014 21:48:57 +0800 > Change some flows or behavior to improve the efficiency or make the > code readable. Besides, support WOL and runtime suspend. Series applied, but as Florian mentioned you should seriously consider converting this driver to use phylib. --

Re: v3.14-rc2+ WARNING: CPU: 0 PID: 24108 at fs/sysfs/group.c:216 sysfs_remove_group+0xa3/0xb0()

2014-02-18 Thread Michal Šmucr
On 18. 2. 2014 21:51, Alan Stern wrote: On Tue, 18 Feb 2014, [windows-1252] Michal �mucr wrote: On 17.2.2014 20:48, Alan Stern wrote: This isn't a USB problem. Hello, I'm experiencing very similar messages after every disconnection of USB soundcard (snd-usb-audio module). During searching

RE: [PATCH v4 13/14] usb: force warm reset to break resume livelock

2014-02-18 Thread Paul Zimmerman
> From: Felipe Balbi [mailto:ba...@ti.com] > Sent: Tuesday, February 18, 2014 1:05 PM > > Hi, > > + Paul as he might have better details about the Synopsys core host-side > implementation > > On Tue, Feb 18, 2014 at 12:42:53PM -0800, Sarah Sharp wrote: > > On Tue, Feb 11, 2014 at 07:29:40PM -080

Re: [PATCH v4 13/14] usb: force warm reset to break resume livelock

2014-02-18 Thread Felipe Balbi
On Tue, Feb 18, 2014 at 09:54:59PM +, Paul Zimmerman wrote: > > From: Felipe Balbi [mailto:ba...@ti.com] > > Sent: Tuesday, February 18, 2014 1:05 PM > > > > Hi, > > > > + Paul as he might have better details about the Synopsys core host-side > > implementation > > > > On Tue, Feb 18, 2014 a

Re: [PATCH 05/25] libusbg: Update strings only when writting US English strings.

2014-02-18 Thread Sergei Shtylyov
Hello. On 02/17/2014 09:53 PM, Krzysztof Opasiak wrote: Strings in current verison of library are hardcoded to US English. Functions which set strings are generic and allow to set other languages, but internal library structures should be update only when setting US English strings. Signed-o

Re: [PATCH 05/25] libusbg: Update strings only when writting US English strings.

2014-02-18 Thread Sergei Shtylyov
Hello. On 02/19/2014 02:07 AM, Sergei Shtylyov wrote: Strings in current verison of library are hardcoded to US English. Functions which set strings are generic and allow to set other languages, but internal library structures should be update only when setting US English strings. Signed-off

Re: [PATCH 15/25] libusbg: Add getter for config name.

2014-02-18 Thread Sergei Shtylyov
Hello. On 02/17/2014 09:53 PM, Krzysztof Opasiak wrote: Add usbg_get_config_name() and usbg_get_config_name_len() to avoid direct config structure members access. Signed-off-by: Krzysztof Opasiak --- include/usbg/usbg.h | 16 src/usbg.c | 10 ++ 2 f

Re: [PATCH v2 2/3] usb: chipidea: msm: Add device tree support

2014-02-18 Thread Sergei Shtylyov
Hello. On 02/19/2014 12:34 AM, Courtney Cavin wrote: From: "Ivan T. Ivanov" Allows controller to be specified via device tree. Pass PHY phandle specified in DT to core driver. Signed-off-by: Ivan T. Ivanov --- drivers/usb/chipidea/ci_hdrc_msm.c | 23 ++- 1 f

Re: [PATCH v4 13/14] usb: force warm reset to break resume livelock

2014-02-18 Thread Julius Werner
> Julius, are you sure the Synopsys host will actually power off the > ports? The Intel hosts need some special ACPI methods, so I'm not sure > if Dan's issue with ports after power on could even be seen on the > Synopsys host. > > The Synopsys issue (as I remember it, please correct me if I'm wro

Re: [PATCH v4 13/14] usb: force warm reset to break resume livelock

2014-02-18 Thread Dan Williams
On Tue, Feb 18, 2014 at 2:40 PM, Julius Werner wrote: >> Can you take a look at it, and see if it would address your issue? I >> think it will catch the case where we transition from SS.Inactive -> >> RxDetect -> Polling. > > I don't think that's targeting the same problem. Hans seems to be > des

Re: [PATCH] usb: mark *hci_pci irqs with IRQF_NO_THREAD

2014-02-18 Thread Thomas Gleixner
On Mon, 17 Feb 2014, Stanislaw Gruszka wrote: > There is threadirqs kenel boot option which allow to force interrupt > routines to be performed as thread. > > USB irq routines use spin_lock(*hci->lock) variant without disabling > interrupts, what is perfectly fine, but that can cause deadlock wh

Re: [PATCH net-next 12/14] r8152: replace netif_rx with netif_receive_skb

2014-02-18 Thread Francois Romieu
Hayes Wang : > Replace netif_rx with netif_receive_skb to avoid disabling irq frequently > for increasing the efficiency. read_bulk_callback is issued in irq context. It could thus use plain spin_lock / spin_unlock instead of the irq disabling version. -- Ueimor -- To unsubscribe from this list

Re: [PATCH v4 13/14] usb: force warm reset to break resume livelock

2014-02-18 Thread Julius Werner
>> We don't need to change hub_port_debounce() right away... that was >> just an additional suggestion to make things more efficient for >> SuperSpeed devices in general. I think for now (in order to solve >> Dan's problem), it would be best if he just calls hub_port_debounce() >> in usb_port_runti

Re: [PATCH v9 01/12] usb: doc: phy-mxs: Add more compatible strings

2014-02-18 Thread Shawn Guo
On Tue, Feb 18, 2014 at 10:49:24AM -0600, Felipe Balbi wrote: > On Fri, Dec 27, 2013 at 10:38:30AM +0800, Peter Chen wrote: > > Add "fsl,imx6q-usbphy" for imx6dq and imx6dl, add > > "fsl,imx6sl-usbphy" for imx6sl. > > > > Signed-off-by: Peter Chen > > anybody from DT to give me an Acked-by ? Un

Re: [PATCH 2/2] USB: at91: using USBA_NR_DMAS for DMA channels

2014-02-18 Thread Bo Shen
Hi Felipe Balbi, On 02/19/2014 12:19 AM, Felipe Balbi wrote: On Fri, Jan 17, 2014 at 10:59:25AM +0800, Bo Shen wrote: When the SoC is earlier than sama5d3 SoC, which have the same number endpoints and DMAs. However for sama5d3 SoC, it has different number for endpoints and DMAs. So, define USBA

  1   2   >