At Sat, 11 Jan 2014 11:08:39 +0100,
wrote:
>
> FWD:
>
> Any news to the snd-usb-audio issue?
>
> Thanks, Bernhard
>
> Old Message:
> -
> I have tested the patch with kernel 3.12.0 with suspend and hibernate, and
> the problem is gone.
>
> No messages "no reset_resume for driver s
On Sun, 2014-01-12 at 14:12 +0400, Sergey Galanov wrote:
> Hi.
> My hdd docking station (AgeStar 3UBT with usb3 support) stopped
> working after upgrade to linux 3.12.3. It worked fine in 3.12.0 and
> before. I can't point to more specific version because it's hard to
> find old packages for my dis
> Yes, it can, if you look at the comment in usb_match_id(), we have to
> check for this there.
Geez, /me blind... Will send a patch.
Thanks!
signature.asc
Description: Digital signature
When implementing the RefId feature, it was missed that id_tables can be
NULL under special circumstances. Bail out in that case.
Signed-off-by: Wolfram Sang
---
drivers/usb/core/driver.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/usb/core/driver.c b/drivers/usb/core/driver.c
From: Bjørn Mork
> Thomas Kear writes:
>
> > On Sat, Jan 11, 2014 at 11:09 AM, Bjrn Mork wrote:
> >> But looking at the code I think I found and obvious miss in the SG list
> >> initialisation. I'll post a proposed fix for that. Would be good if
> >> someone was able to test it.
> >
> > I've b
David Laight writes:
> The patch you submitted is wrong.
> Whoever wrote the sg interface was on crack.
> The 'last' marker needs moving as well.
I'm afraid I don't understand what you meant by this.
sg_init_table() set the 'last' marker. AFAICS, you don't need to change
it unless you want to
From: Bjørn Mork
> David Laight writes:
>
> > The patch you submitted is wrong.
> > Whoever wrote the sg interface was on crack.
> > The 'last' marker needs moving as well.
>
> I'm afraid I don't understand what you meant by this.
>
> sg_init_table() set the 'last' marker. AFAICS, you don't ne
David Laight writes:
> From: Bjørn Mork
>> David Laight writes:
>>
>> > The patch you submitted is wrong.
>> > Whoever wrote the sg interface was on crack.
>> > The 'last' marker needs moving as well.
>>
>> I'm afraid I don't understand what you meant by this.
>>
>> sg_init_table() set the 'la
This is a short series of bugfixes for FunctionFS.
The first patch fixes the problem found by Dan Carpenter (or his automatic
tool?) - if ffs_dev is checked for being NULL it should be done so
consistently throughout the ffs_release_dev().
ffs_alloc_dev() and ffs_free_dev() are used only in f_fs.
Consistently prefix function name with underscore if the function has to
be called with ffs_lock taken.
Signed-off-by: Andrzej Pietrasiewicz
---
drivers/usb/gadget/f_fs.c | 30 +++---
1 files changed, 15 insertions(+), 15 deletions(-)
diff --git a/drivers/usb/gadget/f_
ffs_alloc_dev and ffs_free_dev are used only in f_fs.c,
so make them static.
Signed-off-by: Andrzej Pietrasiewicz
---
drivers/usb/gadget/f_fs.c |6 --
drivers/usb/gadget/u_fs.h |2 --
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/gadget/f_fs.c b/drivers/u
ffs_dev->ffs_release_dev_callback should be accessed only if ffs_dev
is not NULL.
Additionally whitespace error correction.
Signed-off-by: Andrzej Pietrasiewicz
---
drivers/usb/gadget/f_fs.c | 11 ++-
1 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/usb/gadget/f_
From: Bjørn Mork [mailto:bj...@mork.no]
> David Laight writes:
> > From: Bjørn Mork
> >> David Laight writes:
> >>
> >> > The patch you submitted is wrong.
> >> > Whoever wrote the sg interface was on crack.
> >> > The 'last' marker needs moving as well.
> >>
> >> I'm afraid I don't understand wh
To create a global command queue we need to fill a command structure
for each entry on the command ring.
We start by requiring xhci_configure_endpoint() to be called with
a proper command structure. Functions xhci_check_maxpacket and
xhci_check_bandwith
that called xhci_configure_endpoint without
Prepare for the global command ring by using command structures
internally in functions calling xhci_queue_stop_endpoint()
Signed-off-by: Mathias Nyman
---
drivers/usb/host/xhci-hub.c | 14 --
drivers/usb/host/xhci.c | 3 +++
2 files changed, 15 insertions(+), 2 deletions(-)
di
Remove the per-device command list and handle_cmd_in_cmd_wait_list()
and use the completion and status variables found in the
command structure in the global command list.
Signed-off-by: Mathias Nyman
---
drivers/usb/host/xhci-hub.c | 11 --
drivers/usb/host/xhci-mem.c | 1 -
drivers/usb/
Use one timer to control command timeout.
start/kick the timer every time a command is completed and a
new command is waiting, or a new command is added to a empty list.
If the timer runs out, then tag the current command as "aborted", and
start the xhci command abortion process.
Previously each
Create a list to store command structures, add a strucure to it every time
a command is submitted, and remove it from the list once we get a
command completion event matching the command.
Signed-off-by: Mathias Nyman
---
drivers/usb/host/xhci-mem.c | 8
drivers/usb/host/xhci-ring.c |
Require each queued command to have a command structure.
We store the command trb pointer in the structure when queuing it,
making the find_next_enqueue() function obsolete.
Don't free the command strucures right away after sending the commands,
We will free the commands when we receive a "command
Prepare for the global command ring by using command structures
internally in functions calling xhci_queue_reset_ep()
Signed-off-by: Mathias Nyman
---
drivers/usb/host/xhci-ring.c | 5 +
drivers/usb/host/xhci.c | 6 ++
2 files changed, 11 insertions(+)
diff --git a/drivers/usb/host
This is an attempt to re-work and solve the issues in xhci command
queue management that Sarah has descibed earlier:
Right now, the command management in the xHCI driver is rather ad-hock.
Different parts of the driver all submit commands, including interrupt
handling routines, functions calle
Preparing for the global command queue by changing functions calling
xhci_queue_slot_control() to internally use command structures
Signed-off-by: Mathias Nyman
---
drivers/usb/host/xhci.c | 34 +-
1 file changed, 29 insertions(+), 5 deletions(-)
diff --git a/dri
Prepare for the global command ring by using command structures
internally in functions calling xhci_queue_new_dequeue_state()
Signed-off-by: Mathias Nyman
---
drivers/usb/host/xhci-ring.c | 3 +++
drivers/usb/host/xhci.c | 6 ++
2 files changed, 9 insertions(+)
diff --git a/drivers/us
Preparing for the global command queue by using command strucure
in xhci_address_device
Signed-off-by: Mathias Nyman
---
drivers/usb/host/xhci.c | 22 +-
1 file changed, 17 insertions(+), 5 deletions(-)
diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
index 5e6
Hello.
On 13-01-2014 17:26, Andrzej Pietrasiewicz wrote:
ffs_dev->ffs_release_dev_callback should be accessed only if ffs_dev
is not NULL.
Additionally whitespace error correction.
Signed-off-by: Andrzej Pietrasiewicz
---
drivers/usb/gadget/f_fs.c | 11 ++-
1 files changed,
ffs_alloc_dev and ffs_free_dev are used only in f_fs.c,
so make them static.
Signed-off-by: Andrzej Pietrasiewicz
---
drivers/usb/gadget/f_fs.c |6 --
drivers/usb/gadget/u_fs.h |2 --
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/gadget/f_fs.c b/drivers/u
Consistently prefix function name with underscore if the function has to
be called with ffs_lock taken.
Signed-off-by: Andrzej Pietrasiewicz
---
drivers/usb/gadget/f_fs.c | 30 +++---
1 files changed, 15 insertions(+), 15 deletions(-)
diff --git a/drivers/usb/gadget/f_
This is a short series of bugfixes for FunctionFS.
The first patch fixes the problem found by Dan Carpenter (or his automatic
tool?) - if ffs_dev is checked for being NULL it should be done so
consistently throughout the ffs_release_dev().
The second patch is a code style cleanup.
ffs_alloc_dev(
ffs_dev->ffs_release_dev_callback should be accessed only if ffs_dev
is not NULL.
Signed-off-by: Andrzej Pietrasiewicz
---
drivers/usb/gadget/f_fs.c |9 +
1 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/gadget/f_fs.c b/drivers/usb/gadget/f_fs.c
index 306a2b
Remove trailing whitespace
Signed-off-by: Andrzej Pietrasiewicz
---
drivers/usb/gadget/f_fs.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/usb/gadget/f_fs.c b/drivers/usb/gadget/f_fs.c
index 78333f0..f0c657d 100644
--- a/drivers/usb/gadget/f_fs.c
+++ b/driver
Hi,
On 01/12/2014 02:04 PM, Tomasz Figa wrote:
Hi,
[Cc'ing DT maintainers directly]
Alan Stern Wrote:
I prefer the -generic option, although generic- is equally fine - Having
said that, I don't really care if it's called mmio either (although this
does seem less 'descriptive').
I can d
On Mon, 13 Jan 2014, Hans de Goede wrote:
> I agree that usb-Xhci would be the best compatible strings to use.
>
> The problem with usb-ehci is that there already is a ppc specific driver
> binding to that
> compatible string, doing various ppc specific controller initialization.
>
> Thinking m
Some co-workers of mine bought Samsung laptops that had mostly usb3 ports.
Those ports did not resume correctly (the driver would timeout communicating
and fail). This led to frustration as suspend/resume is a common use for
laptops.
Poking around, I applied the reset on resume quirk to this chip
On Mon, Jan 13 2014, Andrzej Pietrasiewicz wrote:
> Remove trailing whitespace
>
> Signed-off-by: Andrzej Pietrasiewicz
Acked-by: Michal Nazarewicz
> ---
> drivers/usb/gadget/f_fs.c |2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/usb/gadget/f_fs.c b/drive
On Mon, Jan 13 2014, Andrzej Pietrasiewicz wrote:
> ffs_dev->ffs_release_dev_callback should be accessed only if ffs_dev
> is not NULL.
>
> Signed-off-by: Andrzej Pietrasiewicz
Acked-by: Michal Nazarewicz
> ---
> drivers/usb/gadget/f_fs.c |9 +
> 1 files changed, 5 insertions(+), 4
On Mon, Jan 13 2014, Andrzej Pietrasiewicz wrote:
> Consistently prefix function name with underscore if the function has to
> be called with ffs_lock taken.
>
> Signed-off-by: Andrzej Pietrasiewicz
Acked-by: Michal Nazarewicz
> ---
> drivers/usb/gadget/f_fs.c | 30 +++---
On Mon, Jan 13 2014, Andrzej Pietrasiewicz wrote:
> ffs_alloc_dev and ffs_free_dev are used only in f_fs.c,
> so make them static.
>
> Signed-off-by: Andrzej Pietrasiewicz
Acked-by: Michal Nazarewicz
> ---
> drivers/usb/gadget/f_fs.c |6 --
> drivers/usb/gadget/u_fs.h |2 --
> 2 fi
From: Mathias Nyman
> This is an attempt to re-work and solve the issues in xhci command
> queue management that Sarah has descibed earlier:
>
> Right now, the command management in the xHCI driver is rather ad-hock.
> Different parts of the driver all submit commands, including interrupt
> handli
On Tue, Jan 07, 2014 at 12:29:28PM -0800, Dan Williams wrote:
> Alan, Sarah,
>
> This revision boils down the port power control fixes to the
> bare minimum to get the implementation functional and reliable.
> Data structure changes are constrained to struct usb_port and
> gone are the clumsier at
On Mon, Jan 13, 2014 at 11:01 AM, Sarah Sharp
wrote:
> On Tue, Jan 07, 2014 at 12:29:28PM -0800, Dan Williams wrote:
>> Alan, Sarah,
>>
>> This revision boils down the port power control fixes to the
>> bare minimum to get the implementation functional and reliable.
>> Data structure changes are c
From: Hayes Wang
Date: Thu, 9 Jan 2014 14:50:32 +0800
> Remove the limitation that the ecm and r8152 drivers couldn't coexist.
> Besides, add the feature to support the vendor mode only. This let
> someone who doesn't want to use ecm driver easy to use the vendor
> driver without creating the ude
Hi all,
I have an EG20T-based board and have some issues with performance on the
USB device interface.
I made a libusb test program (using the async interface)[0] to read data
from the EG20T's USB device port which has the gadget zero source/sink
function bound. In theory, one would hope thi
On Sat, Jan 11, 2014 at 06:01:48PM +0400, Alexander Shiyan wrote:
> Суббота, 11 января 2014, 13:55 +01:00 от Uwe Kleine-König
> :
> > On Mon, Nov 11, 2013 at 11:09:16AM +0400, Alexander Shiyan wrote:
> > > Hello.
> > >
> > > > On Sunday, November 10, 2013 03:18 PM, Alexander Shiyan wrote:
>
The DWC2 driver should now be in good enough shape to move out of
staging. I have stress tested it overnight on RPI running mass
storage and Ethernet transfers in parallel, and for several days
on our proprietary PCI-based platform.
Signed-off-by: Paul Zimmerman
---
Greg,
I believe I have addres
A couple comments below.
On Tue, Jan 07, 2014 at 12:30:21PM -0800, Dan Williams wrote:
> From: Lan Tianyu
>
> describe the mechanisms for controlling port power policy and
> discovering the port power state.
>
> Cc: Oliver Neukum
> Signed-off-by: Lan Tianyu
> Signed-off-by: Sarah Sharp
I th
On Mon, 13 Jan 2014, Alan Ott wrote:
> Hi all,
>
> I have an EG20T-based board and have some issues with performance on the
> USB device interface.
>
> I made a libusb test program (using the async interface)[0] to read data
> from the EG20T's USB device port which has the gadget zero source/s
The DWC2 driver should now be in good enough shape to move out of
staging. I have stress tested it overnight on RPI running mass
storage and Ethernet transfers in parallel, and for several days
on our proprietary PCI-based platform.
Signed-off-by: Paul Zimmerman
---
v4: Also change directory path
On Mon, Jan 13, 2014 at 01:50:09PM -0800, Paul Zimmerman wrote:
> The DWC2 driver should now be in good enough shape to move out of
> staging. I have stress tested it overnight on RPI running mass
> storage and Ethernet transfers in parallel, and for several days
> on our proprietary PCI-based plat
> From: Greg KH [mailto:gre...@linuxfoundation.org]
> Sent: Monday, January 13, 2014 2:04 PM
>
> On Mon, Jan 13, 2014 at 01:50:09PM -0800, Paul Zimmerman wrote:
>> The DWC2 driver should now be in good enough shape to move out of
>> staging. I have stress tested it overnight on RPI running mass
>>
Toshiharu and Tomoya,
I sent the email below to linux-usb today in regards to some performance
issues I'm seeing with the EG20T (pch_udc) driver.
I appreciate any insight you may have.
Alan.
On 01/13/2014 03:20 PM, Alan Ott wrote:
Hi all,
I have an EG20T-based board and have some issues wi
Hi,
On Mon, Jan 13, 2014 at 03:20:31PM -0500, Alan Ott wrote:
> I have an EG20T-based board and have some issues with performance on
> the USB device interface.
I don't have that hardware but ...
> I made a libusb test program (using the async interface)[0] to read
> data from the EG20T's USB de
On 01/13/2014 05:11 PM, Felipe Balbi wrote:
160MBit/sec isn't terrible, but I hoped for better. A USB analyzer
shows 7 transactions happening quickly (with about 14us separating
them), but every 8th transaction, the EG20T will NAK between 20-80
times[1], losing 50-100us[2].
as Alan stated, this
On Mon, Jan 13, 2014 at 01:50:09PM -0800, Paul Zimmerman wrote:
> The DWC2 driver should now be in good enough shape to move out of
> staging. I have stress tested it overnight on RPI running mass
> storage and Ethernet transfers in parallel, and for several days
> on our proprietary PCI-based plat
Hi all,
And here is v5 of my ohci and ehci-platform clks, phy and dt support patch-set.
New since the last version is that the compatibility strings now are
"usb-ohci" and "usb-ehci", which should make everyone happy I hope.
Other then that there are no changes compared to v4.
Regards,
Hans
--
Currently ehci-platform is only used in combination with devicetree when used
with some Via socs. By extending it to (optionally) get clks and a phy from
devicetree, and enabling / disabling those on power_on / off, it can be used
more generically. Specifically after this commit it can be used for
Add support for ohci-platform instantiation from devicetree, including
optionally getting clks and a phy from devicetree, and enabling / disabling
those on power_on / off.
This should allow using ohci-platform from devicetree in various cases.
Specifically after this commit it can be used for the
On Tue, Jan 07, 2014 at 12:29:44PM -0800, Dan Williams wrote:
> ACPI identifies peer ports by setting their 'group_token' and 'group_position'
> _PLD data to the same value. If a platform has tier mismatch (see Appendix D
> figure 131 in the xhci spec), ACPI can override the default peer port
> as
Hello together,
i will close this bug at Debian now.
After the last update this error seems to disappear in Debian stable.
http://ftp.debian.org/debian/dists/wheezy/ChangeLog
USB: pl2303: fix device initialisation at open
The source for this patch can be found here:
http://www.spinics.net/lists
On Mon, Jan 13, 2014 at 02:56:57PM -0800, Sarah Sharp wrote:
> On Tue, Jan 07, 2014 at 12:29:44PM -0800, Dan Williams wrote:
> > ACPI identifies peer ports by setting their 'group_token' and
> > 'group_position'
> > _PLD data to the same value. If a platform has tier mismatch (see Appendix
> > D
Now that the DWC2 driver has been moved to drivers/usb, move its
bindings doc to the correct place
Cc: Rob Herring
Signed-off-by: Paul Zimmerman
---
Greg,
I missed this file when moving the rest of the dwc2 files.
Documentation/devicetree/bindings/{staging => usb}/dwc2.txt | 0
1 file changed,
On Mon, Jan 13, 2014 at 10:49:49AM -0500, Don Zickus wrote:
> Some co-workers of mine bought Samsung laptops that had mostly usb3 ports.
> Those ports did not resume correctly (the driver would timeout communicating
> and fail). This led to frustration as suspend/resume is a common use for
> lapto
On 01/09/2014 03:50 PM, Sarah Sharp wrote:
>>> On Tue, Jan 07, 2014 at 03:57:00PM -0800, walt wrote:
>>
>> I've wondered if my xhci problems might be caused by hardware quirks, and
>> wondering why I seem to be the only one who has this problem.
>>
>> Maybe I could "take one for the team" by buyin
On Mon, Jan 13, 2014 at 2:56 PM, Sarah Sharp
wrote:
> On Tue, Jan 07, 2014 at 12:29:44PM -0800, Dan Williams wrote:
>> ACPI identifies peer ports by setting their 'group_token' and
>> 'group_position'
>> _PLD data to the same value. If a platform has tier mismatch (see Appendix D
>> figure 131 i
On Sat, Jan 11, 2014 at 02:04:00AM +0100, Bjørn Mork wrote:
> This modifies the probing order so that any matching
> dynamic entry always will be used, even if the driver
> has a matching static entry.
>
> It is sometimes useful to dynamically update existing
> device entries. With the new ability
Hi all,
Given that 3.13 will be out in a few days, it's time to close my trees
for new patches until 3.14-rc1 is out.
Please feel free to send me patches for these trees, but note that I'll
be ignoring them until 3.14-rc1 is out, at which point in time I'll
start reviewing them again and applying
Dear friends,
So far, there has been no response to this issue report. I understand
this is not a help desk with guaranteed replies but the fact that there
was no response whatsoever is surprising to me.
I would like to at least kindly ask that someone looks at the traces and
tells me if thi
On Mon, 13 Jan 2014, Sarah Sharp wrote:
> On Mon, Jan 13, 2014 at 02:56:57PM -0800, Sarah Sharp wrote:
> > I haven't looked at this too closely, but what happens if:
> > - the USB 2.0 roothub is registered
> > - userspace immediately sets autosuspend_delay to zero and
> >pm_qos_no_port_powe
On Mon, 13 Jan 2014, Felipe Balbi wrote:
> Hi,
>
> On Mon, Jan 13, 2014 at 03:20:31PM -0500, Alan Ott wrote:
> > I have an EG20T-based board and have some issues with performance on
> > the USB device interface.
>
> I don't have that hardware but ...
>
> > I made a libusb test program (using th
Понедельник, 13 января 2014, 22:31 +01:00 от Uwe Kleine-König
:
> On Sat, Jan 11, 2014 at 06:01:48PM +0400, Alexander Shiyan wrote:
> > Суббота, 11 января 2014, 13:55 +01:00 от Uwe Kleine-König
> > :
> > > On Mon, Nov 11, 2013 at 11:09:16AM +0400, Alexander Shiyan wrote:
> > > > Hello.
> > > >
>
On Tuesday, January 14, 2014 11:30 AM, Alexander Shiyan wrote:
Понедельник, 13 января 2014, 22:31 +01:00 от Uwe Kleine-König
:
On Sat, Jan 11, 2014 at 06:01:48PM +0400, Alexander Shiyan wrote:
Суббота, 11 января 2014, 13:55 +01:00 от Uwe Kleine-König
:
On Mon, Nov 11, 2013 at 11:09:16AM +040
On 14/01/14 11:45, Hans de Goede wrote:
Currently ehci-platform is only used in combination with devicetree when used
with some Via socs. By extending it to (optionally) get clks and a phy from
devicetree, and enabling / disabling those on power_on / off, it can be used
more generically. Specific
On 01/13/2014 09:01 PM, Alan Stern wrote:
On Mon, 13 Jan 2014, Felipe Balbi wrote:
Hi,
On Mon, Jan 13, 2014 at 03:20:31PM -0500, Alan Ott wrote:
I have an EG20T-based board and have some issues with performance on
the USB device interface.
I don't have that hardware but ...
I made a libusb
Hi
I guess it is something to do with the buffer size of the gadget
driver. Could you please try change the buffer size to 16K and confirm
if the delay is shifting ? In this case your delay should be after 31
transfers...
===
66 static struct usb_zero_options gzero_options = {
67
On 01/14/2014 12:08 AM, Rajaram R wrote:
I guess it is something to do with the buffer size of the gadget
driver. Could you please try change the buffer size to 16K and confirm
if the delay is shifting ? In this case your delay should be after 31
transfers...
===
66 static struct u
On Tue, Jan 14, 2014 at 02:06:13PM +0800, Alan Ott wrote:
> On 01/14/2014 12:08 AM, Rajaram R wrote:
> > I guess it is something to do with the buffer size of the gadget
> > driver. Could you please try change the buffer size to 16K and confirm
> > if the delay is shifting ? In this case your delay
When s3c_hsotg_ep_sethalt() function is called for ep0 it should be stalled
in the same way that it is in s3c_hsotg_process_control() function, because
SET_HALT for ep0 is delayed response for setup request. Endpoint 0, if
halted, it doesn't need CLEAR_HALT because it clears "stalled" state
automat
76 matches
Mail list logo
