[PATCH] usb: core: bail out if user gives an unknown RefId when using new_id

2014-01-12 Thread Wolfram Sang
If users use the new RefId feature of new_id, give them an error message if they provided an unknown reference. That helps detecting typos. Signed-off-by: Wolfram Sang --- drivers/usb/core/driver.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/usb/core/driv

Re: [RFC 2/2] usb: core: allow a reference device for new_id

2014-01-12 Thread Wolfram Sang
> > I also wonder if we should return an error to the user in case we don't > > find a matching reference entry? It will otherwise be very difficult > > for the user to catch typos. > > Ah, yeah, that would be a good idea, Wofram, care to do an add-on patch > for that? Just sent. Another questi

Re: [RFC 2/2] usb: core: allow a reference device for new_id

2014-01-12 Thread Wolfram Sang
> > To be fair, Bjørn had this idea two years ago, but hesitated to > > implement it. I found his mail while implementing my idea, though. > > I did? Wow. I know I was looking at solutions to this problem, but I > didn't remember thinking about taking the device reference from > userspace. :)

Re: [PATCH v4 1/2] ohci-platform: Add support for devicetree instantiation

2014-01-12 Thread Hans de Goede
Hi, Thanks for the review. Note I did my best to ensure my patches would not break vt8500 support, but if you could run some tests with them that would be great. On 01/11/2014 09:37 AM, Tony Prisk wrote: On 11/01/14 11:46, Hans de Goede wrote: Add support for ohci-platform instantiation from d

Re: [PATCH v4 0/2] ohci and ehci-platform clks, phy and dt support

2014-01-12 Thread Tomasz Figa
Hi, [Cc'ing DT maintainers directly] On 12.01.2014 04:04, Tony Prisk wrote: On 12/01/14 11:30, Alan Stern wrote: On Fri, 10 Jan 2014, Hans de Goede wrote: Hi, On 01/11/2014 12:50 AM, Sergei Shtylyov wrote: Hello. On 01/11/2014 01:46 AM, Hans de Goede wrote: Here is v4 of my ohci and ehc

Re: segate external USB3.0 HD cannot work

2014-01-12 Thread yoma sophian
hi: 2014/1/12 yoma sophian : > hi Oliver > > 2014/1/12 Oliver Neukum : >> On Sat, 2014-01-11 at 18:17 +0800, yoma sophian wrote: >>> hi all: >>> I got one segate external usb3.0 HD. >>> When I plug in that device, I will get below error message repeatedly: >>> >>> [ 432.191560] usb 4-1: Set SEL fo

Re: [RFC 2/2] usb: core: allow a reference device for new_id

2014-01-12 Thread Greg KH
On Sun, Jan 12, 2014 at 10:11:54AM +0100, Wolfram Sang wrote: > > > > I also wonder if we should return an error to the user in case we don't > > > find a matching reference entry? It will otherwise be very difficult > > > for the user to catch typos. > > > > Ah, yeah, that would be a good idea,

[BUG] FL1009: xHCI host not responding to stop endpoint command.

2014-01-12 Thread Arnaud Ebalard
Hi, Both with a LaCie 2.5" USB 3.0 Rugged Mini disk (powered by the port) and a 3.5" SATA disk connected via an ICY DOCK MB981U3S-1S dock station (external power), I can transfer huge files w/o issue but I get the following when transferring small files (e.g. copy of some debian directory to a fol

[PATCH] usb: cdc-wdm: resp_count can be 0 even if WDM_READ is set

2014-01-12 Thread Bjørn Mork
Do not decrement resp_count if it's already 0. We set resp_count to 0 when the device is closed. The next open and read will try to clear the WDM_READ flag if there was leftover data in the read buffer. This fix is necessary to prevent resubmitting the read URB in a tight loop because resp_count

Re: [BUG] FL1009: xHCI host not responding to stop endpoint command.

2014-01-12 Thread Arnaud Ebalard
Hi, a...@natisbad.org (Arnaud Ebalard) writes: > Both with a LaCie 2.5" USB 3.0 Rugged Mini disk (powered by the port) > and a 3.5" SATA disk connected via an ICY DOCK MB981U3S-1S dock station > (external power), I can transfer huge files w/o issue but I get the > following when transferring smal

Re: [PATCH 4/8] IBM Akebono: Add support to the OHCI platform driver for PPC476GTR

2014-01-12 Thread Alistair Popple
On Sat, 11 Jan 2014 12:06:32 Benjamin Herrenschmidt wrote: > On Fri, 2014-01-10 at 16:52 -0800, Greg KH wrote: > > > >Signed-off-by: Alistair Popple > > > >Acked-by: Alan Stern > > > >Cc: linux-usb@vger.kernel.org > > > > > > >Greg, why this patch hasn't been merged? Because it wasn't address

Re: [PATCH 1/2] usb: gadget: s3c2410_udc: Fix build error

2014-01-12 Thread Sachin Kamat
On 3 January 2014 10:58, Sachin Kamat wrote: > Pass value instead of address as expected by 'usb_ep_set_maxpacket_limit'. > Fixes the following compilation error introduced by commit e117e742d310 > ("usb: gadget: add "maxpacket_limit" field to struct usb_ep"): > > drivers/usb/gadget/s3c2410_udc.c:

Re: [PATCH 1/2] usb: gadget: s3c2410_udc: Fix build error

2014-01-12 Thread Robert Baldyga
On 01/13/2014 04:10 AM, Sachin Kamat wrote: > On 3 January 2014 10:58, Sachin Kamat wrote: >> Pass value instead of address as expected by 'usb_ep_set_maxpacket_limit'. >> Fixes the following compilation error introduced by commit e117e742d310 >> ("usb: gadget: add "maxpacket_limit" field to struc