re: usb: gadget: FunctionFS: convert to new function interface with backward compatibility

2014-01-08 Thread Dan Carpenter
Hello Andrzej Pietrasiewicz, This is a semi-automatic email about new static checker warnings. The patch 5920cda62768: "usb: gadget: FunctionFS: convert to new function interface with backward compatibility" from Dec 3, 2013, leads to the following Smatch complaint: drivers/usb/gadget/f_fs.c:259

Re: gadgetfs USB2.0 Chapter 9 Tests: Test after "Addressed State" fails

2014-01-08 Thread Marco Zamponi
>> Shouldn't the usb.c user space application be compliant (e.g. pass all >> the CV Tests) ? > > Yes it should. For some reason though, it does not. The "Endpoint Descriptor Test - Configured State" is where it fails. - regards On Tue, Jan 7, 2014 at 5:02 PM, Michal Nazarewicz wrote: > On Tue,

Re: gadgetfs USB2.0 Chapter 9 Tests: Test after "Addressed State" fails

2014-01-08 Thread Marco Zamponi
The first Warning occurs in the test before (Interface Descriptor Test): ... INFO Device does not use a class-specific protocol on this interface INFO ENGLISH_USlanguage string descriptor is : Source/Sink INFO Calling SetInterface(), InterfaceNumber=0, AlternateSetting=0 WARNING SetI

Re: xhci_hcd and Canon Lide 110 not playing well together

2014-01-08 Thread Xenia Ragiadakou
On 07/01/2014 11:46 μμ, Sarah Sharp wrote: On Wed, Dec 25, 2013 at 09:51:28PM -0500, Alan Stern wrote: Okay, now we know that usb_enable_interface takes a long time. That routine does nothing but call usb_enable_endpoint, which does nothing but call usb_hcd_reset_endpoint, which calls the xhci_

Re: [PATCH v4 1/5] mfd: omap-usb-host: Update DT clock binding information

2014-01-08 Thread Sebastian Reichel
On Wed, Jan 08, 2014 at 11:45:38AM +0530, Roger Quadros wrote: > diff --git a/Documentation/devicetree/bindings/mfd/omap-usb-host.txt > b/Documentation/devicetree/bindings/mfd/omap-usb-host.txt > index b381fa6..5635202 100644 > --- a/Documentation/devicetree/bindings/mfd/omap-usb-host.txt > +++ b/

Re: [PATCH v2] mfd: omap-usb-tll: Don't hold lock during pm_runtime_get/put_sync()

2014-01-08 Thread Lee Jones
> pm_runtime_get/put_sync() can sleep so don't hold spinlock while > calling them. > > This patch prevents a BUG() during system suspend when > CONFIG_DEBUG_ATOMIC_SLEEP is enabled. > > Bug is present in Kernel versions v3.9 onwards. > > Reported-by: Tomi Valkeinen > Signed-off-by: Roger Quadro

RE: [PATCH] usb: Skip U1/U2 LPM disable if device is disconnected.

2014-01-08 Thread Venkatesh Murthy, HemanthX
>-Original Message- >From: Sarah Sharp [mailto:sarah.a.sh...@linux.intel.com] >Sent: Tuesday, January 07, 2014 12:16 AM >To: Alan Stern >Cc: linux-usb@vger.kernel.org; Nandibasappa, GirishX; Venkatesh Murthy, >HemanthX >Subject: Re: [PATCH] usb: Skip U1/U2 LPM disable if device is disconne

RE: [PATCH v2] xhci: Allocate the td array and urb_priv together.

2014-01-08 Thread David Laight
> From: 'David Cohen' ... > > > The new kmalloc is going to be "n * sizeof(struct) - n * sizeof(pointer)" > > > bigger. I don't know what is the usual range of values for "n", but my > > > experience with android devices with non-abundant memory size is that > > > they are sensible to kmalloc > PAG

[PATCH 03/10] usb: chipidea: host:vbus control change for OTG HNP.

2014-01-08 Thread Li Jun
Leave vbus on/off hanlded by OTG fsm if in OTG mode, init OTG port number. Signed-off-by: Li Jun --- drivers/usb/chipidea/host.c | 13 + drivers/usb/chipidea/host.h |9 + 2 files changed, 18 insertions(+), 4 deletions(-) diff --git a/drivers/usb/chipidea/host.c b/drive

[PATCH 02/10] usb: chipidea: usb OTG fsm initlization.

2014-01-08 Thread Li Jun
This patch adds OTG fsm related initizations when do otg init, add a seperate file for OTG fsm related utilities. Signed-off-by: Li Jun --- drivers/usb/chipidea/Makefile |1 + drivers/usb/chipidea/ci.h |1 + drivers/usb/chipidea/otg.c |6 +++ drivers/usb/chipidea/otg_fsm.c

[PATCH 04/10] usb: chipidea: udc:driver update for OTG HNP.

2014-01-08 Thread Li Jun
Add b_hnp_enable request handling and enable gadget->is_otg Signed-off-by: Li Jun --- drivers/usb/chipidea/udc.c | 11 ++- 1 files changed, 10 insertions(+), 1 deletions(-) diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c index 73a39ef..ccdc277 100644 --- a/drivers

[PATCH 00/10] usb: chipidea: Add USB OTG HNP and SRP support on Chipidea usb driver.

2014-01-08 Thread Li Jun
This patchset adds USB OTG HNP and SRP support on chipidea usb driver, existing OTG port role swtich function by ID pin status kept unchanged, based on that, if select CONFIG_USB_OTG_FSM, OTG HNP and SRP will be supported. Also some update on common otg fsm driver according to OTG and EH Rev 2.0.

[PATCH 01/10] usb: phy-fsm: update OTG HNP state transition conditions according to OTG and EH 2.0 spec.

2014-01-08 Thread Li Jun
According to:"On-The-Go and Embedded Host Supplement to the USB Revision 2.0 Specification July 27, 2012 Revision 2.0 version 1.1a" - From a_host to a_wait_bcon if !b_conn - Add transition from a_host to a_wait_vfall if id state is high or a_bus_drop - From a_wait_vfall to a_idle if a_wait_vfall_tm

[PATCH 08/10] usb: chipidea: add OTG HNP polling support.

2014-01-08 Thread Li Jun
This patch add OTG HNP polling support for both A and B device. After A/B in host state, host request polling message will be sent from host to peripheral every 1.5s, if host found the host request flag is set to be 1 by peripheral, a role switch will be started. Signed-off-by: Li Jun --- driver

[PATCH 10/10] usb: chipidea: debug: add debug file for OTG variables show and registers dump.

2014-01-08 Thread Li Jun
This patch add a debug file for OTG vairables show and registers dump. Signed-off-by: Li Jun --- drivers/usb/chipidea/debug.c | 100 ++ 1 files changed, 100 insertions(+), 0 deletions(-) diff --git a/drivers/usb/chipidea/debug.c b/drivers/usb/chipidea/de

[PATCH 07/10] usb: chipidea: OTG HNP and SRP fsm implementation.

2014-01-08 Thread Li Jun
USB OTG interrupt handling and fsm transition according to USB OTG spec 2.0, update otg timer time out handlers. Signed-off-by: Li Jun --- drivers/usb/chipidea/bits.h|3 + drivers/usb/chipidea/core.c| 10 ++- drivers/usb/chipidea/otg.c |6 + drivers/usb/chipidea/otg_fsm.c |

[PATCH 06/10] usb: chipidea: OTG fsm timers initialization.

2014-01-08 Thread Li Jun
This patch adds OTG fsm timers initialization, which use controller's 1ms interrupt as time out counter, also adds some local timers which are not in otg_fsm_timer list. Signed-off-by: Li Jun --- drivers/usb/chipidea/otg_fsm.c | 111 +++- drivers/usb/chipidea

[PATCH 05/10] usb: chipidea: add OTG fsm operation functions implemenation.

2014-01-08 Thread Li Jun
Add OTG HNP and SRP operation functions implementation: - charge vbus - drive vbus - connection signaling - drive sof - start data pulse - add fsm timer - delete fsm timer - start host - start gadget Signed-off-by: Li Jun --- drivers/usb/chipidea/bits.h| 11 ++ drivers/usb/chipidea/otg_fsm

[PATCH 09/10] usb: chipidea: add sys inputs for OTG fsm input.

2014-01-08 Thread Li Jun
This patch adds sys input to control and show OTG fsm inputs by application, user can do host and preipheral role switch by change these inputs. Signed-off-by: Li Jun --- drivers/usb/chipidea/otg.c |1 + drivers/usb/chipidea/otg_fsm.c | 204 driv

Re: [PATCH v4 1/5] mfd: omap-usb-host: Update DT clock binding information

2014-01-08 Thread Mark Rutland
On Wed, Jan 08, 2014 at 06:15:38AM +, Roger Quadros wrote: > The omap-usb-host driver expects the 60MHz functional clock > of the USB host module to be named as "init_60m_fclk". > Add this information in the DT binding document. > > CC: Lee Jones > CC: Samuel Ortiz > Signed-off-by: Roger Qua

RE: [Bug 68161] Unstable work of xhci with USB3.0 card reader and UDMA7 CompactFlash card.

2014-01-08 Thread David Laight
> From: tatxarata > Since reporting this bug I've invested some time to get myself familiar > with USB protocol and analyzed attached capture files. It seems like > device resetoccurs after device returns urb_status=-75 (-EOVERFLOW). ... > In case of USB2.0 host<->device traffic looks pretty the sa

Re: [PATCH v4 1/5] mfd: omap-usb-host: Update DT clock binding information

2014-01-08 Thread Roger Quadros
+Tero Hi Sebastian, On 01/08/2014 02:38 PM, Sebastian Reichel wrote: > On Wed, Jan 08, 2014 at 11:45:38AM +0530, Roger Quadros wrote: >> diff --git a/Documentation/devicetree/bindings/mfd/omap-usb-host.txt >> b/Documentation/devicetree/bindings/mfd/omap-usb-host.txt >> index b381fa6..5635202 100

Re: [PATCH v4 1/5] mfd: omap-usb-host: Update DT clock binding information

2014-01-08 Thread Roger Quadros
Hi Mark, On 01/08/2014 03:26 PM, Mark Rutland wrote: > On Wed, Jan 08, 2014 at 06:15:38AM +, Roger Quadros wrote: >> The omap-usb-host driver expects the 60MHz functional clock >> of the USB host module to be named as "init_60m_fclk". >> Add this information in the DT binding document. >> >> C

Re: [PATCH v4 1/5] mfd: omap-usb-host: Update DT clock binding information

2014-01-08 Thread Arnd Bergmann
On Wednesday 08 January 2014 15:39:36 Roger Quadros wrote: > > What about the other clocks acquired in drivers/mfd/omap-usb-host.c? > > Shouldn't > > all of those be provided by via the DT phandle? > > > > All those clocks are identically named across the OMAP SoCs and are unique > for each > S

Re: [PATCH v4 1/5] mfd: omap-usb-host: Update DT clock binding information

2014-01-08 Thread Roger Quadros
On 01/08/2014 03:49 PM, Arnd Bergmann wrote: > On Wednesday 08 January 2014 15:39:36 Roger Quadros wrote: >>> What about the other clocks acquired in drivers/mfd/omap-usb-host.c? >>> Shouldn't >>> all of those be provided by via the DT phandle? >>> >> >> All those clocks are identically named acro

Re: [PATCH v4 1/5] mfd: omap-usb-host: Update DT clock binding information

2014-01-08 Thread Arnd Bergmann
On Wednesday 08 January 2014 15:57:19 Roger Quadros wrote: > It is a clock gate defined like so in the DT clock data > > on OMAP4 > init_60m_fclk: init_60m_fclk { > #clock-cells = <0>; > compatible = "ti,divider-clock"; > clocks = <&dpll_usb_

Re: [PATCH v4 1/5] mfd: omap-usb-host: Update DT clock binding information

2014-01-08 Thread Sebastian Reichel
Hi, On Wed, Jan 08, 2014 at 03:39:36PM +0530, Roger Quadros wrote: > > What about the other clocks acquired in drivers/mfd/omap-usb-host.c? > > Shouldn't > > all of those be provided by via the DT phandle? > > All those clocks are identically named across the OMAP SoCs and are unique > for each

Re: [PATCH v4 1/5] mfd: omap-usb-host: Update DT clock binding information

2014-01-08 Thread Arnd Bergmann
On Wednesday 08 January 2014 11:52:44 Sebastian Reichel wrote: > > On Wed, Jan 08, 2014 at 03:39:36PM +0530, Roger Quadros wrote: > > > What about the other clocks acquired in drivers/mfd/omap-usb-host.c? > > > Shouldn't > > > all of those be provided by via the DT phandle? > > > > All those clo

Re: [PATCH v4 1/5] mfd: omap-usb-host: Update DT clock binding information

2014-01-08 Thread Roger Quadros
On 01/08/2014 04:10 PM, Arnd Bergmann wrote: > On Wednesday 08 January 2014 15:57:19 Roger Quadros wrote: >> It is a clock gate defined like so in the DT clock data >> >> on OMAP4 >> init_60m_fclk: init_60m_fclk { >> #clock-cells = <0>; >> compatible = "ti,di

Re: [PATCH v4 1/5] mfd: omap-usb-host: Update DT clock binding information

2014-01-08 Thread Roger Quadros
On 01/08/2014 04:25 PM, Arnd Bergmann wrote: > On Wednesday 08 January 2014 11:52:44 Sebastian Reichel wrote: >> >> On Wed, Jan 08, 2014 at 03:39:36PM +0530, Roger Quadros wrote: What about the other clocks acquired in drivers/mfd/omap-usb-host.c? Shouldn't all of those be provided

Re: [PATCH v4 1/5] mfd: omap-usb-host: Update DT clock binding information

2014-01-08 Thread Arnd Bergmann
On Wednesday 08 January 2014, Roger Quadros wrote: > OK. I'll update the binding information to reflect all the clocks. > > But what about clk_get() vs of_clk_get_by_name() ? I think the convention these days is to just use clk_get(), which calls of_clk_get_by_name() internally. Not sure if that'

Re: [PATCH v4 1/5] mfd: omap-usb-host: Update DT clock binding information

2014-01-08 Thread Roger Quadros
On 01/08/2014 05:05 PM, Arnd Bergmann wrote: > On Wednesday 08 January 2014, Roger Quadros wrote: >> OK. I'll update the binding information to reflect all the clocks. >> >> But what about clk_get() vs of_clk_get_by_name() ? > > I think the convention these days is to just use clk_get(), which cal

Re: [PATCH 4/8] usb: ehci: add freescale imx28 special write register method

2014-01-08 Thread Marc Kleine-Budde
On 01/08/2014 01:23 AM, Greg KH wrote: > On Mon, Jan 06, 2014 at 10:10:41AM +0800, Peter Chen wrote: >> According to Freescale imx28 Errata, "ENGR119653 USB: ARM to USB >> register error issue", All USB register write operations must >> use the ARM SWP instruction. So, we implement a special ehci_w

Re: [Bug 68161] Unstable work of xhci with USB3.0 card reader and UDMA7 CompactFlash card.

2014-01-08 Thread tatxarata
On 01/08/2014 01:59 PM, David Laight wrote: From: tatxarata Since reporting this bug I've invested some time to get myself familiar with USB protocol and analyzed attached capture files. It seems like device resetoccurs after device returns urb_status=-75 (-EOVERFLOW). ... In case of USB2.0 hos

Re: [PATCH v1] xhci: Switch Intel Lynx Point ports to EHCI on shutdown

2014-01-08 Thread Denis Turischev
On 01/08/2014 01:11 AM, Sarah Sharp wrote: > Denis, what do you mean by "works for Lynx Point"? Do you mean that > adding the quirk to switch the ports on EHCI on shutdown (e95829f474) > for the Intense-PC2 *instead of* the commit to put the host in D3 on > shutdown (638298dc66) works? Or do you

Re: [PATCH v6] usb: gadget: Add UDC driver for Aeroflex Gaisler GRUSBDC

2014-01-08 Thread Andreas Larsson
On 2014-01-06 17:22, Mark Rutland wrote: Hi, Apologies for the late reply, I wasn't able to access my mail much over the Christmas break. The patch is already applied to both the next branch of Felipe Balbi's usb/next branch and merged from there into Greg Kroah-Hartman's usb/usb-next branch

Re: [PATCH v6] usb: gadget: Add UDC driver for Aeroflex Gaisler GRUSBDC

2014-01-08 Thread Mark Rutland
On Wed, Jan 08, 2014 at 01:23:04PM +, Andreas Larsson wrote: > On 2014-01-06 17:22, Mark Rutland wrote: > > Hi, > > > > Apologies for the late reply, I wasn't able to access my mail much over > > the Christmas break. > > The patch is already applied to both the next branch of Felipe Balbi's >

Re: [PATCH 4/8] usb: ehci: add freescale imx28 special write register method

2014-01-08 Thread Greg KH
On Wed, Jan 08, 2014 at 12:54:25PM +0100, Marc Kleine-Budde wrote: > On 01/08/2014 01:23 AM, Greg KH wrote: > > On Mon, Jan 06, 2014 at 10:10:41AM +0800, Peter Chen wrote: > >> According to Freescale imx28 Errata, "ENGR119653 USB: ARM to USB > >> register error issue", All USB register write operat

Re: [PATCH v2] xhci: Allocate the td array and urb_priv together.

2014-01-08 Thread 'David Cohen'
On Wed, Jan 08, 2014 at 09:25:42AM +, David Laight wrote: > > From: 'David Cohen' > ... > > > > The new kmalloc is going to be "n * sizeof(struct) - n * > > > > sizeof(pointer)" > > > > bigger. I don't know what is the usual range of values for "n", but my > > > > experience with android devic

RE: [PATCH v2] xhci: Allocate the td array and urb_priv together.

2014-01-08 Thread David Laight
> From: 'David Cohen' ... > I actually don't know what's the regular range of 'td_cnt'. But what got my > attention was this comment from patch description: > > "The only possible downside is for isochronous tranfers with 64 td > when the allocate is 8+4096 bytes (on 64bit systems) so requires > a

Re: [RFC/PATCH] usb/xhci: avoid kernel panic on xhci_suspend()

2014-01-08 Thread Alan Stern
On Tue, 7 Jan 2014, Greg KH wrote: > On Tue, Jan 07, 2014 at 05:44:26PM -0800, David Cohen wrote: > > From: jianqian > > > > There is a possible kernel panic faced on xhci_suspend(). > > Due to kernel modified the hub autosupend_delay to 0s, after usb1 root > > hub finishes initialization, it wi

Re: XHCI issues: WD MyBook 1230 - reset SuperSpeed USB device

2014-01-08 Thread Peter Palúch
Greetings, Regarding the issue with WD MyBook 1230 stalling and being reset when connected to an HP EliteBook 8560p, I have tested the 3.13-rc7 kernel from kernel.org to no avail - the drive still stalls and is reset after a couple of seconds. I am attaching a dmesg output (relevant lines reg

Re: Alcatel usb modem

2014-01-08 Thread Lars Melin
On 2014-01-02 23:59, Dan Williams wrote: On Sun, 2013-12-29 at 15:35 +0700, Lars Melin wrote: On 2013-12-29 00:55, Greg KH wrote: On Sat, Dec 28, 2013 at 02:13:08PM +, thomas.takacs.a...@gmail.com wrote: Hi, I've seen this message: tell linux-usb... to add your device to a proper device. M

Re: [RFC 2/2] dual scan thread bug fix

2014-01-08 Thread Alan Stern
On Wed, 8 Jan 2014, James Bottomley wrote: > OK, Agreed, but that means modifying the 1/2 patch with the below. This > should make the proposed diff to 2/2 correct. > > James > > --- > diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c > index ef3f958..5fad646 100644 > --- a/drive

Re: [PATCH 1/2] ohci-platform: Add support for devicetree instantiation

2014-01-08 Thread Hans de Goede
Hi, On 01/06/2014 08:50 AM, Hans de Goede wrote: Otherwise you don't know the difference between "no clock provided", "error getting the clock reference" and "clock controller not initialized yet, try again". I guess of these 3 we really only want to continue on "no clock provided", so I th

RE: [PATCH 3.12 033/118] usb: xhci: Link TRB must not occur within a USB payload burst

2014-01-08 Thread David Laight
> From: Sarah Sharp > On Tue, Jan 07, 2014 at 03:57:00PM -0800, walt wrote: > > On 01/07/2014 01:21 PM, Sarah Sharp wrote: > > > > > Can you please try the attached patch, on top of the previous three > > > patches, and send me dmesg? > > > > Hi Sarah, I just now finished running 0001-More-debuggin

[PATCH] usb: delete non-required instances of include

2014-01-08 Thread Paul Gortmaker
None of these files are actually using any __init type directives and hence don't need to include . Most are just a left over from __devinit and __cpuinit removal, or simply due to code getting copied from one driver to the next. Signed-off-by: Paul Gortmaker --- [build tested drivers/usb for a

[PATCH] xhci: make warnings greppable

2014-01-08 Thread oliver
From: Oliver Neukum This changes debug messages and warnings in xhci-ring.c to be on a single line so grep can find them. grep must have precedence over the 80 column limit. Signed-off-by: Oliver Neukum --- drivers/usb/host/xhci-ring.c | 21 - 1 file changed, 8 insertions(+

[PATCH] xhci: make warnings greppable

2014-01-08 Thread oliver
From: Oliver Neukum This changes debug messages and warnings in xhci-ring.c to be on a single line so grep can find them. grep must have precedence over the 80 column limit. Signed-off-by: Oliver Neukum --- drivers/usb/host/xhci-ring.c | 21 - 1 file changed, 8 insertions(+

[PATCH] USB: c67x00: correct spelling mistakes in comments

2014-01-08 Thread Rahul Bedarkar
Signed-off-by: Rahul Bedarkar --- drivers/usb/c67x00/c67x00-hcd.h| 2 +- drivers/usb/c67x00/c67x00-ll-hpi.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/usb/c67x00/c67x00-hcd.h b/drivers/usb/c67x00/c67x00-hcd.h index b4b2b01..d441a98 100644 --- a/drivers/u

[PATCH v2 0/2] ohci and ehci-platform clks, phy and dt support

2014-01-08 Thread Hans de Goede
Hi All, Here is v2 of my ohci and ehci-platform clks, phy and dt support patch-set. Changes since v1: -Various improvements to dt-bindings as suggested by various people -Support up-to 3 clocks Regards, Hans -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of

[PATCH v2 2/2] ehci-platform: Add support for clks and phy passed through devicetree

2014-01-08 Thread Hans de Goede
Currently ehci-platform is only used in combination with devicetree when used with some via socs. By extending it to (optionally) get clks and a phy from devicetree, and enabling / disabling those on power_on / off, it can be used more generically. Specifically after this commit it can be used for

Re: Isochronous transfer error on USB3

2014-01-08 Thread Mauro Carvalho Chehab
Em Thu, 02 Jan 2014 14:07:22 -0800 Sarah Sharp escreveu: > On Sun, Dec 29, 2013 at 02:54:40AM -0200, Mauro Carvalho Chehab wrote: > > It seems that usb_unlink_urb() is causing troubles with xHCI: the > > endpoint stops streaming, but, after that, it doesn't start again, > > and lots of debug mess

[PATCH] USB: image: correct spelling mistake in comment

2014-01-08 Thread Rahul Bedarkar
Signed-off-by: Rahul Bedarkar --- drivers/usb/image/mdc800.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/image/mdc800.c b/drivers/usb/image/mdc800.c index 7121b50..a62865a 100644 --- a/drivers/usb/image/mdc800.c +++ b/drivers/usb/image/mdc800.c @@ -51,7 +51,7

[PATCH] USB: c67x00: fix up line break coding style issues

2014-01-08 Thread Rahul Bedarkar
Signed-off-by: Rahul Bedarkar --- drivers/usb/c67x00/c67x00-drv.c| 3 ++- drivers/usb/c67x00/c67x00-hcd.h| 2 +- drivers/usb/c67x00/c67x00-ll-hpi.c | 21 +- drivers/usb/c67x00/c67x00-sched.c | 44 -- drivers/usb/c67x00/c67x00.h

[PATCH] USB: chipidea: fix up coding style issues

2014-01-08 Thread Rahul Bedarkar
Signed-off-by: Rahul Bedarkar --- drivers/usb/chipidea/ci_hdrc_imx.c | 3 ++- drivers/usb/chipidea/core.c| 9 + drivers/usb/chipidea/host.c| 3 ++- drivers/usb/chipidea/udc.c | 9 ++--- 4 files changed, 15 insertions(+), 9 deletions(-) diff --git a/drivers/us

Re: [PATCH 3.12 033/118] usb: xhci: Link TRB must not occur within a USB payload burst

2014-01-08 Thread Alan Stern
On Tue, 7 Jan 2014, Sarah Sharp wrote: > On Tue, Jan 07, 2014 at 03:57:00PM -0800, walt wrote: > > On 01/07/2014 01:21 PM, Sarah Sharp wrote: > > > > > Can you please try the attached patch, on top of the previous three > > > patches, and send me dmesg? > > > > Hi Sarah, I just now finished runn

[PATCH v2 1/2] ohci-platform: Add support for devicetree instantiation

2014-01-08 Thread Hans de Goede
Add support for ohci-platform instantiation from devicetree, including optionally getting clks and a phy from devicetree, and enabling / disabling those on power_on / off. This should allow using ohci-platform from devicetree in various cases. Specifically after this commit it can be used for the

Re: [Bug 68161] Unstable work of xhci with USB3.0 card reader and UDMA7 CompactFlash card.

2014-01-08 Thread Alan Stern
On Wed, 8 Jan 2014, tatxarata wrote: > Since reporting this bug I've invested some time to get myself familiar > with USB protocol and analyzed attached capture files. It seems like > device resetoccurs after device returns urb_status=-75 (-EOVERFLOW). Yes. The EOVERFLOW error is what causes

RE: [PATCH 3.12 033/118] usb: xhci: Link TRB must not occur within a USB payload burst

2014-01-08 Thread David Laight
> From: Alan Stern > > This may be a foolish question, but why is xhci-hcd using no-op TRBs in > the first place? Because it can't write in a link TRB because other parts of the code use link TRBs to detect the end of the ring. The problem is that it can't put a link TRB in the middle of a chain

Re: [PATCH 1/2] ohci-platform: Add support for devicetree instantiation

2014-01-08 Thread Alan Stern
On Tue, 7 Jan 2014, Hans de Goede wrote: > Hi, > > On 01/07/2014 10:16 PM, Arnd Bergmann wrote: > > On Tuesday 07 January 2014 22:03:11 Hans de Goede wrote: > + > +Optional properties: > + - clocks: array of clocks > + - clock-names: clock names "ahb" and/or "ohci" > >>> > >>>

Re: Isochronous transfer error on USB3

2014-01-08 Thread Mauro Carvalho Chehab
Em Wed, 08 Jan 2014 14:31:28 -0200 Mauro Carvalho Chehab escreveu: > Em Thu, 02 Jan 2014 14:07:22 -0800 > Sarah Sharp escreveu: > > > On Sun, Dec 29, 2013 at 02:54:40AM -0200, Mauro Carvalho Chehab wrote: > > > It seems that usb_unlink_urb() is causing troubles with xHCI: the > > > endpoint sto

Re: [PATCH] RFC: Allow to blacklist xhci_hcd module and use ports with EHCI

2014-01-08 Thread Alan Stern
On Tue, 7 Jan 2014, Holger Hans Peter Freyther wrote: > On Tue, Jan 07, 2014 at 10:32:08AM -0500, Alan Stern wrote: > > > > I think in my case quirk_usb_handoff_xhci is called during boot that > > > will switch the ports to the XHCI. > > > > That's what I said. Early PCI processing occurs durin

RE: [PATCH 3.12 033/118] usb: xhci: Link TRB must not occur within a USB payload burst

2014-01-08 Thread Alan Stern
On Wed, 8 Jan 2014, David Laight wrote: > > From: Alan Stern > > > > This may be a foolish question, but why is xhci-hcd using no-op TRBs in > > the first place? > > Because it can't write in a link TRB because other parts of the > code use link TRBs to detect the end of the ring. > > The probl

Re: Alcatel usb modem

2014-01-08 Thread Greg KH
On Wed, Jan 08, 2014 at 10:45:43PM +0700, Lars Melin wrote: > On 2014-01-02 23:59, Dan Williams wrote: > >On Sun, 2013-12-29 at 15:35 +0700, Lars Melin wrote: > >>On 2013-12-29 00:55, Greg KH wrote: > >>>On Sat, Dec 28, 2013 at 02:13:08PM +, thomas.takacs.a...@gmail.com > >>>wrote: > Hi, >

Re: [PATCH] usb:hub set hub->change_bits when over-current happens

2014-01-08 Thread Greg KH
On Wed, Jan 08, 2014 at 02:45:42PM +0800, Shen Guang wrote: > When we are doing compliance test with xHCI, we found that if we > enable CONFIG_USB_SUSPEND and plug in a bad device which causes > over-current condition to the root port, software will not be noticed. > The reason is that current code

RE: [PATCH 3.12 033/118] usb: xhci: Link TRB must not occur within a USB payload burst

2014-01-08 Thread David Laight
> From: Alan Stern > On Wed, 8 Jan 2014, David Laight wrote: > > > > From: Alan Stern > > > > > > This may be a foolish question, but why is xhci-hcd using no-op TRBs in > > > the first place? > > > > Because it can't write in a link TRB because other parts of the > > code use link TRBs to detect

RE: [PATCH RFC alternative ver 1] phy: Exynos 421x USB 2.0 PHY support

2014-01-08 Thread Kamil Debski
Hi Kishon, Thank you for your review. > From: Kishon Vijay Abraham I [mailto:kis...@ti.com] > Sent: Monday, January 06, 2014 11:24 AM > > Hi, > > On Friday 20 December 2013 06:54 PM, Kamil Debski wrote: > > This the alternative version of the support for Exynos 421x USB 2.0 > > PHY in the Gener

Re: [PATCH] usb:hub set hub->change_bits when over-current happens

2014-01-08 Thread Alan Stern
On Wed, 8 Jan 2014, Greg KH wrote: > On Wed, Jan 08, 2014 at 02:45:42PM +0800, Shen Guang wrote: > > When we are doing compliance test with xHCI, we found that if we > > enable CONFIG_USB_SUSPEND and plug in a bad device which causes > > over-current condition to the root port, software will not b

RE: [PATCH v5 3/9] phy: Add new Exynos USB 2.0 PHY driver

2014-01-08 Thread Kamil Debski
Hi, > From: Kishon Vijay Abraham I [mailto:kis...@ti.com] > Sent: Monday, January 06, 2014 11:12 AM > > Hi, > > On Friday 20 December 2013 06:54 PM, Kamil Debski wrote: > > Add a new driver for the Exynos USB 2.0 PHY. The new driver uses the > > generic PHY framework. The driver includes support

Re: Isochronous transfer error on USB3

2014-01-08 Thread Mauro Carvalho Chehab
Em Wed, 08 Jan 2014 15:05:12 -0200 Mauro Carvalho Chehab escreveu: > Em Wed, 08 Jan 2014 14:31:28 -0200 > Mauro Carvalho Chehab escreveu: > > > Em Thu, 02 Jan 2014 14:07:22 -0800 > > Sarah Sharp escreveu: > > > > > On Sun, Dec 29, 2013 at 02:54:40AM -0200, Mauro Carvalho Chehab wrote: > > > >

Re: [PATCH v2 2/2] ehci-platform: Add support for clks and phy passed through devicetree

2014-01-08 Thread Maxime Ripard
On Wed, Jan 08, 2014 at 05:30:08PM +0100, Hans de Goede wrote: > Currently ehci-platform is only used in combination with devicetree when used > with some via socs. By extending it to (optionally) get clks and a phy from > devicetree, and enabling / disabling those on power_on / off, it can be used

Re: [PATCH] usb:hub set hub->change_bits when over-current happens

2014-01-08 Thread Sarah Sharp
On Wed, Jan 08, 2014 at 12:49:57PM -0500, Alan Stern wrote: > On Wed, 8 Jan 2014, Greg KH wrote: > > > On Wed, Jan 08, 2014 at 02:45:42PM +0800, Shen Guang wrote: > > > When we are doing compliance test with xHCI, we found that if we > > > enable CONFIG_USB_SUSPEND and plug in a bad device which c

Re: [PATCH net-next v2 6/6] r8152: support RTL8153

2014-01-08 Thread Ben Hutchings
On Tue, 2014-01-07 at 20:35 +0800, hayeswang wrote: > Bjørn Mork [mailto:bj...@mork.no] > > Sent: Monday, January 06, 2014 5:22 PM > > To: Hayeswang > > Cc: oli...@neukum.org; net...@vger.kernel.org; nic_swsd; > > linux-ker...@vger.kernel.org; linux-usb@vger.kernel.org > > Subject: Re: [PATCH ne

Fw: Isochronous transfer error on USB3

2014-01-08 Thread Mauro Carvalho Chehab
Hi Hans/Takashi, I'm getting an weird behavior with em28xx, especially when the device is connected into an audio port. I'm using, on my tests, an em28xx HVR-950 device, using this tree: http://git.linuxtv.org/mchehab/experimental.git/shortlog/refs/heads/em28xx-v4l2-v6 Where the alsa dri

Re: [Bug 68161] Unstable work of xhci with USB3.0 card reader and UDMA7 CompactFlash card.

2014-01-08 Thread tatxarata
Oops.. my bad... It seems like wireshark misses some data while capturing on usbmon device. According to LBA addresses in subsequent SCSI commands it looks like on a request of 240 sectors host really gets from device 240 sectors. On the other hand for each such request in the capture exists

Re: [RFC/PATCH] usb/xhci: avoid kernel panic on xhci_suspend()

2014-01-08 Thread David Cohen
On Wed, Jan 08, 2014 at 10:48:06AM -0500, Alan Stern wrote: > On Tue, 7 Jan 2014, Greg KH wrote: > > > On Tue, Jan 07, 2014 at 05:44:26PM -0800, David Cohen wrote: > > > From: jianqian > > > > > > There is a possible kernel panic faced on xhci_suspend(). > > > Due to kernel modified the hub auto

[PATCH 1/2] xhci: Avoid infinite loop when sg urb requires too many trbs

2014-01-08 Thread Sarah Sharp
From: Ben Hutchings Currently prepare_ring() returns -ENOMEM if the urb won't fit into a single ring segment. usb_sg_wait() treats this error as a temporary condition and will keep retrying until something else goes wrong. The number of retries should be limited in usb_sg_wait(), but also prepa

[PATCH 2/2] xhci: Set scatter-gather limit to avoid failed block writes.

2014-01-08 Thread Sarah Sharp
Commit 35773dac5f862cb1c82ea151eba3e2f6de51ec3e "usb: xhci: Link TRB must not occur within a USB payload burst" attempted to fix an issue found with USB ethernet adapters, and inadvertently broke USB storage devices. The patch attempts to ensure that transfers never span a segment, and rejects tra

[GIT PULL] xhci: Urgent bug fixes for usb-next and 3.14.

2014-01-08 Thread Sarah Sharp
The following changes since commit d85b277ed1d3ff7b6084bf13963ab0a66544e81c: usb: gadget: remove unused variable in gr_queue_int() (2014-01-07 16:30:25 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/sarah/xhci.git tags/for-usb-next-2014-01-08

Re: [Bug 68161] Unstable work of xhci with USB3.0 card reader and UDMA7 CompactFlash card.

2014-01-08 Thread Alan Stern
On Wed, 8 Jan 2014, tatxarata wrote: > Oops.. my bad... > > It seems like wireshark misses some data while capturing on usbmon > device. According to LBA addresses in subsequent SCSI commands it looks > like on a request of 240 sectors host really gets from device 240 > sectors. On the other h

Re: Fw: Isochronous transfer error on USB3

2014-01-08 Thread Alan Stern
On Wed, 8 Jan 2014, Mauro Carvalho Chehab wrote: > Hi Hans/Takashi, > > I'm getting an weird behavior with em28xx, especially when the device > is connected into an audio port. > > I'm using, on my tests, an em28xx HVR-950 device, using this tree: > > http://git.linuxtv.org/mchehab/experi

Re: [GIT PULL] xhci: Urgent bug fixes for usb-next and 3.14.

2014-01-08 Thread Greg Kroah-Hartman
On Wed, Jan 08, 2014 at 11:59:14AM -0800, Sarah Sharp wrote: > The following changes since commit d85b277ed1d3ff7b6084bf13963ab0a66544e81c: > > usb: gadget: remove unused variable in gr_queue_int() (2014-01-07 16:30:25 > -0800) > > are available in the git repository at: > > git://git.kerne

Re: [PATCH v2 1/2] ohci-platform: Add support for devicetree instantiation

2014-01-08 Thread Florian Fainelli
Hello, 2014/1/8 Hans de Goede : > Add support for ohci-platform instantiation from devicetree, including > optionally getting clks and a phy from devicetree, and enabling / disabling > those on power_on / off. > > This should allow using ohci-platform from devicetree in various cases. > Specifical

Re: [Bug 68161] Unstable work of xhci with USB3.0 card reader and UDMA7 CompactFlash card.

2014-01-08 Thread tatxarata
On 01/08/2014 08:50 PM, Alan Stern wrote: On Wed, 8 Jan 2014, tatxarata wrote: Since reporting this bug I've invested some time to get myself familiar with USB protocol and analyzed attached capture files. It seems like device resetoccurs after device returns urb_status=-75 (-EOVERFLOW). Yes.

Re: 3.13-rc2 phy-twl4030-usb.c - Timeout setting T2 HSUSB PHY DPLL

2014-01-08 Thread Belisko Marek
Any pointers? Still present in 3.13-rc7. On Wed, Dec 4, 2013 at 1:22 PM, Roger Quadros wrote: > +Kishon > > On 12/03/2013 11:33 PM, Belisko Marek wrote: >> Hi, >> >> current 3.13-rcX break usb support on gta04 board (similar to >> beagleboard) when booting via board file. >> >> In console we can

Re: [PATCH 08/10] usb: chipidea: add OTG HNP polling support.

2014-01-08 Thread Felipe Balbi
Hi, On Wed, Jan 08, 2014 at 05:06:23PM +0800, Li Jun wrote: > This patch add OTG HNP polling support for both A and B device. > After A/B in host state, host request polling message will be sent > from host to peripheral every 1.5s, if host found the host request > flag is set to be 1 by periphera

Re: [RFC 2/2] dual scan thread bug fix

2014-01-08 Thread James Bottomley
On Wed, 2014-01-08 at 10:57 -0500, Alan Stern wrote: > On Wed, 8 Jan 2014, James Bottomley wrote: > > > OK, Agreed, but that means modifying the 1/2 patch with the below. This > > should make the proposed diff to 2/2 correct. > > > > James > > > > --- > > diff --git a/drivers/scsi/scsi_scan.c b

Re: [PATCH v2] xhci: Allocate the td array and urb_priv together.

2014-01-08 Thread 'David Cohen'
On Wed, Jan 08, 2014 at 03:29:31PM +, David Laight wrote: > > From: 'David Cohen' > ... > > I actually don't know what's the regular range of 'td_cnt'. But what got my > > attention was this comment from patch description: > > > > "The only possible downside is for isochronous tranfers with 64

Re: [PATCH] USB: c67x00: fix up line break coding style issues

2014-01-08 Thread Greg Kroah-Hartman
On Wed, Jan 08, 2014 at 10:01:54PM +0530, Rahul Bedarkar wrote: > > Signed-off-by: Rahul Bedarkar > --- > drivers/usb/c67x00/c67x00-drv.c| 3 ++- > drivers/usb/c67x00/c67x00-hcd.h| 2 +- > drivers/usb/c67x00/c67x00-ll-hpi.c | 21 +- > drivers/usb/c67x00/c67x00-sched.c

Re: [PATCH] USB: chipidea: fix up coding style issues

2014-01-08 Thread Greg Kroah-Hartman
On Wed, Jan 08, 2014 at 10:04:04PM +0530, Rahul Bedarkar wrote: > > Signed-off-by: Rahul Bedarkar > --- > drivers/usb/chipidea/ci_hdrc_imx.c | 3 ++- > drivers/usb/chipidea/core.c| 9 + > drivers/usb/chipidea/host.c| 3 ++- > drivers/usb/chipidea/udc.c | 9 ++-

Re: [PATCH] drivers: dwc2: Mark function as static in core.c

2014-01-08 Thread Greg Kroah-Hartman
On Sat, Dec 21, 2013 at 03:50:29PM +0530, Rashika Kheria wrote: > Mark function dwc2_set_param_uframe_sched() as static in core.c because > it is not used outside this file. > > This eliminates the following warning in core.c: > drivers/staging/dwc2/core.c:2739:5: warning: no previous prototype fo

Re: [PATCH 3.12 033/118] usb: xhci: Link TRB must not occur within a USB payload burst

2014-01-08 Thread walt
On 01/03/2014 03:29 PM, Sarah Sharp wrote: > I'll let you know when I have some diagnostic patches ready. Hi Sarah. I see today gregkh committed the patches you've already sent me, so I assume someone (other than me) has tested those patches and discovered some benefit from them? I'm still wond

Re: [PATCH 4/8] usb: ehci: add freescale imx28 special write register method

2014-01-08 Thread Peter Chen
On Wed, Jan 08, 2014 at 06:25:01AM -0800, Greg KH wrote: > On Wed, Jan 08, 2014 at 12:54:25PM +0100, Marc Kleine-Budde wrote: > > On 01/08/2014 01:23 AM, Greg KH wrote: > > > On Mon, Jan 06, 2014 at 10:10:41AM +0800, Peter Chen wrote: > > >> According to Freescale imx28 Errata, "ENGR119653 USB: ARM

Re: [PATCH 4/8] usb: ehci: add freescale imx28 special write register method

2014-01-08 Thread Peter Chen
On Tue, Jan 07, 2014 at 04:20:25PM -0800, Greg KH wrote: > On Mon, Jan 06, 2014 at 09:42:26AM +0100, Marc Kleine-Budde wrote: > > Hello Peter and Greg, > > > > On 01/06/2014 03:10 AM, Peter Chen wrote: > > > According to Freescale imx28 Errata, "ENGR119653 USB: ARM to USB > > > register error issu

Re: [PATCH 7/8] usb: chipidea: Fix Internal error: : 808 [#1] ARM related to STS flag

2014-01-08 Thread Peter Chen
On Tue, Jan 07, 2014 at 04:27:30PM -0800, Greg KH wrote: > On Mon, Jan 06, 2014 at 10:10:44AM +0800, Peter Chen wrote: > > From: Chris Ruehl > > > > * init the sts flag to 0 (missed) > > * fix write the real bit not sts value > > * Set PORTCS_STS and DEVLC_STS only if sts = 1 > > > > Signed-off-

Re: [PATCH 4/8] usb: ehci: add freescale imx28 special write register method

2014-01-08 Thread Greg KH
On Thu, Jan 09, 2014 at 09:23:18AM +0800, Peter Chen wrote: > On Wed, Jan 08, 2014 at 06:25:01AM -0800, Greg KH wrote: > > On Wed, Jan 08, 2014 at 12:54:25PM +0100, Marc Kleine-Budde wrote: > > > On 01/08/2014 01:23 AM, Greg KH wrote: > > > > On Mon, Jan 06, 2014 at 10:10:41AM +0800, Peter Chen wro

Re: [PATCH 4/8] usb: ehci: add freescale imx28 special write register method

2014-01-08 Thread Greg KH
On Thu, Jan 09, 2014 at 09:36:09AM +0800, Peter Chen wrote: > On Tue, Jan 07, 2014 at 04:20:25PM -0800, Greg KH wrote: > > On Mon, Jan 06, 2014 at 09:42:26AM +0100, Marc Kleine-Budde wrote: > > > Hello Peter and Greg, > > > > > > On 01/06/2014 03:10 AM, Peter Chen wrote: > > > > According to Frees

Re: 3.13-rc2 phy-twl4030-usb.c - Timeout setting T2 HSUSB PHY DPLL

2014-01-08 Thread Roger Quadros
Hi Marek, I have no idea what is happening there. Have you tried using device tree boot? Board file boot support would be dropped eventually. Did you try if I2C read write to the twl4030 device works and all necessary clocks/supplies are present? Kishon, do you know what is causing the USB DPLL

Re: [PATCH v5 3/9] phy: Add new Exynos USB 2.0 PHY driver

2014-01-08 Thread Kishon Vijay Abraham I
Hi, On Wednesday 08 January 2014 11:26 PM, Kamil Debski wrote: > Hi, > >> From: Kishon Vijay Abraham I [mailto:kis...@ti.com] >> Sent: Monday, January 06, 2014 11:12 AM >> >> Hi, >> >> On Friday 20 December 2013 06:54 PM, Kamil Debski wrote: >>> Add a new driver for the Exynos USB 2.0 PHY. The ne

  1   2   >