Re: [RFC 0/2] target refcounting infrastructure fixes for usb

2014-01-03 Thread Hans de Goede
Hi, On 01/03/2014 01:45 AM, Sarah Sharp wrote: On Sat, Dec 21, 2013 at 03:51:25PM -0500, Alan Stern wrote: On Fri, 20 Dec 2013, Sarah Sharp wrote: On Thu, Dec 19, 2013 at 11:48:47AM -0800, James Bottomley wrote: It should apply incrementally on top of the previous two. If it actually works,

[PATCH 1/1] usb: gadget: printer: using gadget_is_otg to check otg support at runtime

2014-01-03 Thread Peter Chen
We need to use gadget_is_otg to check if the gadget is really otg support at runtime, other composite gadget drivers have already followed this method. Signed-off-by: Peter Chen --- drivers/usb/gadget/printer.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/usb

Re: [PATCH net-next v2 6/6] r8152: support RTL8153

2014-01-03 Thread Bjørn Mork
hayeswang writes: > Bjørn Mork [mailto:bj...@mork.no] >> Sent: Thursday, January 02, 2014 10:25 PM >> To: Hayeswang >> Cc: oli...@neukum.org; net...@vger.kernel.org; nic_swsd; >> linux-ker...@vger.kernel.org; linux-usb@vger.kernel.org >> Subject: Re: [PATCH net-next v2 6/6] r8152: support RTL8

Re: [PATCH 04/16] USB: pl2303: switch to generic TIOCMIWAIT implementation

2014-01-03 Thread Arnd Bergmann
On Thursday 02 January 2014, Johan Hovold wrote: > Switch to the generic TIOCMIWAIT implementation which does not suffer > from the races involved when using the deprecated sleep_on functions. > > Cc: Arnd Bergmann > Signed-off-by: Johan Hovold Acked-by: Arnd Bergmann -- To unsubscribe from th

Re: [PATCH, RFC 15/30] usbserial: stop using interruptible_sleep_on

2014-01-03 Thread Arnd Bergmann
On Thursday 02 January 2014, Johan Hovold wrote: > I'd prefer to just fix the race once and for all. These four drivers > have been on my todo list since I converted the other usb-serial drivers > about a year ago. In fact, I posted a fix for f81232 last week, and > I've had a fix for pl2303 brewin

Re: [PATCH 08/16] USB: cypress_m8: switch to generic TIOCMIWAIT implementation

2014-01-03 Thread Arnd Bergmann
On Thursday 02 January 2014, Johan Hovold wrote: > Switch to the generic TIOCMIWAIT implementation which does not suffer > from the races involved when using the deprecated sleep_on functions. > > Cc: Arnd Bergmann > Signed-off-by: Johan Hovold Acked-by: Arnd Bergmann -- To unsubscribe from th

Re: [PATCH 13/16] USB: ch341: switch to generic TIOCMIWAIT implementation

2014-01-03 Thread Arnd Bergmann
On Thursday 02 January 2014, Johan Hovold wrote: > Switch to the generic TIOCMIWAIT implementation which does not suffer > from the races involved when using the deprecated sleep_on functions. > > Cc: Arnd Bergmann > Signed-off-by: Johan Hovold Acked-by: Arnd Bergmann -- To unsubscribe from th

Re: [RFC 0/2] target refcounting infrastructure fixes for usb

2014-01-03 Thread James Bottomley
On Fri, 2014-01-03 at 09:56 +0100, Hans de Goede wrote: > James, what is the status of getting the fix for the refcount issue into > mainline ? The plan is what I wrote in the patch intro: "Since it's a major change to the infrastructure, we'll incubate upstream first before backp

Re: gadgetfs USB2.0 Chapter 9 Tests: Test after "Addressed State" fails

2014-01-03 Thread Marco Zamponi
Thank you Roshan for the patch and thank you Michal for the discussion! Appearently I am not as familiar with USB as you guys are. But what I understood from the discussion is, that if I apply the patch from Roshan to f_fs.c and composite.c, the CV Test should not fail? Thanks! On Tue, Dec 24, 20

Re: gadgetfs USB2.0 Chapter 9 Tests: Test after "Addressed State" fails

2014-01-03 Thread Michal Nazarewicz
On Fri, Jan 03 2014, Marco Zamponi wrote: > Thank you Roshan for the patch and thank you Michal for the discussion! > Appearently I am not as familiar with USB as you guys are. But what I > understood from the discussion is, that if I apply the patch from Roshan to > f_fs.c and composite.c, the CV

Re: [PATCH 3.12 033/118] usb: xhci: Link TRB must not occur within a USB payload burst

2014-01-03 Thread walt
On 01/02/2014 11:15 AM, Sarah Sharp wrote: > On Tue, Dec 31, 2013 at 12:40:16PM -0800, walt wrote: >> On 12/18/2013 01:11 PM, Greg Kroah-Hartman wrote: >>> 3.12-stable review patch. If anyone has any objections, please let me know. >>> >>> -- >>> >>> From: David Laight >>> >>> com

Re: Similar Elan Touchscreen reset behaviour

2014-01-03 Thread Alan Stern
On Thu, 2 Jan 2014, Sarah Sharp wrote: > On Sun, Dec 29, 2013 at 06:28:20AM -0800, Eric Decker wrote: > > When I boot using a live USB (the kernel in this case is > > vmlinuz-3.11.0.12-generic), I see a couple of messages and then the kernel > > finishes (that is it doesn't hang). *Although the

Re: [RFC 2/2] dual scan thread bug fix

2014-01-03 Thread Alan Stern
On Thu, 2 Jan 2014, James Bottomley wrote: > In the highly unusual case where two threads are running concurrently through > the scanning code scanning the same target, we run into the situation where > one may allocate the target while the other is still using it. In this case, > because the rea

Re: mmotm 2014-01-02-14-35 uploaded (musb)

2014-01-03 Thread Randy Dunlap
On 01/02/14 14:36, a...@linux-foundation.org wrote: > The mm-of-the-moment snapshot 2014-01-02-14-35 has been uploaded to > >http://www.ozlabs.org/~akpm/mmotm/ > > mmotm-readme.txt says > > README for mm-of-the-moment: > > http://www.ozlabs.org/~akpm/mmotm/ > > This is a snapshot of my -mm

Re: [PATCH v1] xhci: Switch Intel Lynx Point ports to EHCI on shutdown

2014-01-03 Thread Oliver Neukum
On Thu, 2014-01-02 at 16:03 -0800, Sarah Sharp wrote: > That means your system worked fine in 3.13-rc3 (when the quirk was > applied broadly), but won't work for 3.13-rc6 (when the quirk was > narrowed to HP machines). So we need the quirk to apply to your > systems > as well. > > ISTR that the o

Re: [PATCH v1] xhci: Switch Intel Lynx Point ports to EHCI on shutdown

2014-01-03 Thread art1
On 01/03/2014 01:03 AM, Sarah Sharp wrote: ISTR that the other folks on Cc (Meng, Niklas, Giorgos, and Art) all had systems that broke when commit 638298dc66ea36623dbc2757a24fc2c4ab41b016 was introduced. For those systems, what vendor was the system, and what BIOS was it running? Information f

Re: [PATCH 3.12 033/118] usb: xhci: Link TRB must not occur within a USB payload burst

2014-01-03 Thread Sarah Sharp
On Fri, Jan 03, 2014 at 07:40:33AM -0800, walt wrote: > On 01/02/2014 11:15 AM, Sarah Sharp wrote: > > On Tue, Dec 31, 2013 at 12:40:16PM -0800, walt wrote: > >> On 12/18/2013 01:11 PM, Greg Kroah-Hartman wrote: > >>> 3.12-stable review patch. If anyone has any objections, please let me > >>> kno

Re: mmotm 2014-01-02-14-35 uploaded (musb)

2014-01-03 Thread Felipe Balbi
On Fri, Jan 03, 2014 at 09:57:50AM -0800, Randy Dunlap wrote: > On 01/02/14 14:36, a...@linux-foundation.org wrote: > > The mm-of-the-moment snapshot 2014-01-02-14-35 has been uploaded to > > > >http://www.ozlabs.org/~akpm/mmotm/ > > > > mmotm-readme.txt says > > > > README for mm-of-the-mom

Re: xHCI driver Bug report (Babble reported at enumeration for cam that works in Windows)

2014-01-03 Thread Sarah Sharp
On Fri, Jan 03, 2014 at 12:48:26AM +, Marius Silaghi wrote: > Thanks > Running 3.12.4 > > During the holiday I managed to solve my problem with the following small > patch (could it be added to the mainstream kernel such that it would be > solved when we upgrade to the future kernels?): H

Re: Similar Elan Touchscreen reset behaviour

2014-01-03 Thread Alan Stern
On Fri, 3 Jan 2014, Eric Decker wrote: > On Fri, Jan 3, 2014 at 7:46 AM, Alan Stern wrote: > > > On Thu, 2 Jan 2014, Sarah Sharp wrote: > > > > > On Sun, Dec 29, 2013 at 06:28:20AM -0800, Eric Decker wrote: > > > > > > When I boot using a live USB (the kernel in this case is > > > > vmlinuz-3.11.

XHCI (possible) bug

2014-01-03 Thread Felipe Balbi
Hi Sarah, I'm running v3.12.1 on my desktop pc and today I got into rather weird state when I was testing an old OMAP3 platform (as device) connected trough xHCI. Even after disconnecting the device, I still see it as if it was still present on the bus. All I was doing was connecting and disconne

Re: [PATCH 0/7] Chipidea Fix for 3.13-rc2

2014-01-03 Thread Greg KH
On Fri, Dec 27, 2013 at 01:37:48PM +0800, Peter Chen wrote: > On Thu, Dec 05, 2013 at 03:20:48PM +0800, Peter Chen wrote: > > Hi Greg, > > > > This patchset includes chipidea fixes for 3.13-rc2, the mainly > > fixes include add correct imx28 write register method, fixing > > un-initialized variabl

Re: [GIT PULL] usb patches for v3.14 merge window

2014-01-03 Thread Greg KH
On Thu, Dec 26, 2013 at 04:36:59PM -0600, Felipe Balbi wrote: > Hi Greg, > > Here's my overly extensive pull request for v3.14 merge window. Lots > of work has happened for next merge window. > > All patches have been tested with all ARM defconfigs, i386_defconfig, > kvm_guest.config, x86_64_defc

Re: [PATCH 00/26] USB: serial: patches for v3.14

2014-01-03 Thread Greg Kroah-Hartman
On Sun, Dec 29, 2013 at 07:22:52PM +0100, Johan Hovold wrote: > Hi Greg, > > Here are a few patches for v3.14 (if it's not to late) including a new > driver by Andrew Lunn (and Moxa) for MOXA UPort devices, some subsystem > wide cleanups, and some pl2303 driver improvements. > > The pl2303 patche

Re: [PATCH v1] USB: chipidea: correct spelling mistakes in comment

2014-01-03 Thread Greg KH
On Wed, Jan 01, 2014 at 10:02:34AM +0530, Rahul Bedarkar wrote: > Changes are as follows: Changes for what, this patch? > 1. Reverted drivers/usb/chipidea/ci_hdrc_pci.c as zeroes and zeros either are > acceptable What do you mean, you don't touch this file in this patch. totally confused... g

Re: [PATCH v1] USB: chipidea: correct spelling mistakes in comment

2014-01-03 Thread Randy Dunlap
On 01/03/14 12:37, Greg KH wrote: > On Wed, Jan 01, 2014 at 10:02:34AM +0530, Rahul Bedarkar wrote: >> Changes are as follows: > > Changes for what, this patch? > >> 1. Reverted drivers/usb/chipidea/ci_hdrc_pci.c as zeroes and zeros either >> are acceptable > > What do you mean, you don't touch

Re: [PATCH v1] USB: core: correct spelling mistakes in comments and warning

2014-01-03 Thread Greg KH
On Wed, Jan 01, 2014 at 09:59:30AM +0530, Rahul Bedarkar wrote: > Changed warning string to "port %d not suspended yet" That's not the description for this whole patch :( sorry, please fix this up and resend. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the

Re: mmotm 2014-01-02-14-35 uploaded (musb)

2014-01-03 Thread Randy Dunlap
On 01/03/14 12:02, Felipe Balbi wrote: > On Fri, Jan 03, 2014 at 09:57:50AM -0800, Randy Dunlap wrote: >> On 01/02/14 14:36, a...@linux-foundation.org wrote: >>> The mm-of-the-moment snapshot 2014-01-02-14-35 has been uploaded to >>> >>>http://www.ozlabs.org/~akpm/mmotm/ >>> >>> mmotm-readme.tx

Re: [PATCH 3.12 033/118] usb: xhci: Link TRB must not occur within a USB payload burst

2014-01-03 Thread walt
On 01/03/2014 11:54 AM, Sarah Sharp wrote: > On Fri, Jan 03, 2014 at 07:40:33AM -0800, walt wrote: >> On 01/02/2014 11:15 AM, Sarah Sharp wrote: >>> On Tue, Dec 31, 2013 at 12:40:16PM -0800, walt wrote: On 12/18/2013 01:11 PM, Greg Kroah-Hartman wrote: > 3.12-stable review patch. If anyon

Re: [RFC 0/2] target refcounting infrastructure fixes for usb

2014-01-03 Thread Sarah Sharp
On Fri, Jan 03, 2014 at 09:56:45AM +0100, Hans de Goede wrote: > Hi, > > On 01/03/2014 01:45 AM, Sarah Sharp wrote: > >Ok, Alan's additional patch fixed the warnings I was seeing on UAS > >device unplug. James, can you Cc me on the finished patch when you send > >it in? > > > >Hans, I don't want

Re: [RFC 0/2] target refcounting infrastructure fixes for usb

2014-01-03 Thread Hans de Goede
Hi, On 01/03/2014 11:00 PM, Sarah Sharp wrote: On Fri, Jan 03, 2014 at 09:56:45AM +0100, Hans de Goede wrote: Hi, On 01/03/2014 01:45 AM, Sarah Sharp wrote: Ok, Alan's additional patch fixed the warnings I was seeing on UAS device unplug. James, can you Cc me on the finished patch when you s

Re: [PATCH 3.12 033/118] usb: xhci: Link TRB must not occur within a USB payload burst

2014-01-03 Thread Sarah Sharp
On Fri, Jan 03, 2014 at 01:21:18PM -0800, walt wrote: > I'm so sorry Sarah, that was another mistake. The mistake is so stupid I'm > not > going to publish it here :( > > Once I finally ran the kernel with debugging actually compiled in, dmesg > contains > xhci debugging messages. Wow :) > >

[PATCH] usb: Skip U1/U2 LPM disable if device is disconnected.

2014-01-03 Thread Sarah Sharp
Occasionally when a USB 3.0 device is disconnected, the roothub port goes into the SS.Inactive state, rather than reporting a disconnect. A warm reset is the only way to get out of this state. khubd notices the link state in hub_port_events(), and since a udev is active on that port, it calls int

Re: [PATCH] usb: Skip U1/U2 LPM disable if device is disconnected.

2014-01-03 Thread Greg KH
On Fri, Jan 03, 2014 at 04:22:45PM -0800, Sarah Sharp wrote: > Occasionally when a USB 3.0 device is disconnected, the roothub port > goes into the SS.Inactive state, rather than reporting a disconnect. Is that a hardware bug? Or just something inherent in how the spec says things can work? than

Re: [PATCH v3 1/2] usb: musb: add support for JZ4740 usb device controller

2014-01-03 Thread Richard Weinberger
On Thu, Dec 19, 2013 at 9:42 PM, Apelete Seketeli wrote: > Add support for Ingenic JZ4740 USB Device Controller through a > specific musb glue layer. > > JZ4740 UDC not being OTG compatible and missing some hardware > registers, this musb glue layer is written from scratch to be used in > gadget m

Re: [PATCH net-next] r8152: fix the wrong return value

2014-01-03 Thread David Miller
From: Hayes Wang Date: Fri, 3 Jan 2014 11:21:56 +0800 > The return value should be the boolean value, not the error code. > > Signed-off-by: Hayes Wang > Spotted-by: Dan Carpenter Applied, but I agree with others that it's more canonical to have the function return either an error code, or ze

Re: [RFC 2/2] dual scan thread bug fix

2014-01-03 Thread James Bottomley
On Fri, 2014-01-03 at 10:58 -0500, Alan Stern wrote: > On Thu, 2 Jan 2014, James Bottomley wrote: > > > In the highly unusual case where two threads are running concurrently > > through > > the scanning code scanning the same target, we run into the situation where > > one may allocate the targe

[PATCH] USB: wusbcore: correct spelling mistakes in comments and error string

2014-01-03 Thread Rahul Bedarkar
Signed-off-by: Rahul Bedarkar --- drivers/usb/wusbcore/cbaf.c | 2 +- drivers/usb/wusbcore/crypto.c | 2 +- drivers/usb/wusbcore/devconnect.c | 4 ++-- drivers/usb/wusbcore/security.c | 2 +- drivers/usb/wusbcore/wa-hc.h | 10 +- drivers/usb/wusbcore/wa-rpipe.c |

[PATCH] USB: wusbcore: fix up minor coding style issues in cbaf.c

2014-01-03 Thread Rahul Bedarkar
Signed-off-by: Rahul Bedarkar --- drivers/usb/wusbcore/cbaf.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/usb/wusbcore/cbaf.c b/drivers/usb/wusbcore/cbaf.c index 66a6e6f..b423fe6 100644 --- a/drivers/usb/wusbcore/cbaf.c +++ b/drivers/usb/wusbcore/cbaf

Re: [PATCH] USB: wusbcore: correct spelling mistakes in comments and error string

2014-01-03 Thread Randy Dunlap
On 01/03/14 21:47, Rahul Bedarkar wrote: > > Signed-off-by: Rahul Bedarkar > --- > drivers/usb/wusbcore/cbaf.c | 2 +- > drivers/usb/wusbcore/crypto.c | 2 +- > drivers/usb/wusbcore/devconnect.c | 4 ++-- > drivers/usb/wusbcore/security.c | 2 +- > drivers/usb/wusbcore/wa-hc.h

[PATCH] USB: core: correct spelling mistakes in comments and warning

2014-01-03 Thread Rahul Bedarkar
Signed-off-by: Rahul Bedarkar --- drivers/usb/core/buffer.c | 2 +- drivers/usb/core/devio.c| 2 +- drivers/usb/core/hcd.c | 2 +- drivers/usb/core/hub.c | 7 --- drivers/usb/core/hub.h | 2 +- drivers/usb/core/message.c | 4 ++-- drivers/usb/core/sysfs.c| 2 +- driv

CP2102 mystery - ttyUSB0 vs usbfs

2014-01-03 Thread Dave Mielke
Members of this list may recall a question I asked regarding the CP2102 serial adapter a couple of weeks ago. For the curious, my original message is attached to this one. At the time, I was rather frustrated at the "go away and figure it out for yourself" response, but, in the end, I'm glad I t

[PATCH v2] USB: wusbcore: correct spelling mistakes in comments and error string

2014-01-03 Thread Rahul Bedarkar
Signed-off-by: Rahul Bedarkar --- drivers/usb/wusbcore/cbaf.c | 2 +- drivers/usb/wusbcore/crypto.c | 2 +- drivers/usb/wusbcore/devconnect.c | 4 ++-- drivers/usb/wusbcore/security.c | 2 +- drivers/usb/wusbcore/wa-hc.h | 10 +- drivers/usb/wusbcore/wa-rpipe.c |