Re: USB sound auto-suspend not working

2013-12-18 Thread Oliver Neukum
On Tue, 2013-12-17 at 14:55 -0800, Sarah Sharp wrote: > Hi Oliver and Takashi, > > I've noticed that in the last couple kernel releases or so, I can't get > USB webcams to suspend. It turns out that the USB sound interface is > keeping the device active, even when the device is not playing sound.

XHCI issues: WD MyBook 1230 - reset SuperSpeed USB device

2013-12-18 Thread Peter Palúch
Greetings, I have an HP EliteBook 8560p, I am running Linux kernel 3.12.3, and I am trying to connect a WDC MyBook 1230 3TB SuperSpeed USB hard drive to the notebook. I am often (though not consistently) having problems with the access to the drive stalling for several seconds, and the kernel

About SRP and HNP features at OTG descriptor

2013-12-18 Thread Peter Chen
Hi Felipe, According to the newest OTG & EH spec (On-The-Go and Embedded Host Supplement to the USB Revision 2.0 Specification July 27, 2012 Revision 2.0 version 1.1a), the OTG descriptor is needed for B device, even for peripheral-only B device (see chapter 6.1 OTG Descriptor). At current code, o

RE: [PATCH] xhci: fix array index out of the bounds in function last_trb() and last_trb_on_last_seg()

2013-12-18 Thread David Laight
> > Then the inc_deq() code could just be: > > > > ring->deq_updates++; > > ring->num_trbs_free++; > > > > if (last_trb(xhci, ring, ring->deq_seg, ++ring->dequeue)) { > > ring->deq_seg = ring->deq_seg->next; > > ring->dequeue = ring->deq_seg->trbs; > >

Re: [PATCH] usb: dwc3: ep0: Handle variable-length Data Stage

2013-12-18 Thread Pratyush Anand
Hi Anton, On Wed, Dec 18, 2013 at 12:11:33PM +0800, Felipe Balbi wrote: > Hi, > > On Tue, Dec 17, 2013 at 03:59:31PM +0900, Anton Tikhomirov wrote: > > In accordance with specification, when sent data length is > > please mention section of specification. > > > an exact multiple of wMaxPacketSi

[PATCH] mfd: omap-usb-tll: Don't hold lock during pm_runtime_get/put_sync()

2013-12-18 Thread Roger Quadros
pm_runtime_get/put_sync() can sleep so don't hold spinlock while calling them. This patch prevents a BUG() when CONFIG_DEBUG_ATOMIC_SLEEP is enabled. Bug is present in Kernel versions v3.9 onwards. Reported-by: Tomi Valkeinen Signed-off-by: Roger Quadros Tested-by: Tomi Valkeinen Cc: # 3.9+ -

[PATCH 1/2] usb: usbtest: Add timetout to simple_io()

2013-12-18 Thread Roger Quadros
Without a timetout some tests e.g. test_halt() can remain stuck forever. Signed-off-by: Roger Quadros Reviewed-by: Felipe Balbi --- drivers/usb/misc/usbtest.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/usb/misc/usbtest.c b/drivers/usb/misc/usbtes

[PATCH 2/2] usb: usbtest: Always clear halt else further tests will fail

2013-12-18 Thread Roger Quadros
In test_halt() we set an endpoint halt condition and return on halt verification failure, then the enpoint will remain halted and all further tests related to that enpoint will fail. This is because we don't tackle endpoint halt error condition in any of the tests. To avoid that situation, make su

Re: [PATCH] mfd: omap-usb-tll: Don't hold lock during pm_runtime_get/put_sync()

2013-12-18 Thread Lee Jones
> pm_runtime_get/put_sync() can sleep so don't hold spinlock while > calling them. > > This patch prevents a BUG() when CONFIG_DEBUG_ATOMIC_SLEEP is enabled. > Bug is present in Kernel versions v3.9 onwards. > > Reported-by: Tomi Valkeinen > Signed-off-by: Roger Quadros > Tested-by: Tomi Valkei

[RFC 5/5] usb: dwc3: enable async suspend/resume

2013-12-18 Thread Yuvaraj Kumar C D
From: Andrew Bresticker In addition to enabling async suspend/resume on the xhci-plat device, we must enable it for the dwc3 device (the parent of xhci-plat) in order to make the full USB stack resume asynchronously. Like the xhci-plat, ehci-s5p, and ohci-exynos drivers, there are no outside dep

[RFC 3/5] usb: xhci-plat: enable async suspend/resume

2013-12-18 Thread Yuvaraj Kumar C D
From: Andrew Bresticker USB host controllers can take a significant amount of time to suspend and resume, adding several hundred miliseconds to the kernel resume time. Since the XHCI controller has no outside dependencies (other than clocks, which are suspended late/resumed early), allow it to su

[RFC 4/5] usb: dwc3-exynos: enable async suspend/resume

2013-12-18 Thread Yuvaraj Kumar C D
From: Andrew Bresticker In addition to enabling async suspend/resume on the xhci-plat device, we must enable it for the dwc3-exynos platform device in order to make the full USB stack resume asynchronously. Like the xhci-plat, ehci-s5p, and ohci-exynos drivers, there are no outside dependencies

[RFC 1/5] usb: ohci-exynos: enable async suspend/resume

2013-12-18 Thread Yuvaraj Kumar C D
From: Andrew Bresticker USB host controllers can take a significant amount of time to suspend and resume, adding several hundred miliseconds to the kernel resume time. Since the Exynos OHCI controller has no outside dependencies (other than clocks, which are suspended late/resumed early), allow i

[RFC 2/5] usb: ehci-s5p: enable async suspend/resume

2013-12-18 Thread Yuvaraj Kumar C D
From: Andrew Bresticker USB host controllers can take a significant amount of time to suspend and resume, adding several hundred miliseconds to the kernel resume time. Since the Exynos EHCI controller has no outside dependencies (other than clocks, which are suspended late/resumed early), allow i

[PATCH v3] usb: xhci Use TRB_CYCLE instead of the constant 0x1.

2013-12-18 Thread David Laight
Using TRB_CYCLE makes it clearer that the ring->cycle_state value is used when writing to the actual ring itself. Always use ^= TRB_CYCLE to invert the bit. Revert the part of 186a7ef13a8f (xHCI: set cycle state when allocate rings) that passed the cycle state to xhci_ring_alloc() and xhci_initia

RE: [PATCH v3] usb: xhci Use TRB_CYCLE instead of the constant 0x1.

2013-12-18 Thread David Laight
> From: Of David Laight > Using TRB_CYCLE makes it clearer that the ring->cycle_state value is used when > writing to the actual ring itself. FWIW this patch is against Linus's tree. This hunk probably fails to apply to some trees because the patch to force TRB_CYCLE to be little endian hasn't got

[PATCH v2] xhci: Allocate the td array and urb_priv together.

2013-12-18 Thread David Laight
This saves a kzalloc() call on every transfer and some memory indirections. The only possible downside is for isochronous tranfers with 64 td when the allocate is 8+4096 bytes (on 64bit systems) so requires an additional page. Signed-off-by: David Laight --- v2: Added signed-off-by line drive

Re: [PATCH V3] usb: musb: Fix unstable init of OTG_INTERFSEL.

2013-12-18 Thread Grazvydas Ignotas
On Wed, Dec 18, 2013 at 9:41 AM, Andreas Naumann wrote: > Am 17.12.2013 18:22, schrieb David Cohen: > >> On Tue, Dec 17, 2013 at 05:48:33PM +0100, anaum...@ultratronik.de wrote: >>> >>> From: Andreas Naumann >>> >>> This is a hard to reproduce problem which leads to non-functional >>> USB-OTG por

[PATCH v2] usb: xhci: Add a 2nd memory barrier to giveback_first_trb()

2013-12-18 Thread David Laight
Add a wmb() barrier between the write to the cycle bit in the first TRB and the write to the doorbell register. Without this the hardware might read the ring entry before the write completes and not action the transfer until the next time a request is added. Since it isn't needed in the other plac

[PATCH v2] usb: xhci: Rename xhci_queue_xxx_tx() to xhci_queue_xxx_urb()

2013-12-18 Thread David Laight
The xhci_queue_bulk_tx() function is used for both OUT and IN transactions, but the name implies that it is only used for transmits. Rename it to xhci_queue_bulk_urb() to avoid any confusion. Similarly rename the functions for ctrl, intr and isoc URB. Rename the existing xhci_queue_isoc_tx() to wr

[PATCH] usb: dwc3: dwc3-omap: Fix the crash in module removal

2013-12-18 Thread George Cherian
In the wrapper driver the child nodes are populated using of_platform_populate(), which does a device_add. So while removing the module if platform_device_unregister is called it leads to following crash. [ 57.676757] Unable to handle kernel NULL pointer dereference at virtual address 0018

Re: [PATCH 1/1] hso: fix problem with wrong status code sent by OPTION GTM601 during RING indication

2013-12-18 Thread Dr. H. Nikolaus Schaller
Hi Dan, Am 17.12.2013 um 23:27 schrieb Dan Williams: > On Tue, 2013-12-17 at 20:56 +0100, Dr. H. Nikolaus Schaller wrote: >> Hi Dan, >> >> Am 16.12.2013 um 20:40 schrieb Dan Williams: >> >>> On Fri, 2013-12-13 at 15:43 +0100, Dr. H. Nikolaus Schaller wrote: Hi, Am 02.10.2013 um

[PATCH] usb: phy: am335x: Enable USB remote wakeup using PHY wakeup

2013-12-18 Thread George Cherian
USB remote wakeup using PHY wakeup is supported only in standby mode. Enabling the PHY_WKUP will break DS0 mode of system suspend. If the same is enabled while entering DS0, AM33xx never stays in DS0, it returns immediately from DS0. By default make the PHY wakeup disabled, using sysfs entry enable

[RESEND PATCH] usb: dwc3: fix the glue drivers using the nop phy

2013-12-18 Thread Heikki Krogerus
The reset_gpio member of the usb_phy_gen_xceiv_platform_data structure needs the have negative value or phy-generic's probe will fail unless DT is used. 0 is a valid gpio number. This fixes an issue where phy-generic fails to probe with message: "usb_phy_gen_xceiv.0: Error requesting RESET GPIO 0"

RE: [PATCH] usb: xhci: Rename xhci_queue_xxx_tx() to xhci_queue_xxx_urb()

2013-12-18 Thread David Laight
> From: Sarah Sharp > Hi David, > > This patch is fine in general, however I can't seem to get it to apply. > I tried 3.12, 3.13-rc4, and my for-usb-next-queue branch, and `git am` > failed on all three kernels. Can you rebase this against either > 3.13-rc4 or my for-usb-next-queue branch? I've

Re: [PATCH v2 1/3] mips: qi_lb60: add defconfig for Ben NanoNote

2013-12-18 Thread Sergei Shtylyov
Hello. On 18-12-2013 3:55, Apelete Seketeli wrote: Add defconfig for the Ben NanoNote handheld computer which is built around QI_LB60 board and Ingenic JZ4740 MIPS SoC. Signed-off-by: Apelete Seketeli --- arch/mips/configs/qi_lb60_defconfig | 188 +++ 1 f

Re: [PATCH 1/2] usb: usbtest: Add timetout to simple_io()

2013-12-18 Thread Huang Rui
Hi Roger, On Wed, Dec 18, 2013 at 03:40:10PM +0530, Roger Quadros wrote: > Without a timetout some tests e.g. test_halt() can remain stuck forever. > > Signed-off-by: Roger Quadros > Reviewed-by: Felipe Balbi > --- > drivers/usb/misc/usbtest.c | 14 +++--- > 1 file changed, 11 insertio

[PATCH] usb: xhci: Rename constants for truncated bulk transfers.

2013-12-18 Thread David Laight
Rename the constants XHCI_TRUST_TX_LENGTH to XHCI_TRUST_RX_LENGTH and COMP_SHORT_TX to COMP_SHORT_RX to avoid any confusion that they might apply to transmit transfers. Signed-off-by: David Laight --- I can't actually see any driver that requires this quirk! Note that this replaces part of the

[PATCH] usb: xhci: Don't trace all short/incomplete receives.

2013-12-18 Thread David Laight
Don't trace unexpected incomplete receives if the XHCI_TRUST_RX_LENGTH is set. Don't trace short receives if URB_SHORT_NOT_OK is set. Short receives are normal for USB ethernet devices. Ratelimit both traces. Signed-off-by: David Laight --- This is dependent on my previous patch to rename XHCI

Re: [PATCH V3] usb: musb: Fix unstable init of OTG_INTERFSEL.

2013-12-18 Thread Felipe Balbi
Hi, On Tue, Dec 17, 2013 at 05:48:33PM +0100, anaum...@ultratronik.de wrote: > From: Andreas Naumann > > This is a hard to reproduce problem which leads to non-functional > USB-OTG port in 0.1%-1% of all boots. Tracked it down to commit > e25bec160158abe86c276d7d206264afc3646281, which introduce

Re: [PATCH 0/7] usb: dwc3: pm_runtime implementation

2013-12-18 Thread Felipe Balbi
Hi, On Tue, Dec 17, 2013 at 03:35:54PM -0800, David Cohen wrote: > On Tue, Dec 17, 2013 at 03:31:40PM -0800, David Cohen wrote: > > On Thu, Dec 12, 2013 at 03:38:38PM -0600, Felipe Balbi wrote: > > > hi all, > > > > > > these patches add pm_runtime support for all glue layers. > > > > > > I plan

Re: [PATCH 0/7] usb: dwc3: pm_runtime implementation

2013-12-18 Thread Felipe Balbi
On Wed, Dec 18, 2013 at 09:36:14AM -0600, Felipe Balbi wrote: > Hi, > > On Tue, Dec 17, 2013 at 03:35:54PM -0800, David Cohen wrote: > > On Tue, Dec 17, 2013 at 03:31:40PM -0800, David Cohen wrote: > > > On Thu, Dec 12, 2013 at 03:38:38PM -0600, Felipe Balbi wrote: > > > > hi all, > > > > > > > >

Re: [PATCH] usb: phy: fix driver dependencies

2013-12-18 Thread Felipe Balbi
Hi, On Wed, Dec 18, 2013 at 05:33:52PM +1100, Stephen Rothwell wrote: > > > > > > > both isp1301-omap and fsl_usb2_otg drivers > > > > > > > depend on usb_bus_start_enum() which is only > > > > > > > defined if CONFIG_USB != n. There is a problem, > > > > > > > however, where both those drivers co

Re: [PATCH] usb: dwc3: ep0: Handle variable-length Data Stage

2013-12-18 Thread Felipe Balbi
Hi, On Wed, Dec 18, 2013 at 03:22:07PM +0530, Pratyush Anand wrote: > > > In accordance with specification, when sent data length is > > > > please mention section of specification. > > > > > an exact multiple of wMaxPacketSize for the pipe and less > > > than requested by host, the function sha

Re: [PATCH v2 1/3] mips: qi_lb60: add defconfig for Ben NanoNote

2013-12-18 Thread Apelete Seketeli
Hello, On 18-Dec-13, Sergei Shtylyov wrote: > Hello. > > On 18-12-2013 3:55, Apelete Seketeli wrote: > > >Add defconfig for the Ben NanoNote handheld computer which is built > >around QI_LB60 board and Ingenic JZ4740 MIPS SoC. > > >Signed-off-by: Apelete Seketeli > >--- > > arch/mips/configs/

Re: [RFC 5/5] usb: dwc3: enable async suspend/resume

2013-12-18 Thread Felipe Balbi
On Wed, Dec 18, 2013 at 04:09:34PM +0530, Yuvaraj Kumar C D wrote: > From: Andrew Bresticker > > In addition to enabling async suspend/resume on the xhci-plat device, > we must enable it for the dwc3 device (the parent of xhci-plat) in order > to make the full USB stack resume asynchronously. Li

Re: [RFC 4/5] usb: dwc3-exynos: enable async suspend/resume

2013-12-18 Thread Felipe Balbi
On Wed, Dec 18, 2013 at 04:09:33PM +0530, Yuvaraj Kumar C D wrote: > From: Andrew Bresticker > > In addition to enabling async suspend/resume on the xhci-plat device, > we must enable it for the dwc3-exynos platform device in order to make > the full USB stack resume asynchronously. Like the xhc

[PATCH] Change nop_cmd to __le32 to fix sparse warnings.

2013-12-18 Thread David Laight
Code is correct since the value and final target are both little-endian. Signed-off-by: David Laight --- drivers/usb/host/xhci-ring.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c index 2315be1..0420daf 100644 ---

Re: [PATCH] usb: dwc3: dwc3-omap: Fix the crash in module removal

2013-12-18 Thread Felipe Balbi
Hi, On Wed, Dec 18, 2013 at 06:35:09PM +0530, George Cherian wrote: > In the wrapper driver the child nodes are populated using > of_platform_populate(), which does a device_add. So while > removing the module if platform_device_unregister is called > it leads to following crash. > > [ 57.67675

Suspend issues with a LaCie USB hard disk connected

2013-12-18 Thread Daniel Mack
Hi, I'm facing an issue putting an embedded system to sleep while a Lacie external USB hard disk is connected. Relevant kernel messages that occur at the attempt are: [ 13.834731] PM: Sending message for entering DeepSleep mode [ 13.846575] sd 0:0:0:0: [sda] Synchronizing SCSI cache [ 13.85

Re: [PATCH v7 8/9] phy: add Broadcom Kona USB2 PHY driver

2013-12-18 Thread Felipe Balbi
On Tue, Dec 17, 2013 at 02:42:35PM -0500, Matt Porter wrote: > Add a driver for the internal Broadcom Kona USB 2.0 PHY found > on the BCM281xx family of SoCs. > > Signed-off-by: Matt Porter Kishon, are you ok with this driver ? > +static int bcm_kona_usb2_probe(struct platform_device *pdev) > +

Re: [PATCH] usb: phy: am335x: Enable USB remote wakeup using PHY wakeup

2013-12-18 Thread Felipe Balbi
Hi, On Wed, Dec 18, 2013 at 06:52:09PM +0530, George Cherian wrote: > USB remote wakeup using PHY wakeup is supported only in standby mode. > Enabling the PHY_WKUP will break DS0 mode of system suspend. > If the same is enabled while entering DS0, AM33xx never stays in DS0, > it returns immediatel

Re: [PATCH 1/2] usb: usbtest: Add timetout to simple_io()

2013-12-18 Thread Felipe Balbi
On Wed, Dec 18, 2013 at 10:46:03PM +0800, Huang Rui wrote: > Hi Roger, > > On Wed, Dec 18, 2013 at 03:40:10PM +0530, Roger Quadros wrote: > > Without a timetout some tests e.g. test_halt() can remain stuck forever. > > > > Signed-off-by: Roger Quadros > > Reviewed-by: Felipe Balbi > > --- > >

Re: [PATCH v7 8/9] phy: add Broadcom Kona USB2 PHY driver

2013-12-18 Thread Matt Porter
On Wed, Dec 18, 2013 at 10:25:54AM -0600, Felipe Balbi wrote: > On Tue, Dec 17, 2013 at 02:42:35PM -0500, Matt Porter wrote: > > Add a driver for the internal Broadcom Kona USB 2.0 PHY found > > on the BCM281xx family of SoCs. > > > > Signed-off-by: Matt Porter > > Kishon, are you ok with this d

Re: USB sound auto-suspend not working

2013-12-18 Thread Takashi Iwai
At Tue, 17 Dec 2013 14:55:48 -0800, Sarah Sharp wrote: > > Hi Oliver and Takashi, > > I've noticed that in the last couple kernel releases or so, I can't get > USB webcams to suspend. It turns out that the USB sound interface is > keeping the device active, even when the device is not playing so

Re: [PATCH v2 1/3] mips: qi_lb60: add defconfig for Ben NanoNote

2013-12-18 Thread Sergei Shtylyov
Hello. On 12/18/2013 07:00 PM, Apelete Seketeli wrote: Add defconfig for the Ben NanoNote handheld computer which is built around QI_LB60 board and Ingenic JZ4740 MIPS SoC. Signed-off-by: Apelete Seketeli --- arch/mips/configs/qi_lb60_defconfig | 188 +++

[GIT PULL] USB fixes for 3.13-rc5

2013-12-18 Thread Greg KH
The following changes since commit 2d51f3cd11f414c56a87dc018196b85fd50b04a4: usb: hub: Use correct reset for wedged USB3 devices that are NOTATTACHED (2013-12-04 17:00:43 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/ tags/usb-3

Re: [PATCH 1/1] hso: fix problem with wrong status code sent by OPTION GTM601 during RING indication

2013-12-18 Thread Dan Williams
On Wed, 2013-12-18 at 14:16 +0100, Dr. H. Nikolaus Schaller wrote: > Hi Dan, > > Am 17.12.2013 um 23:27 schrieb Dan Williams: > > > On Tue, 2013-12-17 at 20:56 +0100, Dr. H. Nikolaus Schaller wrote: > >> Hi Dan, > >> > >> Am 16.12.2013 um 20:40 schrieb Dan Williams: > >> > >>> On Fri, 2013-12-1

Re: [PATCH] usb: phy: am335x: Enable USB remote wakeup using PHY wakeup

2013-12-18 Thread Alan Stern
On Wed, 18 Dec 2013, Felipe Balbi wrote: > Alan, any suggestions on how to handle wakeup correctly ? I mean, it > should be enabled by default during runtime PM and disabled during > system sleep. During system sleep, it should be set according to the value of device_may_wakeup(). > But when i

Re: XHCI: Ring expansion failure

2013-12-18 Thread Sarah Sharp
On Wed, Nov 06, 2013 at 11:09:50PM -, hema...@codeaurora.org wrote: > >> On Wed, Nov 6, 2013 at 12:33 PM, wrote: > On Wed, Nov 6, 2013 at 12:53 AM, wrote: > > Hi Hi Hemant, > > By performing iterative port suspend and resume (which results > > in function suspend and resu

[PATCH] usb: musb: finish suspend/reset work independently from musb_hub_control()

2013-12-18 Thread Daniel Mack
Currently, resume and reset is completed when the USB core calls back the root hub, asking for the port's state. This results in unpredictable timing of state assertion, which in turn renders some USB devices unusable after resume. Fix this by moving the logic to end the reset and suspend state ou

Re: [RFC 0/2] target refcounting infrastructure fixes for usb

2013-12-18 Thread Sarah Sharp
On Mon, Dec 16, 2013 at 07:10:19AM -0800, James Bottomley wrote: > This set should fix our target problems with USB by making the target > visibility properly reference counted. Since it's a major change to the > infrastructure, we'll incubate upstream first before backporting to > stable. > > Ja

Re: Suspend issues with a LaCie USB hard disk connected

2013-12-18 Thread Alan Stern
On Wed, 18 Dec 2013, Daniel Mack wrote: > Hi, > > I'm facing an issue putting an embedded system to sleep while a Lacie > external USB hard disk is connected. Relevant kernel messages that occur > at the attempt are: > > [ 13.834731] PM: Sending message for entering DeepSleep mode > [ 13.846

Re: XHCI: Ring expansion failure

2013-12-18 Thread Alan Stern
On Wed, 18 Dec 2013, Sarah Sharp wrote: > I think there's a couple of ways we could fix this. > > One would be to set the IOC flag on the last no-op TRBs in a TD we're > trying to cancel. I think that will make the event handling code > increment the dequeue pointer and update the number of free

Re: xhci_hcd and Canon Lide 110 not playing well together

2013-12-18 Thread Matthias Bläsing
Hey all, On Fr, 2013-12-13 at 17:53 +0100, Holger Hans Peter Freyther wrote: > On Tue, May 28, 2013 at 07:40:57PM +0200, Holger Hans Peter Freyther wrote: > > Is there a timeline when you think this could be fixed? > > > I tried with 3.10.x and 3.12.5 and the symptoms remain the same. The first

Re: [RFC 0/2] target refcounting infrastructure fixes for usb

2013-12-18 Thread Alan Stern
On Wed, 18 Dec 2013, Sarah Sharp wrote: > On Mon, Dec 16, 2013 at 07:10:19AM -0800, James Bottomley wrote: > > This set should fix our target problems with USB by making the target > > visibility properly reference counted. Since it's a major change to the > > infrastructure, we'll incubate upstr

Debugging XHCI hardware issues?

2013-12-18 Thread Florian Echtler
Hello again, we've made some progress getting large SuperSpeed ISO transfers for the new Kinect to work. As it turns out, the central issue here was which XHCI controller the device is connected to. I have two different HCs, one from Intel and one from NEC. According to lspci, these are: 00:14.0

Re: [PATCH] usb: phy: fix driver dependencies

2013-12-18 Thread Stephen Rothwell
On Wed, 18 Dec 2013 09:58:33 -0600 Felipe Balbi wrote: > > are you sure that patch is included ? I have just checked on > greg/usb-linus that it's impossible to make CONFIG_USB=m and > CONFIG_ISP1301_OMAP=y (same for the other phy driver from Freescale). > > I can also build omap1_defconfig with

RE: Debugging XHCI hardware issues?

2013-12-18 Thread Paul Zimmerman
> From: linux-usb-ow...@vger.kernel.org > [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Florian Echtler > Sent: Wednesday, December 18, 2013 2:04 PM > > we've made some progress getting large SuperSpeed ISO transfers for the > new Kinect to work. As it turns out, the central issue here wa

Re: [PATCH V3] usb: musb: Fix unstable init of OTG_INTERFSEL.

2013-12-18 Thread Grazvydas Ignotas
On Wed, Dec 18, 2013 at 5:35 PM, Felipe Balbi wrote: > Hi, > > On Tue, Dec 17, 2013 at 05:48:33PM +0100, anaum...@ultratronik.de wrote: >> From: Andreas Naumann >> >> This is a hard to reproduce problem which leads to non-functional >> USB-OTG port in 0.1%-1% of all boots. Tracked it down to comm

Re: [PATCH 09/12] USB: ohci-octeon: Use devm_ioremap_resource()

2013-12-18 Thread David Daney
On 12/10/2013 11:27 PM, Jingoo Han wrote: Use devm_ioremap_resource() to make cleanup paths simpler. Signed-off-by: Jingoo Han Tested and... Acked-by: David Daney --- drivers/usb/host/ohci-octeon.c | 23 +-- 1 file changed, 5 insertions(+), 18 deletions(-) diff

Re: [PATCH 03/12] USB: ehci-octeon: Use devm_ioremap_resource()

2013-12-18 Thread David Daney
On 12/10/2013 11:20 PM, Jingoo Han wrote: Use devm_ioremap_resource() to make cleanup paths simpler. Signed-off-by: Jingoo Han This patch doesn't apply cleanly against Linus' branch. However, I was able to successfully test it after manually applying the changes. After you rebase the patc

Re: [RFC 0/2] target refcounting infrastructure fixes for usb

2013-12-18 Thread James Bottomley
On Wed, 2013-12-18 at 16:50 -0500, Alan Stern wrote: > On Wed, 18 Dec 2013, Sarah Sharp wrote: > > > On Mon, Dec 16, 2013 at 07:10:19AM -0800, James Bottomley wrote: > > > This set should fix our target problems with USB by making the target > > > visibility properly reference counted. Since it's

Support for Empia 2980 video/audio capture chip set

2013-12-18 Thread Keith Lawson
Hello, I'm trying to get a "Dazzle Video Capture USB V1.0" video capture card working on a Linux device but it doesn't look like the chip set is supported yet. I believe this card is the next version of the Pinnacle VC100 capture card that worked with the em28xx kernel module. The hardware v

RE: [PATCH] usb: dwc3: ep0: Handle variable-length Data Stage

2013-12-18 Thread Anton Tikhomirov
Hi, > Hi, > > On Tue, Dec 17, 2013 at 03:59:31PM +0900, Anton Tikhomirov wrote: > > In accordance with specification, when sent data length is > > please mention section of specification. USB2.0 spec., 8.5.3.2 Variable-length Data Stage > > > an exact multiple of wMaxPacketSize for the pipe

Re: [PATCH 03/12] USB: ehci-octeon: Use devm_ioremap_resource()

2013-12-18 Thread 'Greg Kroah-Hartman'
On Wed, Dec 18, 2013 at 03:44:21PM -0800, David Daney wrote: > On 12/10/2013 11:20 PM, Jingoo Han wrote: > > Use devm_ioremap_resource() to make cleanup paths simpler. > > > > Signed-off-by: Jingoo Han > > This patch doesn't apply cleanly against Linus' branch. However, I was > able to successf

Re: [PATCH 03/12] USB: ehci-octeon: Use devm_ioremap_resource()

2013-12-18 Thread Jingoo Han
On Thursday, December 19, 2013 8:44 AM, Jingoo Han wrote: > On 12/10/2013 11:20 PM, Jingoo Han wrote: > > Use devm_ioremap_resource() to make cleanup paths simpler. > > > > Signed-off-by: Jingoo Han > > This patch doesn't apply cleanly against Linus' branch. However, I was > able to successfully

Re: Support for Empia 2980 video/audio capture chip set

2013-12-18 Thread Greg KH
On Wed, Dec 18, 2013 at 08:26:47PM -0500, Keith Lawson wrote: > Hello, > > I'm trying to get a "Dazzle Video Capture USB V1.0" video capture card > working on a Linux device but it doesn't look like the chip set is > supported yet. I believe this card is the next version of the Pinnacle > VC10

Re: [PATCH 1/1] AX88179_178A: Add FLAG_HW_IPALIGN to determine whether reserving NET_IP_ALIGN bytes for an SKB.

2013-12-18 Thread Freddy Xin
On 2013年12月16日 18:09, David Laight wrote: I was thinking of something like: skb = netdev_alloc_skb(dev, length + dev->skb_align, gfp); if (NET_IP_ALIGN && skb && !(ev->driver_flags & FLAG_HW_IPALIGN)) skb_reserve(skb, NET_IP_ALIGN); It might even be reasonable to remove the length adjustment -

Re: [PATCH 1/2] usb: usbtest: Add timetout to simple_io()

2013-12-18 Thread Huang Rui
On Wed, Dec 18, 2013 at 10:37:44AM -0600, Felipe Balbi wrote: > On Wed, Dec 18, 2013 at 10:46:03PM +0800, Huang Rui wrote: > > Hi Roger, > > > > On Wed, Dec 18, 2013 at 03:40:10PM +0530, Roger Quadros wrote: > > > Without a timetout some tests e.g. test_halt() can remain stuck forever. > > > > >

Re: [PATCH 2/2] usb: usbtest: Always clear halt else further tests will fail

2013-12-18 Thread Huang Rui
On Wed, Dec 18, 2013 at 03:40:11PM +0530, Roger Quadros wrote: > In test_halt() we set an endpoint halt condition and return on halt > verification > failure, then the enpoint will remain halted and all further tests related > to that enpoint will fail. This is because we don't tackle endpoint hal

Re: [RFC/PATCH 0/3] pm: Make SET_*_PM_OPS() macros more smart

2013-12-18 Thread David Cohen
On Thu, Dec 12, 2013 at 09:18:22PM -0800, David Cohen wrote: > Hi, > > These patches are proposal to extend the lack of #ifdef checks on PM callback > to its implementation too. > > Currently SET_*_PM_OPS() macros make #ifdefs checks not necessary when setting > the callback to PM ops, but the ca

Re: XHCI: Ring expansion failure

2013-12-18 Thread hemantk
> On Wed, Nov 06, 2013 at 11:09:50PM -, hema...@codeaurora.org wrote: >> >> On Wed, Nov 6, 2013 at 12:33 PM, wrote: >> On Wed, Nov 6, 2013 at 12:53 AM, wrote: >> > Hi > > Hi Hemant, > >> > By performing iterative port suspend and resume (which results >> > in function suspe

Re: [PATCH v7 8/9] phy: add Broadcom Kona USB2 PHY driver

2013-12-18 Thread Kishon Vijay Abraham I
Hi Felipe, On Wednesday 18 December 2013 09:55 PM, Felipe Balbi wrote: > On Tue, Dec 17, 2013 at 02:42:35PM -0500, Matt Porter wrote: >> Add a driver for the internal Broadcom Kona USB 2.0 PHY found >> on the BCM281xx family of SoCs. >> >> Signed-off-by: Matt Porter > > Kishon, are you ok with t

RE: [PATCH] usb: dwc3: ep0: Handle variable-length Data Stage

2013-12-18 Thread Anton Tikhomirov
Hi Pratyush, > Hi Anton, > > On Wed, Dec 18, 2013 at 12:11:33PM +0800, Felipe Balbi wrote: > > Hi, > > > > On Tue, Dec 17, 2013 at 03:59:31PM +0900, Anton Tikhomirov wrote: > > > In accordance with specification, when sent data length is > > > > please mention section of specification. > > > >

Re: [PATCH] usb: dwc3: ep0: Handle variable-length Data Stage

2013-12-18 Thread Felipe Balbi
Hi, On Thu, Dec 19, 2013 at 02:54:31PM +0900, Anton Tikhomirov wrote: > > WARN_ON(ret < 0); > > > > Regards > > Pratyush > > By the way, chaining additional (auxiliary) TRB would allow complying with > Buffer Size Rule on _UDC_driver_level_ for any type of OUT endpoints, when > total size of

Re: [PATCH] usb: dwc3: ep0: Handle variable-length Data Stage

2013-12-18 Thread Felipe Balbi
On Thu, Dec 19, 2013 at 11:32:08AM +0900, Anton Tikhomirov wrote: > Hi, > > > Hi, > > > > On Tue, Dec 17, 2013 at 03:59:31PM +0900, Anton Tikhomirov wrote: > > > In accordance with specification, when sent data length is > > > > please mention section of specification. > > USB2.0 spec., 8.5.3.

Re: [PATCH 2/2] usb: usbtest: Always clear halt else further tests will fail

2013-12-18 Thread Huang Rui
On Thu, Dec 19, 2013 at 12:01:47PM +0800, Huang Rui wrote: > On Wed, Dec 18, 2013 at 03:40:11PM +0530, Roger Quadros wrote: > > In test_halt() we set an endpoint halt condition and return on halt > > verification > > failure, then the enpoint will remain halted and all further tests related

Re: [PATCH 2/2] usb: usbtest: Always clear halt else further tests will fail

2013-12-18 Thread Roger Quadros
On 12/19/2013 11:16 AM, Huang Rui wrote: > On Thu, Dec 19, 2013 at 12:01:47PM +0800, Huang Rui wrote: >> On Wed, Dec 18, 2013 at 03:40:11PM +0530, Roger Quadros wrote: >>> In test_halt() we set an endpoint halt condition and return on halt >>> verification >>> failure, then the enpoint will remain

Re: [PATCH 2/2] usb: usbtest: Always clear halt else further tests will fail

2013-12-18 Thread Greg KH
On Thu, Dec 19, 2013 at 11:51:45AM +0530, Roger Quadros wrote: > On 12/19/2013 11:16 AM, Huang Rui wrote: > > On Thu, Dec 19, 2013 at 12:01:47PM +0800, Huang Rui wrote: > >> On Wed, Dec 18, 2013 at 03:40:11PM +0530, Roger Quadros wrote: > >>> In test_halt() we set an endpoint halt condition and ret

RE: [PATCH] usb: dwc3: ep0: Handle variable-length Data Stage

2013-12-18 Thread Anton Tikhomirov
Hi, > Hi, > > On Thu, Dec 19, 2013 at 02:54:31PM +0900, Anton Tikhomirov wrote: > > > WARN_ON(ret < 0); > > > > > > Regards > > > Pratyush > > > > By the way, chaining additional (auxiliary) TRB would allow complying > with > > Buffer Size Rule on _UDC_driver_level_ for any type of OUT endpoint

RE: [PATCH] usb: dwc3: ep0: Handle variable-length Data Stage

2013-12-18 Thread Paul Zimmerman
> From: linux-usb-ow...@vger.kernel.org > [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Felipe Balbi > Sent: Wednesday, December 18, 2013 10:03 PM > > On Thu, Dec 19, 2013 at 11:32:08AM +0900, Anton Tikhomirov wrote: > > Hi, > > > > > Hi, > > > > > > On Tue, Dec 17, 2013 at 03:59:31PM +09

RE: [PATCH] usb: dwc3: ep0: Handle variable-length Data Stage

2013-12-18 Thread Anton Tikhomirov
Hi, > > On Thu, Dec 19, 2013 at 11:32:08AM +0900, Anton Tikhomirov wrote: > > > Hi, > > > > > > > Hi, > > > > > > > > On Tue, Dec 17, 2013 at 03:59:31PM +0900, Anton Tikhomirov wrote: > > > > > In accordance with specification, when sent data length is > > > > > > > > please mention section of spe

Re: [PATCH 1/1] hso: fix problem with wrong status code sent by OPTION GTM601 during RING indication

2013-12-18 Thread Dr. H. Nikolaus Schaller
Hi Dan, Am 18.12.2013 um 18:49 schrieb Dan Williams: > On Wed, 2013-12-18 at 14:16 +0100, Dr. H. Nikolaus Schaller wrote: >> Hi Dan, >> >> Am 17.12.2013 um 23:27 schrieb Dan Williams: >> >>> On Tue, 2013-12-17 at 20:56 +0100, Dr. H. Nikolaus Schaller wrote: Hi Dan, Am 16.12.2013