Re: [PATCH RESEND v2 1/2] phy: core: Add an exported of_phy_get function

2013-12-16 Thread Kishon Vijay Abraham I
On Friday 13 December 2013 08:56 PM, Kamil Debski wrote: > Hi Kishon, > >> From: Kishon Vijay Abraham I [mailto:kis...@ti.com] >> Sent: Friday, December 13, 2013 3:45 PM >> >> Hi, >> >> On Friday 13 December 2013 07:32 PM, Kamil Debski wrote: >>> Previously the of_phy_get function took a struct de

Re: xhci_hcd debugging status, please?

2013-12-16 Thread Oliver Neukum
On Fri, 2013-12-13 at 14:39 +0100, Udo van den Heuvel wrote: > On 2013-12-10 16:03, Oliver Neukum wrote: > >> Thanks, but some of the messages look quite hardcoded. > >> Is there a patch to get rid of them? > > > > More patches concerning dynamic debugging are in the queue for 3.14 > > It looks li

Re: [PATCH 11/12] USB: ohci-spear: Use devm_ioremap_resource()

2013-12-16 Thread Viresh Kumar
On 11 December 2013 12:59, Jingoo Han wrote: > Use devm_ioremap_resource() to make cleanup paths simpler. > > Signed-off-by: Jingoo Han > --- > drivers/usb/host/ohci-spear.c | 13 +++-- > 1 file changed, 3 insertions(+), 10 deletions(-) Acked-by: Viresh Kumar -- To unsubscribe from t

Re: [PATCH 1/2] usb: gadget: atmel_usba: Use devm_*() functions

2013-12-16 Thread Nicolas Ferre
On 16/12/2013 07:13, Jingoo Han : > Use devm_*() functions to make cleanup paths simpler. > > Signed-off-by: Jingoo Han Acked-by: Nicolas Ferre Thanks, bye, > --- > drivers/usb/gadget/atmel_usba_udc.c | 64 > ++- > 1 file changed, 17 insertions(+), 47 delet

[PATCH 1/7] usb: gadget: f_loopback: Fix sparse warning

2013-12-16 Thread Jingoo Han
Make local symbols static in order to fix the following sparse warnings. drivers/usb/gadget/f_loopback.c:123:34: warning: symbol 'ss_loop_source_comp_desc' was not declared. Should it be static? drivers/usb/gadget/f_loopback.c:139:34: warning: symbol 'ss_loop_sink_comp_desc' was not declared. Sh

Re: [PATCH 2/2] usb: gadget: atmel_usba: Fix sparse warning

2013-12-16 Thread Nicolas Ferre
On 16/12/2013 07:14, Jingoo Han : > 'usba_gadget_template' is used only in this file. Thus, make > 'usba_gadget_template' static, in order to fix the following > sparse warning. > > warning: symbol 'usba_gadget_template' was not declared. Should it be static? > > Signed-off-by: Jingoo Han Acked

[PATCH 2/7] usb: gadget: f_mass_storage: Fix sparse warning

2013-12-16 Thread Jingoo Han
Use NULL instead of 0 when returning pointer, to fix the following sparse warnings. drivers/usb/gadget/f_mass_storage.c:3114:60: warning: Using plain integer as NULL pointer drivers/usb/gadget/f_mass_storage.c:3114:63: warning: Using plain integer as NULL pointer Signed-off-by: Jingoo Han ---

[PATCH 3/7] usb: gadget: f_ncm: Fix sparse warning

2013-12-16 Thread Jingoo Han
Make local symbol static in order to fix the following sparse warning. drivers/usb/gadget/f_ncm.c:1389:21: warning: symbol 'ncm_alloc' was not declared. Should it be static? Signed-off-by: Jingoo Han --- drivers/usb/gadget/f_ncm.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 6/7] usb: gadget: f_serial: Fix sparse warning

2013-12-16 Thread Jingoo Han
Make local symbol static in order to fix the following sparse warning. drivers/usb/gadget/f_serial.c:357:21: warning: symbol 'gser_alloc' was not declared. Should it be static? Signed-off-by: Jingoo Han --- drivers/usb/gadget/f_serial.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH 5/7] usb: gadget: f_phonet: Fix sparse warning

2013-12-16 Thread Jingoo Han
Make local symbol static in order to fix the following sparse warning. drivers/usb/gadget/f_phonet.c:692:21: warning: symbol 'phonet_alloc' was not declared. Should it be static? Signed-off-by: Jingoo Han --- drivers/usb/gadget/f_phonet.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-

[PATCH 4/7] usb: gadget: f_obex: Fix sparse warning

2013-12-16 Thread Jingoo Han
Make local symbol static in order to fix the following sparse warning. drivers/usb/gadget/f_obex.c:502:21: warning: symbol 'obex_alloc' was not declared. Should it be static? Signed-off-by: Jingoo Han --- drivers/usb/gadget/f_obex.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) dif

[PATCH 7/7] usb: gadget: f_sourcesink: Fix sparse warning

2013-12-16 Thread Jingoo Han
Make local symbols static in order to fix the following sparse warnings. drivers/usb/gadget/f_sourcesink.c:205:34: warning: symbol 'ss_source_comp_desc' was not declared. Should it be static? drivers/usb/gadget/f_sourcesink.c:222:34: warning: symbol 'ss_sink_comp_desc' was not declared. Should i

RE: [PATCH] xhci: fix array index out of the bounds in function last_trb() and last_trb_on_last_seg()

2013-12-16 Thread David Laight
> From: Of Wang, Lin X > Sent: 15 December 2013 14:21 > To: Sarah Sharp (sarah.a.sh...@linux.intel.com) > Cc: linux-usb@vger.kernel.org > Subject: [PATCH] xhci: fix array index out of the bounds in function > last_trb() and > last_trb_on_last_seg() > > In function last_trb() and last_trb_on_last_

RE: [PATCH 1/1] AX88179_178A: Add FLAG_HW_IPALIGN to determine whether reserving NET_IP_ALIGN bytes for an SKB.

2013-12-16 Thread David Laight
> From: Freddy Xin > On 2013年12月13日 18:36, David Laight wrote: > >> From: fre...@asix.com.tw > > ... > >> - skb = __netdev_alloc_skb_ip_align(dev->net, size, flags); > >> + if (dev->driver_info->flags & FLAG_HW_IPALIGN) > >> + skb = __netdev_alloc_skb(dev->net, size, flags); > >> + else

Fwd: BBB gadgetfs freeze patch

2013-12-16 Thread palesius .
The change was made to drivers/usb/gadget/inode.c under the kernel source. I can't offer a lot of help if you are running on angstrom, but if you are running on debian I followed this procedure (i used the 3.12 branch): http://eewiki.net/display/linuxonarm/BeagleBone+Black#BeagleBoneBlack-LinuxKe

Re: WG: [PATCH] usb: musb: omap2430: fix occasional musb breakage on boot

2013-12-16 Thread Grazvydas Ignotas
On Fri, Dec 13, 2013 at 6:27 PM, Andreas Naumann wrote: > On 13.12.2013 13:34, Grazvydas Ignotas wrote: >> >> Hmm I don't know about that, this would be inconsistent with what all >> other OMAP drivers do. Maybe we should do what musb_core.c does just > > Ok, thats cool. > >> to be consistent and

[PATCH 00/12] libusbg: Cleanup, bug fix and refactoring.

2013-12-16 Thread Krzysztof Opasiak
Dear Matt, Please excuse me my passivity after discussuon about libusbg some time ago. I had to close some other issues before taking up this one. Recently I looked into code of libusbg, build it and found some errors which are fixed in attached patches. Moreover I have done some clean up and mi

[PATCH 01/12] libusbg: Surround header with include guards.

2013-12-16 Thread Krzysztof Opasiak
Surround header with include guards to protect against multiple inclusion. Signed-off-by: Krzysztof Opasiak --- include/gadget/gadget.h |4 1 file changed, 4 insertions(+) diff --git a/include/gadget/gadget.h b/include/gadget/gadget.h index 9bca97e..f3c08e9 100644 --- a/include/gadget/

[PATCH 02/12] libusbg: Add missing return statement in non-void functions.

2013-12-16 Thread Krzysztof Opasiak
Add return 0 in functions which return non-void to suppress compiler complaint. Signed-off-by: Krzysztof Opasiak --- src/gadget.c |4 1 file changed, 4 insertions(+) diff --git a/src/gadget.c b/src/gadget.c index 8ca68b3..8320f34 100644 --- a/src/gadget.c +++ b/src/gadget.c @@ -223,6 +

[PATCH 03/12] libusbg: Fix gadget-acm-ecm example to cleanup at exit.

2013-12-16 Thread Krzysztof Opasiak
Make use of previously unused variable ret to cleanup afterr successful gadget creation. Signed-off-by: Krzysztof Opasiak --- examples/gadget-acm-ecm.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/examples/gadget-acm-ecm.c b/examples/gadget-acm-ecm.c index e33ee06..

[PATCH 04/12] libusbg: Move directory creation before writing attributes.

2013-12-16 Thread Krzysztof Opasiak
Change order of gadget creation and attribute writting to fix No such file or directory error while creating new gadget. Signed-off-by: Krzysztof Opasiak --- src/gadget.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/gadget.c b/src/gadget.c index 8320f34..

[PATCH 07/12] libusbg: Add missing config attrs parsing while new config creation.

2013-12-16 Thread Krzysztof Opasiak
Afther creation of configuration its attributes left uninitialized. Config attrs should be initialized with default values provided by kernel. Signed-off-by: Krzysztof Opasiak --- src/gadget.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gadget.c b/src/gadget.c index 5568486..40d

[PATCH 09/12] libusbg: Initialize gadget attributes and strings while gadget creation

2013-12-16 Thread Krzysztof Opasiak
Fix gadget_create_gadget function to initialize gadget attributes and strings with default values provided by kernel. Signed-off-by: Krzysztof Opasiak --- src/gadget.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/gadget.c b/src/gadget.c index 04fe46b..050bea5 1

[PATCH 08/12] libusbg: Separate parsing gadget attributes and strings.

2013-12-16 Thread Krzysztof Opasiak
Gadget attributes and strings are logically independent, so they should be initialized in separate functions. Signed-off-by: Krzysztof Opasiak --- src/gadget.c |9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/gadget.c b/src/gadget.c index 40da70f..04fe46b 10064

[PATCH 11/12] libusbg: Replace hard coded sizes with suitable sizeof.

2013-12-16 Thread Krzysztof Opasiak
use sizeof to determine size of memory to copy instead of using hard coded values. Signed-off-by: Krzysztof Opasiak --- src/gadget.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gadget.c b/src/gadget.c index cba309d..ed6aef2 100644 --- a/src/gadget.c +++ b/src/g

[PATCH 05/12] libusbg: Fix memory leak when unable to create directory.

2013-12-16 Thread Krzysztof Opasiak
Free the memory allocated for gadget/config/function structure when faild to create suitable directory. Signed-off-by: Krzysztof Opasiak --- src/gadget.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gadget.c b/src/gadget.c index aea9b2e..f613c3e 100644 --- a/src/gadget.c +++ b/s

[PATCH 10/12] libusbg: Move symlink creation after memory allocation.

2013-12-16 Thread Krzysztof Opasiak
Move creation of symlink after memory allocation for binding structure. Fix missing initialization of parent. Signed-off-by: Krzysztof Opasiak --- src/gadget.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/src/gadget.c b/src/gadget.c index 050bea5..cba309d 10

[PATCH 06/12] libusbg: Add error handling to gadget_read_string.

2013-12-16 Thread Krzysztof Opasiak
Add error handling when gadget_read_buf return NULL. If read of string fails, the string should be set as empty. Signed-off-by: Krzysztof Opasiak --- src/gadget.c | 23 +-- 1 file changed, 17 insertions(+), 6 deletions(-) diff --git a/src/gadget.c b/src/gadget.c index f613

[PATCH 12/12] libusbg: Replace directory names with defines.

2013-12-16 Thread Krzysztof Opasiak
Replace strings, functions, configs strings placed everywhere in code with macro defintions STRINGS_DIR, FUNCTIONS_DIR and CONFIGS_DIR. Signed-off-by: Krzysztof Opasiak --- src/gadget.c | 37 +++-- 1 file changed, 23 insertions(+), 14 deletions(-) diff --git a/

Re: [PATCH v7 2/2] usb-serial: Moxa UPORT 12XX/14XX/16XX driver

2013-12-16 Thread Johan Hovold
On Tue, Dec 10, 2013 at 10:50:25PM +0100, Andrew Lunn wrote: > Add a driver which supports the following Moxa USB to serial converters: > * 2 ports : UPort 1250, UPort 1250I > * 4 ports : UPort 1410, UPort 1450, UPort 1450I > * 8 ports : UPort 1610-8, UPort 1650-8 > * 16 port

RE: [PATCH 11/12] libusbg: Replace hard coded sizes with suitable sizeof.

2013-12-16 Thread David Laight
> From: Krzysztof Opasiak > use sizeof to determine size of memory to copy instead of > using hard coded values. ... > - memcpy(&f->attr.net.dev_addr, dev_addr, 6); > + memcpy(&f->attr.net.dev_addr, dev_addr, sizeof(*dev_addr)); It generally looks better if you use the size of the destin

Re: pl2303 device failing with ENOTTY

2013-12-16 Thread Johan Hovold
On Sun, Dec 08, 2013 at 01:46:29PM -0300, Ismael Luceno wrote: > Hi. > > I'm using a small script to periodically talk to devices over RS232. > > For simplicity I decided to use "chat". Once in a while, every about > 25000 cycles, the usb converter stops working. > > Removing and re-adding the d

RE: [PATCH 11/12] libusbg: Replace hard coded sizes with suitable sizeof.

2013-12-16 Thread Krzysztof Opasiak
> -Original Message- > From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb- > ow...@vger.kernel.org] On Behalf Of David Laight > Subject: RE: [PATCH 11/12] libusbg: Replace hard coded sizes with > suitable sizeof. > > > From: Krzysztof Opasiak > > use sizeof to determine size of memor

Re: [PATCH 1/1] usb: musb: ux500_dma: fix potential NULL dereference error

2013-12-16 Thread Linus Walleij
On Fri, Dec 13, 2013 at 11:47 AM, Lee Jones wrote: > static checker warning: "drivers/usb/musb/ux500_dma.c:335 > ux500_dma_controller_start() > error: potential NULL dereference 'param_array'." > > Reported-by: Dan Carpenter > Signed-off-by: Lee Jones Acked-by: Linus Walleij Yours,

[PATCH v3 1/2] phy: core: Add an exported of_phy_get function

2013-12-16 Thread Kamil Debski
Previously the of_phy_get function took a struct device * and was declared static. It was impossible to call it from another driver and thus it was impossible to get phy defined for a given node. The old function was renamed to _of_phy_get and was left for internal use. of_phy_get function was adde

[PATCH v3 2/2] phy: core: Add devm_of_phy_get to phy-core

2013-12-16 Thread Kamil Debski
Adding devm_of_phy_get will allow to get phys by supplying the device_node instead of by name. Signed-off-by: Kamil Debski --- drivers/phy/phy-core.c | 31 +++ include/linux/phy/phy.h |2 ++ 2 files changed, 33 insertions(+) diff --git a/drivers/phy/phy-core.c

RE: [PATCH RESEND v2 1/2] phy: core: Add an exported of_phy_get function

2013-12-16 Thread Kamil Debski
Hi, > From: Kishon Vijay Abraham I [mailto:kis...@ti.com] > Sent: Monday, December 16, 2013 10:01 AM > > On Friday 13 December 2013 08:56 PM, Kamil Debski wrote: > > Hi Kishon, > > > >> From: Kishon Vijay Abraham I [mailto:kis...@ti.com] > >> Sent: Friday, December 13, 2013 3:45 PM > >> > >> Hi,

Re: [PATCH v3 2/2] phy: core: Add devm_of_phy_get to phy-core

2013-12-16 Thread Kishon Vijay Abraham I
On Monday 16 December 2013 06:22 PM, Kamil Debski wrote: > Adding devm_of_phy_get will allow to get phys by supplying the > device_node instead of by name. > > Signed-off-by: Kamil Debski > --- > drivers/phy/phy-core.c | 31 +++ > include/linux/phy/phy.h |2 ++

Re: [PATCH 3/3] devicetree: bindings: document lsi,zevio-usb

2013-12-16 Thread Rob Herring
On Sat, Dec 14, 2013 at 9:35 PM, wrote: > From: Daniel Tang > > > Signed-off-by: Daniel Tang A few minor things below. Otherwise: Acked-by: Rob Herring > --- > .../devicetree/bindings/usb/ci-hdrc-zevio.txt | 17 > + > 1 file changed, 17 insertions(+) > create mo

Re: [PATCH] xhci: fix array index out of the bounds in function last_trb() and last_trb_on_last_seg()

2013-12-16 Thread 王林
2013/12/16 David Laight : >> From: Of Wang, Lin X >> Sent: 15 December 2013 14:21 >> To: Sarah Sharp (sarah.a.sh...@linux.intel.com) >> Cc: linux-usb@vger.kernel.org >> Subject: [PATCH] xhci: fix array index out of the bounds in function >> last_trb() and >> last_trb_on_last_seg() >> >> In functio

RE: [PATCH] xhci: fix array index out of the bounds in function last_trb() and last_trb_on_last_seg()

2013-12-16 Thread David Laight
> From: Wang, Lin X > 2013/12/16 David Laight : > >> From: Of Wang, Lin X > >> Sent: 15 December 2013 14:21 > >> To: Sarah Sharp (sarah.a.sh...@linux.intel.com) > >> Cc: linux-usb@vger.kernel.org > >> Subject: [PATCH] xhci: fix array index out of the bounds in function > >> last_trb() and > >> las

Re: [PATCH] xhci: fix array index out of the bounds in function last_trb() and last_trb_on_last_seg()

2013-12-16 Thread Lin
2013/12/16 David Laight : >> From: Wang, Lin X >> 2013/12/16 David Laight : >> >> From: Of Wang, Lin X >> >> Sent: 15 December 2013 14:21 >> >> To: Sarah Sharp (sarah.a.sh...@linux.intel.com) >> >> Cc: linux-usb@vger.kernel.org >> >> Subject: [PATCH] xhci: fix array index out of the bounds in funct

[RFC 0/2] target refcounting infrastructure fixes for usb

2013-12-16 Thread James Bottomley
This set should fix our target problems with USB by making the target visibility properly reference counted. Since it's a major change to the infrastructure, we'll incubate upstream first before backporting to stable. James --- James Bottomley (2): [SCSI] fix our current target reap infrastru

[RFC 1/2] fix our current target reap infrastructure.

2013-12-16 Thread James Bottomley
This patch eliminates the reap_ref and replaces it with a proper kref. On last put of this kref, the target is removed from visibility in sysfs. The final call to scsi_target_reap() for the device is done from __scsi_remove_device() and only if the device was made visible. This ensures that the t

[RFC 2/2] dual scan thread bug fix

2013-12-16 Thread James Bottomley
In the highly unusual case where two threads are running concurrently through the scanning code scanning the same target, we run into the situation where one may allocate the target while the other is still using it. In this case, because the reap checks for STARGET_CREATED and kills the target wi

RE: [PATCH] xhci: fix array index out of the bounds in function last_trb() and last_trb_on_last_seg()

2013-12-16 Thread David Laight
> I know all these difference clearly, inc_deq() is indeed a common > function for different rings, but lasr_trb() & last_trb_on_last_seg() > inside it use different condition to determine the last trb in an > event ring and an non-event ring; and sorry, i still not find why last > trb in an event

[PATCH v3 2/2] arm: omap: remove *.auto* from device names given in usb_bind_phy

2013-12-16 Thread Kishon Vijay Abraham I
commit 2f7711 (usb: musb: remove hand-crafted id handling) used PLATFORM_DEVID_AUTO while creating MUSB core device. So commit 51482b (ARM: OMAP: USB: Add phy binding information) added usb_bind_phy (binds the controller with the PHY) in the board files, with *.auto* in the device name of the contr

[PATCH v3 0/2] usb: fix controller-PHY binding for OMAP3 platform

2013-12-16 Thread Kishon Vijay Abraham I
After the platform devices are created using PLATFORM_DEVID_AUTO, the device names given in usb_bind_phy (in board file) does not match with the actual device name causing the USB PHY library not to return the PHY reference when the MUSB controller request for the PHY in the non-dt boot case. So re

[PATCH v3 1/2] usb: musb: omap: remove using PLATFORM_DEVID_AUTO in omap2430.c

2013-12-16 Thread Kishon Vijay Abraham I
commit 2f7711 (usb: musb: remove hand-crafted id handling) used PLATFORM_DEVID_AUTO while creating MUSB core device. After the platform devices are created using PLATFORM_DEVID_AUTO, the device names given in usb_bind_phy (in board file) does not match with the actual device name causing the USB PH

Re: [RFC 1/2] fix our current target reap infrastructure.

2013-12-16 Thread Alan Stern
On Mon, 16 Dec 2013, James Bottomley wrote: > This patch eliminates the reap_ref and replaces it with a proper kref. > On last put of this kref, the target is removed from visibility in > sysfs. The final call to scsi_target_reap() for the device is done from > __scsi_remove_device() and only if

Re: Bug#704242: Driver for PL-2303 HX not working

2013-12-16 Thread Karsten Malcher
Am 15.12.2013 18:05, schrieb Greg KH: Have you tried a newer kernel in a while? A number of things have been hopefully fixed since June when you last looked. greg k-h no at this time i have not tested it - sorry. Although i am fascinated from your work i personally prefer to use stable rele

Re: Recall: [PATCH] xhci: remove unused variable 'addr' in inc_deq() and inc_enq().

2013-12-16 Thread Sarah Sharp
On Sun, Dec 15, 2013 at 12:20:57AM -0800, Wang, Lin X wrote: > Wang, Lin X would like to recall the message, "[PATCH] xhci: remove unused > variable 'addr' in inc_deq() and inc_enq().". Recalling messages when sent to a public mailing list does not work. Also, recalling messages doesn't work for

RE: "EHCI: BIOS handoff failed (BIOS bug?) 01010001" on Celeron N2805 (Bay Trail) / Gateway LT41P

2013-12-16 Thread Dufour, Sebastien
> -Original Message- > From: linux-usb-ow...@vger.kernel.org > [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Ken Harris > > I have a fabulous Gateway LT41P04u (w/ Insydeh20 BIOS v2.03) and a Celeron > N2805 (Bay Trail) > > I managed to boot Fedora on it (a bit tricky since it has

Re: [PATCH 06/12] libusbg: Add error handling to gadget_read_string.

2013-12-16 Thread Sergei Shtylyov
Hello. On 12/16/2013 02:30 PM, Krzysztof Opasiak wrote: Add error handling when gadget_read_buf return NULL. If read of string fails, the string should be set as empty. Signed-off-by: Krzysztof Opasiak --- src/gadget.c | 23 +-- 1 file changed, 17 insertions(+), 6 d

Problem with disabled/not-connected USB causing "irq N: nobody cared"

2013-12-16 Thread Rafał Miłecki
I've problem with one of my Broadcom based no-name China router. This is a pretty standard/common BCM47186 SoC (chip id 0x5357, rev 0x02, package 0x0A). It can be found in some routers having USB port(s), however my PCB doesn't have any USB port. It seems SoC is capable of handling USB, but my PCB

Re: [PATCH 1/1] hso: fix problem with wrong status code sent by OPTION GTM601 during RING indication

2013-12-16 Thread Dan Williams
On Fri, 2013-12-13 at 15:43 +0100, Dr. H. Nikolaus Schaller wrote: > Hi, > > Am 02.10.2013 um 09:00 schrieb Dr. H. Nikolaus Schaller: > > > Hi Jan, > > > > we are using a GTM601 modem (Firmware 1.7) for a while and have spotted an > > issue that under some conditions the modem sends a packed wIn

[PATCH 2/2] usb: gadget: storage: make FSG_BUFLEN configurable on Kconfig

2013-12-16 Thread Felipe Balbi
By making that configurable on Kconfig, we won't need to modify source code when we want to change the way f_mass_storage behaves for a specific product. Signed-off-by: Felipe Balbi --- drivers/usb/gadget/Kconfig | 15 +++ drivers/usb/gadget/f_mass_storage.c | 17 ++-

[PATCH 1/2] usb: dwc3: gadget: always enable IOC on bulk/interrupt transfers

2013-12-16 Thread Felipe Balbi
by setting IOC always, we can recycle TRBs a lot sooner at the expense of some increased CPU load. The extra load seems to be quite minimal on OMAP5 devices (instead of 1 IRQ for one MSC transfer, we get CONFIG_USB_GADGET_STORAGE_NUM_BUFFERS). Signed-off-by: Felipe Balbi --- drivers/usb/dwc3/ga

Re: [PATCH 1/2] usb: dwc3: gadget: always enable IOC on bulk/interrupt transfers

2013-12-16 Thread Felipe Balbi
On Mon, Dec 16, 2013 at 01:41:42PM -0600, Felipe Balbi wrote: > by setting IOC always, we can recycle TRBs a > lot sooner at the expense of some increased > CPU load. > > The extra load seems to be quite minimal on > OMAP5 devices (instead of 1 IRQ for one MSC > transfer, we get > CONFIG_USB_GADGE

Re: [PATCH] xhci: fix array index out of the bounds in function last_trb() and last_trb_on_last_seg()

2013-12-16 Thread Sarah Sharp
On Mon, Dec 16, 2013 at 03:20:28PM -, David Laight wrote: > > I know all these difference clearly, inc_deq() is indeed a common > > function for different rings, but lasr_trb() & last_trb_on_last_seg() > > inside it use different condition to determine the last trb in an > > event ring and an

Re: Problem with disabled/not-connected USB causing "irq N: nobody cared"

2013-12-16 Thread Alan Stern
On Mon, 16 Dec 2013, Rafał Miłecki wrote: > I've problem with one of my Broadcom based no-name China router. > > This is a pretty standard/common BCM47186 SoC (chip id 0x5357, rev > 0x02, package 0x0A). It can be found in some routers having USB > port(s), however my PCB doesn't have any USB port

Re: Problem with disabled/not-connected USB causing "irq N: nobody cared"

2013-12-16 Thread Rafał Miłecki
2013/12/16 Alan Stern : > On Mon, 16 Dec 2013, Rafał Miłecki wrote: >> Is there any way this could be fixed? > > No, not that I know of. But since the USB controller isn't connected > to anything, you could simply avoid configuring the ehci-hcd driver in > the kernel. I know, but the thing it's n

Re: Problem with disabled/not-connected USB causing "irq N: nobody cared"

2013-12-16 Thread Alan Stern
On Mon, 16 Dec 2013, Rafał Miłecki wrote: > 2013/12/16 Alan Stern : > > On Mon, 16 Dec 2013, Rafał Miłecki wrote: > >> Is there any way this could be fixed? > > > > No, not that I know of. But since the USB controller isn't connected > > to anything, you could simply avoid configuring the ehci-hc

Re: Problem with disabled/not-connected USB causing "irq N: nobody cared"

2013-12-16 Thread Rafał Miłecki
2013/12/16 Alan Stern : > On Mon, 16 Dec 2013, Rafał Miłecki wrote: > >> 2013/12/16 Alan Stern : >> > On Mon, 16 Dec 2013, Rafał Miłecki wrote: >> >> Is there any way this could be fixed? >> > >> > No, not that I know of. But since the USB controller isn't connected >> > to anything, you could sim

[PATCH] usb: dwc3: gadget: always enable IOC on bulk/interrupt transfers

2013-12-16 Thread Felipe Balbi
by setting IOC always, we can recycle TRBs a lot sooner at the expense of some increased CPU load. The extra load seems to be quite minimal on OMAP5 devices (instead of 1 IRQ for one MSC transfer, we get CONFIG_USB_GADGET_STORAGE_NUM_BUFFERS). Signed-off-by: Felipe Balbi --- drivers/usb/dwc3/ga

Re: Problem with disabled/not-connected USB causing "irq N: nobody cared"

2013-12-16 Thread Alan Stern
On Mon, 16 Dec 2013, Rafał Miłecki wrote: > I've just realized I didn't explain my problem fully, I'm sorry! This > single warning about not handled IRQ isn't a real problem. The issue > is that I'm spammed with such messages until hardware reboots itself. > > [ 7.244000] irq 5: nobody cared (try

RE: [PATCH 2/2] usb: gadget: storage: make FSG_BUFLEN configurable on Kconfig

2013-12-16 Thread Paul Zimmerman
> From: linux-usb-ow...@vger.kernel.org > [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Felipe Balbi > Sent: Monday, December 16, 2013 11:42 AM > > By making that configurable on Kconfig, we won't > need to modify source code when we want to change > the way f_mass_storage behaves for a s

Re: [PATCH 2/2] usb: gadget: storage: make FSG_BUFLEN configurable on Kconfig

2013-12-16 Thread Felipe Balbi
On Mon, Dec 16, 2013 at 09:20:20PM +, Paul Zimmerman wrote: > > From: linux-usb-ow...@vger.kernel.org > > [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Felipe Balbi > > Sent: Monday, December 16, 2013 11:42 AM > > > > By making that configurable on Kconfig, we won't > > need to modify

Re: [PATCH 3/3] usb: musb: fix setting JZ4740 gadget periphal mode on reset

2013-12-16 Thread Felipe Balbi
On Sat, Dec 14, 2013 at 04:48:38AM +0100, Apelete Seketeli wrote: > JZ4740 USB Device Controller is not OTG compatible and does not have DEVCTL > register in silicon. > > During ethernet-over-usb transactions, on reset, musb driver tries to > read from DEVCTL and consequently sets device as host (

Re: [GIT PULL] xhci: Regression fix for 3.13.

2013-12-16 Thread Sarah Sharp
On Fri, Dec 06, 2013 at 11:10:29PM -0500, Mark Lord wrote: > On 13-12-06 10:25 AM, Greg Kroah-Hartman wrote: > > On Fri, Dec 06, 2013 at 12:55:23AM -0500, Mark Lord wrote: > >> On 13-12-02 04:42 PM, Greg Kroah-Hartman wrote: > >>> On Mon, Dec 02, 2013 at 12:49:08PM -0800, Sarah Sharp wrote: >

Re: [PATCH v6 5/9] usb: gadget: s3c-hsotg: use generic phy_init()/phy_exit() support

2013-12-16 Thread Felipe Balbi
On Fri, Dec 13, 2013 at 11:51:19AM -0500, Matt Porter wrote: > If a generic phy is present, call phy_init()/phy_exit(). This supports > generic phys that must be soft reset before power on. > > Signed-off-by: Matt Porter > Acked-by: Kishon Vijay Abraham I > --- > drivers/usb/gadget/s3c-hsotg.c

Re: [PATCH v3] usb: gadget: Add UDC driver for Aeroflex Gaisler GRUSBDC

2013-12-16 Thread Felipe Balbi
Hi, On Sun, Dec 15, 2013 at 11:24:12PM +0100, Andreas Larsson wrote: > >>>Also, the way you're using thread IRQs is quite wrong. I can't let that > >>>pass and get merged upstream, sorry. > >> > >>What is quite wrong? What is it that I need to fix? > > > >Ideally the hardirq handler should be usua

Re: [PATCH v6 5/9] usb: gadget: s3c-hsotg: use generic phy_init()/phy_exit() support

2013-12-16 Thread Matt Porter
On Mon, Dec 16, 2013 at 03:20:01PM -0600, Felipe Balbi wrote: > On Fri, Dec 13, 2013 at 11:51:19AM -0500, Matt Porter wrote: > > If a generic phy is present, call phy_init()/phy_exit(). This supports > > generic phys that must be soft reset before power on. > > > > Signed-off-by: Matt Porter > >

Re: [PATCH v3 0/2] usb: fix controller-PHY binding for OMAP3 platform

2013-12-16 Thread Felipe Balbi
Hi, On Mon, Dec 16, 2013 at 09:23:43PM +0530, Kishon Vijay Abraham I wrote: > After the platform devices are created using PLATFORM_DEVID_AUTO, the > device names given in usb_bind_phy (in board file) does not match with > the actual device name causing the USB PHY library not to return the > PHY

Re: [PATCH v6 5/9] usb: gadget: s3c-hsotg: use generic phy_init()/phy_exit() support

2013-12-16 Thread Felipe Balbi
On Mon, Dec 16, 2013 at 04:26:44PM -0500, Matt Porter wrote: > On Mon, Dec 16, 2013 at 03:20:01PM -0600, Felipe Balbi wrote: > > On Fri, Dec 13, 2013 at 11:51:19AM -0500, Matt Porter wrote: > > > If a generic phy is present, call phy_init()/phy_exit(). This supports > > > generic phys that must be

Re: [PATCH v6 08/15] usb: phy-mxs: Add implementation of nofity_suspend and notify_resume

2013-12-16 Thread Felipe Balbi
Hi, On Mon, Dec 16, 2013 at 09:12:05AM +0800, Peter Chen wrote: > On Fri, Dec 13, 2013 at 02:09:24PM -0600, Felipe Balbi wrote: > > On Fri, Dec 13, 2013 at 02:31:42PM +0800, Peter Chen wrote: > > > On Fri, Dec 13, 2013 at 12:32 PM, Felipe Balbi wrote: > > > > On Fri, Dec 13, 2013 at 09:23:38AM +0

Re: [PATCH v4 5/9] usb: s3c-hsotg: Use the new Exynos USB phy driver with the generic phy framework

2013-12-16 Thread Matt Porter
On Thu, Dec 05, 2013 at 01:29:35PM +0100, Kamil Debski wrote: > Change the used phy driver to the new Exynos USB phy driver that uses the > generic phy framework. > > Signed-off-by: Kamil Debski > Signed-off-by: Kyungmin Park > --- > .../devicetree/bindings/usb/samsung-hsotg.txt |4 +++

Re: [PATCH 2/2] usb: gadget: storage: make FSG_BUFLEN configurable on Kconfig

2013-12-16 Thread Alan Stern
On Mon, 16 Dec 2013, Felipe Balbi wrote: > On Mon, Dec 16, 2013 at 09:20:20PM +, Paul Zimmerman wrote: > > > From: linux-usb-ow...@vger.kernel.org > > > [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Felipe Balbi > > > Sent: Monday, December 16, 2013 11:42 AM > > > > > > By making tha

Re: [PATCH v3 0/2] usb: fix controller-PHY binding for OMAP3 platform

2013-12-16 Thread Tony Lindgren
* Felipe Balbi [131216 13:31]: > Hi, > > On Mon, Dec 16, 2013 at 09:23:43PM +0530, Kishon Vijay Abraham I wrote: > > After the platform devices are created using PLATFORM_DEVID_AUTO, the > > device names given in usb_bind_phy (in board file) does not match with > > the actual device name causing

Re: [PATCH v3 0/2] usb: fix controller-PHY binding for OMAP3 platform

2013-12-16 Thread Felipe Balbi
Hi, On Mon, Dec 16, 2013 at 02:38:27PM -0800, Tony Lindgren wrote: > * Felipe Balbi [131216 13:31]: > > Hi, > > > > On Mon, Dec 16, 2013 at 09:23:43PM +0530, Kishon Vijay Abraham I wrote: > > > After the platform devices are created using PLATFORM_DEVID_AUTO, the > > > device names given in usb_

[PATCH v5 2/3] usb: gadget: epautoconf: check feature flags

2013-12-16 Thread Felipe Balbi
Start matching endpoints against feature flags, this will help us dropping the naming conventions currently used by the Gadget Framework. Signed-off-by: Felipe Balbi --- drivers/usb/gadget/epautoconf.c | 30 -- 1 file changed, 28 insertions(+), 2 deletions(-) diff --

[PATCH v5 3/3] usb: dwc3: gadget: set endpoint feature flags

2013-12-16 Thread Felipe Balbi
just so we can start using a more solid endpoint matching system. Signed-off-by: Felipe Balbi --- drivers/usb/dwc3/gadget.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c index b85ec11..301525e 100644 --- a/drivers/u

[PATCH v5 1/3] usb: gadget: ep: add feature flags

2013-12-16 Thread Felipe Balbi
Add a few flags to tell gadget framework which features a particular endpoint supports. Signed-off-by: Felipe Balbi --- include/linux/usb/gadget.h | 13 + 1 file changed, 13 insertions(+) diff --git a/include/linux/usb/gadget.h b/include/linux/usb/gadget.h index cae8a62..d84cdc5 100

Re: [PATCH 3/3] usb: musb: fix setting JZ4740 gadget periphal mode on reset

2013-12-16 Thread Apelete Seketeli
On 16-Dec-13, Felipe Balbi wrote: > On Sat, Dec 14, 2013 at 04:48:38AM +0100, Apelete Seketeli wrote: > > JZ4740 USB Device Controller is not OTG compatible and does not have DEVCTL > > register in silicon. > > > > During ethernet-over-usb transactions, on reset, musb driver tries to > > read from

RE: [PATCH] xhci: fix array index out of the bounds in function last_trb() and last_trb_on_last_seg()

2013-12-16 Thread Wang, Lin X
Hi Sarah, David is right, this patch may lead to the last trb in an event ring unprocessed according to the current logic, you can reject this patch, although I think index out-of-bounds is reasonable. If applying this patch, then corresponding function(inc_deq()) should be modified, maybe lik

Re: [PATCH 3/3] usb: musb: fix setting JZ4740 gadget periphal mode on reset

2013-12-16 Thread Felipe Balbi
Hi, On Tue, Dec 17, 2013 at 02:31:00AM +0100, Apelete Seketeli wrote: > On 16-Dec-13, Felipe Balbi wrote: > > On Sat, Dec 14, 2013 at 04:48:38AM +0100, Apelete Seketeli wrote: > > > JZ4740 USB Device Controller is not OTG compatible and does not have > > > DEVCTL > > > register in silicon. > > >

Re: [GIT PULL] xhci: Regression fix for 3.13.

2013-12-16 Thread Mark Lord
On 13-12-16 04:21 PM, Sarah Sharp wrote: > On Fri, Dec 06, 2013 at 11:10:29PM -0500, Mark Lord wrote: >> On 13-12-06 10:25 AM, Greg Kroah-Hartman wrote: >>> On Fri, Dec 06, 2013 at 12:55:23AM -0500, Mark Lord wrote: On 13-12-02 04:42 PM, Greg Kroah-Hartman wrote: > On Mon, Dec 02, 2013 at

Re: [PATCH] usb: phy: fix driver dependencies

2013-12-16 Thread Felipe Balbi
Hi, On Tue, Dec 10, 2013 at 09:01:18PM -0600, Felipe Balbi wrote: > On Tue, Dec 10, 2013 at 05:27:31PM -0800, Greg KH wrote: > > On Tue, Dec 10, 2013 at 05:00:06PM -0600, Felipe Balbi wrote: > > > both isp1301-omap and fsl_usb2_otg drivers > > > depend on usb_bus_start_enum() which is only > > > d

Re: [PATCH] usb: phy: fix driver dependencies

2013-12-16 Thread Greg KH
On Mon, Dec 16, 2013 at 11:12:28PM -0600, Felipe Balbi wrote: > Hi, > > On Tue, Dec 10, 2013 at 09:01:18PM -0600, Felipe Balbi wrote: > > On Tue, Dec 10, 2013 at 05:27:31PM -0800, Greg KH wrote: > > > On Tue, Dec 10, 2013 at 05:00:06PM -0600, Felipe Balbi wrote: > > > > both isp1301-omap and fsl_u

Re: [PATCH] usb: phy: fix driver dependencies

2013-12-16 Thread Felipe Balbi
On Mon, Dec 16, 2013 at 09:27:02PM -0800, Greg KH wrote: > On Mon, Dec 16, 2013 at 11:12:28PM -0600, Felipe Balbi wrote: > > Hi, > > > > On Tue, Dec 10, 2013 at 09:01:18PM -0600, Felipe Balbi wrote: > > > On Tue, Dec 10, 2013 at 05:27:31PM -0800, Greg KH wrote: > > > > On Tue, Dec 10, 2013 at 05:0

Re: Problem with disabled/not-connected USB causing "irq N: nobody cared"

2013-12-16 Thread Rafał Miłecki
2013/12/16 Alan Stern : > On Mon, 16 Dec 2013, Rafał Miłecki wrote: > >> I've just realized I didn't explain my problem fully, I'm sorry! This >> single warning about not handled IRQ isn't a real problem. The issue >> is that I'm spammed with such messages until hardware reboots itself. >> >> [ 7.2

[PATCH] usb: dwc3: ep0: Handle variable-length Data Stage

2013-12-16 Thread Anton Tikhomirov
In accordance with specification, when sent data length is an exact multiple of wMaxPacketSize for the pipe and less than requested by host, the function shall return a zero-length packet (ZLP) to indicate the end of the Data stage to a USB host. Signed-off-by: Anton Tikhomirov --- drivers/usb/d