Recall: [PATCH] xhci: remove unused variable 'addr' in inc_deq() and inc_enq().

2013-12-15 Thread Wang, Lin X
Wang, Lin X would like to recall the message, "[PATCH] xhci: remove unused variable 'addr' in inc_deq() and inc_enq().".-- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/major

Re: [PATCH] usb: gadget: nokia: fix error recovery path for optional functions

2013-12-15 Thread Sebastian Andrzej Siewior
On 12/13/2013 02:46 PM, Andrzej Pietrasiewicz wrote: > diff --git a/drivers/usb/gadget/nokia.c b/drivers/usb/gadget/nokia.c > index 0a8099a..3ab3861 100644 > --- a/drivers/usb/gadget/nokia.c > +++ b/drivers/usb/gadget/nokia.c > @@ -126,9 +126,9 @@ static int __init nokia_bind_config(struct > usb_c

Re: Bug#704242: Driver for PL-2303 HX not working

2013-12-15 Thread Karsten Malcher
Hello Greg, Am 14.12.2013 18:08, schrieb Greg KH: On Fri, Dec 13, 2013 at 04:06:35PM +0100, Karsten Malcher wrote: Hello together, is there anything new for the PL-2303 HX? It would be fine if it could work like in the past. Have you tried a newer kernel in a while? A number of things have b

Re: [PATCH] usbtest: Fix BOS control test for USB 2.01 devices.

2013-12-15 Thread Huang Rui
Hi Sarah, On Fri, Dec 13, 2013 at 01:56:19PM -0800, Sarah Sharp wrote: > Commit c952a8ba7136505cd1ca01735cc748ddc08c7d2f "usb: usbtest: add a > test case to support bos for queue control" will cause USB 2.01 and USB > 2.10 devices with a BOS descriptor to fail case 15 of the control test. > > The

[PATCH] xhci: fix array index out of the bounds in function last_trb() and last_trb_on_last_seg()

2013-12-15 Thread Wang, Lin X
In function last_trb() and last_trb_on_last_seg(), incorrect array index value 'TRBS_PER_SEGMENT' is used to determine the last element in an event ring segment, which lead to the out-of-bounds of index. But according to the current logic of event ring operation, this "bug" brings no problems an

[PATCH] xhci: remove unused variable 'addr' in inc_deq() and inc_enq()

2013-12-15 Thread Wang, Lin X
This patch removes the variable 'addr' assigned but never used in function inc_deq() and inc_enq(). Signed-off-by: Lin Wang --- drivers/usb/host/xhci-ring.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c index d26cd94..afa28c

Re: Bug#704242: Driver for PL-2303 HX not working

2013-12-15 Thread Greg KH
On Sun, Dec 15, 2013 at 11:32:33AM +0100, Karsten Malcher wrote: > Hello Greg, > > Am 14.12.2013 18:08, schrieb Greg KH: > > On Fri, Dec 13, 2013 at 04:06:35PM +0100, Karsten Malcher wrote: > >> Hello together, > >> > >> is there anything new for the PL-2303 HX? > >> It would be fine if it could w

Re: [RFC/PATCH 1/3] pm: make PM macros more smart

2013-12-15 Thread Pavel Machek
On Thu 2013-12-12 21:18:23, David Cohen wrote: > This patch makes SET_SYSTEM_SLEEP_PM_OPS() and SET_RUNTIME_PM_OPS() more > smart. > > Despite those macros check for '#ifdef CONFIG_PM_SLEEP/RUNTIME' to avoid > setting the callbacks when such #ifdef's aren't defined, they don't > handle compiler to

SuperSpeed ISO transfer returning EINVAL?

2013-12-15 Thread Florian Echtler
Hello everyone, I'm experimenting with the Kinect v2 on Linux (using libusbx-1.0.17). I've noticed that when trying to replicate the ISO transfers observed on Windows (8 packets of 0x8400 bytes each), I'm getting back -EINVAL from the usbfs IOCTL. For background info, I'm attaching a Wireshark di

Re: [RFC/PATCH 1/3] pm: make PM macros more smart

2013-12-15 Thread David Cohen
On Sun, Dec 15, 2013 at 06:51:12PM +0100, Pavel Machek wrote: > On Thu 2013-12-12 21:18:23, David Cohen wrote: > > This patch makes SET_SYSTEM_SLEEP_PM_OPS() and SET_RUNTIME_PM_OPS() more > > smart. > > > > Despite those macros check for '#ifdef CONFIG_PM_SLEEP/RUNTIME' to avoid > > setting the ca

Re: [RFC] fix our current target reap infrastructure.

2013-12-15 Thread Alan Stern
On Sat, 14 Dec 2013, James Bottomley wrote: > > The refcount test and state change race with scsi_alloc_target(). > > Maybe the race won't occur in practice, but to be safe you should hold > > shost->host_lock throughout that time interval, as the original code > > here does. > > You mean the f

Re: [RFC] fix our current target reap infrastructure.

2013-12-15 Thread James Bottomley
On Sun, 2013-12-15 at 16:32 -0500, Alan Stern wrote: > On Sat, 14 Dec 2013, James Bottomley wrote: > > > > The refcount test and state change race with scsi_alloc_target(). > > > Maybe the race won't occur in practice, but to be safe you should hold > > > shost->host_lock throughout that time in

Re: [PATCH v3] usb: gadget: Add UDC driver for Aeroflex Gaisler GRUSBDC

2013-12-15 Thread Andreas Larsson
On 12/13/2013 08:52 PM, Felipe Balbi wrote: Hi, On Fri, Dec 13, 2013 at 08:48:30AM +0100, Andreas Larsson wrote: On Wed, Dec 04, 2013 at 09:13:58AM +0100, Andreas Larsson wrote: +static void gr_finish_request(struct gr_ep *ep, struct gr_request *req, + int status) +

Re: [PATCH v6 08/15] usb: phy-mxs: Add implementation of nofity_suspend and notify_resume

2013-12-15 Thread Peter Chen
On Fri, Dec 13, 2013 at 02:09:24PM -0600, Felipe Balbi wrote: > On Fri, Dec 13, 2013 at 02:31:42PM +0800, Peter Chen wrote: > > On Fri, Dec 13, 2013 at 12:32 PM, Felipe Balbi wrote: > > > On Fri, Dec 13, 2013 at 09:23:38AM +0800, Peter Chen wrote: > > >> Implementation of notify_suspend and notify

Re: [PATCH 1/3] usb: chipidea: add support for USB OTG controller on LSI Zevio SoCs

2013-12-15 Thread Peter Chen
On Sun, Dec 15, 2013 at 02:35:07PM +1100, dt.ta...@gmail.com wrote: > From: Daniel Tang > > The USB controller in TI-NSPIRE calculators (LSI Zevio SoC) are based off > either > Freescale's USB OTG controller or the USB controller found in the IMX233, both > of which are Chipidea compatible. > >

Re: [PATCH 1/3] usb: chipidea: add support for USB OTG controller on LSI Zevio SoCs

2013-12-15 Thread Daniel Tang
Hi, On 16/12/2013, at 12:19 PM, Peter Chen wrote: > > The driver patch is okay for me, please cc me your dt patch next > time, I will apply it when your dt patches are applied by > dt maintainer (or any of your dt strings "zevio_xxx" are applied). > > -- > > Best Regards, > Peter Chen > Th

RE: [PATCH 7/7] usb: dwc3: exynos: add pm_runtime support

2013-12-15 Thread Anton Tikhomirov
Hi Felipe, > On Fri, Dec 13, 2013 at 02:01:32PM +0900, Anton Tikhomirov wrote: > > Hi Felipe, > > > > > -static int dwc3_exynos_suspend(struct device *dev) > > > +static int __dwc3_exynos_suspend(struct dwc3_exynos *exynos) > > > { > > > - struct dwc3_exynos *exynos = dev_get_drvdata(dev); > > >

Re: [RFC] fix our current target reap infrastructure.

2013-12-15 Thread Alan Stern
On Sun, 15 Dec 2013, James Bottomley wrote: > No, I was thinking of the two thread scan bug (i.e. two scan threads) > not one scan and one remove, which is a bug in the old code. This is a > race between put and get when the kref is incremented from zero (an > illegal operation which triggers a w

RE: [PATCH 7/7] usb: dwc3: exynos: add pm_runtime support

2013-12-15 Thread Anton Tikhomirov
Hi Felipe, > On Fri, Dec 13, 2013 at 01:56:18PM -0600, Felipe Balbi wrote: > > On Fri, Dec 13, 2013 at 02:01:32PM +0900, Anton Tikhomirov wrote: > > > Hi Felipe, > > > > > > > -static int dwc3_exynos_suspend(struct device *dev) > > > > +static int __dwc3_exynos_suspend(struct dwc3_exynos *exynos)

Re: [RFC] fix our current target reap infrastructure.

2013-12-15 Thread Alan Stern
On Sun, 15 Dec 2013, James Bottomley wrote: > No, I was thinking of the two thread scan bug (i.e. two scan threads) > not one scan and one remove, which is a bug in the old code. By the way, the existing code doesn't allow two threads to scan a target at the same time. They would both have to ho

Re: [RFC] fix our current target reap infrastructure.

2013-12-15 Thread James Bottomley
On Sun, 2013-12-15 at 21:44 -0500, Alan Stern wrote: > On Sun, 15 Dec 2013, James Bottomley wrote: > > > No, I was thinking of the two thread scan bug (i.e. two scan threads) > > not one scan and one remove, which is a bug in the old code. This is a > > race between put and get when the kref is i

Re: [RFC] fix our current target reap infrastructure.

2013-12-15 Thread James Bottomley
On Sun, 2013-12-15 at 21:49 -0500, Alan Stern wrote: > On Sun, 15 Dec 2013, James Bottomley wrote: > > > No, I was thinking of the two thread scan bug (i.e. two scan threads) > > not one scan and one remove, which is a bug in the old code. > > By the way, the existing code doesn't allow two threa

Re: BBB gadgetfs freeze patch

2013-12-15 Thread dbailey
palesius . writes: > > In working on a project (http://github.com/dominicgs/USBProxy) we ran > across an issue where io on endpoint 0 would cause the system to hang. > > We made the following change which resolved the problem for us. I'm > not sure if this is the "correct" fix, or if the proble

[PATCH 1/2] usb: gadget: atmel_usba: Use devm_*() functions

2013-12-15 Thread Jingoo Han
Use devm_*() functions to make cleanup paths simpler. Signed-off-by: Jingoo Han --- drivers/usb/gadget/atmel_usba_udc.c | 64 ++- 1 file changed, 17 insertions(+), 47 deletions(-) diff --git a/drivers/usb/gadget/atmel_usba_udc.c b/drivers/usb/gadget/atmel_usba

[PATCH 2/2] usb: gadget: atmel_usba: Fix sparse warning

2013-12-15 Thread Jingoo Han
'usba_gadget_template' is used only in this file. Thus, make 'usba_gadget_template' static, in order to fix the following sparse warning. warning: symbol 'usba_gadget_template' was not declared. Should it be static? Signed-off-by: Jingoo Han --- drivers/usb/gadget/atmel_usba_udc.c |2 +- 1

[PATCH] Remove double initialization of msg_namelen variable

2013-12-15 Thread Sankha Narayan Guria
This removes the double initialization of the msg_namelen variable. Signed-off-by: Sankha Narayan Guria --- linux/drivers/staging/usbip/usbip_common.c.orig 2013-12-16 11:24:32.930512781 +0530 +++ linux/drivers/staging/usbip/usbip_common.c 2013-12-16 11:25:03.190513334 +0530 @@ -366,7 +366,6 @@ i

Re: [PATCH 1/1] AX88179_178A: Add FLAG_HW_IPALIGN to determine whether reserving NET_IP_ALIGN bytes for an SKB.

2013-12-15 Thread Freddy Xin
On 2013年12月13日 18:36, David Laight wrote: From: fre...@asix.com.tw ... - skb = __netdev_alloc_skb_ip_align(dev->net, size, flags); + if (dev->driver_info->flags & FLAG_HW_IPALIGN) + skb = __netdev_alloc_skb(dev->net, size, flags); + else + skb = __