Re: [PATCH 1/1] mfd: omap-usb-host: Fix USB device detection problems on OMAP4 Panda

2013-12-02 Thread Roger Quadros
Hi David, On 11/29/2013 03:17 PM, David Laight wrote: >> From: Of Roger Quadros >> With u-boot 2013.10, USB devices are sometimes not detected >> on OMAP4 Panda. To make us independent of what bootloader does >> with the USB Host module, we must RESET it to get it to a known >> good state. This pa

[PATCH 1/1] support new huawei devices in option.c

2013-12-02 Thread Fangxiaozhi (Franko)
1. Add new supporting declarations to option.c, to support Huawei new devices with new bInterfaceProtocol value. Signed-off-by: fangxiaozhi --- linux-3.12.1/drivers/usb/serial/option.bk 2013-11-29 14:49:44.528970754 +0800 +++ linux-3.12.1/drivers/usb/serial/op

RE: net/usb/ax88179_178a driver broken in linux-3.12

2013-12-02 Thread David Laight
> From: Mark Lord > Sent: 30 November 2013 02:59 > To: Sarah Sharp; David Laight > Cc: David Miller; eric.duma...@gmail.com; ming@canonical.com; > net...@vger.kernel.org; linux- > u...@vger.kernel.org > Subject: Re: net/usb/ax88179_178a driver broken in linux-3.12 > > On 13-11-19 08:44 AM, Ma

Re: [PATCH 1/1] mfd: omap-usb-host: Fix USB device detection problems on OMAP4 Panda

2013-12-02 Thread Roger Quadros
+Benoit, Tony, Paul. Hi Michael, On 11/30/2013 06:48 AM, Michael Trimarchi wrote: > Hi Roger > > On Fri, Nov 29, 2013 at 2:01 PM, Roger Quadros wrote: >> With u-boot 2013.10, USB devices are sometimes not detected >> on OMAP4 Panda. To make us independent of what bootloader does >> with the USB

Re: [PATCH 1/1] mfd: omap-usb-host: Fix USB device detection problems on OMAP4 Panda

2013-12-02 Thread Roger Quadros
Michael, On 11/29/2013 05:32 PM, Michael Trimarchi wrote: > Hi Roger > > On Fri, Nov 29, 2013 at 2:01 PM, Roger Quadros wrote: >> With u-boot 2013.10, USB devices are sometimes not detected >> on OMAP4 Panda. To make us independent of what bootloader does >> with the USB Host module, we must RES

Re: [PATCH 1/1] mfd: omap-usb-host: Fix USB device detection problems on OMAP4 Panda

2013-12-02 Thread Michael Trimarchi
Hi Roger On Mon, Dec 2, 2013 at 10:39 AM, Roger Quadros wrote: > +Benoit, Tony, Paul. > > Hi Michael, > > On 11/30/2013 06:48 AM, Michael Trimarchi wrote: >> Hi Roger >> >> On Fri, Nov 29, 2013 at 2:01 PM, Roger Quadros wrote: >>> With u-boot 2013.10, USB devices are sometimes not detected >>> o

Re: [PATCH] usb: cdc-wdm: manage_power should always set needs_remote_wakeup

2013-12-02 Thread Oliver Neukum
On Fri, 2013-11-29 at 20:17 +0100, Bjørn Mork wrote: > Cc: > Reported-by: Oliver Neukum > Signed-off-by: Bjørn Mork Acked-by: Oliver Neukum -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [RFC PATH 1/3] phy: add USB ULPI abstraction layer

2013-12-02 Thread Kishon Vijay Abraham I
Hi, On Thursday 28 November 2013 09:29 PM, Heikki Krogerus wrote: > ULPI PHY is an USB2 PHY that is accessed from the USB > controller. ULPI PHYs allow discovery based on vendor and > product ids which allows binding the PHY to a driver. > > For USB controllers that are enumerated from buses such

Re: [RFC PATH 2/3] usb: dwc3: add ULPI interface support

2013-12-02 Thread Kishon Vijay Abraham I
Hi, On Thursday 28 November 2013 09:29 PM, Heikki Krogerus wrote: > Registers ULPI interface with the ULPI abstraction layer if > the HSPHY type is ULPI, which will create phy instance for > usb2. > > Depends on Kishon's patch set adding support for generic PHY > framework. > > Signed-off-by: He

Re: [RFC PATH 0/3] USB PHYs and PCI

2013-12-02 Thread Kishon Vijay Abraham I
Hi, On Thursday 28 November 2013 09:29 PM, Heikki Krogerus wrote: > Hi guys, > > PCI does not give any information about the PHY but we still need to > be able to take advantage of any possible vendor specific features, > such as custom PM operations, charger detection, ADP probing and > sensing,

Re: [PATCH 1/2] chipidea: ci_hdrc_imx: Allow handling the clock for an USB phy/hub

2013-12-02 Thread Mark Rutland
On Thu, Nov 14, 2013 at 02:09:46AM +, Fabio Estevam wrote: > From: Fabio Estevam > > When using external USB PHY or USB hub, it is common that they require a clock > input. > > Add a 'clk_phy' clock, so that it can be retrieved from the device tree and > enabled in the driver, so that the c

Re: [PATCH 2/2] ARM: dts: imx6q-udoo: Add USB host support

2013-12-02 Thread Mark Rutland
On Thu, Nov 14, 2013 at 02:09:47AM +, Fabio Estevam wrote: > From: Fabio Estevam > > Udoo board has USBH1 port connected to a USB2514 hub. > > Add support for it. > > Signed-off-by: Fabio Estevam > --- > arch/arm/boot/dts/imx6q-udoo.dts | 34 ++ > 1 file ch

Re: [PATCH v6 00/16] ARM: at91: move to common clk framework

2013-12-02 Thread boris brezillon
Hi Mike, Le 01/12/2013 00:05, Mike Turquette a écrit : Quoting Boris BREZILLON (2013-11-28 04:36:24) Hello, This patch series is the 5th version of the at91 clk implementations using the Common Clk Framework. Oops, I just replied to v5 of this series. Thanks for the fixes. Which tree do you w

Re: [PATCH 1/1] mfd: omap-usb-host: Fix USB device detection problems on OMAP4 Panda

2013-12-02 Thread Sebastian Andrzej Siewior
- sta...@vger.kernel.org since they probably don't care about this unless the patch is merged. On 12/02/2013 10:41 AM, Roger Quadros wrote: > Michael, > > On 11/29/2013 05:32 PM, Michael Trimarchi wrote: >> Hi Roger >> >> On Fri, Nov 29, 2013 at 2:01 PM, Roger Quadros wrote: >>> With u-boot 20

Re: [PATCH 1/1] mfd: omap-usb-host: Fix USB device detection problems on OMAP4 Panda

2013-12-02 Thread Roger Quadros
Michael, On 12/02/2013 11:51 AM, Michael Trimarchi wrote: > Hi Roger > > On Mon, Dec 2, 2013 at 10:39 AM, Roger Quadros wrote: >> +Benoit, Tony, Paul. >> >> Hi Michael, >> >> On 11/30/2013 06:48 AM, Michael Trimarchi wrote: >>> Hi Roger >>> >>> On Fri, Nov 29, 2013 at 2:01 PM, Roger Quadros wro

Re: [PATCH 1/1] mfd: omap-usb-host: Fix USB device detection problems on OMAP4 Panda

2013-12-02 Thread Roger Quadros
On 12/02/2013 02:01 PM, Sebastian Andrzej Siewior wrote: > - sta...@vger.kernel.org since they probably don't care about this > unless the patch is merged. > > On 12/02/2013 10:41 AM, Roger Quadros wrote: >> Michael, >> >> On 11/29/2013 05:32 PM, Michael Trimarchi wrote: >>> Hi Roger >>> >>> On

[PATCH 2/2] Indent with tab instead of spaces.

2013-12-02 Thread David Cluytens
From: David Cluytens --- drivers/usb/class/cdc-acm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c index 8ad4e94..e840431 100644 --- a/drivers/usb/class/cdc-acm.c +++ b/drivers/usb/class/cdc-acm.c @@ -1515,8 +151

[PATCH 1/2] Added support for the Lenovo RD02-D400 USB Modem

2013-12-02 Thread David Cluytens
From: David Cluytens --- drivers/usb/class/cdc-acm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c index 3e7560f..8ad4e94 100644 --- a/drivers/usb/class/cdc-acm.c +++ b/drivers/usb/class/cdc-acm.c @@ -1515,6 +1515,8 @@ static int

Re: [PATCH 1/1] mfd: omap-usb-host: Fix USB device detection problems on OMAP4 Panda

2013-12-02 Thread Sebastian Andrzej Siewior
On 12/02/2013 01:12 PM, Roger Quadros wrote: > You are right. The musb hwmod data doesn't have the HWMOD_INIT_NO_RESET > flag, so hwmod should reset it during boot. > > Maybe I too should just remove HWMOD_INIT_NO_RESET flag from the USB Host > hwmod data, then we don't need to change this driver

Re: [PATCH v6 00/16] ARM: at91: move to common clk framework

2013-12-02 Thread Nicolas Ferre
On 01/12/2013 00:05, Mike Turquette : Quoting Boris BREZILLON (2013-11-28 04:36:24) Hello, This patch series is the 5th version of the at91 clk implementations using the Common Clk Framework. Oops, I just replied to v5 of this series. Thanks for the fixes. Which tree do you want this to go th

Re: [PATCH v3 13/16] usb/gadget: FunctionFS: convert to new function interface with backward compatibility

2013-12-02 Thread Michal Nazarewicz
On Fri, Nov 22 2013, Andrzej Pietrasiewicz wrote: > This is required in order to integrate configfs support. > f_fs needs to be a separately compiled module and so it needs to use the new > interface. > > Signed-off-by: Andrzej Pietrasiewicz > Signed-off-by: Kyungmin Park Acked-by: Michal Nazare

[PATCH] Staging: usbip: vhci_hcd.c: removed a space

2013-12-02 Thread Aldo Iljazi
Line 921: Removed the space before the semicolon. Signed-off-by: Aldo Iljazi --- drivers/staging/usbip/vhci_hcd.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/usbip/vhci_hcd.c b/drivers/staging/usbip/vhci_hcd.c index e810ad5..fa3e0b2 100644 --- a/drivers

Re: [RFC PATH 1/3] phy: add USB ULPI abstraction layer

2013-12-02 Thread Heikki Krogerus
Hi, On Mon, Dec 02, 2013 at 04:20:51PM +0530, Kishon Vijay Abraham I wrote: > Hi, > > On Thursday 28 November 2013 09:29 PM, Heikki Krogerus wrote: > > ULPI PHY is an USB2 PHY that is accessed from the USB > > controller. ULPI PHYs allow discovery based on vendor and > > product ids which allows

Re: [PATCH 1/1] mfd: omap-usb-host: Fix USB device detection problems on OMAP4 Panda

2013-12-02 Thread Roger Quadros
On 12/02/2013 03:04 PM, Sebastian Andrzej Siewior wrote: > On 12/02/2013 01:12 PM, Roger Quadros wrote: >> You are right. The musb hwmod data doesn't have the HWMOD_INIT_NO_RESET >> flag, so hwmod should reset it during boot. >> >> Maybe I too should just remove HWMOD_INIT_NO_RESET flag from the US

Re: [PATCH 1/1] mfd: omap-usb-host: Fix USB device detection problems on OMAP4 Panda

2013-12-02 Thread Sebastian Andrzej Siewior
On 12/02/2013 02:35 PM, Roger Quadros wrote: >> It refers to "Errata Id:i660" why it is required. Once you figured what >> why it has been added you could have an idea if it is okay to remove it >> and if the reset you do here might lead to it (I dunno). >> > > Keshava no longer works @TI. I have

Re: [RFC PATH 2/3] usb: dwc3: add ULPI interface support

2013-12-02 Thread Heikki Krogerus
Hi, On Mon, Dec 02, 2013 at 04:24:31PM +0530, Kishon Vijay Abraham I wrote: > Hi, > > On Thursday 28 November 2013 09:29 PM, Heikki Krogerus wrote: > > diff --git a/drivers/usb/dwc3/Makefile b/drivers/usb/dwc3/Makefile > > index dd17601..8bb82bc 100644 > > --- a/drivers/usb/dwc3/Makefile > > +

Re: [PATCH 1/1] mfd: omap-usb-host: Fix USB device detection problems on OMAP4 Panda

2013-12-02 Thread Roger Quadros
On 12/02/2013 03:39 PM, Sebastian Andrzej Siewior wrote: > On 12/02/2013 02:35 PM, Roger Quadros wrote: >>> It refers to "Errata Id:i660" why it is required. Once you figured what >>> why it has been added you could have an idea if it is okay to remove it >>> and if the reset you do here might lead

Re: [PATCH 1/1] mfd: omap-usb-host: Fix USB device detection problems on OMAP4 Panda

2013-12-02 Thread Sebastian Andrzej Siewior
On 12/02/2013 02:44 PM, Roger Quadros wrote: > "Errata id: i660 > DESCRIPTION > In the following configuration : > • USBHOST module is set to smart-idle mode > • PRCM asserts idle_req to the USBHOST module. (This typically happens when > the system is going to > a low power mode : all ports have b

Re: [PATCH 1/3] HID: usbhid: merge the sis quirk

2013-12-02 Thread Jiri Kosina
On Wed, 27 Nov 2013, AceLan Kao wrote: > USB_VENDOR_ID_SIS and USB_VENDOR_ID_SIS2_TOUCH are identical, > so refine the code and merge the quirks. Good spotting. I have applied all 3 patches. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-usb

"Buggy kernel device driver?" for Super Top M6116 SATA Bridge (14cd:6116)

2013-12-02 Thread Jaime T
Hi folks. When I run "hdparm -N /dev/sdb" on my cheapo usb-connect sata bridge (Super Top M6116 SATA Bridge , device id 14cd:6116), it returns: /dev/sdb: max sectors = 1953525168/1(1953525168?), HPA setting seems invalid (buggy kernel device driver?) FWIW, I'm running Debian Testing - I origi

Re: [PATCH v6 00/16] ARM: at91: move to common clk framework

2013-12-02 Thread boris brezillon
On 02/12/2013 12:43, boris brezillon wrote: Hi Mike, Le 01/12/2013 00:05, Mike Turquette a écrit : Quoting Boris BREZILLON (2013-11-28 04:36:24) Hello, This patch series is the 5th version of the at91 clk implementations using the Common Clk Framework. Oops, I just replied to v5 of this seri

Re: [PATCH 1/1] mfd: omap-usb-host: Fix USB device detection problems on OMAP4 Panda

2013-12-02 Thread Paul Walmsley
On Mon, 2 Dec 2013, Roger Quadros wrote: > It won't be done by omap_hwmod as we set HWMOD_INIT_NO_RESET flag in the > hwmod data [1]. > > Question is do we do it in the driver of leave it to hwmod? It should be done by hwmod (or more broadly, some OMAP bus code). That way the device can be br

Re: net/usb/ax88179_178a driver broken in linux-3.12

2013-12-02 Thread Mark Lord
On 13-12-02 04:30 AM, David Laight wrote: >> From: Mark Lord >> Sent: 30 November 2013 02:59 >> To: Sarah Sharp; David Laight >> Cc: David Miller; eric.duma...@gmail.com; ming@canonical.com; >> net...@vger.kernel.org; linux- >> u...@vger.kernel.org >> Subject: Re: net/usb/ax88179_178a driver b

Re: [PATCH 1/1] mfd: omap-usb-host: Fix USB device detection problems on OMAP4 Panda

2013-12-02 Thread Roger Quadros
On 12/02/2013 04:03 PM, Sebastian Andrzej Siewior wrote: > On 12/02/2013 02:44 PM, Roger Quadros wrote: >> "Errata id: i660 >> DESCRIPTION >> In the following configuration : >> • USBHOST module is set to smart-idle mode >> • PRCM asserts idle_req to the USBHOST module. (This typically happens when

Re: [RFC PATH 0/3] USB PHYs and PCI

2013-12-02 Thread Heikki Krogerus
Hi, On Mon, Dec 02, 2013 at 04:33:26PM +0530, Kishon Vijay Abraham I wrote: > Hi, > > On Thursday 28 November 2013 09:29 PM, Heikki Krogerus wrote: > > Hi guys, > > > > PCI does not give any information about the PHY but we still need to > > be able to take advantage of any possible vendor speci

Re: "Buggy kernel device driver?" for Super Top M6116 SATA Bridge (14cd:6116)

2013-12-02 Thread Alan Stern
On Mon, 2 Dec 2013, Jaime T wrote: > Hi folks. > > When I run "hdparm -N /dev/sdb" on my cheapo usb-connect sata bridge > (Super Top M6116 SATA Bridge , device id 14cd:6116), it returns: > > /dev/sdb: > max sectors = 1953525168/1(1953525168?), HPA setting seems invalid > (buggy kernel device

RE: [PATCH 1/1] mfd: omap-usb-host: Fix USB device detection problems on OMAP4 Panda

2013-12-02 Thread David Laight
> From: Roger Quadros [mailto:rog...@ti.com] > On 11/29/2013 03:17 PM, David Laight wrote: ... > >> + timeout = jiffies + msecs_to_jiffies(100); > >> + while (!(usbhs_read(omap->uhh_base, OMAP_UHH_SYSSTATUS) > >> + & OMAP_UHH_SYSSTATUS_RESETDONE)) { > >> + cpu_relax(); >

[PATCH v4 10/16] usb/gadget: FunctionFS: Remove VLAIS usage from gadget code

2013-12-02 Thread Andrzej Pietrasiewicz
The use of variable length arrays in structs (VLAIS) in the Linux Kernel code precludes the use of compilers which don't implement VLAIS (for instance the Clang compiler). This alternate patch calculates offsets into the kmalloc-ed memory buffer using macros. The previous patch required multiple km

[PATCH v4 00/16] Equivalent of g_ffs with configfs

2013-12-02 Thread Andrzej Pietrasiewicz
This series aims at integrating configfs into FunctionFS, the way it has been done for acm, ncm, ecm, eem, ecm subset, rndis, obex, phonet and mass_storage. It contains everything that is required to provide the equivalent of g_ffs.ko with configfs. Configfs support in FunctionFS has been awaited

[PATCH v4 11/16] usb/gadget: FunctionFS: create utility file

2013-12-02 Thread Andrzej Pietrasiewicz
A header file to be used by f_fs.c and g_ffs.c will be required when f_fs.c is converted into a module. Signed-off-by: Andrzej Pietrasiewicz Signed-off-by: Kyungmin Park Acked-by: Michal Nazarewicz --- drivers/usb/gadget/f_fs.c |1 + drivers/usb/gadget/g_ffs.c | 19 ++-

[PATCH v4 16/16] usb/gadget: FunctionFS: add configfs support

2013-12-02 Thread Andrzej Pietrasiewicz
Add support for using FunctionFS in configfs-based USB gadgets. Signed-off-by: Andrzej Pietrasiewicz Signed-off-by: Kyungmin Park --- Documentation/ABI/testing/configfs-usb-gadget-ffs |9 +++ drivers/usb/gadget/Kconfig| 12 +++ drivers/usb/gadget/f_fs.c

[PATCH v4 13/16] usb/gadget: FunctionFS: convert to new function interface with backward compatibility

2013-12-02 Thread Andrzej Pietrasiewicz
This is required in order to integrate configfs support. f_fs needs to be a separately compiled module and so it needs to use the new interface. Signed-off-by: Andrzej Pietrasiewicz Signed-off-by: Kyungmin Park Acked-by: Michal Nazarewicz --- drivers/usb/gadget/Kconfig |3 + drivers/us

[PATCH v4 06/16] usb/gadget: f_subset: remove compatibility layer

2013-12-02 Thread Andrzej Pietrasiewicz
There are no old function interface users left, so the old interface can be removed. Signed-off-by: Andrzej Pietrasiewicz Signed-off-by: Kyungmin Park Acked-by: Michal Nazarewicz --- drivers/usb/gadget/f_subset.c | 60 + drivers/usb/gadget/u_ether.h |

[PATCH v4 07/16] usb/gadget: g_ffs: convert to new interface of f_rndis

2013-12-02 Thread Andrzej Pietrasiewicz
There is a new interface of f_rndis and g_ffs is the last to use the old one. Signed-off-by: Andrzej Pietrasiewicz Signed-off-by: Kyungmin Park Acked-by: Michal Nazarewicz --- drivers/usb/gadget/Kconfig |1 + drivers/usb/gadget/g_ffs.c | 105 +++- 2

[PATCH v4 03/16] usb/gadget: g_ffs: convert to new interface of f_ecm

2013-12-02 Thread Andrzej Pietrasiewicz
There is a new funtion interface and g_ffs is the last gadget to use the old. Signed-off-by: Andrzej Pietrasiewicz Signed-off-by: Kyungmin Park Acked-by: Michal Nazarewicz --- drivers/usb/gadget/Kconfig |1 + drivers/usb/gadget/g_ffs.c | 93 +--- 2

[PATCH v4 04/16] usb/gadget: f_ecm: remove compatibility layer

2013-12-02 Thread Andrzej Pietrasiewicz
There are no old function interface users left, so the old interface can be removed. Signed-off-by: Andrzej Pietrasiewicz Signed-off-by: Kyungmim Park Acked-by: Michal Nazarewicz --- drivers/usb/gadget/f_ecm.c | 73 +- drivers/usb/gadget/u_ether.h |

[PATCH v4 15/16] usb/gadget: FunctionFS: Remove compatibility layer

2013-12-02 Thread Andrzej Pietrasiewicz
There are no old function interface users left, so the old interface can be removed. Signed-off-by: Andrzej Pietrasiewicz Signed-off-by: Kyungmin Park --- drivers/usb/gadget/f_fs.c | 114 drivers/usb/gadget/u_fs.h |2 - include/linux/usb/f

[PATCH v4 14/16] usb/gadget: g_ffs: convert to new interface of f_fs

2013-12-02 Thread Andrzej Pietrasiewicz
Prepare for configfs integration. Use the new interface so that f_fs can be made a module. Signed-off-by: Andrzej Pietrasiewicz Signed-off-by: Kyungmin Park --- drivers/usb/gadget/Kconfig |1 + drivers/usb/gadget/g_ffs.c | 190 ++- 2 files changed, 1

[PATCH v4 09/16] usb/gadget: rndis: merge u_rndis.ko with usb_f_rndis.ko

2013-12-02 Thread Andrzej Pietrasiewicz
The rndis function's users use only the new interface, so the two modules can be merged. Signed-off-by: Andrzej Pietrasiewicz Signed-off-by: Kyungmin Park Acked-by: Michal Nazarewicz --- drivers/usb/gadget/Kconfig |7 --- drivers/usb/gadget/Makefile |4 +--- drivers/usb/gadget/f

[PATCH v4 12/16] usb/gadget: FunctionFS: add devices management code

2013-12-02 Thread Andrzej Pietrasiewicz
This will be required in order to use the new function interface (usb_get_function_instance/usb_put_function_instance) Signed-off-by: Andrzej Pietrasiewicz Signed-off-by: Kyunmgin Park Acked-by: Michal Nazarewicz --- drivers/usb/gadget/f_fs.c | 221 ++-

[PATCH v4 08/16] usb/gadget: f_rndis: remove compatibility layer

2013-12-02 Thread Andrzej Pietrasiewicz
There are no old function interface users left, so the old interface can be removed. Signed-off-by: Andrzej Pietrasiewicz Signed-off-by: Kyungmin Park Acked-by: Michal Nazarewicz --- drivers/usb/gadget/f_rndis.c | 72 +- drivers/usb/gadget/u_ether.h |

[PATCH v4 05/16] usb/gadget: g_ffs: convert to new interface of f_subset

2013-12-02 Thread Andrzej Pietrasiewicz
There is a new function interface of f_subset and g_ffs is the last to use the old one. Signed-off-by: Andrzej Pietrasiewicz Signed-off-by: Kyungmin Park Acked-by: Michal Nazarewicz --- drivers/usb/gadget/Kconfig |1 + drivers/usb/gadget/g_ffs.c | 69 ++---

Re: 3.12.1 Virt dev invalid for slot_id 0x1 from drivers/usb/host/xhci.c

2013-12-02 Thread Sarah Sharp
On Wed, Nov 27, 2013 at 05:21:57PM -0700, Shuah Khan wrote: > On 11/27/2013 02:59 PM, Sarah Sharp wrote: > >On Mon, Nov 25, 2013 at 11:41:47AM -0700, Shuah Khan wrote: > >>I started seeing the following on my Samsung Series on 3.12.1 > >> > >>Is this bad? Looks like the following WARN_ON is firing:

[PATCH v4 02/16] usb/gadget: g_ffs: remove a reduntant gfs_ether_setup variable

2013-12-02 Thread Andrzej Pietrasiewicz
Since d6a0143985489e470a118605352f4b18df0ce142 usb: gadget: move the global the_dev variable to their users "the_dev" variable can be used as a "setup done" flag; non-NULL meaning "setup done", NULL meaning "setup not done". Moreover, gether_cleanup() can be safely called with a NULL argument. Cor

[PATCH v4 01/16] usb/gadget: configfs: allow setting function instance's name

2013-12-02 Thread Andrzej Pietrasiewicz
USB function's configfs config group is created in a generic way in usb/gadget/configfs.c:function_make(), which in turn delegates actual allocation and setup of the USB function instance to a particular implementation, e.g. in f_acm.c. The said implementation does its job in a parameter-less funct

Re: [PATCH 2/3] usb: phy-ulpi: Add EXTVBUSIND,CHRGVBUS flag support

2013-12-02 Thread Sergei Shtylyov
On 12/02/2013 10:05 AM, Chris Ruehl wrote: usb: phy-ulpi: Add EXTVBUSIND,CHRGVBUS flag support ULPI like ISP1504 support external vbus power indication used in combination with vbus switches mic2075. Signed-off-by: Chris Ruehl --- drivers/usb/phy/phy-ulpi.c | 11 ++- 1 file c

Re: [PATCH 2/2] Indent with tab instead of spaces.

2013-12-02 Thread Sergei Shtylyov
Hello. On 12/02/2013 03:19 PM, David Cluytens wrote: From: David Cluytens --- drivers/usb/class/cdc-acm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c index 8ad4e94..e840431 100644 --- a/drivers/usb/cl

Re: [PATCH 3/3] usb: phy-generic: Add ULPI VBUS support

2013-12-02 Thread Mark Rutland
On Mon, Dec 02, 2013 at 07:05:19AM +, Chris Ruehl wrote: > usb: phy-generic: Add ULPI VBUS support > > Some platforms need to set the VBUS parameters of the ULPI > like ISP1504 which interact with overcurrent protection and > power switch MIC2575. Therefore it requires to set > * DRVVBUS > * D

Re: [PATCH v6 5/5] usb: dwc3: implement gadget's quirk ep_out_align_size

2013-12-02 Thread David Cohen
On 11/25/2013 01:06 PM, Felipe Balbi wrote: > Hi, > > On Tue, Nov 12, 2013 at 01:04:46PM -0800, David Cohen wrote: >> diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c >> index 5452c0fce360..7c2d36f6ad4b 100644 >> --- a/drivers/usb/dwc3/gadget.c >> +++ b/drivers/usb/dwc3/gadget.c

Re: [GIT PULL] xhci: Big-endian sparse fixes.

2013-12-02 Thread Sarah Sharp
On Wed, Nov 27, 2013 at 03:49:43PM -0800, Sarah Sharp wrote: > On Wed, Nov 27, 2013 at 03:36:56PM -0800, Greg Kroah-Hartman wrote: > > On Wed, Nov 27, 2013 at 03:36:02PM -0800, Greg Kroah-Hartman wrote: > > > On Wed, Nov 27, 2013 at 03:14:40PM -0800, Sarah Sharp wrote: > > > > The following changes

Re: [PATCH v4 14/16] usb/gadget: g_ffs: convert to new interface of f_fs

2013-12-02 Thread Michal Nazarewicz
On Mon, Dec 02 2013, Andrzej Pietrasiewicz wrote: > - ffs_dev_lock(); > for (i = 0; i < func_num; i++) { > - ffs_tab[i] = ffs_alloc_dev(); > - if (IS_ERR(ffs_tab[i])) { > - ret = PTR_ERR(ffs_tab[i]); > - --i; > +

Re: [PATCH v4 15/16] usb/gadget: FunctionFS: Remove compatibility layer

2013-12-02 Thread Michal Nazarewicz
On Mon, Dec 02 2013, Andrzej Pietrasiewicz wrote: > There are no old function interface users left, so the old interface can > be removed. > > Signed-off-by: Andrzej Pietrasiewicz > Signed-off-by: Kyungmin Park Acked-by: Michal Nazarewicz > --- > drivers/usb/gadget/f_fs.c | 114 > -

Re: [PATCH v4 16/16] usb/gadget: FunctionFS: add configfs support

2013-12-02 Thread Michal Nazarewicz
On Mon, Dec 02 2013, Andrzej Pietrasiewicz wrote: > Add support for using FunctionFS in configfs-based USB gadgets. > > Signed-off-by: Andrzej Pietrasiewicz > Signed-off-by: Kyungmin Park Acked-by: Michal Nazarewicz Sorry for the delay with this patchset. > --- > Documentation/ABI/testing/co

Re: net/usb/ax88179_178a driver broken in linux-3.12

2013-12-02 Thread Sarah Sharp
On Mon, Dec 02, 2013 at 10:05:54AM -0500, Mark Lord wrote: > On 13-12-02 04:30 AM, David Laight wrote: > >> From: Mark Lord > >> Sent: 30 November 2013 02:59 > >> To: Sarah Sharp; David Laight > >> Cc: David Miller; eric.duma...@gmail.com; ming@canonical.com; > >> net...@vger.kernel.org; linux

Re: net/usb/ax88179_178a driver broken in linux-3.12

2013-12-02 Thread Mark Lord
On 13-12-02 02:08 PM, Sarah Sharp wrote: >> On 13-12-02 04:30 AM, David Laight wrote: .. >>> Sarah needs to feed the xhci_ring.c fix through into stable. .. > I'm working on it. You will probably have to wait for -rc3, depending > on when Greg sends his next pull request. I will Cc you on the pul

Re: net/usb/ax88179_178a driver broken in linux-3.12

2013-12-02 Thread Greg KH
On Mon, Dec 02, 2013 at 11:08:36AM -0800, Sarah Sharp wrote: > On Mon, Dec 02, 2013 at 10:05:54AM -0500, Mark Lord wrote: > > On 13-12-02 04:30 AM, David Laight wrote: > > >> From: Mark Lord > > >> Sent: 30 November 2013 02:59 > > >> To: Sarah Sharp; David Laight > > >> Cc: David Miller; eric.duma.

Re: cdc_acm crash with multiple USB modems

2013-12-02 Thread Johan Hovold
On Mon, Nov 25, 2013 at 11:38:38AM -0600, m...@privateit.net wrote: > Hi there, > > Apologies if I'm submitting this issue to the wrong place. > > The problem: > > Basically I have a Hylafax server running with 4 USB modems all using the > cdc_acm driver. Everything works great unless a job is

Re: zte_ev not properly handling ZTE AC2726 CDMA modems

2013-12-02 Thread Dmitry Kunilov
On 11/28/2013 2:33 AM, Johan Hovold wrote: On Wed, Nov 27, 2013 at 11:51:29AM -0500, Alan Stern wrote: On Wed, 27 Nov 2013, Johan Hovold wrote: I am attaching the output that I am getting in the syslog. Note that I have two usb modems connected to that router and that's how I am able to debug

[GIT PULL] xhci: Regression fix for 3.13.

2013-12-02 Thread Sarah Sharp
The following changes since commit c24cb6c8b501ebdf1aacec7960110a9741a45ced: Merge tag 'fixes-for-v3.13-rc2' of git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb into usb-linus (2013-11-27 09:49:03 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/ker

[PATCH 1/1] usb: xhci: Link TRB must not occur within a USB payload burst

2013-12-02 Thread Sarah Sharp
From: David Laight Section 4.11.7.1 of rev 1.0 of the xhci specification states that a link TRB can only occur at a boundary between underlying USB frames (512 bytes for high speed devices). If this isn't done the USB frames aren't formatted correctly and, for example, the USB3 ethernet ax88179_

[PATCH 0/3] usb: wusbcore: connect/disconnect fixes

2013-12-02 Thread Thomas Pugliese
This set of patches fixes various problems that can occur when connecting and disconnecting Wireless USB devices. Thomas Pugliese (3): usb: wusbcore: send keepalives to unauthenticated devices usb: wusbcore: do device lookup while holding the hc mutex usb: wusbcore: fix deadlock in wusbhc_g

[PATCH 2/3] usb: wusbcore: do device lookup while holding the hc mutex

2013-12-02 Thread Thomas Pugliese
This patch modifies the device notification handler to not look up the wusb_dev object before it calls the lower-level handler routines since the wusbhc mutex is not held when calling those routines and the device could go away in the meantime. Instead, let the individual notification handlers

[PATCH 3/3] usb: wusbcore: fix deadlock in wusbhc_gtk_rekey

2013-12-02 Thread Thomas Pugliese
When multiple wireless USB devices are connected and one of the devices disconnects, the host will distribute a new group key to the remaining devicese using wusbhc_gtk_rekey. wusbhc_gtk_rekey takes the wusbhc->mutex and holds it while it submits a URB to set the new key. This causes a deadloc

[PATCH 1/3] usb: wusbcore: send keepalives to unauthenticated devices

2013-12-02 Thread Thomas Pugliese
This patch modifies the WUSB device disconnect timer code to send keepalives to all connected devices even if they are not authenticated. This fixes a problem where unauthenticated devices that lose their connection before they are authenticated will stay in the device tree forever. More impo

Re: [GIT PULL] xhci: Regression fix for 3.13.

2013-12-02 Thread Greg Kroah-Hartman
On Mon, Dec 02, 2013 at 12:49:08PM -0800, Sarah Sharp wrote: > The following changes since commit c24cb6c8b501ebdf1aacec7960110a9741a45ced: > > Merge tag 'fixes-for-v3.13-rc2' of > git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb into usb-linus > (2013-11-27 09:49:03 -0800) > > are ava

Re: [GIT PULL] xhci: Big-endian sparse fixes.

2013-12-02 Thread Greg Kroah-Hartman
On Mon, Dec 02, 2013 at 10:40:48AM -0800, Sarah Sharp wrote: > On Wed, Nov 27, 2013 at 03:49:43PM -0800, Sarah Sharp wrote: > > On Wed, Nov 27, 2013 at 03:36:56PM -0800, Greg Kroah-Hartman wrote: > > > On Wed, Nov 27, 2013 at 03:36:02PM -0800, Greg Kroah-Hartman wrote: > > > > On Wed, Nov 27, 2013

Re: [PATCHv4] USB: serial: option: add support for Huawei E173s-6

2013-12-02 Thread Greg KH
On Sat, Nov 23, 2013 at 01:07:45PM +0100, Johan Hovold wrote: > On Mon, Nov 11, 2013 at 09:59:15AM -0300, Gustavo Zacarias wrote: > > Interface 1 on this device isn't for option to bind to otherwise an oops > > on usb_wwan with log flooding will happen when accessing the port: > > > > tty_release:

Re: [PATCH] usb: xhci-plat: Enable USB 2.0 hardware LPM support for platform xHCs

2013-12-02 Thread Julius Werner
*ping* Is anyone still reading this or should I resubmit? Sorry for being annoying, just please let me know if this is already considered to get picked up at the next opportunity or if you've intentionally decided against it for now. I want to make sure it didn't fall through the cracks somewhere.

Re: 答复: Re: 答复: Re: 【PATCH】USB:add new zte 3g-modem's pid to option.c

2013-12-02 Thread Greg KH
On Thu, Nov 28, 2013 at 05:19:02PM +0800, zhang.ju...@zte.com.cn wrote: > > On Thu, Nov 28, 2013 at 10:46:51AM +0800, zhang.ju...@zte.com.cn wrote: > > > > Signed-off-by: Jun zhang > > You failed to answer my question from before, why? > Re:Since i was the first time to commit patch,i am so sorr

Re: [PATCH 0/3] usb: wusbcore: connect/disconnect fixes

2013-12-02 Thread Greg KH
On Mon, Dec 02, 2013 at 03:39:42PM -0600, Thomas Pugliese wrote: > This set of patches fixes various problems that can occur when connecting > and disconnecting Wireless USB devices. > > Thomas Pugliese (3): > usb: wusbcore: send keepalives to unauthenticated devices > usb: wusbcore: do devic

Re: [PATCH 0/3] usb: wusbcore: connect/disconnect fixes

2013-12-02 Thread Thomas Pugliese
On Mon, 2 Dec 2013, Greg KH wrote: > On Mon, Dec 02, 2013 at 03:39:42PM -0600, Thomas Pugliese wrote: > > This set of patches fixes various problems that can occur when connecting > > and disconnecting Wireless USB devices. > > > > Thomas Pugliese (3): > > usb: wusbcore: send keepalives to u

test-feedback: more problems with 3.13 than with 3.12 using mbim at K5150-surfstick

2013-12-02 Thread Thomas Schäfer
Hi, a short description of the situation: focus is on IPv6 3.12: start of Modemmanager and device plugged in little bit waiting then the "trick" because of arp/noarp/nd-problem: "ifconfig wwan0 arp" mmcli --simple connect confirmed with ok /sbin/ip link set wwan0 up got addresses

[PATCH 01/15] xhci: convert TRB_CYCLE to le32 before using it to set Link TRB's cycle bit

2013-12-02 Thread Sarah Sharp
From: Xenia Ragiadakou This patch converts TRB_CYCLE to le32 to update correctly the Cycle Bit in 'control' field of the link TRB. This bug was found using sparse. Signed-off-by: Xenia Ragiadakou Signed-off-by: Sarah Sharp --- drivers/usb/host/xhci-mem.c | 5 +++-- 1 file changed, 3 insertion

RE: Staff and Faculty Mailbox Access Message !

2013-12-02 Thread Camp, Jean
From: Camp, Jean Sent: Monday, December 02, 2013 4:02 PM To: Camp, Jean Subject: Staff and Faculty Mailbox Access Message ! Staff and Faculty Mailbox Message ! 495MB500MB This is to notify all Faculty Members and Staf

[PATCH 15/15] xhci: replace xhci_write_64() with writeq()

2013-12-02 Thread Sarah Sharp
From: Xenia Ragiadakou Function xhci_write_64() is used to write 64bit xHC registers residing in MMIO. On 32bit systems, xHC registers need to be written with 32bit accesses by writing first the lower 32bits and then the higher 32bits. The header file asm-generic/io-64-nonatomic-lo-hi.h ensures t

[PATCH 11/15] xhci: remove conversion from generic to pci device in xhci_mem.c

2013-12-02 Thread Sarah Sharp
From: Xenia Ragiadakou This patch removes the to_pci_dev() conversion performed to generic struct device since it is not actually useful (the pointer to the generic device can be used directly rather through a conversion to pci_dev) and it is pci bus specific. This isn't stable material because

[PATCH 12/15] xhci: replace xhci_readl() with readl()

2013-12-02 Thread Sarah Sharp
From: Xenia Ragiadakou Function xhci_readl() is used to read 32bit xHC registers residing in MMIO address space. It takes as first argument a pointer to the xhci_hcd although it does not use it. xhci_readl() internally simply calls readl(). This creates an illusion that xhci_readl() is an xhci sp

[PATCH 05/15] xhci: fix incorrect type in assignment in xhci_address_device()

2013-12-02 Thread Sarah Sharp
From: Xenia Ragiadakou The field 'dev_info' in struct xhci_slot_ctx has type __le32 and it needs to be converted to CPU byteorder for the correct retrieval of its subfield 'Context Entries'. This field is used by the trace event 'xhci_address_ctx' to trace only the contexts of valid endpoints. Th

[PATCH 13/15] xhci: replace xhci_writel() with writel()

2013-12-02 Thread Sarah Sharp
From: Xenia Ragiadakou Function xhci_writel() is used to write a 32bit value in xHC registers residing in MMIO address space. It takes as first argument a pointer to the xhci_hcd although it does not use it. xhci_writel() internally simply calls writel(). This creates an illusion that xhci_writel

[PATCH 09/15] xhci: fix incorrect type in assignment in xhci_count_num_new_endpoints()

2013-12-02 Thread Sarah Sharp
From: Xenia Ragiadakou The fields 'add_flags' and 'drop_flags' in struct xhci_input_control_ctx have type __le32 and need to be converted to CPU byteorder before being used to derive the number of added endpoints. This bug was found using sparse. This patch is not suitable for stable, since the

[PATCH 03/15] xhci: fix derivation of TRB's DMA address in xhci_log_event Trace Event Class

2013-12-02 Thread Sarah Sharp
From: Xenia Ragiadakou This patch fixes the retrieval of the DMA address of the TRB that generated the event by converting the field[0] (low address bits) and field[1] (high address bits) to CPU byteorder and then typecasting field[1] to u64 so that the bitshift will not lead to overflow. In the

[GIT PULL] xhci: Cleanup for 3.14: Sparse fixes, replace xhci_read/write, misc

2013-12-02 Thread Sarah Sharp
The following changes since commit 6ce4eac1f600b34f2f7f58f9cd8f0503d79e42ae: Linux 3.13-rc1 (2013-11-22 11:30:55 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/sarah/xhci.git tags/for-usb-next-2013-12-02 for you to fetch changes up to 7dd09a1af

[PATCH 04/15] xhci: fix sparse warning in xhci-trace.h

2013-12-02 Thread Sarah Sharp
From: Xenia Ragiadakou This patch fixes the following sparse warnings: drivers/usb/host/./xhci-trace.h:116:1: warning: cast to restricted __le32 drivers/usb/host/./xhci-trace.h:116:1: warning: cast to restricted __le32 drivers/usb/host/./xhci-trace.h:116:1: warning: restricted __le32 degrades to

[PATCH 06/15] xhci: replace USB_MAXINTERFACES with config->desc.bNumInterface

2013-12-02 Thread Sarah Sharp
From: Xenia Ragiadakou This patch replaces USB_MAXINTERFACES with config->desc.bNumInterface in the termination condition for the loop that updates the LPM timeout of the endpoints on the cofiguration's interfaces, in xhci_calculate_lpm_timeout(), to avoid unnecessary loop cycles since most confi

[PATCH 10/15] xhci: fix incorrect type in assignment in xhci_count_num_dropped_endpoints()

2013-12-02 Thread Sarah Sharp
From: Xenia Ragiadakou The fields 'add_flags' and 'drop_flags' in struct xhci_input_control_ctx have type __le32 and need to be converted to CPU byteorder before being used to derive the number of dropped endpoints. This bug was found using sparse. This patch is not suitable for stable, since th

[PATCH 14/15] xhci: replace xhci_read_64() with readq()

2013-12-02 Thread Sarah Sharp
From: Xenia Ragiadakou Function xhci_read_64() is used to read 64bit xHC registers residing in MMIO. On 32bit systems, xHC registers need to be read with 32bit accesses by reading first the lower 32bits and then the higher 32bits. Replace all calls to xhci_read_64() with calls to readq() and inc

[PATCH 07/15] xhci: fix SCT_FOR_CTX(p) macro

2013-12-02 Thread Sarah Sharp
From: Xenia Ragiadakou SCT_FOR_CTX(p) is defined as (((p) << 1) & 0x7) in which case if we want to set the stream context type to SCT_SSA_256 i.e 0x7 (although secondary stream arrays are not yet supported) using this macro definition we will get actually 0x6 which is not what we want. This patc

[PATCH 08/15] xhci: remove unnecessary check in xhci_free_stream_info()

2013-12-02 Thread Sarah Sharp
From: Xenia Ragiadakou This patch removes the unneccessary check 'if (stream_info)' because there is already a check few lines above which ensures that stream_info is not NULL. Signed-off-by: Xenia Ragiadakou Signed-off-by: Sarah Sharp --- drivers/usb/host/xhci-mem.c | 3 +-- 1 file changed,

[PATCH 02/15] xhci: fix incorrect type in assignment in handle_device_notification()

2013-12-02 Thread Sarah Sharp
From: Xenia Ragiadakou This patch converts Event TRB's 3rd field, which has type le32, to CPU byteorder before using it to retrieve the Slot ID with TRB_TO_SLOT_ID macro. This bug was found using sparse. Signed-off-by: Xenia Ragiadakou Signed-off-by: Sarah Sharp --- drivers/usb/host/xhci-ring

Re: [PATCH 3/5] USB: xHCI: use DEFINE_PCI_DEVICE_TABLE macro

2013-12-02 Thread Sarah Sharp
On Thu, Nov 28, 2013 at 11:08:13AM +0900, Jingoo Han wrote: > This macro is used to create a struct pci_device_id array. > > Signed-off-by: Jingoo Han Applied to my for-usb-next-queue branch. It will be queued to Greg's usb-next branch, and should be merged into 3.14. Sarah Sharp > --- > dri

  1   2   >