Re: [PATCH v3 8/9] phy: add Broadcom Kona USB2 PHY driver

2013-11-27 Thread Kishon Vijay Abraham I
Hi, On Monday 25 November 2013 11:46 PM, Matt Porter wrote: > Add a driver for the internal Broadcom Kona USB 2.0 PHY found > on the BCM281xx family of SoCs. > > Signed-off-by: Matt Porter > --- > drivers/phy/Kconfig | 6 ++ > drivers/phy/Makefile| 1 + > drivers/phy

Re: [PATCH v3 9/9] ARM: dts: add usb udc support to bcm281xx

2013-11-27 Thread Kishon Vijay Abraham I
Hi, On Monday 25 November 2013 11:46 PM, Matt Porter wrote: > Adds USB OTG/PHY and clock support to BCM281xx and enables > UDC support on the bcm11351-brt and bcm28155-ap boards. > > Signed-off-by: Matt Porter > Reviewed-by: Markus Mayer > Reviewed-by: Tim Kryger > --- > arch/arm/boot/dts/bcm

Re: [PATCH 1/3] usb: dwc3: Add Keystone specific glue layer

2013-11-27 Thread George Cherian
On 11/26/2013 1:46 AM, WingMan Kwok wrote: Add Keystone platform specific glue layer to support USB3 Host mode. Cc: Santosh Shilimkar Cc: Felipe Balbi Cc: Greg Kroah-Hartman Signed-off-by: WingMan Kwok --- drivers/usb/dwc3/Kconfig |7 + drivers/usb/dwc3/Makefile|1

Re: [PATCH v2] PM / Sleep: Add pm_generic functions to re-use runtime PM callbacks

2013-11-27 Thread Ulf Hansson
>> >> There are already a generic callbacks that does this. Normally the >> generic callbacks is used from buses and power domains. >> >> My new callbacks are intended to be used from the driver, so those are >> kind of different from the others in that sense. > > Hmm. I see. > > For that to work,

Re: [PATCH 2/3] ARM: dts: keystone: Add usb devicetree bindings

2013-11-27 Thread George Cherian
On 11/26/2013 1:46 AM, WingMan Kwok wrote: Added device tree support for TI's Keystone USB driver and updated the Documentation with device tree binding information. On Keystone II platforms, we use no-op phy driver. Cc: Santosh Shilimkar Signed-off-by: WingMan Kwok --- .../devicetree/bindi

Re: huawei E5776 (hilink) 3.12-->3.13 not working anymore

2013-11-27 Thread Bjørn Mork
Thomas Schäfer writes: > Hi, > > I have it already mentioned somewhere. Sorry for duplicates. > > The Huawei E5776 > (normal use, classic IPv4, hilink mode (with webinterface and RFC1918 IP- > config including NAT) So this is always connected and you don't normally use ModemManager or any oth

[PATCH] usb: s3c-hsotg: change dependency to PLAT_SAMSUNG

2013-11-27 Thread Marek Szyprowski
On device tree based Samsung SoC platforms (like Exynos) no platform devices are defined and CONFIG_S3C_DEV_USB_HSOTG is no longer available, so change the driver dependency to more generic and appropriate CONFIG_PLAT_SAMSUNG, as the driver can be used on almost all Samsung platforms. Signed-off-b

Re: huawei E5776 (hilink) 3.12-->3.13 not working anymore

2013-11-27 Thread Thomas Schäfer
Am 27.11.2013 13:33, schrieb Bjørn Mork: Thomas Schäfer writes: Hi, I have it already mentioned somewhere. Sorry for duplicates. The Huawei E5776 (normal use, classic IPv4, hilink mode (with webinterface and RFC1918 IP- config including NAT) So this is always connected and you don't normal

Re: [PATCH v2] PM / Sleep: Add pm_generic functions to re-use runtime PM callbacks

2013-11-27 Thread Rafael J. Wysocki
On Wednesday, November 27, 2013 10:59:57 AM Ulf Hansson wrote: > >> > >> There are already a generic callbacks that does this. Normally the > >> generic callbacks is used from buses and power domains. > >> > >> My new callbacks are intended to be used from the driver, so those are > >> kind of diff

Re: huawei E5776 (hilink) 3.12-->3.13 not working anymore

2013-11-27 Thread Bjørn Mork
Thomas Schäfer writes: > Am 27.11.2013 13:33, schrieb Bjørn Mork: >> Thomas Schäfer writes: >> >>> Hi, >>> >>> I have it already mentioned somewhere. Sorry for duplicates. >>> >>> The Huawei E5776 >>> (normal use, classic IPv4, hilink mode (with webinterface and RFC1918 IP- >>> config including

Re: [PATCH] A patch fro support alcatel's new products

2013-11-27 Thread gre...@linuxfoundation.org
On Wed, Nov 27, 2013 at 05:54:03AM +, Yanan, SUO(MBB-SZ-TCT) wrote: > Hi : > > We want make our new product work well on Linux(fedora, Debian, Ubuntu) && > Android, and have make patch tested ,It,s perfect. It is? :) Unfortunatly you sent this email in html form, with a base64 attachment,

Re: 【PATCH】USB:add new zte 3g-modem's pid to option.c

2013-11-27 Thread Greg KH
On Wed, Nov 27, 2013 at 05:01:59PM +0800, zhang.ju...@zte.com.cn wrote: > > Signed-off-by: Jun zhang > > --- drivers/usb/serial/option.cThu Nov 21 04:37:52 2013 > +++ drivers/usb/serial/option_bac.cWed Nov 27 16:00:58 2013 > @@ -1427,6 +1427,19 @@ > { USB_VENDOR_AND_INTE

Re: [PATCH v2] PM / Sleep: Add pm_generic functions to re-use runtime PM callbacks

2013-11-27 Thread Ulf Hansson
> > We first need to clarify the terminology as that seems to be the source of > the confusion to some extent at least. > > When I (or Alan presumably too) say "a subsystem", I mean a bus type, a device > type or a device class as represented by struct bus_type, struct device_type > and struct clas

Re: [PATCH v2] PM / Sleep: Add pm_generic functions to re-use runtime PM callbacks

2013-11-27 Thread Ulf Hansson
On 27 November 2013 17:05, Ulf Hansson wrote: >> >> We first need to clarify the terminology as that seems to be the source of >> the confusion to some extent at least. >> >> When I (or Alan presumably too) say "a subsystem", I mean a bus type, a >> device >> type or a device class as represented

RE: Xhci Host not allowed to send get device desc at addr zero

2013-11-27 Thread Aymen BOUATTAY
Hi Pratyush, Douglas Turner pointed me to this thread discussion http://www.spinics.net/lists/linux-usb/msg95103.html seems there is some issue to use new scheme enumeration with super speed devices Hi Sarah, Any comments will be appreciated Thanks, Aymen -Original Message- From: Pra

Re: huawei E5776 (hilink) 3.12-->3.13 not working anymore

2013-11-27 Thread Lars Melin
On 2013-11-27 04:22, Thomas Schäfer wrote: Hi, I have it already mentioned somewhere. Sorry for duplicates. The Huawei E5776 (normal use, classic IPv4, hilink mode (with webinterface and RFC1918 IP- config including NAT) worked well with 3.12 and before, but it doesn't work any more with 3.13.

Re: zte_ev not properly handling ZTE AC2726 CDMA modems

2013-11-27 Thread Johan Hovold
On Tue, Nov 26, 2013 at 02:45:06PM -0800, Dmitry Kunilov wrote: > >> -Original Message- > >> From: Johan Hovold [mailto:jhov...@gmail.com] > >> Sent: Tuesday, November 26, 2013 6:39 AM > >> To: Dmitry Kunilov > >> Cc: linux-usb@vger.kernel.org > >> Subject: Re: zte_ev not properly handling

Re: BUG: usb: obex in g_nokia.ko causing kernel panic

2013-11-27 Thread Pali Rohár
On Tuesday 26 November 2013 20:03:11 Felipe Balbi wrote: > Hi, > > On Tue, Nov 26, 2013 at 12:59:13PM -0600, Felipe Balbi wrote: > > > > diff --git a/drivers/usb/gadget/f_obex.c > > > > b/drivers/usb/gadget/f_obex.c index ad39f1d..4af2f06 > > > > 100644 --- a/drivers/usb/gadget/f_obex.c > > > > ++

Re: zte_ev not properly handling ZTE AC2726 CDMA modems

2013-11-27 Thread Alan Stern
On Wed, 27 Nov 2013, Johan Hovold wrote: > > I am attaching the output that I am getting in the syslog. Note that I have > > two usb modems connected to that router and that's how I am able to debug > > it. > > 2-1 is an external USB2.0 hub, 2-1.2 is the ZTE modem, and 2-1.1 is a Huawei > > CDMA m

Re: [PATCH v3 1/9] phy: add phy_get_bus_width()/phy_set_bus_width() calls

2013-11-27 Thread Matt Porter
On Tue, Nov 26, 2013 at 03:46:26PM +0530, Kishon Vijay Abraham I wrote: > Hi, > > On Monday 25 November 2013 11:45 PM, Matt Porter wrote: > > This adds a pair of APIs that allows the generic PHY subsystem to > > provide information on the PHY bus width. The PHY provider driver may > > use phy_set_

Re: [PATCH v3 2/9] staging: dwc2: update DT binding to add generic clock/phy properties

2013-11-27 Thread Matt Porter
On Tue, Nov 26, 2013 at 03:49:30PM +0530, Kishon Vijay Abraham I wrote: > On Monday 25 November 2013 11:46 PM, Matt Porter wrote: > > dwc2/s3c-hsotg require a single clock to be specified and optionally > > a generic phy. On the s3c-hsotg driver old style USB phy support is > > present as a fallbac

Re: [PATCH v3 5/9] usb: gadget: s3c-hsotg: use generic phy_init()/phy_exit() support

2013-11-27 Thread Matt Porter
On Tue, Nov 26, 2013 at 03:53:32PM +0530, Kishon Vijay Abraham I wrote: > Hi, > > On Monday 25 November 2013 11:46 PM, Matt Porter wrote: > > If a generic phy is present, call phy_init()/phy_exit(). This supports > > generic phys that must be soft reset before power on. > > > > Signed-off-by: Mat

Re: [PATCH v3 6/9] usb: gadget: s3c-hsotg: get phy bus width from phy subsystem

2013-11-27 Thread Matt Porter
On Tue, Nov 26, 2013 at 03:58:45PM +0530, Kishon Vijay Abraham I wrote: > Hi, > > On Monday 25 November 2013 11:46 PM, Matt Porter wrote: > > Adds support for querying the phy bus width from the generic phy > > subsystem. Configure UTMI bus width in GUSBCFG based on this value. > > > > Signed-off

Re: [PATCH v3 7/9] phy: add Broadcom Kona USB2 PHY DT binding

2013-11-27 Thread Matt Porter
On Tue, Nov 26, 2013 at 04:01:05PM +0530, Kishon Vijay Abraham I wrote: > Hi, > > On Monday 25 November 2013 11:46 PM, Matt Porter wrote: > > Add a binding that describes the Broadcom Kona USB2 PHY found > > on the BCM281xx family of SoCs. > > > > Signed-off-by: Matt Porter > > --- > > .../devi

Re: [PATCH v3 8/9] phy: add Broadcom Kona USB2 PHY driver

2013-11-27 Thread Matt Porter
On Wed, Nov 27, 2013 at 02:21:52PM +0530, Kishon Vijay Abraham I wrote: > Hi, > > On Monday 25 November 2013 11:46 PM, Matt Porter wrote: > > Add a driver for the internal Broadcom Kona USB 2.0 PHY found > > on the BCM281xx family of SoCs. > > > > Signed-off-by: Matt Porter > > --- > > drivers/

Re: [RFC PATCH] usb: gadget/uvc: add streaming and data event handling

2013-11-27 Thread Laurent Pinchart
Hi Michal, Thank you for the patch, and sorry for the late reply. On Friday 06 September 2013 00:18:54 Michael Grzeschik wrote: > This patch lets the kernel handle setup and data events of > the uvc gadget. It is generating its response data by the > prepared usb uvc control descriptores. > > Fo

Re: [PATCH v3 9/9] ARM: dts: add usb udc support to bcm281xx

2013-11-27 Thread Matt Porter
On Wed, Nov 27, 2013 at 02:27:19PM +0530, Kishon Vijay Abraham I wrote: > Hi, > > On Monday 25 November 2013 11:46 PM, Matt Porter wrote: > > Adds USB OTG/PHY and clock support to BCM281xx and enables > > UDC support on the bcm11351-brt and bcm28155-ap boards. > > > > Signed-off-by: Matt Porter

Re: BUG: usb: obex in g_nokia.ko causing kernel panic

2013-11-27 Thread Felipe Balbi
Hi, On Wed, Nov 27, 2013 at 05:40:42PM +0100, Pali Rohár wrote: > > > > > @@ -282,10 +284,12 @@ static void obex_disconnect(struct > > > > > gserial *g) if (!obex->can_activate) > > > > > > > > > > return; > > > > > > > > > > +#if 0 > > > > > > > > > > status = usb_function_

Re: [PATCH 1/3] usb: dwc3: Add Keystone specific glue layer

2013-11-27 Thread Felipe Balbi
Hi, On Wed, Nov 27, 2013 at 02:49:54PM +0530, George Cherian wrote: > >+error = of_platform_populate(node, NULL, NULL, dev); > >+if (error) { > >+dev_err(&pdev->dev, "failed to create dwc3 core\n"); > >+goto err_core; > >+} > >+ > >+return 0; > >+ > >+err_co

Re: [REWORKED PATCH 1/5] usb: phy: fsm: don't depend on indirect includes

2013-11-27 Thread Felipe Balbi
On Wed, Nov 27, 2013 at 11:14:56AM +0900, Anton Tikhomirov wrote: > Hi Felipe, > > > Hi, > > > > On Tue, Nov 26, 2013 at 10:33:44AM -0600, Felipe Balbi wrote: > > > this header uses spinlocks and errno values, so > > > we must include and > > > to avoid build errors. > > > > > > Signed-off-by:

Re: [PATCH] usb: s3c-hsotg: change dependency to PLAT_SAMSUNG

2013-11-27 Thread Felipe Balbi
On Wed, Nov 27, 2013 at 02:03:22PM +0100, Marek Szyprowski wrote: > On device tree based Samsung SoC platforms (like Exynos) no platform > devices are defined and CONFIG_S3C_DEV_USB_HSOTG is no longer available, > so change the driver dependency to more generic and appropriate > CONFIG_PLAT_SAMSUNG

Re: [PATCH v2 4/4] usb/gadget: f_sourcesink: add configfs support

2013-11-27 Thread Felipe Balbi
Hi, On Wed, Nov 27, 2013 at 08:38:25AM +0100, Andrzej Pietrasiewicz wrote: > W dniu 26.11.2013 20:51, Felipe Balbi pisze: > >On Thu, Nov 07, 2013 at 08:41:28AM +0100, Andrzej Pietrasiewicz wrote: > >>Add support for using the sourcesink function in gadgets composed with > >>configfs. > >> > >>Sign

Re: [RESEND GIT PULL v2] USB fixes for v3.13-rc2

2013-11-27 Thread Greg KH
On Mon, Nov 25, 2013 at 01:36:51PM -0600, Felipe Balbi wrote: > Hi Greg, > > Here's my first set of fixes for this -rc cycle. Please > consider merging them on your usb-linus branch. > > Let me know if you need any changes to this pull request. I > did a test merge of this tag with your usb-linus

Re: [PATCH 1/3] usb: dwc3: Add Keystone specific glue layer

2013-11-27 Thread Santosh Shilimkar
On Wednesday 27 November 2013 12:41 PM, Felipe Balbi wrote: > Hi, > > On Wed, Nov 27, 2013 at 02:49:54PM +0530, George Cherian wrote: >>> + error = of_platform_populate(node, NULL, NULL, dev); >>> + if (error) { >>> + dev_err(&pdev->dev, "failed to create dwc3 core\n"); >>> +

Re: possible xhci regression: usb 3.0 hdd disconnects immediately

2013-11-27 Thread b3nmore
On 11/25/2013 03:37 PM, b3nmore wrote: > Hi, > > I can't get my external usb 3.0 hdd to work on usb 3.0 ports with > kernels 3.11, 3.12.0, 3.13-rc1, it only works on usb 2 ports. dmesg > shows, that it disconnects immediately after it is plugged in. Then it > continues to connect and disconnect in

Re: [PATCH 1/3] usb: dwc3: Add Keystone specific glue layer

2013-11-27 Thread Felipe Balbi
On Wed, Nov 27, 2013 at 01:32:04PM -0500, Santosh Shilimkar wrote: > On Wednesday 27 November 2013 12:41 PM, Felipe Balbi wrote: > > Hi, > > > > On Wed, Nov 27, 2013 at 02:49:54PM +0530, George Cherian wrote: > >>> + error = of_platform_populate(node, NULL, NULL, dev); > >>> + if (error) { > >>> +

Re: huawei E5776 (hilink) 3.12-->3.13 not working anymore

2013-11-27 Thread Thomas Schäfer
> Am 27.11.2013 13:33, schrieb Bjørn Mork: > > How about looking at usbmon differences? That should show us where > > things start to go wrong. Here are the two cases 3.12 with a short connection dhcp and ping 3.13 with failing dhcp I hope I caught the right bus. Because of the size of fil

Re: [PATCH 2/3] ARM: dts: keystone: Add usb devicetree bindings

2013-11-27 Thread Santosh Shilimkar
On Wednesday 27 November 2013 04:59 AM, George Cherian wrote: > On 11/26/2013 1:46 AM, WingMan Kwok wrote: >> Added device tree support for TI's Keystone USB driver and updated the >> Documentation with device tree binding information. >> >> On Keystone II platforms, we use no-op phy driver. >> >>

Advice on usb-next pull

2013-11-27 Thread Sarah Sharp
Hi Greg, I've got a potential pull request to send you for usb-next, but I wanted to get your advice on it first. It contains a series of patches from Xenia to remove the xhci_readl/writel variants in order to just replace them with standard readl and writel calls. Normally I would queue these f

Re: [PATCH v5 06/17] clk: at91: add PMC pll clocks

2013-11-27 Thread Mike Turquette
Quoting Boris BREZILLON (2013-11-12 13:57:19) > +static const struct clk_ops pll_ops = { > + .prepare = clk_pll_prepare, > + .is_prepared = clk_pll_is_ready, > + .disable = clk_pll_disable, > + .is_enabled = clk_pll_is_ready, > + .recalc_rate = clk_pll_recalc_rate, > +

Re: Advice on usb-next pull

2013-11-27 Thread Greg KH
On Wed, Nov 27, 2013 at 01:42:40PM -0800, Sarah Sharp wrote: > Hi Greg, > > I've got a potential pull request to send you for usb-next, but I wanted > to get your advice on it first. It contains a series of patches from > Xenia to remove the xhci_readl/writel variants in order to just replace > t

Re: Advice on usb-next pull

2013-11-27 Thread Sarah Sharp
On Wed, Nov 27, 2013 at 01:51:05PM -0800, Greg KH wrote: > On Wed, Nov 27, 2013 at 01:42:40PM -0800, Sarah Sharp wrote: > > Hi Greg, > > > > I've got a potential pull request to send you for usb-next, but I wanted > > to get your advice on it first. It contains a series of patches from > > Xenia

Re: 3.12.1 Virt dev invalid for slot_id 0x1 from drivers/usb/host/xhci.c

2013-11-27 Thread Sarah Sharp
On Mon, Nov 25, 2013 at 11:41:47AM -0700, Shuah Khan wrote: > I started seeing the following on my Samsung Series on 3.12.1 > > Is this bad? Looks like the following WARN_ON is firing: > > drivers/usb/host/xhci.c: > > if (WARN_ON(!virt_dev)) { > /* > * In

VIA chipset not supported by xhci drivers?

2013-11-27 Thread Philip Prindeville
I wasn’t able to get the 7-port Orico controller working, so I swapped it out for a 4-port (single chip) Anker instead. $ sudo lspci -v -s 03:00.0 03:00.0 USB controller: VIA Technologies, Inc. VL80x xHCI USB 3.0 Controller (rev 03) (prog-if 30 [XHCI]) Subsystem: VIA Technologies, Inc. V

Re: [PATCH v5 08/17] clk: at91: add PMC system clocks

2013-11-27 Thread Mike Turquette
Quoting Boris BREZILLON (2013-11-12 14:05:35) > This patch adds new at91 system clock implementation using common clk > framework. > > Some peripherals need to enable a "system" clock in order to work properly. > Each system clock is given an id based on the bit position in SCER/SCDR > registers.

Re: [PATCH v3 5/9] usb: gadget: s3c-hsotg: use generic phy_init()/phy_exit() support

2013-11-27 Thread Matt Porter
On Wed, Nov 27, 2013 at 12:13:25PM -0500, Matt Porter wrote: > On Tue, Nov 26, 2013 at 03:53:32PM +0530, Kishon Vijay Abraham I wrote: > > Hi, > > > > On Monday 25 November 2013 11:46 PM, Matt Porter wrote: > > > If a generic phy is present, call phy_init()/phy_exit(). This supports > > > generic

[PATCH 4/5] xhci: fix sparse warning in xhci-trace.h

2013-11-27 Thread Sarah Sharp
From: Xenia Ragiadakou This patch fixes the following sparse warnings: drivers/usb/host/./xhci-trace.h:116:1: warning: cast to restricted __le32 drivers/usb/host/./xhci-trace.h:116:1: warning: cast to restricted __le32 drivers/usb/host/./xhci-trace.h:116:1: warning: restricted __le32 degrades to

[PATCH 1/5] xhci: convert TRB_CYCLE to le32 before using it to set Link TRB's cycle bit

2013-11-27 Thread Sarah Sharp
From: Xenia Ragiadakou This patch converts TRB_CYCLE to le32 to update correctly the Cycle Bit in 'control' field of the link TRB. This bug was found using sparse. This patch should be backported to kernels as old as 3.4, that contain the commit 186a7ef13a8fa3bc7cca1ccd33bd469b931e46de "xHCI: se

[PATCH 5/5] xhci: fix incorrect type in assignment in xhci_address_device()

2013-11-27 Thread Sarah Sharp
From: Xenia Ragiadakou The field 'dev_info' in struct xhci_slot_ctx has type __le32 and it needs to be converted to CPU byteorder for the correct retrieval of its subfield 'Context Entries'. This field is used by the trace event 'xhci_address_ctx' to trace only the contexts of valid endpoints. Th

[PATCH 3/5] xhci: fix derivation of TRB's DMA address in xhci_log_event Trace Event Class

2013-11-27 Thread Sarah Sharp
From: Xenia Ragiadakou This patch fixes the retrieval of the DMA address of the TRB that generated the event by converting the field[0] (low address bits) and field[1] (high address bits) to CPU byteorder and then typecasting field[1] to u64 so that the bitshift will not lead to overflow. In the

[GIT PULL] xhci: Big-endian sparse fixes.

2013-11-27 Thread Sarah Sharp
The following changes since commit 7d49f0bac41ee9b012af1efe2f725d91a87a8fe9: USB: Maintainers change for usb serial drivers (2013-10-31 08:53:52 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/sarah/xhci.git tags/for-usb-linus-2013-11-27 for you

[PATCH 2/5] xhci: fix incorrect type in assignment in handle_device_notification()

2013-11-27 Thread Sarah Sharp
From: Xenia Ragiadakou This patch converts Event TRB's 3rd field, which has type le32, to CPU byteorder before using it to retrieve the Slot ID with TRB_TO_SLOT_ID macro. This bug was found using sparse. This patch should be backported to kernels as old as 3.4, that contain the commit 623bef9e03

[PATCH 01/10] xhci: replace USB_MAXINTERFACES with config->desc.bNumInterface

2013-11-27 Thread Sarah Sharp
From: Xenia Ragiadakou This patch replaces USB_MAXINTERFACES with config->desc.bNumInterface in the termination condition for the loop that updates the LPM timeout of the endpoints on the cofiguration's interfaces, in xhci_calculate_lpm_timeout(), to avoid unnecessary loop cycles since most confi

[PATCH 09/10] xhci: replace xhci_read_64() with readq()

2013-11-27 Thread Sarah Sharp
From: Xenia Ragiadakou Function xhci_read_64() is used to read 64bit xHC registers residing in MMIO. On 32bit systems, xHC registers need to be read with 32bit accesses by reading first the lower 32bits and then the higher 32bits. Replace all calls to xhci_read_64() with calls to readq() and inc

[PATCH 04/10] xhci: fix incorrect type in assignment in xhci_count_num_new_endpoints()

2013-11-27 Thread Sarah Sharp
From: Xenia Ragiadakou The fields 'add_flags' and 'drop_flags' in struct xhci_input_control_ctx have type __le32 and need to be converted to CPU byteorder before being used to derive the number of added endpoints. This bug was found using sparse. This patch is not suitable for stable, since the

[PATCH 10/10] xhci: replace xhci_write_64() with writeq()

2013-11-27 Thread Sarah Sharp
From: Xenia Ragiadakou Function xhci_write_64() is used to write 64bit xHC registers residing in MMIO. On 32bit systems, xHC registers need to be written with 32bit accesses by writing first the lower 32bits and then the higher 32bits. The header file asm-generic/io-64-nonatomic-lo-hi.h ensures t

[PATCH 05/10] xhci: fix incorrect type in assignment in xhci_count_num_dropped_endpoints()

2013-11-27 Thread Sarah Sharp
From: Xenia Ragiadakou The fields 'add_flags' and 'drop_flags' in struct xhci_input_control_ctx have type __le32 and need to be converted to CPU byteorder before being used to derive the number of dropped endpoints. This bug was found using sparse. This patch is not suitable for stable, since th

[PATCH 08/10] xhci: replace xhci_writel() with writel()

2013-11-27 Thread Sarah Sharp
From: Xenia Ragiadakou Function xhci_writel() is used to write a 32bit value in xHC registers residing in MMIO address space. It takes as first argument a pointer to the xhci_hcd although it does not use it. xhci_writel() internally simply calls writel(). This creates an illusion that xhci_writel

[PATCH 03/10] xhci: remove unnecessary check in xhci_free_stream_info()

2013-11-27 Thread Sarah Sharp
From: Xenia Ragiadakou This patch removes the unneccessary check 'if (stream_info)' because there is already a check few lines above which ensures that stream_info is not NULL. Signed-off-by: Xenia Ragiadakou Signed-off-by: Sarah Sharp --- drivers/usb/host/xhci-mem.c | 3 +-- 1 file changed,

[PATCH 07/10] xhci: replace xhci_readl() with readl()

2013-11-27 Thread Sarah Sharp
From: Xenia Ragiadakou Function xhci_readl() is used to read 32bit xHC registers residing in MMIO address space. It takes as first argument a pointer to the xhci_hcd although it does not use it. xhci_readl() internally simply calls readl(). This creates an illusion that xhci_readl() is an xhci sp

[GIT PULL] xhci: Sparse fixes, replace xhci_read/write, misc

2013-11-27 Thread Sarah Sharp
The following changes since commit 172a894f74e090f3aada7b0347d334ad9db14a36: xhci: fix incorrect type in assignment in xhci_address_device() (2013-11-18 10:10:13 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/sarah/xhci.git tags/for-usb-next-20

[PATCH 02/10] xhci: fix SCT_FOR_CTX(p) macro

2013-11-27 Thread Sarah Sharp
From: Xenia Ragiadakou SCT_FOR_CTX(p) is defined as (((p) << 1) & 0x7) in which case if we want to set the stream context type to SCT_SSA_256 i.e 0x7 (although secondary stream arrays are not yet supported) using this macro definition we will get actually 0x6 which is not what we want. This patc

[PATCH 06/10] xhci: remove conversion from generic to pci device in xhci_mem.c

2013-11-27 Thread Sarah Sharp
From: Xenia Ragiadakou This patch removes the to_pci_dev() conversion performed to generic struct device since it is not actually useful (the pointer to the generic device can be used directly rather through a conversion to pci_dev) and it is pci bus specific. This isn't stable material because

Re: [GIT PULL] xhci: Big-endian sparse fixes.

2013-11-27 Thread Greg Kroah-Hartman
On Wed, Nov 27, 2013 at 03:14:40PM -0800, Sarah Sharp wrote: > The following changes since commit 7d49f0bac41ee9b012af1efe2f725d91a87a8fe9: > > USB: Maintainers change for usb serial drivers (2013-10-31 08:53:52 -0700) > > are available in the git repository at: > > git://git.kernel.org/pub/

Re: [GIT PULL] xhci: Big-endian sparse fixes.

2013-11-27 Thread Greg Kroah-Hartman
On Wed, Nov 27, 2013 at 03:36:02PM -0800, Greg Kroah-Hartman wrote: > On Wed, Nov 27, 2013 at 03:14:40PM -0800, Sarah Sharp wrote: > > The following changes since commit 7d49f0bac41ee9b012af1efe2f725d91a87a8fe9: > > > > USB: Maintainers change for usb serial drivers (2013-10-31 08:53:52 -0700) >

Re: [GIT PULL] xhci: Big-endian sparse fixes.

2013-11-27 Thread Sarah Sharp
On Wed, Nov 27, 2013 at 03:36:56PM -0800, Greg Kroah-Hartman wrote: > On Wed, Nov 27, 2013 at 03:36:02PM -0800, Greg Kroah-Hartman wrote: > > On Wed, Nov 27, 2013 at 03:14:40PM -0800, Sarah Sharp wrote: > > > The following changes since commit > > > 7d49f0bac41ee9b012af1efe2f725d91a87a8fe9: > > >

Re: 3.12.1 Virt dev invalid for slot_id 0x1 from drivers/usb/host/xhci.c

2013-11-27 Thread Shuah Khan
On 11/27/2013 02:59 PM, Sarah Sharp wrote: On Mon, Nov 25, 2013 at 11:41:47AM -0700, Shuah Khan wrote: I started seeing the following on my Samsung Series on 3.12.1 Is this bad? Looks like the following WARN_ON is firing: drivers/usb/host/xhci.c: if (WARN_ON(!virt_dev)) {

RE: [REWORKED PATCH 1/5] usb: phy: fsm: don't depend on indirect includes

2013-11-27 Thread Anton Tikhomirov
Hi, > On Wed, Nov 27, 2013 at 11:14:56AM +0900, Anton Tikhomirov wrote: > > Hi Felipe, > > > > > Hi, > > > > > > On Tue, Nov 26, 2013 at 10:33:44AM -0600, Felipe Balbi wrote: > > > > this header uses spinlocks and errno values, so > > > > we must include and > > > > to avoid build errors. > > >

[PATCH 1/3] usb: gadget: goku_udc: use DEFINE_PCI_DEVICE_TABLE macro

2013-11-27 Thread Jingoo Han
This macro is used to create a struct pci_device_id array. Signed-off-by: Jingoo Han --- drivers/usb/gadget/goku_udc.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/goku_udc.c b/drivers/usb/gadget/goku_udc.c index f827680..120ba8a 100644 --- a/drivers/

[PATCH 2/3] usb: gadget: net2272: use DEFINE_PCI_DEVICE_TABLE macro

2013-11-27 Thread Jingoo Han
This macro is used to create a struct pci_device_id array. Signed-off-by: Jingoo Han --- drivers/usb/gadget/net2272.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/net2272.c b/drivers/usb/gadget/net2272.c index bf2bb39..10442aa 100644 --- a/drivers/usb

[PATCH 3/3] usb: gadget: net2280: use DEFINE_PCI_DEVICE_TABLE macro

2013-11-27 Thread Jingoo Han
This macro is used to create a struct pci_device_id array. Signed-off-by: Jingoo Han --- drivers/usb/gadget/net2280.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/net2280.c b/drivers/usb/gadget/net2280.c index fc85217..e267a5a 100644 --- a/drivers/usb

[PATCH 1/5] USB: EHCI: use DEFINE_PCI_DEVICE_TABLE macro

2013-11-27 Thread Jingoo Han
This macro is used to create a struct pci_device_id array. Signed-off-by: Jingoo Han --- drivers/usb/host/ehci-pci.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/ehci-pci.c b/drivers/usb/host/ehci-pci.c index 3e86bf4..5b30f59 100644 --- a/drivers/usb/ho

[PATCH 2/5] USB: OHCI: use DEFINE_PCI_DEVICE_TABLE macro

2013-11-27 Thread Jingoo Han
This macro is used to create a struct pci_device_id array. Signed-off-by: Jingoo Han --- drivers/usb/host/ohci-pci.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/ohci-pci.c b/drivers/usb/host/ohci-pci.c index 90879e9..762e20a 100644 --- a/drivers/us

[PATCH 3/5] USB: xHCI: use DEFINE_PCI_DEVICE_TABLE macro

2013-11-27 Thread Jingoo Han
This macro is used to create a struct pci_device_id array. Signed-off-by: Jingoo Han --- drivers/usb/host/xhci-pci.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c index b8dffd5..3f75a32 100644 --- a/drivers/usb/ho

[PATCH 4/5] USB: whci-hcd: use DEFINE_PCI_DEVICE_TABLE macro

2013-11-27 Thread Jingoo Han
This macro is used to create a struct pci_device_id array. Signed-off-by: Jingoo Han --- drivers/usb/host/whci/hcd.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/whci/hcd.c b/drivers/usb/host/whci/hcd.c index 1b0888f..1192f6a 100644 --- a/drivers/usb/ho

[PATCH 5/5] USB: isp1760: use DEFINE_PCI_DEVICE_TABLE macro

2013-11-27 Thread Jingoo Han
This macro is used to create a struct pci_device_id array. Signed-off-by: Jingoo Han --- drivers/usb/host/isp1760-if.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/isp1760-if.c b/drivers/usb/host/isp1760-if.c index df931e9..7771861 100644 --- a/drivers/

Re: [PATCH v2 2/2] usb: chipidea: usbmisc: Add support for i.MX51 CPU

2013-11-27 Thread Shawn Guo
On Tue, Nov 26, 2013 at 07:36:50PM +0400, Alexander Shiyan wrote: > This adds i.MX51 as the next user of the usbmisc driver. > Functionality is similar to i.MX53, so at this stage simply > reuse existing i.MX53 calls. > > Signed-off-by: Alexander Shiyan > --- > drivers/usb/chipidea/usbmisc_imx.c

[PATCH -next] staging: dwc2: fix sparse non static symbol warning

2013-11-27 Thread Wei Yongjun
From: Wei Yongjun Fixes the following sparse warning: drivers/staging/dwc2/core.c:2672:6: warning: symbol 'dwc2_set_param_uframe_sched' was not declared. Should it be static? Signed-off-by: Wei Yongjun --- drivers/staging/dwc2/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) dif

Re: [PATCH 1/3] usb: gadget: goku_udc: use DEFINE_PCI_DEVICE_TABLE macro

2013-11-27 Thread Greg KH
On Thu, Nov 28, 2013 at 11:02:26AM +0900, Jingoo Han wrote: > This macro is used to create a struct pci_device_id array. And it shouldn't be used, please don't. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org M

Re: 答复: Re: 【PATCH】USB:add new zte 3g-modem's pid to option.c

2013-11-27 Thread Greg KH
On Thu, Nov 28, 2013 at 10:46:51AM +0800, zhang.ju...@zte.com.cn wrote: > > Signed-off-by: Jun zhang You failed to answer my question from before, why? > --- drivers/usb/serial/option.c2013-11-21 04:37:52.0 +0800 > +++ option_bac.c2013-11-28 14:13:54.480576688 +0800 I n

Re: musb: bluk_split only worked for the first segment(PIO only)

2013-11-27 Thread Yingchun Li
> It is by hardware, but in some platforms, for example TI AM335x, these > features are not supported even though the register bits are set. It's a weird registers, so I think it should do a special musb_read_configdata and return the right register value. Then the musb_core_init will do the right

Re: [PATCH 1/3] usb: gadget: goku_udc: use DEFINE_PCI_DEVICE_TABLE macro

2013-11-27 Thread Jingoo Han
On Thursday, November 28, 2013 11:02 AM, Jingoo Han wrote: > > This macro is used to create a struct pci_device_id array. > > Signed-off-by: Jingoo Han Please, ignore these patches. As Greg Kroah-Hartman said, I will send the patch to remove 'DEFINE_PCI_DEVICE_TABLE' instead. Sorry for annoyin

[PATCH 1/5] USB: UHCI: remove DEFINE_PCI_DEVICE_TABLE macro

2013-11-27 Thread Jingoo Han
Don't use DEFINE_PCI_DEVICE_TABLE macro, because this macro is not preferred. Signed-off-by: Jingoo Han --- drivers/usb/host/uhci-pci.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/uhci-pci.c b/drivers/usb/host/uhci-pci.c index 4cd7988..940304c 100644 -

[PATCH 3/5] usb: dwc3: pci: remove DEFINE_PCI_DEVICE_TABLE macro

2013-11-27 Thread Jingoo Han
Don't use DEFINE_PCI_DEVICE_TABLE macro, because this macro is not preferred. Signed-off-by: Jingoo Han --- drivers/usb/dwc3/dwc3-pci.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/dwc3/dwc3-pci.c b/drivers/usb/dwc3/dwc3-pci.c index 31443ae..665686e 100644 -

[PATCH 2/5] usb: chipidea: remove DEFINE_PCI_DEVICE_TABLE macro

2013-11-27 Thread Jingoo Han
Don't use DEFINE_PCI_DEVICE_TABLE macro, because this macro is not preferred. Signed-off-by: Jingoo Han --- drivers/usb/chipidea/ci_hdrc_pci.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/chipidea/ci_hdrc_pci.c b/drivers/usb/chipidea/ci_hdrc_pci.c index d51

[PATCH 4/5] usb: gadget: pch_udc: remove DEFINE_PCI_DEVICE_TABLE macro

2013-11-27 Thread Jingoo Han
Don't use DEFINE_PCI_DEVICE_TABLE macro, because this macro is not preferred. Signed-off-by: Jingoo Han --- drivers/usb/gadget/pch_udc.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/pch_udc.c b/drivers/usb/gadget/pch_udc.c index 32d5e92..78a3d92 10064

[PATCH 5/5] usb: gadget: amd5536udc: remove DEFINE_PCI_DEVICE_TABLE macro

2013-11-27 Thread Jingoo Han
Don't use DEFINE_PCI_DEVICE_TABLE macro, because this macro is not preferred. Signed-off-by: Jingoo Han --- drivers/usb/gadget/amd5536udc.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/amd5536udc.c b/drivers/usb/gadget/amd5536udc.c index 54a1e29..f0ff

Re: Need help to support USB3.0 HID Keyboard device

2013-11-27 Thread Bhavik Kothari
On Tuesday 26 November 2013 09:40 PM, Greg KH wrote: On Tue, Nov 26, 2013 at 03:26:04PM +0530, Bhavik Kothari wrote: On Friday 22 November 2013 10:25 PM, Greg KH wrote: On Fri, Nov 22, 2013 at 04:47:10PM +0530, Bhavik Kothari wrote: Hi, I have been working on USB3.0 device driver and wanted t

Re: [PATCH v3 5/9] usb: gadget: s3c-hsotg: use generic phy_init()/phy_exit() support

2013-11-27 Thread Kishon Vijay Abraham I
On Thursday 28 November 2013 04:06 AM, Matt Porter wrote: > On Wed, Nov 27, 2013 at 12:13:25PM -0500, Matt Porter wrote: >> On Tue, Nov 26, 2013 at 03:53:32PM +0530, Kishon Vijay Abraham I wrote: >>> Hi, >>> >>> On Monday 25 November 2013 11:46 PM, Matt Porter wrote: If a generic phy is presen

Re: VIA chipset not supported by xhci drivers?

2013-11-27 Thread Greg KH
On Wed, Nov 27, 2013 at 03:00:40PM -0700, Philip Prindeville wrote: > I wasn’t able to get the 7-port Orico controller working, so I swapped > it out for a 4-port (single chip) Anker instead. > > $ sudo lspci -v -s 03:00.0 > 03:00.0 USB controller: VIA Technologies, Inc. VL80x xHCI USB 3.0 Control

Re: [PATCH v2 2/2] usb: chipidea: usbmisc: Add support for i.MX51 CPU

2013-11-27 Thread Alexander Shiyan
Hello. > On Tue, Nov 26, 2013 at 07:36:50PM +0400, Alexander Shiyan wrote: > > This adds i.MX51 as the next user of the usbmisc driver. > > Functionality is similar to i.MX53, so at this stage simply > > reuse existing i.MX53 calls. > > > > Signed-off-by: Alexander Shiyan > > --- > > drivers/us

[PATCH 7/8] usb/gadget: f_uvc: use usb_gstrings_attach

2013-11-27 Thread Andrzej Pietrasiewicz
Attach strings to gadget with usb_strings_attach. Signed-off-by: Andrzej Pietrasiewicz Signed-off-by: Kyungmin Park --- drivers/usb/gadget/f_uvc.c | 29 - 1 files changed, 12 insertions(+), 17 deletions(-) diff --git a/drivers/usb/gadget/f_uvc.c b/drivers/usb/gadg

[PATCH 1/8] usb/gadget: uvc: move descriptors to their only user

2013-11-27 Thread Andrzej Pietrasiewicz
A bunch of descriptors is defined in webcam.c. They are used only by f_uvc. Move them to their only user. Signed-off-by: Andrzej Pietrasiewicz Signed-off-by: Kyungmin Park --- drivers/usb/gadget/f_uvc.c | 271 +++ drivers/usb/gadget/f_uvc.h |7 +-

[PATCH 3/8] usb/gadget: uvc: separately compile some components of f_uvc

2013-11-27 Thread Andrzej Pietrasiewicz
Compile uvc_queue, uvc_v4l2, uvc_video separately so that later they can be all combined in a separately compiled f_uvc. Signed-off-by: Andrzej Pietrasiewicz Signed-off-by: Kyungmin Park --- drivers/usb/gadget/Makefile|2 +- drivers/usb/gadget/f_uvc.c |2 + drivers/usb/gadget/f_

[PATCH 8/8] usb/gadget: f_uvc: add configfs support

2013-11-27 Thread Andrzej Pietrasiewicz
Add support for using uvc as a component of a composite gadget set up with configfs. Signed-off-by: Andrzej Pietrasiewicz Signed-off-by: Kyungmin Park --- Documentation/ABI/testing/configfs-usb-gadget-uvc | 11 + drivers/usb/gadget/Kconfig| 12 + drivers/usb/gadget/f

[PATCH 5/8] usb/gadget: webcam: convert webcam to new interface of f_uvc

2013-11-27 Thread Andrzej Pietrasiewicz
Use the new function interface of f_uvc. Signed-off-by: Andrzej Pietrasiewicz Signed-off-by: Kyungmin Park --- drivers/usb/gadget/Kconfig |1 + drivers/usb/gadget/Makefile |4 +- drivers/usb/gadget/f_uvc.c |4 --- drivers/usb/gadget/webcam.c | 46 +---

[PATCH 6/8] usb/gadget: f_uvc: remove compatibility layer

2013-11-27 Thread Andrzej Pietrasiewicz
There are no users of the old interface left. Remove it. Signed-off-by: Andrzej Pietrasiewicz Signed-off-by: Kyungmin Park --- drivers/usb/gadget/f_uvc.c | 129 1 files changed, 0 insertions(+), 129 deletions(-) diff --git a/drivers/usb/gadget/f_uv

[PATCH 4/8] usb/gadget: f_uvc: convert f_uvc to new function interface

2013-11-27 Thread Andrzej Pietrasiewicz
Use the new function registration interface. It is required in order to integrate configfs support. Signed-off-by: Andrzej Pietrasiewicz Signed-off-by: Kyungmin Park --- drivers/usb/gadget/Kconfig |3 + drivers/usb/gadget/Makefile |2 + drivers/usb/gadget/f_uvc.c | 270 ++

[PATCH 2/8] usb/gadget: uvc: move module parameters from f_uvc

2013-11-27 Thread Andrzej Pietrasiewicz
When configfs support is integrated the future uvc function module must not take any parameters. Move parameters to webcam. Signed-off-by: Andrzej Pietrasiewicz Signed-off-by: Kyungmin Park --- drivers/usb/gadget/f_uvc.c | 27 +-- drivers/usb/gadget/f_uvc.h |6 ++

[PATCH 0/8] Equivalent of g_webcam with configfs

2013-11-27 Thread Andrzej Pietrasiewicz
This series aims at integrating configfs into uvc, the way it has been done for acm, ncm, ecm, eem, ecm subset, rndis, obex, phonet, mass_storage, FunctionFS, loopback and sourcesink. It contains everything that is required to provide the equivalent of g_webcam.ko with configfs. Rebased onto Felip

  1   2   >