On Fri, Nov 22, 2013 at 04:43:44PM -0800, Paul Zimmerman wrote:
> This is a series of cleanups to the DWC2 driver, in response to Dan
> Carpenter's review on 11/15/2013. I believe I have addressed all of
> Dan's suggestions, except for removing the validation checks from
> the dwc2_set_param_* func
usb phy was power'ed on but was never power'ed off in the error path.
Fix it.
Signed-off-by: Kishon Vijay Abraham I
---
drivers/usb/dwc3/core.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
index 4dd1f7e..a49217a 100644
--- a/drivers/u
Modified dwc3 core to find PHYs only if the platform indicates that it has
to use a PHY (using quirks). Adapted DWC3 and USB3 PHY to use Generic PHY
framework. Also changed the name of USB3 PHY driver to PIPE3 PHY driver
since the same driver has to be used for SATA and PCIE too.
Changes from v2
No functional change. Moved omap_usb.h from linux/usb/ to linux/phy/.
Also removed the unused members of struct omap_usb (after phy-omap-pipe3
started using it's own header file)
Signed-off-by: Kishon Vijay Abraham I
---
drivers/phy/phy-omap-usb2.c |2 +-
include/linux/{usb => phy}
Added device tree bindings for dwc3, usb2 and usb3 PHYs. The documentation
of these can be found at Documentation/devicetree/bindings/phy/phy-bindings.txt
and Documentation/devicetree/bindings/phy/ti-phy.txt.
Signed-off-by: Kishon Vijay Abraham I
---
arch/arm/boot/dts/omap5.dtsi |4
1 f
Since now we have a separate folder for phy, move the PHY dt binding
documentation of TI to that folder.
Signed-off-by: Kishon Vijay Abraham I
---
.../devicetree/bindings/{usb/usb-phy.txt => phy/ti-phy.txt}|8
1 file changed, 4 insertions(+), 4 deletions(-)
rename Documentation
Now that omap-usb2 is adapted to the new generic PHY framework,
*set_suspend* ops can be removed from omap-usb2 driver.
Signed-off-by: Kishon Vijay Abraham I
Acked-by: Felipe Balbi
Reviewed-by: Sylwester Nawrocki
---
drivers/phy/phy-omap-usb2.c | 25 -
1 file changed,
There can be systems which does not have an external phy, so get
phy only if no quirks are added that indicates the PHY is not present.
Introduced two quirk flags to indicate the *absence* of usb2 phy and
usb3 phy. Also remove checking if return value is -ENXIO since it's now
changed to always enab
> From: Alan Stern
> On Mon, 25 Nov 2013, Xenia Ragiadakou wrote:
>
> > > You can simplify part of the problem by not allowing an endpoint to be
> > > reset if it has any pending URBs. Just fail the reset in this case.
> >
> > Yes, you are right since, from what i understand, it is the
> > respon
Adapted dwc3 core to use the Generic PHY Framework. So for init, exit,
power_on and power_off the following APIs are used phy_init(), phy_exit(),
phy_power_on() and phy_power_off().
However using the old USB phy library wont be removed till the PHYs of all
other SoC's using dwc3 core is adapted to
Invoke usb_phy api's only if usb_phy does not have error value. This is
needed for both the legacy usb_phy and generic phy to co-exist in dwc3 core.
Signed-off-by: Kishon Vijay Abraham I
---
drivers/usb/dwc3/core.c | 42 --
1 file changed, 28 insertions(
Adapted omap-usb3 PHY driver to Generic PHY Framework and moved phy-omap-usb3
driver in drivers/usb/phy to drivers/phy and also renamed the file to
phy-ti-pipe3 since this same driver will be used for SATA PHY and
PCIE PHY.
Signed-off-by: Kishon Vijay Abraham I
---
drivers/phy/Kconfig
usb_phy_set_suspend(phy, 0) is called before usb_phy_init. Fix it.
Reported-by: Roger Quadros
Signed-off-by: Kishon Vijay Abraham I
---
drivers/usb/dwc3/core.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
index 74
On Fri, 2013-11-22 at 12:18 -0800, Dan Williams wrote:
> On Fri, Nov 22, 2013 at 2:39 AM, Oliver Neukum wrote:
> > On Fri, 2013-11-22 at 01:07 -0800, Dan Williams wrote:
> >> Move all port power policy evaluation to usb_port_runtime_suspend().
> >> Makes it clearer what blocks port power off and i
To put devices into low power state during sleep, it sometimes makes
sense at subsystem-level to re-use device's runtime PM callbacks.
The PM core will at device_suspend_late disable runtime PM, after that
we can safely operate on these callbacks. At suspend_late the device
will be put into low po
Hi Marek, Peter,
On Mon, Nov 25, 2013 at 12:58:32AM +0100, Marek Vasut wrote:
> Hello Michael,
>
> > Hi Marek, Peter,
> >
> > On Sat, Aug 25, 2012 at 01:51:38AM +0200, Marek Vasut wrote:
> > > Add the pinmux settings for USB PHY overcurrent pins.
> > >
> > > Signed-off-by: Marek Vasut
> > > Cc
Beagle (rev. C4) and Beagle-XM (all revs) need VAUX2 1.8V supply
for the USB PHY.
As the generic PHY driver can't handle more than one supply
at the moment, we configure this supply to be always on.
This will cause a very small power impact if the USB host subsystem
is not in use, about 76.86 micr
Hi all,
With runtime pm enabled udc driver, we may put controller to low
power mode when vbus is off or with SRP request. But gadget driver
may not know the udc status when it calls usb_ep_ops and usb_gadget_ops.
I meet this problem when I plug out usb cable from PC (using g_mass_storage),
my cal
I've made the success and error paths clearer and pulled some code in
one indent level.
Signed-off-by: Dan Carpenter
diff --git a/drivers/staging/dwc2/hcd_queue.c b/drivers/staging/dwc2/hcd_queue.c
index f200f1f6e1c6..ad9136e9d820 100644
--- a/drivers/staging/dwc2/hcd_queue.c
+++ b/drivers/stagi
Instead of writing code like:
if (dwc2_qh_is_non_per(qh)) {
...
} else {
...
}
return;
write it like:
if (dwc2_qh_is_non_per(qh)) {
...
return;
}
...
Signed-off-by: Dan Carpen
Combine two conditions and make the success path explicit.
Signed-off-by: Dan Carpenter
---
The code is more complicated than it needs to be because of the debug
code. If we just tested for error and then returned instead of trying
to print a debug message that is the easiest way. Debug code is
On Mon, Nov 04, 2013 at 11:57:10AM +0530, Kishon Vijay Abraham I wrote:
> Hi,
>
> On Saturday 02 November 2013 01:15 AM, Matt Porter wrote:
> >Add a driver for the internal Broadcom Kona USB 2.0 PHY found
> >on the BCM281xx family of SoCs.
> >
> >Signed-off-by: Matt Porter
> >---
> > drivers/phy
I have reviewed the second half of the driver now.
drivers/staging/dwc2/hcd_ddma.c
616 static void dwc2_fill_host_dma_desc(struct dwc2_hsotg *hsotg,
617 struct dwc2_host_chan *chan,
618 struct dwc2_qtd *qtd, struc
Hi,
I can't get my external usb 3.0 hdd to work on usb 3.0 ports with
kernels 3.11, 3.12.0, 3.13-rc1, it only works on usb 2 ports. dmesg
shows, that it disconnects immediately after it is plugged in. Then it
continues to connect and disconnect indefinitely:
[ 2623.116141] usb 3-5: new SuperSpeed
On Mon, 25 Nov 2013, David Laight wrote:
> > From: Alan Stern
> > On Mon, 25 Nov 2013, Xenia Ragiadakou wrote:
> >
> > > > You can simplify part of the problem by not allowing an endpoint to be
> > > > reset if it has any pending URBs. Just fail the reset in this case.
> > >
> > > Yes, you are r
On Mon, Nov 25, 2013 at 7:55 AM, Roger Quadros wrote:
> Beagle (rev. C4) and Beagle-XM (all revs) need VAUX2 1.8V supply
> for the USB PHY.
>
> As the generic PHY driver can't handle more than one supply
> at the moment, we configure this supply to be always on.
> This will cause a very small powe
Hi,
On Mon, Nov 18, 2013 at 04:54:35PM +0100, Markus Pargmann wrote:
> If there is no gadget driver musb should stay in B_IDLE state.
>
> Signed-off-by: Markus Pargmann
> ---
> drivers/usb/musb/musb_core.c | 3 ---
> drivers/usb/musb/musb_gadget.c | 14 --
> 2 files changed, 12 i
Hi,
On Mon, Nov 18, 2013 at 04:54:37PM +0100, Markus Pargmann wrote:
> @@ -350,6 +373,30 @@ out:
> return ret;
> }
>
> +static int dsps_musb_dbg_init(struct musb *musb, struct dsps_glue *glue)
> +{
> + struct dentry *root;
> + struct dentry *file;
> + char buf[128];
> +
> +
On Mon, Nov 18, 2013 at 04:54:38PM +0100, Markus Pargmann wrote:
> Signed-off-by: Markus Pargmann
no commit log == no commit. Sorry, but I'll be very pedantic about it.
--
balbi
signature.asc
Description: Digital signature
Hi,
On Mon, Nov 18, 2013 at 04:54:36PM +0100, Markus Pargmann wrote:
> It is not safe to assign the of_node to a device without driver. The
> device is matched against a list of drivers and the of_node could lead
> to a DT match with the parent driver.
>
> Signed-off-by: Markus Pargmann
> ---
>
On Wed, Nov 13, 2013 at 10:35:13PM +0800, Huang Rui wrote:
> The commit "usb: usbtest: support bos descriptor test for usb 3.0"
> introduced a test for bos descriptor. And USB 2.1 device also can be
> checked. So this patch extends the test coverage to support USB 2.1 device.
>
> Reported-by: Sara
On Wed, Nov 13, 2013 at 10:35:14PM +0800, Huang Rui wrote:
> USB 2.1 Link PM adds to use bits[1:15] according to USB 2.0 ECN Errata for
> Link Power Management spec.
>
> Bit Encoding
> 0 Reserved
> 1 LPM
> 2 BESL & Altemate HIRD definitions supported
> 3 Recommended Baseline BESL
hi alan
2013/11/15 Alan Stern :
> On Fri, 15 Nov 2013, vichy wrote:
>
>> hi Alan
>>
>> 2013/11/14 Alan Stern :
>> > On Thu, 14 Nov 2013, vichy wrote:
>> >
>> >> hi all:
>> >> I have some questions:
>> >> 1. if I need to capture all the data host capture from bus, usb mon
>> >> binary can reach thi
Hi,
On Sun, Nov 24, 2013 at 10:43:59PM +, Russell King - ARM Linux wrote:
> On Mon, Nov 25, 2013 at 12:22:47AM +0200, Aaro Koskinen wrote:
> > [ 33.967324] ohci ohci: Coherent DMA mask 0x (pfn
> > 0xe-0xe) covers a smaller range of system memory than the DMA zone
> > pfn 0x
On 11/25/2013 05:14 PM, Felipe Balbi wrote:
> Hi,
>
> On Mon, Nov 18, 2013 at 04:54:36PM +0100, Markus Pargmann wrote:
>> It is not safe to assign the of_node to a device without driver.
>> The device is matched against a list of drivers and the of_node
>> could lead to a DT match with the parent
On Tue, 26 Nov 2013, vichy wrote:
> BTW, is it possible to filter out bulk, interrupt or isochronous data
> that echi driver pass to urb?
If you use usbmon, you can filter the text output file very easily.
I don't know of any way to filter a binary output file from tcpdump.
> I am writing user
On 11/25/2013 04:41 AM, Alan Stern wrote:
On Mon, 25 Nov 2013, Xenia Ragiadakou wrote:
You can simplify part of the problem by not allowing an endpoint to be
reset if it has any pending URBs. Just fail the reset in this case.
Yes, you are right since, from what i understand, it is the
respons
fsg_common_set_inquiry_string() expects pointers
as second and third argument. Let's fix that by
passing NULL instead of plain 0 just so we silence
sparse's:
drivers/usb/gadget/f_mass_storage.c:3114:60: warning: \
Using plain integer as NULL pointer
drivers/usb/gadget/f_mass_storage.c:3114
use NULL instead of 0 as pointer.
Signed-off-by: Felipe Balbi
---
drivers/usb/gadget/f_fs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/f_fs.c b/drivers/usb/gadget/f_fs.c
index 774e8b8..241fc87 100644
--- a/drivers/usb/gadget/f_fs.c
+++ b/drivers/usb/ga
On Mon, Nov 25, 2013 at 06:33:02PM +0200, Aaro Koskinen wrote:
> Hi,
>
> On Sun, Nov 24, 2013 at 10:43:59PM +, Russell King - ARM Linux wrote:
> > On Mon, Nov 25, 2013 at 12:22:47AM +0200, Aaro Koskinen wrote:
> > > [ 33.967324] ohci ohci: Coherent DMA mask 0x (pfn
> > > 0xe-0xe
that symbol is only used inside this function driver,
we should mark it static. Fixes sparse's:
drivers/usb/gadget/tcm_usb_gadget.c:373:6: warning: symbol \
'bot_cleanup_old_alt' was not declared. Should it \
be static?
Signed-off-by: Felipe Balbi
---
drivers/usb/gadget/tcm_usb_
This will tell glue layer which mode we want port
to be in.
Signed-off-by: Felipe Balbi
---
drivers/usb/musb/musb_core.c | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
index 0a43329..377ef9b 100644
--- a
this will let us support broken designs such
as AM335x EVM SK where ID pin isn't routed
anywhere on a host port.
With this we can toggle internal IDDIG signal
and make sure MUSB goes into host mode as
necessary.
Signed-off-by: Felipe Balbi
---
drivers/usb/musb/musb_dsps.c | 51 +
On 11/25/2013 04:44 AM, Alan Stern wrote:
On Mon, 25 Nov 2013, Xenia Ragiadakou wrote:
On 11/25/2013 01:50 AM, Xenia Ragiadakou wrote:
[snip]
Also, while you're going through the whole remove-and-add procedure for
endpoints that aren't halted, do you want to hold the bandwidth mutex?
If the p
Hi,
On Fri, Nov 22, 2013 at 02:28:50PM +, Mark Jackson wrote:
> We have a custom AM335x board where the USB0_ID pin has been left floating.
>
> By default, this puts the USB controller into peripheral mode, but we need
> to force it into host mode.
>
> This can be achieved in s/w by setting
Hi Greg,
Here's my first set of fixes for this -rc cycle. Please
consider merging them on your usb-linus branch.
Let me know if you need any changes to this pull request. I
did a test merge of this tag with your usb-linus branch and
it merges just fine.
cheers
The following changes since commit
On Mon, 25 Nov 2013, Xenia Ragiadakou wrote:
> Actually, xhci driver does not implement endpoint_disable(). So, how can
> I force the disable not to be finished until the pending reset is
> finished? The only way i see is by implementing endpoint_disable()
> callback for xhci. Do you have somet
Changes since v2:
- Rebased on 3.13-rc1
- Fix braces in phy_get_bus_width()/phy_set_bus_width()
- Drop generic phy conversion to use the same support from
the Exynos generic phy conversion series
- Modify dts support to match the "device" phy name required
Adds support for querying the phy bus width from the generic phy
subsystem. Configure UTMI bus width in GUSBCFG based on this value.
Signed-off-by: Matt Porter
---
drivers/usb/gadget/s3c-hsotg.c | 14 +-
drivers/usb/gadget/s3c-hsotg.h | 1 +
2 files changed, 14 insertions(+), 1 dele
Add a binding that describes the Broadcom Kona USB2 PHY found
on the BCM281xx family of SoCs.
Signed-off-by: Matt Porter
---
.../devicetree/bindings/phy/bcm-kona-usb2-phy.txt | 15 +++
1 file changed, 15 insertions(+)
create mode 100644 Documentation/devicetree/bindings/phy/
Adds USB OTG/PHY and clock support to BCM281xx and enables
UDC support on the bcm11351-brt and bcm28155-ap boards.
Signed-off-by: Matt Porter
Reviewed-by: Markus Mayer
Reviewed-by: Tim Kryger
---
arch/arm/boot/dts/bcm11351-brt.dts | 6 ++
arch/arm/boot/dts/bcm11351.dtsi| 18 ++
Enable support for the dwc2 binding.
Signed-off-by: Matt Porter
---
drivers/usb/gadget/s3c-hsotg.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/gadget/s3c-hsotg.c b/drivers/usb/gadget/s3c-hsotg.c
index a8e6c3d..da3879b 100644
--- a/drivers/usb/gadget/s3c-hsotg.c
+++ b/drivers/
Add a driver for the internal Broadcom Kona USB 2.0 PHY found
on the BCM281xx family of SoCs.
Signed-off-by: Matt Porter
---
drivers/phy/Kconfig | 6 ++
drivers/phy/Makefile| 1 +
drivers/phy/phy-bcm-kona-usb2.c | 158
3 files
If a generic phy is present, call phy_init()/phy_exit(). This supports
generic phys that must be soft reset before power on.
Signed-off-by: Matt Porter
---
drivers/usb/gadget/s3c-hsotg.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/usb/gadget/s3c-hsotg.c b/drivers/usb/gadget/
dwc2/s3c-hsotg require a single clock to be specified and optionally
a generic phy. On the s3c-hsotg driver old style USB phy support is
present as a fallback so the generic phy properties are optional.
Signed-off-by: Matt Porter
---
Documentation/devicetree/bindings/staging/dwc2.txt | 10 ++
Remove unused Samsung-specific machine include and Kconfig
dependency on S3C.
Signed-off-by: Matt Porter
Reviewed-by: Markus Mayer
Reviewed-by: Tim Kryger
---
drivers/usb/gadget/Kconfig | 7 +++
drivers/usb/gadget/s3c-hsotg.c | 2 --
2 files changed, 3 insertions(+), 6 deletions(-)
di
This adds a pair of APIs that allows the generic PHY subsystem to
provide information on the PHY bus width. The PHY provider driver may
use phy_set_bus_width() to set the bus width that the PHY supports.
The controller driver may then use phy_get_bus_width() to fetch the
PHY bus width in order to p
From: George Cherian
Due to inter dependencies of I2C and extcon by the time dwc3
checks for extcon device its not registered especially in case of J6.
In O5 the vbus regulator save us from getting to this point.
So for tiime being return PROBE_DEFER if extcon is enabled in dt.
Signed-off-by: Ge
PROPIETARIO WEBMAIL ATENCIÓN;
Su buzón ha superado el límite de almacenamiento es de 5 GB, según lo
definido por el administrador, que se ejecuta en 10.9GB, es posible
que no pueda enviar o recibir correo nuevo hasta que vuelva a validar
su correo del buzón. Para revalidar su buzón de corr
I started seeing the following on my Samsung Series on 3.12.1
Is this bad? Looks like the following WARN_ON is firing:
drivers/usb/host/xhci.c:
if (WARN_ON(!virt_dev)) {
/*
* In plug/unplug torture test with an NEC controller,
* a zero-d
On Tue, Nov 05, 2013 at 05:13:21PM +0100, Kamil Debski wrote:
> Change the used phy driver to the new Exynos USB phy driver that uses the
> generic phy framework.
>
> Signed-off-by: Kamil Debski
> Signed-off-by: Kyungmin Park
> ---
> drivers/usb/gadget/s3c-hsotg.c | 12 +++-
> 1 file
On Mon, Nov 25, 2013 at 3:33 AM, Oliver Neukum wrote:
> On Fri, 2013-11-22 at 12:18 -0800, Dan Williams wrote:
>> On Fri, Nov 22, 2013 at 2:39 AM, Oliver Neukum wrote:
>> > On Fri, 2013-11-22 at 01:07 -0800, Dan Williams wrote:
>> >> Move all port power policy evaluation to usb_port_runtime_suspe
Hey kernel folks,
I'm running Debian Wheezy 7.2 on Asus U36JC. Debian runs fine and all my USB
2.0/3.0 ports work correctly. However, there is a big issue when my
computers wakes up from suspend. The USB 3.0 port does not wake up and
xhci_hcd throws some errors into dmesg. I tried to remove xhci_h
> From: Dan Carpenter [mailto:dan.carpen...@oracle.com]
> Sent: Monday, November 25, 2013 6:18 AM
>
> I have reviewed the second half of the driver now.
>
> drivers/staging/dwc2/hcd_ddma.c
>616 static void dwc2_fill_host_dma_desc(struct dwc2_hsotg *hsotg,
>617
On Mon, Nov 25, 2013 at 01:02:33PM -0600, Felipe Balbi wrote:
> Hi Greg,
>
> Here's my first set of fixes for this -rc cycle. Please
> consider merging them on your usb-linus branch.
>
> Let me know if you need any changes to this pull request. I
> did a test merge of this tag with your usb-linus
On Mon, Nov 25, 2013 at 11:33:48AM -0800, Greg KH wrote:
> On Mon, Nov 25, 2013 at 01:02:33PM -0600, Felipe Balbi wrote:
> > Hi Greg,
> >
> > Here's my first set of fixes for this -rc cycle. Please
> > consider merging them on your usb-linus branch.
> >
> > Let me know if you need any changes to
Hi Greg,
Here's my first set of fixes for this -rc cycle. Please
consider merging them on your usb-linus branch.
Let me know if you need any changes to this pull request. I
did a test merge of this tag with your usb-linus branch and
it merges just fine.
cheers
ps: now with proper tag :-) sorry
Hi Felipe,
These five patches for musb/dsps didn't make it into 3.13, which is no
big deal, at least as far as I'm concerned :)
I rebased the missing bits on top of 3.13-rc1. There are no functional
changes in comparison to what was posted earlier on this list.
Successfully tested on a AM33xx bo
rx_mode and tx_mode need to be read at suspend time and restored on
resume for dsps platforms. So add it to the wrapper struct first, and
initialize the values.
Signed-off-by: Daniel Mack
---
drivers/usb/musb/musb_dsps.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/usb/musb/mu
The dsps platform needs to save save some registers at suspend time and
restore them after resume. This patch adds a struct for these registers,
and also lets the musb core know that the core registers need to be
saved as well.
We also have to call musb_port_reset() for this platform upon resume,
It appears not all platforms featuring a musb core need to save the musb
core registers at suspend time and restore them on resume.
The dsps platform does, however. So add a bit in struct
musb_hdrc_platform_data to let platforms specify their need of such
action being taken.
Signed-off-by: Daniel
Make musb_port_suspend() externally available, and call it when to host
goes into suspend. This allows the core to go into suspend while a
device is connected.
Signed-off-by: Daniel Mack
---
drivers/usb/musb/musb_host.c| 2 ++
drivers/usb/musb/musb_host.h| 2 ++
drivers/usb/musb/musb_vir
Just a cosmetic thing, no functional change.
Signed-off-by: Daniel Mack
---
drivers/usb/musb/musb_dsps.c | 23 +++
1 file changed, 11 insertions(+), 12 deletions(-)
diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb/musb/musb_dsps.c
index 361ddf8..b27c072 100644
--- a/d
> From: Dan Carpenter [mailto:dan.carpen...@oracle.com]
> Sent: Monday, November 25, 2013 6:11 AM
>
> I've made the success and error paths clearer and pulled some code in
> one indent level.
>
> Signed-off-by: Dan Carpenter
>
> diff --git a/drivers/staging/dwc2/hcd_queue.c
> b/drivers/staging
Hi,
On Mon, Nov 25, 2013 at 08:39:49PM +0100, Daniel Mack wrote:
> It appears not all platforms featuring a musb core need to save the musb
> core registers at suspend time and restore them on resume.
>
> The dsps platform does, however. So add a bit in struct
> musb_hdrc_platform_data to let pla
> From: Dan Carpenter [mailto:dan.carpen...@oracle.com]
> Sent: Monday, November 25, 2013 6:14 AM
>
> Combine two conditions and make the success path explicit.
>
> Signed-off-by: Dan Carpenter
> ---
> The code is more complicated than it needs to be because of the debug
> code. If we just test
On Mon, Nov 25, 2013 at 08:39:50PM +0100, Daniel Mack wrote:
> Make musb_port_suspend() externally available, and call it when to host
> goes into suspend. This allows the core to go into suspend while a
> device is connected.
>
> Signed-off-by: Daniel Mack
> ---
> drivers/usb/musb/musb_host.c
> From: Dan Carpenter [mailto:dan.carpen...@oracle.com]
> Sent: Monday, November 25, 2013 6:14 AM
>
> Instead of writing code like:
>
> if (dwc2_qh_is_non_per(qh)) {
> ...
> } else {
> ...
> }
> return;
>
> write it like:
>
> if (dwc2_qh
On Mon, Nov 25, 2013 at 08:39:52PM +0100, Daniel Mack wrote:
> The dsps platform needs to save save some registers at suspend time and
> restore them after resume. This patch adds a struct for these registers,
> and also lets the musb core know that the core registers need to be
> saved as well.
>
On Mon, Nov 25, 2013 at 08:39:53PM +0100, Daniel Mack wrote:
> Just a cosmetic thing, no functional change.
>
> Signed-off-by: Daniel Mack
> ---
> drivers/usb/musb/musb_dsps.c | 23 +++
> 1 file changed, 11 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/usb/musb/mus
On Mon, Nov 25, 2013 at 07:46:57PM +, Paul Zimmerman wrote:
>
> This touches the same function as the patch series "staging: dwc2:
> cleanups for DWC2 driver" that I have already submitted. If you don't
> mind, I will fold this patch into that series when I resubmit it to
> fix some other thin
On Fri, Nov 22, 2013 at 2:12 PM, Alan Stern wrote:
> On Fri, 22 Nov 2013, Dan Williams wrote:
>
>> Summary:
>> 1/ Half the size of v1 [1], drop peer port power control for now
>> 2/ Make port power control more robust by reusing the existing
>>"reset-resume" implementation for connection recov
On 11/25/2013 08:46 PM, Felipe Balbi wrote:
> On Mon, Nov 25, 2013 at 08:39:50PM +0100, Daniel Mack wrote:
>> Make musb_port_suspend() externally available, and call it when to host
>> goes into suspend. This allows the core to go into suspend while a
>> device is connected.
>>
>> Signed-off-by: Da
On 11/25/2013 08:49 PM, Felipe Balbi wrote:
> On Mon, Nov 25, 2013 at 08:39:53PM +0100, Daniel Mack wrote:
>> Just a cosmetic thing, no functional change.
>>
>> Signed-off-by: Daniel Mack
>> ---
>> drivers/usb/musb/musb_dsps.c | 23 +++
>> 1 file changed, 11 insertions(+), 12
Hi,
On Mon, Nov 25, 2013 at 08:58:22PM +0100, Daniel Mack wrote:
> On 11/25/2013 08:46 PM, Felipe Balbi wrote:
> > On Mon, Nov 25, 2013 at 08:39:50PM +0100, Daniel Mack wrote:
> >> Make musb_port_suspend() externally available, and call it when to host
> >> goes into suspend. This allows the core
On 11/25/2013 08:48 PM, Felipe Balbi wrote:
> On Mon, Nov 25, 2013 at 08:39:52PM +0100, Daniel Mack wrote:
>> The dsps platform needs to save save some registers at suspend time and
>> restore them after resume. This patch adds a struct for these registers,
>> and also lets the musb core know that
On 11/25/2013 08:44 PM, Felipe Balbi wrote:
> Hi,
>
> On Mon, Nov 25, 2013 at 08:39:49PM +0100, Daniel Mack wrote:
>> It appears not all platforms featuring a musb core need to save the musb
>> core registers at suspend time and restore them on resume.
>>
>> The dsps platform does, however. So add
Hi,
On Mon, Nov 25, 2013 at 09:04:16PM +0100, Daniel Mack wrote:
> >> diff --git a/drivers/usb/musb/musb_virthub.c
> >> b/drivers/usb/musb/musb_virthub.c
> >> index e977441..24e46c0 100644
> >> --- a/drivers/usb/musb/musb_virthub.c
> >> +++ b/drivers/usb/musb/musb_virthub.c
> >> @@ -109,7 +109,7
Hi,
On Mon, Nov 25, 2013 at 09:08:51PM +0100, Daniel Mack wrote:
> On 11/25/2013 08:44 PM, Felipe Balbi wrote:
> > Hi,
> >
> > On Mon, Nov 25, 2013 at 08:39:49PM +0100, Daniel Mack wrote:
> >> It appears not all platforms featuring a musb core need to save the musb
> >> core registers at suspend
Series adds USB host support for Keystone SOCs. Keystone SOCs uses dwc3
hardware IP implementation. On Keystone II platforms, we use no-op phy
driver.
All three patches are posted together just for completeness. Only first patch
is expected to go via usb tree and other two via linux-keystone tree
Added device tree support for TI's Keystone USB driver and updated the
Documentation with device tree binding information.
On Keystone II platforms, we use no-op phy driver.
Cc: Santosh Shilimkar
Signed-off-by: WingMan Kwok
---
.../devicetree/bindings/usb/keystone-usb.txt | 43
Add Keystone platform specific glue layer to support
USB3 Host mode.
Cc: Santosh Shilimkar
Cc: Felipe Balbi
Cc: Greg Kroah-Hartman
Signed-off-by: WingMan Kwok
---
drivers/usb/dwc3/Kconfig |7 +
drivers/usb/dwc3/Makefile|1 +
drivers/usb/dwc3/dwc3-keystone.c | 272
Enable the USB host mode support on TI's Keystone platform.
It also enables the support of usb mass storage, FAT and Ext4
filesystems to test rootfs mount over an USB disk.
Cc: Santosh Shilimkar
Signed-off-by: WingMan Kwok
---
arch/arm/configs/keystone_defconfig | 20 +++-
1 f
On 11/25/2013 09:01 PM, Felipe Balbi wrote:
> Hi,
>
> On Mon, Nov 25, 2013 at 08:58:22PM +0100, Daniel Mack wrote:
>> On 11/25/2013 08:46 PM, Felipe Balbi wrote:
>>> On Mon, Nov 25, 2013 at 08:39:50PM +0100, Daniel Mack wrote:
Make musb_port_suspend() externally available, and call it when to
On 11/25/2013 09:08 PM, Felipe Balbi wrote:
> On Mon, Nov 25, 2013 at 09:04:16PM +0100, Daniel Mack wrote:
diff --git a/drivers/usb/musb/musb_virthub.c
b/drivers/usb/musb/musb_virthub.c
index e977441..24e46c0 100644
--- a/drivers/usb/musb/musb_virthub.c
+++ b/drivers/usb/m
On 11/25/2013 09:13 PM, Felipe Balbi wrote:
> Hi,
>
> On Mon, Nov 25, 2013 at 09:08:51PM +0100, Daniel Mack wrote:
>> On 11/25/2013 08:44 PM, Felipe Balbi wrote:
>>> Hi,
>>>
>>> On Mon, Nov 25, 2013 at 08:39:49PM +0100, Daniel Mack wrote:
It appears not all platforms featuring a musb core nee
On Mon, 25 Nov 2013, Felipe Balbi wrote:
> On Mon, Nov 25, 2013 at 08:39:50PM +0100, Daniel Mack wrote:
> > Make musb_port_suspend() externally available, and call it when to host
> > goes into suspend. This allows the core to go into suspend while a
> > device is connected.
> have you considered
Hi,
On Mon, Nov 25, 2013 at 03:16:19PM -0500, WingMan Kwok wrote:
> diff --git a/drivers/usb/dwc3/dwc3-keystone.c
> b/drivers/usb/dwc3/dwc3-keystone.c
> new file mode 100644
> index 000..a4c9cbc
> --- /dev/null
> +++ b/drivers/usb/dwc3/dwc3-keystone.c
> @@ -0,0 +1,272 @@
> +/**
> + * dwc3-key
On Mon, 25 Nov 2013, Daniel Mack wrote:
> >>> What if you have a mounted file system on a pendrive ? Should we allow
> >>> suspend in that case ?
> >>
> >> Well, I would have expected that, but in fact, the opposite is true.
> >> With 3.12, mounting a filesystem on a USB media and accessing it aft
Hi,
On Mon, Nov 25, 2013 at 03:16:20PM -0500, WingMan Kwok wrote:
> Added device tree support for TI's Keystone USB driver and updated the
> Documentation with device tree binding information.
>
> On Keystone II platforms, we use no-op phy driver.
>
> Cc: Santosh Shilimkar
> Signed-off-by: Wing
1 - 100 of 155 matches
Mail list logo
