Re: [PATCH 11/68] usb-core: Track if an endpoint has streams

2013-11-16 Thread Hans de Goede
Hi, On 11/16/2013 08:45 AM, Oliver Neukum wrote: On Fri, 2013-11-15 at 23:26 +0100, Hans de Goede wrote: Hi, On 11/15/2013 11:16 PM, Oliver Neukum wrote: On Fri, 2013-11-15 at 16:06 +0100, Hans de Goede wrote: This is a preparation patch for adding support for bulk streams to usbfs. @@ -2

Re: [PATCH 31/68] uas: Pack iu struct definitions

2013-11-16 Thread Hans de Goede
Hi, On 11/15/2013 10:09 PM, Greg KH wrote: On Fri, Nov 15, 2013 at 03:56:31PM -, David Laight wrote: From: Hans de Goede [mailto:hdego...@redhat.com] On 11/15/2013 04:29 PM, David Laight wrote: From: Of Hans de Goede The iu struct definitions are usb packet definitions, so no alignment sh

Re: [PATCH 42/68] uas: Add a usbcore.nouas kernel cmdline option

2013-11-16 Thread Hans de Goede
Hi, On 11/15/2013 10:07 PM, Greg KH wrote: On Fri, Nov 15, 2013 at 09:21:40PM +0100, Hans de Goede wrote: Hi, On 11/15/2013 08:19 PM, Sarah Sharp wrote: On Fri, Nov 15, 2013 at 04:06:56PM +0100, Hans de Goede wrote: Note this is done through a usbcore module parameter as the option is needed

RE: [PATCH 2/2] usb: chipidea: usbmisc: Add support for i.MX51 CPU

2013-11-16 Thread Peter Chen
> > > > Signed-off-by: Alexander Shiyan > > --- > > drivers/usb/chipidea/usbmisc_imx.c | 40 +- > > > 1 file changed, 22 insertions(+), 18 deletions(-) > > > > > > -static int usbmisc_imx53_init(struct imx_usbmisc_data *data) > > +static int usbmisc_imx5_ini

Re: [PATCH 2/2] usb: chipidea: usbmisc: Add support for i.MX51 CPU

2013-11-16 Thread Alexander Shiyan
Hello. > > > Signed-off-by: Alexander Shiyan > > > --- > > > drivers/usb/chipidea/usbmisc_imx.c | 40 +- > > > > > 1 file changed, 22 insertions(+), 18 deletions(-) > > > > > > > > > -static int usbmisc_imx53_init(struct imx_usbmisc_data *data) > > > +static

[PATCH 11/70] usb-core: Track if an endpoint has streams

2013-11-16 Thread Hans de Goede
This is a preparation patch for adding support for bulk streams to usbfs. Signed-off-by: Hans de Goede Signed-off-by: Sarah Sharp --- drivers/usb/core/hcd.c | 34 ++ include/linux/usb.h| 2 ++ 2 files changed, 28 insertions(+), 8 deletions(-) diff --git a/d

[GIT pull for 3.14 v2] xhci streams and uas fixes + usbfs streams support

2013-11-16 Thread Hans de Goede
Hi Sarah, Here is v2 of my patch-series / pull-req for you to pull into your xhci tree for 3.14 . This new version has the following changes: "usb-core: Track if an endpoint has streams": Remove unnecessary ep type check from usb_free_streams, the check if the endpoint has streams is sufficient.

[PATCH 44/70] uas: Honor no-uas quirk set in usb-storage's quirks module parameter

2013-11-16 Thread Hans de Goede
Falling back from uas to usb-storage requires coordination between uas and usb-storage, so use usb-storage's quirks module parameter, rather then requiring the user to pass a param to 2 different modules. Signed-off-by: Hans de Goede --- drivers/usb/storage/Kconfig | 2 +- drivers/usb/stora

[PATCH 43/70] usb-storage: Modify and export adjust_quirks so that it can be used by uas

2013-11-16 Thread Hans de Goede
Signed-off-by: Hans de Goede --- drivers/usb/storage/usb.c | 16 ++-- drivers/usb/storage/usb.h | 3 +++ 2 files changed, 13 insertions(+), 6 deletions(-) diff --git a/drivers/usb/storage/usb.c b/drivers/usb/storage/usb.c index 2055bc7..a045f52 100644 --- a/drivers/usb/storage/usb.c

[PATCH 48/70] uas: Drop fixed endpoint config handling

2013-11-16 Thread Hans de Goede
The fixed endpoint config code was only necessary to deal with an early uas prototype which has never been released, so lets drop it and enforce proper uas endpoint descriptors. Signed-off-by: Hans de Goede --- drivers/usb/storage/uas.c | 36 +++- 1 file changed,

[PATCH 49/70] uas: Verify endpoint descriptors from uas_use_uas_driver()

2013-11-16 Thread Hans de Goede
Signed-off-by: Hans de Goede --- drivers/usb/storage/uas-detect.h | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/usb/storage/uas-detect.h b/drivers/usb/storage/uas-detect.h index 8de030a..b8a02e1 100644 --- a/drivers/usb/storage/uas-detect.h +++ b/drivers

[PATCH 69/70] uas: Add Hans de Goede as uas maintainer

2013-11-16 Thread Hans de Goede
At the kernel-summit Sarah Sharp asked me if I was willing to become the uas maintainer. I said yes, and here is a patch to make this official. Also remove Matthew Wilcox and Sarah Sharp as maintainers at their request. I've also added myself to the module's author tag, so that if people look the

Re: [PATCH 31/68] uas: Pack iu struct definitions

2013-11-16 Thread Alan Stern
On Sat, 16 Nov 2013, Hans de Goede wrote: > > No, Linux relies on the compiler to pack things like this together and > > not put padding in, with the __packed__ attribute (don't we have a > > __packed macro instead of the __attribute__() thing?) > > Yes we've a __packed macro, but the norm in the

Re: [PATCH 27/31] USB: EHCI: tegra: use reset framework

2013-11-16 Thread Alan Stern
On Fri, 15 Nov 2013, Stephen Warren wrote: > From: Stephen Warren > > Tegra's clock driver now provides an implementation of the common > reset API (include/linux/reset.h). Use this instead of the old Tegra- > specific API; that will soon be removed. > > Cc: tred...@nvidia.com > Cc: pdeschrij..

Re: [PATCH 31/68] uas: Pack iu struct definitions

2013-11-16 Thread Hans de Goede
Hi, On 11/16/2013 07:11 PM, Alan Stern wrote: On Sat, 16 Nov 2013, Hans de Goede wrote: No, Linux relies on the compiler to pack things like this together and not put padding in, with the __packed__ attribute (don't we have a __packed macro instead of the __attribute__() thing?) Yes we've a

Re: CDC-ACM device issue

2013-11-16 Thread Luke-Jr
I *thought* 3.12 fixed this, but it seems it just gives EOF instead of EIO... It seems Linux is trying an interrupt in and a control out, and getting ENOENT and EPIPE respectively. Windows (where this works), on the other hand, is doing a whole bunch of other things... Here are USB captures of

[PATCH] USB: chipidea: i.MX: Probe usbmisc early

2013-11-16 Thread Marek Vasut
Probe the usbmisc driver earlier, otherwise the ci_hdrc_imx.c will get -EPROBE_DEFER from usbmisc when both are compiled into the kernel and thus USB gadget mode won't work. Signed-off-by: Marek Vasut Cc: Alexander Shishkin Cc: Peter Chen --- drivers/usb/chipidea/usbmisc_imx.c | 13 +++

RE: [PATCH 2/2] usb: chipidea: usbmisc: Add support for i.MX51 CPU

2013-11-16 Thread Peter Chen
> > > This gives us some breathing room later to actually do the right > thing > > > without additionally performing renames all over the place to make > > > imx5 -> imx53 (again)/imx51 (new). > > > > You may take matt's suggestion, it can reduce the code change now and > in future. > > We can on

RE: [PATCH] USB: chipidea: i.MX: Probe usbmisc early

2013-11-16 Thread Peter Chen
> > Probe the usbmisc driver earlier, otherwise the ci_hdrc_imx.c will > get -EPROBE_DEFER from usbmisc when both are compiled into the kernel > and thus USB gadget mode won't work. > Hi Marek, you know the root cause of it, you suggested using a better way to fix it. http://marc.info/?l=linu