Hi,
On Tuesday 05 November 2013 09:43 PM, Kamil Debski wrote:
Add a new driver for the Exynos USB PHY. The new driver uses the generic
PHY framework. The driver includes support for the Exynos 4x10 and 4x12
SoC families.
Signed-off-by: Kamil Debski
Signed-off-by: Kyungmin Park
---
.../devic
Since commit c5340bd14 ("usb: musb: cancel work on removal") the workqueue
is cancelled but then if we bail out before the workqueue is setup we
get this:
|INFO: trying to register non-static key.
|the code is fine but needs lockdep annotation.
|turning off the locking correctness validator.
|CPU:
Hi
By performing iterative port suspend and resume (which results in function
suspend and resume), ring expansion failure is observed. Attached device
has multiple interfaces for which interface host drivers are unlinking the
urbs during function suspend and submitting urbs during resume.
For the
> -Original Message-
> From: Andiry Xu [mailto:and...@gmail.com]
> Sent: 05 November 2013 17:40
> To: David Laight
> Cc: Linux-USB; Sarah Sharp
> Subject: Re: [PATCH] usb: xhci: Optimise setup of isochronous transfers
>
> On Tue, Nov 5, 2013 at 6:21 AM, David Laight wrote:
> >
> > Close
> By performing iterative port suspend and resume (which results in function
> suspend and resume), ring expansion failure is observed. Attached device
> has multiple interfaces for which interface host drivers are unlinking the
> urbs during function suspend and submitting urbs during resume.
>
>
Hi,
> From: Jingoo Han [mailto:jg1@samsung.com]
> Sent: Wednesday, November 06, 2013 2:03 AM
>
> On Wednesday, November 06, 2013 1:13 AM, Kamil Debski wrote:
> >
> > Add a new driver for the Exynos USB PHY. The new driver uses the
> > generic PHY framework. The driver includes support for the
When suspend, some urb is put into cancelled_td_list.
process_bulk_intr_td may process the last trb as below:
xhci_transfer_event.transfer_len = 0
xhci_transfer_event.trb_comp_code = 27
urb.transfer_buffer_length = 1024
trb_comp_code is COMP_STOP_INVAL, it should be taken as
invalid urb and discar
Hi Kishon
On Wednesday 06 of November 2013 13:48:13 Kishon Vijay Abraham I wrote:
> Hi,
>
> On Tuesday 05 November 2013 09:43 PM, Kamil Debski wrote:
> > Add a new driver for the Exynos USB PHY. The new driver uses the generic
> > PHY framework. The driver includes support for the Exynos 4x10 and
Hi,
On Wednesday 06 November 2013 05:08 PM, Tomasz Figa wrote:
Hi Kishon
On Wednesday 06 of November 2013 13:48:13 Kishon Vijay Abraham I wrote:
Hi,
On Tuesday 05 November 2013 09:43 PM, Kamil Debski wrote:
Add a new driver for the Exynos USB PHY. The new driver uses the generic
PHY framewor
On Wednesday 06 of November 2013 18:20:36 Kishon Vijay Abraham I wrote:
> Hi,
>
> On Wednesday 06 November 2013 05:08 PM, Tomasz Figa wrote:
> > Hi Kishon
> >
> > On Wednesday 06 of November 2013 13:48:13 Kishon Vijay Abraham I wrote:
> >> Hi,
> >>
> >> On Tuesday 05 November 2013 09:43 PM, Kamil
In reference to the message sent by Andrzej Pietrasiewicz
(about libusbg (formerly libgadget)) I would like to propose
some changes to libusbg.
Creating directories is now performed after successful memory
allocation and gadget function creation. Hard coded values are
replaced with constants. Erro
256 hard coded value has been replaced by two defined
constants MAX_LENGTH and MAX_PATH_LENGTH
Signed-off-by: Stanislaw Wadas
---
Changes since v1:
- fixed typos in MAX_LENGTH throughout
include/gadget/gadget.h | 27 +++
src/gadget.c| 46 +
Error handling was added to fputs()/fgets() functions.
Signed-off-by: Stanislaw Wadas
---
Changes since v3:
- fixed code indentation
Changes since v2:
- fixed code indentation
- removed unused variable ret
Changes since v1:
- fixed typos in MAX_LENGTH throughout
mkdir() function is now performed after successful memory allocation
and gadget function creation.
Signed-off-by: Stanislaw Wadas
---
src/gadget.c | 36 ++--
1 file changed, 18 insertions(+), 18 deletions(-)
diff --git a/src/gadget.c b/src/gadget.c
index d226d3
Added inline to gadget_write_string().
Signed-off-by: Stanislaw Wadas
---
src/gadget.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gadget.c b/src/gadget.c
index 79a1698..8ca68b3 100644
--- a/src/gadget.c
+++ b/src/gadget.c
@@ -162,7 +162,7 @@ static void gadget_wri
> > I just did a diff of registers in exynos 4210 and 4212 PHY drivers [1]
> > and couldn't find that big a difference in register layout. Of course
> > there are a few changes in HSIC bit fields and PHYFSEL but that's only
> > minimal and could well be handled in a single driver.
> >
> > [1] -> ht
> 256 hard coded value has been replaced by two defined
> constants MAX_LENGTH and MAX_PATH_LENGTH
Think of better names.
David
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://v
Hi David,
On Wednesday 06 of November 2013 13:03:45 David Laight wrote:
> > > I just did a diff of registers in exynos 4210 and 4212 PHY drivers [1]
> > > and couldn't find that big a difference in register layout. Of course
> > > there are a few changes in HSIC bit fields and PHYFSEL but that's o
"Yann E. MORIN" writes:
> Dirk, All,
>
> On 2013-11-01 00:39 +0100, Dirk Gouders spake thusly:
>> If choices consist of choice_values that depend on symbols set to 'm',
>> those choice_values are not set to 'n' if the choice is changed from
>> 'm' to 'y' (in which case only one active choice_valu
Hi,
On Wed, Nov 06, 2013 at 12:33:26AM +0400, Valentine Barshak wrote:
> This adds remove_phy flag to the HCD structure. If the flag is
> set and if hcd->phy is valid, the phy is shutdown and released
> whenever usb_add_hcd fails or usb_hcd_remove is called.
> This can be used by the HCD drivers t
Hi,
On Wed, Nov 06, 2013 at 12:33:27AM +0400, Valentine Barshak wrote:
> This adds external USB phy support to USB HCD driver that
> allows to find and initialize external USB phy, bound to
> the HCD when the HCD is added.
> The usb_add_hcd function returns -EPROBE_DEFER if the USB
> phy, bound to
On Tue, 5 Nov 2013, Cliff Brake wrote:
> On Tue, Nov 5, 2013 at 9:57 AM, Alan Stern wrote:
> > On Mon, 4 Nov 2013, Cliff Brake wrote:
> >
>
> >>
> >> I assume interrupts are disabled during both ohci_irq() and ehci_irq().
> >
> > Currently they are. This will change somewhat in the not-too-dist
On Tue, 5 Nov 2013, David Cohen wrote:
> Due to USB controllers may have different restrictions, usb gadget layer
> needs to provide a generic way to inform gadget functions to complain
> with non-standard requirements.
>
> This patch adds 'quirk_ep_out_aligned_size' field to struct usb_gadget
>
On Wed, 6 Nov 2013, Alistair Popple wrote:
> Currently the ppc-of driver uses the compatibility string
> "usb-ehci". This means platforms that use device-tree and implement an
> EHCI compatible interface have to either use the ppc-of driver or add
> a compatible line to the ehci-platform driver. I
On Tue, 5 Nov 2013, Dan Carpenter wrote:
> Hello Alan Stern,
>
> The patch b35c5009bbf6: "USB: EHCI: create per-TT bandwidth tables"
> from Oct 11, 2013, leads to the following
> static checker warning: "drivers/usb/host/ehci-sched.c:1377
> reserve_release_iso_bandwidth()
>error: 'tt' d
On Wed, 6 Nov 2013, Felipe Balbi wrote:
> Hi,
>
> On Wed, Nov 06, 2013 at 12:33:26AM +0400, Valentine Barshak wrote:
> > This adds remove_phy flag to the HCD structure. If the flag is
> > set and if hcd->phy is valid, the phy is shutdown and released
> > whenever usb_add_hcd fails or usb_hcd_remo
On Wed, 6 Nov 2013, Felipe Balbi wrote:
> Hi,
>
> On Wed, Nov 06, 2013 at 12:33:27AM +0400, Valentine Barshak wrote:
> > This adds external USB phy support to USB HCD driver that
> > allows to find and initialize external USB phy, bound to
> > the HCD when the HCD is added.
> > The usb_add_hcd fu
On 11/06/2013 07:45 PM, Felipe Balbi wrote:
Hi,
On Wed, Nov 06, 2013 at 12:33:26AM +0400, Valentine Barshak wrote:
This adds remove_phy flag to the HCD structure. If the flag is
set and if hcd->phy is valid, the phy is shutdown and released
whenever usb_add_hcd fails or usb_hcd_remove is called
On 11/06/2013 08:39 PM, Alan Stern wrote:
On Wed, 6 Nov 2013, Felipe Balbi wrote:
Hi,
On Wed, Nov 06, 2013 at 12:33:27AM +0400, Valentine Barshak wrote:
This adds external USB phy support to USB HCD driver that
allows to find and initialize external USB phy, bound to
the HCD when the HCD is a
Hi,
On Wed, Nov 06, 2013 at 08:43:36PM +0400, Valentine wrote:
> On 11/06/2013 07:45 PM, Felipe Balbi wrote:
> >Hi,
> >
> >On Wed, Nov 06, 2013 at 12:33:26AM +0400, Valentine Barshak wrote:
> >>This adds remove_phy flag to the HCD structure. If the flag is
> >>set and if hcd->phy is valid, the phy
On Wed, Nov 06, 2013 at 08:47:36PM +0400, Valentine wrote:
> On 11/06/2013 08:39 PM, Alan Stern wrote:
> >On Wed, 6 Nov 2013, Felipe Balbi wrote:
> >
> >>Hi,
> >>
> >>On Wed, Nov 06, 2013 at 12:33:27AM +0400, Valentine Barshak wrote:
> >>>This adds external USB phy support to USB HCD driver that
>
On 11/06/2013 09:04 PM, Felipe Balbi wrote:
Hi,
On Wed, Nov 06, 2013 at 08:43:36PM +0400, Valentine wrote:
On 11/06/2013 07:45 PM, Felipe Balbi wrote:
Hi,
On Wed, Nov 06, 2013 at 12:33:26AM +0400, Valentine Barshak wrote:
This adds remove_phy flag to the HCD structure. If the flag is
set and
On Wed, Nov 6, 2013 at 12:53 AM, wrote:
> Hi
>
> By performing iterative port suspend and resume (which results in function
> suspend and resume), ring expansion failure is observed. Attached device
> has multiple interfaces for which interface host drivers are unlinking the
> urbs during functio
fedora kernel 3.9.10-100.fc17.x86_64
xhci_hcd :12:00.0: ERROR Transfer event TRB DMA ptr not part of
current TD
i got this message about every 200 MICROseconds after a warm boot.
unplugging the usb3 cables silenced it. plugging back in, everything
came up fine.
grepping messages for :
On Tue, Nov 05 2013, Alan Stern wrote:
> Maybe Michal can enlighten us.
Sorry for late response, this thread fell under my radar for some
reason.
So here's how it works:
epfile represents an end point file on the fuctionfs file system,
i.e. what user space is seeing. It's numbering is independe
Dirk, All,
On 2013-11-06 15:43 +0100, Dirk Gouders spake thusly:
> "Yann E. MORIN" writes:
[--SNIP--]
> > It seems I'm missing something here.
[--SNIP--]
> Yes, but obviously, I did not describe it very clearly. The steps to
> reproduce the problem are:
>
> $ ./scripts/kconfig/mconf test.i
On Wed, Nov 06, 2013 at 11:24:37AM -0500, Alan Stern wrote:
> Short of adding redundant tests, how would you suggest this be handled?
Yeah. I discourage people from making changes to please the checker.
It often hurts readability. Also the checker is changing all the time
and later we might want
On Wed, 2013-11-06 at 18:39 +1100, Alistair Popple wrote:
> diff --git a/arch/powerpc/boot/dts/sequoia.dts
> b/arch/powerpc/boot/dts/sequoia.dts
> index b1d3292..e28371e 100644
> --- a/arch/powerpc/boot/dts/sequoia.dts
> +++ b/arch/powerpc/boot/dts/sequoia.dts
> @@ -153,7 +153,7 @@
>
This patch adds a check for USB_STATE_NOTATTACHED to the
hub_port_warm_reset_required() workaround for ports that end up in
Compliance Mode in hub_events() when trying to decide which reset
function to use. Trying to call usb_reset_device() with a NOTATTACHED
device will just fail and leave the por
*bump*
Hi Sarah, is there anything else that needs to be resolved to pick
this patch up? Looks like Matthias' recent LPM fixes are all in now so
there should be no way this could cause any trouble?
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to
> On Wed, Nov 6, 2013 at 12:53 AM, wrote:
>> Hi
>>
>> By performing iterative port suspend and resume (which results in
>> function
>> suspend and resume), ring expansion failure is observed. Attached device
>> has multiple interfaces for which interface host drivers are unlinking
>> the
>> urbs
On Wed, Nov 06, 2013 at 12:27:21PM -0800, Julius Werner wrote:
> This patch adds a check for USB_STATE_NOTATTACHED to the
> hub_port_warm_reset_required() workaround for ports that end up in
> Compliance Mode in hub_events() when trying to decide which reset
> function to use. Trying to call usb_re
On Wed, 6 Nov 2013, Julius Werner wrote:
> This patch adds a check for USB_STATE_NOTATTACHED to the
> hub_port_warm_reset_required() workaround for ports that end up in
> Compliance Mode in hub_events() when trying to decide which reset
> function to use. Trying to call usb_reset_device() with a N
On Wed, Nov 6, 2013 at 12:33 PM, wrote:
>> On Wed, Nov 6, 2013 at 12:53 AM, wrote:
>>> Hi
>>>
>>> By performing iterative port suspend and resume (which results in
>>> function
>>> suspend and resume), ring expansion failure is observed. Attached device
>>> has multiple interfaces for which int
> On Wed, Nov 6, 2013 at 12:33 PM, wrote:
>>> On Wed, Nov 6, 2013 at 12:53 AM, wrote:
Hi
By performing iterative port suspend and resume (which results in
function
suspend and resume), ring expansion failure is observed. Attached
device
has multiple interfaces
> Who makes those calls, drivers? Any specific ones that you know need to
be fixed?
Well, the one I'm worried about is the one this patch is fixing, in
hub_events(). I have seen this happen when having certain USB3 devices
plugged into a host controller that always looses power on
suspend-to-ram
The following changes since commit 31d141e3a666269a3b6fcccddb0351caf7454240:
Linux 3.12-rc6 (2013-10-19 12:28:15 -0700)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/
tags/usb-3.13-rc1
for you to fetch changes up to 7d49f0bac41ee9b012a
>> On Wed, Nov 6, 2013 at 12:33 PM, wrote:
On Wed, Nov 6, 2013 at 12:53 AM, wrote:
> Hi
>
> By performing iterative port suspend and resume (which results in
> function
> suspend and resume), ring expansion failure is observed. Attached
> device
> has multiple i
We need to set mxs_phy rather as the platform drvdata so that we can get
the correct mxs_phy in mxs_phy_remove().
Change-Id: I6e1753cc978e2ed3fbb3d1865be0c54031d337d2
Signed-off-by: Jisheng Zhang
---
drivers/usb/phy/phy-mxs-usb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
On Thu, Nov 07, 2013 at 10:26:20AM +0800, Jisheng Zhang wrote:
> We need to set mxs_phy rather as the platform drvdata so that we can get
> the correct mxs_phy in mxs_phy_remove().
>
> Change-Id: I6e1753cc978e2ed3fbb3d1865be0c54031d337d2
> Signed-off-by: Jisheng Zhang
Acked-by: Shawn Guo
Chang
On Wed, 6 Nov 2013 11:14:44 Alan Stern wrote:
> On Wed, 6 Nov 2013, Alistair Popple wrote:
[snip]
> > + /* Initialise platform data from device tree if available. */
> > + if (!dn) {
>
> Shouldn't this be "if (dn)"?
Yep. Thanks.
> > + if (of_get_property(dn, "big-endian", NULL))
On Thu, 7 Nov 2013 06:57:00 Benjamin Herrenschmidt wrote:
> On Wed, 2013-11-06 at 18:39 +1100, Alistair Popple wrote:
[snip]
>
> I would go even further and add the 44x workarounds to the normal
> platform device, with a compatible check in there. That isn't the
> first time we add quirks to an
On Wed, 6 Nov 2013 18:34:47 -0800
Shawn Guo wrote:
> On Thu, Nov 07, 2013 at 10:26:20AM +0800, Jisheng Zhang wrote:
> > We need to set mxs_phy rather as the platform drvdata so that we can get
> > the correct mxs_phy in mxs_phy_remove().
> >
> > Change-Id: I6e1753cc978e2ed3fbb3d1865be0c54031d337
On Thu, Nov 07, 2013 at 10:26:20AM +0800, Jisheng Zhang wrote:
> We need to set mxs_phy rather as the platform drvdata so that we can get
> the correct mxs_phy in mxs_phy_remove().
>
> Change-Id: I6e1753cc978e2ed3fbb3d1865be0c54031d337d2
please strip Gerrit-specific tags from commit log.
--
bal
We need to set mxs_phy rather as the platform drvdata so that we can get
the correct mxs_phy in mxs_phy_remove().
Signed-off-by: Jisheng Zhang
---
drivers/usb/phy/phy-mxs-usb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/phy/phy-mxs-usb.c b/drivers/usb/phy/phy
On Tue, 5 Nov 2013 10:04:02 Alan Stern wrote:
[snip]
> >
> > + /* Platforms using DT don't always provide platform data.
> > +* This should provide reasonable defaults. */
>
> /*
>* The accepted format for multi-line
>* comments is like this.
>*/
>
Ok, I'll
On Thu, 2013-11-07 at 14:34 +1100, Alistair Popple wrote:
> Thanks. Based on the discussion for the EHCI driver I would like to change
> the
> compatibility string to "usb-ochi" (instead of "ibm,akebono-ohci"). Are you
> still happy for me to add the Acked-by with the alternate compatibility (an
>
> Signed-off-by: Jisheng Zhang
> ---
> drivers/usb/phy/phy-mxs-usb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/phy/phy-mxs-usb.c b/drivers/usb/phy/phy-mxs-
> usb.c
> index fdd33b4..545844b 100644
> --- a/drivers/usb/phy/phy-mxs-usb.c
> +++ b/driver
There is a new funtion interface and g_ffs is the last gadget to use the old.
Signed-off-by: Andrzej Pietrasiewicz
Signed-off-by: Kyungmin Park
Acked-by: Michal Nazarewicz
---
drivers/usb/gadget/Kconfig |1 +
drivers/usb/gadget/g_ffs.c | 93 +---
2
There are no old function interface users left, so the old interface
can be removed.
Signed-off-by: Andrzej Pietrasiewicz
Signed-off-by: Kyungmin Park
Acked-by: Michal Nazarewicz
---
drivers/usb/gadget/f_subset.c | 60 +
drivers/usb/gadget/u_ether.h |
There is a new function interface of f_subset and g_ffs is the last to use
the old one.
Signed-off-by: Andrzej Pietrasiewicz
Signed-off-by: Kyungmin Park
Acked-by: Michal Nazarewicz
---
drivers/usb/gadget/Kconfig |1 +
drivers/usb/gadget/g_ffs.c | 69 ++---
USB function's configfs config group is created in a generic way in
usb/gadget/configfs.c:function_make(), which in turn delegates actual
allocation and setup of the USB function instance to a particular
implementation, e.g. in f_acm.c. The said implementation does its job
in a parameter-less funct
There are no old function interface users left, so the old interface
can be removed.
Signed-off-by: Andrzej Pietrasiewicz
Signed-off-by: Kyungmim Park
Acked-by: Michal Nazarewicz
---
drivers/usb/gadget/f_ecm.c | 73 +-
drivers/usb/gadget/u_ether.h |
This series aims at integrating configfs into FunctionFS, the way
it has been done for acm, ncm, ecm, eem, ecm subset, rndis, obex, phonet
and mass_storage. It contains everything that is required to provide the
equivalent of g_ffs.ko with configfs.
Configfs support in FunctionFS has been awaited
There is a new interface of f_rndis and g_ffs is the last to use the old one.
Signed-off-by: Andrzej Pietrasiewicz
Signed-off-by: Kyungmin Park
Acked-by: Michal Nazarewicz
---
drivers/usb/gadget/Kconfig |1 +
drivers/usb/gadget/g_ffs.c | 105 +++-
2
Since d6a0143985489e470a118605352f4b18df0ce142
usb: gadget: move the global the_dev variable to their users
"the_dev" variable can be used as a "setup done" flag; non-NULL
meaning "setup done", NULL meaning "setup not done". Moreover,
gether_cleanup() can be safely called with a NULL argument.
Cor
The rndis function's users use only the new interface, so the two modules
can be merged.
Signed-off-by: Andrzej Pietrasiewicz
Signed-off-by: Kyungmin Park
Acked-by: Michal Nazarewicz
---
drivers/usb/gadget/Kconfig |7 ---
drivers/usb/gadget/Makefile |4 +---
drivers/usb/gadget/f
The use of variable length arrays in structs (VLAIS) in the Linux Kernel code
precludes the use of compilers which don't implement VLAIS (for instance the
Clang compiler). This alternate patch calculates offsets into the kmalloc-ed
memory buffer using macros. The previous patch required multiple km
A header file to be used by f_fs.c and g_ffs.c will be required when
f_fs.c is converted into a module.
Signed-off-by: Andrzej Pietrasiewicz
Signed-off-by: Kyungmin Park
Acked-by: Michal Nazarewicz
---
drivers/usb/gadget/f_fs.c |1 +
drivers/usb/gadget/g_ffs.c | 19 ++-
This will be required in order to use the new function interface
(usb_get_function_instance/usb_put_function_instance)
Signed-off-by: Andrzej Pietrasiewicz
Signed-off-by: Kyunmgin Park
---
drivers/usb/gadget/f_fs.c | 41
drivers/usb/gadget/g_ffs.c | 50
There are no old function interface users left, so the old interface
can be removed.
Signed-off-by: Andrzej Pietrasiewicz
Signed-off-by: Kyungmin Park
Acked-by: Michal Nazarewicz
---
drivers/usb/gadget/f_rndis.c | 72 +-
drivers/usb/gadget/u_ether.h |
This series aims at integrating configfs into FunctionFS, the way
it has been done for acm, ncm, ecm, eem, ecm subset, rndis, obex, phonet
and mass_storage. It contains everything that is required to provide the
equivalent of g_ffs.ko with configfs.
Configfs support in FunctionFS has been awaited
Since d6a0143985489e470a118605352f4b18df0ce142
usb: gadget: move the global the_dev variable to their users
"the_dev" variable can be used as a "setup done" flag; non-NULL
meaning "setup done", NULL meaning "setup not done". Moreover,
gether_cleanup() can be safely called with a NULL argument.
Cor
There is a new function interface of f_subset and g_ffs is the last to use
the old one.
Signed-off-by: Andrzej Pietrasiewicz
Signed-off-by: Kyungmin Park
Acked-by: Michal Nazarewicz
---
drivers/usb/gadget/Kconfig |1 +
drivers/usb/gadget/g_ffs.c | 69 ++---
There is a new funtion interface and g_ffs is the last gadget to use the old.
Signed-off-by: Andrzej Pietrasiewicz
Signed-off-by: Kyungmin Park
Acked-by: Michal Nazarewicz
---
drivers/usb/gadget/Kconfig |1 +
drivers/usb/gadget/g_ffs.c | 93 +---
2
Add support for using FunctionFS in configfs-based USB gadgets.
Signed-off-by: Andrzej Pietrasiewicz
Signed-off-by: Kyungmin Park
Acked-by: Michal Nazarewicz
---
Documentation/ABI/testing/configfs-usb-gadget-ffs |9 ++
drivers/usb/gadget/Kconfig| 12 ++
drivers/us
This is required in order to integrate configfs support.
f_fs needs to be a separately compiled module and so it needs to use the new
interface.
Signed-off-by: Andrzej Pietrasiewicz
Signed-off-by: Kyungmin Park
Acked-by: Michal Nazarewicz
---
drivers/usb/gadget/Kconfig |3 +
drivers/us
There are no old function interface users left, so the old interface
can be removed.
Signed-off-by: Andrzej Pietrasiewicz
Signed-off-by: Kyungmim Park
Acked-by: Michal Nazarewicz
---
drivers/usb/gadget/f_ecm.c | 73 +-
drivers/usb/gadget/u_ether.h |
USB function's configfs config group is created in a generic way in
usb/gadget/configfs.c:function_make(), which in turn delegates actual
allocation and setup of the USB function instance to a particular
implementation, e.g. in f_acm.c. The said implementation does its job
in a parameter-less funct
The use of variable length arrays in structs (VLAIS) in the Linux Kernel code
precludes the use of compilers which don't implement VLAIS (for instance the
Clang compiler). This alternate patch calculates offsets into the kmalloc-ed
memory buffer using macros. The previous patch required multiple km
This will be required in order to use the new function interface
(usb_get_function_instance/usb_put_function_instance)
Signed-off-by: Andrzej Pietrasiewicz
Signed-off-by: Kyungmin Park
---
drivers/usb/gadget/f_fs.c | 41
drivers/usb/gadget/g_ffs.c | 50
Prepare for configfs integration. Use the new interface so that f_fs can be
made a module.
Signed-off-by: Andrzej Pietrasiewicz
Signed-off-by: Kyungmin Park
---
drivers/usb/gadget/Kconfig |1 +
drivers/usb/gadget/g_ffs.c | 135
2 files changed,
There are no old function interface users left, so the old interface can
be removed.
Signed-off-by: Andrzej Pietrasiewicz
Signed-off-by: Kyungmin Park
Acked-by: Michal Nazarewicz
---
drivers/usb/gadget/f_fs.c | 148 +---
drivers/usb/gadget/u_fs.h
The rndis function's users use only the new interface, so the two modules
can be merged.
Signed-off-by: Andrzej Pietrasiewicz
Signed-off-by: Kyungmin Park
Acked-by: Michal Nazarewicz
---
drivers/usb/gadget/Kconfig |7 ---
drivers/usb/gadget/Makefile |4 +---
drivers/usb/gadget/f
A header file to be used by f_fs.c and g_ffs.c will be required when
f_fs.c is converted into a module.
Signed-off-by: Andrzej Pietrasiewicz
Signed-off-by: Kyungmin Park
Acked-by: Michal Nazarewicz
---
drivers/usb/gadget/f_fs.c |1 +
drivers/usb/gadget/g_ffs.c | 19 ++-
There are no old function interface users left, so the old interface
can be removed.
Signed-off-by: Andrzej Pietrasiewicz
Signed-off-by: Kyungmin Park
Acked-by: Michal Nazarewicz
---
drivers/usb/gadget/f_subset.c | 60 +
drivers/usb/gadget/u_ether.h |
There are no old function interface users left, so the old interface
can be removed.
Signed-off-by: Andrzej Pietrasiewicz
Signed-off-by: Kyungmin Park
Acked-by: Michal Nazarewicz
---
drivers/usb/gadget/f_rndis.c | 72 +-
drivers/usb/gadget/u_ether.h |
There is a new interface of f_rndis and g_ffs is the last to use the old one.
Signed-off-by: Andrzej Pietrasiewicz
Signed-off-by: Kyungmin Park
Acked-by: Michal Nazarewicz
---
drivers/usb/gadget/Kconfig |1 +
drivers/usb/gadget/g_ffs.c | 105 +++-
2
alloc_ep_req() is a function repeated in several modules.
Make a common implementation and use it.
Signed-off-by: Andrzej Pietrasiewicz
Signed-off-by: Kyungmin Park
Acked-by: Michal Nazarewicz
---
drivers/usb/gadget/Makefile |2 +-
drivers/usb/gadget/f_hid.c| 18 +--
On Tue, 2013-11-05 at 21:16 +, Luke-Jr wrote:
> I am trying to interface with the "HEX" devices sold by http://technobit.eu/
> which appear as CDC-ACM devices, but give an I/O error whenever I try to open
> them, with some rather unclear error description in dmesg:
>
> [10526714.860052] usb
Add support for using the loopback USB function in gadgets composed with
configfs.
Signed-off-by: Andrzej Pietrasiewicz
Signed-off-by: Kyungmin Park
---
.../ABI/testing/configfs-usb-gadget-loopback |8 ++
drivers/usb/gadget/Kconfig | 12 ++
drivers/usb/gadget
If there are setup requests not directed to an endpont or an interface,
current config's setup() has been attempted so far.
This patch, in case the above fails, adds code which tries the setup() of
configuration's function if there is only one function in the configuration.
This behavior is requir
Add support for using the sourcesink function in gadgets composed with
configfs.
Signed-off-by: Andrzej Pietrasiewicz
Signed-off-by: Kyungmin Park
---
.../ABI/testing/configfs-usb-gadget-sourcesink | 12 +
drivers/usb/gadget/Kconfig |7 +-
drivers/usb/gadget/f_
This series aims at integrating configfs into gadget zero, the way
it has been done for acm, ncm, ecm, eem, ecm subset, rndis, obex, phonet,
mass_storage and FunctionFS. It contains everything that is required to provide
the
equivalent of g_zero.ko with configfs.
v1..v2:
- fixes after Michal's
There is a bug in ehci_msm_probe() where we do:
hcd->irq = platform_get_irq(pdev, 0);
if (hcd->irq < 0) {
The problem is that hcd->irq is unsigned so the error handling doesn't
work. I have made it signed.
Signed-off-by: Dan Carpenter
diff --git a/include/linux/usb/hcd.h b/inc
95 matches
Mail list logo
