Re: [PATCH v2 5/9] usb: gadget: s3c-hsotg: enable generic phy support

2013-11-02 Thread Tomasz Figa
Hi Matt. On Friday 01 of November 2013 15:45:54 Matt Porter wrote: > Adds support for the generic PHY subsystem. Generic PHY > support is probed and then the driver falls back to checking > for an old style USB PHY and pdata if not found. > > Signed-off-by: Matt Porter > --- > drivers/usb/gadge

Re: [PATCH v2 1/9] phy: add phy_get_bus_width()/phy_set_bus_width() calls

2013-11-02 Thread Tomasz Figa
Hi Matt, On Friday 01 of November 2013 15:45:50 Matt Porter wrote: > This adds a pair of APIs that allows the generic PHY subsystem to > provide information on the PHY bus width. The PHY provider driver may > use phy_set_bus_width() to set the bus width that the PHY supports. > The controller driv

[PATCH net-next 13/13] scripts/checkpatch.pl: Add dev_kfree_skb*(NULL) check to checkpatch

2013-11-02 Thread Govindarajulu Varadarajan
Signed-off-by: Govindarajulu Varadarajan --- scripts/checkpatch.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 66cad50..e651b8a 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -3719,7 +3719,7 @@ sub proc

[PATCH net-next 05/13] driver: usb/gadget: remove unnecessary skb NULL check before calling dev_kfree_skb_irq

2013-11-02 Thread Govindarajulu Varadarajan
dev_kfree_skb_irq is protected from NULL. No need to check for NULL while calling this function. Signed-off-by: Govindarajulu Varadarajan --- drivers/usb/gadget/f_phonet.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/usb/gadget/f_phonet.c b/drivers/usb/gadget

[PATCH net-next 09/13] driver: s390: remove unnecessary NULL check before dev_kfree_skb_any

2013-11-02 Thread Govindarajulu Varadarajan
dev_kfree_skb_any is protected from NULL. No need to check for NULL while calling this function. Signed-off-by: Govindarajulu Varadarajan --- drivers/s390/net/claw.c | 6 ++ drivers/s390/net/ctcm_mpc.c | 6 ++ drivers/s390/net/qeth_core_main.c | 6 ++ 3 files changed,

[PATCH net-next 03/13] driver: atm: remove unnecessary skb NULL check before calling dev_kfree_skb_irq

2013-11-02 Thread Govindarajulu Varadarajan
dev_kfree_skb_irq is protected from NULL. No need to check for NULL while calling this function. Signed-off-by: Govindarajulu Varadarajan --- drivers/atm/eni.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/atm/eni.c b/drivers/atm/eni.c index b1955ba..78a4445 100644

[PATCH net-next 06/13] driver: net: remove unnecessary NULL check before dev_kfree_skb_any

2013-11-02 Thread Govindarajulu Varadarajan
dev_kfree_skb_any is protected from NULL. No need to check for NULL while calling this function. Signed-off-by: Govindarajulu Varadarajan --- drivers/net/ethernet/amd/lance.c | 9 +++-- drivers/net/ethernet/atheros/alx/main.c | 6 ++ drivers/net/etherne

[PATCH net-next 08/13] driver: isdn: remove unnecessary NULL check before dev_kfree_skb_any

2013-11-02 Thread Govindarajulu Varadarajan
dev_kfree_skb_any is protected from NULL. No need to check for NULL while calling this function. Signed-off-by: Govindarajulu Varadarajan --- drivers/isdn/gigaset/ser-gigaset.c | 3 +-- drivers/isdn/hisax/hfc_usb.c | 6 ++ drivers/isdn/hisax/icc.c | 6 ++ drivers/isdn/his

[PATCH net-next 01/13] net: Check skb for NULL in dev_kfree_skb_irq

2013-11-02 Thread Govindarajulu Varadarajan
Signed-off-by: Govindarajulu Varadarajan --- net/core/dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/dev.c b/net/core/dev.c index 0054c8c..63bd44d 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -2146,7 +2146,7 @@ EXPORT_SYMBOL(__netif_schedule); void de

[PATCH net-next 02/13] driver: net: remove unnecessary skb NULL check before calling dev_kfree_skb_irq

2013-11-02 Thread Govindarajulu Varadarajan
dev_kfree_skb_irq is protected from NULL. No need to check for NULL while calling this function. Signed-off-by: Govindarajulu Varadarajan --- drivers/net/ethernet/amd/ni65.c | 6 ++ drivers/net/ethernet/atheros/atl1c/atl1c_main.c | 10 -- drivers/net/ethernet/ath

[PATCH net-next 11/13] driver: usb: remove unnecessary NULL check before dev_kfree_skb_any

2013-11-02 Thread Govindarajulu Varadarajan
dev_kfree_skb_any is protected from NULL. No need to check for NULL while calling this function. Signed-off-by: Govindarajulu Varadarajan --- drivers/usb/gadget/u_ether.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/usb/gadget/u_ether.c b/drivers/usb/gadget/u

[PATCH net-next 04/13] driver: staging: remove unnecessary skb NULL check before calling dev_kfree_skb_irq

2013-11-02 Thread Govindarajulu Varadarajan
dev_kfree_skb_irq is protected from NULL. No need to check for NULL while calling this function. Signed-off-by: Govindarajulu Varadarajan --- drivers/staging/slicoss/slicoss.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/stagi

[PATCH net-next 07/13] driver: staging: remove unnecessary NULL check before dev_kfree_skb_any

2013-11-02 Thread Govindarajulu Varadarajan
dev_kfree_skb_any is protected from NULL. No need to check for NULL while calling this function. Signed-off-by: Govindarajulu Varadarajan --- drivers/staging/rtl8187se/ieee80211/ieee80211_rx.c | 3 +-- drivers/staging/rtl8187se/ieee80211/ieee80211_tx.c | 3 +-- drivers/staging/rtl8188eu/core/r

[PATCH net-next 10/13] driver: infiniband: remove unnecessary NULL check before dev_kfree_skb_any

2013-11-02 Thread Govindarajulu Varadarajan
dev_kfree_skb_any is protected from NULL. No need to check for NULL while calling this function. Signed-off-by: Govindarajulu Varadarajan --- drivers/infiniband/hw/amso1100/c2.c | 6 ++ drivers/infiniband/hw/nes/nes_hw.c | 3 +-- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git

[PATCH net-next 12/13] driver: net: fix space before '(' and remove extra variable

2013-11-02 Thread Govindarajulu Varadarajan
Signed-off-by: Govindarajulu Varadarajan --- drivers/net/ethernet/sgi/ioc3-eth.c | 4 +--- drivers/net/usb/usbnet.c| 2 +- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/sgi/ioc3-eth.c b/drivers/net/ethernet/sgi/ioc3-eth.c index 6bd90f2..80dcfd9 1

[PATCH net-next 00/13] Protect dev_kfree_skb_irq from NULL and remove unnecessary NULL checks

2013-11-02 Thread Govindarajulu Varadarajan
dev_kfree_skb_irq is not NULL safe. The following patch checks skb for NULL in dev_kfree_skb_irq. At many places we check for NULL before calling dev_kfree_skb_*(). Moving the check to dev_kfree_skb_irq_*() removes the reddundant if condition and makes code simpler. Also dev_kfree_skb_any eithe

Re:

2013-11-02 Thread baljeet217
I recommend to visit the link! http://compassionate-hc.com/_351en_google.invites.main_us273_.html?vimimydydoku=9408470 -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majo

Re: [PATCH 01/16] usb/gadget: configfs: allow setting function instance's name

2013-11-02 Thread Michal Nazarewicz
On Wed, Oct 23 2013, Andrzej Pietrasiewicz wrote: > USB function's configfs config group is created in a generic way in > usb/gadget/configfs.c:function_make(), which in turn delegates actual > allocation and setup of the USB function instance to a particular > implementation, e.g. in f_acm.c. The

Re: [PATCH 02/16] usb/gadget: g_ffs: remove a reduntant gfs_ether_setup variable

2013-11-02 Thread Michal Nazarewicz
On Wed, Oct 23 2013, Andrzej Pietrasiewicz wrote: > Since d6a0143985489e470a118605352f4b18df0ce142 > usb: gadget: move the global the_dev variable to their users > "the_dev" variable can be used as a "setup done" flag; non-NULL > meaning "setup done", NULL meaning "setup not done". Moreover, > geth

Re: [PATCH 04/16] usb/gadget: f_ecm: remove compatibility layer

2013-11-02 Thread Michal Nazarewicz
On Wed, Oct 23 2013, Andrzej Pietrasiewicz wrote: > There are no old function interface users left, so the old interface > can be removed. > > Signed-off-by: Andrzej Pietrasiewicz > Signed-off-by: Kyungmim Park Acked-by: Michal Nazarewicz > --- > drivers/usb/gadget/f_ecm.c | 73 > +--

Re: [PATCH 06/16] usb/gadget: f_subset: remove compatibility layer

2013-11-02 Thread Michal Nazarewicz
On Wed, Oct 23 2013, Andrzej Pietrasiewicz wrote: > There are no old function interface users left, so the old interface > can be removed. > > Signed-off-by: Andrzej Pietrasiewicz > Signed-off-by: Kyungmin Park Acked-by: Michal Nazarewicz > --- > drivers/usb/gadget/f_subset.c | 60 > +-

Re: [PATCH 08/16] usb/gadget: f_rndis: remove compatibility layer

2013-11-02 Thread Michal Nazarewicz
On Wed, Oct 23 2013, Andrzej Pietrasiewicz wrote: > There are no old function interface users left, so the old interface > can be removed. > > Signed-off-by: Andrzej Pietrasiewicz > Signed-off-by: Kyungmin Park Acked-by: Michal Nazarewicz > --- > drivers/usb/gadget/f_rndis.c | 72 > +--

Re: [PATCH v2 1/9] phy: add phy_get_bus_width()/phy_set_bus_width() calls

2013-11-02 Thread Kishon Vijay Abraham I
Hi Tomasz, On Saturday 02 November 2013 06:44 PM, Tomasz Figa wrote: Hi Matt, On Friday 01 of November 2013 15:45:50 Matt Porter wrote: This adds a pair of APIs that allows the generic PHY subsystem to provide information on the PHY bus width. The PHY provider driver may use phy_set_bus_width(

Re: [PATCH 10/16] usb/gadget: FunctionFS: Remove VLAIS usage from gadget code

2013-11-02 Thread Michal Nazarewicz
On Wed, Oct 23 2013, Andrzej Pietrasiewicz wrote: > From: Mark Charlebois > > The use of variable length arrays in structs (VLAIS) in the Linux Kernel code > precludes the use of compilers which don't implement VLAIS (for instance the > Clang compiler). This alternate patch calculates offsets into

Re: [PATCH v2 1/9] phy: add phy_get_bus_width()/phy_set_bus_width() calls

2013-11-02 Thread Matt Porter
On Sat, Nov 02, 2013 at 10:46:55PM +0530, Kishon Vijay Abraham I wrote: > Hi Tomasz, > > On Saturday 02 November 2013 06:44 PM, Tomasz Figa wrote: > >Hi Matt, > > > >On Friday 01 of November 2013 15:45:50 Matt Porter wrote: > >>This adds a pair of APIs that allows the generic PHY subsystem to > >>

Re: [PATCH 09/16] usb/gadget: rndis: merge u_rndis.ko with usb_f_rndis.ko

2013-11-02 Thread Michal Nazarewicz
On Wed, Oct 23 2013, Andrzej Pietrasiewicz wrote: > The rndis function's users use only the new interface, so the two modules > can be merged. > > Signed-off-by: Andrzej Pietrasiewicz > Signed-off-by: Kyungmin Park Acked-by: Michal Nazarewicz > --- > drivers/usb/gadget/Kconfig |7 --

Re: [PATCH 11/16] usb/gadget: FunctionFS: create utility file

2013-11-02 Thread Michal Nazarewicz
On Wed, Oct 23 2013, Andrzej Pietrasiewicz wrote: > A header file to be used by f_fs.c and g_ffs.c will be required when > f_fs.c is converted into a module. > > Signed-off-by: Andrzej Pietrasiewicz > Signed-off-by: Kyungmin Park Acked-by: Michal Nazarewicz > --- > drivers/usb/gadget/f_fs.c

Re: [PATCH v2 5/9] usb: gadget: s3c-hsotg: enable generic phy support

2013-11-02 Thread Matt Porter
On Sat, Nov 02, 2013 at 02:09:21PM +0100, Tomasz Figa wrote: > Hi Matt. > > On Friday 01 of November 2013 15:45:54 Matt Porter wrote: > > Adds support for the generic PHY subsystem. Generic PHY > > support is probed and then the driver falls back to checking > > for an old style USB PHY and pdata

Re: [PATCH 12/16] usb/gadget: FunctionFS: add devices management code

2013-11-02 Thread Michal Nazarewicz
On Wed, Oct 23 2013, Andrzej Pietrasiewicz wrote: > This will be required in order to use the new function interface > (usb_get_function_instance/usb_put_function_instance) > > Signed-off-by: Andrzej Pietrasiewicz > Signed-off-by: Kyunmgin Park > --- > drivers/usb/gadget/f_fs.c | 41 +

Re: Gadget tool proposition

2013-11-02 Thread 'Matt Porter'
On Thu, Oct 31, 2013 at 01:35:45PM +0100, Krzysztof Opasiak wrote: > Hi, > > > -Original Message- > > From: Felipe Balbi [mailto:ba...@ti.com] > > Sent: Wednesday, October 30, 2013 6:33 PM > > To: Krzysztof Opasiak > > Cc: linux-usb@vger.kernel.org; Matt Porter > > Subject: Re: Gadget tool

Re: [PATCH v2 1/9] phy: add phy_get_bus_width()/phy_set_bus_width() calls

2013-11-02 Thread Tomasz Figa
On Saturday 02 of November 2013 13:47:09 Matt Porter wrote: > On Sat, Nov 02, 2013 at 10:46:55PM +0530, Kishon Vijay Abraham I wrote: > > Hi Tomasz, > > > > On Saturday 02 November 2013 06:44 PM, Tomasz Figa wrote: > > >Hi Matt, > > > > > >On Friday 01 of November 2013 15:45:50 Matt Porter wrote:

Re: khubd timed out on ep0in len=0/64 with 3.4 kernel

2013-11-02 Thread Prasad Koya
Hi I didn't have luck reproducing with both CONFIG_USB_DEBUG and CONFIG_USB_STORAGE_DEBUG. I could reproduce with each of them enabled separately. Am attaching the whole dmesg of both as zip files. If I should send them in different format, please let me know. I didn't see anything warnings or err