On Thu, Oct 31, 2013 at 12:32:29AM +0800, Alan Stern wrote:
> On Wed, 30 Oct 2013, Alan Stern wrote:
>
> > I think you have found a bug in the dwc3 driver.
>
> > At this point, because the IGNORE_BULK_OUT bit is set, g_mass_storage
> > issues a usb_ep_clear_halt() call for the bulk-in (CSW) endpo
Hi,
On Thu, Oct 31, 2013 at 10:21:28AM -0500, Felipe Balbi wrote:
> On Thu, Oct 31, 2013 at 04:02:20PM +0100, Johannes Stezenbach wrote:
> > On Wed, Oct 30, 2013 at 10:44:30PM +0100, Johannes Stezenbach wrote:
> > > On Wed, Oct 30, 2013 at 12:54:15PM -0500, Felipe Balbi wrote:
> > > >
> > > > Do
"Yann E. MORIN" writes:
> Dirk, All,
>
> On 2013-10-30 15:26 +0100, Dirk Gouders spake thusly:
>> Dirk Gouders writes:
> [--SNIP--]
>> below is a patch that prevents choice_values to appear in the list if
>> they depend on 'm' symbols and the choice symbol is set to 'y'. I would
>> be glad if y
If choices consist of choice_values that depend on symbols set to 'm',
those choice_values are not set to 'n' if the choice is changed from
'm' to 'y' (in which case only one active choice_value is allowed).
Those values are also written to the config file causing modules to be
built when they shou
Am 31.10.2013 21:56, schrieb Johan Hovold:
> On Thu, Oct 31, 2013 at 09:26:06PM +0100, Johan Hovold wrote:
>> On Thu, Oct 31, 2013 at 7:45 PM, Frank Schäfer wrote:
>>> Am 31.10.2013 13:30, schrieb Mika Westerberg:
On Thu, Oct 31, 2013 at 01:02:56PM +0100, Frank Schäfer wrote:
> 2) comment
No need to keep this code duplicated from usbnet.
Cc: Alexey Orishko
Signed-off-by: Bjørn Mork
---
drivers/net/usb/cdc_ncm.c | 26 --
1 file changed, 26 deletions(-)
diff --git a/drivers/net/usb/cdc_ncm.c b/drivers/net/usb/cdc_ncm.c
index c90d843..8fc1a06 100644
--- a
Too many pointers back and forth are likely to confuse developers,
creating subtle bugs whenever we forget to syncronize them all.
As a usbnet driver, we should stick with the standard struct
usbnet fields as much as possible. The netdevice is one such
field.
Cc: Greg Suarez
Cc: Alexey Orishko
Padding NTBs to max size is part of the support for devices
optimizing their DMA transfers. This optimization depends on
max sized NTBs not being ZLP terminated. So we are much better
off dropping the padding if we are going to send a ZLP anyway.
Cc: Alexey Orishko
Signed-off-by: Bjørn Mork
---
Cc: Alexey Orishko
Signed-off-by: Bjørn Mork
---
include/linux/usb/cdc_ncm.h | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/include/linux/usb/cdc_ncm.h b/include/linux/usb/cdc_ncm.h
index cad54ad..2300f74 100644
--- a/include/linux/usb/cdc_ncm.h
+++ b/include/
We already use the usbnet udev field everywhere this could have
been used.
Cc: Alexey Orishko
Signed-off-by: Bjørn Mork
---
drivers/net/usb/cdc_ncm.c |2 --
include/linux/usb/cdc_ncm.h |1 -
2 files changed, 3 deletions(-)
diff --git a/drivers/net/usb/cdc_ncm.c b/drivers/net/usb/cdc_
These signatures are well known bit patterns, mostly made up
of ascii characters. Mentally parsing works best if they
are printed in hex.
Cc: Alexey Orishko
Signed-off-by: Bjørn Mork
---
drivers/net/usb/cdc_ncm.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/
There are MBIM devices out there reporting
dwNtbInMaxSize=2048 dwNtbOutMaxSize=2048
and since the spec require a datagram max size of at least
2048, this means that a full sized datagram will never fit.
Still, sending larger NTBs than the device supports is not
going to help. We do not have a
We need to inform the device about the *new* value, not the
old one.
Cc: Alexey Orishko
Signed-off-by: Bjørn Mork
---
drivers/net/usb/cdc_ncm.c |1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/usb/cdc_ncm.c b/drivers/net/usb/cdc_ncm.c
index 4de3a542..b8de8dd 100644
--- a/drive
This makes it a lot easier to test modified versions
Cc: Alexey Orishko
Signed-off-by: Bjørn Mork
---
include/linux/usb/cdc_ncm.h |5 +
1 file changed, 5 insertions(+)
diff --git a/include/linux/usb/cdc_ncm.h b/include/linux/usb/cdc_ncm.h
index cc25b70..89f0bbc 100644
--- a/include/lin
Make it a bit easier for users to figure out what goes
wrong when bind fails.
Cc: Alexey Orishko
Signed-off-by: Bjørn Mork
---
drivers/net/usb/cdc_ncm.c | 36 ++--
1 file changed, 26 insertions(+), 10 deletions(-)
diff --git a/drivers/net/usb/cdc_ncm.c b/drive
Fix cut'n'paste typo. Log the bogus length and not the
irrelevant signature.
Cc: Alexey Orishko
Signed-off-by: Bjørn Mork
---
drivers/net/usb/cdc_ncm.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/usb/cdc_ncm.c b/drivers/net/usb/cdc_ncm.c
index c40f742..b5
Most setup errors are ignored to ensure maximum firmware
compatibilty. But GET_NTB_PARAMETERS and the functional
descriptors are required. Use proper error codes and
log level if these fail.
Cc: Alexey Orishko
Signed-off-by: Bjørn Mork
---
drivers/net/usb/cdc_ncm.c |4 ++--
1 file changed
These fields are only used to prevent printing the same speeds
multiple times if we receive multiple identical speed notifications.
The value of these printk's is questionable, and even more so when
we filter out some of the notifications sent us by the firmware. If
we are going to print any of th
header_desc was completely unused and union_desc was never used
outside cdc_ncm_bind_common.
Cc: Alexey Orishko
Signed-off-by: Bjørn Mork
---
drivers/net/usb/cdc_ncm.c | 12 ++--
include/linux/usb/cdc_ncm.h |4 +---
2 files changed, 7 insertions(+), 9 deletions(-)
diff --git a/
Take advantage of standard device name prefixing and
netdevice msglvl control where possible.
Cc: Alexey Orishko
Signed-off-by: Bjørn Mork
---
drivers/net/usb/cdc_ncm.c | 98 ++---
1 file changed, 48 insertions(+), 50 deletions(-)
diff --git a/drivers/
These functions were merely wrappers around the usbnet
variants. Remove them.
Cc: Alexey Orishko
Signed-off-by: Bjørn Mork
---
drivers/net/usb/cdc_ncm.c | 20 ++--
1 file changed, 2 insertions(+), 18 deletions(-)
diff --git a/drivers/net/usb/cdc_ncm.c b/drivers/net/usb/cdc_n
Rewriting the "set max datagram" part of dc_ncm_setup to
separate the selection and validatation of the size from
the code which optionally informs the device of this
value. This ensures that we use the correct value
regardless of device support for the get and set commands.
Removing some of the
We can avoid the costly division for the common case where
we pad the frame to tx_max size as long as we ensure that
tx_max is either the device specified dwNtbOutMaxSize or not
a multiplum of wMaxPacketSize.
Using the preconverted 'maxpacket' field avoids converting
wMaxPacketSize to CPU endianne
This series ended up longer than expected, and it is still not
complete. There is more to come when time allows...
Most changes are trivial. Notable non-trivial changes are
- removed filtering of identical speed notifications
- tx_max calulation is changed to count the pad byte if
necessary,
This is always a duplicate of the "control" field. It causes
confusion wrt intf_data updates and cleanups.
Cc: Alexey Orishko
Signed-off-by: Bjørn Mork
---
drivers/net/usb/cdc_ncm.c |4 +---
include/linux/usb/cdc_ncm.h |1 -
2 files changed, 1 insertion(+), 4 deletions(-)
diff --git
No need to duplicate stuff already in the common usbnet
struct. We still need to keep our special find_endpoints
function because we need explicit control over the selected
altsetting.
Cc: Alexey Orishko
Signed-off-by: Bjørn Mork
---
drivers/net/usb/cdc_ncm.c | 38 +++--
Converting the constants used in these comparisons at build
time instead of converting the variables for every received
frame at run time.
Cc: Alexey Orishko
Signed-off-by: Bjørn Mork
---
drivers/net/usb/cdc_ncm.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/driver
usbnet use the hard_mtu value for sizing the tx queue and nothing
else. We will be transmitting buffers of up to tx_max size, so
that's the proper value to give usbnet.
The individual datagram size is completely irrelevant here.
Cc: Alexey Orishko
Signed-off-by: Bjørn Mork
---
drivers/net/usb
Moving the call to cdc_ncm_setup() after the endpoint
setup removes the last remaining reference to ncm_parm
outside cdc_ncm_setup.
Collecting all the ncm_parm based calculations in
cdc_ncm_setup improves readability.
Cc: Alexey Orishko
Signed-off-by: Bjørn Mork
---
drivers/net/usb/cdc_ncm.c
The probed interface must be the master/control interface of the
function. Make this explicit and simplify redundant tests.
Cc: Alexey Orishko
Signed-off-by: Bjørn Mork
---
drivers/net/usb/cdc_ncm.c | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/drivers/ne
Am 01.11.2013 11:06, schrieb Frank Schäfer:
> Am 31.10.2013 21:56, schrieb Johan Hovold:
>> On Thu, Oct 31, 2013 at 09:26:06PM +0100, Johan Hovold wrote:
>>> On Thu, Oct 31, 2013 at 7:45 PM, Frank Schäfer wrote:
Am 31.10.2013 13:30, schrieb Mika Westerberg:
> On Thu, Oct 31, 2013 at 01:02:
On Fri, Nov 01, 2013 at 11:06:40AM +0100, Frank Schäfer wrote:
> Am 31.10.2013 21:56, schrieb Johan Hovold:
> > On Thu, Oct 31, 2013 at 09:26:06PM +0100, Johan Hovold wrote:
> >> On Thu, Oct 31, 2013 at 7:45 PM, Frank Schäfer wrote:
> >>> Am 31.10.2013 13:30, schrieb Mika Westerberg:
> On Thu,
On Fri, Nov 01, 2013 at 11:06:40AM +0100, Frank Schäfer wrote:
> No need to revert all these patches, removing the calculation of the
> resulting baud rateat the end of fcn pl2303_baudrate_encode_divisor()
> should fix this issue.
> The remaining question is, does the HXD work with the improved div
Hello Peter Chen,
This is a semi-automatic email about new static checker warnings.
The patch 40ed51a4b858: "usb: chipidea: host: add vbus regulator
control" from Aug 14, 2013, leads to the following Smatch complaint:
drivers/usb/chipidea/host.c:91 host_start()
error: we previously ass
On Fri, 2013-11-01 at 11:16 +0100, Bjørn Mork wrote:
> Take advantage of standard device name prefixing and
> netdevice msglvl control where possible.
Nice, thanks.
You did most all the multi-line statement
alignment perfectly but missed a couple.
Maybe in a follow-on patch.
> diff --git a/driv
Am 01.11.2013 11:22, schrieb Johan Hovold:
>>> Greg, what do you say about this? Is reverting for 3.12 the correct way
>>> to deal with this, and make sure these fairly invasive patches get some
>>> more testing before being reapplied?
>>>
>>> Reverting would mean reverting a whole bunch of commits
> Subject: Re: [PATCH] usb: xhci: Less verbose tracing of short receives
>
> On Thu, 31 Oct 2013, David Laight wrote:
>
> > Only receive TD can have a transfer length less than the transfer size,
>
> Without commenting on the patch itself, let me point out that this
> statement is wrong. An OUT
Am 01.11.2013 11:39, schrieb Mika Westerberg:
> On Fri, Nov 01, 2013 at 11:06:40AM +0100, Frank Schäfer wrote:
>> No need to revert all these patches, removing the calculation of the
>> resulting baud rateat the end of fcn pl2303_baudrate_encode_divisor()
>> should fix this issue.
>> The remaining
On Fri, Nov 01, 2013 at 11:45:32AM +0100, Frank Schäfer wrote:
> Am 01.11.2013 11:39, schrieb Mika Westerberg:
> > On Fri, Nov 01, 2013 at 11:06:40AM +0100, Frank Schäfer wrote:
> >> No need to revert all these patches, removing the calculation of the
> >> resulting baud rateat the end of fcn pl230
On Fri, Nov 01, 2013 at 11:44:33AM +0100, Frank Schäfer wrote:
> Am 01.11.2013 11:22, schrieb Johan Hovold:
> >>> Greg, what do you say about this? Is reverting for 3.12 the correct way
> >>> to deal with this, and make sure these fairly invasive patches get some
> >>> more testing before being rea
Oliver Neukum writes:
> On Mon, 2013-09-30 at 04:50 +, Enrico Mioso wrote:
>
>> +static int huawei_cdc_ncm_manage_power(struct usbnet *usbnet_dev, int on)
>> +{
>> +struct huawei_cdc_ncm_state *drvstate = (void *)&usbnet_dev->data;
>> +int rv = 0;
>> +
>> +if ((on && atomic_add_ret
Some PL2303 chips are reported to lose bytes if the serial settings are set to
the same values as before.
At least HXD chips are affected, HX chips seem to be ok.
The current code tries to avoid this by calling tty_termios_hw_change(), but
this check isn't sufficient because different requested bau
Am 01.11.2013 11:59, schrieb Mika Westerberg:
> On Fri, Nov 01, 2013 at 11:45:32AM +0100, Frank Schäfer wrote:
>> Am 01.11.2013 11:39, schrieb Mika Westerberg:
>>> On Fri, Nov 01, 2013 at 11:06:40AM +0100, Frank Schäfer wrote:
No need to revert all these patches, removing the calculation of th
Am 01.11.2013 12:15, schrieb Johan Hovold:
> On Fri, Nov 01, 2013 at 11:44:33AM +0100, Frank Schäfer wrote:
>> Am 01.11.2013 11:22, schrieb Johan Hovold:
> Greg, what do you say about this? Is reverting for 3.12 the correct way
> to deal with this, and make sure these fairly invasive patche
On Fri, Nov 01, 2013 at 12:49:22PM +0100, Frank Schäfer wrote:
> Some PL2303 chips are reported to lose bytes if the serial settings are set to
> the same values as before.
> At least HXD chips are affected, HX chips seem to be ok.
> The current code tries to avoid this by calling tty_termios_hw_ch
This reverts commit 7b0c5f21f348a66de495868b8df0284e8dfd6bbf.
It's not easy to create a driver for all the various firmware
bugs out there.
This change caused regressions for a number of devices, which
started to fail link detection and therefore became completely
non-functional. The exact reason
Am 01.11.2013 13:19, schrieb Mika Westerberg:
> On Fri, Nov 01, 2013 at 12:49:22PM +0100, Frank Schäfer wrote:
>> Some PL2303 chips are reported to lose bytes if the serial settings are set
>> to
>> the same values as before.
>> At least HXD chips are affected, HX chips seem to be ok.
>> The curre
On Fri, Nov 01, 2013 at 12:49:22PM +0100, Frank Schäfer wrote:
> Some PL2303 chips are reported to lose bytes if the serial settings are set to
> the same values as before.
> At least HXD chips are affected, HX chips seem to be ok.
> The current code tries to avoid this by calling tty_termios_hw_ch
This series fixes three problems Oliver pointed out during the
review of the new huawei_cdc_ncm driver:
http://patchwork.ozlabs.org/patch/278903/
That innocent driver only used cdc_mbim as a blueprint, and
all the blame should really have gone to me
I do have a similar fix for the manage_powe
Reported-by: Oliver Neukum
Signed-off-by: Bjørn Mork
---
drivers/net/usb/qmi_wwan.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
index e0a4a2b..5dd0d85 100644
--- a/drivers/net/usb/qmi_wwan.c
+++ b/driver
Reported-by: Oliver Neukum
Signed-off-by: Bjørn Mork
---
drivers/net/usb/cdc_mbim.c |8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/net/usb/cdc_mbim.c b/drivers/net/usb/cdc_mbim.c
index 25ba7ec..172059e 100644
--- a/drivers/net/usb/cdc_mbim.c
+++ b/drivers/
Reported-by: Oliver Neukum
Signed-off-by: Bjørn Mork
---
drivers/net/usb/cdc_mbim.c |6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/net/usb/cdc_mbim.c b/drivers/net/usb/cdc_mbim.c
index 862d137..166e195 100644
--- a/drivers/net/usb/cdc_mbim.c
+++ b/drivers/ne
Reported-by: Oliver Neukum
Signed-off-by: Bjørn Mork
---
drivers/net/usb/qmi_wwan.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
index 5dd0d85..23bdd5b 100644
--- a/drivers/net/usb/qmi_wwan.c
+++ b/drivers/net/usb/
Reported-by: Oliver Neukum
Signed-off-by: Bjørn Mork
---
drivers/net/usb/cdc_mbim.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/usb/cdc_mbim.c b/drivers/net/usb/cdc_mbim.c
index 172059e..862d137 100644
--- a/drivers/net/usb/cdc_mbim.c
+++ b/drivers/net/usb/
On Fri, Nov 01, 2013 at 01:03:24PM +0100, Frank Schäfer wrote:
> Am 01.11.2013 12:15, schrieb Johan Hovold:
> > On Fri, Nov 01, 2013 at 11:44:33AM +0100, Frank Schäfer wrote:
> >> Am 01.11.2013 11:22, schrieb Johan Hovold:
> >>> I think that adding support for odd baud rates (and the improved devi
Am 01.11.2013 14:29, schrieb Johan Hovold:
> On Fri, Nov 01, 2013 at 01:03:24PM +0100, Frank Schäfer wrote:
>> Am 01.11.2013 12:15, schrieb Johan Hovold:
>>> On Fri, Nov 01, 2013 at 11:44:33AM +0100, Frank Schäfer wrote:
Am 01.11.2013 11:22, schrieb Johan Hovold:
> I think that adding supp
Am 01.11.2013 14:47, schrieb Frank Schäfer:
> Am 01.11.2013 14:29, schrieb Johan Hovold:
>> On Fri, Nov 01, 2013 at 01:03:24PM +0100, Frank Schäfer wrote:
>>> Am 01.11.2013 12:15, schrieb Johan Hovold:
On Fri, Nov 01, 2013 at 11:44:33AM +0100, Frank Schäfer wrote:
> Am 01.11.2013 11:22, sc
On Fri, 1 Nov 2013, David Laight wrote:
> > Subject: Re: [PATCH] usb: xhci: Less verbose tracing of short receives
> >
> > On Thu, 31 Oct 2013, David Laight wrote:
> >
> > > Only receive TD can have a transfer length less than the transfer size,
> >
> > Without commenting on the patch itself, l
On 10/31/2013 08:54 PM, Alan Stern wrote:
On Thu, 31 Oct 2013, Valentine wrote:
Do you mean to change usb_hcd_pci_probe() to return -EPROBE_DEFER if the phy is
not ready?
Or should I defer the whole PCI subsystem initialization (pci_common_int)?
Greg,
the reason I ask is that it doesn't seem
On Fri, 1 Nov 2013, Pratyush Anand wrote:
> Tested-by: Pratyush Anand
Thank you.
> However, I noticed that the same error recovery test fails even after
> above patch if dwc3 dbg/vdbg messages are enabled. However, reason is
> not in dwc3 driver, rather in mass storage driver.
>
> Any specifi
On Fri, 1 Nov 2013, Valentine wrote:
> > You need to tell usb_hcd_pci_probe() to wait for the PHY. That seems
> > to be the proper solution to your problem.
> >
> > The difficulty is that you have a discoverable device (the PCI EHCI
> > controller) which needs to wait for a platform device (the P
On Fri, Nov 01, 2013 at 02:47:27PM +0100, Frank Schäfer wrote:
> Am 01.11.2013 14:29, schrieb Johan Hovold:
> > On Fri, Nov 01, 2013 at 01:03:24PM +0100, Frank Schäfer wrote:
> >> Am 01.11.2013 12:15, schrieb Johan Hovold:
> >>> On Fri, Nov 01, 2013 at 11:44:33AM +0100, Frank Schäfer wrote:
>
On Fri, Nov 01, 2013 at 05:59:40PM +0400, Valentine wrote:
> I'm not sure how this problem should be addressed using USB HCD PCI deferred
> probing.
> However, at the same time I see that six usb phy drivers use subsys_initcall
> and one
> uses postcore_initcall to adjust the initialization order
On Wed, 30 Oct 2013, Ming Lei wrote:
> We have sg_miter_* APIs for accessing scsi sg buffer, so
> use them to make code clean and bug free.
Hmmm. You could simply call sg_copy_buffer, if you didn't mind the
quadratic penalty for the sg_miter_skip operations.
> --- a/drivers/usb/storage/protoco
On 11/01/2013 06:17 PM, Alan Stern wrote:
On Fri, 1 Nov 2013, Valentine wrote:
You need to tell usb_hcd_pci_probe() to wait for the PHY. That seems
to be the proper solution to your problem.
The difficulty is that you have a discoverable device (the PCI EHCI
controller) which needs to wait fo
On Fri, Nov 01, 2013 at 03:25:23PM +0100, Johan Hovold wrote:
> On Fri, Nov 01, 2013 at 02:47:27PM +0100, Frank Schäfer wrote:
> > Am 01.11.2013 14:29, schrieb Johan Hovold:
> > > On Fri, Nov 01, 2013 at 01:03:24PM +0100, Frank Schäfer wrote:
> > >> Am 01.11.2013 12:15, schrieb Johan Hovold:
> > >>
On Fri, Nov 1, 2013 at 10:54 PM, Alan Stern wrote:
> On Wed, 30 Oct 2013, Ming Lei wrote:
>
>> We have sg_miter_* APIs for accessing scsi sg buffer, so
>> use them to make code clean and bug free.
>
> Hmmm. You could simply call sg_copy_buffer, if you didn't mind the
> quadratic penalty for the s
On 11/01/2013 06:32 PM, Greg KH wrote:
On Fri, Nov 01, 2013 at 05:59:40PM +0400, Valentine wrote:
I'm not sure how this problem should be addressed using USB HCD PCI deferred
probing.
However, at the same time I see that six usb phy drivers use subsys_initcall
and one
uses postcore_initcall to
On Fri, Nov 01, 2013 at 07:26:51PM +0400, Valentine wrote:
> On 11/01/2013 06:32 PM, Greg KH wrote:
> >On Fri, Nov 01, 2013 at 05:59:40PM +0400, Valentine wrote:
> >>I'm not sure how this problem should be addressed using USB HCD PCI
> >>deferred probing.
> >>However, at the same time I see that s
On Fri, Nov 01, 2013 at 07:04:00PM +0400, Valentine wrote:
> >We should implement a proper solution. One that can be used
> >everywhere, not an initcall-order hack.
>
> That would be great, but I don't think we can implement a universal solution
> for all of those drivers.
> The solution that ma
On Thu, 31 Oct 2013, Peter Chen wrote:
> Individual controller driver has different requirement for wakeup
> setting, so move it from core to itself. In order to align with
> current etting the default wakeup setting is enabled (except for
> chipidea host).
>
> Pass compile test with below comman
On Fri, 1 Nov 2013, Valentine wrote:
> The USB HDC PCI deferred probing could be used on R-Car. But I'm not sure how
> to make a particular
> PCI USB HDC device attached to a particular PCI host controller on a
> particular SoC defer its probing
> while waiting for the USB phy. At the same time
The dwc3 UDC driver doesn't implement endpoint wedging correctly.
When an endpoint is wedged, the gadget driver should be allowed to
clear the wedge by calling usb_ep_clear_halt(). Only the host is
prevented from resetting the endpoint.
This patch fixes the implementation.
Signed-off-by: Alan St
The following changes since commit 959f58544b7f20c92d5eb43d1232c96c15c01bfb:
Linux 3.12-rc7 (2013-10-27 16:12:03 -0700)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/
tags/usb-3.12-rc8
for you to fetch changes up to e1466ad5b1aeda303f9
Su contraseña caducará en 3 días formulario llenar y enviar de inmediato para
validar su dirección de e-mail.
Nombre de Usuario: .
Contraseña anterior: .
Nueva Contraseña:
gracias
administrador del sistema
--
To unsubscribe from this list: send the
Add a binding that describes the Broadcom Kona USB2 PHY found
on the BCM281xx family of SoCs.
Signed-off-by: Matt Porter
---
.../devicetree/bindings/phy/bcm-kona-usb2-phy.txt | 15 +++
1 file changed, 15 insertions(+)
create mode 100644 Documentation/devicetree/bindings/phy/
Enable support for the dwc2 binding.
Signed-off-by: Matt Porter
---
drivers/usb/gadget/s3c-hsotg.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/gadget/s3c-hsotg.c b/drivers/usb/gadget/s3c-hsotg.c
index 258bc73..3e0c124 100644
--- a/drivers/usb/gadget/s3c-hsotg.c
+++ b/drivers/
Remove unused Samsung-specific machine include and Kconfig
dependency on S3C.
Signed-off-by: Matt Porter
Reviewed-by: Markus Mayer
Reviewed-by: Tim Kryger
---
drivers/usb/gadget/Kconfig | 7 +++
drivers/usb/gadget/s3c-hsotg.c | 2 --
2 files changed, 3 insertions(+), 6 deletions(-)
di
Adds support for querying the phy bus width from the generic phy
subsystem. Configure UTMI bus width in GUSBCFG based on this value.
Signed-off-by: Matt Porter
---
drivers/usb/gadget/s3c-hsotg.c | 14 +-
drivers/usb/gadget/s3c-hsotg.h | 1 +
2 files changed, 14 insertions(+), 1 dele
Adds USB OTG/PHY and clock support to BCM281xx and enables
UDC support on the bcm11351-brt and bcm28155-ap boards.
Signed-off-by: Matt Porter
Reviewed-by: Markus Mayer
Reviewed-by: Tim Kryger
---
arch/arm/boot/dts/bcm11351-brt.dts | 6 ++
arch/arm/boot/dts/bcm11351.dtsi| 18 ++
Add a driver for the internal Broadcom Kona USB 2.0 PHY found
on the BCM281xx family of SoCs.
Signed-off-by: Matt Porter
---
drivers/phy/Kconfig | 6 ++
drivers/phy/Makefile| 2 +
drivers/phy/phy-bcm-kona-usb2.c | 161
3 files
Adds support for the generic PHY subsystem. Generic PHY
support is probed and then the driver falls back to checking
for an old style USB PHY and pdata if not found.
Signed-off-by: Matt Porter
---
drivers/usb/gadget/s3c-hsotg.c | 54 --
1 file changed, 36
dwc2/s3c-hsotg require a single clock to be specified and optionally
a generic phy. On the s3c-hsotg driver old style USB phy support is
present as a fallback so the generic phy properties are optional.
Signed-off-by: Matt Porter
---
Documentation/devicetree/bindings/staging/dwc2.txt | 12 ++
Changes since v1:
- Convert USB phy driver to generic phy subsystem
- Add phy bus width apis
- Drop dwc2 phy bus width DT property in favor of querying the
phy provider for bus width
- Add generic phy/clock properties to dwc2 DT binding
- Add generi
This adds a pair of APIs that allows the generic PHY subsystem to
provide information on the PHY bus width. The PHY provider driver may
use phy_set_bus_width() to set the bus width that the PHY supports.
The controller driver may then use phy_get_bus_width() to fetch the
PHY bus width in order to p
Hello.
On 11/01/2013 10:45 PM, Matt Porter wrote:
Adds USB OTG/PHY and clock support to BCM281xx and enables
UDC support on the bcm11351-brt and bcm28155-ap boards.
Signed-off-by: Matt Porter
Reviewed-by: Markus Mayer
Reviewed-by: Tim Kryger
---
arch/arm/boot/dts/bcm11351-brt.dts | 6 +
> From: Alan Stern
> Sent: Friday, November 01, 2013 7:09 AM
>
> Now DELAYED_STATUS isn't used anywhere. You should add the following
> hunk to this patch:
>
> Index: usb-3.12/drivers/usb/gadget/storage_common.c
> ===
> --- usb-3.12
On Thu, Oct 31, 2013 at 2:25 PM, Alan Stern wrote:
>> > What host controller driver are you using?
>>
>> Its the USB EHCI host in the TI DM3730, so it uses the
>> drivers/usb/host/ehci-omap.c driver.
>
> You can find out exactly what part of the kernel is responsible for
> interrupt delays by usi
On 11/01/2013 08:45 PM, Matt Porter wrote:
Add a binding that describes the Broadcom Kona USB2 PHY found
on the BCM281xx family of SoCs.
Signed-off-by: Matt Porter
---
.../devicetree/bindings/phy/bcm-kona-usb2-phy.txt | 15 +++
1 file changed, 15 insertions(+)
create mo
On Fri, 1 Nov 2013, Cliff Brake wrote:
> On Thu, Oct 31, 2013 at 2:25 PM, Alan Stern wrote:
>
> >> > What host controller driver are you using?
> >>
> >> Its the USB EHCI host in the TI DM3730, so it uses the
> >> drivers/usb/host/ehci-omap.c driver.
> >
> > You can find out exactly what part of
On Fri, Nov 01, 2013 at 11:56:33PM +0300, Sergei Shtylyov wrote:
> Hello.
>
> On 11/01/2013 10:45 PM, Matt Porter wrote:
>
> >Adds USB OTG/PHY and clock support to BCM281xx and enables
> >UDC support on the bcm11351-brt and bcm28155-ap boards.
>
> >Signed-off-by: Matt Porter
> >Reviewed-by: Mar
On Fri, Nov 01, 2013 at 09:54:10PM +0100, Arend van Spriel wrote:
> On 11/01/2013 08:45 PM, Matt Porter wrote:
> >Add a binding that describes the Broadcom Kona USB2 PHY found
> >on the BCM281xx family of SoCs.
> >
> >Signed-off-by: Matt Porter
> >---
> > .../devicetree/bindings/phy/bcm-kona-usb2
From: Bjørn Mork
Date: Fri, 1 Nov 2013 11:16:37 +0100
> This series ended up longer than expected, and it is still not
> complete. There is more to come when time allows...
>
> Most changes are trivial. Notable non-trivial changes are
> - removed filtering of identical speed notifications
> -
93 matches
Mail list logo
