Re: [PATCH] USB: cdc-acm: put delayed_wb to list

2013-10-14 Thread Xiao Jin
Hi, Greg, I am sorry for the inconvenience. I will the patch format with the title v2. Thanks for the review. On Mon, 2013-10-14 at 11:10 -0700, Greg KH wrote: > On Tue, Oct 08, 2013 at 05:08:48PM +0800, Xiao Jin wrote: > > > > From: xiao jin > > > > If acm_write_start during acm suspend, writ

[PATCH v2] cdc-acm: put delayed_wb to list

2013-10-14 Thread xiao jin
If acm_write_start during acm suspend, write acm_wb is backuped to delayed_wb. When acm resume, the delayed_wb will be started. This mechanism can only record one write during acm suspend. More acm write will be abandoned. This patch is to use list_head to record the write acm_wb during acm suspen

[PATCH v2] xhci: fix usb3 streams

2013-10-14 Thread Gerd Hoffmann
Gerd, Hans, any objections to this updated patch? The warning is fixed with it. The patch probably still needs to address the case where the ring expansion fails because we can't insert the new segments into the radix tree. The patch should probably allocate the segments, attempt to add them to

Re: [PATCH v2 1/3] usb: musb: Handle nullpointer

2013-10-14 Thread Bin Liu
On Mon, Oct 14, 2013 at 5:49 PM, Felipe Balbi wrote: > On Mon, Oct 14, 2013 at 03:50:37PM +0200, Markus Pargmann wrote: >> When the device is connected to a host without a gadget driver, >> otg->gadget is NULL. >> >> Signed-off-by: Markus Pargmann >> --- >> drivers/usb/musb/musb_core.c | 3 ++- >

Re: [PATCH v2 1/3] usb: musb: Handle nullpointer

2013-10-14 Thread Bin Liu
On Mon, Oct 14, 2013 at 8:56 PM, Bin Liu wrote: > On Mon, Oct 14, 2013 at 5:49 PM, Felipe Balbi wrote: >> On Mon, Oct 14, 2013 at 03:50:37PM +0200, Markus Pargmann wrote: >>> When the device is connected to a host without a gadget driver, >>> otg->gadget is NULL. >>> >>> Signed-off-by: Markus Par

Re: [PATCH 01/11] usb: chipidea: Add power management support

2013-10-14 Thread Peter Chen
On Mon, Oct 14, 2013 at 12:01:08PM +0100, Russell King - ARM Linux wrote: > On Sat, Oct 12, 2013 at 05:35:03PM +0800, Peter Chen wrote: > > This commit adds runtime and system power management support for > > chipidea core. The runtime pm support is controlled by glue > > layer, it can be enabled b

Re: [PATCH v2 1/3] usb: musb: Handle nullpointer

2013-10-14 Thread Felipe Balbi
On Mon, Oct 14, 2013 at 09:00:33PM -0500, Bin Liu wrote: > On Mon, Oct 14, 2013 at 8:56 PM, Bin Liu wrote: > > On Mon, Oct 14, 2013 at 5:49 PM, Felipe Balbi wrote: > >> On Mon, Oct 14, 2013 at 03:50:37PM +0200, Markus Pargmann wrote: > >>> When the device is connected to a host without a gadget d

Re: [PATCH 05/11] USB: OHCI: Properly handle ohci-ep93xx suspend

2013-10-14 Thread Olof Johansson
On Mon, Oct 14, 2013 at 2:07 PM, Hartley Sweeten wrote: > On Monday, October 14, 2013 1:50 PM, Alan Stern wrote: >> On Mon, 14 Oct 2013, Hartley Sweeten wrote: >>> As an alternative to this patch, I have successfully used the ohci-platform >>> driver on the ep93xx. This does move a bit of glue cod

Re: [PATCH] extcon: palmas: Handle ID interrupt properly using USB_ID_INT_SRC

2013-10-14 Thread George Cherian
Laxman/Chanwoo/Kishon, Any comments on this!! Regards -George On 10/11/2013 12:18 AM, George Cherian wrote: Always cross check with the ID state and the source of interrupt. Also add a case in which ID Source is ID_GND but LATCH state is set wrongly. This uses the previous Link stat to determine

Re: [PATCH] usb: ohci: remove ep93xx bus glue platform driver

2013-10-14 Thread Ryan Mallon
On 15/10/13 08:35, H Hartley Sweeten wrote: > Convert ep93xx to use the OHCI platform driver and remove the > ohci-ep93xx bus glue driver. > > Signed-off-by: H Hartley Sweeten > Cc: Alan Stern > Cc: Greg Kroah-Hartman > Cc: Ryan Mallon Cc'ed Olof, who wanted to see what the patches looked lik

Re: [PATCH 2/7] usb: dwc3: adapt dwc3 core to use Generic PHY Framework

2013-10-14 Thread Kishon Vijay Abraham I
Hi Roger, On Monday 14 October 2013 03:51 PM, Roger Quadros wrote: > +Vivek > > On 10/14/2013 12:26 PM, Kishon Vijay Abraham I wrote: >> Hi Roger, >> >> On Friday 11 October 2013 08:39 PM, Roger Quadros wrote: >>> Hi, >>> >>> On 09/02/2013 06:43 PM, Kishon Vijay Abraham I wrote: Adapted dwc3

Re: [PATCH v2] xhci: fix usb3 streams

2013-10-14 Thread Hans de Goede
Hi Sarah, On 10/15/2013 03:54 AM, Gerd Hoffmann wrote: Gerd, Hans, any objections to this updated patch? The warning is fixed with it. No objections, looks good to me. The patch probably still needs to address the case where the ring expansion fails because we can't insert the new segments

[PATCH v2 1/2] usb/gadget: storage_common: use strtobool instead of kstrtouint

2013-10-14 Thread Andrzej Pietrasiewicz
strtobool is more flexible for the user and is more appropriate in the context. Signed-off-by: Andrzej Pietrasiewicz Signed-off-by: Kyungmin Park Acked-by: Michal Nazarewicz --- drivers/usb/gadget/storage_common.c | 16 1 files changed, 8 insertions(+), 8 deletions(-) diff

[PATCH v2 0/2] Fixes for mass_storage

2013-10-14 Thread Andrzej Pietrasiewicz
A short series to fix 2 issues: - use strtobool instead of kstrtouint with base 2 for: ro, nofua, cdrom, removable attrs (better fits the context and more flexible to users) - setting a lun to be cdrom implies read-only and succeeds only if the lun is not open v1..v2: - fixes after Michal's r

[PATCH v2 2/2] usb/gadget: storage_common: pass filesem to fsg_store_cdrom

2013-10-14 Thread Andrzej Pietrasiewicz
If cdrom flag is set ro flag is implied. Try setting the ro first, and only if it succeeds set the cdrom flag. Signed-off-by: Andrzej Pietrasiewicz Signed-off-by: Kyungmin Park Acked-by: Michal Nazarewicz --- drivers/usb/gadget/f_mass_storage.c |7 +- drivers/usb/gadget/storage_common.

Re: [PATCH 0/2] Fixes for mass_storage

2013-10-14 Thread Andrzej Pietrasiewicz
W dniu 15.10.2013 00:48, Felipe Balbi pisze: Hi, On Mon, Oct 14, 2013 at 11:21:45AM +0200, Andrzej Pietrasiewicz wrote: A short series to fix 2 issues: - use strtobool instead of kstrtouint with base 2 for: ro, nofua, cdrom, removable attrs (better fits the context and more flexible to users)

[PATCH v2 0/2] Adapt phy-omap-usb2 for AM437x platform

2013-10-14 Thread George Cherian
This series adapts the phy-omap-usb2 generic phy driver for AM437x. While at that arrange the include files alphabetically (PATCH 1) V2 of 2nd Patch which fixes the following from v1 - List comaptible entries in Documentaion - Add usb_phy_data instead of checking compatible each tim

Re: [PATCH 1/1] ARM: dts: omap3: Adapt USB OTG to generic PHY framework

2013-10-14 Thread Benoit Cousson
Hi Roger, On 14/10/2013 11:20, Roger Quadros wrote: Hi Benoit, On 10/10/2013 06:34 PM, Felipe Balbi wrote: On Mon, Oct 07, 2013 at 04:28:13PM +0300, Roger Quadros wrote: The generic PHY framewrok expects different properties than the old USB PHY framework. Supply those properties. Fixes USB

[PATCH v2 1/2] phy: omap-usb2: Arrange the include in alphabetical order

2013-10-14 Thread George Cherian
This patch arranges the includes in alphabetical order Signed-off-by: George Cherian --- drivers/phy/phy-omap-usb2.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/phy/phy-omap-usb2.c b/drivers/phy/phy-omap-usb2.c index bfc5c33..3e5f08c 100644 ---

[PATCH v2 2/2] phy: omap-usb2: Adapt phy-omap-usb2 for AM437x

2013-10-14 Thread George Cherian
This patch adds a compatible for AM437x "ti,am43xx-usb2" to reuse the same phy-omap-usb2 driver. Also updated the documentation to add the new compatible. Signed-off-by: George Cherian --- Documentation/devicetree/bindings/usb/usb-phy.txt | 4 +- drivers/phy/phy-omap-usb2.c

<    1   2