Re: Need testers for long-standing xHCI clear halt bug

Hi Sarah, I built: - current kernel git with SUSE config - libgphoto2 with the clear_halt reenabled - rebooted gphoto2 now hangs on the second try - only applied both patches referenced. I need to whack them a bit as xhci_giveback_urb_in_irq got a new parameter - rebuilt, rebooted gphoto2

[PATCH 05/12] usb: phy-mxs: Add implementation of nofity_suspend and notify_resume

Add notify_suspend and notify_resume according to different SoCs. Signed-off-by: Peter Chen --- drivers/usb/phy/phy-mxs-usb.c | 73 + 1 files changed, 73 insertions(+), 0 deletions(-) diff --git a/drivers/usb/phy/phy-mxs-usb.c b/drivers/usb/phy/phy-mxs-

[PATCH 08/12] usb: phy-mxs: Add system suspend/resume API

We need this to keep PHY's power on or off during the system suspend mode. If we need to enable USB wakeup, then we must keep PHY's power being on during the system suspend mode. Otherwise, we need to keep PHY's power being off to save power. Signed-off-by: Peter Chen --- drivers/usb/phy/phy-mxs

[PATCH 01/12] usb: phy-mxs: Add auto clock and power setting

With the auto setting, the PHY's clock and power can be recovered correctly from low power mode, it is ganranteed by IC logic. Signed-off-by: Peter Chen --- drivers/usb/phy/phy-mxs-usb.c | 20 +--- 1 files changed, 17 insertions(+), 3 deletions(-) diff --git a/drivers/usb/phy/

[PATCH 06/12] usb: phy: Add set_wakeup API

This API is used to set wakeup enable at PHY registers, in that case, the PHY can be waken up from suspend due to external events, like vbus change, dp/dm change and id change. Signed-off-by: Peter Chen --- include/linux/usb/phy.h | 16 1 files changed, 16 insertions(+), 0 del

[PATCH 07/12] usb: phy-mxs: Add implementation of set_wakeup

When we need the PHY can be waken up by external signals, we can call this API. Besides, we call mxs_phy_disconnect_line at this API to close the connection between USB PHY and controller, after that, the line state from controller is SE0. Once the PHY is out of power, without calling mxs_phy_disco

[PATCH 03/12] usb: phy-mxs: Add anatop regmap

It is needed by mx6 SoC serial, but not for mx23 and mx28. Signed-off-by: Peter Chen --- drivers/usb/phy/phy-mxs-usb.c | 17 - 1 files changed, 16 insertions(+), 1 deletions(-) diff --git a/drivers/usb/phy/phy-mxs-usb.c b/drivers/usb/phy/phy-mxs-usb.c index 831b13e..e0b0de0 10

[PATCH 04/12] usb: phy: add notify suspend and resume callback

They are used to notify PHY that the controller enters suspend or finishes resume. Signed-off-by: Peter Chen --- include/linux/usb/phy.h | 23 +++ 1 files changed, 23 insertions(+), 0 deletions(-) diff --git a/include/linux/usb/phy.h b/include/linux/usb/phy.h index 6c0b1c5

[PATCH 02/12] usb: phy-mxs: Enable IC fixes for mx6 SoC serial

After adding IC fixes bits, some PHY bugs are fixed by IC logic. Signed-off-by: Peter Chen --- drivers/usb/phy/phy-mxs-usb.c | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/drivers/usb/phy/phy-mxs-usb.c b/drivers/usb/phy/phy-mxs-usb.c index 87ba429..831b13e 100

[PATCH 00/12] Add power management support for MXS PHY

Hi Felipe, The serial adds power management support for MXS PHY, it includes: - Add three common PHY API, .set_wakeup, .notify_suspend, notify_resume. - Related above API implementation at mxs phy driver - misc changes for mxs phy to support low power mode and wakeup. Hi Shawn, The last four ar

[PATCH 10/12] ARM: dts: imx6: add anatop phandle for usbphy

Add anatop phandle for usbphy Signed-off-by: Peter Chen --- arch/arm/boot/dts/imx6qdl.dtsi |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi index ef51342..145ece2 100644 --- a/arch/arm/boot/dts/imx6qdl.dtsi

[PATCH 09/12] usb: phy-mxs: update binding for adding anatop phandle

Add anatop phandle which is used to access anatop registers to control PHY's power and other USB operations. Signed-off-by: Peter Chen --- Documentation/devicetree/bindings/usb/mxs-phy.txt |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/Documentation/devicetree/bindings

[PATCH 12/12] ARM: dts: imx6: Add disconnect_line_without_vbus property for usbphy

When the vbus is not there and the PHY is out of power, we need to disconnect connection between USB PHY and USB controller, otherwise the unexpected USB wakeup will occur due to dp/dm change at device mode. Signed-off-by: Peter Chen --- arch/arm/boot/dts/imx6qdl.dtsi |1 + 1 files changed,

[PATCH 11/12] usb: phy-mxs: update binding for adding disconnect line property

This property is used to disconnect line between USB PHY and USB controller. Signed-off-by: Peter Chen --- Documentation/devicetree/bindings/usb/mxs-phy.txt |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/Documentation/devicetree/bindings/usb/mxs-phy.txt b/Documentat

Re: [PATCH v3] usb-serial: Moxa UPORT 12XX/14XX/16XX driver

On Wed, Oct 09, 2013 at 12:57:45PM +0200, Johan Hovold wrote: > On Wed, Sep 25, 2013 at 11:53:00AM +0200, Andrew Lunn wrote: > > TODO > > Custom resume function > > You have to implement a custom resume function as usb-serial will use > the incompatible generic one otherwise. Model it after the g

Re: [PATCH 02/12] usb: phy-mxs: Enable IC fixes for mx6 SoC serial

Hi, > After adding IC fixes bits, some PHY bugs are fixed by > IC logic. Can you please elaborate what those bits do exactly ? They seem like a magic stuff to me thus far, which is not exactly helpful . I can't find them in the datasheet either. > Signed-off-by: Peter Chen > --- > drivers/us

Re: [PATCH 05/12] usb: phy-mxs: Add implementation of nofity_suspend and notify_resume

Dear Peter Chen, > Add notify_suspend and notify_resume according to different SoCs. > > Signed-off-by: Peter Chen > --- > drivers/usb/phy/phy-mxs-usb.c | 73 > + 1 files changed, 73 > insertions(+), 0 deletions(-) > > diff --git a/drivers/usb/phy/phy-m

Re: [PATCH 07/12] usb: phy-mxs: Add implementation of set_wakeup

Dear Peter Chen, > When we need the PHY can be waken up by external signals, > we can call this API. Besides, we call mxs_phy_disconnect_line > at this API to close the connection between USB PHY and > controller, after that, the line state from controller is SE0. > Once the PHY is out of power, w

Re: [PATCH 11/12] usb: phy-mxs: update binding for adding disconnect line property

Dear Peter Chen, > This property is used to disconnect line between USB PHY and > USB controller. > > Signed-off-by: Peter Chen > --- > Documentation/devicetree/bindings/usb/mxs-phy.txt |4 > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/Documentation/devicetree/bi

[PATCH 01/11] usb: chipidea: Add power management support

This commit adds runtime and system power management support for chipidea core. The runtime pm support is controlled by glue layer, it can be enabled by flag CI_HDRC_SUPPORTS_RUNTIME_PM. Signed-off-by: Peter Chen --- drivers/usb/chipidea/ci.h|2 + drivers/usb/chipidea/core.c | 119

[PATCH 00/11] Add power management support for chipidea

Hi Greg, This serial adds power management (system & runtime) for chipidea core. With this, the chipidea controller can be at low power mode when it is not in use, and the chipidea controller can be the system wakeup source. It needs to depend on my patch[1], since [1] adds some common PHY APIs,

[PATCH 04/11] usb: chipidea: add wakeup interrupt handler

When the controller is at suspend mode, it can be waken up by external events (like vbus, dp/dm or id change). Once we receive the wakeup interrupt, we need to resume the controller first, eg open clocks, disable some wakeup settings, etc. After that, the controller can receive the normal USB inter

[PATCH 03/11] usb: chipidea: usbmisc_imx: remove the controller's clock information

Currently, the usbmisc is just an API supplier for controller driver, the controller calls related APIs to handle different things among the SoCs, before calling it, the clock must be on. So the clock operation is useless for usbmisc, it also increases the difficulties to manage the clock, especial

[PATCH 08/11] usb: chipidea: host: add ehci quirk for imx controller

When the port goes to suspend or finishes resme, it needs to notify PHY, it is not a standard EHCI operation, so we add a quirk for it. Signed-off-by: Peter Chen --- drivers/usb/chipidea/host.c | 129 ++ include/linux/usb/chipidea.h |1 + 2 files cha

[PATCH 10/11] usb: chipidea: imx: add binding for supporting runtime pm

Add property for supporting runtime power management Signed-off-by: Peter Chen --- .../devicetree/bindings/usb/ci13xxx-imx.txt|2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/Documentation/devicetree/bindings/usb/ci13xxx-imx.txt b/Documentation/devicetree/bindin

[PATCH 07/11] usb: chipidea: host: add quirk for ehci operation

For chipidea controller, it does not follow ehci spec strictly. Taking resume signal as an example, it will stop resume signal about 20-21ms later automatically, but standard ehci spec says, the resume signal is controlled by software (clear portsc.PORT_RESUME). This operation causes some remote w

[PATCH 06/11] usb: chipidea: imx: call set_wakeup when necessary

- Disable wakeup after probe - Enable wakeup during the suspend - Disable wakeup after controller is active Signed-off-by: Peter Chen --- drivers/usb/chipidea/ci_hdrc_imx.c | 36 1 files changed, 36 insertions(+), 0 deletions(-) diff --git a/drivers/usb/ch

[PATCH 09/11] usb: chipidea: imx: Enable CI_HDRC_IMX_EHCI_QUIRK if the phy has notify APIs

If the PHY has .notify_suspend and .notify_resume, it means this imx usb controller needs to add quirks for standard ehci routine. Signed-off-by: Peter Chen --- drivers/usb/chipidea/ci_hdrc_imx.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/drivers/usb/chipidea/ci

[PATCH 02/11] usb: chipidea: imx: add power management support

Add system and runtime power management support for imx gluy layer. Signed-off-by: Peter Chen --- drivers/usb/chipidea/ci_hdrc_imx.c | 99 ++- 1 files changed, 96 insertions(+), 3 deletions(-) diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c b/drivers/usb/chipi

[PATCH 11/11] ARM: dts: imx6qdl-sabresd: Enable runtime pm for usbotg and usb host 1

Enable runtime power management support for usbotg and usb host 1. Signed-off-by: Peter Chen --- arch/arm/boot/dts/imx6qdl-sabresd.dtsi |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi index

[PATCH 05/11] usb: chipidea: usbmisc_imx: add set_wakup API

It is used to enable USB wakeup Signed-off-by: Peter Chen --- drivers/usb/chipidea/ci_hdrc_imx.h |1 + drivers/usb/chipidea/usbmisc_imx.c | 41 2 files changed, 42 insertions(+), 0 deletions(-) diff --git a/drivers/usb/chipidea/ci_hdrc_imx.h b/drivers

Re: When USB PHY framework should be used?

Hi, On Friday 11 October 2013 10:52 PM, Arokux X wrote: >> I think you should have a wrapper driver to EHCI/OHCI to handle this reset. > > Thank you Kishon and Peter for the quick replies. Is there any good > example of such a wrapper driver in the kernel already? can you explain how your IP act

[PATCH 1/1] drivers: usb: core: devio.c: Coding style fixes

Whitespace fixes, including: - Whitespace after if-keyword - Spaces to Tabs Other coding style fixes: - Added braces for if-else blocks where missing Signed-off-by: Matthias Beyer --- drivers/usb/core/devio.c | 40 +--- 1 file changed, 21 insertions(+), 19

[PATCH 1/1] drivers: usb: core: devio.c: Braces around switch (updated)

Added braces around switch statement as the styleguide tells us. Indented the switch-block for it and split a function call (driver->unlocked_ioctl() on line 1876) arguments to several lines to fit the 80-column convention. Signed-off-by: Matthias Beyer --- drivers/usb/core/devio.c | 63

Re: LTE vodafone K5150 (hilink) 12d1 1f16 ; 12d1 1575 cdc_ether mbim?

Thomas Schäfer writes: > Am Samstag, 12. Oktober 2013, 00:13:59 schrieb Bjørn Mork: >> Thomas Schäfer writes: >> > Bjørn writes: >> >> Could be the driver. I don't know if it is ever tested with IPv6, and >> >> it does a bit of header magic so it is possible to screw up. Of course, >> >> the sa

Re: LTE vodafone K5150 (hilink) 12d1 1f16 ; 12d1 1575 cdc_ether mbim?

Bjørn Mork writes: > Do those packets (the RA and NS from the firmware) show up in a normal > IP packet dump from the wwan interface? Do you see any replies? I > guess you don't. We set NOARP on the interface because MBIM really > doesn't have any L2 headers. But here we see that the firmware

Re: [PATCH] usbnet: fix error return code in usbnet_probe()

On Sat, 2013-10-12 at 14:24 +0800, Wei Yongjun wrote: > From: Wei Yongjun > > Fix to return -ENOMEM in the padding pkt alloc fail error handling > case instead of 0, as done elsewhere in this function. > > Signed-off-by: Wei Yongjun Acked-by: Oliver Neukum -- To unsubscribe from this list: s

Re: LTE vodafone K5150 (hilink) 12d1 1f16 ; 12d1 1575 cdc_ether mbim?

Am Samstag, 12. Oktober 2013, 13:46:19 schrieb Bjørn Mork: > > happens: > > ifconfig wwan0 arp > > Nope, that won't make any difference. At least on a proper ethernet > interface we still answer NS for our addresses, even if we disable > sending them. > > So the questions still are: Do you se

Re: [PATCH 10/11] usb: chipidea: imx: add binding for supporting runtime pm

On Sat, 12 Oct 2013, Peter Chen wrote: > Add property for supporting runtime power management > > Signed-off-by: Peter Chen > --- > .../devicetree/bindings/usb/ci13xxx-imx.txt|2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/Documentation/devicetree/binding

Re: [PATCH 11/12] usb: phy-mxs: update binding for adding disconnect line property

Dear Peter Chen, On Sat, 12 Oct 2013 17:09:45 +0800, Peter Chen wrote: > This property is used to disconnect line between USB PHY and > USB controller. > > Signed-off-by: Peter Chen > --- > Documentation/devicetree/bindings/usb/mxs-phy.txt |4 > 1 files changed, 4 insertions(+), 0 dele

Re: [PATCH 1/1] drivers: usb: core: devio.c: Coding style fixes

Hello. On 12-10-2013 13:01, Matthias Beyer wrote: Whitespace fixes, including: - Whitespace after if-keyword - Spaces to Tabs Other coding style fixes: - Added braces for if-else blocks where missing Signed-off-by: Matthias Beyer --- drivers/usb/core/devio.c | 40

Re: LTE vodafone K5150 (hilink) 12d1 1f16 ; 12d1 1575 cdc_ether mbim?

Am Samstag, 12. Oktober 2013, 13:46:19 schrieben Sie: > So the questions still are: Do you see those solicitatins going from the > driver to the IP layer? And do you see any Neighbor Advertisement > replies from the IP layer? If the respective answers are yes/no, then > you should look elsewhere

USB regression in v3.12-rc4

Hi, With v3.12-rc4 I can no longer connect to N800 (OMAP2) with USB (peripheral, g_ether). According to git bisect this is caused by: 9b0a1de3c85d99d881c86a29b3d52da7b9c7bd61 is the first bad commit commit 9b0a1de3c85d99d881c86a29b3d52da7b9c7bd61 Author: Bin Liu Date: Tue Sep 17 15:33:35 2013

Re: USB regression in v3.12-rc4

Hi, On Sun, Oct 13, 2013 at 12:46:18AM +0300, Aaro Koskinen wrote: > With v3.12-rc4 I can no longer connect to N800 (OMAP2) with USB > (peripheral, g_ether). To clarify, I was running v3.12-rc4 on N800/peripheral side and that's where the problem is; on host side I'm running some old Debian kerne