Re: some questions about ehci period scheduling

2013-09-24 Thread vichy
hi Alan: > > BTW, I have another question about iso_stream_schedule. > > When if (likely (!list_empty (&stream->td_list))) happen, > > why don't we just take last scheduled microframe, stream->next_uframe > > as start point directly? > > We do exactly that if URB_ISO_ASAP isn't set. But first th

Re: [PATCH v3 3/6] uas: make work list per-device

2013-09-24 Thread Christoph Hellwig
On Wed, Sep 18, 2013 at 09:33:04AM +0200, Gerd Hoffmann wrote: > > > While being at it rename the list head from "list" to "work", preparing > > > for the addition of a second list. > > > > Why do you even the list? > > The list was already there when I took over maintainance ... > > > What woul

[PATCH v3 03/10] ARM: OMAP2+: omap-usb-host: Get rid of platform_data from struct usbhs_phy_data

2013-09-24 Thread Roger Quadros
The platform data bits can be inferred from the other members of struct usbhs_phy_data. So get rid of the platform_data member. Build the platform data for the PHY device in usbhs_init_phys() instead. Signed-off-by: Roger Quadros --- arch/arm/mach-omap2/board-omap3beagle.c |6 -- arch/a

[PATCH v3 09/10] ARM: dts: omap3-beagle-xm: Add USB Host support

2013-09-24 Thread Roger Quadros
Provide RESET GPIO and Power regulator for the USB PHY, the USB Host port mode and the PHY device for the controller. Also provide pin multiplexer information for USB host pins. We also relocate omap3_pmx_core pin definations so that they are close to omap3_pmx_wkup pin definations. Signed-off-by

[PATCH v3 07/10] ARM: dts: omap5-uevm: Use reset-gpios for hsusb2/3_reset

2013-09-24 Thread Roger Quadros
We no longer need to model the RESET line as a regulator since the USB phy-nop driver accepts "reset-gpios" property. Signed-off-by: Roger Quadros --- arch/arm/boot/dts/omap5-uevm.dts | 26 ++ 1 files changed, 2 insertions(+), 24 deletions(-) diff --git a/arch/arm/boot

[PATCH v3 10/10] ARM: dts: omap3-beagle: Add USB OTG PHY details

2013-09-24 Thread Roger Quadros
Add information about the USB OTG PHY. Without this the OTG port on beagle will not work. Signed-off-by: Roger Quadros --- arch/arm/boot/dts/omap3-beagle.dts |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/arch/arm/boot/dts/omap3-beagle.dts b/arch/arm/boot/dts/oma

[PATCH v3 08/10] ARM: dts: omap3-beagle: Make USB host pin naming consistent

2013-09-24 Thread Roger Quadros
Use a common naming scheme "mode0name.modename flags" for the USB host pins to be consistent. Signed-off-by: Roger Quadros --- arch/arm/boot/dts/omap3-beagle.dts | 24 1 files changed, 12 insertions(+), 12 deletions(-) diff --git a/arch/arm/boot/dts/omap3-beagle.dts

[PATCH v3 04/10] ARM: OMAP2+: usb-host: Adapt to USB phy-nop RESET line changes

2013-09-24 Thread Roger Quadros
The USB phy-nop nop driver expects the RESET line information to be sent as a GPIO number via platform data. Adapt to that. Signed-off-by: Roger Quadros --- arch/arm/mach-omap2/usb-host.c | 11 +-- 1 files changed, 1 insertions(+), 10 deletions(-) diff --git a/arch/arm/mach-omap2/usb-

[PATCH v3 01/10] usb: phy: generic: Add gpio_reset to platform data

2013-09-24 Thread Roger Quadros
The GPIO number of the RESET line can be passed to the driver using the gpio_reset member. Signed-off-by: Roger Quadros --- include/linux/usb/usb_phy_gen_xceiv.h |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/include/linux/usb/usb_phy_gen_xceiv.h b/include/linux/usb/

[PATCH v3 06/10] ARM: dts: omap4-panda: Use reset-gpios for hsusb1_reset

2013-09-24 Thread Roger Quadros
We no longer need to model the RESET line as a regulator since the USB phy-nop driver accepts "reset-gpios" property. Signed-off-by: Roger Quadros --- arch/arm/boot/dts/omap4-panda-common.dtsi | 18 +- 1 files changed, 1 insertions(+), 17 deletions(-) diff --git a/arch/arm/boo

[PATCH v3 00/10] USB: phy: phy-nop: Manage RESET GPIO in the driver

2013-09-24 Thread Roger Quadros
Hi, Modelling the RESET line as a regulator supply wasn't a good idea as it abuses the regulator framework and makes adaptation code/data more complex. Instead, manage the RESET gpio line directly in the driver. This also makes us easy to migrate to a dedicated GPIO RESET controller whenever it

[PATCH v3 02/10] usb: phy: generic: Don't use regulator framework for RESET line

2013-09-24 Thread Roger Quadros
Modelling the RESET line as a regulator supply wasn't a good idea as it kind of abuses the regulator framework and also makes adaptation code more complex. Instead, manage the RESET gpio line directly in the driver. Update the device tree binding information. This also makes us easy to migrate to

[PATCH v3 05/10] ARM: dts: omap3-beagle: Use reset-gpios for hsusb2_reset

2013-09-24 Thread Roger Quadros
We no longer need to model the RESET line as a regulator since the USB phy-nop driver accepts "reset-gpios" property. Signed-off-by: Roger Quadros --- arch/arm/boot/dts/omap3-beagle.dts | 13 + 1 files changed, 1 insertions(+), 12 deletions(-) diff --git a/arch/arm/boot/dts/omap3-

[PATCH] USB: gadget: s3c-hsotg: fix can_write limit for non-periodic endpoints

2013-09-24 Thread Robert Baldyga
Value of can_write variable in s3c_hsotg_write_fifo function should be limited to 512 only for non-periodic endpoints. There was some discrepancy between comment and code, becouse comment suggests correct behavior, but in the code limit was applied to periodic endpoints too. So there is additional

Re: [PATCH v2 1/1] usb: gadget: f_fs: Add support for SuperSpeed Mode

2013-09-24 Thread Manu Gautam
Hi Felipe, I wanted to mention one point with respect to this patch: Below changes in the functionfs.h to add ss_count (super speed descriptors count) in desc_header (which is passed from userspace) make the driver incompatible with existing userspace applications compiled against old header f

USB/IP: sharing USB device disappearing at client side

2013-09-24 Thread Gonglei (Arei)
Hi, On KVM platform, I try to share an USB Mass Storage device from On host SUSE11SP2/usbip 1.1.1 (linux-3.11.1-stable)server to another host SUSE11SP2/usbip 1.1.1 client, creation of tunnel is successful: the drive shows up in lsusb on client. When I attach the usb device to a VM on the client

[PATCH v2] USB: gadget: s3c-hsotg: add isochronous transfers support

2013-09-24 Thread Robert Baldyga
Hello, This is update for my proposal for isochronous transfers support in s3c-hsotg driver. I've fixed issuses pointed by Bartlomiej Zolnierkiewicz. For more information, please check the change log at the end of the mail. This patch adds isochronous transfer support. It adds few modifications:

Re: [PATCH] hid-elo: some systems cannot stomach work around

2013-09-24 Thread Jiri Kosina
On Mon, 9 Sep 2013, oli...@neukum.org wrote: > From: Oliver Neukum > > Some systems although they have firmware class 'M', which usually > needs a work around to not crash, must not be subjected to the > work around because the work around crashes them. They cannot be > told apart by their own d

[PATCH] usb/core/devio.c: Don't reject control message to endpoint with wrong direction bit

2013-09-24 Thread Kurt Garloff
Hi, this has been discussed on linux-usb and Alan Stern provided very helpful feedback. Please merge this patch ... From: Kurt Garloff Date: Mon, 23 Sep 2013 14:19:02 +0200 Subject: Tolerate wrong direction bit in endpoint address for control messages Trying to read data from the Pegasus

Re: ehci-pci D3cold logspam

2013-09-24 Thread Alan Stern
On Mon, 23 Sep 2013, Bjorn Helgaas wrote: > d010e5769 ("PCI / ACPI: Use dev_dbg() instead of dev_info() in > acpi_pci_set_power_state()") might be part of the solution. That was > done in response to https://bugzilla.kernel.org/show_bug.cgi?id=60636, > which looks basically the same as your compl

Re: [PATCH 4/4] usb: xhci: change enumeration scheme to 'new scheme' by default

2013-09-24 Thread Alan Stern
On Mon, 23 Sep 2013, Dan Williams wrote: > Change the enumeration scheme for xhci attached devices from: > >SetAddress >GetDescriptor(8) >GetDescriptor(18) > > ...to: > >GetDescriptor(64) >SetAddress >GetDescriptor(18) > > ...as some devices misbehave when encountering

Re: [PATCH 1/4] usb: hub_activate kill an 'else'

2013-09-24 Thread Alan Stern
On Mon, 23 Sep 2013, Dan Williams wrote: > Remove a few extra lines and make it clear that all implementations > disable the port by sharing the same line of code. > > Cc: Alan Stern > Signed-off-by: Dan Williams > --- > drivers/usb/core/hub.c | 11 --- > 1 files changed, 4 insertion

Re: [PATCH v4 0/2] usb: implement AMD remote wakeup quirk

2013-09-24 Thread Alan Stern
On Tue, 24 Sep 2013, Huang Rui wrote: > Hi Sarah and Alan, > > On Mon, Sep 23, 2013 at 05:14:02PM -0700, Sarah Sharp wrote: > > On Mon, Sep 23, 2013 at 12:43:15PM -0400, Alan Stern wrote: > > > This version of the patch set looks good. > > > > > > Alan Stern > > > > Looks fine to me as well. >

Re: some questions about ehci period scheduling

2013-09-24 Thread Alan Stern
On Tue, 24 Sep 2013, vichy wrote: > hi Alan: > > > BTW, I have another question about iso_stream_schedule. > > > When if (likely (!list_empty (&stream->td_list))) happen, > > > why don't we just take last scheduled microframe, stream->next_uframe > > > as start point directly? > > > > We do exac

Re: EHCI bus glue driver works for storage, fails for a WiFi module

2013-09-24 Thread Alan Stern
On Mon, 23 Sep 2013, Arokux X wrote: > Hi, > > recently I was working on porting EHCI HCD bus glue driver from the > vendors kernel tree to the mainline [1]. I've got the storage (USB > stick and USB external hard drive) working and was happy. However it > does not work completely. Specifically s

Re: Cannot load snd-usb-audio on 3.12-rc2

2013-09-24 Thread Daniel Mack
Hi Sarah, On 24.09.2013 01:41, Sarah Sharp wrote: > The snd-usb-audio driver no longer loads properly on 3.12-rc2 when I > plug in my USB headset. It worked fine on 3.11-rc4 (not sure about > vanilla 3.11). > > Trying to manually load the driver fails: > > sarah@xanatos:~$ sudo modprobe snd-usb

Re: [PATCH v3 1/2] staging: dwc2: validate urb->actual_length for OUT endpoints

2013-09-24 Thread Felipe Balbi
Hi, On Mon, Sep 23, 2013 at 09:53:49PM +, Paul Zimmerman wrote: > > From: Felipe Balbi [mailto:ba...@ti.com] > > Sent: Monday, September 23, 2013 2:45 PM > > > > On Mon, Sep 23, 2013 at 02:23:33PM -0700, Paul Zimmerman wrote: > > > In dwc2_assign_and_init_hc(), validate urb->actual_length for

[PATCH] Remove VLAIS usage from gadget code - alternate patch

2013-09-24 Thread charlebm
From: Mark Charlebois The use of variable length arrays in structs (VLAIS) in the Linux Kernel code precludes the use of compilers which don't implement VLAIS (for instance the Clang compiler). This alternate patch calculates offsets into the kmalloc-ed memory buffer using macros. The previous pa

[PATCH] Memory mapping for USBFS

2013-09-24 Thread Markus Rechberger
This patch adds memory mapping support to USBFS for isochronous and bulk data transfers, it allows to pre-allocate usb transfer buffers. The CPU usage decreases 1-2% on my 1.3ghz U7300 notebook when transferring 20mbyte/sec, it should be more interesting to see those statistics on embedded systems

driver request

2013-09-24 Thread Alex MacPherson
Hello, Can you add the startech.com usb to serial adapter to a proper driver. I am using the command sudo modprobe usbserial vendor=0x14b0 product=0x3410 It works on my ubuntu 12.04 AMD 64 desktop system but my linux mint 15 netbook AOD270 will not get me to console into my Cisco hardwar

Re: [PATCH] Memory mapping for USBFS

2013-09-24 Thread Markus Rechberger
On Tue, Sep 24, 2013 at 9:12 PM, Markus Rechberger wrote: > This patch adds memory mapping support to USBFS for isochronous and bulk > data transfers, it allows to pre-allocate usb transfer buffers. > > The CPU usage decreases 1-2% on my 1.3ghz U7300 notebook when > transferring 20mbyte/sec, it sh

[PATCH] USB: fix substandard locking for the sysfs files

2013-09-24 Thread Alan Stern
This patch straightens out some locking issues in the USB sysfs interface: Deauthorization will destroy existing configurations. Attributes that read from udev->actconfig need to lock the device to prevent races. Likewise for the rawdescriptor values. Attr

[PATCH] USB: fix PM config symbol in uhci-hcd, ehci-hcd, and xhci-hcd

2013-09-24 Thread Alan Stern
Since uhci-hcd, ehci-hcd, and xhci-hcd support runtime PM, the .pm field in their pci_driver structures should be protected by CONFIG_PM rather than CONFIG_PM_SLEEP. The corresponding change has already been made for ohci-hcd. Without this change, controllers won't do runtime suspend if system su

[PATCH] USB: OHCI: accept very late isochronous URBs

2013-09-24 Thread Alan Stern
Commit 24f531371de1 (USB: EHCI: accept very late isochronous URBs) changed the isochronous API provided by ehci-hcd. URBs submitted too late, so that the time slots for all their packets have already expired, are no longer rejected outright. Instead the submission is accepted, and the URB complet

[PATCH] USB: UHCI: accept very late isochronous URBs

2013-09-24 Thread Alan Stern
Commit 24f531371de1 (USB: EHCI: accept very late isochronous URBs) changed the isochronous API provided by ehci-hcd. URBs submitted too late, so that the time slots for all their packets have already expired, are no longer rejected outright. Instead the submission is accepted, and the URB complet

[PATCH] USB: iMX21: accept very late isochronous URBs

2013-09-24 Thread Alan Stern
Commit 24f531371de1 (USB: EHCI: accept very late isochronous URBs) changed the isochronous API provided by ehci-hcd. URBs submitted too late, so that the time slots for all their packets have already expired, are no longer rejected outright. Instead the submission is accepted, and the URB complet

Re: problematic device

2013-09-24 Thread folkert
> Then the problem is most likely in the device or the firmware. If you > get a usbmon trace, it might provide more information. > You asked what the firmware is doing wrong, but you already know the > answer: It disconnects the device every 6-7 seconds. Perhaps it does > this because it doesn'

Re: problematic device

2013-09-24 Thread Alan Stern
On Tue, 24 Sep 2013, folkert wrote: > > Then the problem is most likely in the device or the firmware. If you > > get a usbmon trace, it might provide more information. > > > You asked what the firmware is doing wrong, but you already know the > > answer: It disconnects the device every 6-7 sec

Re: [PATCH] Remove VLAIS usage from gadget code - alternate patch

2013-09-24 Thread Behan Webster
On 09/24/13 13:56, charl...@gmail.com wrote: From: Mark Charlebois The use of variable length arrays in structs (VLAIS) in the Linux Kernel code precludes the use of compilers which don't implement VLAIS (for instance the Clang compiler). This alternate patch calculates offsets into the kmalloc

[PATCH 0/2] USB 2.0 Link PM is broken

2013-09-24 Thread Sarah Sharp
Sigh. It looks like yet another aspect of USB power management is broken. If you plug in a USB 3.0 device into a USB 2.0 port on Intel Haswell-ULT systems, many devices fail to enumerate, or stop responding to SCSI commands. The end result is that many USB 3.0 devices simply don't work when plug

[PATCH 1/2] usb: Don't enable USB 2.0 Link PM by default.

2013-09-24 Thread Sarah Sharp
How it's supposed to work: -- USB 2.0 Link PM is a lower power state that some newer USB 2.0 devices support. USB 3.0 devices certified by the USB-IF are required to support it if they are plugged into a USB 2.0 only port, or a USB 2.0 cable is used. USB 2.0 Link PM requi

[PATCH 2/2] usb: Disable USB 2.0 Link PM before device reset.

2013-09-24 Thread Sarah Sharp
Before the USB core resets a device, we need to disable the L1 timeout for the roothub, if USB 2.0 Link PM is enabled. Otherwise the port may transition into L1 in between descriptor fetches, before we know if the USB device descriptors changed. LPM will be re-enabled after the full device descri

RE: [PATCH 0/2] USB 2.0 Link PM is broken

2013-09-24 Thread Paul Zimmerman
> From: Sarah Sharp [mailto:sarah.a.sh...@linux.intel.com] > Sent: Tuesday, September 24, 2013 2:29 PM > > Sigh. It looks like yet another aspect of USB power management is > broken. If you plug in a USB 3.0 device into a USB 2.0 port on Intel > Haswell-ULT systems, many devices fail to enumerat

Re: [PATCH v4 0/2] usb: implement AMD remote wakeup quirk

2013-09-24 Thread Huang Rui
On Tue, Sep 24, 2013 at 10:21:32AM -0400, Alan Stern wrote: > On Tue, 24 Sep 2013, Huang Rui wrote: > > > Hi Sarah and Alan, > > > > On Mon, Sep 23, 2013 at 05:14:02PM -0700, Sarah Sharp wrote: > > > On Mon, Sep 23, 2013 at 12:43:15PM -0400, Alan Stern wrote: > > > > This version of the patch set

Re: [PATCH 0/2] USB 2.0 Link PM is broken

2013-09-24 Thread Julius Werner
> My hypothesis is that the Synopsys host doesn't go into L1 if the device > NAKs a transfer, only when the bus is idle. That way, it doesn't have > to depend on L1 remote wakeup, which is broken for these devices. I > don't have a way to confirm that though. Paul, is the Synopsys host > working