Re: [PATCH] USBNET: fix handling padding packet

2013-09-19 Thread Bjørn Mork
Oliver Neukum writes: > On Wed, 2013-09-18 at 20:56 +0200, Bjørn Mork wrote: >> Oliver Neukum wrote: > >> >No, USB 3.0 uses no companion controllers, so you can have devices >> >of any speed connected to it. >> > >> >> Ah, right. I don't own such modern hardware, but I should have known >> this

Re: [PATCH v3 1/1] usb: gadget: zero: Add flexible auto remote wakeup test method

2013-09-19 Thread Daniele Forsi
2013/9/19 Peter Chen: > + "milliseconds to increase successive wakup delays"); there's a typo: s/wakup/wakeup/ -- Daniele Forsi -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at htt

Re: [PATCH]fsl/usb: Workarourd for USB erratum-A005697

2013-09-19 Thread Daniele Forsi
2013/9/19 Ramneek Mehresh: > + * we need to wait for 10ms for bus to fo into suspend mode after there's a typo: s/fo/go/ -- Daniele Forsi -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://

RE: [PATCH] USBNET: fix handling padding packet

2013-09-19 Thread David Laight
> I wonder what the gain of that really is? Yes, I can see the advantage > of making the class drivers more effective. But padding is only > relevant for the ECM class, isn't it? And are there any ECM class > devices where SG support matters? AFAICT the requirement for avoiding ZLP is a property

[PATCH] staging: usbip: Fix build on Debian ppc

2013-09-19 Thread Dominik Paulus
From: Tobias Polzer One missing include was added. Signed-off-by: Dominik Paulus Signed-off-by: Tobias Polzer --- drivers/staging/usbip/userspace/src/usbip_network.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/staging/usbip/userspace/src/usbip_network.c b/drivers/staging/

Re: [PATCH] staging: usbip: Fix build on Debian ppc

2013-09-19 Thread Tobias Polzer
When testing usbip under powerpc, it (unexpectedly) worked, but only after removing the following lines from vhch_hcd.c: 1004 /* will be removed */ 1005 if (pdev->dev.dma_mask) { 1006 dev_info(&pdev->dev, "vhci_hcd DMA not supported\n"); 1007 return

Re: [PATCH] staging: usbip: Fix build on Debian ppc

2013-09-19 Thread Dan Carpenter
On Thu, Sep 19, 2013 at 10:55:18AM +0200, Tobias Polzer wrote: > When testing usbip under powerpc, it (unexpectedly) worked, but only after > removing the following lines from vhch_hcd.c: > > 1004 /* will be removed */ > 1005 if (pdev->dev.dma_mask) { > 1006 dev_inf

[PATCH v3 1/7] USB: gadget: s3c-hsotg: fix "protocol stall" handling

2013-09-19 Thread Robert Baldyga
After normal handling of SetupDone interrupt, XferCompl interrupt occurs, and then we enqueue new setup request. But when ep0 is stalled, there is no XferCompl, so we have to enqueue setup request immediately after stalling ep. Otherwise incoming control requests won't be processed correctly. Sign

[PATCH v3 6/7] USB: gadget: s3c-hsotg: fix clear feature ENDPOINT_HALT

2013-09-19 Thread Robert Baldyga
All requests for endpoint are completed when it was halted and the halt was cleared by CLEAR_FEATURE, but not when new state is same as previous. Signed-off-by: Robert Baldyga Signed-off-by: Kyungmin Park --- drivers/usb/gadget/s3c-hsotg.c | 10 +- 1 file changed, 9 insertions(+), 1 d

[PATCH v3 5/7] USB: gadget: s3c-hsotg: fix "halted" property updating

2013-09-19 Thread Robert Baldyga
Property "halted" of s3c_hsotg_ep structure is actually initialised when ep enabled, and changed when halt is set/cleared. Signed-off-by: Robert Baldyga Signed-off-by: Kyungmin Park --- drivers/usb/gadget/s3c-hsotg.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb/gadget/s

[PATCH v3 7/7] USB: gadget: s3c-hsotg: fix interrupt configuration in dedicated-fifo mode

2013-09-19 Thread Robert Baldyga
In dedicated-fifo mode TxFIFOEmpty interrupt should be asserted when TxFIFO for this endpoint is completly empty, so NPTxFEmpLvl and PTxFEmpLvl bits are set in GAHBCFG register. In DIEPMSK register INTknTXFEmpMsk is set, becouse it's needed to indicate FIFO Empty state. Signed-off-by: Robert Baldy

[PATCH v3 3/7] USB: gadget: s3c-hsotg: fix endpoint interrupts handling

2013-09-19 Thread Robert Baldyga
When s3c_hsotg_trytx is called for ep without enqueued request, interrupts for this ep are disabled, to prevent interrupt flooding. Interrupts are enabled when new request for this ep is starting. Signed-off-by: Robert Baldyga Signed-off-by: Kyungmin Park --- drivers/usb/gadget/s3c-hsotg.c |

[PATCH v3 4/7] USB: gadget: s3c-hsotg: add DAINT masking

2013-09-19 Thread Robert Baldyga
In OEPInt/IEPInt interrupts handling added bitwise and of DAINT and DAINTMSK, because we should handle masked interrupts only. Signed-off-by: Robert Baldyga Signed-off-by: Kyungmin Park --- drivers/usb/gadget/s3c-hsotg.c |8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --g

[PATCH v3 0/7] usb: s3c-hsotg: fixes for proper functioning

2013-09-19 Thread Robert Baldyga
Hello, This is a third version of set of patches fixing s3c-hsotg USB driver functioning. From the previous vesrion there are two changes - fixed one small mistake found in one of patches, and add new patch fixing interrupt configuration for dedicated-fifo mode. These patches add few fixes: - Fix

[PATCH v3 2/7] USB: gadget: s3c-hsotg: fix s3c_hsotg_write_fifo function for dedicated fifo mode

2013-09-19 Thread Robert Baldyga
In s3c_hsotg_write_fifo function PTxFEmp/NPTxFEmp interrupts are enabled only in shared-fifo mode. In dedicated-fifo mode they should not be used (when enabled then cause interrupt storm). Signed-off-by: Robert Baldyga Signed-off-by: Kyungmin Park --- drivers/usb/gadget/s3c-hsotg.c | 16 +

Re: [PATCH] staging: usbip: Fix build on Debian ppc

2013-09-19 Thread Dominik Paulus
On Thu, Sep 19, 2013 at 12:12:44PM +0300, Dan Carpenter wrote: > On Thu, Sep 19, 2013 at 10:55:18AM +0200, Tobias Polzer wrote: > > When testing usbip under powerpc, it (unexpectedly) worked, but only after > > removing the following lines from vhch_hcd.c: > > > > 1004 /* will be removed *

Re: [Regression/Bug] Webcam is not working and causes crashes since 3.2

2013-09-19 Thread Hans de Goede
Hi, On 09/18/2013 09:55 PM, Frank Dierich wrote: Hi, I have an ASUS A8JP Notebook with a build in webcam and I am using Ubuntu 12.04. The camera is working nice with Cheese and kernels before 3.2. I have tested the following once 2.6.32.61, 2.6.33.20, 2.6.34.11, 2.6.35.14, 2.6.36.4, 2.6.37.6

Re: [PATCH] staging: usbip: Fix build on Debian ppc

2013-09-19 Thread navin patidar
On September 19, 2013 at 3:40 PM Dominik Paulus wrote: > On Thu, Sep 19, 2013 at 12:12:44PM +0300, Dan Carpenter wrote: > > On Thu, Sep 19, 2013 at 10:55:18AM +0200, Tobias Polzer wrote: > > > When testing usbip under powerpc, it (unexpectedly) worked, but only after > > > removing the following l

Re: [PATCH] staging: usbip: Fix build on Debian ppc

2013-09-19 Thread Dan Carpenter
Ah, ok. I had no idea what you were talking about before. I thought you were talking about build errors in a file that didn't exist... (Because the subject says "build" and there was a typo in the file name). Navin, says you can remove it. regards, dan carpenter -- To unsubscribe from this list

Re: [PATCH v3 1/1] usb: gadget: zero: Add flexible auto remote wakeup test method

2013-09-19 Thread Peter Chen
On Thu, Sep 19, 2013 at 09:24:15AM +0200, Daniele Forsi wrote: > 2013/9/19 Peter Chen: > > > + "milliseconds to increase successive wakup delays"); > > there's a typo: s/wakup/wakeup/ > Thanks, I think I need check more carefully for typo error -- Best Regards, Peter Chen -- T

[PATCH] staging: usbip: Fix build with --with-tcp-wrappers

2013-09-19 Thread Dominik Paulus
With --with-tcp-wrappers=no specified, the build system reset LIBS to the empty string and thus fails to link against libsysfs. Signed-off-by: Dominik Paulus Signed-off-by: Tobias Polzer --- drivers/staging/usbip/userspace/configure.ac | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/

[PATCH v4 1/1] usb: gadget: zero: Add flexible auto remote wakeup test method

2013-09-19 Thread Peter Chen
In order to increase test coverage, we can change the interval between two remote wakeups every time, and the interval can be any user defined values. This change will no affect current behavior if the user does not use two introduced module parameters. Signed-off-by: Peter Chen --- Changes for

Re: [PATCH] USBNET: fix handling padding packet

2013-09-19 Thread Ming Lei
On Thu, Sep 19, 2013 at 3:18 PM, Bjørn Mork wrote: > Oliver Neukum writes: >> On Wed, 2013-09-18 at 20:56 +0200, Bjørn Mork wrote: >>> Oliver Neukum wrote: >> >>> >No, USB 3.0 uses no companion controllers, so you can have devices >>> >of any speed connected to it. >>> > >>> >>> Ah, right. I don

Re: [PATCH]fsl/usb: Workarourd for USB erratum-A005697

2013-09-19 Thread Alan Stern
On Thu, 19 Sep 2013, Ramneek Mehresh wrote: > As per USB specification, in Suspend state the status bit does > not change until the port is suspended. However, there may be a delay > in suspending a port if there is a transaction currently in progress > on the bus. > > In the USBDR controller, th

[PATCH 5/7] staging: usbip: Add encryption support to kernel

2013-09-19 Thread Dominik Paulus
This adds code performing the actual encryption and authentication operations in the usbip kernel code. The whole data stream may now be encrypted and authenticated with AES-GCM and symmetric 128 bit keys. Signed-off-by: Dominik Paulus Signed-off-by: Tobias Polzer --- drivers/staging/usbip/Kcon

[PATCH 0/7] staging: usbip: Extend crypto support

2013-09-19 Thread Dominik Paulus
Hi, this patch series extends our previous set of patches (see [1]). We extended the crypto support so all of the usbip network traffic can now be completely encrypted and authenticated. We now use GnuTLS not only for password verification, but extend the lifetime of the TLS connection to cover a

[PATCH 1/7] staging: usbip: TLS for all userspace communication

2013-09-19 Thread Dominik Paulus
This patch extends the TLS support to cover all communication in userspace. The TLS connection is released shortly before the socket is passed to the kernel. This requires for additional connection state to be passed between functions. We thus replaced the sockfd by a struct containing the TLS con

[PATCH 2/7] staging: usbip: Exchange session keys in userspace

2013-09-19 Thread Dominik Paulus
In preparation for the kernel crypto support, we exchange two - randomly generated - session keys between usbip and usbipd to be used for encrypting all traffic generated in kernelspace. We use two different 128-bit keys, one for sending and one for receiving. Both are generated by the client (usbi

[PATCH 4/7] staging: usbip: Wrap kernel_sendmsg()/recvmsg()

2013-09-19 Thread Dominik Paulus
This adds two simple wrappers around kernel_sendmsg() and kernel_recvmsg() that can be extended to perform additional cryptographic operations on the data before sending it. Signed-off-by: Dominik Paulus Signed-off-by: Tobias Polzer --- drivers/staging/usbip/stub_rx.c | 2 +- drivers/stag

[PATCH 7/7] staging: usbip: Increment version number to 1.2.1

2013-09-19 Thread Dominik Paulus
Also increment the kernel module version number to match the userspace version, as compatibility with old userspace utilities is now at least partially broken. Signed-off-by: Dominik Paulus Signed-off-by: Tobias Polzer --- drivers/staging/usbip/usbip_common.h | 2 +- drivers/staging/usb

[PATCH 6/7] staging: usbip: Update documentation

2013-09-19 Thread Dominik Paulus
From: Tobias Polzer README was updated and cleaned. It now contains just one example, which was updated to use encryption. Also, the new crypto behaviour is documented. The usbip "port" command has been removed from the README, as it isn't supported by newer userland versions. One dead link was r

[PATCH 3/7] staging: usbip: Pass session keys to the kernel

2013-09-19 Thread Dominik Paulus
This extends the userspace code to write the generated session keys to sysfs in hexadecimal encoding after establishing the connection. The kernel code is modified to parse the session keys. Signed-off-by: Dominik Paulus Signed-off-by: Tobias Polzer --- drivers/staging/usbip/stub_dev.c

Re: [alsa-devel] question about webcam audio capture

2013-09-19 Thread vichy
hi Clemens: 2013/9/10 Clemens Ladisch : > vichy wrote: >> 2013/9/9 Clemens Ladisch : >>> vichy wrote: I try to do webcam audio capture on my arm platform. when I execute audio capture I got below message "retire_capture_urb: 108 callbacks suppressed" >>> >>> This means that the reti

Getting udev name from usb_device structure

2013-09-19 Thread Sergio Work
Hi all! I'm writting a LSM hook in order to allow to mount just only some particular USB Mass Storage devices according to their idVendor, idProduct, and Serial. The hook is executed when a device is going to be mounted, and it has the following prototype: static int sb_mount(const char *dev_name

[PATCH 00/51] DMA mask changes

2013-09-19 Thread Russell King - ARM Linux
This started out as a request to look at the DMA mask situation, and how to solve the issues which we have on ARM - notably how the DMA mask should be setup. However, I started off reviewing how the dma_mask and coherent_dma_mask was being used, and what I found was rather messy, and in some cases

Re: [RFC 10/21] xhci: replace xhci_readl() with readl() in xhci-dbg.c

2013-09-19 Thread Sarah Sharp
On Fri, Sep 13, 2013 at 03:50:48PM +0530, Pratyush Anand wrote: > On Fri, Sep 13, 2013 at 3:40 PM, Xenia Ragiadakou > wrote: > > Nope :). There is still Kumar 's patch that keeps the wrappers, so it can > > be applied instead of mine. But you did not tell me which tool you use > > currently to log

[PATCH 02/51] DMA-API: net: brocade/bna/bnad.c: fix 32-bit DMA mask handling

2013-09-19 Thread Russell King
The fallback to 32-bit DMA mask is rather odd: if (!dma_set_mask(&pdev->dev, DMA_BIT_MASK(64)) && !dma_set_coherent_mask(&pdev->dev, DMA_BIT_MASK(64))) { *using_dac = true; } else { err = dma_set_mask(&pdev->dev, DMA_BIT_MASK(32));

[PATCH 03/51] DMA-API: net: intel/e1000e: fix 32-bit DMA mask handling

2013-09-19 Thread Russell King
The fallback to 32-bit DMA mask is rather odd: err = dma_set_mask(&pdev->dev, DMA_BIT_MASK(64)); if (!err) { err = dma_set_coherent_mask(&pdev->dev, DMA_BIT_MASK(64)); if (!err) pci_using_dac = 1; } else {

[PATCH 04/51] DMA-API: net: intel/igb: fix 32-bit DMA mask handling

2013-09-19 Thread Russell King
The fallback to 32-bit DMA mask is rather odd: err = dma_set_mask(&pdev->dev, DMA_BIT_MASK(64)); if (!err) { err = dma_set_coherent_mask(&pdev->dev, DMA_BIT_MASK(64)); if (!err) pci_using_dac = 1; } else {

[PATCH 01/51] DMA-API: provide a helper to set both DMA and coherent DMA masks

2013-09-19 Thread Russell King
Provide a helper to set both the DMA and coherent DMA masks to the same value - this avoids duplicated code in a number of drivers, sometimes with buggy error handling, and also allows us identify which drivers do things differently. Signed-off-by: Russell King --- Documentation/DMA-API-HOWTO.tx

[PATCH 05/51] DMA-API: net: intel/igbvf: fix 32-bit DMA mask handling

2013-09-19 Thread Russell King
The fallback to 32-bit DMA mask is rather odd: err = dma_set_mask(&pdev->dev, DMA_BIT_MASK(64)); if (!err) { err = dma_set_coherent_mask(&pdev->dev, DMA_BIT_MASK(64)); if (!err) pci_using_dac = 1; } else {

[PATCH 06/51] DMA-API: net: intel/ixgb: fix 32-bit DMA mask handling

2013-09-19 Thread Russell King
The fallback to 32-bit DMA mask is rather odd: err = dma_set_mask(&pdev->dev, DMA_BIT_MASK(64)); if (!err) { err = dma_set_coherent_mask(&pdev->dev, DMA_BIT_MASK(64)); if (!err) pci_using_dac = 1; } else {

[PATCH 07/51] DMA-API: net: intel/ixgbe: fix 32-bit DMA mask handling

2013-09-19 Thread Russell King
The fallback to 32-bit DMA mask is rather odd: if (!dma_set_mask(&pdev->dev, DMA_BIT_MASK(64)) && !dma_set_coherent_mask(&pdev->dev, DMA_BIT_MASK(64))) { pci_using_dac = 1; } else { err = dma_set_mask(&pdev->dev, DMA_BIT_MASK(32));

[PATCH 08/51] DMA-API: net: intel/ixgbevf: fix 32-bit DMA mask handling

2013-09-19 Thread Russell King
The fallback to 32-bit DMA mask is rather odd: if (!dma_set_mask(&pdev->dev, DMA_BIT_MASK(64)) && !dma_set_coherent_mask(&pdev->dev, DMA_BIT_MASK(64))) { pci_using_dac = 1; } else { err = dma_set_mask(&pdev->dev, DMA_BIT_MASK(32));

Re: Getting udev name from usb_device structure

2013-09-19 Thread Greg KH
On Thu, Sep 19, 2013 at 08:42:45PM +0200, Sergio Work wrote: > Hi all! > > I'm writting a LSM hook in order to allow to mount just only some > particular USB Mass Storage devices according to their idVendor, > idProduct, and Serial. Why would this be an LSM hook? What's wrong with the existing s

Re: [RFC] Patch Memory Mapping for USBFS

2013-09-19 Thread Markus Rechberger
On Fri, Sep 20, 2013 at 1:57 AM, Markus Rechberger wrote: > > This patch adds memory mapping support to USBFS for isochronous and bulk data > transfers, it allows to pre-allocate usb transfer buffers. > I guess some things can be made a little bit nicer here so any feedback is > welcome. > The C

Re: [PATCH 01/51] DMA-API: provide a helper to set both DMA and coherent DMA masks

2013-09-19 Thread Ben Hutchings
On Thu, 2013-09-19 at 22:25 +0100, Russell King wrote: > Provide a helper to set both the DMA and coherent DMA masks to the > same value - this avoids duplicated code in a number of drivers, > sometimes with buggy error handling, and also allows us identify > which drivers do things differently. >

Re: [RFC] Patch Memory Mapping for USBFS

2013-09-19 Thread Alan Stern
On Fri, 20 Sep 2013, Markus Rechberger wrote: > to comment it by myself, memory should be cleared for not exposing > uncleared memory to userspace > and usbmem should be checked if(!mem), if(!usbmem). It will be in the > next version. The next time you post a version of this patch, please make su

RE: [PATCH]fsl/usb: Workarourd for USB erratum-A005697

2013-09-19 Thread Mehresh Ramneek-B31383
-Original Message- From: Alan Stern [mailto:st...@rowland.harvard.edu] Sent: Thursday, September 19, 2013 7:03 PM To: Mehresh Ramneek-B31383 Cc: linux-usb@vger.kernel.org Subject: Re: [PATCH]fsl/usb: Workarourd for USB erratum-A005697 On Thu, 19 Sep 2013, Ramneek Mehresh wrote: > As pe

Re: [PATCH v11 0/8] PHY framework

2013-09-19 Thread Kishon Vijay Abraham I
Hi Greg, On Tuesday 17 September 2013 09:11 PM, Felipe Balbi wrote: > On Wed, Sep 04, 2013 at 02:27:06PM +0530, Kishon Vijay Abraham I wrote: >> On Tuesday 03 September 2013 09:20 PM, Greg KH wrote: >>> On Tue, Sep 03, 2013 at 08:55:23PM +0530, Kishon Vijay Abraham I wrote: Hi Greg,

Re: [RFC 10/21] xhci: replace xhci_readl() with readl() in xhci-dbg.c

2013-09-19 Thread Pratyush Anand
On Fri, Sep 20, 2013 at 05:37:50AM +0800, Sarah Sharp wrote: > On Fri, Sep 13, 2013 at 03:50:48PM +0530, Pratyush Anand wrote: > > On Fri, Sep 13, 2013 at 3:40 PM, Xenia Ragiadakou > > wrote: > > > Nope :). There is still Kumar 's patch that keeps the wrappers, so it can > > > be applied instead o

Re: [PATCH v11 0/8] PHY framework

2013-09-19 Thread Greg KH
On Fri, Sep 20, 2013 at 11:04:40AM +0530, Kishon Vijay Abraham I wrote: > Hi Greg, > > On Tuesday 17 September 2013 09:11 PM, Felipe Balbi wrote: > > On Wed, Sep 04, 2013 at 02:27:06PM +0530, Kishon Vijay Abraham I wrote: > >> On Tuesday 03 September 2013 09:20 PM, Greg KH wrote: > >>> On Tue, Sep