Re: [RFC 10/21] xhci: replace xhci_readl() with readl() in xhci-dbg.c

On 09/13/2013 06:49 AM, Pratyush Anand wrote: On Tue, Sep 10, 2013 at 02:03:15AM +0800, Xenia Ragiadakou wrote: Function xhci_readl() is used to read 32bit xHC registers residing in MMIO address space. It takes as first argument a pointer to the xhci_hcd although it does not use it because inter

Re: [RFC 10/21] xhci: replace xhci_readl() with readl() in xhci-dbg.c

Hi ksenia, On Fri, Sep 13, 2013 at 04:45:23PM +0800, Xenia Ragiadakou wrote: > On 09/13/2013 06:49 AM, Pratyush Anand wrote: > > On Tue, Sep 10, 2013 at 02:03:15AM +0800, Xenia Ragiadakou wrote: > >> Function xhci_readl() is used to read 32bit xHC registers residing in MMIO > >> address space. It

Re: [RFC 10/21] xhci: replace xhci_readl() with readl() in xhci-dbg.c

On 09/13/2013 12:28 PM, Pratyush Anand wrote: Hi ksenia, On Fri, Sep 13, 2013 at 04:45:23PM +0800, Xenia Ragiadakou wrote: On 09/13/2013 06:49 AM, Pratyush Anand wrote: On Tue, Sep 10, 2013 at 02:03:15AM +0800, Xenia Ragiadakou wrote: Function xhci_readl() is used to read 32bit xHC registers

report about XHCI needing extremely long to sleep

Hi, I have a report from a customer about an XHCI which needs a ten times increase of timeout in @@ -904,7 +904,7 @@ int xhci_suspend(struct xhci_hcd *xhci) command &= ~CMD_RUN; xhci_writel(xhci, command, &xhci->op_regs->command); if (xhci_handshake(xhci, &xhci->op_regs->s

[PATCH v3 1/6] xhci: fix usb3 streams

xhci maintains a radix tree for each stream endpoint because it must be able to map a trb address to the stream ring. Each ring segment must be added to the ring for this to work. Currently xhci sticks only the first segment of each stream ring into the radix tree. Result is that things work ini

[PATCH v3 0/6] make uas fly

Hi, This patch series enables uas support in the linux kernel. First patch fixes usb3 streams support in xhci, patches 2-5 improve uas error handling and patch 6 removes BROKEN from the uas kernel config. New in v3: Fix the race pointed out by Oliver, on both existing code and the patch. Adde

[PATCH v3 6/6] uas: remove BROKEN

xhci streams support is fixed, unblock usb attached scsi. Signed-off-by: Gerd Hoffmann --- drivers/usb/storage/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/storage/Kconfig b/drivers/usb/storage/Kconfig index 8470e1b..4761a28 100644 --- a/drivers/usb/sto

[PATCH v3 5/6] uas: replace BUG_ON() + WARN_ON() with WARN_ON_ONCE()

Signed-off-by: Gerd Hoffmann --- drivers/usb/storage/uas.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c index f049038..046eedf 100644 --- a/drivers/usb/storage/uas.c +++ b/drivers/usb/storage/uas.c @

[PATCH v3 4/6] uas: add dead request list

This patch adds a new list where all requests which are canceled are added to, so we don't loose them. Then, after killing all inflight urbs on bus reset (and disconnect) we'll walk over the list and clean them up. Without this we can end up with aborted requests lingering around in case of statu

[PATCH v3 3/6] uas: make work list per-device

Simplifies locking, we'll protect the list with the device spin lock. Also plugs races which can happen when two devices operate on the global list. While being at it rename the list head from "list" to "work", preparing for the addition of a second list. Signed-off-by: Gerd Hoffmann --- driver

[PATCH v3 2/6] uas: properly reinitialize in uas_eh_bus_reset_handler

Signed-off-by: Gerd Hoffmann --- drivers/usb/storage/uas.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c index d966b59..fc08ee9 100644 --- a/drivers/usb/storage/uas.c +++ b/drivers/usb/storage/uas.c @@ -85,6 +85,8 @@ static int uas_

[PATCH V2] USB: EHCI: make ehci-w90X900 a separate driver

Separate the W90X900(W90P910) on-chip host controller driver from ehci-hcd host code so that it can be built as a separate driver module. This work is part of enabling multi-platform kernels on ARM; however, note that other changes are still needed before W90X900(W90P910) can be booted with a multi

Re: Ejected Nook (usb mass storage) prevents suspend

What's the status of this? Do I still need to test it? I won't have access to the Nook that triggered it the first time for a couple weeks, but I could try to find another device like that. --Andy On Fri, Aug 2, 2013 at 7:18 AM, Alan Stern wrote: > On Fri, 2 Aug 2013, Oliver Neukum wrote: > >>

[PATCH] staging: dwc2: Fix typo in staging/dwc2

Correct spelling typo in comments Singend-off-by: Masanari Iida --- drivers/staging/dwc2/core.c | 2 +- drivers/staging/dwc2/hcd_queue.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/dwc2/core.c b/drivers/staging/dwc2/core.c index 06dae67..8dbd174

Re: Ejected Nook (usb mass storage) prevents suspend

On Fri, 2013-09-13 at 06:37 -0700, Andy Lutomirski wrote: > What's the status of this? Do I still need to test it? > > I won't have access to the Nook that triggered it the first time for a > couple weeks, but I could try to find another device like that. It works for me. I'll push upstream in a

[PATCH 3/3] USB : serial : pl2303 wake up after dcd status check.

Seems to be done this way in other drivers (ch341, 8250, ...). And get tty reference only if dcd_change need to be called. Signed-off-by: Paul Chavent --- drivers/usb/serial/pl2303.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/drivers/usb/serial/pl2303.c

[PATCH 2/3] USB : serial : invoke dcd_change ldisc's handler.

Signed-off-by: Paul Chavent --- Documentation/pps/pps.txt| 15 +++ drivers/usb/serial/generic.c | 9 + 2 files changed, 24 insertions(+) diff --git a/Documentation/pps/pps.txt b/Documentation/pps/pps.txt index d35dcdd..67b9a94 100644 --- a/Documentation/pps/pps.txt +++ b

[PATCH 1/3] USB : serial : call handle_dcd_change in ftdi driver.

Signed-off-by: Paul Chavent --- drivers/usb/serial/ftdi_sio.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/ftdi_sio.c index c45f9c0..df66495 100644 --- a/drivers/usb/serial/ftdi_sio.c +++ b/drivers/usb/serial/ftdi_si

[PATCH 0/3] Enable PPS reporting for USB serial devices V2

Hi. This series enable the PPS reporting for USB serial devices (second submission). As opposed to the previous one this patch doesn't change the usb_serial_handle_dcd_change interface, and only add the minimum of code in order to enable the PPS over USB serial devices. It also add some comments

Re: [PATCH 1/3] USB : serial : call handle_dcd_change in ftdi driver.

On Fri, Sep 13, 2013 at 05:35:11PM +0200, Paul Chavent wrote: > Signed-off-by: Paul Chavent Why? We need more information in the changelog body to be able to accept this. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.or

Re: [PATCH 2/3] USB : serial : invoke dcd_change ldisc's handler.

On Fri, Sep 13, 2013 at 05:35:12PM +0200, Paul Chavent wrote: > Signed-off-by: Paul Chavent Again, why? I need a whole lot more information in here to be able to accept this. Yes, you provided much of this in the 0/3 message, but that doesn't end up in the kernel. Third time's a charm? thanks

Re: [PATCH 1/3] USB : serial : call handle_dcd_change in ftdi driver.

On Fri, Sep 13, 2013 at 05:35:11PM +0200, Paul Chavent wrote: > Signed-off-by: Paul Chavent > --- > drivers/usb/serial/ftdi_sio.c | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/ftdi_sio.c > index c45f9c0..df66495

Re: [PATCH 2/3] USB : serial : invoke dcd_change ldisc's handler.

On Fri, Sep 13, 2013 at 05:35:12PM +0200, Paul Chavent wrote: > Signed-off-by: Paul Chavent > --- > Documentation/pps/pps.txt| 15 +++ > drivers/usb/serial/generic.c | 9 + > 2 files changed, 24 insertions(+) > > diff --git a/Documentation/pps/pps.txt b/Documentation/pps

Re: Testing USB connectors on iMX28EVK

Dear Peter Chen, > On Thu, Sep 12, 2013 at 12:55:54PM +0200, gianluca wrote: > > Hello, > > I just compiled the kernel from git repo of peter chen > > (git://github.com/hzpeterchen/linux-usb) > > Please use current linux-next tree, it has already supported > mx28 evk for vbus and id detection. >

Re: [PATCH 3/3] USB : serial : pl2303 wake up after dcd status check.

Hi. This patch was just a suggestion. Don't bother with rebasing. I will wait your changes and remove this patch from the next submission. Cheers. Paul. On 09/13/2013 06:23 PM, Johan Hovold wrote: On Fri, Sep 13, 2013 at 05:35:13PM +0200, Paul Chavent wrote: Seems to be done this way in ot

Re: [PATCH 3/3] USB : serial : pl2303 wake up after dcd status check.

On Fri, Sep 13, 2013 at 05:35:13PM +0200, Paul Chavent wrote: > Seems to be done this way in other drivers (ch341, 8250, ...). > And get tty reference only if dcd_change need to be called. This is fine. I have a patch here doing the same two changes as part of a larger clean-up of the pl2303 inter

Re: [PATCH 2/3] USB : serial : invoke dcd_change ldisc's handler.

On Fri, Sep 13, 2013 at 05:35:12PM +0200, Paul Chavent wrote: > Signed-off-by: Paul Chavent Acked-by: Rodolfo Giometti -- GNU/Linux Solutions e-mail: giome...@enneenne.com Linux Device Driver giome...@linux.it Embedded Systems phon

Re: [PATCH 1/2] USB: remove claim that usb_disconnect() acquires usb_bus_list_lock

On Fri, 13 Sep 2013, Bjorn Helgaas wrote: > After 9ad3d6ccf5 ("USB: Remove USB private semaphore"), usb_disconnect() > no longer acquires usb_bus_list_lock, so remove the comment to that effect. > > Signed-off-by: Bjorn Helgaas > --- > drivers/usb/core/hub.c |2 -- > 1 file changed, 2 delet

Re: [PATCH 2/2] USB: don't hold usb_bus_list_lock for usb_disconnect()

On Fri, 13 Sep 2013, Bjorn Helgaas wrote: > usb_bus_list_lock protects the usb_bus_list, and we don't touch that list > in usb_disconnect(), so there's no reason to hold the lock here. The code says: /* used when updating list of hcds */ DEFINE_MUTEX(usb_bus_list_lock);/* exported only f

[PATCH 0/2] usb_bus_list_lock updates

I think the usb_disconnect() comment update is pretty straightforward, though more comment updates may be warranted. The changes so usb_add_hcd() and usb_remove_hcd() don't hold the usb_bus_list_lock around usb_disconnect() need more scrutiny from you experts. It *appears* unnecessary to me, and

[PATCH 1/2] USB: remove claim that usb_disconnect() acquires usb_bus_list_lock

After 9ad3d6ccf5 ("USB: Remove USB private semaphore"), usb_disconnect() no longer acquires usb_bus_list_lock, so remove the comment to that effect. Signed-off-by: Bjorn Helgaas --- drivers/usb/core/hub.c |2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/usb/core/hub.c b/drivers/us

[PATCH 2/2] USB: don't hold usb_bus_list_lock for usb_disconnect()

usb_bus_list_lock protects the usb_bus_list, and we don't touch that list in usb_disconnect(), so there's no reason to hold the lock here. Signed-off-by: Bjorn Helgaas --- drivers/usb/core/hcd.c |4 1 file changed, 4 deletions(-) diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/h

Re: [PATCH 1/3] USB : serial : call handle_dcd_change in ftdi driver.

Hello. On 09/13/2013 07:35 PM, Paul Chavent wrote: Signed-off-by: Paul Chavent --- drivers/usb/serial/ftdi_sio.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/ftdi_sio.c index c45f9c0..df66495 100644 --- a/dri

Re: [PATCH 2/3] USB : serial : invoke dcd_change ldisc's handler.

Hello. On 09/13/2013 07:35 PM, Paul Chavent wrote: Signed-off-by: Paul Chavent --- Documentation/pps/pps.txt| 15 +++ drivers/usb/serial/generic.c | 9 + 2 files changed, 24 insertions(+) diff --git a/Documentation/pps/pps.txt b/Documentation/pps/pps.txt index d

Re: [PATCH 2/2] USB: don't hold usb_bus_list_lock for usb_disconnect()

On Fri, Sep 13, 2013 at 12:25 PM, Alan Stern wrote: > On Fri, 13 Sep 2013, Bjorn Helgaas wrote: > >> usb_bus_list_lock protects the usb_bus_list, and we don't touch that list >> in usb_disconnect(), so there's no reason to hold the lock here. > > The code says: > > /* used when updating list of hc

[PATCH v2 0/2] usb_bus_list_lock updates

Comment updates for usb_bus_list_lock. Also un-EXPORT usb_bus_list_lock. --- Bjorn Helgaas (2): USB: correct the usb_disconnect() comment about usb_bus_list_lock USB: unexport usb_bus_list_lock and update comments drivers/usb/core/hcd.c |5 ++--- drivers/usb/core/hub.c |4

[PATCH v2 1/2] USB: correct the usb_disconnect() comment about usb_bus_list_lock

usb_disconnect() no longer acquires usb_bus_list_lock, so update its comment to that effect. Signed-off-by: Bjorn Helgaas --- drivers/usb/core/hub.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c index 558313d..087691b 1

[PATCH v2 2/2] USB: unexport usb_bus_list_lock and update comments

usb_bus_list_lock is used by usbfs, but that's in the same module as hcd.c, so there's no need to export it. Update the comment to show that it protects the set of root hubs as well as the list of buses. Signed-off-by: Bjorn Helgaas --- drivers/usb/core/hcd.c |5 ++--- 1 file changed, 2 ins

Re: [PATCH 2/2] USB: don't hold usb_bus_list_lock for usb_disconnect()

On Fri, 13 Sep 2013, Bjorn Helgaas wrote: > On Fri, Sep 13, 2013 at 12:25 PM, Alan Stern > wrote: > > On Fri, 13 Sep 2013, Bjorn Helgaas wrote: > > > >> usb_bus_list_lock protects the usb_bus_list, and we don't touch that list > >> in usb_disconnect(), so there's no reason to hold the lock here.

Re: [PATCH v2 0/2] usb_bus_list_lock updates

On Fri, 13 Sep 2013, Bjorn Helgaas wrote: > Comment updates for usb_bus_list_lock. > > Also un-EXPORT usb_bus_list_lock. For both patches: Signed-off-by: Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org Mo

RE: [RFC 10/21] xhci: replace xhci_readl() with readl() in xhci-dbg.c

> From: linux-usb-ow...@vger.kernel.org > [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Pratyush Anand > Sent: Thursday, September 12, 2013 8:50 PM > > On Tue, Sep 10, 2013 at 02:03:15AM +0800, Xenia Ragiadakou wrote: > > Function xhci_readl() is used to read 32bit xHC registers residing

Re: [PATCH 2/2] USB: don't hold usb_bus_list_lock for usb_disconnect()

On Fri, Sep 13, 2013 at 2:14 PM, Alan Stern wrote: > On Fri, 13 Sep 2013, Bjorn Helgaas wrote: > >> On Fri, Sep 13, 2013 at 12:25 PM, Alan Stern >> wrote: >> > On Fri, 13 Sep 2013, Bjorn Helgaas wrote: >> > >> >> usb_bus_list_lock protects the usb_bus_list, and we don't touch that list >> >> in

Re: [PATCH 2/2] USB: don't hold usb_bus_list_lock for usb_disconnect()

On Fri, 13 Sep 2013, Bjorn Helgaas wrote: > Thanks. Maybe this is more relevant than I thought. I'd sure like to > copy your strategy rather than reinvent something. Well, I don't know if this will really end up being all that relevant for PCI, but you're welcome to steal any ideas you like. :