Re: [PATCH v3] xHCI: Fixing xhci_readl definition and function call

2013-08-28 Thread Dan Carpenter
On Mon, Aug 26, 2013 at 07:38:57AM +0530, Kumar Gaurav wrote: > This patch redefine function xhci_readl.xhci_readl function doesn't use > xhci_hcd argument. > Hence there is no need of keeping it in the function arguments. > > Redefining this function breaks other functions which calls this func

Re: [Pull Request] xhci: Bug fixes for 3.12.

2013-08-28 Thread Dmitry Kasatkin
On 27/08/13 21:26, Sarah Sharp wrote: > The following changes since commit 154547c4fe0fbe92185e69a6cdc2b0502b361995: > > USB: serial: clean up attribute permissions (2013-08-25 15:12:03 -0700) > > are available in the git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/sarah/xh

Re: [PATCH v2 1/3] usb: add is_usb_mouse routine and remote wakeup quirk

2013-08-28 Thread Huang Rui
Hi Greg, I'm glad you can take a look at my patches. :) On Wed, Aug 28, 2013 at 11:38:28AM +0800, Greg Kroah-Hartman wrote: > On Wed, Aug 28, 2013 at 11:13:12AM +0800, Huang Rui wrote: > > This patch add a routine to judge if the usb device is a mouse or not. > > The is_usb_mouse only has one inp

Re: [PATCH] usb: gadget: Add UDC driver for Aeroflex Gaisler GRUSBDC

2013-08-28 Thread Andreas Larsson
On 2013-08-12 16:05, Andreas Larsson wrote: This adds an UDC driver for GRUSBDC USB Device Controller cores available in the GRLIB VHDL IP core library. The driver only supports DMA mode. Any comments? It would be great to get feedback soon in case some things need to be changed for this drive

Re:[RFT & RFC] USB: Fix USB device disconnects on resume.

2013-08-28 Thread Dmitri Zolotov
~/linux-3.9.11$ grep -r "TRSMRCY" drivers/usb/core/hub.c:/* TRSMRCY = 20 msec */ drivers/usb/core/hub.c:/* TRSMRCY = 10 msec */ drivers/usb/core/hcd.c: * unsuspended. If they are then a TRSMRCY delay is needed drivers/usb/core/hcd.c:usleep_range(1, 1100

Announcing libusbx-1.0.17-rc1

2013-08-28 Thread Hans de Goede
Hi All, I'm very happy to announce libusbx-1.0.17-rc1. 2013-08-28: v1.0.17-rc1 * Hotplug callbacks now always get passed a libusb_context, even if it is the default context. Previously NULL would be passed for the default context, but since the first context created is the default context, a

Re: [PATCH v1] USB: EHCI: disable IAA_WATCHDOG and START_UNLINK_INTR if they needn't to be handled

2013-08-28 Thread Ming Lei
On Wed, Aug 28, 2013 at 12:24 PM, Ming Lei wrote: > On Wed, 28 Aug 2013 12:02:03 +0800 > Ming Lei wrote: > >> Actually the problem only happened when underrun without >> URB_ISO_ASAP. >> >> I have another fix which uses rebase trick and is simper(less change), could >> you comment on the attachme

Re: linux-next: Tree for Aug 28 [ xhci build breakage ]

2013-08-28 Thread Sedat Dilek
On Wed, Aug 28, 2013 at 11:49 AM, Sedat Dilek wrote: > Hi all, > > Changes since 20130827: > > The f2fs tree lost its build failure. > > The md tree gained a conflict against the arm tree. > > The libata tree lost its build failure. > > The spi tree lost its build failure. > > The arm-soc tree gai

Re: linux-next: Tree for Aug 28 [ xhci build breakage ]

2013-08-28 Thread Sedat Dilek
On Wed, Aug 28, 2013 at 11:56 AM, Sedat Dilek wrote: > On Wed, Aug 28, 2013 at 11:49 AM, Sedat Dilek wrote: >> Hi all, >> >> Changes since 20130827: >> >> The f2fs tree lost its build failure. >> >> The md tree gained a conflict against the arm tree. >> >> The libata tree lost its build failure.

Re: [patch] usb: musb: unlock on error in cppi41_dma_callback()

2013-08-28 Thread Dan Carpenter
On Tue, Aug 27, 2013 at 03:05:27PM -0500, Felipe Balbi wrote: > On Wed, Aug 21, 2013 at 11:38:21AM +0300, Dan Carpenter wrote: > > We need to unlock and enable IRQs before returning on error. > > > > Signed-off-by: Dan Carpenter > > doesn't apply Wei Yongjun already fixed the bug. regards, dan

Re: linux-next: Tree for Aug 28 [ xhci build breakage ]

2013-08-28 Thread Sedat Dilek
On Wed, Aug 28, 2013 at 12:29 PM, Sedat Dilek wrote: > On Wed, Aug 28, 2013 at 11:56 AM, Sedat Dilek wrote: >> On Wed, Aug 28, 2013 at 11:49 AM, Sedat Dilek wrote: >>> Hi all, >>> >>> Changes since 20130827: >>> >>> The f2fs tree lost its build failure. >>> >>> The md tree gained a conflict agai

Re: linux-next: Tree for Aug 28 [ xhci build breakage ]

2013-08-28 Thread Dmitry Kasatkin
On 28/08/13 13:38, Sedat Dilek wrote: > On Wed, Aug 28, 2013 at 12:29 PM, Sedat Dilek wrote: >> On Wed, Aug 28, 2013 at 11:56 AM, Sedat Dilek wrote: >>> On Wed, Aug 28, 2013 at 11:49 AM, Sedat Dilek wrote: Hi all, Changes since 20130827: The f2fs tree lost its build fail

Re: [PATCH v11 0/8] PHY framework

2013-08-28 Thread Kishon Vijay Abraham I
Hi, On Wednesday 28 August 2013 12:50 AM, Felipe Balbi wrote: > Hi, > > On Mon, Aug 26, 2013 at 01:44:49PM +0530, Kishon Vijay Abraham I wrote: >> On Wednesday 21 August 2013 11:16 AM, Kishon Vijay Abraham I wrote: >>> Added a generic PHY framework that provides a set of APIs for the PHY >>> dri

Re: linux-next: Tree for Aug 28 [ xhci build breakage ]

2013-08-28 Thread Sedat Dilek
On Wed, Aug 28, 2013 at 12:43 PM, Dmitry Kasatkin wrote: > On 28/08/13 13:38, Sedat Dilek wrote: >> On Wed, Aug 28, 2013 at 12:29 PM, Sedat Dilek wrote: >>> On Wed, Aug 28, 2013 at 11:56 AM, Sedat Dilek wrote: On Wed, Aug 28, 2013 at 11:49 AM, Sedat Dilek wrote: > Hi all, > >

[patch] dma: cppi41: off by one in desc_to_chan()

2013-08-28 Thread Dan Carpenter
The test here should be ">=" instead of ">". The cdd->chan_busy[] array has "ALLOC_DECS_NUM" elements. Signed-off-by: Dan Carpenter Acked-by: Vinod Koul --- Resending to Greg and the USB people because Vinod says this goes through the USB tree. diff --git a/drivers/dma/cppi41.c b/drivers/dma/c

Re: linux-next: Tree for Aug 28 [ xhci build breakage ]

2013-08-28 Thread Sedat Dilek
On Wed, Aug 28, 2013 at 12:46 PM, Sedat Dilek wrote: > On Wed, Aug 28, 2013 at 12:43 PM, Dmitry Kasatkin > wrote: >> On 28/08/13 13:38, Sedat Dilek wrote: >>> On Wed, Aug 28, 2013 at 12:29 PM, Sedat Dilek wrote: On Wed, Aug 28, 2013 at 11:56 AM, Sedat Dilek wrote: > On Wed, Aug 2

Re: linux-next: Tree for Aug 28 [ xhci build breakage ]

2013-08-28 Thread Dmitry Kasatkin
On 28/08/13 13:46, Sedat Dilek wrote: > On Wed, Aug 28, 2013 at 12:43 PM, Dmitry Kasatkin > wrote: >> On 28/08/13 13:38, Sedat Dilek wrote: >>> On Wed, Aug 28, 2013 at 12:29 PM, Sedat Dilek wrote: On Wed, Aug 28, 2013 at 11:56 AM, Sedat Dilek wrote: > On Wed, Aug 28, 2013 at 11:49

Re: linux-next: Tree for Aug 28 [ xhci build breakage ]

2013-08-28 Thread Sedat Dilek
On Wed, Aug 28, 2013 at 12:53 PM, Dmitry Kasatkin wrote: > On 28/08/13 13:46, Sedat Dilek wrote: >> On Wed, Aug 28, 2013 at 12:43 PM, Dmitry Kasatkin >> wrote: >>> On 28/08/13 13:38, Sedat Dilek wrote: On Wed, Aug 28, 2013 at 12:29 PM, Sedat Dilek wrote: > On Wed, Aug 28, 2013 at

Re: linux-next: Tree for Aug 28 [ xhci build breakage ]

2013-08-28 Thread Sedat Dilek
debug.h:76: >>>>>> DEFINE_DYNAMIC_DEBUG_METADATA(descriptor, fmt); \ >>>>>> linux/include/linux/dynamic_debug.h:78: >>>>>> __dynamic_pr_debug(&descriptor, pr_fmt(fmt),\ >>>>>> linux/include/linux/dynamic_debug.h:84: &

[v2 PATCH 3/3] staging: ozwpan: Return error, if PD is not connected.

2013-08-28 Thread Rupesh Gujare
Return error if we receive write(), while PD is not connected. Signed-off-by: Rupesh Gujare --- drivers/staging/ozwpan/ozcdev.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/ozwpan/ozcdev.c b/drivers/staging/ozwpan/ozcdev.c index 50722ea..6ccb64f 100644 --- a/drivers/s

[v2 PATCH 2/3] staging: ozwpan: Change error number.

2013-08-28 Thread Rupesh Gujare
Incorrect error number was returned here (EPERM), ENXIO is more appropriate. Signed-off-by: Rupesh Gujare --- drivers/staging/ozwpan/ozcdev.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ozwpan/ozcdev.c b/drivers/staging/ozwpan/ozcdev.c index 03b41ee..50

[v2 PATCH 1/3] staging: ozwpan: Increase ISOC IN buffer depth

2013-08-28 Thread Rupesh Gujare
Buffer depth of 50 units is not sufficient when there is considerable delay occuring on air due to interference, increase ISOC IN buffer depth to 100 units. Signed-off-by: Rupesh Gujare --- drivers/staging/ozwpan/ozhcd.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/driv

Re: [RFC 3/3] EHCI: handle late isochronous submissions

2013-08-28 Thread Ming Lei
On Mon, 26 Aug 2013 14:50:53 -0400 (EDT) Alan Stern wrote: > This patch does the real work. It fixes up ehci-hcd so that an URB > submitted by a completion handler will keep the isochronous stream > alive, even if the handler was delayed by running in a tasklet and the > queue has emptied out

ehci-pci 0000:00:1a.0: DMA-API: device driver maps memory fromstack

2013-08-28 Thread Richard Ryniker
https://bugzilla.redhat.com/show_bug.cgi?id=1001806 Aug 26 16:11:36 localhost kernel: [ cut here ] Aug 26 16:11:36 localhost kernel: WARNING: CPU: 0 PID: 54 at lib/dma-debug.c:950 check_for_stack+0xa0/0x100() Aug 26 16:11:36 localhost kernel: ehci-pci :00:1a.0: DMA-API:

Re: kernel Oops: 0003 on usbhid_submit_report

2013-08-28 Thread Jiri Kosina
On Mon, 26 Aug 2013, Andreas Lillebø Holm wrote: > You are my hero Jiri :-) These two patches fixes the issues I was seeing > and I can no longer reproduce them. Thanks a lot for confirmation. This has been a very long-standing bug, but for some reasons I have started to see devices actually t

[PATCH v2 0/3] Add Generic USB VBUS/ID detection via GPIO using extcon

2013-08-28 Thread George Cherian
Hi, These patches add generic support for USB VBUS/ID pin detection using extcon framework. The USB ID pin on DRA7xx is connected via the gpio expander pcf8575. The interrupt line of the same is connected to the gpio 11 of bank 6. The following driver relies on the gpio interrupt to notify t

[PATCH v2 3/3] ARM: dts: dra7-evm: Add extcon nodes for USB ID pin detection

2013-08-28 Thread George Cherian
Add -extcon nodes for USB ID pin detection. -i2c nodes. -pcf nodes to which USB ID pin is connected. Signed-off-by: George Cherian --- arch/arm/boot/dts/dra7-evm.dts | 52 +- 1 file changed, 51 insertions(+), 1 deletion(-) diff --g

[PATCH v2 1/3] extcon: extcon-gpio-usbvid: Generic USB VBUS/ID detection via GPIO

2013-08-28 Thread George Cherian
Add a generic USB VBUS/ID detection EXTCON driver. This driver expects the ID/VBUS pin are connected via GPIOs. This driver is tested on DRA7x board were the ID pin is routed via GPIOs. The driver supports both VBUS and ID pin configuration and ID pin only configuration. Signed-off-by: George Cher

[PATCH v2 2/3] drivers: Makefile: Extcon is a framework so bump it up

2013-08-28 Thread George Cherian
Bump up the order, since extcon is a framework and needed by other drivers. With the previous order it failed to detect extcon device in DWC3 when both were compiled built-in. Signed-off-by: George Cherian --- drivers/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/d

Re: [PATCH 1/2] usb:gadget:dummy_hcd : Avoid infinite loop

2013-08-28 Thread Alan Stern
On Wed, 28 Aug 2013, Philippe De Swert wrote: > When an error occurs adding a platform device there is a risk of an infinite > loop. > If more than one platform device was added i will remain >= than 0. The > intention seems > to clean up all the different already added platform devices before t

Re: 3.4.4: disabling irq

2013-08-28 Thread Udo van den Heuvel
On 2013-08-27 19:43, Alan Stern wrote: >>> rmmod ohci-pci >>> modprobe dummy-irq irq=18 >>> >>> and see if the IRQ line gets disabled after that. >> >> Can I actually use that irq/ports that way? (as with no usage the >> problem does not occur) > > No, if you unload the ohci-hcd driver

Re: [PATCH 2/2] usb:gadget:dummy_hcd : Detect port and link state correctly to avoid unreachable code

2013-08-28 Thread Alan Stern
On Wed, 28 Aug 2013, Philippe De Swert wrote: > Since USB_SS_PORT_LS_U0 is 0x the & operation with the port state would > always be 0. Thus the if would never be true. The code tries to check if the > port is enabled and link is active (U0 state). This means the port_status > should be 0x0001

Re: Re:[RFT & RFC] USB: Fix USB device disconnects on resume.

2013-08-28 Thread Alan Stern
On Wed, 28 Aug 2013, Dmitri Zolotov wrote: > ~/linux-3.9.11$ grep -r "TRSMRCY" > drivers/usb/core/hub.c:/* TRSMRCY = 20 msec */ Where did that come from? In the 3.9.11 kernel this says 10, not 20. > drivers/usb/core/hub.c:/* TRSMRCY = 10 msec */ > drivers/usb/core/hcd.c:

Re: [PATCH v2 3/3] ARM: dts: dra7-evm: Add extcon nodes for USB ID pin detection

2013-08-28 Thread Sergei Shtylyov
Hello. On 08/28/2013 05:59 PM, George Cherian wrote: Add -extcon nodes for USB ID pin detection. -i2c nodes. -pcf nodes to which USB ID pin is connected. Signed-off-by: George Cherian --- arch/arm/boot/dts/dra7-evm.dts | 52 +

Re: ehci-pci 0000:00:1a.0: DMA-API: device driver maps memory fromstack

2013-08-28 Thread Alan Stern
On Wed, 28 Aug 2013, Richard Ryniker wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1001806 > > Aug 26 16:11:36 localhost kernel: [ cut here ] > Aug 26 16:11:36 localhost kernel: WARNING: CPU: 0 PID: 54 at > lib/dma-debug.c:950 check_for_stack+0xa0/0x100() > Aug 26 1

Re: ehci-pci 0000:00:1a.0: DMA-API: device driver maps memory fromstack

2013-08-28 Thread Jiri Kosina
On Wed, 28 Aug 2013, Alan Stern wrote: > > Aug 26 16:11:36 localhost kernel: [ cut here ] > > Aug 26 16:11:36 localhost kernel: WARNING: CPU: 0 PID: 54 at > > lib/dma-debug.c:950 check_for_stack+0xa0/0x100() > > Aug 26 16:11:36 localhost kernel: ehci-pci :00:1a.0: DMA-A

Re: [PATCH v3] xHCI: Fixing xhci_readl definition and function call

2013-08-28 Thread Kumar Gaurav
On Wednesday 28 August 2013 12:43 PM, Dan Carpenter wrote: On Mon, Aug 26, 2013 at 07:38:57AM +0530, Kumar Gaurav wrote: This patch redefine function xhci_readl.xhci_readl function doesn't use xhci_hcd argument. Hence there is no need of keeping it in the function arguments. Redefining this fu

Re: linux-next: Tree for Aug 28 [ xhci build breakage ]

2013-08-28 Thread Sedat Dilek
> linux/include/linux/dynamic_debug.h:76: >>>>>>> DEFINE_DYNAMIC_DEBUG_METADATA(descriptor, fmt); \ >>>>>>> linux/include/linux/dynamic_debug.h:78: >>>>>>> __dynamic_pr_debug(&descriptor, pr_fmt(fmt),\ >>>>>>&g

[PATCH 2nd RESEND] clk: tegra30: Don't wait for PLL_U lock bit

2013-08-28 Thread Tuomas Tynkkynen
The lock bit on PLL_U does not seem to be working correctly and sometimes never gets set when waiting for the PLL to come up. Remove the TEGRA_PLL_USE_LOCK flag to use a constant delay. Signed-off-by: Tuomas Tynkkynen Tested-by: Stephen Warren Acked-by: Stephen Warren --- drivers/clk/tegra/cl

[PATCH 2nd RESEND] Clock changes for Tegra30 USB Host support

2013-08-28 Thread Tuomas Tynkkynen
Hi all, This patch is required for USB support on Tegra30 due to a hardware quirk in the PLL_U oscillator which clocks the USB complex. The other USB patches for Tegra30 and Tegra114 are already on their way to 3.12, so it would be nice to have this one as well in 3.12. Diff from previous: Added

Re: [RFC v2] usb: Fix xHCI host issues on remote wakeup.

2013-08-28 Thread Sarah Sharp
On Tue, Aug 27, 2013 at 05:41:19PM -0700, Greg KH wrote: > On Mon, Aug 26, 2013 at 06:59:22PM -0700, Sarah Sharp wrote: > > I attempted to replicate this bug with Ubuntu 12.04, but could not. I > > used Ubuntu 12.04 on the same platform, with the same BIOS that the bug > > was triggered on ChromeO

Re: [PATCH] usb: dwc3: core: clarify usb-phy array binding

2013-08-28 Thread Mark Rutland
On Tue, Aug 27, 2013 at 07:53:29PM +0100, Felipe Balbi wrote: > Hi, > > On Tue, Aug 13, 2013 at 02:34:10PM +0100, Mark Rutland wrote: > > On Mon, Aug 12, 2013 at 07:05:53PM +0100, Felipe Balbi wrote: > > > On Fri, Aug 09, 2013 at 01:42:15PM -0500, Kumar Gala wrote: > > > > > > > > On Aug 9, 2013,

Re: [PATCH v1] USB: EHCI: disable IAA_WATCHDOG and START_UNLINK_INTR if they needn't to be handled

2013-08-28 Thread Alan Stern
On Wed, 28 Aug 2013, Ming Lei wrote: > > Think about it this way: Why did you write the "USB: EHCI: improve > > interrupt qh unlink" patch in the first place? Essentially the same > > reason applies to uhci-hcd and ohci-hcd, and they will need similar > > patches. > > Right, but drivers which su

Re: [RFC 3/3] EHCI: handle late isochronous submissions

2013-08-28 Thread Alan Stern
On Wed, 28 Aug 2013, Ming Lei wrote: > Below is the approach I proposed(mentioned in another thread), which should be > simper than this one, any comments? > > drivers/usb/host/ehci-sched.c | 53 > ++--- > drivers/usb/host/ehci.h |1 + > 2 files c

[Pull Request] xhci: Remove warnings introduced by host quirks patch.

2013-08-28 Thread Sarah Sharp
The following changes since commit 752e69555d107853043cb9405250c9387b26e708: Merge tag 'usb-for-v3.12-part2' of git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb into usb-next (2013-08-27 14:07:31 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kern

[PATCH 1/1] xhci: Fix warning introduced by disabling runtime PM.

2013-08-28 Thread Sarah Sharp
The 0day build server caught a new build warning that is triggered when CONFIG_USB_DEFAULT_PERSIST is turned on: tree: git://git.kernel.org/pub/scm/linux/kernel/git/sarah/xhci.git for-usb-next head: 0730d52a86919300a39a2be37f6c140997dfb82f commit: c8476fb855434c733099079063990e5bfa7ecad6 [1/3

Re: [PATCH v2 1/3] usb: add is_usb_mouse routine and remote wakeup quirk

2013-08-28 Thread Greg Kroah-Hartman
On Wed, Aug 28, 2013 at 04:09:32PM +0800, Huang Rui wrote: > On Wed, Aug 28, 2013 at 11:38:28AM +0800, Greg Kroah-Hartman wrote: > > On Wed, Aug 28, 2013 at 11:13:12AM +0800, Huang Rui wrote: > > > This patch add a routine to judge if the usb device is a mouse or not. > > > The is_usb_mouse only ha

Re: [Pull Request] xhci: Bug fixes for 3.12.

2013-08-28 Thread Greg Kroah-Hartman
On Wed, Aug 28, 2013 at 10:44:57AM +0300, Dmitry Kasatkin wrote: > On 27/08/13 21:26, Sarah Sharp wrote: > > The following changes since commit 154547c4fe0fbe92185e69a6cdc2b0502b361995: > > > > USB: serial: clean up attribute permissions (2013-08-25 15:12:03 -0700) > > > > are available in the gi

Re: linux-next: Tree for Aug 28 [ xhci build breakage ]

2013-08-28 Thread Sarah Sharp
Please trim your replies. On Wed, Aug 28, 2013 at 01:53:49PM +0300, Dmitry Kasatkin wrote: > >>> That change seems to cause the problems: > >>> > >>> commit 0730d52a86919300a39a2be37f6c140997dfb82f > >>> "xhci:prevent "callbacks suppressed" when debug is not enabled" > >>> > >>> - Sedat - > >>> >

Re: [Pull Request] xhci: Remove warnings introduced by host quirks patch.

2013-08-28 Thread Greg Kroah-Hartman
On Wed, Aug 28, 2013 at 09:51:18AM -0700, Sarah Sharp wrote: > The following changes since commit 752e69555d107853043cb9405250c9387b26e708: > > Merge tag 'usb-for-v3.12-part2' of > git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb into usb-next > (2013-08-27 14:07:31 -0700) > > are avai

Re: [PATCH v3] xHCI: Fixing xhci_readl definition and function call

2013-08-28 Thread Sarah Sharp
On Wed, Aug 28, 2013 at 08:39:06PM +0530, Kumar Gaurav wrote: > On Wednesday 28 August 2013 12:43 PM, Dan Carpenter wrote: > >On Mon, Aug 26, 2013 at 07:38:57AM +0530, Kumar Gaurav wrote: > I've started cloning linux-next and as it's not applying on > linux-next, I'll try it on linux-next (once i c

Re: [PATCH v2 1/3] usb: add is_usb_mouse routine and remote wakeup quirk

2013-08-28 Thread Alan Stern
On Wed, 28 Aug 2013, Greg Kroah-Hartman wrote: > > [Q] Why the special devices are only mice? Would high speed devices > > such as 3G modem or USB Bluetooth adapter trigger this issue? > > - Current this sensitivity is only confined to devices that use Pixart > > controllers. This controller is

Re: linux-next: Tree for Aug 28 [ xhci build breakage ]

2013-08-28 Thread Greg Kroah-Hartman
On Wed, Aug 28, 2013 at 09:59:38AM -0700, Sarah Sharp wrote: > Please trim your replies. > > On Wed, Aug 28, 2013 at 01:53:49PM +0300, Dmitry Kasatkin wrote: > > >>> That change seems to cause the problems: > > >>> > > >>> commit 0730d52a86919300a39a2be37f6c140997dfb82f > > >>> "xhci:prevent "call

Re: [RFC v2] usb: Fix xHCI host issues on remote wakeup.

2013-08-28 Thread Greg KH
On Wed, Aug 28, 2013 at 08:27:48AM -0700, Sarah Sharp wrote: > On Tue, Aug 27, 2013 at 05:41:19PM -0700, Greg KH wrote: > > On Mon, Aug 26, 2013 at 06:59:22PM -0700, Sarah Sharp wrote: > > > I attempted to replicate this bug with Ubuntu 12.04, but could not. I > > > used Ubuntu 12.04 on the same p

Re: [PATCH v3] xHCI: Fixing xhci_readl definition and function call

2013-08-28 Thread Kumar Gaurav
On Wednesday 28 August 2013 10:31 PM, Sarah Sharp wrote: On Wed, Aug 28, 2013 at 08:39:06PM +0530, Kumar Gaurav wrote: On Wednesday 28 August 2013 12:43 PM, Dan Carpenter wrote: On Mon, Aug 26, 2013 at 07:38:57AM +0530, Kumar Gaurav wrote: I've started cloning linux-next and as it's not applyi

Re: linux-next: Tree for Aug 28 [ xhci build breakage ]

2013-08-28 Thread Dmitry Kasatkin
On 28/08/13 19:59, Sarah Sharp wrote: > Please trim your replies. > > On Wed, Aug 28, 2013 at 01:53:49PM +0300, Dmitry Kasatkin wrote: > That change seems to cause the problems: > > commit 0730d52a86919300a39a2be37f6c140997dfb82f > "xhci:prevent "callbacks suppressed" when debug is

Re: [PATCH v2 1/3] usb: add is_usb_mouse routine and remote wakeup quirk

2013-08-28 Thread Greg Kroah-Hartman
On Wed, Aug 28, 2013 at 01:13:46PM -0400, Alan Stern wrote: > On Wed, 28 Aug 2013, Greg Kroah-Hartman wrote: > > > > [Q] Why the special devices are only mice? Would high speed devices > > > such as 3G modem or USB Bluetooth adapter trigger this issue? > > > - Current this sensitivity is only conf

Re: [RFC v2] usb: Fix xHCI host issues on remote wakeup.

2013-08-28 Thread Sarah Sharp
On Wed, Aug 28, 2013 at 10:26:01AM -0700, Greg KH wrote: > On Wed, Aug 28, 2013 at 08:27:48AM -0700, Sarah Sharp wrote: > > On Tue, Aug 27, 2013 at 05:41:19PM -0700, Greg KH wrote: > > > On Mon, Aug 26, 2013 at 06:59:22PM -0700, Sarah Sharp wrote: > > > > This patch should be backported to kernels

[PATCH v3 1/3] extcon: extcon-gpio-usbvid: Generic USB VBUS/ID detection via GPIO

2013-08-28 Thread George Cherian
Add a generic USB VBUS/ID detection EXTCON driver. This driver expects the ID/VBUS pin are connected via GPIOs. This driver is tested on DRA7x board were the ID pin is routed via GPIOs. The driver supports both VBUS and ID pin configuration and ID pin only configuration. Signed-off-by: George Cher

[PATCH v3 3/3] ARM: dts: dra7-evm: Add extcon nodes for USB ID pin detection

2013-08-28 Thread George Cherian
Add -extcon nodes for USB ID pin detection. -i2c nodes. -pcf nodes to which USB ID pin is connected. Signed-off-by: George Cherian --- arch/arm/boot/dts/dra7-evm.dts | 50 +- 1 file changed, 49 insertions(+), 1 deletion(-) diff --g

Re: [PATCH v2 0/3] Add Generic USB VBUS/ID detection via GPIO using extcon

2013-08-28 Thread George Cherian
On 8/28/2013 7:29 PM, George Cherian wrote: Hi, These patches add generic support for USB VBUS/ID pin detection using extcon framework. The USB ID pin on DRA7xx is connected via the gpio expander pcf8575. The interrupt line of the same is connected to the gpio 11 of bank 6. The following driver

Re: [PATCH v3] xHCI: Fixing xhci_readl definition and function call

2013-08-28 Thread Sarah Sharp
On Wed, Aug 28, 2013 at 10:45:48PM +0530, Kumar Gaurav wrote: > On Wednesday 28 August 2013 10:31 PM, Sarah Sharp wrote: > >On Wed, Aug 28, 2013 at 08:39:06PM +0530, Kumar Gaurav wrote: > >>On Wednesday 28 August 2013 12:43 PM, Dan Carpenter wrote: > >>>On Mon, Aug 26, 2013 at 07:38:57AM +0530, Kum

Re: [Pull Request] xhci: Remove warnings introduced by host quirks patch.

2013-08-28 Thread Sarah Sharp
On Wed, Aug 28, 2013 at 10:09:44AM -0700, Greg Kroah-Hartman wrote: > On Wed, Aug 28, 2013 at 09:51:18AM -0700, Sarah Sharp wrote: > > The following changes since commit 752e69555d107853043cb9405250c9387b26e708: > > > > Merge tag 'usb-for-v3.12-part2' of > > git://git.kernel.org/pub/scm/linux/k

Re: linux-next: Tree for Aug 28 [ xhci build breakage ]

2013-08-28 Thread Sarah Sharp
On Wed, Aug 28, 2013 at 10:18:24AM -0700, Greg Kroah-Hartman wrote: > On Wed, Aug 28, 2013 at 09:59:38AM -0700, Sarah Sharp wrote: > > Please trim your replies. > > > > On Wed, Aug 28, 2013 at 01:53:49PM +0300, Dmitry Kasatkin wrote: > > > >>> That change seems to cause the problems: > > > >>> > >

Re: linux-next: Tree for Aug 28 [ xhci build breakage ]

2013-08-28 Thread Sedat Dilek
On Wed, Aug 28, 2013 at 7:24 PM, Dmitry Kasatkin wrote: > On 28/08/13 19:59, Sarah Sharp wrote: >> Please trim your replies. >> >> On Wed, Aug 28, 2013 at 01:53:49PM +0300, Dmitry Kasatkin wrote: >> That change seems to cause the problems: >> >> commit 0730d52a86919300a39a2be37f6c14099

[PATCH v3 0/3] Add Generic USB VBUS/ID detection via GPIO using extcon

2013-08-28 Thread George Cherian
Hi, These patches add generic support for USB VBUS/ID pin detection using extcon framework. The USB ID pin on DRA7xx is connected via the gpio expander pcf8575. The interrupt line of the same is connected to the gpio 11 of bank 6. The following driver relies on the gpio interrupt to notify the

[PATCH v3 1/1] dev-core: fix build break when DEBUG is enabled

2013-08-28 Thread Sarah Sharp
Any objections to queuing this patch through Greg's usb-next tree? I've already sent the 2/2 patch, which will cause build breakage without this patch. Changes since v2: - Fixed a checkpatch warning caused by a comment in a macro. Sarah Sharp >8-

[PATCH v3 2/3] drivers: Makefile: Extcon is a framework so bump it up

2013-08-28 Thread George Cherian
Bump up the order, since extcon is a framework and needed by other drivers. With the previous order it failed to detect extcon device in DWC3 when both were compiled built-in. Signed-off-by: George Cherian --- drivers/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/d

Re: [PATCH v3 1/1] dev-core: fix build break when DEBUG is enabled

2013-08-28 Thread Greg KH
On Wed, Aug 28, 2013 at 10:50:31AM -0700, Sarah Sharp wrote: > Any objections to queuing this patch through Greg's usb-next tree? I've > already sent the 2/2 patch, which will cause build breakage without this > patch. > > Changes since v2: > - Fixed a checkpatch warning caused by a comment in a

Re: [PATCH v3 3/3] ARM: dts: dra7-evm: Add extcon nodes for USB ID pin detection

2013-08-28 Thread Sergei Shtylyov
On 08/28/2013 09:33 PM, George Cherian wrote: Add -extcon nodes for USB ID pin detection. -i2c nodes. -pcf nodes to which USB ID pin is connected. Signed-off-by: George Cherian --- arch/arm/boot/dts/dra7-evm.dts | 50 +- 1 fi

Re: [PATCH] usb: phy: samsung-usb2: Toggle HSIC GPIO from device tree

2013-08-28 Thread Julius Werner
I've tried to get the 3503 driver to work in my case for quite some time, but ultimately gave up. For me, playing around with the load order was not enough to solve all issues. When you try to build a permanent, clean solution for this, you should definitely also test the case where the hub has alr

Re: [alsa-devel] Buffer size for ALSA USB PCM audio

2013-08-28 Thread Alan Stern
On Wed, 28 Aug 2013, Clemens Ladisch wrote: > Sorry, what I said applies more to explicit sync endpoints. When using > implicit sync, a playback URB is submitted for each completed capture > URB, with the number of samples per packet identical to the > corresponding capture packet, so the paramet

Re: [PATCH v2 1/3] usb: add is_usb_mouse routine and remote wakeup quirk

2013-08-28 Thread Alan Stern
On Wed, 28 Aug 2013, Greg Kroah-Hartman wrote: > On Wed, Aug 28, 2013 at 01:13:46PM -0400, Alan Stern wrote: > > On Wed, 28 Aug 2013, Greg Kroah-Hartman wrote: > > > > > > [Q] Why the special devices are only mice? Would high speed devices > > > > such as 3G modem or USB Bluetooth adapter trigger

Re: [PATCH v3] xHCI: Fixing xhci_readl definition and function call

2013-08-28 Thread Dan Carpenter
On Wed, Aug 28, 2013 at 08:39:06PM +0530, Kumar Gaurav wrote: > On Wednesday 28 August 2013 12:43 PM, Dan Carpenter wrote: > >On Mon, Aug 26, 2013 at 07:38:57AM +0530, Kumar Gaurav wrote: > >>This patch redefine function xhci_readl.xhci_readl function doesn't use > >>xhci_hcd argument. > >>Hence t

Re: Memory synchronization vs. interrupt handlers

2013-08-28 Thread Alan Stern
Russell, Peter, and Ingo: Can you folks enlighten us regarding this issue for some common architectures? On Tue, 27 Aug 2013, Paul E. McKenney wrote: > On Mon, Aug 26, 2013 at 11:49:15AM -0400, Alan Stern wrote: > > David and Paul: > > > > Here's a question that doesn't seem to be answered in

Re: 3.4.4: disabling irq

2013-08-28 Thread Alan Stern
On Wed, 28 Aug 2013, Udo van den Heuvel wrote: > On 2013-08-27 19:43, Alan Stern wrote: > >>> rmmod ohci-pci > >>> modprobe dummy-irq irq=18 > >>> > >>> and see if the IRQ line gets disabled after that. > >> > >> Can I actually use that irq/ports that way? (as with no usage the > >> pr

Re: [Bug] [Sony VAIO SVT15117CXS] USB 2.0 ports not working with any USB device

2013-08-28 Thread Alan Stern
On Tue, 27 Aug 2013, Kevin Archer wrote: > rmmod xhci-hcd yields: > libkmod: ERROR ../libkmod/libkmod-module.c:753 > kmod_module_remove_module: could not remove 'xhci_hcd': No such file > or directory > Error: could not remove module xhci-hcd: No such file or directory Oops. Apparently the drive

Re: Memory synchronization vs. interrupt handlers

2013-08-28 Thread H. Peter Anvin
On 08/28/2013 12:16 PM, Alan Stern wrote: > Russell, Peter, and Ingo: > > Can you folks enlighten us regarding this issue for some common > architectures? > On x86, IRET is a serializing instruction; it guarantees hard serialization of absolutely everything. I would expect architectures that h

Re: Bug report: 045e:0721 Microsoft LifeCam NX-3000 not detected

2013-08-28 Thread Alan Stern
On Wed, 28 Aug 2013, Jürgen Liebmann wrote: > In the attachment the both usbmon traces: > > usbmon-reverted.out (camera works ok) > usbmon-74a6af256648 (camera fails) This is very strange indeed. Here's where the two traces start to get different results. In the kernel with the commit revert

Re: linux-next: Tree for Aug 28 [ xhci build breakage ]

2013-08-28 Thread Sarah Sharp
On Wed, Aug 28, 2013 at 07:39:14PM +0200, Sedat Dilek wrote: > On Wed, Aug 28, 2013 at 7:24 PM, Dmitry Kasatkin > wrote: > Still noone answered me why "drivers/usb/host/xhci-ring.c" does NOT > include (dev_info_ratelimited() and other defines). > I am expecting that... even I see... > >

Re: [PATCH] USB2NET : SR9700 : One chip USB 1.1 USB2NET SR9700 Device Driver Support

2013-08-28 Thread David Miller
From: liujunliang_...@163.com Date: Sat, 24 Aug 2013 19:26:00 +0800 > From: liujl Your proper name is not "liujl", please put something more reasonable here and also in your Signoff. Also, integrate Joe Perches's white space fixes into this patch as part of your resubmission. Thank you. -- To

Re: [PATCH] usb: xhci-plat: Enable USB 2.0 hardware LPM support for platform xHCs

2013-08-28 Thread Sarah Sharp
On Mon, Aug 26, 2013 at 07:37:56PM +, Paul Zimmerman wrote: > > From: Sarah Sharp [mailto:sarah.a.sh...@linux.intel.com] > > Sent: Monday, August 26, 2013 12:14 PM > > > > On Thu, Aug 22, 2013 at 05:11:49AM +, Paul Zimmerman wrote: > > > > From: Julius Werner > > > > Sent: Wednesday, Augus

[PATCH 2/2] xhci: Fix warning introduced by disabling runtime PM.

2013-08-28 Thread Sarah Sharp
The 0day build server caught a new build warning that is triggered when CONFIG_USB_DEFAULT_PERSIST is turned on: tree: git://git.kernel.org/pub/scm/linux/kernel/git/sarah/xhci.git for-usb-next head: 0730d52a86919300a39a2be37f6c140997dfb82f commit: c8476fb855434c733099079063990e5bfa7ecad6 [1/3

[Pull Request] xhci: Fix build breakage and new warnings.

2013-08-28 Thread Sarah Sharp
The following changes since commit 752e69555d107853043cb9405250c9387b26e708: Merge tag 'usb-for-v3.12-part2' of git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb into usb-next (2013-08-27 14:07:31 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kern

[PATCH 1/2] dev-core: fix build break when DEBUG is enabled

2013-08-28 Thread Sarah Sharp
From: Dmitry Kasatkin When DEBUG is defined, dev_dbg_ratelimited uses dynamic debug data structures even when CONFIG_DYNAMIC_DEBUG is not defined. It leads to build break. For example, when I try to use dev_dbg_ratelimited in USB code and CONFIG_USB_DEBUG is enabled, but CONFIG_DYNAMIC_DEBUG is n

RE: [PATCH] usb: xhci-plat: Enable USB 2.0 hardware LPM support for platform xHCs

2013-08-28 Thread Paul Zimmerman
> From: Sarah Sharp [mailto:sarah.a.sh...@linux.intel.com] > Sent: Wednesday, August 28, 2013 2:52 PM > > On Mon, Aug 26, 2013 at 07:37:56PM +, Paul Zimmerman wrote: > > > From: Sarah Sharp [mailto:sarah.a.sh...@linux.intel.com] > > > Sent: Monday, August 26, 2013 12:14 PM > > > > > > On Thu,

Re: [PATCH net,stable] net: usb: Add HP hs2434 device to ZLP exception table

2013-08-28 Thread David Miller
From: Rob Gardner Date: Sun, 25 Aug 2013 18:29:13 -0600 > From 018343ce2e679d97283fb51da25c43aa876d087a Mon Sep 17 00:00:00 2001 > From: Rob Gardner > Date: Sun, 25 Aug 2013 16:02:23 -0600 > Subject: [PATCH net,stable] net: usb: Add HP hs2434 device to ZLP exception > table > > This patch adds

Re: [Pull Request] xhci: Fix build breakage and new warnings.

2013-08-28 Thread Greg Kroah-Hartman
On Wed, Aug 28, 2013 at 03:15:14PM -0700, Sarah Sharp wrote: > The following changes since commit 752e69555d107853043cb9405250c9387b26e708: > > Merge tag 'usb-for-v3.12-part2' of > git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb into usb-next > (2013-08-27 14:07:31 -0700) > > are avai

Re: [patch] dma: cppi41: off by one in desc_to_chan()

2013-08-28 Thread Greg Kroah-Hartman
On Wed, Aug 28, 2013 at 01:48:44PM +0300, Dan Carpenter wrote: > The test here should be ">=" instead of ">". The cdd->chan_busy[] array > has "ALLOC_DECS_NUM" elements. > > Signed-off-by: Dan Carpenter > Acked-by: Vinod Koul > --- > Resending to Greg and the USB people because Vinod says this

Re: [PATCH] usb: xhci-plat: Enable USB 2.0 hardware LPM support for platform xHCs

2013-08-28 Thread Julius Werner
> So the 2.41a has BESL support, but may not set the BLC flag. What > happens if we use the HIRD encoding instead? Will things break? It > seems like we would need to disable USB 2.0 LPM on that host all > together, if it expects BESL encoding, but advertises HIRD encoding. Wait a second, just

Re: [PATCH net,stable] net: usb: Add HP hs2434 device to ZLP exception table

2013-08-28 Thread Rob Gardner
On Wed, 28 Aug 2013 18:23:32 -0400 (EDT) David Miller wrote: > From: Rob Gardner > Date: Sun, 25 Aug 2013 18:29:13 -0600 > > > From 018343ce2e679d97283fb51da25c43aa876d087a Mon Sep 17 00:00:00 2001 > > From: Rob Gardner > > Date: Sun, 25 Aug 2013 16:02:23 -0600 > > Subject: [PATCH net,stable]

[PATCH] usb: acm gadget: Null termintate strings table

2013-08-28 Thread Graham Williams
The gadget strings table should be null terminated. usb_gadget_get_string() loops through the table expecting a null at the end of the list. Signed-off-by: Graham Williams --- drivers/usb/gadget/f_acm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/gadget/f_acm.c b/drivers/usb/

Re: [PATCH net,stable] net: usb: Add HP hs2434 device to ZLP exception table

2013-08-28 Thread David Miller
From: Rob Gardner Date: Wed, 28 Aug 2013 17:18:12 -0600 > Bjørn says it could have a minor performance impact, but should not > cause any loss of functionality. I don't think there's any hard data on > what the performance cost might be but I know he would eventually like > to get rid of the exce

Re: [PATCH net,stable] net: usb: Add HP hs2434 device to ZLP exception table

2013-08-28 Thread Rob Gardner
On Wed, 28 Aug 2013 20:01:11 -0400 (EDT) David Miller wrote: > From: Rob Gardner > Date: Wed, 28 Aug 2013 17:18:12 -0600 > > > Bjørn says it could have a minor performance impact, but should not > > cause any loss of functionality. I don't think there's any hard data on > > what the performance

Re: [RFC 3/3] EHCI: handle late isochronous submissions

2013-08-28 Thread Ming Lei
On Thu, Aug 29, 2013 at 12:23 AM, Alan Stern wrote: > On Wed, 28 Aug 2013, Ming Lei wrote: > >> Below is the approach I proposed(mentioned in another thread), which should >> be >> simper than this one, any comments? >> >> drivers/usb/host/ehci-sched.c | 53 >>

Re: [PATCH v3 1/3] extcon: extcon-gpio-usbvid: Generic USB VBUS/ID detection via GPIO

2013-08-28 Thread Chanwoo Choi
Hi George, You didn't modify this patchset about my comment on v1 patchset. Please pay attention to comment. On 08/29/2013 02:33 AM, George Cherian wrote: > Add a generic USB VBUS/ID detection EXTCON driver. This driver expects > the ID/VBUS pin are connected via GPIOs. This driver is tested on >

Re: [PATCH v3 1/3] extcon: extcon-gpio-usbvid: Generic USB VBUS/ID detection via GPIO

2013-08-28 Thread George Cherian
Hi Chanwoo, Thanks for the review and sorry for all the trivial mistakes. On 8/29/2013 7:05 AM, Chanwoo Choi wrote: Hi George, You didn't modify this patchset about my comment on v1 patchset. Please pay attention to comment. On 08/29/2013 02:33 AM, George Cherian wrote: Add a generic USB VBU

Re: [RFC 3/3] EHCI: handle late isochronous submissions

2013-08-28 Thread Ming Lei
On Wed, 28 Aug 2013 12:23:31 -0400 (EDT) Alan Stern wrote: > You must never alter ehci->last_iso_frame like this. It violates the > driver's invariants for time to run "backward". After all, there may > already be other TDs scheduled for the frames you are about to scan > again; they mustn't

Re: [PATCH v3 3/3] ARM: dts: dra7-evm: Add extcon nodes for USB ID pin detection

2013-08-28 Thread George Cherian
On 8/28/2013 11:24 PM, Sergei Shtylyov wrote: On 08/28/2013 09:33 PM, George Cherian wrote: Add -extcon nodes for USB ID pin detection. -i2c nodes. -pcf nodes to which USB ID pin is connected. Signed-off-by: George Cherian --- arch/arm/boot/dts/dra7-evm.dts | 50 +

Re: [PATCH 2/4] usb: r8a66597-hcd: use platform_{get,set}_drvdata()

2013-08-28 Thread Libo Chen
On 2013/8/28 12:36, Greg KH wrote: > On Tue, Aug 27, 2013 at 04:10:22PM +0800, Libo Chen wrote: >> >> Use the wrapper functions for getting and setting the driver data using >> platform_device instead of using dev_{get,set}_drvdata() with &pdev->dev, >> so we can directly pass a struct platform_dev

  1   2   >