[PATCH -next] usb: musb: cppi41: fix missing unlock on error in cppi41_dma_callback()

2013-08-18 Thread Wei Yongjun
From: Wei Yongjun Add the missing unlock before return from function cppi41_dma_callback() in the error handling case. Signed-off-by: Wei Yongjun --- drivers/usb/musb/musb_cppi41.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/usb/musb/musb_cppi41.c b/drivers/u

Re: [PATCH v1 02/49] USB: sg: prepare for enabling irq in complete()

2013-08-18 Thread Ming Lei
On Sun, Aug 18, 2013 at 9:01 AM, Alan Stern wrote: > On Sun, 18 Aug 2013, Ming Lei wrote: > >> Complete() will be run with interrupt enabled, so change to >> spin_lock_irqsave(). >> >> Cc: Alan Stern >> Signed-off-by: Ming Lei >> --- >> drivers/usb/core/message.c |5 +++-- >> 1 file changed

USB configfs questions and help

2013-08-18 Thread Philippe
Hi, Last week I discovered the new configfs for the USB gadget support in the kernel. I found the following threads on the mailing list: https://lkml.org/lkml/2012/6/21/154 https://lkml.org/lkml/2012/11/26/38 Now there is some discussion about having a userpace library to handle the creation

[PATCH] usb:gadget Fix comment for pointer to configfs

2013-08-18 Thread Philippe De Swert
The documentation for the USB gadget fs is actually in Documentation/usb/gadget_configfs.txt. Signed-off-by: Philippe De Swert --- drivers/usb/gadget/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig index 8e93683.

Re: octeon-usb and dwc2 in staging are for the same hw

2013-08-18 Thread Aaro Koskinen
Hi, On Sat, Aug 17, 2013 at 08:44:18PM +, Paul Zimmerman wrote: > > It doesn't get very far: > > > > External DMA Mode not supported > > dwc2_hcd_init() FAILED, returning -22 > > Hi Greg, all, > > After taking a look at the Octeon driver, it looks like that controller > uses a custo

Re: [PATCH v1 26/49] input: cm109: prepare for enabling irq in complete()

2013-08-18 Thread Ming Lei
Hi Dmitry, On Sun, Aug 18, 2013 at 11:37 AM, Dmitry Torokhov wrote: > Hi Ming, > > On Sun, Aug 18, 2013 at 12:24:51AM +0800, Ming Lei wrote: >> Complete() will be run with interrupt enabled, so change to >> spin_lock_irqsave(). > > I think cm109 needs some love in it's URB handling, but this patc

Re: [PATCH v1 02/49] USB: sg: prepare for enabling irq in complete()

2013-08-18 Thread Alan Stern
On Sun, 18 Aug 2013, Ming Lei wrote: > > As far as I can see, these don't need to disable interrupts. All they > > protect against is the code in usb_sg_wait() and usb_sg_cancel(), which > > both run in process context. > > Yes. > > > But will lockdep complain if they don't disable interrupts?

Re: USB configfs questions and help

2013-08-18 Thread Alan Stern
On Sun, 18 Aug 2013, Philippe wrote: > Hi, > > Last week I discovered the new configfs for the USB gadget support in > the kernel. > > I found the following threads on the mailing list: > https://lkml.org/lkml/2012/6/21/154 > https://lkml.org/lkml/2012/11/26/38 > > Now there is some discussion

[PATCH] USB: musb: Avoid null pointer dereference in debug logging

2013-08-18 Thread Maarten ter Huurne
Since commit 511f3c53 usb_gadget_remove_driver will pass NULL for the driver argument. Signed-off-by: Maarten ter Huurne --- drivers/usb/musb/musb_gadget.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/musb/musb_gadget.c b/drivers/usb/musb/musb_gadget.c index

Re: [alsa-devel] Buffer size for ALSA USB PCM audio

2013-08-18 Thread Clemens Ladisch
Alan Stern wrote: > On Tue, 13 Aug 2013, Clemens Ladisch wrote: >>> The difference is that this version tries always to keep a period's >>> worth of bytes in the USB hardware queue. >> >> Having truncated URBs is possible only when URBs are shorter than one >> period, > > No. URBs are truncated wh

Re: [PATCH v1 26/49] input: cm109: prepare for enabling irq in complete()

2013-08-18 Thread Greg Kroah-Hartman
On Sun, Aug 18, 2013 at 10:10:15PM +0800, Ming Lei wrote: > Hi Dmitry, > > On Sun, Aug 18, 2013 at 11:37 AM, Dmitry Torokhov > wrote: > > Hi Ming, > > > > On Sun, Aug 18, 2013 at 12:24:51AM +0800, Ming Lei wrote: > >> Complete() will be run with interrupt enabled, so change to > >> spin_lock_irqs

[PATCH] USB: serial: fix stringify operator in usb-serial-simple

2013-08-18 Thread Yann Droneaud
From: Yann Droneaud usb-serial-simple uses an unknown stringify macro that make all drivers being named "stringify(vendor)". This can be a problem when two drivers have the same (wrong) name: kernel: usbcore: registered new interface driver usb_serial_simple kernel: usbserial: USB Seria

Re: [PATCH] USB: serial: fix stringify operator in usb-serial-simple

2013-08-18 Thread Greg Kroah-Hartman
On Sun, Aug 18, 2013 at 09:29:00PM +0200, Yann Droneaud wrote: > From: Yann Droneaud > > usb-serial-simple uses an unknown stringify macro that make > all drivers being named "stringify(vendor)". > > This can be a problem when two drivers have the same (wrong) name: > > kernel: usbcore: reg

RE: octeon-usb and dwc2 in staging are for the same hw

2013-08-18 Thread Paul Zimmerman
> From: Aaro Koskinen [mailto:aaro.koski...@iki.fi] > Sent: Sunday, August 18, 2013 4:41 AM > > On Sat, Aug 17, 2013 at 08:44:18PM +, Paul Zimmerman wrote: > > > It doesn't get very far: > > > > > > External DMA Mode not supported > > > dwc2_hcd_init() FAILED, returning -22 > > > > Hi Greg

Re: [PATCH] USB: serial: fix stringify operator in usb-serial-simple

2013-08-18 Thread Yann Droneaud
Le 18.08.2013 21:40, Greg Kroah-Hartman a écrit : On Sun, Aug 18, 2013 at 09:29:00PM +0200, Yann Droneaud wrote: Ugh, sorry about that, I thought there used to be a stringify() macro that used to do this. Nice patch, I'll queue it up. That's __stringify() which is defined in but: 1) inside

[PATCH 1/4] usb: gadget: USB_FUSB300 should depend on HAS_DMA

2013-08-18 Thread Geert Uytterhoeven
If NO_DMA=y: drivers/built-in.o: In function `fusb300_set_idma': drivers/usb/gadget/fusb300_udc.c:946: undefined reference to `usb_gadget_map_request' drivers/usb/gadget/fusb300_udc.c:958: undefined reference to `usb_gadget_unmap_request' Signed-off-by: Geert Uytterhoeven --- drivers/usb/gadg

[PATCH 2/4] usb: gadget: USB_R8A66597 should depend on HAS_DMA

2013-08-18 Thread Geert Uytterhoeven
If NO_DMA=y: drivers/built-in.o: In function `sudmac_free_channel': drivers/usb/gadget/r8a66597-udc.c:676: undefined reference to `usb_gadget_unmap_request' drivers/built-in.o: In function `sudmac_alloc_channel': drivers/usb/gadget/r8a66597-udc.c:666: undefined reference to `usb_gadget_map_reque

[PATCH 4/4] usb: chipidea: USB_CHIPIDEA should depend on HAS_DMA

2013-08-18 Thread Geert Uytterhoeven
If NO_DMA=y: drivers/built-in.o: In function `dma_set_coherent_mask': include/linux/dma-mapping.h:93: undefined reference to `dma_supported' Signed-off-by: Geert Uytterhoeven --- drivers/usb/chipidea/Kconfig |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/chip

[PATCH 3/4] usb: gadget: USB_NET2272_DMA should depend on HAS_DMA

2013-08-18 Thread Geert Uytterhoeven
If NO_DMA=y: drivers/built-in.o: In function `net2272_done': drivers/usb/gadget/net2272.c:386: undefined reference to `usb_gadget_unmap_request' drivers/built-in.o: In function `net2272_queue': drivers/usb/gadget/net2272.c:848: undefined reference to `usb_gadget_map_request' Signed-off-by: Geer

Re: [PATCH] usb: USB host support should depend on HAS_DMA

2013-08-18 Thread Geert Uytterhoeven
On Thu, Jul 11, 2013 at 1:12 AM, Arnd Bergmann wrote: > On Wednesday 10 July 2013, Alan Stern wrote: >> This isn't right. There are USB host controllers that use PIO, not >> DMA. The HAS_DMA dependency should go with the controller driver, not >> the USB core. >> >> On the other hand, the USB co

Re: USB configfs questions and help

2013-08-18 Thread Philippe De Swert
Hi, On 18/08/13 17:52, Alan Stern wrote: Now there is some discussion about having a userpace library to handle the creation of all the necessary files easily. But I cannot find a trace of it. Does it exist already? No mention of it has appeared on the mailing list. From: https://lkml.org/lk

Re: [PATCH] USB: musb: Avoid null pointer dereference in debug logging

2013-08-18 Thread Sergei Shtylyov
Hello. On 18-08-2013 20:21, Maarten ter Huurne wrote: Since commit 511f3c53 usb_gadget_remove_driver will pass NULL for the Please also specify that commit's summary line in parens. driver argument. Signed-off-by: Maarten ter Huurne --- drivers/usb/musb/musb_gadget.c | 3 ++- 1 fi

Re: [PATCH v1 02/49] USB: sg: prepare for enabling irq in complete()

2013-08-18 Thread Ming Lei
On Sun, Aug 18, 2013 at 10:44 PM, Alan Stern wrote: > On Sun, 18 Aug 2013, Ming Lei wrote: > >> > As far as I can see, these don't need to disable interrupts. All they >> > protect against is the code in usb_sg_wait() and usb_sg_cancel(), which >> > both run in process context. >> >> Yes. >> >> >

Re: USB configfs questions and help

2013-08-18 Thread Alan Stern
On Mon, 19 Aug 2013, Philippe De Swert wrote: > Hi, > > On 18/08/13 17:52, Alan Stern wrote: > >> Now there is some discussion about having a userpace library to handle > >> the creation of all the necessary files easily. But I cannot find a > >> trace of it. Does it exist already? > > > > No men

Re: [PATCH] usb: phy: Cleanup error code in **_usb_get_phy_**() APIs

2013-08-18 Thread Vivek Gautam
Hi, On Thu, Aug 8, 2013 at 12:05 AM, Julius Werner wrote: >> @@ -94,11 +94,11 @@ static int devm_usb_phy_match(struct device *dev, void >> *res, void *match_data) >> */ >> struct usb_phy *devm_usb_get_phy(struct device *dev, enum usb_phy_type type) >> { >> - struct usb_phy **ptr, *phy

Re: [PATCH 4/4] usb: chipidea: USB_CHIPIDEA should depend on HAS_DMA

2013-08-18 Thread Peter Chen
On Sun, Aug 18, 2013 at 10:20:44PM +0200, Geert Uytterhoeven wrote: > If NO_DMA=y: > > drivers/built-in.o: In function `dma_set_coherent_mask': > include/linux/dma-mapping.h:93: undefined reference to `dma_supported' > > Signed-off-by: Geert Uytterhoeven > --- > drivers/usb/chipidea/Kconfig |

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-08-18 Thread Kishon Vijay Abraham I
Felipe, ping.. On Wednesday 14 August 2013 08:35 PM, Kishon Vijay Abraham I wrote: > Hi, > > On Wednesday 14 August 2013 04:34 AM, Tomasz Figa wrote: >> On Wednesday 14 of August 2013 00:19:28 Sylwester Nawrocki wrote: >>> W dniu 2013-08-13 14:05, Kishon Vijay Abraham I pisze: On Tuesday 13

[PATCH] USB: musb: Avoid null pointer dereference in debug logging

2013-08-18 Thread Maarten ter Huurne
Since commit 511f3c53 (usb: gadget: udc-core: fix a regression during gadget driver unbinding) usb_gadget_remove_driver will pass NULL for the driver argument. Signed-off-by: Maarten ter Huurne --- drivers/usb/musb/musb_gadget.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

Re: [PATCH] dma: cpp41: make it compile with CONFIG_BUG=n

2013-08-18 Thread Vinod Koul
On Fri, Aug 16, 2013 at 05:40:55PM +0200, Sebastian Andrzej Siewior wrote: > From: Sebastian Andrzej Siewior > > Before Randy figures out that this does not compile with CONFIG_BUG=n > here is a fix for it. > > Signed-off-by: Sebastian Andrzej Siewior Acked-by: Vinod Koul ~Vinod > --- > driv