[patch] USB: mos7720: use GFP_ATOMIC under spinlock

2013-08-16 Thread Dan Carpenter
The write_parport_reg_nonblock() function shouldn't sleep because it's called with spinlocks held. Signed-off-by: Dan Carpenter --- diff --git a/drivers/usb/serial/mos7720.c b/drivers/usb/serial/mos7720.c index b013001..248fda6 100644 --- a/drivers/usb/serial/mos7720.c +++ b/drivers/usb/serial/m

[PATCH 0/3] usb: dwc3: PHY should be selected when glue is enabled

2013-08-16 Thread Huang Rui
Hi Felipe, USB transceivers should be selected when platform glues are enabled. Because it need initialize usb phy platform device for binding related phy driver when gules are probing. Patch 1 and patch 2 add NOP USB transceivers into Kconfig of PCI and Exynos glue. I tested them based on PCI gl

[PATCH 3/3] usb: dwc3: omap: omap_usb3 should be selected for dwc3-omap

2013-08-16 Thread Huang Rui
OMAP USB3 PHY should be selected when OMAP5 platforms are enabled. If OMAP USB3 PHY are disabled, during dwc3-omap probing process, the driver can not find transceiver of USB3 PHY. Signed-off-by: Huang Rui --- drivers/usb/dwc3/Kconfig |1 + 1 file changed, 1 insertion(+) diff --git a/driver

[PATCH 1/3] usb: dwc3: pci: nop_usb_xceiv should be selected for dwc3-pci

2013-08-16 Thread Huang Rui
NOP USB transceiver should be selected when PCIe-based platforms are enabled. Because it need initialize usb phy platform device for binding related phy driver when pci gule are probing. If NOP USB transceiver is disabled, during dwc3-pci probing process, the driver can not find transceivers of bot

[PATCH 2/3] usb: dwc3: exynos: nop_usb_xceiv should be selected for dwc3-exynos

2013-08-16 Thread Huang Rui
NOP USB transceiver should be selected when Exynos platforms are enabled. Because it need initialize usb phy platform device for binding related phy driver when exynos gule are probing. If NOP USB transceiver is disabled, during dwc3-exynos probing process, the driver can not find transceivers of b

[RFC 1/2] xhci: remove unused argument from xhci_giveback_urb_in_irq()

2013-08-16 Thread Xenia Ragiadakou
This patch removes the "adjective" argument from xhci_giveback_urb_in_irq(), since it is not used in the function anymore. Signed-off-by: Xenia Ragiadakou --- drivers/usb/host/xhci-ring.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/usb/host/xhci-ring.c b/d

[RFC 2/2] xhci: refactor handle_cmd_completion() switch into separate function

2013-08-16 Thread Xenia Ragiadakou
This patch refactors the big switch statement in handle_cmd_completion() into a separate function, called handle_cmd_completion2() (this name is temporary, we will need a different name). There have been declared some additional local variables, such as cmd_trb, cmd_comp_code, cmd_type, add_flags

[patch] usb: chipidea: fix a NULL dereference on error

2013-08-16 Thread Dan Carpenter
The regulator_disable() function can't accept NULL pointers so we need to add a check. Signed-off-by: Dan Carpenter diff --git a/drivers/usb/chipidea/host.c b/drivers/usb/chipidea/host.c index 6f96795..abfb1cc 100644 --- a/drivers/usb/chipidea/host.c +++ b/drivers/usb/chipidea/host.c @@ -88,7 +8

[PATCH net-next 1/7] r8152: remove clearing the memory to zero for netdev priv

2013-08-16 Thread Hayes Wang
Remove memset(tp, 0, sizeof(*tp)); Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index ef2498c..c13662b 100644 --- a/drivers/net/usb/r8152.c +++ b/drivers/net/usb/r8152.c @@ -2105,7 +2105

[PATCH net-next 3/7] r8152: replace lockflags with flags

2013-08-16 Thread Hayes Wang
Replace lockflags with flags. Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 48 1 file changed, 24 insertions(+), 24 deletions(-) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index a18f02d..41b99ce 100644 --- a/drivers

[PATCH net-next 4/7] r8152: adjust some duplicated code

2013-08-16 Thread Hayes Wang
- Use r8152_get_tx_agg for getting tx agg list - Replace submit rx with goto submit Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 55 + 1 file changed, 28 insertions(+), 27 deletions(-) diff --git a/drivers/net/usb/r8152.c b/drivers/net/

[PATCH net-next 2/7] r8152: replace void * with struct r8152 *

2013-08-16 Thread Hayes Wang
Change the type of contex of tx_agg and rx_agg from void * to staruc r8152 *. Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index c13662b..a18f02d 100644 --- a/driv

[PATCH net-next 7/7] r8152: add comments

2013-08-16 Thread Hayes Wang
Add comments. Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index 825edfe..f3fce41 100644 --- a/drivers/net/usb/r8152.c +++ b/drivers/net/usb/r8152.c @@ -790,6 +790,9 @@ static void

[PATCH net-next 5/7] r8152: move some declearation of variables

2013-08-16 Thread Hayes Wang
Move some declearation of variables in rx_bottom(). Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 29 ++--- 1 file changed, 14 insertions(+), 15 deletions(-) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index 4dee76b..0a88f64 100644 --- a/driv

[PATCH net-next 6/7] r8152: adjust tx_bottom function

2013-08-16 Thread Hayes Wang
Split some parts of code into another function to simplify tx_bottom(). Use while loop to replace the goto loop. Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 134 1 file changed, 68 insertions(+), 66 deletions(-) diff --git a/drivers/n

Re: [PATCH v2 1/8] usb: phy: omap-control: Get rid of platform data

2013-08-16 Thread Roger Quadros
Hi Sebastian, On 08/15/2013 07:22 PM, Sebastian Andrzej Siewior wrote: > * Roger Quadros | 2013-08-15 16:15:05 [+0300]: > >> diff --git a/drivers/usb/phy/phy-omap-control.c >> b/drivers/usb/phy/phy-omap-control.c >> index a4dda8e..3b9ee83 100644 >> --- a/drivers/usb/phy/phy-omap-control.c >> +++

Re: [PATCH v2 6/8] usb: phy: omap: get rid of omap_get_control_dev()

2013-08-16 Thread Roger Quadros
On 08/15/2013 07:51 PM, Sebastian Andrzej Siewior wrote: > * Roger Quadros | 2013-08-15 16:15:10 [+0300]: > >> diff --git a/drivers/usb/phy/phy-omap-control.c >> b/drivers/usb/phy/phy-omap-control.c >> index 078c46f..d144c14 100644 >> --- a/drivers/usb/phy/phy-omap-control.c >> +++ b/drivers/usb/

Re: [PATCH v2 6/8] usb: phy: omap: get rid of omap_get_control_dev()

2013-08-16 Thread Sebastian Andrzej Siewior
On 08/16/2013 11:00 AM, Roger Quadros wrote: >> I don't like that part where you can call this function even before the >> driver probed the device. This shouldn't happen since you have hard module >> dependency and the proper compatible string in your device. But this >> kind of thing won't happen

Re: [PATCH v2 2/8] usb: phy: omap: Add new device types and remove omap_control_usb3_phy_power()

2013-08-16 Thread Roger Quadros
Hi Benoit, On 08/15/2013 04:58 PM, Benoit Cousson wrote: > Hi Roger, > > On 15/08/2013 15:15, Roger Quadros wrote: >> Add support for new device types and in the process rid of "ti,type" >> device tree property. The correct type of device will be determined >> from the compatible string instead.

Re: [PATCH 2/5] usb-core: Track if an endpoint has streams

2013-08-16 Thread Hans de Goede
Hi, On 08/15/2013 06:00 PM, Sarah Sharp wrote: On Wed, Aug 14, 2013 at 02:32:03PM +0200, Hans de Goede wrote: - /* Streams only apply to bulk endpoints. */ - for (i = 0; i < num_eps; i++) + for (i = 0; i < num_eps; i++) { + /* Streams only apply to bulk endpoints

Re: [patch] USB: mos7720: use GFP_ATOMIC under spinlock

2013-08-16 Thread Johan Hovold
On Fri, Aug 16, 2013 at 10:16:59AM +0300, Dan Carpenter wrote: > The write_parport_reg_nonblock() function shouldn't sleep because it's > called with spinlocks held. Ouch. Thanks for catching this. > Signed-off-by: Dan Carpenter Cc: sta...@vger.kernel.org Acked-by: Johan Hovold Greg, this one

[PATCH 0/2] Enable USB ID pin detection using extcon for DRA7xx

2013-08-16 Thread George Cherian
Hi, These patches add support for USB ID pin detection using extcon framework. The ID pin on DRA7xx is connected via the gpio expander pcf8575. The interrupt line of the same is connected to the gpio 11 of bank 6. The following driver relies on the gpio interrupt to notify the actual ID pin

[PATCH 1/2] extcon: extcon-dra7xx: Add extcon driver for USB ID detection

2013-08-16 Thread George Cherian
Adding extcon driver for USB ID detection to dynamically configure USB Host/Peripheral mode. Signed-off-by: George Cherian --- .../devicetree/bindings/extcon/extcon-dra7xx.txt | 19 ++ drivers/extcon/Kconfig | 7 + drivers/extcon/Makefile

[PATCH 2/2] arm: dts: dra7-evm: Add extcon dt nodes for USB ID detection

2013-08-16 Thread George Cherian
Adding extcon dt nodes for USB ID detection. ID pin is routed via the gpio expander , so adding pcf8575 nodes. Changing otg mode to peripheral mode for usb1 Signed-off-by: George Cherian --- arch/arm/boot/dts/dra7-evm.dts | 42 +- 1 file changed, 41 insert

Re: [PATCH v2 0/8] Common Clock Framework support for Samsung S3C64xx

2013-08-16 Thread Tomasz Figa
Hi Mike, On Monday 05 of August 2013 11:06:25 Mike Turquette wrote: > Quoting Kukjin Kim (2013-08-05 10:01:36) > > > On 07/23/13 08:49, Tomasz Figa wrote: > > > This series is an attempt to move clock support on Samsung S3C64xx > > > SoCs > > > to Common Clock Framework. > > > > > > First, suppo

Re: linux-next: Tree for Aug 15 (usb/phy/phy-am335x-control.c)

2013-08-16 Thread Roger Quadros
+Sebastian, On 08/15/2013 08:07 PM, Randy Dunlap wrote: > On 08/14/13 23:58, Stephen Rothwell wrote: >> Hi all, >> >> Changes since 20130814: >> > > on i386 and x86_64: > > drivers/usb/phy/phy-am335x-control.c:45:3: error: implicit declaration of > function '__WARN' [-Werror=implicit-function-d

Re: [PATCH v2 0/9] USB: phy: phy-nop: Manage RESET GPIO in the driver

2013-08-16 Thread Benoit Cousson
Hi Roger, On 15/08/2013 12:18, Roger Quadros wrote: Hi, Modelling the RESET line as a regulator supply wasn't a good idea as it abuses the regulator framework and makes adaptation code/data more complex. Instead, manage the RESET gpio line directly in the driver. This also makes us easy to mi

Re: [patch] usb: chipidea: fix a NULL dereference on error

2013-08-16 Thread Peter Chen
On Fri, Aug 16, 2013 at 10:34:10AM +0300, Dan Carpenter wrote: > The regulator_disable() function can't accept NULL pointers so we need > to add a check. > > Signed-off-by: Dan Carpenter > > diff --git a/drivers/usb/chipidea/host.c b/drivers/usb/chipidea/host.c > index 6f96795..abfb1cc 100644 >

Re: [patch] USB: mos7720: use GFP_ATOMIC under spinlock

2013-08-16 Thread Greg Kroah-Hartman
On Fri, Aug 16, 2013 at 12:12:10PM +0200, Johan Hovold wrote: > On Fri, Aug 16, 2013 at 10:16:59AM +0300, Dan Carpenter wrote: > > The write_parport_reg_nonblock() function shouldn't sleep because it's > > called with spinlocks held. > > Ouch. Thanks for catching this. > > > Signed-off-by: Dan Ca

Re: octeon-usb and dwc2 in staging are for the same hw

2013-08-16 Thread Greg KH
Hi Aaro and Paul, It was just pointed out to me by Sebastian that it looks like both the octeon-usb and dwc2 drivers in drivers/staging/ are for the same exact hardware core. Were you two aware of this? As the dwc2 code seems to be the "more mature" codebase, any objection to me deleting the oct

[PATCH v3 0/8] phy: omap-usb: Support multiple instances and new types

2013-08-16 Thread Roger Quadros
Hi, This patchset does the following: * Get rid of omap_control_usb platform data as we support DT only. * Restructure and add support for new PHY types. We now support the follwing four types TYPE_OMAP - if it has otghs_control mailbox register (e.g. on OMAP4) TYPE_USB2 - if it has Power dow

[PATCH v3 7/8] ARM: dts: omap4: update omap-control-usb nodes

2013-08-16 Thread Roger Quadros
Split otghs_ctrl and USB2 PHY power down into separate omap-control-usb nodes. Get rid of "ti,type" property. CC: Benoit Cousson Signed-off-by: Roger Quadros --- arch/arm/boot/dts/omap4.dtsi | 20 1 files changed, 12 insertions(+), 8 deletions(-) diff --git a/arch/arm/bo

[PATCH v3 2/8] usb: phy: omap: Add new device types and remove omap_control_usb3_phy_power()

2013-08-16 Thread Roger Quadros
Add support for new device types and in the process rid of "ti,type" device tree property. The correct type of device will be determined from the compatible string instead. Introduce a compatible string for each device type. At the moment we support 4 types Mailbox, USB2, USB3 and DRA7. Update DT

[PATCH v3 5/8] usb: musb: omap2430: Don't use omap_get_control_dev()

2013-08-16 Thread Roger Quadros
omap_get_control_dev() is being deprecated as it doesn't support multiple instances. As control device is present only from OMAP4 onwards which supports DT only, we use phandles to get the reference to the control device. Also get rid of "ti,has-mailbox" property as it is redundant and we can dete

[PATCH v3 6/8] usb: phy: omap: get rid of omap_get_control_dev()

2013-08-16 Thread Roger Quadros
This function was preventing us from supporting multiple instances. Get rid of it. Since we support DT boots only, users can get the control device phandle from the DT node. Signed-off-by: Roger Quadros --- drivers/usb/phy/phy-omap-control.c | 31 ++- include/linu

[PATCH v3 1/8] usb: phy: omap-control: Get rid of platform data

2013-08-16 Thread Roger Quadros
omap-control device is present from OMAP4 onwards which support device tree boots only. So get rid of platform data. Signed-off-by: Roger Quadros --- drivers/usb/phy/phy-omap-control.c | 18 +++--- include/linux/usb/omap_control_usb.h |4 2 files changed, 7 insertions(+)

[PATCH v3 8/8] ARM: dts: omap5: update omap-control-usb node

2013-08-16 Thread Roger Quadros
Split USB2 PHY and USB3 PHY into separate omap-control-usb nodes. Get rid of "ti,type" property. CC: Benoit Cousson Signed-off-by: Roger Quadros --- arch/arm/boot/dts/omap5.dtsi | 20 1 files changed, 12 insertions(+), 8 deletions(-) diff --git a/arch/arm/boot/dts/omap5.

[PATCH v3 4/8] usb: phy: omap-usb3: Don't use omap_get_control_dev()

2013-08-16 Thread Roger Quadros
omap_get_control_dev() is being deprecated as it doesn't support multiple instances. As control device is present only from OMAP4 onwards which supports DT only, we use phandles to get the reference to the control device. As we don't support non-DT boot, we just bail out on probe if device node is

[PATCH v3 3/8] usb: phy: omap-usb2: Don't use omap_get_control_dev()

2013-08-16 Thread Roger Quadros
omap_get_control_dev() is being deprecated as it doesn't support multiple instances. As control device is present only from OMAP4 onwards which supports DT only, we use phandles to get the reference to the control device. As we don't support non-DT boot, we just bail out on probe if device node is

[PATCH] net: cdc_ncm: Export cdc_ncm_{tx,rx}_fixup functions for re-use

2013-08-16 Thread Enrico Mioso
Some drivers implementing NCM-like protocols, may re-use those functions, as is the case in the huawei_cdc_ncm driver. Export them via EXPORT_SYMBOL_GPL. Signed-off-by: Enrico Mioso --- drivers/net/usb/cdc_ncm.c |6 -- include/linux/usb/cdc_ncm.h |3 +++ 2 files changed, 7 insert

[PATCH] net: huawei_cdc_ncm: Introduce new huawei_cdc_ncm driver

2013-08-16 Thread Enrico Mioso
This driver supports devices using the NCM protocol as an encapsulation layer for other protocols, like the E3131 Huawei 3G modem. Suggested-by: Bjorn Mork Signed-off-by: Enrico Mioso --- drivers/net/usb/Kconfig | 11 ++ drivers/net/usb/Makefile |1 + drivers/net/usb/hua

[PATCH] net: cdc_ncm: remove non-standard NCM device IDs

2013-08-16 Thread Enrico Mioso
Remove device IDs of NCM-like (but not NCM-conformant) devices, that are handled by the huawwei_cdc_ncm driver now. Signed-off-by: Enrico Mioso --- drivers/net/usb/cdc_ncm.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/drivers/net/usb/cdc_ncm.c b/drivers/net/usb/cdc_ncm.c

Re: [PATCH] net: cdc_ncm: Export cdc_ncm_{tx,rx}_fixup functions for re-use

2013-08-16 Thread Greg Kroah-Hartman
On Fri, Aug 16, 2013 at 03:39:19PM +0200, Enrico Mioso wrote: > Some drivers implementing NCM-like protocols, may re-use those functions, as > is > the case in the huawei_cdc_ncm driver. Where is that driver at, I don't see it in the kernel tree. > Export them via EXPORT_SYMBOL_GPL. Normally w

Re: [PATCH] net: cdc_ncm: Export cdc_ncm_{tx,rx}_fixup functions for re-use

2013-08-16 Thread Greg Kroah-Hartman
On Fri, Aug 16, 2013 at 06:49:07AM -0700, Greg Kroah-Hartman wrote: > On Fri, Aug 16, 2013 at 03:39:19PM +0200, Enrico Mioso wrote: > > Some drivers implementing NCM-like protocols, may re-use those functions, > > as is > > the case in the huawei_cdc_ncm driver. > > Where is that driver at, I do

Re: [PATCH] net: cdc_ncm: Export cdc_ncm_{tx,rx}_fixup functions for re-use

2013-08-16 Thread Enrico Mioso
Yes, you're right. I'm sorry - this time I didn't apply numbering scheme to those 3 patches - yet they are consequential, but not depending on each other from a strict point of view. Thank you for your review Greg! On Fri, 16 Aug 2013, Greg Kroah-Hartman wrote: ==Date: Fri, 16 Aug 2013 06:49:

Re: [PATCH v3 7/8] ARM: dts: omap4: update omap-control-usb nodes

2013-08-16 Thread Benoit Cousson
Hi Roger, Sorry I missed something in the previous revision :-( On 16/08/2013 15:09, Roger Quadros wrote: Split otghs_ctrl and USB2 PHY power down into separate omap-control-usb nodes. Get rid of "ti,type" property. You should add that you update the usb_otg_hs node accordingly as well. CC:

Re: Non-enumerable devices on USB and other enumerable buses

2013-08-16 Thread Alan Stern
On Thu, 15 Aug 2013, Mark Brown wrote: > No, this really is something that's very much generic to the device and > will apply to anywhere the silicon is used. The power on process for a > device isn't something that changes, the mapping of resources that might > be used in that sequence is but we

Re: [PATCH 4/4] xhci-plat: Don't enable legacy PCI interrupts.

2013-08-16 Thread Felipe Balbi
Hi, On Thu, Aug 15, 2013 at 09:28:20PM -0700, Greg Kroah-Hartman wrote: > > But should be also met for ARM SOC which use dwc3 controller as xHCI > > controller. Because DWC3 driver register xHCI as platform driver by > > default. So this issue can be reproduce. > > Which system can I reproduce th

Re: [PATCH 4/4] xhci-plat: Don't enable legacy PCI interrupts.

2013-08-16 Thread Greg Kroah-Hartman
On Fri, Aug 16, 2013 at 09:58:25AM -0500, Felipe Balbi wrote: > Hi, > > On Thu, Aug 15, 2013 at 09:28:20PM -0700, Greg Kroah-Hartman wrote: > > > But should be also met for ARM SOC which use dwc3 controller as xHCI > > > controller. Because DWC3 driver register xHCI as platform driver by > > > def

[PATCH 0/2] g_ffs CDC ACM support

2013-08-16 Thread Matt Porter
This series fixes a build warning from USB Ethernet module parameters in g_ffs and adds an additional configuration for CDC ACM + FunctionFS. Matt Porter (2): usb: gadget: ffs: fix eth module parameters warning in pure-only config usb: gadget: ffs: add ACM + FunctionFS configuration driv

[PATCH 2/2] usb: gadget: ffs: add ACM + FunctionFS configuration

2013-08-16 Thread Matt Porter
Adds an additional configuration to g_ffs to allow for CDC ACM support in conjuction with FunctionFS. A module parameter is added to allow for multiple ACM ports to be instantiated. Signed-off-by: Matt Porter --- drivers/usb/gadget/Kconfig |9 ++ drivers/usb/gadget/g_ffs.c | 71 +++

[PATCH 1/2] usb: gadget: ffs: fix eth module parameters warning in pure-only config

2013-08-16 Thread Matt Porter
Fixes the build warning spewed out by USB_ETHERNET_MODULE_PARAMETERS() which was unconditionally included even when ethernet configs are disabled. Signed-off-by: Matt Porter --- drivers/usb/gadget/g_ffs.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/usb/gadget

Re: [PATCH 2/2] usb: gadget: ffs: add ACM + FunctionFS configuration

2013-08-16 Thread Felipe Balbi
On Fri, Aug 16, 2013 at 11:27:48AM -0400, Matt Porter wrote: > Adds an additional configuration to g_ffs to allow for > CDC ACM support in conjuction with FunctionFS. A module > parameter is added to allow for multiple ACM ports to > be instantiated. > > Signed-off-by: Matt Porter the whole idea

[PATCH] usb: phy: am335x-control: make it compile with

2013-08-16 Thread Sebastian Andrzej Siewior
From: Sebastian Andrzej Siewior Randy reported this |drivers/usb/phy/phy-am335x-control.c:45:3: error: implicit declaration |of function '__WARN' [-Werror=implicit-function-declaration] and left it as an excercice to figure out that this happens only with CONFIG_BUG=n. As a fix I replace it with

Re: [PATCH 4/4] xhci-plat: Don't enable legacy PCI interrupts.

2013-08-16 Thread Felipe Balbi
On Fri, Aug 16, 2013 at 08:19:02AM -0700, Greg Kroah-Hartman wrote: > On Fri, Aug 16, 2013 at 09:58:25AM -0500, Felipe Balbi wrote: > > Hi, > > > > On Thu, Aug 15, 2013 at 09:28:20PM -0700, Greg Kroah-Hartman wrote: > > > > But should be also met for ARM SOC which use dwc3 controller as xHCI > > >

[PATCH] dma: cpp41: make it compile with CONFIG_BUG=n

2013-08-16 Thread Sebastian Andrzej Siewior
From: Sebastian Andrzej Siewior Before Randy figures out that this does not compile with CONFIG_BUG=n here is a fix for it. Signed-off-by: Sebastian Andrzej Siewior --- drivers/dma/cppi41.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma/cppi41.c b/drivers/dma/c

Re: [PATCH 2/2] usb: gadget: ffs: add ACM + FunctionFS configuration

2013-08-16 Thread Matt Porter
On 08/16/2013 11:32 AM, Felipe Balbi wrote: On Fri, Aug 16, 2013 at 11:27:48AM -0400, Matt Porter wrote: Adds an additional configuration to g_ffs to allow for CDC ACM support in conjuction with FunctionFS. A module parameter is added to allow for multiple ACM ports to be instantiated. Signed-o

Re: [PATCH 2/4] usb: don't check pm qos NO_POWER_OFF flag in usb_port_suspend()

2013-08-16 Thread Sarah Sharp
On Thu, Aug 15, 2013 at 07:11:36PM -0700, Greg Kroah-Hartman wrote: > On Thu, Aug 15, 2013 at 06:43:57PM -0700, Sarah Sharp wrote: > > From: Lan Tianyu > > > > The pm qos NO_POWER_OFF flag is checked twice during usb device suspend > > to see if the usb port power off condition is met. This is re

Re: [PATCH 4/4] xhci-plat: Don't enable legacy PCI interrupts.

2013-08-16 Thread Sarah Sharp
On Fri, Aug 16, 2013 at 10:33:04AM -0500, Felipe Balbi wrote: > On Fri, Aug 16, 2013 at 08:19:02AM -0700, Greg Kroah-Hartman wrote: > > On Fri, Aug 16, 2013 at 09:58:25AM -0500, Felipe Balbi wrote: > > > Hi, > > > > > > On Thu, Aug 15, 2013 at 09:28:20PM -0700, Greg Kroah-Hartman wrote: > > > > >

Re: [PATCH RESEND] clk: tegra30: Don't wait for PLL_U lock bit

2013-08-16 Thread Stephen Warren
On 08/14/2013 02:09 PM, Tuomas Tynkkynen wrote: > The lock bit on PLL_U does not seem to be working correctly and > sometimes never gets set when waiting for the PLL to come up. > Remove the TEGRA_PLL_USE_LOCK flag to use a constant delay. Tested-by: Stephen Warren Acked-by: Stephen Warren (Mik

Re: [PATCH 2/4] usb: don't check pm qos NO_POWER_OFF flag in usb_port_suspend()

2013-08-16 Thread Greg Kroah-Hartman
On Fri, Aug 16, 2013 at 09:35:57AM -0700, Sarah Sharp wrote: > On Thu, Aug 15, 2013 at 07:11:36PM -0700, Greg Kroah-Hartman wrote: > > On Thu, Aug 15, 2013 at 06:43:57PM -0700, Sarah Sharp wrote: > > > From: Lan Tianyu > > > > > > The pm qos NO_POWER_OFF flag is checked twice during usb device su

[PATCH] usb: phy: am335x: add wakeup support

2013-08-16 Thread Sebastian Andrzej Siewior
This is based on George Cherian's patch which added power & wakeup support to am335x and does no longer apply since I took some if the code apart in favor of the multi instance support. This compiles and I boots and later it detects a device after I plug it in :) Could somebody please test it so it

Re: [Pull Request] xhci: Step 1 to fix usb-linus and usb-next.

2013-08-16 Thread Sarah Sharp
On Thu, Aug 15, 2013 at 07:16:10PM -0700, Greg Kroah-Hartman wrote: > In reviewing these, I don't see anything that is all that urgent, so, > can I just pull both of these branches (assuming the second one really > is the correct one, based on the comment, I'm not sure), into usb-next? > That way t

Re: octeon-usb and dwc2 in staging are for the same hw

2013-08-16 Thread Aaro Koskinen
Hi, On Fri, Aug 16, 2013 at 06:01:50AM -0700, Greg KH wrote: > It was just pointed out to me by Sebastian that it looks like both the > octeon-usb and dwc2 drivers in drivers/staging/ are for the same exact > hardware core. > > Were you two aware of this? It was mentioned here: http://m

Re: [PATCH 2/4] usb: don't check pm qos NO_POWER_OFF flag in usb_port_suspend()

2013-08-16 Thread Sarah Sharp
On Fri, Aug 16, 2013 at 09:59:41AM -0700, Greg Kroah-Hartman wrote: > On Fri, Aug 16, 2013 at 09:35:57AM -0700, Sarah Sharp wrote: > > On Thu, Aug 15, 2013 at 07:11:36PM -0700, Greg Kroah-Hartman wrote: > > > On Thu, Aug 15, 2013 at 06:43:57PM -0700, Sarah Sharp wrote: > > > > From: Lan Tianyu > >

Explanation Needed

2013-08-16 Thread Kumar Gaurav
Hi Sarah, I was just reading through xhci driver's code and found something which i'm unable to understand use of. Please help me understanding them 1.use of struct xhci_hcd in function xhci_readl function definition doesn't uses this type of argument static inline unsigned int xhci_re

Re: octeon-usb and dwc2 in staging are for the same hw

2013-08-16 Thread Greg KH
On Fri, Aug 16, 2013 at 08:33:10PM +0300, Aaro Koskinen wrote: > Hi, > > On Fri, Aug 16, 2013 at 06:01:50AM -0700, Greg KH wrote: > > It was just pointed out to me by Sebastian that it looks like both the > > octeon-usb and dwc2 drivers in drivers/staging/ are for the same exact > > hardware core.

Re: [PATCH 2/5] usb-core: Track if an endpoint has streams

2013-08-16 Thread Sarah Sharp
On Fri, Aug 16, 2013 at 11:17:41AM +0200, Hans de Goede wrote: > Hi, > > On 08/15/2013 06:00 PM, Sarah Sharp wrote: > >On Wed, Aug 14, 2013 at 02:32:03PM +0200, Hans de Goede wrote: > >>- /* Streams only apply to bulk endpoints. */ > >>- for (i = 0; i < num_eps; i++) > >>+ for (i = 0; i < nu

Re: Explanation Needed

2013-08-16 Thread Sarah Sharp
On Fri, Aug 16, 2013 at 11:09:12PM +0530, Kumar Gaurav wrote: > Hi Sarah, > > I was just reading through xhci driver's code and found something > which i'm unable to understand use of. > Please help me understanding them > > 1.use of struct xhci_hcd in function xhci_readl > function definitio

Re: [PATCH] usb: phy: am335x-control: make it compile with

2013-08-16 Thread Randy Dunlap
On 08/16/13 08:32, Sebastian Andrzej Siewior wrote: > From: Sebastian Andrzej Siewior > > Randy reported this > |drivers/usb/phy/phy-am335x-control.c:45:3: error: implicit declaration > |of function '__WARN' [-Werror=implicit-function-declaration] > > and left it as an excercice to figure out th

Re: Explanation Needed

2013-08-16 Thread Kumar Gaurav
On Friday 16 August 2013 11:28 PM, Sarah Sharp wrote: On Fri, Aug 16, 2013 at 11:09:12PM +0530, Kumar Gaurav wrote: Hi Sarah, I was just reading through xhci driver's code and found something which i'm unable to understand use of. Please help me understanding them 1.use of struct xhci_hcd in f

Re: Explanation Needed

2013-08-16 Thread Sarah Sharp
On Fri, Aug 16, 2013 at 11:34:58PM +0530, Kumar Gaurav wrote: > On Friday 16 August 2013 11:28 PM, Sarah Sharp wrote: > >On Fri, Aug 16, 2013 at 11:09:12PM +0530, Kumar Gaurav wrote: > >>Hi Sarah, > >> > >>I was just reading through xhci driver's code and found something > >>which i'm unable to und

Re: Explanation Needed

2013-08-16 Thread Kumar Gaurav
On Friday 16 August 2013 11:57 PM, Sarah Sharp wrote: On Fri, Aug 16, 2013 at 11:34:58PM +0530, Kumar Gaurav wrote: On Friday 16 August 2013 11:28 PM, Sarah Sharp wrote: On Fri, Aug 16, 2013 at 11:09:12PM +0530, Kumar Gaurav wrote: Hi Sarah, I was just reading through xhci driver's code and f

RE: octeon-usb and dwc2 in staging are for the same hw

2013-08-16 Thread Paul Zimmerman
> From: Aaro Koskinen [mailto:aaro.koski...@iki.fi] > Sent: Friday, August 16, 2013 10:33 AM > > On Fri, Aug 16, 2013 at 06:01:50AM -0700, Greg KH wrote: > > It was just pointed out to me by Sebastian that it looks like both the > > octeon-usb and dwc2 drivers in drivers/staging/ are for the same

Re: Non-enumerable devices on USB and other enumerable buses

2013-08-16 Thread Mark Brown
On Fri, Aug 16, 2013 at 10:42:10AM -0400, Alan Stern wrote: > Okay, let's see if I understand your problem. You've got a driver that ... > Is that it? Yes, I think that's it. > The difficulty with the first proposal is that subsystems aren't > designed to allow that sort of thing. They expect

[PATCH 1/6] drivers:usb:host:xhci.h Removing xhci_hcd from argument

2013-08-16 Thread Kumar Gaurav
Removed struct xhci_hcd from xhci_readl fucntion as it's no more in use. --- drivers/usb/host/xhci.h |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/usb/host/xhci.h b/drivers/usb/host/xhci.h index c338741..7cf0e41 100644 --- a/drivers/usb/host/xhci.h +++ b/drivers/

[PATCH 2/6] drivers/usb/host/xhci.c Fixing xhci_readl call

2013-08-16 Thread Kumar Gaurav
Fixed xhci_readl call issue as per definition modified in patch 0019-drivers-usb-host-xhci.h-Removing-xhci_hcd-from-argum.patch Signed-off-by: Kumar Gaurav --- drivers/usb/host/xhci.c | 100 +++ 1 file changed, 50 insertions(+), 50 deletions(-) diff

[PATCH 3/6] for fixing xhci_readl call in xhci_mem.c after removing xhci_hcd from function definition

2013-08-16 Thread Kumar Gaurav
--- drivers/usb/host/xhci-mem.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/usb/host/xhci-mem.c b/drivers/usb/host/xhci-mem.c index df6978a..0a8aa3e 100644 --- a/drivers/usb/host/xhci-mem.c +++ b/drivers/usb/host/xhci-mem.c @@ -2057,7 +2057,

[PATCH 4/6] for fixing xhci_readl call in xhci_ring.c after removing xhci_hcd from function definition

2013-08-16 Thread Kumar Gaurav
--- drivers/usb/host/xhci-ring.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c index 1e57eaf..9d4128c 100644 --- a/drivers/usb/host/xhci-ring.c +++ b/drivers/usb/host/xhci-ring.c @@ -286,7 +286,7 @@ vo

Re: [PATCH v2 0/8] Common Clock Framework support for Samsung S3C64xx

2013-08-16 Thread Tomasz Figa
On Friday 16 of August 2013 14:02:03 Mike Turquette wrote: > Quoting Tomasz Figa (2013-08-16 03:44:44) > > > Hi Mike, > > > > On Monday 05 of August 2013 11:06:25 Mike Turquette wrote: > > > Quoting Kukjin Kim (2013-08-05 10:01:36) > > > > > > > On 07/23/13 08:49, Tomasz Figa wrote: > > > > > Th

Re: Non-enumerable devices on USB and other enumerable buses

2013-08-16 Thread Mark Brown
On Fri, Aug 16, 2013 at 03:27:58PM -0400, Alan Stern wrote: > On Fri, 16 Aug 2013, Mark Brown wrote: > > or those for getting platform data to a device when it > > does enumerate. > ? I can't make any sense out of that comment. For one thing, why do > you need to send platform data to a device

Re: [PATCH 1/6] drivers:usb:host:xhci.h Removing xhci_hcd from argument

2013-08-16 Thread Greg KH
On Sat, Aug 17, 2013 at 12:34:04AM +0530, Kumar Gaurav wrote: > On Saturday 17 August 2013 12:30 AM, Greg KH wrote: > >On Sat, Aug 17, 2013 at 12:18:42AM +0530, Kumar Gaurav wrote: > >>Removed struct xhci_hcd from xhci_readl fucntion as it's no more in use. > >>--- > >> drivers/usb/host/xhci.h |

Re: octeon-usb and dwc2 in staging are for the same hw

2013-08-16 Thread Aaro Koskinen
On Fri, Aug 16, 2013 at 08:51:57PM +, Paul Zimmerman wrote: > > From: Aaro Koskinen [mailto:aaro.koski...@iki.fi] > > Sent: Friday, August 16, 2013 1:45 PM > > > > On Fri, Aug 16, 2013 at 06:35:10PM +, Paul Zimmerman wrote: > > > Aaro, I would ask you the same question. Is the Octeon drive

Re: [PATCH 4/6] for fixing xhci_readl call in xhci_ring.c after removing xhci_hcd from function definition

2013-08-16 Thread Greg KH
On Sat, Aug 17, 2013 at 12:21:08AM +0530, Kumar Gaurav wrote: > --- > drivers/usb/host/xhci-ring.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) -ENO_SIGNED_OFF_BY :( Also, where are the 5 other patches? thanks, greg k-h -- To unsubscribe from this list: send the line

Re: [PATCH 2/6] drivers/usb/host/xhci.c Fixing xhci_readl call

2013-08-16 Thread Greg KH
On Sat, Aug 17, 2013 at 12:19:18AM +0530, Kumar Gaurav wrote: > Fixed xhci_readl call issue as per definition modified in patch > 0019-drivers-usb-host-xhci.h-Removing-xhci_hcd-from-argum.patch What patch is that? It looks like a filename, not a git commit id. Can you please fix this up? > Sign

Re: [PATCH v3 1/3] usb: dwc3: msm: Add device tree binding information

2013-08-16 Thread Stephen Warren
On 08/14/2013 06:59 AM, Ivan T. Ivanov wrote: > From: "Ivan T. Ivanov" > > MSM USB3.0 core wrapper consist of USB3.0 IP from Synopsys > (SNPS) and HS, SS PHY's control and configuration registers. > > It could operate in device mode (SS, HS, FS) and host > mode (SS, HS, FS, LS). > diff --git a/

Re: Non-enumerable devices on USB and other enumerable buses

2013-08-16 Thread Mark Brown
On Fri, Aug 16, 2013 at 04:39:47PM -0400, Alan Stern wrote: > On Fri, 16 Aug 2013, Mark Brown wrote: > > The device in this context is a running instance of the driver. > It's kind of difficult to understand what you're saying. Obviously the > literal meaning is not what you had in mind, because

Re: [PATCH 1/3] of: add vendor prefix for Mentor Graphics

2013-08-16 Thread Stephen Warren
On 08/15/2013 07:13 AM, Sebastian Andrzej Siewior wrote: > This prefix is currently used for the musb driver. > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt > b/Documentation/devicetree/bindings/vendor-prefixes.txt > +mg Mentor Graphics It's slightly short; I would have

[PATCH 5/6] for fixing xhci_readl call in xhci_hub.c after removing xhci_hcd from function definition

2013-08-16 Thread Kumar Gaurav
--- drivers/usb/host/xhci-hub.c | 72 +-- 1 file changed, 36 insertions(+), 36 deletions(-) diff --git a/drivers/usb/host/xhci-hub.c b/drivers/usb/host/xhci-hub.c index 1d35459..c0198af 100644 --- a/drivers/usb/host/xhci-hub.c +++ b/drivers/usb/host/xhci-

Re: octeon-usb and dwc2 in staging are for the same hw

2013-08-16 Thread Aaro Koskinen
Hi, On Fri, Aug 16, 2013 at 06:35:10PM +, Paul Zimmerman wrote: > Aaro, I would ask you the same question. Is the Octeon driver fully > functional? Are there any shortcomings with it that you know about? I sent this driver when mainlining the support for EdgeRouter Lite (http://www.ubnt.com/e

Re: octeon-usb and dwc2 in staging are for the same hw

2013-08-16 Thread David Daney
On 08/16/2013 02:07 PM, Aaro Koskinen wrote: On Fri, Aug 16, 2013 at 08:51:57PM +, Paul Zimmerman wrote: From: Aaro Koskinen [mailto:aaro.koski...@iki.fi] Sent: Friday, August 16, 2013 1:45 PM On Fri, Aug 16, 2013 at 06:35:10PM +, Paul Zimmerman wrote: Aaro, I would ask you the same qu

Re: octeon-usb and dwc2 in staging are for the same hw

2013-08-16 Thread Aaro Koskinen
Hi, On Fri, Aug 16, 2013 at 10:39:39AM -0700, Greg KH wrote: > > > As the dwc2 code seems to be the "more mature" codebase, any objection > > > to me deleting the octeon-usb driver? > > > > If it's possible to get it working on Octeon HW, then having a single > > driver is of course the best solu

Re: [PATCH 1/6] drivers:usb:host:xhci.h Removing xhci_hcd from argument

2013-08-16 Thread Greg KH
On Sat, Aug 17, 2013 at 12:18:42AM +0530, Kumar Gaurav wrote: > Removed struct xhci_hcd from xhci_readl fucntion as it's no more in use. > --- > drivers/usb/host/xhci.h |3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) When sending kernel patches, it helps to run them through the scrip

Re: [PATCH 4/6] for fixing xhci_readl call in xhci_ring.c after removing xhci_hcd from function definition

2013-08-16 Thread Greg KH
On Fri, Aug 16, 2013 at 11:53:56AM -0700, Greg KH wrote: > On Sat, Aug 17, 2013 at 12:21:08AM +0530, Kumar Gaurav wrote: > > --- > > drivers/usb/host/xhci-ring.c | 12 ++-- > > 1 file changed, 6 insertions(+), 6 deletions(-) > > -ENO_SIGNED_OFF_BY :( > > Also, where are the 5 other pat

Re: [PATCH 3/6] for fixing xhci_readl call in xhci_mem.c after removing xhci_hcd from function definition

2013-08-16 Thread Greg KH
On Sat, Aug 17, 2013 at 12:20:05AM +0530, Kumar Gaurav wrote: > --- > drivers/usb/host/xhci-mem.c | 20 ++-- > 1 file changed, 10 insertions(+), 10 deletions(-) The subject seems strange, what happened? Your other patches have good subjects, and a semi-decent body of text sayin

RE: octeon-usb and dwc2 in staging are for the same hw

2013-08-16 Thread Paul Zimmerman
> From: Aaro Koskinen [mailto:aaro.koski...@iki.fi] > Sent: Friday, August 16, 2013 1:45 PM > > On Fri, Aug 16, 2013 at 06:35:10PM +, Paul Zimmerman wrote: > > Aaro, I would ask you the same question. Is the Octeon driver fully > > functional? Are there any shortcomings with it that you know a

Re: [PATCH 1/6] drivers:usb:host:xhci.h Removing xhci_hcd from argument

2013-08-16 Thread Greg KH
On Sat, Aug 17, 2013 at 12:18:42AM +0530, Kumar Gaurav wrote: > Removed struct xhci_hcd from xhci_readl fucntion as it's no more in use. > --- > drivers/usb/host/xhci.h |3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/usb/host/xhci.h b/drivers/usb/host/xhci.h

Re: [PATCH 6/6] for fixing xhci_readl call in xhci_dbg.c after removing xhci_hcd from function definition

2013-08-16 Thread Greg KH
On Sat, Aug 17, 2013 at 12:24:47AM +0530, Kumar Gaurav wrote: > --- > drivers/usb/host/xhci-dbg.c | 36 ++-- > 1 file changed, 18 insertions(+), 18 deletions(-) Why is this needed? And isn't it needed earlier in this series, as the build is broken there, right?

Re: [PATCH 4/6] for fixing xhci_readl call in xhci_ring.c after removing xhci_hcd from function definition

2013-08-16 Thread Kumar Gaurav
On Saturday 17 August 2013 12:25 AM, Greg KH wrote: On Fri, Aug 16, 2013 at 11:53:56AM -0700, Greg KH wrote: On Sat, Aug 17, 2013 at 12:21:08AM +0530, Kumar Gaurav wrote: --- drivers/usb/host/xhci-ring.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) -ENO_SIGNED_OFF_BY

Re: [PATCH 5/6] for fixing xhci_readl call in xhci_hub.c after removing xhci_hcd from function definition

2013-08-16 Thread Sarah Sharp
In general, please keep the short descriptions of your patches (which turn into the subject lines of your mails) limited to around 55 characters. Also, please make sure to include the driver or subsystem prefix as the first word in your short description. For the xHCI driver, the preferred prefix

  1   2   >