[3.8-rc3 -> 3.8-rc4 regression] Re: [PATCH] module, async: async_synchronize_full() on module init iff async is used

2013-08-12 Thread Jonathan Nieder
Hi, Tejun Heo wrote: > This avoids the described deadlock because iosched module doesn't use > async and thus wouldn't invoke async_synchronize_full(). This is > hacky and incomplete. It will deadlock if async module loading nests; > however, this works around the known problem case and seems t

Re: [PATCH] usb: chipidea: enable to build host support as module

2013-08-12 Thread Luka Perkov
Hi Peter, On Mon, Aug 12, 2013 at 09:28:28AM +0800, Peter Chen wrote: > On Sun, Aug 11, 2013 at 01:00:49PM +0200, Luka Perkov wrote: > > USB_CHIPIDEA_HOST does not need to depend on USB=y, USB_CHIPIDEA_HOST will > > work > > just fine even if USB=m is used. The depends line can be safely removed

Re: [PATCH 2/3] staging: dwc2: add NAK holdoff patch from downstream Pi kernel

2013-08-12 Thread Matthijs Kooijman
Hi Paul, > Add the NAK holdoff patch from the downstream Raspberry Pi kernel. > This allows the transfer scheduler to better handle "cheeky devices > that just hold off using NAKs". > @@ -365,6 +366,7 @@ struct dwc2_hsotg { > u8 otg_port; > u32 *frame_list; > dma_addr_t frame_li

Re: [PATCH 3/3] staging: dwc2: add microframe scheduler from downstream Pi kernel

2013-08-12 Thread Matthijs Kooijman
Hi Paul & Dom, I haven't got time to look closely right now, but at first glance most of my comments have been resolved. One thing that is still in there, is this piece of code for which I'm not sure if it is really related to the topic of the patch: > @@ -780,6 +784,10 @@ static void dwc2_assig

Re: [PATCH 0/3] staging: dwc2: 2nd try at uframe scheduler patch

2013-08-12 Thread Matthijs Kooijman
Hi Paul, > Matthijs' concern about periodic endpoints with bInterval=1 seems > to be unfounded. I tried a webcam, which uses a bInterval=1 isoc > endpoint, on my PCI-based dev board, and it still works fine with > this patch applied. For the record, I still think this concern actually exists, but

Re: [PATCH 03/13] staging: dwc2: unshift non-bool register value constants

2013-08-12 Thread Matthijs Kooijman
Hey Paul, > OK, I'm kind of on the fence about this one, so if you prefer it this way > I guess it's OK with me. > > Acked-by: Paul Zimmerman Thanks. > What platforms have you tested this on, BTW? You said you have a Raspberry > Pi, so I'd like you to test these patches there before resubmittin

Re: FUSB200 xhci issue

2013-08-12 Thread Oleksij Rempel
Am 10.08.2013 13:57, schrieb Alan Stern: On Sat, 10 Aug 2013, Oleksij Rempel wrote: usb reset do not affect behaviour of firmware. At least after i remove all attempts to reboot FW from driver. If adapter will got reset signal, FW will be notified about it. Then FW will remove reset flag and wi

Re: [PATCH 3/3] staging: dwc2: add microframe scheduler from downstream Pi kernel

2013-08-12 Thread Dan Carpenter
On Sun, Aug 11, 2013 at 12:50:19PM -0700, Paul Zimmerman wrote: > +static int dwc2_find_single_uframe(struct dwc2_hsotg *hsotg, struct dwc2_qh > *qh) > +{ > + unsigned short utime = qh->usecs; > + int done = 0; > + int i = 0; > + int ret = -1; > + > + while (!done) { I don't c

Re: [PATCH v2 3/6] usb: phy: msm: Migrate to Managed Device Resource allocation

2013-08-12 Thread Ivan T. Ivanov
Hi, On Mon, 2013-07-29 at 15:25 +0300, Felipe Balbi wrote: > Hi, > > On Mon, Jul 29, 2013 at 10:04:21AM +0300, Ivan T. Ivanov wrote: > > motg->irq = platform_get_irq(pdev, 0); > > - if (!motg->irq) { > > + if (motg->irq < 0) { > > looks like this particular hunk isn't part of $subject.

Re: Non-enumerable devices on USB and other enumerable buses

2013-08-12 Thread Mark Brown
On Sun, Aug 11, 2013 at 09:53:01PM -0400, Alan Stern wrote: > On Sun, 11 Aug 2013, Mark Brown wrote: > > One example that's bugging me right now is that on the Insignal Arndale > > platform there's a USB hub connected to one of the USB ports on the SoC > > (not as a PHY, it seems we also need the

[PATCH 2/2] USB: chipidea: i.MX: simplify usbmisc

2013-08-12 Thread Sascha Hauer
The chipidea i.MX driver is split into two drivers. The ci_hdrc_imx driver handles the chipidea cores and the usbmisc_imx driver handles the noncore registers common to all chipidea cores (but SoC specific). Current flow is: - usbmisc sets an ops pointer in the ci_hdrc_imx driver during probe - ci

[PATCH v2] USB chipidea i.MX: Fix module loading

2013-08-12 Thread Sascha Hauer
The Chipidea i.MX driver has some issues with module loading dependencies. This fixes this. It is an alternative approach to the one Peter Chen suggested that does without changing the dt binding. Sascha changes since v1: - make usbmisc optional when fsl,usbmisc property is not present. Needed

[PATCH 1/2] USB: chipidea: i.MX: remove unused define

2013-08-12 Thread Sascha Hauer
Signed-off-by: Sascha Hauer --- drivers/usb/chipidea/ci_hdrc_imx.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c b/drivers/usb/chipidea/ci_hdrc_imx.c index 14362c0..11ed423 100644 --- a/drivers/usb/chipidea/ci_hdrc_imx.c +++ b/drivers/usb/chipidea/ci_hd

Re: Non-enumerable devices on USB and other enumerable buses

2013-08-12 Thread Mark Rutland
[Adding Olof] On Mon, Aug 12, 2013 at 10:51:36AM +0100, Mark Brown wrote: > On Sun, Aug 11, 2013 at 09:53:01PM -0400, Alan Stern wrote: > > On Sun, 11 Aug 2013, Mark Brown wrote: > > > > One example that's bugging me right now is that on the Insignal Arndale > > > platform there's a USB hub conne

Re: Non-enumerable devices on USB and other enumerable buses

2013-08-12 Thread Mark Brown
On Sun, Aug 11, 2013 at 07:02:57PM -0700, Greg Kroah-Hartman wrote: > On Sun, Aug 11, 2013 at 08:08:26PM +0100, Mark Brown wrote: > > I know there's been some discussion of this topic but do we have any > > general consensus on how to handle such things both from a Linux driver > > model point of

Re: Non-enumerable devices on USB and other enumerable buses

2013-08-12 Thread Mark Brown
On Mon, Aug 12, 2013 at 12:07:14PM +0100, Mark Rutland wrote: > As I understand it, the wifi chip on the Snow Chromebook has a similar > issue -- it hangs off of a probeable SDIO bus, but needs a regulator > poked for it to turn on and become probeable (see > exynos_wifi_bt_set_power in [1]). Yes

kernel Oops: 0003 on usbhid_submit_report

2013-08-12 Thread Andreas Lillebø Holm
When communicating with AT90USB1287, at random intervals (1/25 boots) the linux hid_output_field Oopses and kills the communicating thread. The AT90USB1287 microcontroller uses LUFA library for usb/hid communication. It is trigged by a ioctl call from userspace and fails in a kernel paging reque

Re: [alsa-devel] [PATCH] usb-audio: Fix invalid volume resolution for Logitech HD Webcam C525

2013-08-12 Thread Takashi Iwai
At Sat, 10 Aug 2013 12:20:02 +0400, Maksim A. Boyko wrote: > > Add the volume control quirk for avoiding the kernel warning > for the Logitech HD Webcam C525 > as in the similar commit 36691e1be6ec551eef4a5225f126a281f8c051c2 > for the Logitech HD Webcam C310. > > Reported-by: Maksim Boyko > Tes

[PATCH v3 5/6] usb: phy: tegra: Program new PHY parameters

2013-08-12 Thread Tuomas Tynkkynen
The Tegra30 TRM recommends configuration of certain PHY parameters for optimal quality. Program the following registers based on device tree parameters: - UTMIP_XCVR_HSSLEW: HS slew rate control. - UTMIP_HSSQUELCH_LEVEL: HS squelch detector level - UTMIP_HSDISCON_LEVEL: HS disconnect detector leve

[PATCH v3 6/6] usb: host: tegra: Tegra30 support

2013-08-12 Thread Tuomas Tynkkynen
The Tegra30 EHCI controller is mostly compatible with the Tegra20 controller, except Tegra30 includes the HOSTPC register extension. The has_hostpc capability bit must be set in the ehci_hcd structure if the controller has such extensions. The new tegra_ehci_soc_config structure is added to describ

[PATCH v3 4/6] Documentation: New DT parameters for tegra30-usb-phy

2013-08-12 Thread Tuomas Tynkkynen
Document the new device tree parameters for Tegra30 USB PHY. Signed-off-by: Tuomas Tynkkynen Tested-by: Stephen Warren Reviewed-by: Stephen Warren --- .../devicetree/bindings/usb/nvidia,tegra20-usb-phy.txt| 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/

[PATCH v3 2/6] usb: phy: tegra: Fix wrong PHY parameters

2013-08-12 Thread Tuomas Tynkkynen
Some of the PHY parameters are not set according to the TRMs: - UTMIP_FS_PREABMLE_J should be set, not cleared - UTMIP_XCVR_LSBIAS_SEL should be cleared, not set - UTMIP_PD_CHRG should be set in host mode and cleared in device mode - UTMIP_XCVR_SETUP is a two-part field; the upper bits were not se

[PATCH v3 0/6] USB tree changes for Tegra30 and Tegra114 USB Host support

2013-08-12 Thread Tuomas Tynkkynen
Hi all, Here are the patches for the USB tree to enable USB Host support on Tegra30 and Tegra114. These are based on my and Mikko's cleanup patches that just got merged to Felipe's tree. The first one touches the core hub code to prevent certain (non-standard) clock disable features as our contro

[PATCH v3 1/6] usb: host: add has_tdi_phy_lpm capability bit

2013-08-12 Thread Tuomas Tynkkynen
The has_hostpc capability bit indicates that the host controller has the HOSTPC register extensions, but at the same time enables clock disabling power saving features with the PHY Low Power Clock Disable (PHCD) bit. However, some host controllers have the HOSTPC extensions but don't support the l

[PATCH v3 3/6] usb: phy: tegra: Tegra30 support

2013-08-12 Thread Tuomas Tynkkynen
The Tegra30 USB PHY is a bit different than the Tegra20 PHY: - The EHCI controller supports the HOSTPC register extension, and some of the fields that the PHY needs to modify (PHCD and PTS) have moved to the new HOSTPC register. - Some of the UTMI PLL configuration registers have moved from th

Re: [PATCH] dwc3: dwc3-pci: Use SIMPLE_DEV_PM_OPS

2013-08-12 Thread Mark Brown
On Wed, Aug 07, 2013 at 08:51:27AM -0300, Fabio Estevam wrote: > From: Fabio Estevam > > Using SIMPLE_DEV_PM_OPS can make the code simpler and cleaner. > > Signed-off-by: Fabio Estevam Reviewed-by: Mark Brown signature.asc Description: Digital signature

dealing with enclosures that don't handle READ_CAPACITY10

2013-08-12 Thread Oliver Neukum
Hi, I got a bug report about an enclosure that mishandles READ_CAPACITY10. I don't want to introduce yet another quirk. So what about basing this on USB version? Regards Oliver >From 58cb3cd4b8a58d986b74e0a41d52de989dbe64bc Mon Sep 17 00:00:00 2001 From: Oliver Neukum Da

Re: [alsa-devel] Buffer size for ALSA USB PCM audio

2013-08-12 Thread Takashi Iwai
At Thu, 1 Aug 2013 13:37:45 -0400 (EDT), Alan Stern wrote: > > On Mon, 29 Jul 2013, Clemens Ladisch wrote: > > > Alan Stern wrote: > > > Clemens remarked some time ago that keeping the queue full would be > > > trivial, if only he knew how full it needed to be. The answer to that > > > is given

Re: [PATCH 1/2] USB: chipidea: i.MX: remove unused define

2013-08-12 Thread Peter Chen
On Mon, Aug 12, 2013 at 12:29:41PM +0200, Sascha Hauer wrote: > Signed-off-by: Sascha Hauer > --- > drivers/usb/chipidea/ci_hdrc_imx.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c > b/drivers/usb/chipidea/ci_hdrc_imx.c > index 14362c0..11ed423 10

Re: [PATCH 2/2] USB: chipidea: i.MX: simplify usbmisc

2013-08-12 Thread Peter Chen
On Mon, Aug 12, 2013 at 12:29:42PM +0200, Sascha Hauer wrote: > The chipidea i.MX driver is split into two drivers. The ci_hdrc_imx driver > handles the chipidea cores and the usbmisc_imx driver handles the noncore > registers common to all chipidea cores (but SoC specific). Current flow is: > > -

Re: [PATCH] usb: gadget: at91_udc: add usb_clk for transition to common clk framework

2013-08-12 Thread Nicolas Ferre
On 01/08/2013 08:18, Boris BREZILLON : The AT91 PMC (Power Management Controller) provides an USB clock used by USB Full Speed host (ohci) and USB Full Speed device (udc). The usb drivers (ohci and udc) must configure this clock to 48Mhz. This configuration was formely done in mach-at91/clock.c,

Re: [PATCH v2] USB: ohci-at91: add usb_clk for transition to common clk framework

2013-08-12 Thread Nicolas Ferre
On 01/08/2013 19:09, Boris BREZILLON : The AT91 PMC (Power Management Controller) provides an USB clock used by USB Full Speed host (ohci) and USB Full Speed device (udc). The usb drivers (ohci and udc) must configure this clock to 48Mhz. This configuration was formely done in mach-at91/clock.c,

Re: dealing with enclosures that don't handle READ_CAPACITY10

2013-08-12 Thread Alan Stern
On Mon, 12 Aug 2013, Oliver Neukum wrote: > Hi, > > I got a bug report about an enclosure that mishandles READ_CAPACITY10. > I don't want to introduce yet another quirk. So what about basing this > on USB version? > @@ -211,8 +212,12 @@ static int slave_configure(struct scsi_device *sdev) >

Re: dealing with enclosures that don't handle READ_CAPACITY10

2013-08-12 Thread Oliver Neukum
On Mon, 2013-08-12 at 10:36 -0400, Alan Stern wrote: > On Mon, 12 Aug 2013, Oliver Neukum wrote: > > > Hi, > > > > I got a bug report about an enclosure that mishandles READ_CAPACITY10. > > I don't want to introduce yet another quirk. So what about basing this > > on USB version? > > > @@ -211,8

Re: [alsa-devel] Buffer size for ALSA USB PCM audio

2013-08-12 Thread Alan Stern
On Mon, 12 Aug 2013, Takashi Iwai wrote: > > Here's what I've got. In turns out the predicting the optimum number > > of URBs needed is extremely difficult. I decided it would be better to > > make an overestimate and then to submit URBs as needed, rather than > > keeping all of them active all

Re: [alsa-devel] Buffer size for ALSA USB PCM audio

2013-08-12 Thread Takashi Iwai
At Mon, 12 Aug 2013 10:53:36 -0400 (EDT), Alan Stern wrote: > > On Mon, 12 Aug 2013, Takashi Iwai wrote: > > > > Here's what I've got. In turns out the predicting the optimum number > > > of URBs needed is extremely difficult. I decided it would be better to > > > make an overestimate and then

Re: [3.8-rc3 -> 3.8-rc4 regression] Re: [PATCH] module, async: async_synchronize_full() on module init iff async is used

2013-08-12 Thread Tejun Heo
Hello, Jonathan. On Mon, Aug 12, 2013 at 12:04:11AM -0700, Jonathan Nieder wrote: > My laptop fails to boot[1] with the message 'Volume group "data" not > found'. Bisects to v3.8-rc4~17 (the above commit). Reverting that > commit on top of current "master" (d92581fcad18, 2013-08-10) produces > a

Re: Non-enumerable devices on USB and other enumerable buses

2013-08-12 Thread Mark Brown
On Sun, Aug 11, 2013 at 11:08:37PM +0100, Grant Likely wrote: > full enumerating like that with either ACPI or FDT, but we could allow > for sparse population of devices when something is fixed like a > soldered down USB hub or USB Ethernet MAC. I agree, there's no point in listing things that ca

[PATCH] wusbcore: clean up list locking in urb enqueue

2013-08-12 Thread Thomas Pugliese
wa_urb_enqueue_run locks and unlocks its list lock as it traverses the list of queued transfers. This was done to prevent deadlocking due to acquiring locks in reverse order in different places. The problem is that releasing the lock during the list traversal could allow the dequeue routine t

Re: [PATCH] usb: xhci: Disable runtime PM suspend for quirky controllers.

2013-08-12 Thread Shawn Nematbakhsh
Hi Sarah, I will resubmit the patch with these changes shortly. On Fri, Aug 9, 2013 at 10:22 AM, Sarah Sharp wrote: > Hi Shawn, > > I noticed that the ChromeOS kernel tree is still using this particular > patch, and thought it was probably time to revisit it. > > On Sat, May 25, 2013 at 09:57:57

Re: [alsa-devel] Buffer size for ALSA USB PCM audio

2013-08-12 Thread Alan Stern
On Mon, 12 Aug 2013, Takashi Iwai wrote: > So... Clemens, Daniel, Eldad, could you guys review the latest version > of Alan's patch? I'd love to sort this out for 3.12. Here's a revised version of the patch (still untested). The difference is that this version tries always to keep a period's wo

[PATCH 1/1] USB-Serial: Fix error handling of usb_wwan

2013-08-12 Thread Matt Burtch
This fixes an issue where the bulk-in urb used for incoming data transfer is not resubmitted if the packet recieved contains an error status. This results in the driver locking until the port is closed and re-opened. Tested on a custom board with a Cinterion GSM module. Signed-off-by: Matt Burtc

Re: [PATCH 1/1] USB-Serial: Fix error handling of usb_wwan

2013-08-12 Thread Greg Kroah-Hartman
On Mon, Aug 12, 2013 at 10:11:39AM -0700, Matt Burtch wrote: > This fixes an issue where the bulk-in urb used for incoming data transfer > is not resubmitted if the packet recieved contains an error status. This > results in the driver locking until the port is closed and re-opened. > > Tested on

Re: [RFC/PATCH 2/2] usb: ehci: Add support for SINGLE_STEP_SET_FEATURE test of EHSET

2013-08-12 Thread Felipe Balbi
Hi, On Fri, Aug 09, 2013 at 11:04:48AM -0400, Alan Stern wrote: > > > > heh, it doesn't need to be entirely in the core. Core could have the > > > > generic calls and HCDs could implement some callbacks, but I think quite > > > > a bit of the code will be similar if we implement the same thing on

Re: DWC3 role switch cause IRQ request failed

2013-08-12 Thread Felipe Balbi
On Fri, Aug 09, 2013 at 03:16:20PM +, Wang, Yu Y wrote: > > On Fri, Aug 09, 2013 at 01:34:09PM +, Wang, Yu Y wrote: > > > > On Wed, Aug 07, 2013 at 12:03:34PM +, Wang, Yu Y wrote: > > > > > Hi Balbi, > > > > > > > > > > Because dwc3 driver request_threaded_irq with flags IRQF_ONESHOT >

Re: [RFC PATCH v2 1/3] usb: dwc3: msm: Add device tree binding information

2013-08-12 Thread Felipe Balbi
On Fri, Aug 09, 2013 at 10:31:58AM -0500, Kumar Gala wrote: > > On Aug 9, 2013, at 4:53 AM, Ivan T. Ivanov wrote: > > > From: "Ivan T. Ivanov" > > > > MSM USB3.0 core wrapper consist of USB3.0 IP (SNPS) > > probably good to spell out Synopsys rather than SNPS Synopsys (the company) has always

Re: [PATCH] usb: dwc3: core: clarify usb-phy array binding

2013-08-12 Thread Felipe Balbi
On Fri, Aug 09, 2013 at 01:42:15PM -0500, Kumar Gala wrote: > > On Aug 9, 2013, at 11:28 AM, Mark Rutland wrote: > > > On Fri, Aug 09, 2013 at 04:40:32PM +0100, Kumar Gala wrote: > >> The binding spec wasn't clear that the order of the phandles in the > >> usb-phy array has meaning. Clarify this

Re: Non-enumerable devices on USB and other enumerable buses

2013-08-12 Thread Stephen Warren
On 08/12/2013 05:07 AM, Mark Rutland wrote: > [Adding Olof] > > On Mon, Aug 12, 2013 at 10:51:36AM +0100, Mark Brown wrote: >> On Sun, Aug 11, 2013 at 09:53:01PM -0400, Alan Stern wrote: >>> On Sun, 11 Aug 2013, Mark Brown wrote: >> One example that's bugging me right now is that on the Insig

Re: [PATCH] usb: gadget/composite : Avoid crash with bad gadget drivers

2013-08-12 Thread Felipe Balbi
On Fri, Aug 09, 2013 at 09:23:08PM +0300, Philippe De Swert wrote: > Some bad gadget drivers do not check the return status of usb_add_config. fix the gadget driver > Thus they get a not correctly initialized config and when this gadget gets > deactivated the whole kernel crashes. Since on initia

Re: [PATCH] usb: gadget: at91_udc: add usb_clk for transition to common clk framework

2013-08-12 Thread Felipe Balbi
On Mon, Aug 12, 2013 at 03:52:01PM +0200, Nicolas Ferre wrote: > On 01/08/2013 08:18, Boris BREZILLON : > >The AT91 PMC (Power Management Controller) provides an USB clock used by > >USB Full Speed host (ohci) and USB Full Speed device (udc). > >The usb drivers (ohci and udc) must configure this cl

[PATCH v3] usb: rh_call_control tbuf overflow fix

2013-08-12 Thread Sean O. Stalley
rh_call_control() contains a buffer, tbuf, which it uses to hold USB descriptors. These discriptors are eventually copied into the transfer_buffer in the URB. The buffer in the URB is dynamically defined and is always large enough to hold the amount of data it requests. tbuf is currently staticall

Re: [PATCH 11/11] usb: misc: usb3503: Support operation with no I2C control

2013-08-12 Thread Dongjin Kim
Reviewed-by: Dongjin Kim I like this patch series, I dropped my changes to support non-i2c based operation. On Fri, Aug 9, 2013 at 7:41 PM, Mark Brown wrote: > From: Mark Brown > > Refactor so that register writes for configuration are only performed if > the device has a regmap provided and a

RE: [PATCH 3/3] staging: dwc2: add microframe scheduler from downstream Pi kernel

2013-08-12 Thread Paul Zimmerman
> From: popcornmix [mailto:popcorn...@gmail.com] > Sent: Monday, August 12, 2013 6:39 AM > > On Mon, Aug 12, 2013 at 8:40 AM, Matthijs Kooijman wrote: > > > Paul, did you try the patch without this hunk? > > Dom, can you tell use why this hunk is needed? > > The microframe patch originally came

Re: [RFC 2/2] usb: dwc3: Add Qualcomm DWC3 glue layer driver

2013-08-12 Thread Felipe Balbi
On Fri, Aug 09, 2013 at 07:09:18PM +0300, Ivan T. Ivanov wrote: > Hi, > > On Fri, 2013-08-09 at 16:23 +0300, Felipe Balbi wrote: > > Hi, > > > > On Tue, Aug 06, 2013 at 02:53:11PM +0300, Ivan T. Ivanov wrote: > > > diff --git a/drivers/usb/dwc3/dwc3-msm.c b/drivers/usb/dwc3/dwc3-msm.c > > > new

Re: [PATCH 3/3] staging: dwc2: add microframe scheduler from downstream Pi kernel

2013-08-12 Thread Greg KH
On Mon, Aug 12, 2013 at 06:18:00PM +, Paul Zimmerman wrote: > > From: popcornmix [mailto:popcorn...@gmail.com] > > Sent: Monday, August 12, 2013 6:39 AM > > > > On Mon, Aug 12, 2013 at 8:40 AM, Matthijs Kooijman > > wrote: > > > > > Paul, did you try the patch without this hunk? > > > Dom,

Re: Commit 09fc7d22b0 (usb: musb: fix incorrect usage of resource pointer) questions

2013-08-12 Thread Felipe Balbi
On Mon, Aug 12, 2013 at 12:35:25AM +0400, Sergei Shtylyov wrote: > Hello. > > On 08/11/2013 03:08 AM, Sergei Shtylyov wrote: > > >>>I have basically two questions on this change: > > [...] > > >>>2) why you omitted am35x.c from this commit? > > >>mistake > > >Are you going to fix it,

Re: [RFC PATCH v2 1/3] usb: dwc3: msm: Add device tree binding information

2013-08-12 Thread Kumar Gala
On Aug 12, 2013, at 1:04 PM, Felipe Balbi wrote: > On Fri, Aug 09, 2013 at 10:31:58AM -0500, Kumar Gala wrote: >> >> On Aug 9, 2013, at 4:53 AM, Ivan T. Ivanov wrote: >> >>> From: "Ivan T. Ivanov" >>> >>> MSM USB3.0 core wrapper consist of USB3.0 IP (SNPS) >> >> probably good to spell out Sy

Re: [RFC/PATCH 2/2] usb: ehci: Add support for SINGLE_STEP_SET_FEATURE test of EHSET

2013-08-12 Thread Alan Stern
On Mon, 12 Aug 2013, Felipe Balbi wrote: > > > maybe a single callback for supporting 'testmodes' ? which receives the > > > test mode as argument ? > > > > I don't have a clear picture of how you would apply such an approach to > > this case. There would have to be a way to tell the HCD to ins

Re: [PATCH v5 0/5] USB: HCD/EHCI: giveback of URB in tasklet context

2013-08-12 Thread Greg Kroah-Hartman
On Wed, Jul 03, 2013 at 10:53:06PM +0800, Ming Lei wrote: > Hi, > > The patchset supports to run giveback of URB in tasklet context, so that > DMA unmapping/mapping on transfer buffer and compelte() callback can be > run with interrupt enabled, then time of HCD interrupt handler(IRQs > disabled ti

[PATCH] usb: musb: dsps: make it depend on OF_IRQ

2013-08-12 Thread Felipe Balbi
musb_dsps.c utilizes a symbol which is only available when CONFIG_OF_IRQ is set, so make it depend on that. Signed-off-by: Felipe Balbi --- drivers/usb/musb/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/musb/Kconfig b/drivers/usb/musb/Kconfig index 04658d7..c64ee09a7 10

Re: [PATCH 1/4] usb: config->desc.bLength may not exceed amount of data returned by the device

2013-08-12 Thread Greg KH
On Sat, Aug 03, 2013 at 04:37:48PM +0200, Hans de Goede wrote: > While reading the config parsing code I noticed this check is missing, without > this check config->desc.wTotalLength can end up with a value larger then the > dev->rawdescriptors length for the config, and when userspace then tries t

Re: [PATCH 4/4] Documentation sysfs-bus-usb: Document all files used by libusb

2013-08-12 Thread Greg KH
On Sat, Aug 03, 2013 at 04:37:51PM +0200, Hans de Goede wrote: > Signed-off-by: Hans de Goede > --- > Documentation/ABI/testing/sysfs-bus-usb | 38 > + > 1 file changed, 38 insertions(+) This patch doesn't apply at all, can you redo it against the usb-next branch

Re: [PATCH V2] USB: EHCI: make ehci-w90X900 a separate driver

2013-08-12 Thread Greg KH
On Sat, Aug 10, 2013 at 01:04:33PM +0530, Manjunath Goudar wrote: > Separate the W90X900(W90P910) on-chip host controller driver from > ehci-hcd host code so that it can be built as a separate driver module. > This work is part of enabling multi-platform kernels on ARM; > however, note that other c

Re: [PATCH V3 1/2] USB: OHCI: make ohci-ep93xx a separate driver

2013-08-12 Thread Greg KH
On Sat, Aug 10, 2013 at 01:11:39PM +0530, Manjunath Goudar wrote: > Separate the OHCI EP93XX host controller driver from ohci-hcd > host code so that it can be built as a separate driver module. > This work is part of enabling multi-platform kernels on ARM. > > Signed-off-by: Manjunath Goudar > S

Re: [PATCH V5 4/6] USB: OHCI: make ohci-spear a separate driver

2013-08-12 Thread Greg KH
On Mon, Aug 12, 2013 at 12:26:09PM +0530, Viresh Kumar wrote: > On 12 August 2013 12:16, Manjunath Goudar wrote: > > This work is part of enabling multi-platform kernels on ARM; > > it would be nice to have in 3.11. > > You really want it in 3.11, we are already at 3.11-rc5 :) > > Whatever you w

Re: [PATCH V2] USB: OHCI: make ohci-nxp a separate driver

2013-08-12 Thread Greg KH
On Sat, Aug 10, 2013 at 01:14:15PM +0530, Manjunath Goudar wrote: > Separate the OHCI NXP host controller driver from ohci-hcd > host code so that it can be built as a separate driver module. > This work is part of enabling multi-platform kernels on ARM. > > Many place function name and struct nam

Re: [PATCH v3] usb: rh_call_control tbuf potential future overflow fix

2013-08-12 Thread Greg Kroah-Hartman
On Mon, Aug 12, 2013 at 11:09:25AM -0700, Sean O. Stalley wrote: > rh_call_control() contains a buffer, tbuf, which it uses to hold > USB descriptors. These discriptors are eventually copied into the > transfer_buffer in the URB. The buffer in the URB is dynamically > defined and is always large en

Re: Non-enumerable devices on USB and other enumerable buses

2013-08-12 Thread Mark Brown
On Mon, Aug 12, 2013 at 12:08:17PM -0600, Stephen Warren wrote: > In a similar way, I wonder if the USB case can be considered the same > way? This seems less like a good fit since I don't expect the resources > are always so similar there, and also there's the case of the bus being > potentially

Re: [RFC 0/2] USB port power off bug fixes

2013-08-12 Thread Greg Kroah-Hartman
On Tue, Aug 06, 2013 at 01:16:50PM -0700, Sarah Sharp wrote: > On Tue, Aug 06, 2013 at 02:48:57PM -0400, Alan Stern wrote: > > On Tue, 6 Aug 2013, Sarah Sharp wrote: > > > > > On Tue, Aug 06, 2013 at 10:16:15AM -0400, Alan Stern wrote: > > > > Patch 1 has been rendered out of date by intervening c

Re: Non-enumerable devices on USB and other enumerable buses

2013-08-12 Thread Greg Kroah-Hartman
On Mon, Aug 12, 2013 at 12:23:44PM +0100, Mark Brown wrote: > On Sun, Aug 11, 2013 at 07:02:57PM -0700, Greg Kroah-Hartman wrote: > > On Sun, Aug 11, 2013 at 08:08:26PM +0100, Mark Brown wrote: > > > > I know there's been some discussion of this topic but do we have any > > > general consensus on

Re: [PATCH] usb: gadget: at91_udc: add usb_clk for transition to common clk framework

2013-08-12 Thread boris brezillon
Hello Nicolas, On 12/08/2013 15:52, Nicolas Ferre wrote: On 01/08/2013 08:18, Boris BREZILLON : The AT91 PMC (Power Management Controller) provides an USB clock used by USB Full Speed host (ohci) and USB Full Speed device (udc). The usb drivers (ohci and udc) must configure this clock to 48Mhz.

Re: [PATCH] usb: gadget: at91_udc: add usb_clk for transition to common clk framework

2013-08-12 Thread boris brezillon
Hello Felipe On 12/08/2013 20:08, Felipe Balbi wrote: On Mon, Aug 12, 2013 at 03:52:01PM +0200, Nicolas Ferre wrote: On 01/08/2013 08:18, Boris BREZILLON : The AT91 PMC (Power Management Controller) provides an USB clock used by USB Full Speed host (ohci) and USB Full Speed device (udc). The u

Re: patch "usb: ehci: Add support for SINGLE_STEP_SET_FEATURE test of EHSET" added to usb tree

2013-08-12 Thread Alan Stern
On Mon, 12 Aug 2013 gre...@linuxfoundation.org wrote: > This is a note to let you know that I've just added the patch titled > > usb: ehci: Add support for SINGLE_STEP_SET_FEATURE test of EHSET > > to my usb git tree which can be found at > git://git.kernel.org/pub/scm/linux/kernel/git/g

Re: [PATCH 1/2] ACPI / PCI: don't allow PCI devices without irq to be enabled

2013-08-12 Thread Yinghai Lu
On Mon, Aug 12, 2013 at 2:14 PM, Bjorn Helgaas wrote: > On Thu, Aug 8, 2013 at 7:57 AM, Rafael J. Wysocki wrote: >> On Thursday, August 08, 2013 03:35:13 PM Heikki Krogerus wrote: >>> If there is no ACPI entry for the irq, returning error from >>> acpi_pci_enable_irq() if the irq is 0. >>> >>> Pr

Re: Non-enumerable devices on USB and other enumerable buses

2013-08-12 Thread Mark Brown
On Mon, Aug 12, 2013 at 01:50:07PM -0700, Greg Kroah-Hartman wrote: > On Mon, Aug 12, 2013 at 12:23:44PM +0100, Mark Brown wrote: > > I don't think they're bus specific - the main issue with a lot of this > > is that they're outside the infrastructure that the bus standardises so > > we should hav

[RFC 1/3] xhci: trace debug statements for urb cancellation

2013-08-12 Thread Xenia Ragiadakou
This patch defines a new trace event, which is called xhci_dbg_cancel_urb and belongs to the event class xhci_log_msg, and adds tracepoints that trace the debug messages related to the removal of a cancelled URB from the endpoint's transfer ring. Signed-off-by: Xenia Ragiadakou --- drivers/usb/h

Re: patch "usb: ehci: Add support for SINGLE_STEP_SET_FEATURE test of EHSET" added to usb tree

2013-08-12 Thread Jack Pham
On Mon, Aug 12, 2013 at 05:03:17PM -0400, Alan Stern wrote: > Okay, I was a little too late and Greg has merged the patch. > > Jack or Manu, can you write a follow-on patch that adds a Kconfig > option to enable test modes in the HCDs, and then avoids compiling the > new code added to ehci-hcd i

[RFC 2/3] xhci: trace debug messages related to driver initialization and unload

2013-08-12 Thread Xenia Ragiadakou
This patch defines a new trace event, which is called xhci_dbg_init and belongs to the event class xhci_log_msg, and adds tracepoints that trace the debug statements in the functions used to start and stop the xhci-hcd driver. Also, it removes an unnecessary cast of variable val to unsigned int in

[RFC 3/3] xhci: trace debug statements related to ring expansion

2013-08-12 Thread Xenia Ragiadakou
This patch defines a new trace event, which is called xhci_dbg_ring_expansion and belongs to the event class xhci_log_msg, and adds tracepoints that trace the debug messages associated with the expansion of endpoint ring when there is not enough space allocated to hold all pending TRBs. Signed-off

Re: [PATCH 1/2] Revert "Revert "HID: Fix logitech-dj: missing Unifying device issue""

2013-08-12 Thread Peter Wu
On Thursday 18 July 2013 16:28:01 Peter Hurley wrote: > Before we revert to using the workaround, I'd like to suggest that > this new "hidden" problem may be an interaction with the xhci_hcd host > controller driver only. > > Looking at the related bug, the OP indicates the machine only has > USB3

Re: [PATCH 2/4] staging: ozwpan: Increment port number for new device.

2013-08-12 Thread Greg KH
On Mon, Aug 05, 2013 at 06:40:13PM +0100, Rupesh Gujare wrote: > This patch fixes crash issue when there is quick cycle of > de-enumeration & enumeration due to loss of wireless link. > > It is found that sometimes new device (or coming back device) > returns very fast, even before USB core read o

Re: [PATCH 1/2] ACPI / PCI: don't allow PCI devices without irq to be enabled

2013-08-12 Thread Bjorn Helgaas
On Mon, Aug 12, 2013 at 3:32 PM, Yinghai Lu wrote: > On Mon, Aug 12, 2013 at 2:14 PM, Bjorn Helgaas wrote: >> On Thu, Aug 8, 2013 at 7:57 AM, Rafael J. Wysocki wrote: >>> On Thursday, August 08, 2013 03:35:13 PM Heikki Krogerus wrote: If there is no ACPI entry for the irq, returning error f

RE: [PATCH 2/3] staging: dwc2: add NAK holdoff patch from downstream Pi kernel

2013-08-12 Thread Paul Zimmerman
> From: Matthijs Kooijman [mailto:matth...@stdin.nl] > Sent: Monday, August 12, 2013 12:36 AM > To: Paul Zimmerman > Cc: gre...@linuxfoundation.org; linux-usb@vger.kernel.org; > de...@linuxdriverproject.org; > swar...@wwwdotorg.org; gordon.hollingwo...@gmail.com; sk...@netbsd.org; Dom > Cobley >

[PATCH] usb: host: add Kconfig option for EHSET

2013-08-12 Thread Jack Pham
commit 9841f37a1c ("usb: ehci: Add support for SINGLE_STEP_SET_FEATURE test of EHSET") added additional code to the EHCI hub driver but it is anticipated to only have a limited audience (e.g. embedded silicon vendors and integrators). Avoid subjecting all EHCI (and in the future maybe xHCI/OHCI, et

RE: [PATCH v3] usb: rh_call_control tbuf potential future overflow fix

2013-08-12 Thread Stalley, Sean
> -Original Message- > From: Greg Kroah-Hartman [mailto:gre...@linuxfoundation.org] > Sent: Monday, August 12, 2013 1:32 PM > To: Stalley, Sean > Cc: linux-usb@vger.kernel.org; Sarah Sharp; Ismail, Abdul R; Alan Stern > Subject: Re: [PATCH v3] usb: rh_call_control tbuf potential future ov

RTL8192CU module device HW:ID support

2013-08-12 Thread srenaud20
Hello ! Is it possible to add the "Hercules mini 300m v2" in the device list of rtl8192cu. The ID of this one is "0x06F8, 0xE035". Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://v

Re: [PATCH v3] usb: rh_call_control tbuf potential future overflow fix

2013-08-12 Thread Greg Kroah-Hartman
On Mon, Aug 12, 2013 at 11:16:24PM +, Stalley, Sean wrote: > > > > -Original Message- > > From: Greg Kroah-Hartman [mailto:gre...@linuxfoundation.org] > > Sent: Monday, August 12, 2013 1:32 PM > > To: Stalley, Sean > > Cc: linux-usb@vger.kernel.org; Sarah Sharp; Ismail, Abdul R; Alan

Re: RTL8192CU module device HW:ID support

2013-08-12 Thread Greg KH
On Tue, Aug 13, 2013 at 01:50:55AM +0200, srenau...@free.fr wrote: > Hello ! > Is it possible to add the "Hercules mini 300m v2" in the device list of > rtl8192cu. > The ID of this one is "0x06F8, 0xE035". Does the driver work with these new device ids? If so, great, can you send us a patch addi

Re: RTL8192CU module device HW:ID support

2013-08-12 Thread Fabio Estevam
On Mon, Aug 12, 2013 at 8:50 PM, wrote: > Hello ! > Is it possible to add the "Hercules mini 300m v2" in the device list of > rtl8192cu. > The ID of this one is "0x06F8, 0xE035". Does this work for you? diff --git a/drivers/net/wireless/rtlwifi/rtl8192cu/sw.c b/drivers/net/wireless/rtlwifi/rtl

Re: Non-enumerable devices on USB and other enumerable buses

2013-08-12 Thread Alan Stern
On Mon, 12 Aug 2013, Mark Brown wrote: > On Mon, Aug 12, 2013 at 01:50:07PM -0700, Greg Kroah-Hartman wrote: > > On Mon, Aug 12, 2013 at 12:23:44PM +0100, Mark Brown wrote: > > > > I don't think they're bus specific - the main issue with a lot of this > > > is that they're outside the infrastruct

RE: DWC3 role switch cause IRQ request failed

2013-08-12 Thread Wang, Yu Y
> On Fri, Aug 09, 2013 at 03:16:20PM +, Wang, Yu Y wrote: > > > On Fri, Aug 09, 2013 at 01:34:09PM +, Wang, Yu Y wrote: > > > > > On Wed, Aug 07, 2013 at 12:03:34PM +, Wang, Yu Y wrote: > > > > > > Hi Balbi, > > > > > > > > > > > > Because dwc3 driver request_threaded_irq with flags > >

Bug 60738 - USB 3.0 connection delay seems to be too short for HP USB 3.0 hard drive

2013-08-12 Thread Alexandre Demers
Hi, As requested by Greg Kroah, please see bug 60738 - Summary: USB 3.0 connection delay seems to be too short for HP USB 3.0 hard drive. I'll be pleased to help you as much as possible. -- Alexandre Demers -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body o

Re: Bug 60738 - USB 3.0 connection delay seems to be too short for HP USB 3.0 hard drive

2013-08-12 Thread Greg KH
On Tue, Aug 13, 2013 at 12:26:25AM -0400, Alexandre Demers wrote: > Hi, > > As requested by Greg Kroah, please see bug 60738 - Summary: USB 3.0 > connection delay seems to be too short for HP USB 3.0 hard drive. Please just post the information you posted there (at the least, a url would be good

Re: Bug 60738 - USB 3.0 connection delay seems to be too short for HP USB 3.0 hard drive

2013-08-12 Thread Alexandre Demers
Sorry, here are more details. I'm refering to https://bugzilla.kernel.org/show_bug.cgi?id=60738 To sum up: Most of the time, my HP USB 3.0 hard drive will not be properly mounted when booting or when connecting it. I usually end up with something similar to the following in dmesg: [ 204.0816

Re: [PATCH 1/2] usb: core: don't try to reset_device() a port that got just disconnected

2013-08-12 Thread Greg Kroah-Hartman
On Tue, Aug 06, 2013 at 08:40:56PM -0700, Sarah Sharp wrote: > On Tue, Aug 06, 2013 at 06:04:36AM +0800, Greg Kroah-Hartman wrote: > > On Mon, Aug 05, 2013 at 09:46:46AM -0700, Sarah Sharp wrote: > > > I wanted to test it for a kernel release to make sure it didn't cause > > > any issues before sen

Re: Regression: USB memory stick stalls and no longer automounts under 3.11-rc1

2013-08-12 Thread Greg KH
On Mon, Aug 05, 2013 at 09:07:51PM -0400, Alan Stern wrote: > On Tue, 6 Aug 2013, Greg KH wrote: > > > > Have you tried this patch? > > > > > > http://marc.info/?l=linux-usb&m=137523956310060&w=2 > > > > What is the status of this patch, I'm starting to get lots of complaints > > about this :(

Re: Bug 60738 - USB 3.0 connection delay seems to be too short for HP USB 3.0 hard drive

2013-08-12 Thread Kumar Gaurav
Hi Alexandre, I'm new to kernel development. I want to explore this bug. From you dmesg output I'm unable to get the driver your device is using. can you tell me which driver are you using? regards Kumar Gaurav On Tuesday 13 August 2013 11:15 AM, Alexandre Demers wrote: Sorry, here are mor

Re: Bug 60738 - USB 3.0 connection delay seems to be too short for HP USB 3.0 hard drive

2013-08-12 Thread Alexandre Demers
lsusb gives me the following: sudo lsusb --verbose -t /: Bus 13.Port 1: Dev 1, Class=root_hub, Driver=xhci_hcd/2p, 5000M /: Bus 12.Port 1: Dev 1, Class=root_hub, Driver=xhci_hcd/2p, 480M /: Bus 11.Port 1: Dev 1, Class=root_hub, Driver=xhci_hcd/2p, 5000M /: Bus 10.Port 1: Dev 1, Class=root_hub, Dr