Commit 09fc7d22b0 (usb: musb: fix incorrect usage of resource pointer) questions

2013-08-04 Thread Sergei Shtylyov
Hello. I have basically two questions on this change: 1) why it wasn't published before committing? 2) why you omitted am35x.c from this commit? WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majo

[PATCH] staging: ozwpan: Fix build warning.

2013-08-04 Thread Rupesh Gujare
This patch fixes following build warning. drivers/built-in.o: In function `oz_hcd_heartbeat': >> (.text+0x30aadd): undefined reference to `__divdi3' drivers/built-in.o: In function `oz_hcd_heartbeat': >> (.text+0x30ac85): undefined reference to `__divdi3' Signed-off-by: Rupesh Gujare --- dri

Re: [PATCH] staging: ozwpan: Fix build warning.

2013-08-04 Thread Anca Emanuel
Why do not use div_u64() ? [quote]unsigned 64bit divide with 32bit divisor This is the most common 64bit divide and should be used if possible, as many 32bit archs can optimize this variant better than a full 64bit divide. [/quote] > - ep->credit += timespec_to_ns(&delta) / NSEC_PE

Re: [PATCH] usb: fix some scripts/kernel-doc warnings

2013-08-04 Thread Yacine Belkadi
On 08/03/2013 05:29 AM, Greg Kroah-Hartman wrote: > On Fri, Aug 02, 2013 at 08:10:04PM +0200, Yacine Belkadi wrote: >> When building the htmldocs (in verbose mode), scripts/kernel-doc reports the >> following type of warnings: >> >> Warning(drivers/usb/core/usb.c:76): No description found for retur

Re: [PATCH] usb: fix some scripts/kernel-doc warnings

2013-08-04 Thread Greg Kroah-Hartman
On Sun, Aug 04, 2013 at 10:05:36PM +0200, Yacine Belkadi wrote: > On 08/03/2013 05:29 AM, Greg Kroah-Hartman wrote: > > On Fri, Aug 02, 2013 at 08:10:04PM +0200, Yacine Belkadi wrote: > >> When building the htmldocs (in verbose mode), scripts/kernel-doc reports > >> the > >> following type of warn

[PATCH 1/4] usb: gadget: f_mass_storage: use NULL instead of 0

2013-08-04 Thread Jingoo Han
The local variables such as 'filename', 'vendor_name', and 'product_name' are pointers; thus, use NULL instead of 0 to fix the following sparse warnings drivers/usb/gadget/f_mass_storage.c:3046:27: warning: Using plain integer as NULL pointer drivers/usb/gadget/f_mass_storage.c:3050:28: warning:

[PATCH 2/4] usb: gadget: rndis: Staticize rndis_init()/rndis_exit()

2013-08-04 Thread Jingoo Han
rndis_init() and rndis_exit() are used only in this file. Fix the following sparse warnings: drivers/usb/gadget/rndis.c:1145:5: warning: symbol 'rndis_init' was not declared. Should it be static? drivers/usb/gadget/rndis.c:1179:6: warning: symbol 'rndis_exit' was not declared. Should it be stati

[PATCH 3/4] usb: gadget: u_uac1: add __user annotation

2013-08-04 Thread Jingoo Han
Added __user annotation to fix the following sparse warning. drivers/usb/gadget/u_uac1.c:194:52: warning: incorrect type in argument 2 (different address spaces) drivers/usb/gadget/u_uac1.c:194:52:expected void const [noderef] *buf drivers/usb/gadget/u_uac1.c:194:52:got void *buf Signed-

[PATCH 4/4] usb: gadget: f_uac1: Staticize local functions

2013-08-04 Thread Jingoo Han
control_selector_init() is used only in this file. audio_bind_config() is used only in audio.c file to which f_uac1.c is included. Thus, these functions are staticized to fix the following warnings. drivers/usb/gadget/f_uac1.c:698:12: warning: symbol 'control_selector_init' was not declared. Shou

Re: [PATCH 4/4] usb: gadget: f_uac1: Staticize local functions

2013-08-04 Thread Jassi Brar
On 5 August 2013 08:45, Jingoo Han wrote: > control_selector_init() is used only in this file. > audio_bind_config() is used only in audio.c file to which > f_uac1.c is included. Thus, these functions are staticized > to fix the following warnings. > > drivers/usb/gadget/f_uac1.c:698:12: warning:

Re: [PATCH 3/4] usb: gadget: u_uac1: add __user annotation

2013-08-04 Thread Jassi Brar
On 5 August 2013 08:44, Jingoo Han wrote: > Added __user annotation to fix the following sparse warning. > > drivers/usb/gadget/u_uac1.c:194:52: warning: incorrect type in argument 2 > (different address spaces) > drivers/usb/gadget/u_uac1.c:194:52:expected void const [noderef] > *buf > driv

[PATCH 1/2] usb: phy: mv-u3d: Staticize mv_u3d_phy_shutdown()

2013-08-04 Thread Jingoo Han
mv_u3d_phy_shutdown() is used only in this file. Fix the following sparse warning: drivers/usb/phy/phy-mv-u3d-usb.c:85:6: warning: symbol 'mv_u3d_phy_shutdown' was not declared. Should it be static? Signed-off-by: Jingoo Han --- drivers/usb/phy/phy-mv-u3d-usb.c |2 +- 1 file changed, 1 ins

[PATCH 2/2] usb: phy: mv-usb: remove incorrect __exit_p annotation

2013-08-04 Thread Jingoo Han
When platform_driver_probe() is not used, bind/unbind via sysfs is enabled. Thus, __exit_p annotation should be removed from remove(). Also, mv_otg_remove() is staticized, because this function is used only in this file. Fix the following sparse warning: drivers/usb/phy/phy-mv-usb.c:656:5: warni

Re: [PATCH 1/2] usb: core: don't try to reset_device() a port that got just disconnected

2013-08-04 Thread Greg Kroah-Hartman
On Wed, Jul 31, 2013 at 11:30:28AM -0700, Sarah Sharp wrote: > From: Julius Werner > > The USB hub driver's event handler contains a check to catch SuperSpeed > devices that transitioned into the SS.Inactive state and tries to fix > them with a reset. It decides whether to do a plain hub port res

Re: [Pull Request] xhci: Misc bug fixes for 3.11.

2013-08-04 Thread Greg Kroah-Hartman
On Wed, Jul 31, 2013 at 11:30:27AM -0700, Sarah Sharp wrote: > The following changes since commit fed1f1ed90bce42ea010e2904cbc04e7b8304940: > > USB: serial: ftdi_sio: add more RT Systems ftdi devices (2013-07-29 > 13:38:38 -0700) > > are available in the git repository at: > > git://git.ker

[PATCH 1/1] usb: chipidea: refine the operation of creating register mapping

2013-08-04 Thread Peter Chen
- The old operation needs to call hw_alloc_regmap two times, and the first operation is only used to know if the controller is lpm supported, besides, there is a kfree before kzalloc, it is also tricky. - Fix the memory leak for ci->hw_bank.regmap when unload module. Signed-off-by: Peter Chen --

Re: [PATCH] clk: tegra30: Don't wait for PLL_U lock bit

2013-08-04 Thread Prashant Gaikwad
On Thursday 01 August 2013 02:34 AM, Stephen Warren wrote: On 07/31/2013 11:42 AM, Tuomas Tynkkynen wrote: The lock bit on PLL_U does not seem to be working correctly and sometimes never gets set when waiting for the PLL to come up. Remove the TEGRA_PLL_USE_LOCK flag to use a constant delay. Pe