Re: About the hibernation feature implementation in dwc3 driver

2013-08-02 Thread Felipe Balbi
Hi, +linux-usb Always add linux-usb On Fri, Aug 02, 2013 at 05:33:32AM +, Wang, Yu Y wrote: > We are the USB3 driver developers from Intel. And also base on > Synopsys DWC USB3 OTG controller. good to see Intel is also using my driver. > We base on your driver to enabled hibernation featur

Re: Ejected Nook (usb mass storage) prevents suspend

2013-08-02 Thread Oliver Neukum
On Thu, 2013-08-01 at 11:53 -0400, Alan Stern wrote: > On Thu, 1 Aug 2013, Oliver Neukum wrote: > > > On Wed, 2013-07-31 at 11:13 -0400, Alan Stern wrote: > > > > > More importantly, if we already know that the medium is not present or > > > has been changed since it was last used, then there's n

Re: [PATCH v2] usb-gadget-audio-file-wake-up-sleep-thread

2013-08-02 Thread Felipe Balbi
Hi, On Fri, Aug 02, 2013 at 01:15:33PM +0800, Qiao Zhou wrote: > On 08/01/2013 06:21 PM, Qiao Zhou wrote: > >v2->v1: > >stop pcm stream instead of wake up the sleep thread, which is more > >reasonable. > > > >Qiao Zhou (1): > > usb: gadget: audio file: wake up sleep thread when device unbind > >

[PATCH] usb: dwc3: pci: add CONFIG_PM_SLEEP to suspend/resume functions

2013-08-02 Thread Jingoo Han
Add CONFIG_PM_SLEEP to suspend/resume functions to fix the following build warning when CONFIG_PM_SLEEP is not selected. This is because sleep PM callbacks defined by SET_SYSTEM_SLEEP_PM_OPS are only used when the CONFIG_PM_SLEEP is enabled. Unnecessary CONFIG_PM ifdefs are removed. drivers/usb/dw

Re: [PATCH resend] MAINTAINERS: Add separate section for USB NETWORKING DRIVERS

2013-08-02 Thread Greg KH
On Thu, Aug 01, 2013 at 09:03:32PM -0700, Joe Perches wrote: > There are several drivers in drivers/net/usb/ that > do not have specific MAINTAINERS that should have > emails forwarded to the linux-usb mailing list. > > Add a section for those drivers. Thanks, I'll queue this up next week for the

Re: [PATCH] usb: dwc3: pci: add CONFIG_PM_SLEEP to suspend/resume functions

2013-08-02 Thread Felipe Balbi
Hi, On Fri, Aug 02, 2013 at 04:33:12PM +0900, Jingoo Han wrote: > Add CONFIG_PM_SLEEP to suspend/resume functions to fix the following > build warning when CONFIG_PM_SLEEP is not selected. This is because > sleep PM callbacks defined by SET_SYSTEM_SLEEP_PM_OPS are only used > when the CONFIG_PM_SL

Re: [PATCH 1/1] usb: phy: samsung: Update usbphy documentation

2013-08-02 Thread Felipe Balbi
Hi, On Thu, Aug 01, 2013 at 02:54:35PM +0530, Sachin Kamat wrote: > Updated the documentation as per the latest driver implementation. > While at it also fixed some trivial typos. > > Signed-off-by: Sachin Kamat this can go through DeviceTree maintainers: Acked-by: Felipe Balbi -- balbi s

Re: [PATCH] usb: dwc3: pci: add CONFIG_PM_SLEEP to suspend/resume functions

2013-08-02 Thread Jingoo Han
On Friday, August 02, 2013 4:38 PM, Felipe Balbi wrote: > On Fri, Aug 02, 2013 at 04:33:12PM +0900, Jingoo Han wrote: > > Add CONFIG_PM_SLEEP to suspend/resume functions to fix the following > > build warning when CONFIG_PM_SLEEP is not selected. This is because > > sleep PM callbacks defined by SE

Re: [PATCH v2] usb: gadget: at91_udc: add usb_clk for transition to common clk framework

2013-08-02 Thread Felipe Balbi
Hi, On Thu, Aug 01, 2013 at 07:07:50PM +0200, Boris BREZILLON wrote: > @@ -1851,6 +1860,12 @@ fail3: > fail2: > free_irq(udc->udp_irq, udc); > fail1: > + if (IS_ENABLED(CONFIG_COMMON_CLK) && !IS_ERR(udc->uclk)) > + clk_put(udc->uclk); > + if (!IS_ERR(udc->fclk)) > +

Re: Audio I/O parameters

2013-08-02 Thread James Stone
On Thu, Aug 1, 2013 at 5:43 PM, Alan Stern wrote: > On Thu, 1 Aug 2013, James Stone wrote: > >> > SMIs are controlled by the BIOS, not by the kernel. I don't think >> > changing the kernel would affect their timings. >> > >> >> Hmm.. ok. So do I need to see if there is a bios update/report this t

Re: [PATCH] usb: dwc3: pci: add CONFIG_PM_SLEEP to suspend/resume functions

2013-08-02 Thread Felipe Balbi
On Fri, Aug 02, 2013 at 04:47:04PM +0900, Jingoo Han wrote: > On Friday, August 02, 2013 4:38 PM, Felipe Balbi wrote: > > On Fri, Aug 02, 2013 at 04:33:12PM +0900, Jingoo Han wrote: > > > Add CONFIG_PM_SLEEP to suspend/resume functions to fix the following > > > build warning when CONFIG_PM_SLEEP i

Re: [PATCH 1/3] usb: phy-samsung-usb: Simplify PMU register handling

2013-08-02 Thread Felipe Balbi
Hi, On Thu, Aug 01, 2013 at 05:52:04PM -0700, Julius Werner wrote: > This patch simplifies the way the phy-samsung-usb code finds the correct > power management register to enable PHY clock gating. Previously, the > code would calculate the register address from a device tree supplied > base addre

Re: [PATCH 0/6] USB tree changes for Tegra30 and Tegra114 USB Host support

2013-08-02 Thread Felipe Balbi
On Thu, Aug 01, 2013 at 10:22:19AM -0600, Stephen Warren wrote: > On 08/01/2013 07:02 AM, Tuomas Tynkkynen wrote: > > On 08/01/2013 02:22 AM, Stephen Warren wrote: > >> On 07/31/2013 11:41 AM, Tuomas Tynkkynen wrote: > >>> Hi all, > >>> > >>> Here are the patches for the USB tree to enable USB Host

Re: [PATCH] usb: dwc3: pci: add CONFIG_PM_SLEEP to suspend/resume functions

2013-08-02 Thread Jingoo Han
On Friday, August 02, 2013 4:50 PM, Felipe Balbi wrote: > On Fri, Aug 02, 2013 at 04:47:04PM +0900, Jingoo Han wrote: > > On Friday, August 02, 2013 4:38 PM, Felipe Balbi wrote: > > > On Fri, Aug 02, 2013 at 04:33:12PM +0900, Jingoo Han wrote: [...] > > > > -#ifdef CONFIG_PM > > > > +#ifdef CONF

Re: [PATCH] usb: dwc3: pci: add CONFIG_PM_SLEEP to suspend/resume functions

2013-08-02 Thread Felipe Balbi
Hi, On Fri, Aug 02, 2013 at 05:04:17PM +0900, Jingoo Han wrote: > On Friday, August 02, 2013 4:50 PM, Felipe Balbi wrote: > > On Fri, Aug 02, 2013 at 04:47:04PM +0900, Jingoo Han wrote: > > > On Friday, August 02, 2013 4:38 PM, Felipe Balbi wrote: > > > > On Fri, Aug 02, 2013 at 04:33:12PM +0900,

[PATCH V2] usb: dwc3: pci: add CONFIG_PM_SLEEP to suspend/resume functions

2013-08-02 Thread Jingoo Han
Add CONFIG_PM_SLEEP to suspend/resume functions to fix the following build warning when CONFIG_PM_SLEEP is not selected. This is because sleep PM callbacks defined by SET_SYSTEM_SLEEP_PM_OPS are only used when the CONFIG_PM_SLEEP is enabled. Unnecessary CONFIG_PM ifdefs are removed. drivers/usb/dw

[PATCH 1/2] usb: gadget: goku_udc: use NULL instead of 0

2013-08-02 Thread Jingoo Han
'req' is a pointer; thus, use NULL instead of 0 to fix the following sparse warning: drivers/usb/gadget/goku_udc.c:775:13: warning: Using plain integer as NULL pointer Signed-off-by: Jingoo Han --- drivers/usb/gadget/goku_udc.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --g

[PATCH 2/2] usb: gadget: fusb300_udc: Staticize fusb300_rdcxf()

2013-08-02 Thread Jingoo Han
fusb300_rdcxf() used only in this file. Fix the following sparse warning: drivers/usb/gadget/fusb300_udc.c:560:6: warning: symbol 'fusb300_rdcxf' was not declared. Should it be static? Signed-off-by: Jingoo Han --- drivers/usb/gadget/fusb300_udc.c |2 +- 1 file changed, 1 insertion(+), 1 d

Re: question: do we have any UML like design diagram for usb core and driver model?

2013-08-02 Thread Chen Wang
This book is good, thank you very much. looping in the mail-list. On Fri, 2013-08-02 at 10:32 +0530, Rajaram R wrote: > On Thu, Aug 1, 2013 at 2:43 PM, Chen Wang wrote: > > hello, > > I'm reading code of usb core and driver model/sysfs. I believe they are > > designed with OOP. So, do we have an

[PATCH v14 01/12] usb: chipidea: move vbus regulator operation to core

2013-08-02 Thread Peter Chen
The vbus regulator is a common element for USB vbus operation, So, move it from glue layer to core. Tested-by: Marek Vasut Signed-off-by: Michael Grzeschik Signed-off-by: Peter Chen --- drivers/usb/chipidea/ci_hdrc_imx.c | 26 ++ drivers/usb/chipidea/core.c|

[PATCH v14 04/12] usb: chipidea: otg: Add otg file used to access otgsc

2013-08-02 Thread Peter Chen
This file is mainly used to access otgsc currently, it may add otg related things in the future. Tested-by: Marek Vasut Signed-off-by: Peter Chen --- drivers/usb/chipidea/Makefile |2 +- drivers/usb/chipidea/bits.h | 10 drivers/usb/chipidea/core.c |3 +- drivers/usb/chip

[PATCH v3 0/2] usb: gadget: at91_udc: add usb_clk for transition to common clk framework

2013-08-02 Thread Boris BREZILLON
Hello, This patch series prepare the at91 SoCs transition to common clk framework. This is done by adding a new clock (called usb clock or uclk) to at91_udc driver. This clock will be used to configure the usb port clock rate. Best Regards, Boris Changes since v2: - split the patch in 2 parts:

[PATCH v14 05/12] usb: chipidea: Add role init and destory APIs

2013-08-02 Thread Peter Chen
- The role's init will be called at probe procedure. - The role's destory will be called at fail patch at probe and driver's removal. - The role's start/stop will be called when specific role has started. Tested-by: Marek Vasut Signed-off-by: Peter Chen --- drivers/usb/chipidea/core.c | 10 ++

[PATCH v14 06/12] usb: chipidea: add flag CI_HDRC_DUAL_ROLE_NOT_OTG

2013-08-02 Thread Peter Chen
Since we need otgsc to know vbus's status at some chipidea controllers even it is peripheral-only mode. Besides, some SoCs (eg, AR9331 SoC) don't have otgsc register even the DCCPARAMS_DC and DCCPARAMS_HC are both 1 at CAP_DCCPARAMS. We inroduce flag CI_HDRC_DUAL_ROLE_NOT_OTG to indicate if the co

[PATCH v14 07/12] usb: chipidea: disable all interrupts and clear all interrupts status

2013-08-02 Thread Peter Chen
During the initialization, it needs to disable all interrupts enable bit as well as clear all interrupts status bits to avoid exceptional interrupt. Tested-by: Marek Vasut Signed-off-by: Peter Chen --- drivers/usb/chipidea/core.c | 11 ++- 1 files changed, 10 insertions(+), 1 deletion

[PATCH v14 03/12] usb: chipidea: udc: otg_set_peripheral is useless for some chipidea users

2013-08-02 Thread Peter Chen
It is useless at below cases: - If we implement both usb host and device at chipidea driver. - If we don't need phy->otg. Tested-by: Marek Vasut Signed-off-by: Peter Chen --- drivers/usb/chipidea/udc.c |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/drivers/usb/ch

[PATCH v14 11/12] usb: chipidea: udc: misuse flag CI_HDRC_REGS_SHARED and CI_HDRC_PULLUP_ON_VBUS

2013-08-02 Thread Peter Chen
CI_HDRC_REGS_SHARED stands for the controller registers is shared with other USB drivers, if all USB drivers are at chipidea/, it doesn't needed to set. CI_HDRC_PULLUP_ON_VBUS stands for pullup dp when the vbus is on. This flag doesn't need to set if the vbus is always on for gadget since dp has al

[PATCH v14 02/12] usb: chipidea: host: add vbus regulator control

2013-08-02 Thread Peter Chen
For boards which have board level vbus control (eg, through gpio), we need to vbus operation according to below rules: - For host, we need open vbus before start hcd, and close it after remove hcd. - For otg, the vbus needs to be on/off when usb role switches. When the host roles begins, it opens v

[PATCH v14 09/12] usb: chipidea: add vbus interrupt handler

2013-08-02 Thread Peter Chen
We add vbus interrupt handler at ci_otg_work, it uses OTGSC_BSV(at otgsc) to know it is connect or disconnet event. Meanwhile, we introduce two flags id_event and b_sess_valid_event to indicate it is an id interrupt or a vbus interrupt. Tested-by: Marek Vasut Signed-off-by: Peter Chen --- drive

[PATCH v14 10/12] usb: chipidea: add wait vbus lower than OTGSC_BSV before role starts

2013-08-02 Thread Peter Chen
When the gadget role starts, we need to make sure the vbus is lower than OTGSC_BSV, or there will be an vbus interrupt since we use B_SESSION_VALID as vbus interrupt to indicate connect and disconnect. When the host role starts, it may not be useful to wait vbus to lower than OTGSC_BSV, but it can

[PATCH v14 08/12] usb: chipidea: move otg relate things to otg file

2013-08-02 Thread Peter Chen
Move otg relate things to otg file. Tested-by: Marek Vasut Signed-off-by: Peter Chen --- drivers/usb/chipidea/core.c | 63 +-- drivers/usb/chipidea/otg.c | 57 +- drivers/usb/chipidea/otg.h |2 + 3 files chang

[PATCH v14 12/12] usb: chipidea: udc: .pullup is valid when vbus is on at CI_HDRC_PULLUP_ON_VBUS

2013-08-02 Thread Peter Chen
When the flag CI_HDRC_PULLUP_ON_VBUS is set, .pullup should only be called when the vbus is active. When the CI_HDRC_PULLUP_ON_VBUS is set, the controller only begins to run when the vbus is on, So, it is only meaningful software set pullup/pulldown after the controller begins to run. Tested-by: M

[PATCH 1/3] usb: chipidea: udc: fix the oops when plugs in usb cable after rmmod gadget

2013-08-02 Thread Peter Chen
When we rmmod gadget, the ci->driver needs to be cleared. Otherwise, we plug in usb cable again, the driver will consider gadget is there, in fact, it was removed. Besides, consolidate the calling of ci->driver->disconnect, when we do rmmod gadget, the gadget's disconnect should be called from udc

[PATCH 0/3] Misc Chipidea Patch

2013-08-02 Thread Peter Chen
This patchset is based on my vbus/id patchset Peter Chen (3): usb: chipidea: udc: fix the oops when plugs in usb cable after rmmod gadget usb: chipidea: move platform related things to ci_get_platdata usb: host: delete chipidea dependency drivers/usb/chipidea/core.c | 21 +---

[PATCH v3 2/2] usb: gadget: at91_udc: add usb_clk for transition to common clk framework

2013-08-02 Thread Boris BREZILLON
The AT91 PMC (Power Management Controller) provides an USB clock used by USB Full Speed host (ohci) and USB Full Speed device (udc). The usb drivers (ohci and udc) must configure this clock to 48Mhz. This configuration was formely done in mach-at91/clock.c, but this implementation will be removed w

[PATCH v3 1/2] usb: gadget: at91_udc: add missing clk_put on fclk and iclk

2013-08-02 Thread Boris BREZILLON
This patch adds missing clk_put on fclk and iclk in case the probe function fails after these clocks have been retrieved. Signed-off-by: Boris BREZILLON --- drivers/usb/gadget/at91_udc.c |4 1 file changed, 4 insertions(+) diff --git a/drivers/usb/gadget/at91_udc.c b/drivers/usb/gadget

[PATCH 3/3] usb: host: delete chipidea dependency

2013-08-02 Thread Peter Chen
Now, chipidea host has already depended on USB_EHCI_HCD Signed-off-by: Peter Chen --- drivers/usb/host/Kconfig |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig index cf521d6..b548554 100644 --- a/drivers/usb/host/Kcon

[PATCH 2/3] usb: chipidea: move platform related things to ci_get_platdata

2013-08-02 Thread Peter Chen
It will make probe cleaner, meanwhile, it fixes the problem http://marc.info/?l=linux-usb&m=137528143523296&w=2 described indirectly. Signed-off-by: Peter Chen --- drivers/usb/chipidea/core.c | 21 + 1 files changed, 9 insertions(+), 12 deletions(-) diff --git a/drivers/us

Re: question: do we have any UML like design diagram for usb core and driver model?

2013-08-02 Thread Chen Wang
Ok, I see. Maybe it's better to provide these diagrams in books for learners. Rajaram just recommended me one book and it looks good to me :). I have replied and looped the email in the mail-list. On Fri, 2013-08-02 at 10:53 +0800, Greg KH wrote: > On Fri, Aug 02, 2013 at 09:56:17AM +0800, Chen W

RE: About the hibernation feature implementation in dwc3 driver

2013-08-02 Thread Wang, Yu Y
Hi Balbi, Thanks the quick response. Actually, our solution is familiar with your thinking. Due to we have to do "Power-On or Soft Reset" for disconnect and re-connect case, so driver need re-initialized all hardware registers. That's why we want to separate register initialization operation fr

[PATCH v14 00/12] Add tested id switch and vbus connect detect support for Chipidea

2013-08-02 Thread Peter Chen
This patchset adds tested otg id switch function and vbus connect and disconnect detection for chipidea driver. And fix kinds of bugs found at chipidea drivers after enabling id and vbus detection. This patch are fully tested at imx6 sabresd and imx28evk platform by me. Besides, marek tested it o

Re: [PATCH 5/6] staging: ozwpan: Increase farewell report size.

2013-08-02 Thread Dan Carpenter
On Thu, Aug 01, 2013 at 06:45:01PM +0100, Rupesh Gujare wrote: > Farewell report size can be bigger than one byte, increase array > size to accomodate maximum 32 bytes of farewell report. > Gar... No. This is not right. 1) There is no check limiting the size to 32 and it could be up to 253

Re: [PATCH 5/5] usb: musb: dsps: use proper child nodes

2013-08-02 Thread Sebastian Andrzej Siewior
On 08/01/2013 01:30 PM, Sebastian Andrzej Siewior wrote: > On 08/01/2013 12:52 PM, Sebastian Andrzej Siewior wrote: >> On 08/01/2013 07:24 AM, George Cherian wrote: b/arch/arm/boot/dts/am33xx.dtsi index 38b446b..0f756ca 100644 --- a/arch/arm/boot/dts/am33xx.dtsi +++ b/arch/arm/b

Re: Kernel 3.10.3 "reset SuperSpeed USB device number 2 using xhci_hcd"

2013-08-02 Thread Peter Wu
On Sunday 28 July 2013 15:28:52 Alan Stern wrote: > On Sat, 27 Jul 2013, Stuart Foster wrote: > > On 07/27/13 20:34, Alan Stern wrote: > > > On Sat, 27 Jul 2013, Stuart Foster wrote: > > >> On 07/27/13 15:58, Alan Stern wrote: > > >>> On Sat, 27 Jul 2013, Stuart Foster wrote: > > Hi, > >

Re: About the hibernation feature implementation in dwc3 driver

2013-08-02 Thread Felipe Balbi
Hi, no top-posting please, limit your lines to 80-characters On Fri, Aug 02, 2013 at 09:25:39AM +, Wang, Yu Y wrote: > Thanks the quick response. > Actually, our solution is familiar with your thinking. > > Due to we have to do "Power-On or Soft Reset" for disconnect and > re-connect case, s

RE: About the hibernation feature implementation in dwc3 driver

2013-08-02 Thread Wang, Yu Y
Hi Balibi, Check my comments as follows. Thanks, Regards, Yu -Original Message- From: Felipe Balbi [mailto:ba...@ti.com] Sent: Friday, August 02, 2013 6:34 PM To: Wang, Yu Y Cc: ba...@ti.com; Li, Jiebing; Linux USB Mailing List; Zhuang, Jin Can; Wu, Hao; Yuan, Hang Subject: Re: About

Re: [PATCH 5/6] staging: ozwpan: Increase farewell report size.

2013-08-02 Thread Rupesh Gujare
On 02/08/13 11:27, Dan Carpenter wrote: On Thu, Aug 01, 2013 at 06:45:01PM +0100, Rupesh Gujare wrote: Farewell report size can be bigger than one byte, increase array size to accomodate maximum 32 bytes of farewell report. Gar... No. This is not right. 1) There is no check limiting the siz

[PATCH] staging: ozwpan: Fix farewell report.

2013-08-02 Thread Rupesh Gujare
This patch fixes issues reported by Dan here:- http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2013-August/040052.html Reported-by: Dan Carpenter Signed-off-by: Rupesh Gujare --- drivers/staging/ozwpan/ozpd.h|2 +- drivers/staging/ozwpan/ozproto.c |2 +- 2 files ch

Re: About the hibernation feature implementation in dwc3 driver

2013-08-02 Thread Felipe Balbi
Hi, On Fri, Aug 02, 2013 at 10:54:18AM +, Wang, Yu Y wrote: > Check my comments as follows. weird, you sent plain text email, but there are no quotation marks... it makes it very difficult to read. Please go through our netiquette, there is a copy of that at [1] and also lots of good informat

Re: [PATCH v2 1/2] ARM: DTS: tegra: Add USB entries for Tegra30

2013-08-02 Thread Thierry Reding
On Thu, Aug 01, 2013 at 06:39:10PM +0200, Stephen Warren wrote: > On 08/01/2013 09:00 AM, Tuomas Tynkkynen wrote: > > Add device tree entries for the 3 USB controllers and PHYs and > > enable the third controller on Cardhu and Beaver boards. > > > > Fix VBUS regulator entries on Beaver. The GPIO p

Re: NULL pointer dereference in xhci_free_dev

2013-08-02 Thread Heinz Diehl
On 26.07.2013, Sarah Sharp wrote: > Heinz and Frantisek, > I believe your issue should be fixed by this patch: > > http://marc.info/?l=linux-usb&m=137476546506888&w=2 > > Please let me know if it doesn't. Thanks a lot, it does fix it for me. Heinz -- To unsubscribe from this list: send the li

Re: Ejected Nook (usb mass storage) prevents suspend

2013-08-02 Thread Alan Stern
On Fri, 2 Aug 2013, Oliver Neukum wrote: > On Thu, 2013-08-01 at 11:53 -0400, Alan Stern wrote: > > On Thu, 1 Aug 2013, Oliver Neukum wrote: > > > > > On Wed, 2013-07-31 at 11:13 -0400, Alan Stern wrote: > > > > > > > More importantly, if we already know that the medium is not present or > > > >

Re: [PATCH 4/6] usb: phy: tegra: Program new PHY parameters

2013-08-02 Thread Tuomas Tynkkynen
On 08/02/2013 12:16 AM, Stephen Warren wrote: > On 07/31/2013 11:42 AM, Tuomas Tynkkynen wrote: >> The Tegra30 TRM recommends configuration of certain PHY parameters for >> optimal quality. Program the following registers based on device tree >> parameters: >> >> - UTMIP_XCVR_HSSLEW: HS slew rate c

Re: Ejected Nook (usb mass storage) prevents suspend

2013-08-02 Thread Oliver Neukum
On Fri, 2013-08-02 at 09:54 -0400, Alan Stern wrote: > On Fri, 2 Aug 2013, Oliver Neukum wrote: > > > On Thu, 2013-08-01 at 11:53 -0400, Alan Stern wrote: > > > On Thu, 1 Aug 2013, Oliver Neukum wrote: > > > > > > > On Wed, 2013-07-31 at 11:13 -0400, Alan Stern wrote: > > > > > > > > > More impo

Re: Audio I/O parameters

2013-08-02 Thread Alan Stern
Steve: Here's another irqsoff trace collected by James. It's not as extreme as before, but I don't know how to interpret the 875-us jump in the time value. Could this be a result of the timer being adjusted? Also, what's the explanation for these two lines: URL Clas-32862d... 881us : ji

Re: [PATCH 2/6] usb: phy: tegra: Fix wrong PHY parameters

2013-08-02 Thread Tuomas Tynkkynen
On 08/02/2013 12:09 AM, Stephen Warren wrote: > On 07/31/2013 11:41 AM, Tuomas Tynkkynen wrote: >> Some of the PHY parameters are not set according to the TRMs: >> >> - UTMIP_FS_PREABMLE_J should be set, not cleared >> - UTMIP_XCVR_LSBIAS_SEL should be cleared, not set >> - UTMIP_PD_CHRG should be

Re: Ejected Nook (usb mass storage) prevents suspend

2013-08-02 Thread Alan Stern
On Fri, 2 Aug 2013, Oliver Neukum wrote: > On Fri, 2013-08-02 at 09:54 -0400, Alan Stern wrote: > > On Fri, 2 Aug 2013, Oliver Neukum wrote: > > > > > On Thu, 2013-08-01 at 11:53 -0400, Alan Stern wrote: > > > > On Thu, 1 Aug 2013, Oliver Neukum wrote: > > > > > > > > > On Wed, 2013-07-31 at 11:

Re: Audio I/O parameters

2013-08-02 Thread Peter Zijlstra
On Fri, Aug 02, 2013 at 10:14:39AM -0400, Alan Stern wrote: > URL Clas-32862d.h.1us : local_clock <-perf_event_update_userpage > URL Clas-32862d.h.2us : watchdog_overflow_callback > <-__perf_event_overflow > URL Clas-32862d.h.3us : arch_trigger_all_cpu_backtrace_handler >

Re: [PATCH 5/5] usb: musb: dsps: use proper child nodes

2013-08-02 Thread George Cherian
On 8/2/2013 3:59 PM, Sebastian Andrzej Siewior wrote: On 08/01/2013 01:30 PM, Sebastian Andrzej Siewior wrote: On 08/01/2013 12:52 PM, Sebastian Andrzej Siewior wrote: On 08/01/2013 07:24 AM, George Cherian wrote: b/arch/arm/boot/dts/am33xx.dtsi index 38b446b..0f756ca 100644 --- a/arch/arm/boo

Re: [RFC] usb: gadget: start to drop endpoint naming conventions

2013-08-02 Thread Michal Nazarewicz
On Thu, Aug 01 2013, Felipe Balbi wrote: > Hi folks, > > as we all know naming conventions are fragile and easy to break. We've > had weird endpoint naming conventions for far too long in the gadget > framework. > > I'm trying to come up with means to get rid of that and, one of the > ideas, was to

RE: About the hibernation feature implementation in dwc3 driver

2013-08-02 Thread Wang, Yu Y
> Hi, > > On Fri, Aug 02, 2013 at 10:54:18AM +, Wang, Yu Y wrote: > > Check my comments as follows. > > weird, you sent plain text email, but there are no quotation marks... it > makes it > very difficult to read. Please go through our netiquette, there is a copy of > that > at [1] and also

Re: [PATCH 1/6] usb: host: add has_tdi_phy_lpm capability bit

2013-08-02 Thread Tuomas Tynkkynen
On 08/01/2013 11:05 AM, Matthieu CASTET wrote: > Hi, > > Le Wed, 31 Jul 2013 18:41:57 +0100, > Tuomas Tynkkynen a écrit : > >> The has_hostpc capability bit indicates that the host controller has >> the HOSTPC register extensions, but at the same time enables clock >> disabling power saving feat

Re: Audio I/O parameters

2013-08-02 Thread Steven Rostedt
On Fri, 2013-08-02 at 16:36 +0200, Peter Zijlstra wrote: > On Fri, Aug 02, 2013 at 10:14:39AM -0400, Alan Stern wrote: > > URL Clas-32862d.h.1us : local_clock <-perf_event_update_userpage > > URL Clas-32862d.h.2us : watchdog_overflow_callback > > <-__perf_event_overflow > > URL Cla

Re: Audio I/O parameters

2013-08-02 Thread Alan Stern
On Fri, 2 Aug 2013, Steven Rostedt wrote: > On Fri, 2013-08-02 at 16:36 +0200, Peter Zijlstra wrote: > > On Fri, Aug 02, 2013 at 10:14:39AM -0400, Alan Stern wrote: > > > URL Clas-32862d.h.1us : local_clock <-perf_event_update_userpage > > > URL Clas-32862d.h.2us : watchdog_overflo

[PATCH] usb: fix some scripts/kernel-doc warnings

2013-08-02 Thread Yacine Belkadi
When building the htmldocs (in verbose mode), scripts/kernel-doc reports the following type of warnings: Warning(drivers/usb/core/usb.c:76): No description found for return value of 'usb_find_alt_setting' Fix them by: - adding some missing descriptions of return values - using "Return" sections f

Re: Audio I/O parameters

2013-08-02 Thread Steven Rostedt
On Fri, 2013-08-02 at 13:59 -0400, Alan Stern wrote: > On Fri, 2 Aug 2013, Steven Rostedt wrote: > > > On Fri, 2013-08-02 at 16:36 +0200, Peter Zijlstra wrote: > > > On Fri, Aug 02, 2013 at 10:14:39AM -0400, Alan Stern wrote: > > > > URL Clas-32862d.h.1us : local_clock <-perf_event_update_

Re: Audio I/O parameters

2013-08-02 Thread Alan Stern
On Fri, 2 Aug 2013, Steven Rostedt wrote: > On Fri, 2013-08-02 at 13:59 -0400, Alan Stern wrote: > > On Fri, 2 Aug 2013, Steven Rostedt wrote: > > > > > On Fri, 2013-08-02 at 16:36 +0200, Peter Zijlstra wrote: > > > > On Fri, Aug 02, 2013 at 10:14:39AM -0400, Alan Stern wrote: > > > > > URL Clas-

Re: Audio I/O parameters

2013-08-02 Thread Steven Rostedt
On Fri, 2013-08-02 at 14:41 -0400, Alan Stern wrote: > Steve: > > Here's another irqsoff trace collected by James. It's not as extreme > as before, but I don't know how to interpret the 875-us jump in the > time value. Could this be a result of the timer being adjusted? > > Also, what's the e

Re: Audio I/O parameters

2013-08-02 Thread Steven Rostedt
On Fri, 2013-08-02 at 14:57 -0400, Steven Rostedt wrote: > The tracer started within the NMI, but out of sheer (bad) luck. That's > because the NMI code has no logic to handle tracing interrupts on or > off, due to the problems they cause. We may at most be able to just > ignore all NMIs by adding

Re: Audio I/O parameters

2013-08-02 Thread James Stone
On Fri, Aug 2, 2013 at 8:49 AM, James Stone wrote: > On Thu, Aug 1, 2013 at 5:43 PM, Alan Stern wrote: >> On Thu, 1 Aug 2013, James Stone wrote: >> >>> > SMIs are controlled by the BIOS, not by the kernel. I don't think >>> > changing the kernel would affect their timings. >>> > >>> >>> Hmm.. ok

Re: Audio I/O parameters

2013-08-02 Thread James Stone
On Fri, Aug 2, 2013 at 8:02 PM, James Stone wrote: > On Fri, Aug 2, 2013 at 8:49 AM, James Stone wrote: >> On Thu, Aug 1, 2013 at 5:43 PM, Alan Stern wrote: >>> On Thu, 1 Aug 2013, James Stone wrote: >>> > SMIs are controlled by the BIOS, not by the kernel. I don't think > changing th

Re: Audio I/O parameters

2013-08-02 Thread Peter Zijlstra
On Fri, Aug 02, 2013 at 02:57:26PM -0400, Steven Rostedt wrote: > The other thing you can do is not run perf while this is going on. URL Clas-32862d.h.1us : local_clock <-perf_event_update_userpage URL Clas-32862d.h.2us : watchdog_overflow_callback <-__perf_event_overflow URL Clas

[PATCH 2/5] usb: phy: Add AM335x PHY driver

2013-08-02 Thread Sebastian Andrzej Siewior
This driver is a redo of my earlier attempt. It uses parts of the generic PHY driver and uses the new control driver for the register the phy needs to power on/off the phy. It also enables easy access for the wakeup register which is not yet implemented. The difference between the omap attempt is:

[PATCH 5/5] usb/musb dma: add cppi41 dma driver

2013-08-02 Thread Sebastian Andrzej Siewior
This driver is currently used by musb' cppi41 couter part. I may merge both dma engine user of musb at some point but not just yet. The driver seems to work in RX/TX mode in host mode, tested on mass storage. I increaed the size of the TX / RX transfers and waited for the core code to cancel a tra

[PATCH 3/5] usb: musb: dsps: remove the hardcoded phy pieces

2013-08-02 Thread Sebastian Andrzej Siewior
dsps uses a nop driver which is added in dsps itself and does the PHY on/off calls within dsps. Since those calls are now moved the nop driver itself, we can now request the phy proper phy and remove those calls. Currently only the first musb interface is used so we only add one phy node for now.

[PATCH 4/5] usb: musb: dsps: use proper child nodes

2013-08-02 Thread Sebastian Andrzej Siewior
This moves the two instances from the big node into two child nodes. The glue layer ontop does almost nothing. There is one devices containing the control module for USB (2) phy, (2) usb and later the dma engine. The usb device is the "glue device" which contains the musb device as a child. This is

[PATCH 1/5] usb: phy: phy-generic: export init functions

2013-08-02 Thread Sebastian Andrzej Siewior
This patch exports the mostly generic functions so they can be used from other phy driver instead of duplicating the code. Signed-off-by: Sebastian Andrzej Siewior --- drivers/usb/phy/phy-generic.c | 130 -- drivers/usb/phy/phy-generic.h | 20 +++ 2 f

am335x: support for multiple USB instances, v3

2013-08-02 Thread Sebastian Andrzej Siewior
Hi, this series depends on Felipe's master tree and "usb: phy: rename nop_usb_xceiv => usb_phy_gen_xceiv" which I posted earlier. I created a -rc3 based branch for that patch [0]. If you fine with this please let Tony know. I updated the child nodes & the phy generic to use two small memory spaces

Re: [PATCH V3 0/3] networking: Use ETH_ALEN where appropriate

2013-08-02 Thread David Miller
From: Joe Perches Date: Thu, 1 Aug 2013 16:17:46 -0700 > Convert the uses mac addresses to ETH_ALEN so > it's easier to find and verify where mac addresses > need to be __aligned(2) Series applied to net-next, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in th

Re: Audio I/O parameters

2013-08-02 Thread Alan Stern
On Fri, 2 Aug 2013, James Stone wrote: > > Okay, so the USB controllers do share IRQ lines. Were you using the > > other USB buses when the errors occurred? > > Webcam microphone might have been on. > >>> > >>> You should try testing with no other USB activity going on. Just

Re: Audio I/O parameters

2013-08-02 Thread James Stone
On Fri, Aug 2, 2013 at 8:40 PM, Alan Stern wrote: > On Fri, 2 Aug 2013, James Stone wrote: > >> > Okay, so the USB controllers do share IRQ lines. Were you using the >> > other USB buses when the errors occurred? >> >> Webcam microphone might have been on. >> >>> >> >>> You sh

Re: About the hibernation feature implementation in dwc3 driver

2013-08-02 Thread Felipe Balbi
Hi, On Fri, Aug 02, 2013 at 03:42:20PM +, Wang, Yu Y wrote: > > Hi, > > > > On Fri, Aug 02, 2013 at 10:54:18AM +, Wang, Yu Y wrote: > > > Check my comments as follows. > > > > weird, you sent plain text email, but there are no quotation marks... it > > makes it > > very difficult to rea

[RFC option 2] usb: rh_call_control tbuf overflow fix

2013-08-02 Thread Sean O. Stalley
This patch modifies the buffer tbuf in the rh_call_control() function to allow for larger USB descriptors to be passed. rh_call_control() contains a buffer, tbuf, which it uses to hold USB descriptors. These discriptors are eventually copied into the transfer_buffer in the URB. The buffer in the U

[RFC] usb: rh_call_control tbuf overflow fix

2013-08-02 Thread Sean O. Stalley
rh_call_control() contains a buffer, tbuf, which it uses to hold USB descriptors. These discriptors are eventually copied into the transfer_buffer in the URB. The buffer in the URB is dynamically defined and is always large enough to hold the amount of data it requests. tbuf, however, is statical

[RFC option 1] usb: rh_call_control tbuf overflow fix

2013-08-02 Thread Sean O. Stalley
This patch modifies the buffer tbuf in the rh_call_control() function to allow for larger USB descriptors to be passed. rh_call_control() contains a buffer, tbuf, which it uses to hold USB descriptors. These discriptors are eventually copied into the transfer_buffer in the URB. The buffer in the U

Re: [RFC] usb: rh_call_control tbuf overflow fix

2013-08-02 Thread Alan Stern
On Fri, 2 Aug 2013, Sean O. Stalley wrote: > rh_call_control() contains a buffer, tbuf, which it uses to hold > USB descriptors. These discriptors are eventually copied into the > transfer_buffer in the URB. The buffer in the URB is dynamically > defined and is always large enough to hold the amo

Re: [PATCH v3 2/8] clk: samsung: pll: Add support for PLL6552 and PLL6553

2013-08-02 Thread Mike Turquette
Quoting Tomasz Figa (2013-07-28 05:38:25) > On Sunday 28 of July 2013 13:30:51 Mark Brown wrote: > > On Wed, Jul 24, 2013 at 01:52:19AM +0200, Tomasz Figa wrote: > > > Changes since v2: > > > - Reworked to use new PLL registration method introduced by Yadwinder > > > > > >Singh Brar's patch

[PATCH v1 0/4] USB & USBNET: loose SG check and support usbnet DMA SG

2013-08-02 Thread Ming Lei
Hi, This patchset allows drivers to pass sg buffers which size can't be divided by max packet size of endpoint if the host controllers(such ax xHCI) support this kind of sg buffers. Previously we added check[1] on the situation and don't allow these sg buffers passed to USB HCD, looks the check i

[PATCH v1 1/4] USB: introduce usb_device_no_sg_limit() helper

2013-08-02 Thread Ming Lei
Some host controllers(such as xHCI) can support building packet from discontinuous buffers, so introduce one flag and helper for this kind of host controllers, then the feature can help some applications(such as, usbnet) by supporting arbitrary length of sg buffers. Cc: Alan Stern Signed-off-by:

[PATCH v1 4/4] USBNET: ax88179_178a: enable tso if usb host supports sg dma

2013-08-02 Thread Ming Lei
From: Ming Lei This patch enables 'can_dma_sg' flag for ax88179_178a device if the attached host controller supports building packet from discontinuous buffers(DMA SG is possible), so TSO can be enabled and skb fragment buffers can be passed to usb stack via urb->sg directly. With the patch, sys

[PATCH v1 2/4] USB: XHCI: mark no_sg_limit

2013-08-02 Thread Ming Lei
This patch marks all xHCI controllers as no_sg_limit since xHCI supports building packet from discontinuous buffers. Cc: Alan Stern Acked-by: Sarah Sharp Signed-off-by: Ming Lei --- drivers/usb/host/xhci.c |4 1 file changed, 4 insertions(+) diff --git a/drivers/usb/host/xhci.c b/dri

[PATCH v1 3/4] USBNET: support DMA SG

2013-08-02 Thread Ming Lei
This patch introduces support of DMA SG if the USB host controller which usbnet device is attached to is capable of building packet from discontinuous buffers. The patch supports passing the skb fragment buffers to usb stack directly via urb->sg. Cc: Eric Dumazet Cc: Ben Hutchings Cc: Grant Gru

Re: [PATCH] staging: ozwpan: Fix farewell report.

2013-08-02 Thread Greg KH
On Fri, Aug 02, 2013 at 12:04:16PM +0100, Rupesh Gujare wrote: > This patch fixes issues reported by Dan here:- > http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2013-August/040052.html Please list the issues in the patch changelog itself, as sometimes you don't have web access,

Re: [PATCH] usb: fix some scripts/kernel-doc warnings

2013-08-02 Thread Greg Kroah-Hartman
On Fri, Aug 02, 2013 at 08:10:04PM +0200, Yacine Belkadi wrote: > When building the htmldocs (in verbose mode), scripts/kernel-doc reports the > following type of warnings: > > Warning(drivers/usb/core/usb.c:76): No description found for return value of > 'usb_find_alt_setting' > > Fix them by: >

Re: [PATCH v1 3/4] USBNET: support DMA SG

2013-08-02 Thread Oliver Neukum
On Sat, 2013-08-03 at 10:46 +0800, Ming Lei wrote: > @@ -1268,10 +1298,14 @@ netdev_tx_t usbnet_start_xmit (struct sk_buff *skb, > entry = (struct skb_data *) skb->cb; > entry->urb = urb; > entry->dev = dev; > - entry->length = length; > > usb_fill_bulk_urb (urb, dev-