Re: How should we handle isochronous underruns?

2013-07-21 Thread Ming Lei
On Sun, Jul 21, 2013 at 2:00 AM, Alan Stern wrote: > On Sat, 20 Jul 2013, Ming Lei wrote: > >> > No, we don't have to change every driver using isochronous URBs. Many >> > of them set URB_ISO_ASAP on every URB -- in fact, AFAIK snd-usb-audio >> > is the only one that has been fixed not to do this

Re: [PATCH][usbutils] lsusb: port to hwdb

2013-07-21 Thread Tom Gundersen
On Sun, Jul 21, 2013 at 3:34 AM, Greg KH wrote: > Can this mean I can drop the usb.ids file from the usbutils package? I > can't remember where hwdb is generated from, does it rely on the usb.ids > file for the initial creation? hwdb does not use the usb.ids from the usbutils package. However,

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-21 Thread Sascha Hauer
On Sat, Jul 20, 2013 at 07:59:10PM -0700, Greg KH wrote: > On Sat, Jul 20, 2013 at 10:32:26PM -0400, Alan Stern wrote: > > On Sat, 20 Jul 2013, Greg KH wrote: > > > > > > >>That should be passed using platform data. > > > > > > > > > >Ick, don't pass strings around, pass pointers. If you have pla

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-21 Thread Tomasz Figa
Hi, On Saturday 20 of July 2013 19:59:10 Greg KH wrote: > On Sat, Jul 20, 2013 at 10:32:26PM -0400, Alan Stern wrote: > > On Sat, 20 Jul 2013, Greg KH wrote: > > > > >>That should be passed using platform data. > > > > > > > > > >Ick, don't pass strings around, pass pointers. If you have > > > >

Re: [PATCH][usbutils] lsusb: port to hwdb

2013-07-21 Thread Kay Sievers
On Sun, Jul 21, 2013 at 12:01 PM, Tom Gundersen wrote: > On Sun, Jul 21, 2013 at 3:34 AM, Greg KH wrote: >> Can this mean I can drop the usb.ids file from the usbutils package? I >> can't remember where hwdb is generated from, does it rely on the usb.ids >> file for the initial creation? > > hwd

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-21 Thread Kishon Vijay Abraham I
Hi, On Sunday 21 July 2013 04:01 PM, Tomasz Figa wrote: Hi, On Saturday 20 of July 2013 19:59:10 Greg KH wrote: On Sat, Jul 20, 2013 at 10:32:26PM -0400, Alan Stern wrote: On Sat, 20 Jul 2013, Greg KH wrote: That should be passed using platform data. Ick, don't pass strings around, pass po

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-21 Thread Tomasz Figa
On Sunday 21 of July 2013 16:37:33 Kishon Vijay Abraham I wrote: > Hi, > > On Sunday 21 July 2013 04:01 PM, Tomasz Figa wrote: > > Hi, > > > > On Saturday 20 of July 2013 19:59:10 Greg KH wrote: > >> On Sat, Jul 20, 2013 at 10:32:26PM -0400, Alan Stern wrote: > >>> On Sat, 20 Jul 2013, Greg KH wr

[PATCH] xhci: fix null pointer dereference on ring_doorbell_for_active_rings

2013-07-21 Thread Oleksij Rempel
in some cases where device is attched to xhci port and do not responding, for example ath9k_htc with stalled firmware, kernel will crash on ring_doorbell_for_active_rings. This patch check if pointer exist before it is used. Signed-off-by: Oleksij Rempel --- drivers/usb/host/xhci-ring.c | 2 +-

Re: How should we handle isochronous underruns?

2013-07-21 Thread Alan Stern
On Sun, 21 Jul 2013, Ming Lei wrote: > On Sun, Jul 21, 2013 at 2:00 AM, Alan Stern wrote: > > On Sat, 20 Jul 2013, Ming Lei wrote: > > > >> > No, we don't have to change every driver using isochronous URBs. Many > >> > of them set URB_ISO_ASAP on every URB -- in fact, AFAIK snd-usb-audio > >> >

Re: [PATCH][usbutils] lsusb: port to hwdb

2013-07-21 Thread Greg KH
On Sun, Jul 21, 2013 at 12:01:11PM +0200, Tom Gundersen wrote: > On Sun, Jul 21, 2013 at 3:34 AM, Greg KH wrote: > > Can this mean I can drop the usb.ids file from the usbutils package? I > > can't remember where hwdb is generated from, does it rely on the usb.ids > > file for the initial creatio

Re: [PATCH][usbutils] lsusb: port to hwdb

2013-07-21 Thread Greg KH
On Sun, Jul 21, 2013 at 01:05:31PM +0200, Kay Sievers wrote: > > However, hwdb only contains vendor, product, class, subclass and > > protocol. So if you drop usb.ids the rest of the information will be > > lost. > > > > Maybe split the rest out into a separate file and ship only that? > > > > Or i

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-21 Thread Greg KH
On Sun, Jul 21, 2013 at 01:12:07PM +0200, Tomasz Figa wrote: > On Sunday 21 of July 2013 16:37:33 Kishon Vijay Abraham I wrote: > > Hi, > > > > On Sunday 21 July 2013 04:01 PM, Tomasz Figa wrote: > > > Hi, > > > > > > On Saturday 20 of July 2013 19:59:10 Greg KH wrote: > > >> On Sat, Jul 20, 2013

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-21 Thread Greg KH
On Sun, Jul 21, 2013 at 12:22:48PM +0200, Sascha Hauer wrote: > On Sat, Jul 20, 2013 at 07:59:10PM -0700, Greg KH wrote: > > On Sat, Jul 20, 2013 at 10:32:26PM -0400, Alan Stern wrote: > > > On Sat, 20 Jul 2013, Greg KH wrote: > > > > > > > > >>That should be passed using platform data. > > > > >

Re: [PATCH][usbutils] lsusb: port to hwdb

2013-07-21 Thread Kay Sievers
On Sun, Jul 21, 2013 at 5:36 PM, Greg KH wrote: > On Sun, Jul 21, 2013 at 01:05:31PM +0200, Kay Sievers wrote: >> > However, hwdb only contains vendor, product, class, subclass and >> > protocol. So if you drop usb.ids the rest of the information will be >> > lost. >> > >> > Maybe split the rest o

Re: [PATCH][usbutils] lsusb: port to hwdb

2013-07-21 Thread Greg KH
On Sun, Jul 21, 2013 at 05:49:05PM +0200, Kay Sievers wrote: > On Sun, Jul 21, 2013 at 5:36 PM, Greg KH wrote: > > On Sun, Jul 21, 2013 at 01:05:31PM +0200, Kay Sievers wrote: > >> > However, hwdb only contains vendor, product, class, subclass and > >> > protocol. So if you drop usb.ids the rest o

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-21 Thread Sylwester Nawrocki
On 07/21/2013 05:48 PM, Greg KH wrote: On Sun, Jul 21, 2013 at 12:22:48PM +0200, Sascha Hauer wrote: On Sat, Jul 20, 2013 at 07:59:10PM -0700, Greg KH wrote: On Sat, Jul 20, 2013 at 10:32:26PM -0400, Alan Stern wrote: On Sat, 20 Jul 2013, Greg KH wrote: That should be passed using platform d

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-21 Thread Alan Stern
On Sun, 21 Jul 2013, Sylwester Nawrocki wrote: > > What's wrong with the platform_data structure, why can't that be used > > for this? > > At the point the platform data of some driver is initialized, e.g. in > board setup code the PHY pointer is not known, since the PHY supplier > driver has not

Re: [PROBLEM/BUG] mouse polling at only half rate on ohci_hcd

2013-07-21 Thread sgtcapslock
I took Alan's excellent advice and read a good bit of that book last night. Definitely some good authors there! After pondering Alan's diagnosis for a bit, I went to inspect the usbhid driver code, and wound up creating a patch which works! I've tested three different gaming mice, and they now a

Re: [PROBLEM/BUG] mouse polling at only half rate on ohci_hcd

2013-07-21 Thread Greg KH
On Sun, Jul 21, 2013 at 02:59:41PM -0500, sgtcapslock wrote: > I took Alan's excellent advice and read a good bit of that book last > night. Definitely some good authors there! > > After pondering Alan's diagnosis for a bit, I went to inspect the usbhid > driver code, and wound up creating a patc

kernel panic in sg_complete

2013-07-21 Thread Marcin Ślusarz
Hi Few days ago I fried (?) my SD card (with custom Arduino-based hw :) and now every time I insert it into my Linux laptop, after ~10 seconds, kernel panics: [ 258.288466] BUG: unable to handle kernel NULL pointer dereference at 0040 [ 258.289742] IP: [] sg_complete+0xb9/0x1d0 [ 2

Re: kernel panic in sg_complete

2013-07-21 Thread Greg Kroah-Hartman
On Mon, Jul 22, 2013 at 01:00:41AM +0200, Marcin Ślusarz wrote: > If you want me to test some patches, just shout ;) Interesting patch, it makes sense to have this applied. Can you resend it with a "Signed-off-by:" line so that I can add it to the tree? thanks, greg k-h -- To unsubscribe from t

Re: [PATCH v12 00/13] Add tested id switch and vbus connect detect support for Chipidea

2013-07-21 Thread Marek Vasut
Hi Peter, > On Fri, Jul 12, 2013 at 03:18:31PM +0200, Marek Vasut wrote: > > Hi Peter, > > > > > On Fri, Jul 12, 2013 at 06:04:43AM +0200, Marek Vasut wrote: > > > > Hi Peter, > > > > > > > > > On Thu, Jul 11, 2013 at 07:57:19PM +0200, Marek Vasut wrote: > > > > > > Hi Peter, > > > > > > > > >

Re: [PATCH v12 00/13] Add tested id switch and vbus connect detect support for Chipidea

2013-07-21 Thread Peter Chen
On Mon, Jul 22, 2013 at 03:15:28AM +0200, Marek Vasut wrote: > Hi Peter, > > > On Fri, Jul 12, 2013 at 03:18:31PM +0200, Marek Vasut wrote: > > > Hi Peter, > > > > > > > On Fri, Jul 12, 2013 at 06:04:43AM +0200, Marek Vasut wrote: > > > > > Hi Peter, > > > > > > > > > > > On Thu, Jul 11, 2013 at

Re: [PATCH v12 00/13] Add tested id switch and vbus connect detect support for Chipidea

2013-07-21 Thread Marek Vasut
Dear Peter Chen, > On Mon, Jul 22, 2013 at 03:15:28AM +0200, Marek Vasut wrote: > > Hi Peter, > > > > > On Fri, Jul 12, 2013 at 03:18:31PM +0200, Marek Vasut wrote: > > > > Hi Peter, > > > > > > > > > On Fri, Jul 12, 2013 at 06:04:43AM +0200, Marek Vasut wrote: > > > > > > Hi Peter, > > > > > >

Re: [PATCH v12 00/13] Add tested id switch and vbus connect detect support for Chipidea

2013-07-21 Thread Peter Chen
On Mon, Jul 22, 2013 at 03:40:32AM +0200, Marek Vasut wrote: > Dear Peter Chen, > > > On Mon, Jul 22, 2013 at 03:15:28AM +0200, Marek Vasut wrote: > > > Hi Peter, > > > > > > > On Fri, Jul 12, 2013 at 03:18:31PM +0200, Marek Vasut wrote: > > > > > Hi Peter, > > > > > > > > > > > On Fri, Jul 12,

Re: kernel panic in sg_complete

2013-07-21 Thread Alan Stern
On Sun, 21 Jul 2013, Greg Kroah-Hartman wrote: > On Mon, Jul 22, 2013 at 01:00:41AM +0200, Marcin Ślusarz wrote: > > If you want me to test some patches, just shout ;) > > Interesting patch, it makes sense to have this applied. Can you resend > it with a "Signed-off-by:" line so that I can add i

Re: [PATCH v2 3/4] arm: dts: Add USB phy nodes for AM33XX

2013-07-21 Thread George Cherian
On 7/20/2013 9:11 AM, George Cherian wrote: On 7/20/2013 12:12 AM, Sebastian Andrzej Siewior wrote: On 07/19/2013 08:33 PM, Sergei Shtylyov wrote: Hello. Hello, usb: usb@4740 { compatible = "ti,am33xx-usb"; usb0_phy: phy@47401300 { compatible = "ti,am335x-usb-phy"