Re: linux-next: Tree for Jun 18 usb/chipidea)

2013-06-18 Thread Felipe Balbi
Hi, On Tue, Jun 18, 2013 at 11:52:36AM -0700, Randy Dunlap wrote: > On 06/18/13 00:30, Stephen Rothwell wrote: > > Hi all, > > > > Changes since 20130617: > > > > > on i386: > > # CONFIG_USB_PHY is not set > > drivers/built-in.o: In function `ci_hdrc_probe': > core.c:(.text+0x20446b): undefi

[PATCH] xhci: Compute last_ctx from complete set of configured endpoints.

2013-06-18 Thread Reilly Grant
The context entries field of the slot context must be set to one more than the highest endpoint index currently active. The previous logic only included the set of endpoints currently being added, meaning that if an endpoint where dropped then the field would be reset to 1, deactivating all configu

Re: [PATCH v7 1/9] drivers: phy: add generic PHY framework

2013-06-18 Thread Sylwester Nawrocki
Hi Kishon, I've noticed there is a little inconsistency between the code and documentation. On 06/13/2013 10:43 AM, Kishon Vijay Abraham I wrote: +3. Creating the PHY + +The PHY driver should create the PHY in order for other peripheral controllers +to make use of it. The PHY framework provid

[Bug] USB 2.0 Ports Dont Work on Sony Vaio Laptop

2013-06-18 Thread Ming Lei
Hi, Recently, there is one bug report from Ubuntu community: USB 2.0 Ports Dont Work on Sony Vaio Laptop and the problem exists on upstream kernel too. The built-in two USB 2.0 devices can be recognized correctly, but external devices can't be recognized when the device is connected to USB

Re: linux-next: Tree for Jun 18 usb/chipidea)

2013-06-18 Thread Peter Chen
On Wed, Jun 19, 2013 at 4:12 AM, Felipe Balbi wrote: > Hi, > > On Tue, Jun 18, 2013 at 11:52:36AM -0700, Randy Dunlap wrote: >> On 06/18/13 00:30, Stephen Rothwell wrote: >> > Hi all, >> > >> > Changes since 20130617: >> > >> >> >> on i386: >> >> # CONFIG_USB_PHY is not set >> >> drivers/built-in.

[PATCH 1/1] usb: fix build error without CONFIG_USB_PHY

2013-06-18 Thread Peter Chen
on i386: drivers/built-in.o: In function `ci_hdrc_probe': core.c:(.text+0x20446b): undefined reference to `of_usb_get_phy_mode' Signed-off-by: Peter Chen --- include/linux/usb/of.h | 14 +- 1 files changed, 9 insertions(+), 5 deletions(-) diff --git a/include/linux/usb/of.h b/inc

[PATCH V2] USB: initialize or shutdown PHY when add or remove host controller

2013-06-18 Thread Chao Xie
Some controller need software to initialize PHY before add host controller, and shut down PHY after remove host controller. Add the generic code for these controllers so they do not need do it in its own host controller driver. Signed-off-by: Chao Xie --- drivers/usb/core/hcd.c | 24 ++

Re: [PATCH V2] USB: initialize or shutdown PHY when add or remove host controller

2013-06-18 Thread Greg KH
On Tue, Jun 18, 2013 at 10:31:20PM -0400, Chao Xie wrote: > Some controller need software to initialize PHY before add > host controller, and shut down PHY after remove host controller. > Add the generic code for these controllers so they do not need > do it in its own host controller driver. Why?

Re: [RFC PATCH v1 1/6] USB: HCD: support giveback of URB in tasklet context

2013-06-18 Thread Ming Lei
On Wed, Jun 19, 2013 at 12:05 AM, Alan Stern wrote: > On Tue, 18 Jun 2013, Ming Lei wrote: > >> This patch implements the mechanism of giveback of URB in >> tasklet context, so that hardware interrupt handling time for >> usb host controller can be saved much, and HCD interrupt handling >> can be

Re: [RFC PATCH v1 2/6] USB: disable IRQs deliberately when calling complete()

2013-06-18 Thread Ming Lei
On Wed, Jun 19, 2013 at 12:36 AM, Alan Stern wrote: > On Tue, 18 Jun 2013, Ming Lei wrote: > >> We disable local IRQs here in case of running complete() by >> tasklet to avoid possible deadlock because drivers may call >> spin_lock() to hold lock which might be acquired in one hard >> interrupt ha

Re: [RFC PATCH v1 3/6] USB: URB documentation: claim complete() may be run with IRQs enabled

2013-06-18 Thread Ming Lei
On Wed, Jun 19, 2013 at 12:42 AM, Alan Stern wrote: > On Tue, 18 Jun 2013, Ming Lei wrote: > >> There is no good reason to run complete() in hard interrupt >> disabled context. >> >> After running complete() in tasklet, we will enable local IRQs >> when calling complete() since we can do it now. >

Re: [RFC PATCH v1 4/6] USB: EHCI: don't release ehci->lock if URB giveback in tasklet context

2013-06-18 Thread Ming Lei
On Wed, Jun 19, 2013 at 12:43 AM, Alan Stern wrote: > On Tue, 18 Jun 2013, Ming Lei wrote: > >> If HCD_BH is set for HC driver's flags, URB giveback will be >> done in tasklet context instead of interrupt context, so the >> ehci->lock needn't to be released any more before calling >> usb_hcd_giveb

Re: [PATCH V2] USB: initialize or shutdown PHY when add or remove host controller

2013-06-18 Thread Chao Xie
On Wed, Jun 19, 2013 at 10:48 AM, Greg KH wrote: > On Tue, Jun 18, 2013 at 10:31:20PM -0400, Chao Xie wrote: >> Some controller need software to initialize PHY before add >> host controller, and shut down PHY after remove host controller. >> Add the generic code for these controllers so they do no

Re: [RFC PATCH v1 5/6] USB: EHCI: improve interrupt qh unlink

2013-06-18 Thread Ming Lei
On Wed, Jun 19, 2013 at 12:51 AM, Alan Stern wrote: > On Tue, 18 Jun 2013, Ming Lei wrote: > >> Given interrupt URB will be resubmitted from tasklet context which >> is scheduled by ehci hardware interrupt handler, and commonly only >> one interrupt URB is scheduled on qh, so the qh may be unlinke

Re: [RFC PATCH v1 6/6] USB: EHCI: support running URB giveback in tasklet context

2013-06-18 Thread Ming Lei
On Wed, Jun 19, 2013 at 12:55 AM, Alan Stern wrote: > On Tue, 18 Jun 2013, Ming Lei wrote: > >> Both 4 transfers can work well on EHCI HCD after switching to run > > "Both 4 transfers"? The word "both" applies when there are two items, > not more than two. And what are the four transfers you are

Re: [PATCH 1/1] usb: fix build error without CONFIG_USB_PHY

2013-06-18 Thread Felipe Balbi
On Wed, Jun 19, 2013 at 10:11:05AM +0800, Peter Chen wrote: > on i386: > > drivers/built-in.o: In function `ci_hdrc_probe': > core.c:(.text+0x20446b): undefined reference to `of_usb_get_phy_mode' > > Signed-off-by: Peter Chen > --- > include/linux/usb/of.h | 14 +- > 1 files chang

Re: [PATCH] build some drivers only when compile-testing

2013-06-18 Thread Jiri Slaby
On 06/18/2013 06:04 PM, Greg Kroah-Hartman wrote: >> So currently I have what is attached... Comments? > > Looks good to me, want me to queue it up through my char/misc driver > tree for 3.11? If there are no objections... Whoever picks that up, I would be happy 8-). -- js suse labs -- To unsub

<    1   2