Re: Linux USB file storage gadget with new UDC

2013-06-17 Thread victor yeo
Hi, >> I did another usbmon capture from the moment usb cable is plugged into >> the Ubuntu x100e laptop. This time the usbmon does not have -75 error. >> When the SCSI_READ_10 command request for 4096 bytes of data, and the >> data is returned by the gadget, usbmon simply shows -108 error. The >>

Re: [GIT PULL] USB patches for v3.11 merge window

2013-06-17 Thread Roger Quadros
On 06/14/2013 10:15 PM, Felipe Balbi wrote: > Hi, > > On Fri, Jun 14, 2013 at 11:28:51AM +0300, Roger Quadros wrote: >> On 06/13/2013 05:55 PM, Felipe Balbi wrote: >>> HI, >>> >>> On Thu, Jun 13, 2013 at 05:53:50PM +0300, Roger Quadros wrote: On 06/13/2013 05:17 PM, Felipe Balbi wrote: >

Re: [PATCh V10 04/12] usb: ehci: ehci-mv: use PHY driver for ehci

2013-06-17 Thread Roger Quadros
On 06/14/2013 11:01 PM, Alan Stern wrote: > On Fri, 14 Jun 2013, Roger Quadros wrote: > hi The following is my understanding. I think for PHY initialization and shutdown part, it is generic for other parts. PHY initialization need to be called before hc_driver->reset is ca

Re: [PATCH V2 01/10] USB: OHCI: Properly handle ohci-at91 suspend

2013-06-17 Thread Viresh Kumar
On 17 June 2013 14:52, Manjunath Goudar wrote: > when we are using tab characters before "do_wakeup" and "ret" variable,we > will be getting error below. > > WARNING: please, no space before tabs > #31: FILE: drivers/usb/host/ohci-at91.c:622: > +^Ibool ^I^Ido_wakeup = device_may_wakeup(&pdev->dev

staging mailing list dead ?

2013-06-17 Thread Rupesh Gujare
Hi All, First of all I am sorry to bother all of you, as this might not be the right place to ask this question. But since last few days, I am not able to reach staging mailing list (1), neither I am receiving emails from staging mailing list. As well linux driver project server is unreachabl

Re: [PATCH v7 0/9] Generic PHY Framework

2013-06-17 Thread Sylwester Nawrocki
Hi, On 06/13/2013 10:43 AM, Kishon Vijay Abraham I wrote: > Added a generic PHY framework that provides a set of APIs for the PHY drivers > to create/destroy a PHY and APIs for the PHY users to obtain a reference to > the PHY with or without using phandle. > > This framework will be of use only t

Re: [PATCh V10 04/12] usb: ehci: ehci-mv: use PHY driver for ehci

2013-06-17 Thread Alan Stern
On Mon, 17 Jun 2013, Chao Xie wrote: > > To avoid PHY init/shutdown, the platform driver should simply leave the > > generic PHY pointer (which has not yet been added to struct hcd) set to > > NULL. > > > So does it mean that i need add adtional usb_phy to struct hcd? Ah, I was wrong. There alre

Re: MUSB multiplatform work?

2013-06-17 Thread Vinod Koul
On Wed, Jun 12, 2013 at 05:27:53PM +0530, Jassi Brar wrote: > IIRC, TI's Sundaram Raju proposed a TI specific api to DMAEngine for > this very purpose, which was generalized into > device_prep_interleaved_dma(). Which I think should already be enough > to serve the purpose. Is it not? The interle

Re: Linux USB file storage gadget with new UDC

2013-06-17 Thread Alan Stern
On Mon, 17 Jun 2013, victor yeo wrote: > > I have an important finding. When the problem (SCSI_READ_10 command > > reads 4096 bytes of data, causing gadget to reset) happens, the PC > > shows that the gadget is detected as Full-speed device, but gadget > > reports that it is set to High-speed from

Re: [RFC PATCH 0/1] Intel xhci: rework EHCI/xHCI port switching

2013-06-17 Thread Sarah Sharp
On Fri, Jun 14, 2013 at 02:23:36PM -0700, Greg KH wrote: > On Fri, Jun 14, 2013 at 02:16:50PM -0700, Sarah Sharp wrote: > > The main thing I'm concerned about is that the patch doesn't handle > > Intel xHCI host controller PCI hot-plug. We don't really expect any of > > the Intel PCI hosts to be h

Re: [RFC PATCH 0/1] Intel xhci: rework EHCI/xHCI port switching

2013-06-17 Thread Alan Stern
On Mon, 17 Jun 2013, Sarah Sharp wrote: > > We should be able to handle hotplug if at all possible. I know the > > quirk handling issues around PCI hotplug aren't all worked out (or at > > least they were not a year or so ago), so maybe there's really nothing > > you can/need to do here. > > Ok,

[PATCH 2/2] musb: musb: dsps: determine the number of instances at runtime

2013-06-17 Thread Sebastian Andrzej Siewior
There is no need to hardcode the number of instances here. It is better to determine them at runtime. Even if the device provides two instances one might only want to use one of them. Signed-off-by: Sebastian Andrzej Siewior --- drivers/usb/musb/musb_dsps.c | 33 +++--

[PATCH 1/2] musb: musb: dsps: support multiple instances

2013-06-17 Thread Sebastian Andrzej Siewior
If we specify right now more than once instance then we attempt to add the platform device twice. The nop driver does not mind the second add because it checks for it and returns without a word. At removal time a segfault is likely because the first intance clean ups the phy and second, well, goes

[RFC] Add support for am33xx which has two musb ports

2013-06-17 Thread Sebastian Andrzej Siewior
Hi Felipe, so with these two I can use the second port on my am335x-evm in hostmode. After the second ports gets noticed by Linux I see over and over: |musb_bus_suspend 2457: trying to suspend as a_wait_bcon while active Which disappears once I plug in a device and does not come back after I unpl

Re: Staging mailing list dead ?

2013-06-17 Thread Greg Kroah-Hartman
On Mon, Jun 17, 2013 at 10:39:25AM +0100, Rupesh Gujare wrote: > Hi All, > > First of all I am sorry to bother all of you, as this might not be the right > place to ask this question. > But since last few days, I am not able to reach staging mailing list (1), > neither I am receiving emails from s

Re: [PATCH] USB: serial/ftdi_sio.c Fix kernel oops

2013-06-17 Thread Nicolas Palix
Hi, On Thu, Jun 13, 2013 at 5:35 AM, Ben Hutchings wrote: > On Fri, 2013-06-07 at 15:14 +0200, Lotfi Manseur wrote: >> Handle null termios in ftdi_set_termios(), introduced in >> commit 552f6bf1bb0eda0011c0525dd587aa9e7ba5b846 >> This has been corrected in the mainline by >> commits c515598e0f576

Re: MUSB multiplatform work?

2013-06-17 Thread Jassi Brar
On Mon, Jun 17, 2013 at 7:13 PM, Vinod Koul wrote: > On Wed, Jun 12, 2013 at 05:27:53PM +0530, Jassi Brar wrote: >> IIRC, TI's Sundaram Raju proposed a TI specific api to DMAEngine for >> this very purpose, which was generalized into >> device_prep_interleaved_dma(). Which I think should already

[RFC v2 0/4] Remove BUG() calls from xHCI driver

2013-06-17 Thread Sarah Sharp
This is a revised version of the patchset that was originally sent to fix "security issues" identified by the Klockwork static analysis tool. As discussed, these weren't real security issues, mostly just Klockwork not understanding that BUG() would stop code execution. The older patchset did have

[RFC v2 4/4] xhci: remove BUG() in xhci_get_endpoint_type()

2013-06-17 Thread Sarah Sharp
From: Mathias Nyman If the endpoint type is unknown, set it to 0 and fail gracefully instead of causing a kernel panic. Signed-off-by: Mathias Nyman Signed-off-by: Sarah Sharp --- drivers/usb/host/xhci-mem.c | 14 +- 1 files changed, 9 insertions(+), 5 deletions(-) diff --git a

[RFC v2 3/4] xhci: Remove BUG in xhci_setup_addressable_virt_dev

2013-06-17 Thread Sarah Sharp
From: Mathias Nyman We may have more speed types in the future, so fail gracefully, rather than causing the kernel to panic. BUG() was called if the device speed was unknown when setting max packet size. Set the max packet size at the same time as the slot speed and get rid of one switch statem

[RFC v2 1/4] xhci: Remove BUG_ON() in xhci_alloc_container_ctx.

2013-06-17 Thread Sarah Sharp
It's horrible coding style to panic the kernel when someone passes you an argument value you didn't expect. In the future, we may want to add additional context types, so it's better to gracefully handle additional context types instead of panicking. Signed-off-by: Sarah Sharp Cc: John Youn ---

[RFC v2 2/4] xhci: Remove BUG_ON in xhci_get_input_control_ctx.

2013-06-17 Thread Sarah Sharp
Fail gracefully, instead of causing the kernel to panic, if the input control context doesn't have the right type (XHCI_CTX_TYPE_INPUT). Push finding the pointer to the input control context up into functions that can fail. Signed-off-by: Sarah Sharp Cc: John Youn --- drivers/usb/host/xhci-dbg

[RFC v2 1/1] xhci: check for failed dma pool allocation

2013-06-17 Thread Sarah Sharp
From: Mathias Nyman Fail and free the container context in case dma_pool_alloc() can't allocate the raw context data part of it This patch should be backported to kernels as old as 2.6.31, that contain the commit d115b04818e57bdbc7ccde4d0660b15e33013dc8 "USB: xhci: Support for 64-byte contexts".

[RFC v2 0/1] Fix xHCI NULL pointer deref

2013-06-17 Thread Sarah Sharp
This patchset breaks out the one real bug fix patch from the Klockwork "security issues" patchset. It should be applied to usb-linus and queued for stable, as it handles a real potential NULL pointer deference. Sarah Sharp The following changes since commit 0c3f3dc68bb6e6950e8cd7851e7778c550e8df

Re: [RFC v2 0/4] Remove BUG() calls from xHCI driver

2013-06-17 Thread Alan Stern
On Mon, 17 Jun 2013, Sarah Sharp wrote: > The older patchset did have some useful improvements, aside from the > misguided patch to make the USB core be more robust about handling NULL > pointers from usb_hub_to_struct_hub(). As discussed, that could only > happen if khubd binds to a hub with no

Re: [RFC v2 0/4] Remove BUG() calls from xHCI driver

2013-06-17 Thread Greg Kroah-Hartman
On Mon, Jun 17, 2013 at 09:55:17AM -0700, Sarah Sharp wrote: > This is a revised version of the patchset that was originally sent to > fix "security issues" identified by the Klockwork static analysis tool. > As discussed, these weren't real security issues, mostly just Klockwork > not understandin

Re: [RFC v2 0/1] Fix xHCI NULL pointer deref

2013-06-17 Thread Greg Kroah-Hartman
On Mon, Jun 17, 2013 at 09:56:30AM -0700, Sarah Sharp wrote: > This patchset breaks out the one real bug fix patch from the Klockwork > "security issues" patchset. It should be applied to usb-linus and > queued for stable, as it handles a real potential NULL pointer > deference. But, given that i

[PATCH/RESEND 03/12] usb: otg: msm: Convert to clk_prepare/unprepare

2013-06-17 Thread Stephen Boyd
Add calls to clk_prepare and unprepare so that MSM can migrate to the common clock framework. Acked-by: Felipe Balbi Signed-off-by: Stephen Boyd --- drivers/usb/phy/phy-msm-usb.c | 38 +++--- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/drivers

Re: [Application RFC PATCH] ptp-gadget: move from gadgetfs to functionfs

2013-06-17 Thread Michael Grzeschik
Hi Guennadi, On Thu, Jun 06, 2013 at 12:34:39AM +0200, Michael Grzeschik wrote: > This patch moves the ptp-gadget to use functionfs for the endpoint > handling. With functionfs, this patch is deleting a lot of control ep0 > code, which is now handled by the framework. Ping! Do you know who is mai

Re: [PATCH] build some drivers only when compile-testing

2013-06-17 Thread Jiri Slaby
On 05/23/2013 05:09 AM, Jeff Mahoney wrote: > On 5/22/13 10:23 PM, Greg Kroah-Hartman wrote: >> On Wed, May 22, 2013 at 11:18:46AM +0200, Jiri Slaby wrote: >>> Some drivers can be built on more platforms than they run on. This >>> causes users and distributors packaging burden when they have to >>>

Re: [PATCH v3 2/3] USB: serial: make minor allocation dynamic

2013-06-17 Thread Greg KH
On Sat, Jun 08, 2013 at 12:03:47PM +0200, Johan Hovold wrote: > On Fri, Jun 07, 2013 at 11:04:28AM -0700, Greg KH wrote: > > From: Greg Kroah-Hartman > > > Changes v2 - v3: > > - fixed up comments about usb_serial_get_by_minor() > > - fixed error case in usb_serial_get_by_minor() > > - fold

Re: [PATCH] usb: host: Faraday fotg210-hcd driver

2013-06-17 Thread Greg KH
On Wed, Jun 05, 2013 at 05:15:43PM +, Yuan-Hsin Chen wrote: > FOTG210 is an OTG controller which can be configured as an > USB2.0 host. FOTG210 host is an ehci-like controller with > some differences. First, register layout of FOTG210 is > incompatible with EHCI. Furthermore, FOTG210 is lack of

patch "usb: chipidea: ci13xxx_imx: let device core handle pinctrl" added to usb tree

2013-06-17 Thread gregkh
This is a note to let you know that I've just added the patch titled usb: chipidea: ci13xxx_imx: let device core handle pinctrl to my usb git tree which can be found at git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git in the usb-next branch. The patch will show up in the nex

Re: [PATCH 20/20] usb: chipidea: drop "13xxx" infix

2013-06-17 Thread Greg KH
On Thu, Jun 13, 2013 at 06:00:04PM +0300, Alexander Shishkin wrote: > "ci13xxx" is bad for at least the following reasons: > * people often mistype it > * it doesn't add any informational value to the names it's used in > * it needlessly attracts mail filters > > This patch replaces it with

Re: [PATCH 00/20] usb: chipidea: updates for v3.11

2013-06-17 Thread Greg KH
On Thu, Jun 13, 2013 at 05:59:44PM +0300, Alexander Shishkin wrote: > Hi, > > Here's a set of chipidea updates for v3.11. These are mostly fixes and > cleanups, but also include isoch endpoint support and multi-td > transfers by Michael. > > On top there are two mass rename patches that I've been

[no subject]

2013-06-17 Thread AFG GTBANK LOAN
Loan Syndicacion Am AFG Guaranty Trust Bank, zu strukturieren wir Kreditlinien treffen Sie unsere Kunden spezifischen geschäftlichen Anforderungen und einen deutlichen Mehrwert für unsere Kunden Unternehmen. eine Division der AFG Finance und Private Bank plc. Wenn Sie erwägen, eine große Akqui

Re: [PATCH] usb: host: Faraday fotg210-hcd driver

2013-06-17 Thread Yuan-Hsin Chen
Hi, On Tue, Jun 18, 2013 at 4:39 AM, Greg KH wrote: > On Wed, Jun 05, 2013 at 05:15:43PM +, Yuan-Hsin Chen wrote: >> FOTG210 is an OTG controller which can be configured as an >> USB2.0 host. FOTG210 host is an ehci-like controller with >> some differences. First, register layout of FOTG210 i

Re: [RFC v2 0/4] Remove BUG() calls from xHCI driver

2013-06-17 Thread Sarah Sharp
On Mon, Jun 17, 2013 at 10:40:24AM -0700, Greg Kroah-Hartman wrote: > On Mon, Jun 17, 2013 at 09:55:17AM -0700, Sarah Sharp wrote: > > This is a revised version of the patchset that was originally sent to > > fix "security issues" identified by the Klockwork static analysis tool. > > As discussed,

[Pull Request] xhci: Remove BUG() calls from the driver

2013-06-17 Thread Sarah Sharp
The following changes since commit 976f8bef9cfb5246bc0e8dc781562daa79cb7aaf: Merge tag 'usb-for-v3.11' of git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb into usb-next (2013-06-12 14:44:13 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git

Re: [RFC v2 0/1] Fix xHCI NULL pointer deref

2013-06-17 Thread Sarah Sharp
On Mon, Jun 17, 2013 at 10:41:56AM -0700, Greg Kroah-Hartman wrote: > On Mon, Jun 17, 2013 at 09:56:30AM -0700, Sarah Sharp wrote: > > This patchset breaks out the one real bug fix patch from the Klockwork > > "security issues" patchset. It should be applied to usb-linus and > > queued for stable,

Re: [PATCH] usb: host: Faraday fotg210-hcd driver

2013-06-17 Thread Sarah Sharp
On Tue, Jun 18, 2013 at 10:42:09AM +0800, Yuan-Hsin Chen wrote: > Hi, > > On Tue, Jun 18, 2013 at 4:39 AM, Greg KH wrote: > > On Wed, Jun 05, 2013 at 05:15:43PM +, Yuan-Hsin Chen wrote: > >> FOTG210 is an OTG controller which can be configured as an > >> USB2.0 host. FOTG210 host is an ehci-l

Re: [RFC PATCH 0/1] Intel xhci: rework EHCI/xHCI port switching

2013-06-17 Thread Sarah Sharp
On Mon, Jun 17, 2013 at 11:06:15AM -0400, Alan Stern wrote: > On Mon, 17 Jun 2013, Sarah Sharp wrote: > > > > We should be able to handle hotplug if at all possible. I know the > > > quirk handling issues around PCI hotplug aren't all worked out (or at > > > least they were not a year or so ago),

[PATCH -next] usb: gadget: f_subset: fix missing unlock on error in geth_alloc()

2013-06-17 Thread Wei Yongjun
From: Wei Yongjun Add the missing unlock before return from function geth_alloc() in the error handling case. Introduced by commit 02832e56f88a981474ee4c7c141f46fc1b4454f4. (usb: gadget: f_subset: add configfs support) Signed-off-by: Wei Yongjun --- drivers/usb/gadget/f_subset.c | 1 + 1 file

[PATCH -next] usb: gadget: f_ncm: fix missing unlock on error in ncm_alloc()

2013-06-17 Thread Wei Yongjun
From: Wei Yongjun Add the missing unlock before return from function ncm_alloc() in the error handling case. Introduced by commit e730660378be92b83288b59b824ccdace5cd2652. (usb: gadget: f_ncm: add configfs support) Signed-off-by: Wei Yongjun --- drivers/usb/gadget/f_ncm.c | 1 + 1 file change

[PATCH -next] usb: gadget: f_ecm: fix missing unlock on error in ecm_alloc()

2013-06-17 Thread Wei Yongjun
From: Wei Yongjun Add the missing unlock before return from function ecm_alloc() in the error handling case. Introduced by commit da92801c647cdebfd45001fd6aaecb8f0be7f56b. (usb: gadget: f_ecm: add configfs support) Signed-off-by: Wei Yongjun --- drivers/usb/gadget/f_ecm.c | 1 + 1 file change

Re: [PATCH] build some drivers only when compile-testing

2013-06-17 Thread Michal Marek
Dne 17.6.2013 22:05, Jiri Slaby napsal(a): > On 05/23/2013 05:09 AM, Jeff Mahoney wrote: >> On 5/22/13 10:23 PM, Greg Kroah-Hartman wrote: >>> On Wed, May 22, 2013 at 11:18:46AM +0200, Jiri Slaby wrote: Some drivers can be built on more platforms than they run on. This causes users and di

Detecting start/stop streaming for UVC webcam with bulk transfer mode

2013-06-17 Thread Chetan Nanda
Hi, I am currently working with UVC camera device which send data using bulk transfer for preview and capture. I have modified UVC gadget driver to start bulk streaming on receiving first UVC_VS_COMMIT_CONTROL request from host side. But currently not able to detect when to stop the streaming. I

Re: [PATCH] usb: host: Faraday fotg210-hcd driver

2013-06-17 Thread Yuan-Hsin Chen
Hi, On Tue, Jun 18, 2013 at 11:07 AM, Sarah Sharp wrote: > On Tue, Jun 18, 2013 at 10:42:09AM +0800, Yuan-Hsin Chen wrote: >> Hi, >> >> On Tue, Jun 18, 2013 at 4:39 AM, Greg KH wrote: >> > On Wed, Jun 05, 2013 at 05:15:43PM +, Yuan-Hsin Chen wrote: >> >> FOTG210 is an OTG controller which ca