Re: [PATCH 4/9] usb: gadget/uvc: free buffers after streamoff

2013-06-05 Thread Michael Olbrich
On Tue, Jun 04, 2013 at 05:08:23PM +0200, Michael Grzeschik wrote: > From: Michael Grzeschik > > The current approach is to keep the device open and request buffers on > REQBUFS. These buffers will not be freed until device close. The device > close on the other hand will disconnect the device fr

Re: [PATCH 3/6] staging: octeon-usb: cvmx-usbcx-defs.h: avoid long lines in CVMX_USBCX macros

2013-06-05 Thread Dan Carpenter
On Wed, Jun 05, 2013 at 12:31:32AM +0300, Aaro Koskinen wrote: > -#define CVMX_USBCX_DAINT(block_id) (CVMX_ADD_IO_SEG(0x00016F001818ull) + > ((block_id) & 1) * 0x1000ull) There should be a few helper macros. I don't know the names for these: #define bid_to_xxx1(block_id) ((block_id)

Re: [PATCH v2 0/2] USB: PHY: Improve PHY selection logic

2013-06-05 Thread Roger Quadros
On 06/04/2013 11:26 PM, Felipe Balbi wrote: > Hi, > > On Tue, Jun 04, 2013 at 10:16:50AM +0300, Roger Quadros wrote: >> On 06/03/2013 08:47 PM, Greg KH wrote: >>> On Fri, May 31, 2013 at 02:29:01PM +0300, Roger Quadros wrote: Hi, Improve Kconfig so that the relevant PHY driver can b

[PATCH] USB: serial: fix TIOCMIWAIT return value

2013-06-05 Thread Johan Hovold
Fix regression introduced by commit 143d9d9616 ("USB: serial: add tiocmiwait subdriver operation") which made the ioctl operation return ENODEV rather than ENOIOCTLCMD when a subdriver TIOCMIWAIT implementation is missing. Cc: sta...@vger.kernel.org Signed-off-by: Johan Hovold --- Greg, Here's

Re: [PATCH V2 0/6] USB: make ehci-tegra its own module

2013-06-05 Thread Arnd Bergmann
On Wednesday 05 June 2013, Stephen Warren wrote: > > Today 01:53:28 > From: Stephen Warren > > ehci-tegra is currently built into the main ehci-hcd driver, rather than > being a separate module. This causes issues with multi-platform ARM > kernels. This series separates ehci-tegra into its own m

Re: [PATCH] USB: wusbcore: add HWA-specific fields to usb_rpipe_descriptor

2013-06-05 Thread Thomas Pugliese
On Tue, 4 Jun 2013, Thomas Pugliese wrote: > This patch adds the HWA-specific RPIPE fields to usb_rpipe_descriptor and > sets the appropriate values in usb/wusbcore/wa-rpipe.c:rpipe_aim. > > Signed-off-by: Thomas Pugliese > > diff --git a/drivers/usb/wusbcore/wa-rpipe.c b/drivers/usb/wusbcor

Re: [PATCH 2/7] USB: chipidea: ci13xxx-imx: move static pdata into probe function

2013-06-05 Thread Michael Grzeschik
Hi Alexander, On Fri, May 31, 2013 at 08:38:44PM +0200, Michael Grzeschik wrote: > From: Michael Grzeschik > > The pdata structure gets copied anyway inside ci13xxx_add_device > by platform_device_add. We don't need to have it static. > > Signed-off-by: Michael Grzeschik > Signed-off-by: Marc

Re: [PATCH 2/7] USB: chipidea: ci13xxx-imx: move static pdata into probe function

2013-06-05 Thread Alexander Shishkin
Michael Grzeschik writes: > Hi Alexander, > > On Fri, May 31, 2013 at 08:38:44PM +0200, Michael Grzeschik wrote: >> From: Michael Grzeschik >> >> The pdata structure gets copied anyway inside ci13xxx_add_device >> by platform_device_add. We don't need to have it static. >> >> Signed-off-by: Mi

Re: [PATCH V2 3/6] USB: EHCI: export ehci_handshake for ehci-hcd sub-drivers

2013-06-05 Thread Alan Stern
On Tue, 4 Jun 2013, Stephen Warren wrote: > From: Manjunath Goudar > > In order to split ehci-hcd.c into separate modules, handshake() must be > exported. Rename the symbol to add an ehci_ prefix, to avoid any naming > clashes. > > Signed-off-by: Manjunath Goudar > [swarren, split Manjunath's

Re: [PATCH V2 4/6] USB: EHCI: tegra: remove all power management

2013-06-05 Thread Alan Stern
On Tue, 4 Jun 2013, Stephen Warren wrote: > From: Stephen Warren > > The PM routines in ehci-tegra.c use APIs such as ehci_reset(), > ehci_halt(), and ehci_tdi_reset() that would need to be exported to > convert ehci-tegra.c into a separate module from ehci-hcd.c. However, > we'd prefer not to e

Re: [PATCH V2 5/6] USB: EHCI: tegra: fix circular module dependencies

2013-06-05 Thread Alan Stern
On Tue, 4 Jun 2013, Stephen Warren wrote: > From: Stephen Warren > > The Tegra EHCI driver directly calls various functions in the Tegra USB > PHY driver. The reverse is also true; the PHY driver calls into the EHCI > driver. This is problematic when the two are built as modules. > > The calls

Re: [PATCH V2 6/6] USB: EHCI: make ehci-tegra a separate driver

2013-06-05 Thread Alan Stern
On Tue, 4 Jun 2013, Stephen Warren wrote: > From: Manjunath Goudar > > Separate the Tegra on-chip host controller driver from > ehci-hcd host code so that it can be built as a separate driver module. > This work is part of enabling multi-platform kernels on ARM. > > Signed-off-by: Manjunath Gou

Re: [RFC PATCH v3 0/4] Add usb2 link powermanagement BESL support

2013-06-05 Thread Alan Stern
On Tue, 4 Jun 2013, Sarah Sharp wrote: > Alan, Greg, any more comments on this patchset? > > It looks fine to me, and we've been testing it internally within Intel, > so I'll queue it up for 3.11 if you don't have any more objections. No objections to any of the parts touching the USB core. Ala

Re: [PATCH] USB: serial: fix TIOCMIWAIT return value

2013-06-05 Thread Greg Kroah-Hartman
On Wed, Jun 05, 2013 at 12:21:11PM +0200, Johan Hovold wrote: > Fix regression introduced by commit 143d9d9616 ("USB: serial: add > tiocmiwait subdriver operation") which made the ioctl operation return > ENODEV rather than ENOIOCTLCMD when a subdriver TIOCMIWAIT > implementation is missing. Ah, m

Re: [PATCH] USB: serial: fix TIOCMIWAIT return value

2013-06-05 Thread Greg Kroah-Hartman
On Wed, Jun 05, 2013 at 12:21:11PM +0200, Johan Hovold wrote: > Fix regression introduced by commit 143d9d9616 ("USB: serial: add > tiocmiwait subdriver operation") which made the ioctl operation return > ENODEV rather than ENOIOCTLCMD when a subdriver TIOCMIWAIT > implementation is missing. > > C

Re: [RFC PATCH v3 0/4] Add usb2 link powermanagement BESL support

2013-06-05 Thread Greg KH
On Wed, Jun 05, 2013 at 10:51:38AM -0400, Alan Stern wrote: > On Tue, 4 Jun 2013, Sarah Sharp wrote: > > > Alan, Greg, any more comments on this patchset? > > > > It looks fine to me, and we've been testing it internally within Intel, > > so I'll queue it up for 3.11 if you don't have any more ob

Re: [PATCH] USB: serial: fix TIOCMIWAIT return value

2013-06-05 Thread Johan Hovold
On Wed, Jun 05, 2013 at 08:34:29AM -0700, Greg KH wrote: > On Wed, Jun 05, 2013 at 12:21:11PM +0200, Johan Hovold wrote: > > Fix regression introduced by commit 143d9d9616 ("USB: serial: add > > tiocmiwait subdriver operation") which made the ioctl operation return > > ENODEV rather than ENOIOCTLCM

Re: [PATCH] USB: serial: fix TIOCMIWAIT return value

2013-06-05 Thread Johan Hovold
On Wed, Jun 05, 2013 at 08:33:56AM -0700, Greg KH wrote: > On Wed, Jun 05, 2013 at 12:21:11PM +0200, Johan Hovold wrote: > > Fix regression introduced by commit 143d9d9616 ("USB: serial: add > > tiocmiwait subdriver operation") which made the ioctl operation return > > ENODEV rather than ENOIOCTLCM

Re: [PATCH] USB: wusbcore: add HWA-specific fields to usb_rpipe_descriptor

2013-06-05 Thread Thomas Pugliese
On Wed, 5 Jun 2013, Thomas Pugliese wrote: > > > On Tue, 4 Jun 2013, Thomas Pugliese wrote: > > > This patch adds the HWA-specific RPIPE fields to usb_rpipe_descriptor and > > sets the appropriate values in usb/wusbcore/wa-rpipe.c:rpipe_aim. > > > > Signed-off-by: Thomas Pugliese > > > >

Re: [PATCH] USB: serial: fix TIOCMIWAIT return value

2013-06-05 Thread Greg Kroah-Hartman
On Wed, Jun 05, 2013 at 05:44:44PM +0200, Johan Hovold wrote: > On Wed, Jun 05, 2013 at 08:33:56AM -0700, Greg KH wrote: > > On Wed, Jun 05, 2013 at 12:21:11PM +0200, Johan Hovold wrote: > > > Fix regression introduced by commit 143d9d9616 ("USB: serial: add > > > tiocmiwait subdriver operation") w

Re: [PATCH] USB: serial: fix TIOCMIWAIT return value

2013-06-05 Thread Greg Kroah-Hartman
On Wed, Jun 05, 2013 at 10:12:19AM -0700, Greg Kroah-Hartman wrote: > On Wed, Jun 05, 2013 at 05:44:44PM +0200, Johan Hovold wrote: > > On Wed, Jun 05, 2013 at 08:33:56AM -0700, Greg KH wrote: > > > On Wed, Jun 05, 2013 at 12:21:11PM +0200, Johan Hovold wrote: > > > > Fix regression introduced by c

Re: [PATCH] USB: serial: fix TIOCMIWAIT return value

2013-06-05 Thread Greg Kroah-Hartman
On Wed, Jun 05, 2013 at 10:16:47AM -0700, Greg Kroah-Hartman wrote: > On Wed, Jun 05, 2013 at 10:12:19AM -0700, Greg Kroah-Hartman wrote: > > On Wed, Jun 05, 2013 at 05:44:44PM +0200, Johan Hovold wrote: > > > On Wed, Jun 05, 2013 at 08:33:56AM -0700, Greg KH wrote: > > > > On Wed, Jun 05, 2013 at

Re: [PATCH] USB: serial: fix TIOCMIWAIT return value

2013-06-05 Thread Johan Hovold
On Wed, Jun 05, 2013 at 10:12:19AM -0700, Greg KH wrote: > On Wed, Jun 05, 2013 at 05:44:44PM +0200, Johan Hovold wrote: > > On Wed, Jun 05, 2013 at 08:33:56AM -0700, Greg KH wrote: > > > On Wed, Jun 05, 2013 at 12:21:11PM +0200, Johan Hovold wrote: > > > > Fix regression introduced by commit 143d9

Re: [PATCH] USB: serial: fix TIOCMIWAIT return value

2013-06-05 Thread Johan Hovold
On Wed, Jun 05, 2013 at 10:19:20AM -0700, Greg KH wrote: > On Wed, Jun 05, 2013 at 10:16:47AM -0700, Greg Kroah-Hartman wrote: > > On Wed, Jun 05, 2013 at 10:12:19AM -0700, Greg Kroah-Hartman wrote: > > > On Wed, Jun 05, 2013 at 05:44:44PM +0200, Johan Hovold wrote: > > > > On Wed, Jun 05, 2013 at

[PATCH 3/3] USB: serial: increase the number of devices we support

2013-06-05 Thread Greg KH
From: Greg Kroah-Hartman We had the limit of 255 USB to serial devices on one system for almost 15 years, with no complaints. But now it's time to move on from these tiny "baby" systems, and bump the number up to 3000, which should last us a few more years. Signed-off-by: Greg Kroah-Hartman -

[PATCH 2/3] USB: serial: make minor allocation dynamic

2013-06-05 Thread Greg KH
From: Greg Kroah-Hartman This moves the allocation of minor device numbers from a static array to be dynamic, using the idr interface. This means that you could potentially get "gaps" in a minor number range for a single USB serial device with multiple ports, but all should still work properly.

[PATCH 0/3] Increase the number of USB to serial devices we can support at once

2013-06-05 Thread Greg KH
Here are 3 patches that I've tested out on my system with only a small number of devices, but it seems to work, so why not let others try it out... These patches make the USB to serial core have the ability to support up to 3000 devices at once now. We do this in the following steps: - ad

[PATCH 1/3] USB: serial: ports: add minor and port number

2013-06-05 Thread Greg KH
From: Greg Kroah-Hartman The usb_serial_port structure had the number field, which was the minor number for the port, which almost no one really cared about. They really wanted the number of the port within the device, which you had to subtract from the minor of the parent usb_serial_device stru

[PATCH V3 5/7] USB: EHCI: tegra: fix circular module dependencies

2013-06-05 Thread Stephen Warren
From: Stephen Warren The Tegra EHCI driver directly calls various functions in the Tegra USB PHY driver. The reverse is also true; the PHY driver calls into the EHCI driver. This is problematic when the two are built as modules. The calls from the PHY to EHCI driver were originally added in comm

[PATCH V3 1/7] usb: phy: export ulpi_viewport_access_ops

2013-06-05 Thread Stephen Warren
From: Manjunath Goudar In order to build a ULPI PHY driver as a module, this symbol needs to be exported. Signed-off-by: Manjunath Goudar [swarren, reworked Manjunath's patches to split them more logically] Signed-off-by: Stephen Warren Acked-by: Arnd Bergmann --- v3: No change. v2: Include e

[PATCH V3 2/7] usb: phy: add MODULE_LICENSE to phy-tegra-usb.c

2013-06-05 Thread Stephen Warren
From: Stephen Warren When this file is built as a module, it needs a MODULE_LICENSE in order to access many exported symbols. Signed-off-by: Stephen Warren Acked-by: Arnd Bergmann --- v3: No change. v2: No change. --- drivers/usb/phy/phy-tegra-usb.c | 4 1 file changed, 4 insertions(+)

[PATCH V3 0/7] USB: make ehci-tegra its own module

2013-06-05 Thread Stephen Warren
From: Stephen Warren ehci-tegra is currently built into the main ehci-hcd driver, rather than being a separate module. This causes issues with multi-platform ARM kernels. This series separates ehci-tegra into its own module to avoid those problems. Manjunath Goudar originally wrote most of this

[PATCH V3 3/7] USB: EHCI: export ehci_handshake for ehci-hcd sub-drivers

2013-06-05 Thread Stephen Warren
From: Manjunath Goudar In order to split ehci-hcd.c into separate modules, handshake() must be exported. Rename the symbol to add an ehci_ prefix, to avoid any naming clashes. Signed-off-by: Manjunath Goudar [swarren, split Manjunath's patches more logically, limit this change to export just ha

[PATCH V3 4/7] USB: EHCI: tegra: remove all power management

2013-06-05 Thread Stephen Warren
From: Stephen Warren The PM routines in ehci-tegra.c use APIs such as ehci_reset(), ehci_halt(), and ehci_tdi_reset() that would need to be exported to convert ehci-tegra.c into a separate module from ehci-hcd.c. However, we'd prefer not to export them. Instead, simply remove all power managemen

[PATCH V3 7/7] USB: EHCI: tegra: make use of ehci->priv

2013-06-05 Thread Stephen Warren
From: Stephen Warren Rather than allocating struct tegra_ehci_hcd separately, use struct ehci_hcd's priv field instead. Signed-off-by: Stephen Warren --- v3: New patch. --- drivers/usb/host/ehci-tegra.c | 70 +-- 1 file changed, 35 insertions(+), 35 dele

[PATCH V3 6/7] USB: EHCI: make ehci-tegra a separate driver

2013-06-05 Thread Stephen Warren
From: Manjunath Goudar Separate the Tegra on-chip host controller driver from ehci-hcd host code so that it can be built as a separate driver module. This work is part of enabling multi-platform kernels on ARM. Signed-off-by: Manjunath Goudar [swarren, reworked Manjunath's patches to split them

Re: [PATCH V3 4/7] USB: EHCI: tegra: remove all power management

2013-06-05 Thread Alan Stern
On Wed, 5 Jun 2013, Stephen Warren wrote: > From: Stephen Warren > > The PM routines in ehci-tegra.c use APIs such as ehci_reset(), > ehci_halt(), and ehci_tdi_reset() that would need to be exported to > convert ehci-tegra.c into a separate module from ehci-hcd.c. However, > we'd prefer not to e

Re: [PATCH V3 6/7] USB: EHCI: make ehci-tegra a separate driver

2013-06-05 Thread Alan Stern
On Wed, 5 Jun 2013, Stephen Warren wrote: > From: Manjunath Goudar > > Separate the Tegra on-chip host controller driver from > ehci-hcd host code so that it can be built as a separate driver module. > This work is part of enabling multi-platform kernels on ARM. > > Signed-off-by: Manjunath Gou

Re: [PATCH V3 7/7] USB: EHCI: tegra: make use of ehci->priv

2013-06-05 Thread Alan Stern
On Wed, 5 Jun 2013, Stephen Warren wrote: > From: Stephen Warren > > Rather than allocating struct tegra_ehci_hcd separately, use struct > ehci_hcd's priv field instead. > > Signed-off-by: Stephen Warren > --- > v3: New patch. Acked-by: Alan Stern -- To unsubscribe from this list: send the

[PATCH] option,zte_ev: move most ZTE CDMA devices to zte_ev

2013-06-05 Thread Dan Williams
Per some ZTE Linux drivers I found for the AC2716, the following patch moves most ZTE CDMA devices from option to zte_ev. The blacklist stuff that option does is not required with zte_ev, because it doesn't implement any of the send_setup hooks which the blacklist suppressed. I did not move the 2

Re: [PATCH 3/6] staging: octeon-usb: cvmx-usbcx-defs.h: avoid long lines in CVMX_USBCX macros

2013-06-05 Thread Aaro Koskinen
Hi, On Wed, Jun 05, 2013 at 11:36:46AM +0300, Dan Carpenter wrote: > On Wed, Jun 05, 2013 at 12:31:32AM +0300, Aaro Koskinen wrote: > > -#define CVMX_USBCX_DAINT(block_id) (CVMX_ADD_IO_SEG(0x00016F001818ull) > > + ((block_id) & 1) * 0x1000ull) > > There should be a few helper macros.

[PATCH] USB: fix PTR_ERR translation in init_usb_class()

2013-06-05 Thread Alexey Khoroshilov
There is a misprint in init_usb_class(): IS_ERR is used to get error code instead of PTR_ERR. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- drivers/usb/core/file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/

[Application RFC PATCH] ptp-gadget: move from gadgetfs to functionfs

2013-06-05 Thread Michael Grzeschik
This patch moves the ptp-gadget to use functionfs for the endpoint handling. With functionfs, this patch is deleting a lot of control ep0 code, which is now handled by the framework. Signed-off-by: Michael Grzeschik --- Makefile| 9 +- README | 6 +- ptp.c | 820 +-

Re: USB 3 webcam stop captures

2013-06-05 Thread Sarah Sharp
On Wed, Jun 05, 2013 at 11:07:46AM -0700, Oleg Rombakh wrote: > Sarah, > > I found an issue where a USB camera connected to USB3 port might stop > capturing frames. > Steps to reproduce: > > 1. Attach a USB camera to USB3 port (any camera will do but in my case > used Logitech camers) >

Re: [PATCH] lsusb: Fix bug in USB 2.0 extended caps descriptor.

2013-06-05 Thread Sarah Sharp
Ping. Greg, do you want to take this bug fix? Sarah On Thu, May 16, 2013 at 02:04:42PM -0700, Sarah Sharp wrote: > The upper bits of the USB 2.0 extended capability BOS descriptor weren't > being shifted into the right byte position. That didn't matter much > before now, but some USB 2.1 device

Re: [RFC] xhci: fix dma mask setup in xhci.c

2013-06-05 Thread Sarah Sharp
Hi Xenia, I get a checkpatch warning when I attempt to commit this change: Applying: xhci: fix dma mask setup in xhci.c WARNING: line over 80 characters #23: FILE: drivers/usb/host/xhci.c:4686: + if (dma_set_mask(hcd->self.controller, DMA_BIT_MASK(32))) Can you fix that up

[PATCH 0/7] Common Clock Framework support for Samsung S3C64xx

2013-06-05 Thread Tomasz Figa
This series is an attempt to move clock support on Samsung S3C64xx SoCs to Common Clock Framework. First, support for PLL types present on S3C64xx SoCs is added to Samsung Common Clock Framework driver. Then the main clock driver for mentioned SoCs is introduced. Further patches contain fixes for

[PATCH 1/7] clk: samsung: pll: Add support for PLL6552 and PLL6553

2013-06-05 Thread Tomasz Figa
This patch adds support for PLL6552 and PLL6553 PLLs present on Samsung S3C64xx SoCs. Signed-off-by: Tomasz Figa --- drivers/clk/samsung/clk-pll.c | 160 ++ drivers/clk/samsung/clk-pll.h | 4 ++ 2 files changed, 164 insertions(+) diff --git a/drivers/cl

[PATCH 6/7] ARM: s3c64xx: Migrate clock handling to Common Clock Framework

2013-06-05 Thread Tomasz Figa
This patch migrates the s3c64xx platform to use the new clock driver using Common Clock Framework. Signed-off-by: Tomasz Figa --- arch/arm/Kconfig | 2 +- arch/arm/mach-s3c64xx/Makefile| 2 +- arch/arm/mach-s3c64xx/common.c| 21 + arch/a

[PATCH 5/7] usb: host: ohci-s3c2410 Use clk_prepare_enable/clk_disable_unprepare

2013-06-05 Thread Tomasz Figa
This patch modifies the ohci-s3c2410 driver to prepare and unprepare clocks in addition to enabling and disabling, since it is required by common clock framework. Signed-off-by: Tomasz Figa --- drivers/usb/host/ohci-s3c2410.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --

[PATCH 2/7] clk: samsung: Add clock driver for S3C64xx SoCs

2013-06-05 Thread Tomasz Figa
This patch adds new, Common Clock Framework-based clock driver for Samsung S3C64xx SoCs. The driver is just added, without actually letting the platforms use it yet, since this requires more intermediate steps. Signed-off-by: Tomasz Figa --- .../bindings/clock/samsung,s3c64xx-clock.txt |

[PATCH 3/7] ARM: SAMSUNG: Add soc_is_s3c6400/s3c6410 macros

2013-06-05 Thread Tomasz Figa
This patch adds soc_is_s3c6400() and soc_is_s3c6410() macros that allow to distinguish between specific SoCs from s3c64xx series that is needed to handle differences between them. Signed-off-by: Tomasz Figa --- arch/arm/plat-samsung/include/plat/cpu.h | 4 1 file changed, 4 insertions(+) d

[PATCH 7/7] ARM: s3c64xx: Remove old clock management code

2013-06-05 Thread Tomasz Figa
This patch removes old clock management code of S3C64xx, since the platform has been already moved to the new clock driver using Common Clock Framework. Signed-off-by: Tomasz Figa --- arch/arm/mach-s3c64xx/clock.c | 1007 --- arch/arm/mach-s3c64xx/common.h

[PATCH 4/7] ARM: s3c64xx: dma: Use clk_prepare_enable/clk_disable_unprepare

2013-06-05 Thread Tomasz Figa
This patch modifies s3c64xx DMA driver to prepare and unprepare clocks in addition to enableind and disabling, since it is required by common clock framework. Signed-off-by: Tomasz Figa --- arch/arm/mach-s3c64xx/dma.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/a

Fwd: [PATCH] usb: phy: samsung: Add support for EXYNOS4210

2013-06-05 Thread Praveen Paneri
Hi, On Tue, May 28, 2013 at 2:34 PM, Jingoo Han wrote: > Add support for EXYNOS4210 that includes USB EHCI/OHCI. > Previous PHY initialization code is not correct; thus, it is modifed ^ You might want to say "previous PHY init code does not