On Tue, Jun 04, 2013 at 10:13:47AM -0400, Alan Stern wrote:
> On Mon, 3 Jun 2013, Greg KH wrote:
>
> > On Mon, May 27, 2013 at 02:28:51PM +0200, Bj?rn Mork wrote:
> > > But, IMHO, a nicer approach would be to make the allocation completely
> > > dynamic, using e.g. the idr subsystem. Static tables
On Tue, Jun 04, 2013 at 01:04:01PM +0200, Johan Hovold wrote:
> On Mon, Jun 03, 2013 at 07:49:59PM -0700, Greg KH wrote:
> > On Mon, May 27, 2013 at 02:28:51PM +0200, Bjørn Mork wrote:
> > > But, IMHO, a nicer approach would be to make the allocation completely
> > > dynamic, using e.g. the idr sub
When browsing the port->number accesses in usb-serial, I stumbled across
these bugs.
Johan
Johan Hovold (4):
USB: zte_ev: fix broken open
USB: keyspan: fix bogus array index
USB: keyspan: remove unused endpoint-array access
USB: mos7720: fix hardware flow control
drivers/usb/serial/key
Remove the no longer used endpoint-array access completely.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/keyspan.c | 10 --
1 file changed, 10 deletions(-)
diff --git a/drivers/usb/serial/keyspan.c b/drivers/usb/serial/keyspan.c
index d85a3e0..3549d07 100644
--- a/drivers/usb/seri
Remove bogus port-number check in open and close, which prevented this
driver from being used with a minor number different from zero.
Cc: sta...@vger.kernel.org
Signed-off-by: Johan Hovold
---
drivers/usb/serial/zte_ev.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/usb/seria
The outcont_endpoints array was indexed using the port minor number
(which can be greater than the array size) rather than the device port
number.
Cc: sta...@vger.kernel.org
Signed-off-by: Johan Hovold
---
drivers/usb/serial/keyspan.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -
The register access to enable hardware flow control depends on the
device port number and not the port minor number.
Cc: sta...@vger.kernel.org
Signed-off-by: Johan Hovold
---
drivers/usb/serial/mos7720.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/serial/mos7
On Tue, 4 Jun 2013, Arnd Bergmann wrote:
> On Tuesday 04 June 2013 11:22:01 Alan Stern wrote:
> >
> > Instead of doing this, it makes more sense to enable USB_ARCH_HAS_HCD
> > whenever host-side USB is enabled. In other words,
> >
> > def_bool USB
>
> The problem with this is that a lo
On Wed, 5 Jun 2013, victor yeo wrote:
> Thanks a lot. i understand this part now. Do you notice the Set
> Address request is not seen by the gadget driver? The Set Address
> request is handled by the hardware. Could it be the root cause? As
> gadget driver may expect the address information from t
On Tue, Jun 04, 2013 at 06:50:27PM +0200, Johan Hovold wrote:
> When browsing the port->number accesses in usb-serial, I stumbled across
> these bugs.
Ah, you beat me to them, thanks, now applied.
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a me
On 04.06.2013 04:49, Greg KH wrote:
> Tobias, can you test this patch out? Note, I only compiled it, did not
> get the chance to actually run it, so it might not work at all.
Sure, I'll gladly give it a try. Seeing the comments on the code, I'm
just wondering if there might be a more recent versi
On Tuesday 04 June 2013, Alan Stern wrote:
> On Tue, 4 Jun 2013, Arnd Bergmann wrote:
> > so that would create a circular dependency unless we change all of them
> > at once. I did that when creating this patch, but then decided to
> > revert it for now and do smaller steps.
>
> Okay. Changing th
The three options USB_ARCH_HAS_{EHCI,OHCI,XHCI} are all well beyond
their recommended shelf life. They have caused numerous build failures
over the years because they are never completely correct, and with
the move to splitting out the platform specific back-ends out of the
driver, there is no real
Greg,
Just (finally?) noticed the zte_ev driver was added for v3.7 kernel; and
it contains ID conflicts with 'option' for 0x05c6/0x6000, 0x19d2/0xfffe,
and 0x19d2/0x. These devices are listed in both drivers as being
ZTE devices (despite the Qualcomm vendor ID of one), so perhaps the IDs
shou
On Tue, Jun 04, 2013 at 07:27:20PM +0200, Tobias Winter wrote:
> On 04.06.2013 04:49, Greg KH wrote:
> > Tobias, can you test this patch out? Note, I only compiled it, did not
> > get the chance to actually run it, so it might not work at all.
>
> Sure, I'll gladly give it a try. Seeing the comme
On Tue, 4 Jun 2013, Arnd Bergmann wrote:
> The three options USB_ARCH_HAS_{EHCI,OHCI,XHCI} are all well beyond
> their recommended shelf life. They have caused numerous build failures
> over the years because they are never completely correct, and with
> the move to splitting out the platform spec
On Tue, Jun 04, 2013 at 12:50:06PM -0500, Dan Williams wrote:
> Greg,
>
> Just (finally?) noticed the zte_ev driver was added for v3.7 kernel; and
> it contains ID conflicts with 'option' for 0x05c6/0x6000, 0x19d2/0xfffe,
> and 0x19d2/0x. These devices are listed in both drivers as being
> ZT
This patchset moves the existing MSM clock code and affected drivers to the
common clock framework. A prerequisite of moving to the common clock
framework is to use clk_prepare() and clk_enable() so the first
few patches migrate drivers to that call (clk_prepare() is a no-op on MSM
right now). It a
Add calls to clk_prepare and unprepare so that MSM can migrate to
the common clock framework.
Cc: Felipe Balbi
Signed-off-by: Stephen Boyd
---
drivers/usb/phy/phy-msm-usb.c | 38 +++---
1 file changed, 19 insertions(+), 19 deletions(-)
diff --git a/drivers/usb/p
This patch adds the HWA-specific RPIPE fields to usb_rpipe_descriptor and
sets the appropriate values in usb/wusbcore/wa-rpipe.c:rpipe_aim.
Signed-off-by: Thomas Pugliese
diff --git a/drivers/usb/wusbcore/wa-rpipe.c b/drivers/usb/wusbcore/wa-rpipe.c
index f0d546c..ed77ec7 100644
--- a/drivers/u
Hi,
On Mon, Jun 03, 2013 at 04:44:37PM +0300, Alexander Shishkin wrote:
> Felipe Balbi writes:
>
> > Don't register anything non-generic under
> > the gadget's device as we don't really *own*
> > it.
>
> I've just found that this patch makes chipidea with
> CONFIG_CHIPIDEA_DEBUG broken on v3.9.
Hi,
On Tue, Jun 04, 2013 at 12:25:29PM -0700, Stephen Boyd wrote:
> Add calls to clk_prepare and unprepare so that MSM can migrate to
> the common clock framework.
>
> Cc: Felipe Balbi
> Signed-off-by: Stephen Boyd
it's best if this goes with the rest of the series, for that:
Acked-by: Felip
HI,
On Tue, Jun 04, 2013 at 03:01:40PM +0200, Michael Grzeschik wrote:
> On Mon, Jun 03, 2013 at 03:32:50PM +0300, Alexander Shishkin wrote:
> > Michael Grzeschik writes:
> >
> > > From: Michael Grzeschik
> > >
> > > This adds two little devicetree helper functions for determining the
> > > dr_
Hi,
On Tue, Jun 04, 2013 at 10:16:50AM +0300, Roger Quadros wrote:
> On 06/03/2013 08:47 PM, Greg KH wrote:
> > On Fri, May 31, 2013 at 02:29:01PM +0300, Roger Quadros wrote:
> >> Hi,
> >>
> >> Improve Kconfig so that the relevant PHY driver can be explicitely
> >> selected by the controller drive
Hi,
This series fixes most of the checkpatch issues in cvmx-usbcx-defs.h:
Before: total: 1785 errors, 1168 warnings, 3086 lines checked
After: total:0 errors, 53 warnings, 3647 lines checked
The only remaining issue is "WARNING: do not add new typedefs" which
will be addressed in further
Delete CVS keyword marker and a comment that the file is autogenerated.
Signed-off-by: Aaro Koskinen
---
drivers/staging/octeon-usb/cvmx-usbcx-defs.h |4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/octeon-usb/cvmx-usbcx-defs.h
b/drivers/staging/octeon-usb/cvmx-usbcx-de
Avoid long lines in CVMX_USBCX macros.
Signed-off-by: Aaro Koskinen
---
drivers/staging/octeon-usb/cvmx-usbcx-defs.h | 208 +++---
1 file changed, 156 insertions(+), 52 deletions(-)
diff --git a/drivers/staging/octeon-usb/cvmx-usbcx-defs.h
b/drivers/staging/octeon-usb/cvmx
Reformat the original license text to fit in 80-column terminal. No
change in wording.
Signed-off-by: Aaro Koskinen
---
drivers/staging/octeon-usb/cvmx-usbcx-defs.h | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/octeon-usb/cvmx-usbcx-defs.h
b/dr
On Tue, 2013-06-04 at 12:18 -0700, Greg KH wrote:
> On Tue, Jun 04, 2013 at 12:50:06PM -0500, Dan Williams wrote:
> > Greg,
> >
> > Just (finally?) noticed the zte_ev driver was added for v3.7 kernel; and
> > it contains ID conflicts with 'option' for 0x05c6/0x6000, 0x19d2/0xfffe,
> > and 0x19d2/0
Felipe Balbi writes:
> Hi,
>
> On Mon, Jun 03, 2013 at 04:44:37PM +0300, Alexander Shishkin wrote:
>> Felipe Balbi writes:
>>
>> > Don't register anything non-generic under
>> > the gadget's device as we don't really *own*
>> > it.
>>
>> I've just found that this patch makes chipidea with
>> C
On Tue, Jun 04, 2013 at 04:47:18PM -0500, Dan Williams wrote:
> On Tue, 2013-06-04 at 12:18 -0700, Greg KH wrote:
> > On Tue, Jun 04, 2013 at 12:50:06PM -0500, Dan Williams wrote:
> > > Greg,
> > >
> > > Just (finally?) noticed the zte_ev driver was added for v3.7 kernel; and
> > > it contains ID
Alan, Greg, any more comments on this patchset?
It looks fine to me, and we've been testing it internally within Intel,
so I'll queue it up for 3.11 if you don't have any more objections.
Sarah Sharp
On Thu, May 23, 2013 at 05:14:27PM +0300, Mathias Nyman wrote:
> This series adds usb2 best effo
From: Manjunath Goudar
In order to build a ULPI PHY driver as a module, this symbol needs to
be exported.
Signed-off-by: Manjunath Goudar
[swarren, reworked Manjunath's patches to split them more logically]
Signed-off-by: Stephen Warren
---
v2: Include export.h not module.h
---
drivers/usb/ph
From: Stephen Warren
The Tegra EHCI driver directly calls various functions in the Tegra USB
PHY driver. The reverse is also true; the PHY driver calls into the EHCI
driver. This is problematic when the two are built as modules.
The calls from the PHY to EHCI driver were originally added in comm
From: Manjunath Goudar
In order to split ehci-hcd.c into separate modules, handshake() must be
exported. Rename the symbol to add an ehci_ prefix, to avoid any naming
clashes.
Signed-off-by: Manjunath Goudar
[swarren, split Manjunath's patches more logically, limit this change
to export just ha
From: Stephen Warren
ehci-tegra is currently built into the main ehci-hcd driver, rather than
being a separate module. This causes issues with multi-platform ARM
kernels. This series separates ehci-tegra into its own module to avoid
those problems.
Manjunath Goudar originally wrote most of this
From: Stephen Warren
The PM routines in ehci-tegra.c use APIs such as ehci_reset(),
ehci_halt(), and ehci_tdi_reset() that would need to be exported to
convert ehci-tegra.c into a separate module from ehci-hcd.c. However,
we'd prefer not to export them.
Instead, simply remove all power managemen
From: Stephen Warren
When this file is built as a module, it needs a MODULE_LICENSE in order
to access many exported symbols.
Signed-off-by: Stephen Warren
---
v2: No change.
---
drivers/usb/phy/phy-tegra-usb.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/usb/phy/phy-tegra-u
From: Manjunath Goudar
Separate the Tegra on-chip host controller driver from
ehci-hcd host code so that it can be built as a separate driver module.
This work is part of enabling multi-platform kernels on ARM.
Signed-off-by: Manjunath Goudar
[swarren, reworked Manjunath's patches to split them
Hi
> > Could you please teach me who/how/when free resource memory
> > which was kmemdup'ed by platform_device_add_xxx()
> > (and kmalloc'ed dma_mask) on platform_device_register_full() ??
>
> I don't think there's a need to free them. The EHCI/OHCI devices
> are always there after all.
Yes
Randy Dunlap reported below problem
at i386:
> drivers/built-in.o: In function `ci_hdrc_host_init':
> (.text+0x2ce75c): undefined reference to `ehci_init_driver'
> When USB_EHCI_HCD=m and USB_CHIPIDEA=y.
In fact, this problem is existed at all platforms which are using
chipidea driver. The root
Hi Ruchika,
On Tuesday 04 June 2013 07:53 PM, Ruchika Kharwar wrote:
Kishon,
What is the expectation when there is no palmas tied to dwc3/dwc3-omap ?
In the probe of dwc3-omap I have this check
"if (of_property_read_bool(node, "extcon"))"
So If dwc3 node does not have extcon property, it wont
Hi,
On Tuesday 04 June 2013 07:13 PM, Sylwester Nawrocki wrote:
Hi,
On 06/04/2013 02:26 PM, Kishon Vijay Abraham I wrote:
+static inline int phy_init(struct phy *phy)
+{
+ pm_runtime_get_sync(&phy->dev);
Hmm, no need to check return value here ? Also it looks a bit unexpected to
I pu
Pci_enable_device() will set device power state to D0,
so it's no need to do it again in dwc3_pci_probe().
Signed-off-by: Yijing Wang
Cc: Felipe Balbi
Cc: linux-o...@vger.kernel.org
Cc: linux-usb@vger.kernel.org
---
drivers/usb/dwc3/dwc3-pci.c |1 -
1 files changed, 0 insertions(+), 1 delet
On 06/03/2013 08:47 PM, Greg KH wrote:
> On Fri, May 31, 2013 at 02:29:01PM +0300, Roger Quadros wrote:
>> Hi,
>>
>> Improve Kconfig so that the relevant PHY driver can be explicitely
>> selected by the controller driver instead of relying on the user
>> to do so.
>>
>> Detailed description in patc
Peter Chen writes:
> On Thu, May 9, 2013 at 3:51 AM, Randy Dunlap wrote:
>> On 05/08/13 03:02, Peter Chen wrote:
>>> Randy Dunlap reported below problem
>>> at i386:
drivers/built-in.o: In function `ci_hdrc_host_init':
(.text+0x2ce75c): undefined reference to `ehci_init_driver'
>>>
>>
Michael Grzeschik writes:
> Hey Alex,
>
> On Mon, Jun 03, 2013 at 03:35:37PM +0300, Alexander Shishkin wrote:
>> Michael Grzeschik writes:
>>
>> > From: Michael Grzeschik
>> >
>> > This patch makes it possible to configure the PTW, PTS and STS bits
>> > inside the portsc register for host and
Peter Chen writes:
> On Mon, Jun 3, 2013 at 8:37 PM, Alexander Shishkin
> wrote:
>> Michael Grzeschik writes:
>>
>>> From: Sascha Hauer
>>>
>>> Even if a chipidea core is otg capable the board may not. This allows
>>
>> "may not be"
>>
>>> to explicitly set the core to host/peripheral mode. Wi
On 06/03/2013 08:51 PM, Greg KH wrote:
> On Thu, May 23, 2013 at 05:46:44PM +0300, Roger Quadros wrote:
>> On 05/23/2013 05:11 PM, Alan Stern wrote:
>>> On Thu, 23 May 2013, Roger Quadros wrote:
>>>
Device tree probed devices don't get dma_mask set. Previously
we were setting the dma_mask
On Tue, Jun 4, 2013 at 5:31 PM, Alexander Shishkin
wrote:
> Peter Chen writes:
>
>> On Mon, Jun 3, 2013 at 8:37 PM, Alexander Shishkin
>> wrote:
>>> Michael Grzeschik writes:
>>>
From: Sascha Hauer
Even if a chipidea core is otg capable the board may not. This allows
>>>
>>> "ma
Hi,
On 05/29/2013 07:38 AM, Kishon Vijay Abraham I wrote:
> On Wednesday 29 May 2013 04:07 AM, Sylwester Nawrocki wrote:
>> > On 04/29/2013 12:03 PM, Kishon Vijay Abraham I wrote:
>>> >> The PHY framework provides a set of APIs for the PHY drivers to
>>> >> create/destroy a PHY and APIs for the PH
On 04/29/2013 12:03 PM, Kishon Vijay Abraham I wrote:
> The PHY framework provides a set of APIs for the PHY drivers to
> create/destroy a PHY and APIs for the PHY users to obtain a reference to the
> PHY with or without using phandle. For dt-boot, the PHY drivers should
> also register *PHY provid
Hello.
On 04-06-2013 9:45, Kuninori Morimoto wrote:
The ohci/ehci resource will be used vainly if platform doesn't have USB
The platform device resources are never used vainly. And remember
that if PHY doesn't get registered, OHCI/EHCI won't get probed
successfully either -- mind the u
>
> I did actually have this one in my tree, but since that time this
>
> commit 7c8bfed7aaeba690de30835fe89882e1047a55fd
> Author: David Rientjes
> Date: Fri Apr 26 13:25:01 2013 -0700
>
> usb, chipidea: fix link error when USB_EHCI_HCD is a module
>
> has turned up in usb-next, and
On Wed, May 29, 2013 at 11:33 PM, Alan Stern wrote:
> This patch adds some code that inadvertently got left out of commit
> c1fdb68e3d73741630ca16695cf9176c233be7ed (USB: EHCI: changes related
> to qh_refresh()). The calls to qh_refresh() and qh_link_periodic()
> were taken out of qh_schedule();
Chen Peter-B29397 writes:
>
>>
>> I did actually have this one in my tree, but since that time this
>>
>> commit 7c8bfed7aaeba690de30835fe89882e1047a55fd
>> Author: David Rientjes
>> Date: Fri Apr 26 13:25:01 2013 -0700
>>
>> usb, chipidea: fix link error when USB_EHCI_HCD is a module
On Mon, Jun 03, 2013 at 07:49:59PM -0700, Greg KH wrote:
> On Mon, May 27, 2013 at 02:28:51PM +0200, Bjørn Mork wrote:
> > But, IMHO, a nicer approach would be to make the allocation completely
> > dynamic, using e.g. the idr subsystem. Static tables are always feel
> > like straight jackets to me,
Peter Chen writes:
> On Tue, Jun 4, 2013 at 5:31 PM, Alexander Shishkin
> wrote:
>> Peter Chen writes:
>>
>>> On Mon, Jun 3, 2013 at 8:37 PM, Alexander Shishkin
>>> wrote:
Michael Grzeschik writes:
> From: Sascha Hauer
>
> Even if a chipidea core is otg capable the boar
Fabio Estevam writes:
> If usbmisc_ops->post() fails it should point the error path to release all
> previously acquired resources, so adjust it to call ci13xxx_remove_device().
>
> While at it, remove the unnecessary 'plat_ci' indirection, as we can directly
> use the private structure.
>
> Sig
Alexander Shishkin writes:
> Michael Grzeschik writes:
>
>> Hi Alexander,
Pushed to chipidea tree, thanks! Btw, is there an updated version of
multi-td patchset?
Regards,
--
Alex
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.
Fabio Estevam writes:
> From: Fabio Estevam
>
> Fix the following sparse warnings:
>
> drivers/usb/chipidea/usbmisc_imx.c:246:5: warning: symbol
> 'usbmisc_imx_drv_init' was not declared. Should it be static?
> drivers/usb/chipidea/usbmisc_imx.c:252:6: warning: symbol
> 'usbmisc_imx_drv_exit'
From: Rong Wang
If global_phy is used when CONFIG_USB_PHY is not defined,
usb_get_phy() returns ERR_PTR(-ENXIO). If we only check
ci->transceiver is NULL or not in vbus_draw callback, it
will return true and continue to dereference ERR_PTR(-ENXIO)
which will cause a kernel panic.
Tested on CSR S
Hi,
On Tuesday 04 June 2013 03:51 PM, Sylwester Nawrocki wrote:
On 04/29/2013 12:03 PM, Kishon Vijay Abraham I wrote:
The PHY framework provides a set of APIs for the PHY drivers to
create/destroy a PHY and APIs for the PHY users to obtain a reference to the
PHY with or without using phandle. F
On Tue, Jun 04, 2013 at 02:12:16PM +0300, Alexander Shishkin wrote:
> Alexander Shishkin writes:
>
> > Michael Grzeschik writes:
> >
> >> Hi Alexander,
>
> Pushed to chipidea tree, thanks! Btw, is there an updated version of
> multi-td patchset?
Not yet posted; will send in a minute.
Thanks,
These patches add support to handle requests which spawn into several TDs.
Changes since v1:
- fixed missing static for free_pending_td
- fixed resetting mEp->pending_TD to NULL
Michael Grzeschik (2):
usb: chipidea: udc: manage dynamic amount of tds with an linked list
usb: chipidea: udc: add
From: Michael Grzeschik
This patch removes the restriction of having a limited amount of only
four active tds on one endpoint. We use the linked list implementation
to manage all tds which get added and removed by hardware_{en,de}queue.
The removal of this restriction adds the driver to run into
From: Michael Grzeschik
Instead of having a limited number of usable tds in the udc we use a
linked list to support dynamic amount of needed tds for all special
gadget types. This improves throughput.
Signed-off-by: Michael Grzeschik
Reviewed-by: Felipe Balbi
---
drivers/usb/chipidea/debug.c
On Mon, Jun 03, 2013 at 03:32:50PM +0300, Alexander Shishkin wrote:
> Michael Grzeschik writes:
>
> > From: Michael Grzeschik
> >
> > This adds two little devicetree helper functions for determining the
> > dr_mode (host, peripheral, otg) and phy_type (utmi, ulpi,...) from
> > the devicetree.
>
If cfg->product name is not set, a default name is chosen depending
on the common->luns->cdrom flag. If the flag is set the name should
be "File-CD Gadget", and if the flag is not set the name should be
"File-Stor Gadget".
Signed-off-by: Andrzej Pietrasiewicz
Signed-off-by: Kyungmin Park
---
dr
Hi,
On 06/04/2013 02:26 PM, Kishon Vijay Abraham I wrote:
>>> +static inline int phy_init(struct phy *phy)
>>> +{
>>> + pm_runtime_get_sync(&phy->dev);
>>
>> Hmm, no need to check return value here ? Also it looks a bit unexpected to
>
> I purposely dint check the return values in order to supp
On Mon, 3 Jun 2013, Greg KH wrote:
> On Mon, May 27, 2013 at 02:28:51PM +0200, Bj�rn Mork wrote:
> > But, IMHO, a nicer approach would be to make the allocation completely
> > dynamic, using e.g. the idr subsystem. Static tables are always feel
> > like straight jackets to me, no matter how big th
On Tue, 4 Jun 2013, Ming Lei wrote:
> > Index: usb-3.9/drivers/usb/host/ehci-sched.c
> > ===
> > --- usb-3.9.orig/drivers/usb/host/ehci-sched.c
> > +++ usb-3.9/drivers/usb/host/ehci-sched.c
> > @@ -646,6 +646,10 @@ static void end_unl
Kishon,
What is the expectation when there is no palmas tied to dwc3/dwc3-omap ?
Thank you
Regards
Ruchika
On 06/03/2013 11:13 AM, Kishon Vijay Abraham I wrote:
The first three patches deals with cleanup of extcon inorder to get
through compilation without any issues. It also adds an API to get
On Tue, 4 Jun 2013, victor yeo wrote:
> > I have no idea what the CV test is doing. If you can get a log from
> > the CV program, that would help.
>
> The CV log is attached (Dev_desc_test-Address state.html). Is it helpful?
It doesn't help very much. Can you get a more verbose log, one that
The three options USB_ARCH_HAS_{EHCI,OHCI,XHCI} are all well beyond
their recommended shelf life. They have caused numerous build failures
over the years because they are never completely correct, and with
the move to splitting out the platform specific back-ends out of the
driver, there is no real
The OHCI host controller driver can be built standalone now,
without enabling any of the available bus glue drivers, so
there is not really a reason to error out here:
drivers/usb/host/ohci-hcd.c:1258: error:
#error "missing bus glue for ohci-hcd" #error "missing bus glue for ohci-hcd"
This fol
Since the introduction of the timestamp_type field, it is necessary that
the driver chooses which type it will use. This patch adds support for
the timestamp_type.
Signed-off-by: Michael Grzeschik
---
drivers/usb/gadget/uvc_queue.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/
From: Michael Grzeschik
This patch adds ENUM_FMT as possible ioctl to the uvc v4l2 device.
That makes userspace applications with a generic IOCTL calling
convention make also use of it.
Signed-off-by: Michael Grzeschik
---
drivers/usb/gadget/uvc_v4l2.c | 24
1 file cha
From: Michael Grzeschik
Its not valid to set plane sizelimit if using USERPTR. The buffersize
limit will be parsed in buffer producing side.
Signed-off-by: Michael Grzeschik
---
drivers/usb/gadget/uvc_queue.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/gadge
Hi,
this series is fixing some stability and usability issues found with the usb
uvc-gadget. It's needed to make the device usable as an v4l2sink with gstreamer.
Thanks,
Michael
Laurent Pinchart (1):
usb: gadget/uvc: Fix error handling in uvc_queue_buffer()
Michael Grzeschik (8):
usb: gadge
From: Michael Grzeschik
This is needed to tell the userspace daemon
to disable the streaming if the device is
suspended.
Signed-off-by: Michael Grzeschik
---
drivers/usb/gadget/f_uvc.c | 17 +
1 file changed, 17 insertions(+)
diff --git a/drivers/usb/gadget/f_uvc.c b/drivers/u
From: Michael Grzeschik
The disconnect of the USB Device is an common pattern for
an UVC Camera. In many cases this will give us an meaningless
information for all buffers that couldn't be enqueued.
That patch changes this to KERN_DEBUG.
Signed-off-by: Michael Grzeschik
---
drivers/usb/gadget/
From: Laurent Pinchart
The conversion to videobuf2 failed to check the return value of
vb2_qbuf(). Fix it.
Reported-by: Michael Grzeschik
Signed-off-by: Laurent Pinchart
---
drivers/usb/gadget/uvc_queue.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/gad
From: Michael Grzeschik
If the pending buffers in the queue could not be pushed to the udc
endpoint we have to cancel the uvc_queue. Otherwise the gadget will get
stuck on this error. This patch calls uvc_queue_cancel if usb_ep_queue
failed.
Signed-off-by: Michael Grzeschik
---
drivers/usb/gad
From: Michael Grzeschik
Sizeimage is an property comming from the device. It's not safe to
depend on its value for imagesize on S_FMT. Its better to use simple
width * height for compressed formats without bits per pixel.
Signed-off-by: Michael Grzeschik
---
drivers/usb/gadget/uvc_v4l2.c | 4 +
From: Michael Grzeschik
The current approach is to keep the device open and request buffers on
REQBUFS. These buffers will not be freed until device close. The device
close on the other hand will disconnect the device from the USB host.
This way its not possible to change the buffers capabilitie
On Tue, Jun 04 2013, Andrzej Pietrasiewicz wrote:
> If cfg->product name is not set, a default name is chosen depending
> on the common->luns->cdrom flag. If the flag is set the name should
> be "File-CD Gadget", and if the flag is not set the name should be
> "File-Stor Gadget".
>
> Signed-off-by:
On Tue, 4 Jun 2013, Arnd Bergmann wrote:
> The OHCI host controller driver can be built standalone now,
> without enabling any of the available bus glue drivers, so
> there is not really a reason to error out here:
>
> drivers/usb/host/ohci-hcd.c:1258: error:
> #error "missing bus glue for ohci-
On Tue, 4 Jun 2013, Arnd Bergmann wrote:
> The three options USB_ARCH_HAS_{EHCI,OHCI,XHCI} are all well beyond
> their recommended shelf life. They have caused numerous build failures
> over the years because they are never completely correct, and with
> the move to splitting out the platform spec
On Tuesday 04 June 2013 11:22:01 Alan Stern wrote:
>
> Instead of doing this, it makes more sense to enable USB_ARCH_HAS_HCD
> whenever host-side USB is enabled. In other words,
>
> def_bool USB
The problem with this is that a lot of drivers (24 to be exact) are defined
like
config INP
Hi,
>> The CV log is attached (Dev_desc_test-Address state.html). Is it helpful?
>
> It doesn't help very much. Can you get a more verbose log, one that
> lists all the transfers?
>
> It looks like the problem could be that the host and the gadget don't
> agree on what packets have been sent and
On Mon, Jun 03, 2013 at 10:59:08PM -0400, Dave Jones wrote:
> On Mon, Jun 03, 2013 at 07:49:59PM -0700, Greg Kroah-Hartman wrote:
> > On Mon, May 27, 2013 at 02:28:51PM +0200, Bjørn Mork wrote:
> > > But, IMHO, a nicer approach would be to make the allocation completely
> > > dynamic, using e.g.
92 matches
Mail list logo
