Re: [PATCH 6/7] usb: chipidea: udc: add force-full-speed option

2013-06-01 Thread Sascha Hauer
On Fri, May 31, 2013 at 08:38:48PM +0200, Michael Grzeschik wrote: > From: Michael Grzeschik > > This patch makes it possible to set the chipidea udc > into full-speed only mode. It can be set by the oftree > property "force-full-speed". [...] > +/* force full-speed operation */ > +static bool

Re: [PATCH 6/7] usb: chipidea: udc: add force-full-speed option

2013-06-01 Thread Michael Grzeschik
On Sat, Jun 01, 2013 at 09:39:33AM +0200, Sascha Hauer wrote: > On Fri, May 31, 2013 at 08:38:48PM +0200, Michael Grzeschik wrote: > > From: Michael Grzeschik > > > > This patch makes it possible to set the chipidea udc > > into full-speed only mode. It can be set by the oftree > > property "forc

Re: [PATCH 6/7] usb: chipidea: udc: add force-full-speed option

2013-06-01 Thread Sascha Hauer
On Sat, Jun 01, 2013 at 10:19:32AM +0200, Michael Grzeschik wrote: > On Sat, Jun 01, 2013 at 09:39:33AM +0200, Sascha Hauer wrote: > > On Fri, May 31, 2013 at 08:38:48PM +0200, Michael Grzeschik wrote: > > > From: Michael Grzeschik > > > > > > This patch makes it possible to set the chipidea udc

[PATCH] usb: Cocci spatch "memdup.spatch"

2013-06-01 Thread Thomas Meyer
Signed-off-by: Thomas Meyer --- diff -u -p a/drivers/usb/storage/ene_ub6250.c b/drivers/usb/storage/ene_ub6250.c --- a/drivers/usb/storage/ene_ub6250.c +++ b/drivers/usb/storage/ene_ub6250.c @@ -1928,11 +1928,10 @@ static int ene_load_bincode(struct us_da usb_stor_dbg(us, "load f

[PATCH] usb: gadget: lpc32xx_udc: Cocci spatch "memdup.spatch"

2013-06-01 Thread Thomas Meyer
Signed-off-by: Thomas Meyer --- diff -u -p a/drivers/usb/gadget/lpc32xx_udc.c b/drivers/usb/gadget/lpc32xx_udc.c --- a/drivers/usb/gadget/lpc32xx_udc.c +++ b/drivers/usb/gadget/lpc32xx_udc.c @@ -3046,11 +3046,10 @@ static int __init lpc32xx_udc_probe(stru dma_addr_t dma_handle; s

[PATCH] usb: gadget: Cocci spatch "ptr_ret.spatch"

2013-06-01 Thread Thomas Meyer
Signed-off-by: Thomas Meyer --- diff -u -p a/drivers/usb/gadget/f_subset.c b/drivers/usb/gadget/f_subset.c --- a/drivers/usb/gadget/f_subset.c +++ b/drivers/usb/gadget/f_subset.c @@ -274,7 +274,7 @@ static int geth_set_alt(struct usb_funct } net = gether_connect(&geth->port); -

[PATCH] usb: gadget: Cocci spatch "err_cast.spatch"

2013-06-01 Thread Thomas Meyer
Signed-off-by: Thomas Meyer --- diff -u -p a/drivers/usb/gadget/composite.c b/drivers/usb/gadget/composite.c --- a/drivers/usb/gadget/composite.c +++ b/drivers/usb/gadget/composite.c @@ -1138,7 +1138,7 @@ struct usb_string *usb_gstrings_attach(s uc = copy_gadget_strings(sp, n_gstrings,

[PATCH] usb: dwc3: core: Cocci spatch "odd_ptr_err.spatch"

2013-06-01 Thread Thomas Meyer
Signed-off-by: Thomas Meyer --- diff -u -p a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c --- a/drivers/usb/dwc3/core.c +++ b/drivers/usb/dwc3/core.c @@ -450,7 +450,7 @@ static int dwc3_probe(struct platform_de } if (IS_ERR(dwc->usb3_phy)) { - ret = PTR_ERR(d

Re: MUSB multiplatform work?

2013-06-01 Thread Jassi Brar
On 31 May 2013 02:01, Tony Lindgren wrote: > * Linus Walleij [130530 13:27]: >> On Thu, May 30, 2013 at 10:18 PM, Tony Lindgren wrote: >> >> > TUSB would work with dmaengine, but AFAIK we're still missing the >> > dmaengine configuration options to support increasing device end >> > FIFO address

Re: [PATCH] usb: musb: Fix format specifier warning

2013-06-01 Thread Andy Shevchenko
On Sat, Jun 1, 2013 at 1:39 AM, Randy Dunlap wrote: > On 05/31/13 15:34, Andy Shevchenko wrote: >> On Fri, May 31, 2013 at 11:22 PM, Emil Goode wrote: >>> This patch fixes a format specifier warning. dma_addr_t can be either >>> u32 or u64 so we should cast to the largest type and change the form

Re: [PATCH v1 8/9] usb: phy: dts: Adding usbphy DT bindings for am33xx

2013-06-01 Thread Sergei Shtylyov
Hello. On 24-05-2013 9:34, B, Ravi wrote: + phy1: usbphy-gs70@44e10620 { + compatible = "ti,dsps-usbphy"; + reg = <0x44e10620 0x8 + 0x44e10648 0x4>; + reg-names = "phy_ctrl","phy_wkup";

Re: [PATCH] usb: gadget: lpc32xx_udc: Cocci spatch "memdup.spatch"

2013-06-01 Thread Felipe Balbi
On Sat, Jun 01, 2013 at 11:36:46AM +0200, Thomas Meyer wrote: > -ENOLOG please add a commit log. > Signed-off-by: Thomas Meyer > --- > > diff -u -p a/drivers/usb/gadget/lpc32xx_udc.c > b/drivers/usb/gadget/lpc32xx_udc.c > --- a/drivers/usb/gadget/lpc32xx_udc.c > +++ b/drivers/usb/gadget/lpc3

Re: [PATCH] usb: gadget: Cocci spatch "ptr_ret.spatch"

2013-06-01 Thread Felipe Balbi
On Sat, Jun 01, 2013 at 11:59:25AM +0200, Thomas Meyer wrote: > -ENOLOG > Signed-off-by: Thomas Meyer > --- > > diff -u -p a/drivers/usb/gadget/f_subset.c b/drivers/usb/gadget/f_subset.c > --- a/drivers/usb/gadget/f_subset.c > +++ b/drivers/usb/gadget/f_subset.c > @@ -274,7 +274,7 @@ static in

Re: [PATCH] usb: gadget: Cocci spatch "err_cast.spatch"

2013-06-01 Thread Felipe Balbi
On Sat, Jun 01, 2013 at 12:08:45PM +0200, Thomas Meyer wrote: > -ENOLOG > Signed-off-by: Thomas Meyer > --- > > diff -u -p a/drivers/usb/gadget/composite.c b/drivers/usb/gadget/composite.c > --- a/drivers/usb/gadget/composite.c > +++ b/drivers/usb/gadget/composite.c > @@ -1138,7 +1138,7 @@ str

Re: [PATCH] usb: dwc3: core: Cocci spatch "odd_ptr_err.spatch"

2013-06-01 Thread Felipe Balbi
On Sat, Jun 01, 2013 at 12:10:59PM +0200, Thomas Meyer wrote: > > Signed-off-by: Thomas Meyer -ENOLOG -- balbi signature.asc Description: Digital signature

Re: [PATCH] usb: musb: Fix format specifier warning

2013-06-01 Thread Emil Goode
Hello, Thank's for your pointers. I will send a patch that applies on top of Felipe's patch. Best regards, Emil Goode On Sat, Jun 01, 2013 at 04:15:03PM +0300, Andy Shevchenko wrote: > On Sat, Jun 1, 2013 at 1:39 AM, Randy Dunlap wrote: > > On 05/31/13 15:34, Andy Shevchenko wrote: > >> On Fri

[PATCH] usb: musb: use the new %pa format specifier for dma_addr_t

2013-06-01 Thread Emil Goode
This patch makes use of the new format specifier %pa that was introduced by the following commit. 7d7992108d02aa92ad4c77e5d9ce14088c942e75 ("lib/vsprintf.c: add %pa format specifier for phys_addr_t types") The addition of urb->transfer_dma and urb->actual_length is also done a few lines below. I

Re: [PATCH] usb: musb: use the new %pa format specifier for dma_addr_t

2013-06-01 Thread Joe Perches
On Sat, 2013-06-01 at 20:02 +0200, Emil Goode wrote: > This patch makes use of the new format specifier %pa that was introduced > by the following commit. > > 7d7992108d02aa92ad4c77e5d9ce14088c942e75 > ("lib/vsprintf.c: add %pa format specifier for phys_addr_t types") [] > diff --git a/drivers/usb

Re: [PATCH] usb: musb: use the new %pa format specifier for dma_addr_t

2013-06-01 Thread Emil Goode
I see, will send a second version. Thank's Emil On Sat, Jun 01, 2013 at 11:29:10AM -0700, Joe Perches wrote: > On Sat, 2013-06-01 at 20:02 +0200, Emil Goode wrote: > > This patch makes use of the new format specifier %pa that was introduced > > by the following commit. > > > > 7d7992108d02aa92

[PATCH v2] usb: musb: use the new %pa format specifier for dma_addr_t

2013-06-01 Thread Emil Goode
This patch makes use of the new format specifier %pa that was introduced by the following commit. 7d7992108d02aa92ad4c77e5d9ce14088c942e75 ("lib/vsprintf.c: add %pa format specifier for phys_addr_t types") The addition of urb->transfer_dma and urb->actual_length is also done a few lines below. I

Re: [PATCH] usb: musb: use the new %pa format specifier for dma_addr_t

2013-06-01 Thread Joe Perches
On Sat, 2013-06-01 at 21:09 +0200, Emil Goode wrote: > I see, will send a second version. Hey Emil. I believe you can not use %pa with a dma_addr_t because that could be a different size than a phy_addr_t. (the vsprintf cast and deref is to a phy_addr_t) The definitions are: (types.h) #ifdef C

[PATCH v8 0/9] Reorganize R8A7779/Marzen USB code

2013-06-01 Thread Sergei Shtylyov
Hello. Here's the set of 9 patches against the Simon Horman's 'renesas.git' repo, 'renesas-next-20130528' tag. It was created to fix the shortcomings in the R8A7779/Marzen USB platform code and R8A7779 USB common PHY driver, and so spans both arch/arm/mach-shmobile/ and drivers/usb/ subtrees (

[PATCH v8 1/9] ARM: shmobile: Marzen: move USB EHCI, OHCI, and PHY devices to R8A7779 code

2013-06-01 Thread Sergei Shtylyov
USB EHCI, OHCI, and common PHY are the SoC devices but are wrongly defined and registered in the Marzen board file. Move the data and code to their proper place in setup-r8a7779.c; while at it, we have to rename r8a7779_late_devices[] to r8a7779_standard_devices[] -- this seems legitimate since th

[PATCH v8 2/9] ehci-platform: add pre_setup() method to platform data

2013-06-01 Thread Sergei Shtylyov
Sometimes there is a need to initialize some non-standard registers mapped to the EHCI region before accessing the standard EHCI registers. Add pre_setup() method with 'struct usb_hcd *' parameter to be called just before ehci_setup() to the 'ehci-platform' driver's platform data for this purpos

[PATCH v8 3/9] ARM: shmobile: r8a7779: setup EHCI internal buffer

2013-06-01 Thread Sergei Shtylyov
Setup the EHCI internal buffer (before EHCI driver has a chance to touch the registers) using the pre_setup() method in 'struct usb_ehci_pdata'. The patch has been tested on the Marzen board. Signed-off-by: Sergei Shtylyov Acked-by: Kuninori Morimoto Acked-by: Simon Horman --- Changes since v

[PATCH v8 4/9] phy-rcar-usb: remove EHCI internal buffer setup

2013-06-01 Thread Sergei Shtylyov
Now that the EHCI internal buffer setup is done by the platform code, we can remove such code from this driver as it never really belonged here. We also no longer need the 2nd memory region now (2nd EHCI controller is simply missing in e.g. R8A7778 SoC). The patch has been tested on the Mar

[PATCH v8 5/9] ARM: shmobile: r8a7779: remove USB PHY 2nd memory resource

2013-06-01 Thread Sergei Shtylyov
Now that 'drivers/usb/phy/phy-rcar-usb.c' doesn't require the second memory resource anymore, we can remove it from the R8A7779's USB PHY platform device. Signed-off-by: Sergei Shtylyov Acked-by: Kuninori Morimoto Acked-by: Simon Horman --- Changes since version 7: - updated the driver file na

[PATCH v8 6/9] phy-rcar-usb: correct base address

2013-06-01 Thread Sergei Shtylyov
The memory region that is used by the driver overlaps EHCI and OHCI register regions for absolutely no reason now -- fix it by adding offset of 0x800 to the base address, changing the register #define's accordingly. This has extra positive effect that we now can use devm_ioremap_resource()... N

[PATCH v8 7/9] phy-rcar-usb: add platform data

2013-06-01 Thread Sergei Shtylyov
Currently the driver hard-codes USBPCTRL0 register to 0. It is wrong since this register contains board-specific USB ports configuration and so its value should be somehow passed via the platform data. Add the global header file containing 'struct rcar_phy_platform_data' consisting of the various

[PATCH v8 8/9] ARM: shmobile: Marzen: pass platform data to USB PHY device

2013-06-01 Thread Sergei Shtylyov
Since we're now going to setup the USBPCTRL0 register using the USB PHY device's platform data, we now need a way to pass those platform data from the board file to the device which is situated in setup-r8a7779.c -- and what I'm suggesting is r8a7779_add_usb_phy_device() that will register USB PHY

[PATCH v8 9/9] phy-rcar-usb: handle platform data

2013-06-01 Thread Sergei Shtylyov
Set the USBPCTRL0 register from the passed platform data in rcar_usb_phy_init(); don't reset it to 0 in rcar_usb_phy_shutdown() anymore as that does not make sense. Also, don't allow the driver's probe to succeed when the platform data are not supplied with a device. The patch has been tested o

Re: [PATCH] usb: musb: use the new %pa format specifier for dma_addr_t

2013-06-01 Thread Randy Dunlap
On 06/01/13 13:31, Joe Perches wrote: > On Sat, 2013-06-01 at 21:09 +0200, Emil Goode wrote: >> I see, will send a second version. > > Hey Emil. > > I believe you can not use %pa with a dma_addr_t > because that could be a different size than a > phy_addr_t. > > (the vsprintf cast and deref is t

[PATCH v8 0/3] Add USB support to R8A7778/BOCK-W

2013-06-01 Thread Sergei Shtylyov
Hello. Here's the set of 3 patches against the Simon Horman's 'renesas.git' repo, 'renesas-next-20130528' tag, and the R8A7779/Marzen USB patchset I've posted. It was created to add support of R8A7778/BOCK-W USB to the platform code and the USB common PHY driver, and so spans both arch/arm/mach

[PATCH v8 1/3] phy-rcar-usb: add R8A7778 support

2013-06-01 Thread Sergei Shtylyov
The driver currently only supports R8A7779 SoC. Compared to it, R8A7778 USB-PHY has extra register range containing two high-speed signal quality characteristic control registers which should be set up during USB-PHY startup depending on whether a ferrite bead is in use or not. So, we now handle

[PATCH v8 2/3] ARM: shmobile: r8a7778: add USB support

2013-06-01 Thread Sergei Shtylyov
Add USB clock and EHCI, OHCI, and USB PHY platform devices for R8A7778 SoC; add a function to register PHY device with board-specific platform data and register EHCI and OHCI platfrom devices from the init_late() board method. Also, don't forget to enable CONFIG_ARCH_HAS_[EO]HCI options for R8A7

[PATCH v8 3/3] ARM: shmobile: BOCK-W: add USB support

2013-06-01 Thread Sergei Shtylyov
Register the USB PHY device from bockw_init(), passing the platform data to it. Set machine's init_late() method to r8a7778_init_late() in order for [EO]HCI to get registered too... Don't forget to add USB PENC0/1 pins to bockw_pinctrl_map[]. The patch has been tested on the BOCK-W board. Signe

Re: [PATCH] usb: musb: use the new %pa format specifier for dma_addr_t

2013-06-01 Thread Joe Perches
On Sat, 2013-06-01 at 14:56 -0700, Randy Dunlap wrote: > It's a bit of a shame that this > comment was deleted from include/asm-generic/types.h in commit > 3e50594e8e72932ad4cfcb0b3cbdf58fc3bce416: > > -/* > - * DMA addresses may be very different from physical addresses > - * and pointers. i386 a

Re: [PATCH] usb: musb: Fix format specifier warning

2013-06-01 Thread Andy Shevchenko
On Sat, Jun 1, 2013 at 8:11 PM, Emil Goode wrote: > Thank's for your pointers. > I will send a patch that applies on top of Felipe's patch. I guess there is not much sense to do that since Felipe applied your patch already. Just keep in mind the hint for future changes. -- With Best Regards, And

Re: [PATCH] usb: musb: use the new %pa format specifier for dma_addr_t

2013-06-01 Thread Emil Goode
Hello Joe and Randy, Maybe there should be another format specifier %da and Randy's clarifying comment can be added there to the documentation? Best regards, Emil Goode On Sat, Jun 01, 2013 at 03:16:00PM -0700, Joe Perches wrote: > On Sat, 2013-06-01 at 14:56 -0700, Randy Dunlap wrote: > > It's

Re: [PATCH] usb: musb: use the new %pa format specifier for dma_addr_t

2013-06-01 Thread Joe Perches
On Sun, 2013-06-02 at 01:06 +0200, Emil Goode wrote: > Maybe there should be another format specifier %da and Randy's > clarifying comment maybe %pad but I think the whole thing isn't much necessary. It seems there are a grand total of 3 uses of %pa today. Maybe: --- Documentation/printk-formats