Re: [PATCH 0/5] of_platform_driver and OF_DEVICE removal

2013-04-22 Thread Arnd Bergmann
On Monday 22 April 2013, Rob Herring wrote: > From: Rob Herring > > This series is a relatively straight-forward removal of the last remaining > user of of_platform_driver (ibmebus) and removal of CONFIG_OF_DEVICE which > is always enabled when CONFIG_OF is enabled. > > Compile tested on powerpc

Re: Creating a new xhci-hcd platform device

2013-04-22 Thread yehuda yitchak
Hello everyone I want to ask your advice on the best approach for implementing a new XHCI host controller. I am going to add Linux support for a new XHCI host controller for Marvell SOCs. I looked around the latest XHCI support code in the kernel and found that a platform driver called “xhci-hcd”

Re: Creating a new xhci-hcd platform device

2013-04-22 Thread Felipe Balbi
Hi, On Mon, Apr 22, 2013 at 10:18:20AM +0300, yehuda yitchak wrote: > Hello everyone > > I want to ask your advice on the best approach for implementing a new > XHCI host controller. > I am going to add Linux support for a new XHCI host controller for Marvell > SOCs. > > I looked around the lat

Re: Creating a new xhci-hcd platform device

2013-04-22 Thread yehuda yitchak
On Mon, Apr 22, 2013 at 10:48 AM, Felipe Balbi wrote: > Hi, > > On Mon, Apr 22, 2013 at 10:18:20AM +0300, yehuda yitchak wrote: >> Hello everyone >> >> I want to ask your advice on the best approach for implementing a new >> XHCI host controller. >> I am going to add Linux support for a new XHCI h

Re: Creating a new xhci-hcd platform device

2013-04-22 Thread Felipe Balbi
HI, On Mon, Apr 22, 2013 at 11:17:25AM +0300, yehuda yitchak wrote: > >> I want to ask your advice on the best approach for implementing a new > >> XHCI host controller. > >> I am going to add Linux support for a new XHCI host controller for Marvell > >> SOCs. > >> > >> I looked around the latest

Re: Creating a new xhci-hcd platform device

2013-04-22 Thread Ben Dooks
If the code is small, then I don't see any problem with adding it directly to the xhci-plat.c driver (or in this case you'll probably need an xhci-of binding as well) I was wondering if the marvell system supports a more generic way of attaching devices which have these bus window mappings on them

Re: Creating a new xhci-hcd platform device

2013-04-22 Thread yehuda yitchak
On Mon, Apr 22, 2013 at 11:30 AM, Felipe Balbi wrote: > HI, > > On Mon, Apr 22, 2013 at 11:17:25AM +0300, yehuda yitchak wrote: >> >> I want to ask your advice on the best approach for implementing a new >> >> XHCI host controller. >> >> I am going to add Linux support for a new XHCI host controll

Re: Creating a new xhci-hcd platform device

2013-04-22 Thread yehuda yitchak
On Mon, Apr 22, 2013 at 11:54 AM, Ben Dooks wrote: > If the code is small, then I don't see any problem with adding it directly > to the xhci-plat.c driver (or in this case you'll probably need an xhci-of > binding as well) im not sure it is small. you can look at drivers/dma/mv_xor.c function "mv

Re: Creating a new xhci-hcd platform device

2013-04-22 Thread Felipe Balbi
Hi, On Mon, Apr 22, 2013 at 11:54:34AM +0300, yehuda yitchak wrote: > >> >> I want to ask your advice on the best approach for implementing a new > >> >> XHCI host controller. > >> >> I am going to add Linux support for a new XHCI host controller for > >> >> Marvell SOCs. > >> >> > >> >> I looked

Re: Creating a new xhci-hcd platform device

2013-04-22 Thread yehuda yitchak
On Mon, Apr 22, 2013 at 12:13 PM, Felipe Balbi wrote: > Hi, > > On Mon, Apr 22, 2013 at 11:54:34AM +0300, yehuda yitchak wrote: >> >> >> I want to ask your advice on the best approach for implementing a new >> >> >> XHCI host controller. >> >> >> I am going to add Linux support for a new XHCI host

How to safe recover USB driver from broken hardware situation

2013-04-22 Thread Peter Chen
Hi all, Recently, I have several customers troubled in safe recover USB function during the ESD situation (or some other situations, like short dp/dm, ground dp/dm, etc). I designed the ESD detect and recovery process, but I met some sync problems between host controller driver (eg, ehci) and cla

Fwd: cdc_acm buffer allocation out of memory

2013-04-22 Thread Jan Pohanka
Dear all, I'm getting following message from cdc_acm driver when plugging in my GSM module on Amlogic 8726-MXS platform (kernel v3.0.8): cdc_acm 1-1:1.4: ttyACM2: USB ACM device [ 26.730474@0] cdc_acm 1-1:1.6: This device cannot do calls on its own. It is not a modem. [ 26.733206@0] cdc_acm 1-1:1

Re: cdc_acm buffer allocation out of memory

2013-04-22 Thread Daniele Palmas
Hello, 2013/4/22 Jan Pohanka : > Dear all, > > I'm getting following message from cdc_acm driver when plugging in my > GSM module on Amlogic 8726-MXS platform (kernel v3.0.8): > > cdc_acm 1-1:1.4: ttyACM2: USB ACM device > [ 26.730474@0] cdc_acm 1-1:1.6: This device cannot do calls on its > own. I

Re: [PATCH v5 1/9] ARM: shmobile: Marzen: move USB EHCI, OHCI, and PHY devices to R8A7779 code

2013-04-22 Thread Sergei Shtylyov
Hello. On 22-04-2013 5:09, Simon Horman wrote: USB EHCI, OHCI, and common PHY are the SoC devices but are wrongly defined and registered in the Marzen board file. Move the data and code to their proper place in setup-r8a7779.c; while at it, we have to rename 8a7779_late_devices[] to 8a7779_sta

Re: Linux USB file storage gadget with new UDC

2013-04-22 Thread Alan Stern
On Mon, 22 Apr 2013, victor yeo wrote: > Here is a full log from the beginning which shows another problem. > When the SCSI_READ_10 command below is received, there is a disconnect > or port reset which causes the (-32) broken pipe problem. You really need to fix the old problems before worrying

Re: [PATCH v5 0/9] Reorganize R8A7779/Marzen USB code

2013-04-22 Thread Russell King - ARM Linux
On Sat, Apr 20, 2013 at 01:55:12AM +0400, Sergei Shtylyov wrote: > Hello. > >Here's the set of 9 patches against the Simon Horman's 'renesas.git' repo, > 'renesas-next-20130419' tag. It was created to fix the shortcomings in the > R8A7779/Marzen USB platform code and R8A7779 USB common PHY dr

Re: How to safe recover USB driver from broken hardware situation

2013-04-22 Thread Alan Stern
On Mon, 22 Apr 2013, Peter Chen wrote: > Hi all, > > Recently, I have several customers troubled in safe recover USB > function during the ESD situation (or some other situations, like > short dp/dm, ground dp/dm, etc). > > I designed the ESD detect and recovery process, but I met some > sync pr

Re: BUG: USB audio discontinuities with 'UHCI: implement new semantics for URB_ISO_ASAP'

2013-04-22 Thread Alan Stern
On Fri, 19 Apr 2013, Joe Rayhawk wrote: > On Fri, Apr 19, 2013 at 02:18:24PM -0400, Alan Stern wrote: > > On Fri, 19 Apr 2013, Clemens Ladisch wrote: > > > Alan Stern wrote: > > > > + next = uhci->frame_number + 2; > > > > > > > > That 2 is the minimum latency, in frames (one frame p

Re: [PATCH] More initconst in ehci driver

2013-04-22 Thread Alan Stern
On Sat, 20 Apr 2013, Andi Kleen wrote: > From: Andi Kleen > > Signed-off-by: Andi Kleen > > diff --git a/drivers/usb/host/ehci-platform.c > b/drivers/usb/host/ehci-platform.c > index ca75063..6a18f11 100644 > --- a/drivers/usb/host/ehci-platform.c > +++ b/drivers/usb/host/ehci-platform.c > @@

Re: cdc_acm buffer allocation out of memory

2013-04-22 Thread Jan Pohanka
You were right, thank you very much. regards Jan 2013/4/22 Daniele Palmas : > Hello, > > 2013/4/22 Jan Pohanka : >> Dear all, >> >> I'm getting following message from cdc_acm driver when plugging in my >> GSM module on Amlogic 8726-MXS platform (kernel v3.0.8): >> >> cdc_acm 1-1:1.4: ttyACM2: USB

[PATCH] Fix initconst in ehci driver

2013-04-22 Thread Andi Kleen
From: Andi Kleen Signed-off-by: Andi Kleen diff --git a/drivers/usb/host/ehci-mxc.c b/drivers/usb/host/ehci-mxc.c index e9301fb..0a2efca 100644 --- a/drivers/usb/host/ehci-mxc.c +++ b/drivers/usb/host/ehci-mxc.c @@ -47,7 +47,7 @@ struct ehci_mxc_priv { static struct hc_driver __read_mostly e

Re: [PATCH] Fix initconst in ehci driver

2013-04-22 Thread Alan Stern
On Mon, 22 Apr 2013, Andi Kleen wrote: > From: Andi Kleen > > Signed-off-by: Andi Kleen > > diff --git a/drivers/usb/host/ehci-mxc.c b/drivers/usb/host/ehci-mxc.c > diff --git a/drivers/usb/host/ehci-pci.c b/drivers/usb/host/ehci-pci.c > diff --git a/drivers/usb/host/ehci-platform.c > b/dri

Re: [PATCH v2] usb: ehci-s5p: fix: Fix null pointer dereferencing

2013-04-22 Thread Kukjin Kim
On 04/09/13 22:12, Vivek Gautam wrote: 7edb3da: (USB: EHCI: make ehci-s5p a separate driver) raised an issue with ehci-s5p's driver data. Now that 's5p_ehci_hcd' doesn't maintain pointer to 'usb_hcd' and s5p_ehci is nothing but a pointer to hcd->priv; add hcd to the driver data rather than s5p_eh

Re: [PATCH] Fix initconst in ehci driver

2013-04-22 Thread Andi Kleen
On Mon, Apr 22, 2013 at 01:16:11PM -0400, Alan Stern wrote: > On Mon, 22 Apr 2013, Andi Kleen wrote: > > > From: Andi Kleen > > > > Signed-off-by: Andi Kleen > > > > diff --git a/drivers/usb/host/ehci-mxc.c b/drivers/usb/host/ehci-mxc.c > > > diff --git a/drivers/usb/host/ehci-pci.c b/drivers

Re: [PATCH] Fix initconst in ehci driver

2013-04-22 Thread Alan Stern
On Mon, 22 Apr 2013, Andi Kleen wrote: > On Mon, Apr 22, 2013 at 01:16:11PM -0400, Alan Stern wrote: > > On Mon, 22 Apr 2013, Andi Kleen wrote: > > > > > From: Andi Kleen > > > > > > Signed-off-by: Andi Kleen > > > > > > diff --git a/drivers/usb/host/ehci-mxc.c b/drivers/usb/host/ehci-mxc.c >

Re: [PATCH v5 0/9] Reorganize R8A7779/Marzen USB code

2013-04-22 Thread Sergei Shtylyov
Hello. Hello. On 04/22/2013 06:51 PM, Russell King - ARM Linux wrote: Hello. Here's the set of 9 patches against the Simon Horman's 'renesas.git' repo, 'renesas-next-20130419' tag. It was created to fix the shortcomings in the R8A7779/Marzen USB platform code and R8A7779 USB common PHY

Re: [PATCH] Fix initconst in ehci driver

2013-04-22 Thread Andi Kleen
> What do you mean? Take a look at ehci-msm.c, for example, starting > around line 198: Maybe you changed it recently. It's not in 3.8-rc* My LTO tree is only based on 3.8 at this point, not linux-next. -Andi > > static const struct ehci_driver_overrides msm_overrides __initdata = { > .r

Re: [RFT] xhci - correct comp_mode_recovery_timer on return from hibernate

2013-04-22 Thread Tony Camuso
On 04/18/2013 05:12 PM, Sarah Sharp wrote: On Thu, Apr 18, 2013 at 02:45:40PM -0400, Tony Camuso wrote: Sarah, This patch works with RHEL6.4+ kernel, but hangs with 3.9-rc7. I can attach the S3_Suspend_message.log, if you like, but here are the last few lines. Is it hanging on suspend or on

Re: [PATCH] Fix initconst in ehci driver

2013-04-22 Thread Alan Stern
On Mon, 22 Apr 2013, Andi Kleen wrote: > > What do you mean? Take a look at ehci-msm.c, for example, starting > > around line 198: > > Maybe you changed it recently. It's not in 3.8-rc* > My LTO tree is only based on 3.8 at this point, not linux-next. Ah -- that's right, and it's why I specifie

Re: [PATCH V2] usb: storage: Convert US_DEBUGP to usb_stor_dbg

2013-04-22 Thread David Rientjes
On Fri, 19 Apr 2013, Joe Perches wrote: > @@ -966,11 +934,13 @@ static int realtek_cr_autosuspend_setup(struct us_data > *us) > static void realtek_cr_destructor(void *extra) > { > struct rts51x_chip *chip = (struct rts51x_chip *)extra; > - > - US_DEBUGP("%s: <---\n", __func__); > +

[PATCH 0/4] staging: dwc2: a few patches for dwc2 driver

2013-04-22 Thread Paul Zimmerman
Hi Greg, Here are a few patches for the dwc2 driver. The first three are some minor fixes/cleanups, and the last is a new platform device driver interface from Matthijs. Please apply. -- Paul Matthijs Kooijman (1): staging: dwc2: add platform device bindings Paul Zimmerman (3): staging: dw

[PATCH 1/4] staging: dwc2: fix potential null pointer access

2013-04-22 Thread Paul Zimmerman
We were testing hsotg pointer for null after we had already dereferenced it Reported-by: Fengguang Wu Signed-off-by: Paul Zimmerman --- drivers/staging/dwc2/hcd_ddma.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/dwc2/hcd_ddma.c b/drivers/stagin

[PATCH 2/4] staging: dwc2: add missing newlines to debug messages

2013-04-22 Thread Paul Zimmerman
A few debug messages were missing newlines, add them Signed-off-by: Paul Zimmerman --- drivers/staging/dwc2/core_intr.c | 2 +- drivers/staging/dwc2/hcd.c | 4 ++-- drivers/staging/dwc2/hcd_ddma.c | 6 +++--- drivers/staging/dwc2/hcd_intr.c | 2 +- 4 files changed, 7 insertions(+), 7 del

[PATCH 3/4] staging: dwc2: check for null pointer before dereferencing it

2013-04-22 Thread Paul Zimmerman
We were testing qtd->urb pointer for null after we had already dereferenced it Reported-by: Dan Carpenter Signed-off-by: Paul Zimmerman --- drivers/staging/dwc2/hcd_intr.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/staging/dwc2/hcd_intr.c b/drivers/s

[PATCH 4/4] staging: dwc2: add platform device bindings

2013-04-22 Thread Paul Zimmerman
From: Matthijs Kooijman This adds a dwc_platform.ko module that can be loaded by using compatible = "snps,dwc2" in a device tree. Signed-off-by: Matthijs Kooijman Signed-off-by: Paul Zimmerman --- Documentation/devicetree/bindings/staging/dwc2.txt | 15 +++ drivers/staging/dwc2/Kconfig

Re: How to safe recover USB driver from broken hardware situation

2013-04-22 Thread Peter Chen
On Mon, Apr 22, 2013 at 11:26:05AM -0400, Alan Stern wrote: > On Mon, 22 Apr 2013, Peter Chen wrote: > > > Hi all, > > > > Recently, I have several customers troubled in safe recover USB > > function during the ESD situation (or some other situations, like > > short dp/dm, ground dp/dm, etc). > >

Re: [PATCH v5 1/9] ARM: shmobile: Marzen: move USB EHCI, OHCI, and PHY devices to R8A7779 code

2013-04-22 Thread Simon Horman
On Mon, Apr 22, 2013 at 05:34:05PM +0400, Sergei Shtylyov wrote: > Hello. > > On 22-04-2013 5:09, Simon Horman wrote: > > >>>USB EHCI, OHCI, and common PHY are the SoC devices but are wrongly defined > >>>and > >>>registered in the Marzen board file. Move the data and code to their > >>>proper