Re: [PATCH] drivers: usb: chipidea: convert to devm_ioremap_resource()

Silviu-Mihai Popescu writes: > Convert use of devm_request_and_ioremap() to the newly introduced > devm_ioremap_resource() which provides more consistent error handling. You mean, you've run coccinelle? Remember to mention it, then. > devm_ioremap_resource() provides its own error messages so

Re: [PATCH] drivers: usb: chipidea: convert to devm_ioremap_resource()

On Thu, Apr 11, 2013 at 10:12 AM, Alexander Shishkin wrote: > That's cool, but your chipidea patches have to be based off of > ci-for-greg branch of the chipidea tree [1] or at least usb-next branch > of Greg's usb.git [2]. > > [1] git://github.com/virtuoso/linux-ci.git > [2] git://git.kernel.org/

Re: [RFC][PATCH 1/2] ARM: OMAP4: clock: Add device tree support for AUXCLKs

On 04/10/2013 08:39 PM, Nishanth Menon wrote: > On 13:55-20130410, Roger Quadros wrote: >> On 04/10/2013 11:06 AM, Mike Turquette wrote: >>> Quoting Nishanth Menon (2013-04-09 13:49:00) On 10:43-20130409, Tony Lindgren wrote: > * Tony Lindgren [130409 09:54]: >> * Roger Quadros [1304

Re: [Libusbx-devel] libusbx v1.0.15-rc2 is now available for testing

thanx! ++ nicolas Le 10/04/13 02:44, Pete Batard a écrit : On 2013.04.09 11:39, nico wrote: can someone provide a MinGW 32bits built of the last working RC, Sure. Please have a look at the -win download from: https://sourceforge.net/projects/libusbx/files/releases/1.0.15/binaries/ The Windows

Re: [PATCH 1/2 v5] usbnet: allow status interrupt URB to always be active

Oliver Neukum writes: > On Thursday 11 April 2013 10:31:31 Ming Lei wrote: > >> 'mem_flags' isn't needed any more since we can apply allocation >> of GFP_NOIO automatically in resume path now, and you can always >> use GFP_KERNEL safely. Considered that it is a API, please don't >> introduce it.

Re: [PATCH 1/2 v5] usbnet: allow status interrupt URB to always be active

On Thu, Apr 11, 2013 at 2:50 PM, Oliver Neukum wrote: > On Thursday 11 April 2013 10:31:31 Ming Lei wrote: > >> 'mem_flags' isn't needed any more since we can apply allocation >> of GFP_NOIO automatically in resume path now, and you can always >> use GFP_KERNEL safely. Considered that it is a API,

Re: [PATCH 1/2 v5] usbnet: allow status interrupt URB to always be active

On Thu, Apr 11, 2013 at 4:06 PM, Bjørn Mork wrote: > Oliver Neukum writes: > > My immediate thought was that someone also might want to use this new > API from atomic context, e.g. calling it directly from an URB callback. I am wondering it is a valid use case, and if there is one URB submitted,

Re: [RFC][PATCH 1/2] ARM: OMAP4: clock: Add device tree support for AUXCLKs

On 04/11/2013 10:48 AM, Roger Quadros wrote: On 04/10/2013 08:39 PM, Nishanth Menon wrote: On 13:55-20130410, Roger Quadros wrote: On 04/10/2013 11:06 AM, Mike Turquette wrote: Quoting Nishanth Menon (2013-04-09 13:49:00) On 10:43-20130409, Tony Lindgren wrote: * Tony Lindgren [130409 09:54

Re: Linux USB file storage gadget with new UDC

Hi, >> I use kernel 3.4.4, the code in handle_stat1_irqs() is as below. There >> is no reset or disconnect member function in "struct >> usb_gadget_driver" in kernel 3.4.4. >> >> if (stat & (1 << SUSPEND_REQUEST_INTERRUPT)) { >> if (dev->driver->suspend) >>

[PATCH 1/1] usb: gadget/uvc: Add support for Bulk endpoint to be used as Video Streaming ep

This patch adds the support for Bulk endpoint to be used as video streaming endpoint, on basis of a module parameter. By default, the gadget still supports Isochronous endpoint for video streaming, but if the module parameter 'bulk_streaming_ep' is set to 1, we can support Bulk endpoint as well, w

[PATCH] USB: ehci-omap: Select USB_PHY

Hi Greg, The following patch gets rid of Kbuild warnings when USB_EHCI_HCD_OMAP is enabled. Patch is based on your usb-next branch and is needed for 3.10. From: Roger Quadros Date: Thu, 11 Apr 2013 12:08:19 +0300 Subject: [PATCH] USB: ehci-omap: Select USB_PHY As we need NOP_USB_XCEIV which de

Re: [PATCH 1/2 v5] usbnet: allow status interrupt URB to always be active

On Thursday 11 April 2013 16:09:16 Ming Lei wrote: > On Thu, Apr 11, 2013 at 2:50 PM, Oliver Neukum wrote: > > On Thursday 11 April 2013 10:31:31 Ming Lei wrote: > > > >> 'mem_flags' isn't needed any more since we can apply allocation > >> of GFP_NOIO automatically in resume path now, and you can

Re: [PATCH 1/2 v5] usbnet: allow status interrupt URB to always be active

On Thursday 11 April 2013 16:37:53 Ming Lei wrote: > On Thu, Apr 11, 2013 at 4:06 PM, Bjørn Mork wrote: > > Oliver Neukum writes: > > > > My immediate thought was that someone also might want to use this new > > API from atomic context, e.g. calling it directly from an URB callback. > > I am won

Re: [PATCH 1/2 v5] usbnet: allow status interrupt URB to always be active

On Thu, Apr 11, 2013 at 5:53 PM, Oliver Neukum wrote: > On Thursday 11 April 2013 16:09:16 Ming Lei wrote: >> >> Could you explain why work queue need GFP_NOIO? > > Your fix for the memory allocation depends on it happening in the same > context. If you execute code on a work queue this happens in

Re: [PATCH 1/2 v5] usbnet: allow status interrupt URB to always be active

Ming Lei writes: > On Thu, Apr 11, 2013 at 4:06 PM, Bjørn Mork wrote: >> Oliver Neukum writes: >> >> My immediate thought was that someone also might want to use this new >> API from atomic context, e.g. calling it directly from an URB callback. > > I am wondering it is a valid use case, and if

Re: [PATCH] USB: ehci-omap: Select USB_PHY

Hi, On Thu, Apr 11, 2013 at 12:42:04PM +0300, Roger Quadros wrote: > Hi Greg, > > The following patch gets rid of Kbuild warnings when USB_EHCI_HCD_OMAP > is enabled. > > Patch is based on your usb-next branch and is needed for 3.10. > > From: Roger Quadros > Date: Thu, 11 Apr 2013 12:08:19 +0

Re: [PATCH 1/2 v5] usbnet: allow status interrupt URB to always be active

On Thu, Apr 11, 2013 at 6:04 PM, Bjørn Mork wrote: > Ming Lei writes: > > I think you are turning this the wrong way around. Please explain why > there are no use cases where different flags are needed. You seem to be > only concerned about the resume case. This API is not limited to > resuming.

Re: [PATCH 1/2 v5] usbnet: allow status interrupt URB to always be active

On Thu, Apr 11, 2013 at 6:04 PM, Bjørn Mork wrote: > Ming Lei writes: > > Again: What problem are you attempting to solve by removing the > mem_flags from the API? It is not about removing anything, we are discussing one new API (include the parameters) to be introduced. Thanks, -- Ming Lei --

Re: [PATCH 1/2 v5] usbnet: allow status interrupt URB to always be active

Ming Lei writes: > On Thu, Apr 11, 2013 at 6:04 PM, Bjørn Mork wrote: >> Ming Lei writes: >> >> Again: What problem are you attempting to solve by removing the >> mem_flags from the API? > > It is not about removing anything, we are discussing one new API > (include the parameters) to be introd

Re: [PATCH 1/2 v5] usbnet: allow status interrupt URB to always be active

On Thu, Apr 11, 2013 at 6:26 PM, Bjørn Mork wrote: > Ming Lei writes: > >> On Thu, Apr 11, 2013 at 6:04 PM, Bjørn Mork wrote: >>> Ming Lei writes: >>> >>> Again: What problem are you attempting to solve by removing the >>> mem_flags from the API? >> >> It is not about removing anything, we are

Re: [PATCH] USB: ehci-omap: Select USB_PHY

On 04/11/2013 01:04 PM, Felipe Balbi wrote: > Hi, > > On Thu, Apr 11, 2013 at 12:42:04PM +0300, Roger Quadros wrote: >> Hi Greg, >> >> The following patch gets rid of Kbuild warnings when USB_EHCI_HCD_OMAP >> is enabled. >> >> Patch is based on your usb-next branch and is needed for 3.10. >> >> Fr

Re: [PATCH] USB: ehci-omap: Select USB_PHY

Hi, On Thu, Apr 11, 2013 at 01:51:16PM +0300, Roger Quadros wrote: > On 04/11/2013 01:04 PM, Felipe Balbi wrote: > > Hi, > > > > On Thu, Apr 11, 2013 at 12:42:04PM +0300, Roger Quadros wrote: > >> Hi Greg, > >> > >> The following patch gets rid of Kbuild warnings when USB_EHCI_HCD_OMAP > >> is en

Re: [PATCH 1/2 v5] usbnet: allow status interrupt URB to always be active

Ming Lei writes: > OK, I say it again, GFP_KERNEL is enough to cover all cases, and the > mem_flags parameter is redundant. The docs for usb_submit_urb() in drivers/usb/core/urb.c lists some possible mem_flags use cases. Among these are (where (b) and (c) are cases needing GFP_ATOMIC and not app

Re: [PATCH 1/2 v5] usbnet: allow status interrupt URB to always be active

On Thursday 11 April 2013 18:03:09 Ming Lei wrote: > On Thu, Apr 11, 2013 at 5:53 PM, Oliver Neukum wrote: > > On Thursday 11 April 2013 16:09:16 Ming Lei wrote: > >> > >> Could you explain why work queue need GFP_NOIO? > > > > Your fix for the memory allocation depends on it happening in the same

[PATCH] usb: ehci-s5p: skip phy setup for Exynos5440 based platforms

Exynos5440 does not require any explict USB phy configuration. So skip the USB phy configuration for Exynos5440 based platforms. Signed-off-by: Thomas Abraham --- drivers/usb/host/ehci-s5p.c | 11 +-- 1 files changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/ehci-

[PATCH] usb: ohci-exynos: skip phy setup for Exynos5440 based platforms

Exynos5440 does not require any explict USB phy configuration. So skip the USB phy configuration for Exynos5440 based platforms. Signed-off-by: Thomas Abraham --- drivers/usb/host/ohci-exynos.c | 11 +-- 1 files changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/oh

Re: [PATCH 1/2 v5] usbnet: allow status interrupt URB to always be active

On Thu, Apr 11, 2013 at 7:08 PM, Bjørn Mork wrote: > > The docs for usb_submit_urb() in drivers/usb/core/urb.c lists some > possible mem_flags use cases. Among these are (where (b) and (c) are > cases needing GFP_ATOMIC and not applicable here): > > > * (3) If you use a kernel thread with a net

Re: [PATCH 1/2 v5] usbnet: allow status interrupt URB to always be active

On Thursday 11 April 2013 19:42:53 Ming Lei wrote: > On Thu, Apr 11, 2013 at 7:08 PM, Bjørn Mork wrote: > > > > The docs for usb_submit_urb() in drivers/usb/core/urb.c lists some > > possible mem_flags use cases. Among these are (where (b) and (c) are > > cases needing GFP_ATOMIC and not applicabl

Re: [PATCH v3 0/9] Reorganize R8A7779/Marzen USB code

Hello. On 11-04-2013 4:51, Simon Horman wrote: Here's the set of 9 patches against the Simon Horman's 'renesas.git' repo, 'renesas-next-20130410' tag. It was created to fix the shortcomings in the R8A7779/Marzen USB platform code and R8A7779 USB common PHY driver, and so spans both arch/ar

Re: [PATCH v3 0/9] Reorganize R8A7779/Marzen USB code

Hi, On Thu, Apr 11, 2013 at 04:02:33PM +0400, Sergei Shtylyov wrote: > Hello. > > On 11-04-2013 4:51, Simon Horman wrote: > > >Here's the set of 9 patches against the Simon Horman's 'renesas.git' > > repo, > >'renesas-next-20130410' tag. It was created to fix the shortcomings i

Re: [PATCH 1/2 v5] usbnet: allow status interrupt URB to always be active

On Thu, Apr 11, 2013 at 7:14 PM, Oliver Neukum wrote: > > Sorry, I misunderstood. No problem, :-) > > Task A Task B queue > > queue work > request a reset >

Re: [PATCH 1/2 v5] usbnet: allow status interrupt URB to always be active

On Thu, Apr 11, 2013 at 7:54 PM, Oliver Neukum wrote: >> > Is this example >> > a) wrong, or >> > b) not applicable, or >> > c) to be excluded from the new API? >> >> IMO, it may be a) or b), and we can find many GFP_KERNEL usage >> inside usbnet(kevent(), ...). > > Only in the rx path. So it

Re: [PATCH v3 0/9] Reorganize R8A7779/Marzen USB code

Hello. On 11-04-2013 16:06, Felipe Balbi wrote: Here's the set of 9 patches against the Simon Horman's 'renesas.git' repo, 'renesas-next-20130410' tag. It was created to fix the shortcomings in the R8A7779/Marzen USB platform code and R8A7779 USB common PHY driver, and so spans both arch/a

Re: [PATCH 1/2 v5] usbnet: allow status interrupt URB to always be active

On Thursday 11 April 2013 20:11:13 Ming Lei wrote: > On Thu, Apr 11, 2013 at 7:14 PM, Oliver Neukum wrote: > > > > Sorry, I misunderstood. > > No problem, :-) > > > > > Task A Task B > > queue > > > > queue work > >

[PATCH 0/9] Equivalent of g_ncm.ko with configfs

Here I present the conversion of everthing that is required to provide the equivalent of g_ncm.ko with configfs. A branch will be available here (from 11th April 2013, afternoon UTC): git://git.infradead.org/users/kmpark/linux-samsung usb-gadget-configfs @Felipe: The branch name is now corrected

[PATCH 2/9] usb/gadget: rndis: convert into module

In order to convert to configfs the usb functions need to be converted to a new interface and compiled as modules. This patch creates an rndis module which will be used by the new functions. After all users of f_rndis are converted to the new interface, this module can be merged with f_rndis module

[PATCH 1/9] usb/gadget: u_ether: convert into module

u_ether.c has been #include'd by all gadgets which implement USB Ethernet functions. In order to add configfs support, the f_ecm.c, f_eem.c, f_ncm.c, f_subset.c, f_rndis.c need to be converted into modules and must not be #include'd. Consequently, the u_ether.c needs to be a module too, in a manner

[PATCH 4/9] usb/gadget: u_ether: construct with default values and add setters/getters

When configfs support is added it will be possible to add an unconfigured interface to the system. This patch adds an interface to u_ether which makes it possible to create a struct eth_dev filled with default values, an interface which makes it possible to fill the struct with useful values, and a

[PATCH 7/9] usb/gadget: f_ncm: remove compatibility layer

There are no old function interface users left, so the old interface can be removed. Signed-off-by: Andrzej Pietrasiewicz Signed-off-by: Kyungmin Park --- drivers/usb/gadget/f_ncm.c | 80 -- drivers/usb/gadget/u_ether.h |2 - 2 files changed, 0 in

[PATCH 8/9] usb/gadget: f_ncm: use usb_gstrings_attach

Signed-off-by: Andrzej Pietrasiewicz Signed-off-by: Kyungmin Park --- drivers/usb/gadget/f_ncm.c | 26 ++ 1 files changed, 10 insertions(+), 16 deletions(-) diff --git a/drivers/usb/gadget/f_ncm.c b/drivers/usb/gadget/f_ncm.c index 21ba578..0198f60 100644 --- a/drivers

[PATCH 3/9] usb/gadget: change sysfs parent device for USB Ethernet

This adds a new sysfs root device to serve as a replacement for devices which are available only when a gadget is being bound. It is motivated by adding configfs support to USB Ethernet functions. When configfs is there, we would like to be able to mkdir some function directory, e.g.: $ mkdir fun

[PATCH 9/9] usb/gadget: f_ncm: add configfs support

Signed-off-by: Andrzej Pietrasiewicz Signed-off-by: Kyungmin Park --- drivers/usb/gadget/f_ncm.c | 162 +++- drivers/usb/gadget/u_ncm.h |9 +++ 2 files changed, 170 insertions(+), 1 deletions(-) diff --git a/drivers/usb/gadget/f_ncm.c b/drivers/usb/g

[PATCH 6/9] usb/gadget: ncm: convert to new function interface

Signed-off-by: Andrzej Pietrasiewicz Signed-off-by: Kyungmin Park --- drivers/usb/gadget/Kconfig |1 + drivers/usb/gadget/ncm.c | 57 +++- 2 files changed, 36 insertions(+), 22 deletions(-) diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gad

[PATCH 5/9] usb/gadget: f_ncm: convert to new function interface with backward compatibility

Converting ncm to the new function interface requires converting the USB ncm's function code and its users. This patch converts the f_ncm.c to the new function interface. The file is now compiled into a separate usb_f_ncm.ko module. The old function interface is provided by means of a preprocessor

Re: [PATCH] USB: ehci-omap: Select USB_PHY

On 04/11/2013 01:55 PM, Felipe Balbi wrote: > Hi, > > On Thu, Apr 11, 2013 at 01:51:16PM +0300, Roger Quadros wrote: >> On 04/11/2013 01:04 PM, Felipe Balbi wrote: >>> Hi, >>> >>> On Thu, Apr 11, 2013 at 12:42:04PM +0300, Roger Quadros wrote: Hi Greg, The following patch gets rid of

Re: [PATCH 1/2 v5] usbnet: allow status interrupt URB to always be active

On Thu, Apr 11, 2013 at 8:28 PM, Oliver Neukum wrote: > On Thursday 11 April 2013 20:11:13 Ming Lei wrote: >> On Thu, Apr 11, 2013 at 7:14 PM, Oliver Neukum wrote: >> > >> > Sorry, I misunderstood. >> >> No problem, :-) >> >> > >> > Task A Task B

Re: [PATCH] USB: ehci-omap: Select USB_PHY

Am 11.04.2013 14:42, schrieb Roger Quadros: > On 04/11/2013 01:55 PM, Felipe Balbi wrote: >> I would avoid 'select' completely and just update omap2plus_defconfig >> adding those two as modules. >> > > OK, makes sense. I will update the patch to remove "select NOP_USB_XCEIV". Sorry, but this jus

[PATCH] usb-serial: add support for USB Wishbone-serial adapters

Wishbone is an open hardware SoC bus commonly used in FPGA designs. Bus access can be serialized using the Etherbone protocol . This driver is intended to be used with devices which attach their internal Wishbone bus to a USB serial interface using the

Re: [PATCH] USB: ehci-omap: Select USB_PHY

On 04/11/2013 03:42 PM, Roger Quadros wrote: > On 04/11/2013 01:55 PM, Felipe Balbi wrote: >> Hi, >> >> On Thu, Apr 11, 2013 at 01:51:16PM +0300, Roger Quadros wrote: >>> On 04/11/2013 01:04 PM, Felipe Balbi wrote: Hi, On Thu, Apr 11, 2013 at 12:42:04PM +0300, Roger Quadros wrote: >>

Re: [Libusbx-devel] libusbx v1.0.15-rc2 is now available for testing

Hi, is there is any windows Vista32 restriction? ++ Nicolas Le 11/04/13 09:53, nico a écrit : thanx! ++ nicolas Le 10/04/13 02:44, Pete Batard a écrit : On 2013.04.09 11:39, nico wrote: can someone provide a MinGW 32bits built of the last working RC, Sure. Please have a look at the -win downl

[PATCH 09/26] goku_udc: Don't use create_proc_read_entry() [RFC]

Don't use create_proc_read_entry() as that is deprecated, but rather use proc_create_data() and seq_file instead. Signed-off-by: David Howells cc: Felipe Balbi cc: Greg Kroah-Hartman cc: linux-usb@vger.kernel.org --- drivers/usb/gadget/goku_udc.c | 89 ++-

[PATCH 10/26] fsl_udc: Don't use create_proc_read_entry() [RFC]

Don't use create_proc_read_entry() as that is deprecated, but rather use proc_create_data() and seq_file instead. Signed-off-by: David Howells cc: Li Yang cc: Felipe Balbi cc: Greg Kroah-Hartman cc: linux-usb@vger.kernel.org cc: linuxppc-...@lists.ozlabs.org --- drivers/usb/gadget/fsl_udc_co

Re: [PATCH] usb-serial: add support for USB Wishbone-serial adapters

On Thu, Apr 11, 2013 at 03:08:20PM +0200, Wesley W. Terpstra wrote: > Wishbone is an open hardware SoC bus commonly used in FPGA > designs. Bus access can be serialized using the Etherbone > protocol . > > This driver is intended to be used with devices

Re: [PATCH] usb-serial: add support for USB Wishbone-serial adapters

On Thu, 2013-04-11 at 06:45 -0700, Greg KH wrote: > I only have one very minor question about the code: > > > +++ b/drivers/usb/serial/wishbone-serial.c > > @@ -0,0 +1,95 @@ > > +/* > > + * USB Wishbone-Serial adapter driver > > + * > > + * Copyright (C) 2013 Wesley W. Terpstra > > + * Copyright

Re: [PATCH] USB: ehci-omap: Select USB_PHY

Hi, On Thu, Apr 11, 2013 at 04:18:33PM +0300, Roger Quadros wrote: > On 04/11/2013 03:42 PM, Roger Quadros wrote: > > On 04/11/2013 01:55 PM, Felipe Balbi wrote: > >> Hi, > >> > >> On Thu, Apr 11, 2013 at 01:51:16PM +0300, Roger Quadros wrote: > >>> On 04/11/2013 01:04 PM, Felipe Balbi wrote: > >>

Re: Linux USB file storage gadget with new UDC

On Thu, 11 Apr 2013, victor yeo wrote: > Thanks for the detailed write-up. I have checked the UDC driver > set_halt(), it is called by the gadget driver. The full ascii text of > usbmon trace for one usb session is also attached. This usbmon trace > shows a few EOVERFLOW(-75) error. I don't know w

[PATCH 01/11] usbnet: introduce usbnet_link_change API

This patch introduces the API of usbnet_link_change, so that usbnet can handle link change centrally, which may help to implement killing traffic URBs for saving USB bus bandwidth and host controller power. Signed-off-by: Ming Lei --- drivers/net/usb/usbnet.c | 13 + include/linu

[PATCH 02/11] usbnet: mcs7830: don't reset link

The driver doesn't implement link_reset() callback, so it needn't to send link reset event. Signed-off-by: Ming Lei --- drivers/net/usb/mcs7830.c |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/usb/mcs7830.c b/drivers/net/usb/mcs7830.c index 3f3f566..e1c00

[PATCH 03/11] usbnet: mcs7830: apply usbnet_link_change

This patch uses the introduced usbnet_link_change() to handle link change. Signed-off-by: Ming Lei --- drivers/net/usb/mcs7830.c |5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/usb/mcs7830.c b/drivers/net/usb/mcs7830.c index e1c00e9..03832d3 100644 --- a/dr

[PATCH 00/11] usbnet: usbnet: handle link change

Hi, This patch set introduces usbnet_link_change() API and applies it on all usbnet drivers, then handle the link change centrally to stop bulk transfer when link becomes off and restart bulk transfer when link becomes on. With the change, ~10% performance boost on bulk transfer of another device

[PATCH 04/11] usbnet: cdc_ncm: apply usbnet_link_change

Use the introduced usbnet_link_change to handle link change. Signed-off-by: Ming Lei --- drivers/net/usb/cdc_ncm.c |9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/net/usb/cdc_ncm.c b/drivers/net/usb/cdc_ncm.c index 67012cb..43afde8 100644 --- a/drivers/net

[PATCH 05/11] usbnet: asix: apply usbnet_link_change

Use usbnet_link_change to handle link change centrally. Signed-off-by: Ming Lei --- drivers/net/usb/asix_devices.c |6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/net/usb/asix_devices.c b/drivers/net/usb/asix_devices.c index 7097534..ad5d1e4 100644 --- a/drive

[PATCH 06/11] usbnet: ax88179_1781: apply usbnet_link_change

Use usbnet_link_change to handle link change centrally. Signed-off-by: Ming Lei --- drivers/net/usb/ax88179_178a.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/net/usb/ax88179_178a.c b/drivers/net/usb/ax88179_178a.c index 71c27d8..bd8758f 100644 ---

[PATCH 07/11] usbnet: cdc-ether: apply usbnet_link_change

Use usbnet_link_change to handle link change centrally. Signed-off-by: Ming Lei --- drivers/net/usb/cdc_ether.c |5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/usb/cdc_ether.c b/drivers/net/usb/cdc_ether.c index 57136dc..e965806 100644 --- a/drivers/net/usb

[PATCH 09/11] usbnet: sierra: apply usbnet_link_change

Use usbnet_link_change to handle link change centrally. Signed-off-by: Ming Lei --- drivers/net/usb/sierra_net.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/usb/sierra_net.c b/drivers/net/usb/sierra_net.c index 79ab243..a923d61 100644 --- a/drivers/net/us

[PATCH 10/11] usbnet: apply usbnet_link_change

Use usbnet_link_change to handle link change centrally. Signed-off-by: Ming Lei --- drivers/net/usb/usbnet.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c index 40e4237..34e4252 100644 --- a/drivers/net/usb/usbnet.c +++

[PATCH 08/11] usbnet: dm9601: apply usbnet_link_change

Use usbnet_link_change to handle link change centrally. Cc: Peter Korsgaard Signed-off-by: Ming Lei --- drivers/net/usb/dm9601.c |7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/net/usb/dm9601.c b/drivers/net/usb/dm9601.c index 174e5ec..2dbb946 100644 --- a/d

[PATCH 11/11] usbnet: handle link change

The link change is detected via the interrupt pipe, and bulk pipes are responsible for transfering packets, so it is reasonable to stop bulk transfer after link is reported as off. Two adavantages may be obtained with stopping bulk transfer after link becomes off: - USB bus bandwidth is saved(USB

Re: [PATCH] USB: ehci-omap: Select USB_PHY

Felipe, On 04/11/2013 04:02 PM, Alexander Holler wrote: > Am 11.04.2013 14:42, schrieb Roger Quadros: >> On 04/11/2013 01:55 PM, Felipe Balbi wrote: > >>> I would avoid 'select' completely and just update omap2plus_defconfig >>> adding those two as modules. Setting USB_PHY as a module gives rise

Re: [PATCH 11/11] usbnet: handle link change

On Thu, Apr 11, 2013 at 10:40 PM, Ming Lei wrote: > The link change is detected via the interrupt pipe, and bulk > pipes are responsible for transfering packets, so it is reasonable > to stop bulk transfer after link is reported as off. > > Two adavantages may be obtained with stopping bulk transf

Re: [PATCH] USB: ehci-omap: Select USB_PHY

On 04/11/2013 05:34 PM, Felipe Balbi wrote: > Hi, > > On Thu, Apr 11, 2013 at 04:18:33PM +0300, Roger Quadros wrote: >> On 04/11/2013 03:42 PM, Roger Quadros wrote: >>> On 04/11/2013 01:55 PM, Felipe Balbi wrote: Hi, On Thu, Apr 11, 2013 at 01:51:16PM +0300, Roger Quadros wrote: >>>

Re: [PATCH 3/9] usb/gadget: change sysfs parent device for USB Ethernet

On Thu, 11 Apr 2013, Andrzej Pietrasiewicz wrote: > This adds a new sysfs root device to serve as a replacement for > devices which are available only when a gadget is being bound. > > It is motivated by adding configfs support to USB Ethernet functions. > When configfs is there, we would like to

Re: Linux USB file storage gadget with new UDC

Hi, >> Thanks for the detailed write-up. I have checked the UDC driver >> set_halt(), it is called by the gadget driver. The full ascii text of >> usbmon trace for one usb session is also attached. This usbmon trace >> shows a few EOVERFLOW(-75) error. I don't know why EOVERFLOW error >> happened.

Re: [PATCH] USB: ehci-omap: Select USB_PHY

Hi, On Thu, Apr 11, 2013 at 05:44:00PM +0300, Roger Quadros wrote: > Felipe, > > On 04/11/2013 04:02 PM, Alexander Holler wrote: > > Am 11.04.2013 14:42, schrieb Roger Quadros: > >> On 04/11/2013 01:55 PM, Felipe Balbi wrote: > > > >>> I would avoid 'select' completely and just update omap2plus_

Re: [PATCH] USB: ehci-omap: Select USB_PHY

Hi, On Thu, Apr 11, 2013 at 05:53:10PM +0300, Roger Quadros wrote: > >>> From: Roger Quadros > >>> Date: Thu, 11 Apr 2013 12:08:19 +0300 > >>> Subject: [PATCH] USB: ehci-omap: Select USB_PHY > >>> > >>> As we need NOP_USB_XCEIV which depends on USB_PHY > >>> we need to sel

Re: [PATCH] usb-serial: add support for USB Wishbone-serial adapters

On Thu, Apr 11, 2013 at 03:54:47PM +0200, Wesley W. Terpstra wrote: > On Thu, 2013-04-11 at 06:45 -0700, Greg KH wrote: > > I only have one very minor question about the code: > > > > > +++ b/drivers/usb/serial/wishbone-serial.c > > > @@ -0,0 +1,95 @@ > > > +/* > > > + * USB Wishbone-Serial adapte

Re: [PATCH 00/11] usbnet: usbnet: handle link change

On 11.04.2013 17:40, Ming Lei wrote: > Hi, > > This patch set introduces usbnet_link_change() API and applies > it on all usbnet drivers, then handle the link change centrally > to stop bulk transfer when link becomes off and restart bulk > transfer when link becomes on. Should 'rndis_wlan' be ch

Re: [PATCH 08/11] usbnet: dm9601: apply usbnet_link_change

> "Ming" == Ming Lei writes: Ming> Use usbnet_link_change to handle link change centrally. Acked-by: Peter Korsgaard Ming> Cc: Peter Korsgaard Ming> Signed-off-by: Ming Lei Ming> --- Ming> drivers/net/usb/dm9601.c |7 +-- Ming> 1 file changed, 1 insertion(+), 6 deletions(-

Re: [PATCH 00/11] usbnet: usbnet: handle link change

On Thu, Apr 11, 2013 at 11:18 PM, Jussi Kivilinna wrote: > On 11.04.2013 17:40, Ming Lei wrote: >> Hi, >> >> This patch set introduces usbnet_link_change() API and applies >> it on all usbnet drivers, then handle the link change centrally >> to stop bulk transfer when link becomes off and restart

Re: [PATCH 1/2 v5] usbnet: allow status interrupt URB to always be active

On Thu, 2013-04-11 at 10:31 +0800, Ming Lei wrote: > On Thu, Apr 11, 2013 at 4:30 AM, Dan Williams wrote: > > Some drivers (sierra_net) need the status interrupt URB > > active even when the device is closed, because they receive > > custom indications from firmware. Add functions to refcount > >

Re: [PATCH] usb-serial: add support for USB Wishbone-serial adapters

On Thu, 2013-04-11 at 08:15 -0700, Greg KH wrote: > Fair enough, although this driver would probably be the least of our > worries if that were to happen :) Of course. > Documenation/stable_api_nonsense.txt Tactfully named. :) Is there a document that describes how to track the progress a patch m

Re: Linux USB file storage gadget with new UDC

On Thu, 11 Apr 2013, victor yeo wrote: > Thanks, i do not know why UDC sent back a data packet containing more > than 13 bytes in response to TEST UNIT READY command. Sounds like you need to debug the UDC driver. > Here is another usbmon trace attached in this email. There are two > issues in th

Re: [PATCH] usb-serial: add support for USB Wishbone-serial adapters

On Thu, Apr 11, 2013 at 05:30:52PM +0200, Wesley W. Terpstra wrote: > Is there a document that describes how to track the progress a patch > makes on its way to a released kernel version? I understand that > subsystem maintainers aggregate changes which then are aggregated in > turn by Linus, but b

[PATCH 0/2] staging: dwc2: Interrupt-related fixes

Hi folks, here's two interrupt-related fixes (though the first is a bit between a fix and a cleanup). These two are needed for the platform driver patches I'm sending next. I have some interrupt related cleanups (no fixes) later on. These two patches haven't changed from when I sent them in the b

[PATCH 1/2] staging: dwc2: don't pass IRQ_LEVEL to devm_request_irq

It seems this flag is intended to pass to irq_set_status_flags, not request_irq, and is not available on all architectures. Its value corresponds to IRQF_PROBE_SHARED, which shouldn't be needed for this driver, so removing this flag should be safe. Signed-off-by: Matthijs Kooijman --- drivers/st

[PATCH 2/2] staging: dwc2: register common irq handler in dwc2_core_init

Before, this was initialized in pci.c, after the dwc2_hcd_init was called and the interrupts were enabled. This opened up a small time window where common interrupts could be triggered, but there was no handler for them, causing them to keep triggering infinitely and locking up the machine. On my

[PATCH 1/4] staging: dwc2: set the driver name to "dwc2"

Previously, it was "dwc_otg", but this does not correspond to the directory name and might cause confusion with the old out-of-tree dwc_otg driver of which many versions circulate. Signed-off-by: Matthijs Kooijman --- drivers/staging/dwc2/hcd.c | 2 +- drivers/staging/dwc2/pci.c | 2 +- 2 files

[PATCH 0/4] staging: dwc2: Add platform driver

Hi folks, this is a few patches centering around the dwc2 platform driver. I've added the devicetree boilerplate, I'll be sending over a patch for actually using this driver on the ramips platform through the mips people. Gr. Matthijs Matthijs Kooijman (4): staging: dwc2: set the driver name

[PATCH 4/4] staging: dwc2: load parameters from the devicetree

Each of the parameters in the dwc2_core_params struct can now be changed using devicetree parameters. Signed-off-by: Matthijs Kooijman --- Documentation/devicetree/bindings/staging/dwc2.txt | 36 drivers/staging/dwc2/platform.c| 100 + 2 files ch

[PATCH 3/4] staging: dwc2: add platform device bindings

This adds a dwc_platform.ko module that can be loaded by using compatible = "snps,dwc2" in a device tree. Signed-off-by: Matthijs Kooijman --- Documentation/devicetree/bindings/staging/dwc2.txt | 15 +++ drivers/staging/dwc2/Kconfig | 6 +- drivers/staging/dwc2/Makefile

[PATCH 2/4] staging: dwc2: Make dwc2_set_uninitialized more specific

Before, it was a function that would set all members of a given struct containing only int members to -1. Now, it is renamed to dwc_set_all_params and it works only on the dwc2_core_params struct. This makes sure that all of the slightly dubious casting and assumptions happen inside the function in

Re: USB2.0 disk format failure in windows guest

On Wed, 10 Apr 2013, Gonglei (Arei) wrote: > Hi Alan, > We pass-throughed USB 2.0 disk to guest using usb-host (qemu option: -device > usb-ehci,id=ehci -device usb-host,bus=ehci.0,hostbus=2,hostport=1) on KVM(on > linux-3.8.3 or linux-3.0.13) and qemu 1.4.0 , Are you sure this disk was using EH

Re: [PATCH] USB: ehci-omap: Select USB_PHY

Am 11.04.2013 16:44, schrieb Roger Quadros: Sorry, but this just will end up with many users having broken configs because of disabled stuff they don't know why they have to enable them. And thus with a never ending stream of questions and thus with a needed FAQ entry. Alexander, I agree wit

RE: [PATCH 1/2] staging: dwc2: don't pass IRQ_LEVEL to devm_request_irq

> From: Matthijs Kooijman [mailto:matth...@stdin.nl] > Sent: Thursday, April 11, 2013 8:53 AM > > It seems this flag is intended to pass to irq_set_status_flags, not > request_irq, and is not available on all architectures. Its value > corresponds to IRQF_PROBE_SHARED, which shouldn't be needed fo

RE: [PATCH 2/2] staging: dwc2: register common irq handler in dwc2_core_init

> From: Matthijs Kooijman [mailto:matth...@stdin.nl] > Sent: Thursday, April 11, 2013 8:53 AM > > Before, this was initialized in pci.c, after the dwc2_hcd_init was > called and the interrupts were enabled. This opened up a small time > window where common interrupts could be triggered, but there

Re: USB storage disconnects on xHCI only with Renesas host and ASMedia enclosure

On Tue, 9 Apr 2013, infernix wrote: > Hi, > > For some time now (at least since 3.0) I have been having issues with an > USB3 to Sata enclosure and xHCI. The device (174c:55aa ASMedia > Technology Inc) works perfectly fine on USB2 ports in Linux, as well as > on the NEC/Renesas uPD720200(A) US

Re: [PATCH] USB: ehci-omap: Select USB_PHY

Hi, On Thu, Apr 11, 2013 at 07:33:32PM +0200, Alexander Holler wrote: > >>Sorry, but this just will end up with many users having broken configs > >>because of disabled stuff they don't know why they have to enable them. > >>And thus with a never ending stream of questions and thus with a needed >

Re: [PATCH 3/4] staging: dwc2: add platform device bindings

On Thu, Apr 11, 2013 at 06:43:48PM +0200, Matthijs Kooijman wrote: > This adds a dwc_platform.ko module that can be loaded by using > compatible = "snps,dwc2" in a device tree. > > Signed-off-by: Matthijs Kooijman > --- > Documentation/devicetree/bindings/staging/dwc2.txt | 15 +++ > drivers/st

Re: [PATCH 4/4] staging: dwc2: load parameters from the devicetree

Hi, On Thu, Apr 11, 2013 at 06:43:49PM +0200, Matthijs Kooijman wrote: > diff --git a/Documentation/devicetree/bindings/staging/dwc2.txt > b/Documentation/devicetree/bindings/staging/dwc2.txt > index 3649c88..05d9c08 100644 > --- a/Documentation/devicetree/bindings/staging/dwc2.txt > +++ b/Docume

Re: [RFC][PATCH 1/2] ARM: OMAP4: clock: Add device tree support for AUXCLKs

Quoting Nishanth Menon (2013-04-10 10:39:21) > diff --git a/drivers/clk/omap/clk.c b/drivers/clk/omap/clk.c > new file mode 100644 > index 000..63a4cce > --- /dev/null > +++ b/drivers/clk/omap/clk.c > @@ -0,0 +1,94 @@ > +/* > + * Texas Instruments OMAP Clock driver > + * > + * Copyright (C) 201

  1   2   >