Re: Linux USB file storage gadget with new UDC

2013-04-02 Thread victor yeo
Hi, >> Here is the fresh usbmon trace. Four SCSI commands are shown. The >> first SCSI_READ_10 command has LBA of 0. The second SCSI_READ_10 >> command has LBA of 0x00ed2900, which is wrong. Somehow, the first >> SCSI_READ_10 command got the wrong data, i think. Isn't it? > > It looks like the dat

RE: [PATCH] usb: host: tegra: Reset Tegra USB controller before init

2013-04-02 Thread Venu Byravarasu
> -Original Message- > From: gre...@linuxfoundation.org [mailto:gre...@linuxfoundation.org] > Sent: Tuesday, March 05, 2013 6:04 AM > To: Stephen Warren > Cc: Venu Byravarasu; st...@rowland.harvard.edu; linux- > u...@vger.kernel.org; linux-ker...@vger.kernel.org > Subject: Re: [PATCH] usb:

FTDI FT2232C issue

2013-04-02 Thread Yegor Yefremov
I'm making a burn-in test (see serialtest.py http://pastebin.com/pz47gaar) for our devices, that have built-in FTDI chips. If FT2232C is attached directly to the USB host controller port, the tests run properly. If I connect the chip to a USB-hub some of the tests show timeout errors (read() routin

[PATCH 1/2] usb: musb: dsps: print babble message only when musb is active host

2013-04-02 Thread Ravi Babu
The musb controller uses single bit defintion for both reset and babble events. The babble event is valid only when controller is active a-host, and hence print the babble message only when the controller is active a-host. Signed-off-by: Ravi Babu --- drivers/usb/musb/musb_dsps.c |2 +- 1 fi

[PATCH 2/2] usb: musb: gadget: read ep0 fifo only if rxcount is non zero

2013-04-02 Thread Ravi Babu
avoid reading fifo rxcount is zero of fifo is empty, hence read fifo only if rxcount is non-zero Signed-off-by: Ravi Babu --- drivers/usb/musb/musb_gadget_ep0.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/usb/musb/musb_gadget_ep0.c b/drivers/usb/musb/mu

Re: [PATCH 3/5] USB chipidea: introduce dual role mode pdata flags

2013-04-02 Thread Felipe Balbi
Hi, On Thu, Mar 28, 2013 at 03:18:14PM +0200, Alexander Shishkin wrote: > >> >> + dr_mode = ci->platdata->dr_mode; > >> >> + if (dr_mode == USB_DR_MODE_UNKNOWN || dr_mode == > >> >> USB_DR_MODE_DUAL_ROLE) > >> >> + dr_mode = USB_DR_MODE_OTG; > >> >> +

Re: [PATCH 1/2] ARM: imx_v6_v7_defconfig: add CONFIG_USB_PHY

2013-04-02 Thread Felipe Balbi
On Sun, Mar 24, 2013 at 10:06:04PM +0800, Shawn Guo wrote: > Commit edc7cb2 (usb: phy: make it a menuconfig) makes USB_MXS_PHY > be a sub-item of menuconfig symbol USB_PHY. This change gets the > selection of CONFIG_USB_MXS_PHY in imx_v6_v7_defconfig lost. Hence the > boot stops at the point belo

Re: cdc_acm device - unexpected characters sent to USB device

2013-04-02 Thread Oliver Neukum
On Monday 01 April 2013 22:05:47 Mike Verstegen wrote: Hi, > Such a simple question you asked -- but it lead to a useful discovery. > > My logs show that acm_tty_write is called multiple times > > - The application opens the device and then calls write() to send the 4 byte > message to the fd.

Re: [PATCH V2 6/6] usb: mv_usb: remove clock name from pdata

2013-04-02 Thread Felipe Balbi
Hi, On Mon, Mar 25, 2013 at 03:06:57AM -0400, Chao Xie wrote: > Using pdata to pass clock name is not correct. > Directly get clock from usb drivers. > > Signed-off-by: Chao Xie > --- > include/linux/platform_data/mv_usb.h |2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) > > diff

Re: [PATCH] usb: renesas_usbhs: fixup sparse errors for common.c

2013-04-02 Thread Felipe Balbi
On Sun, Mar 31, 2013 at 06:34:43PM -0700, Kuninori Morimoto wrote: > This patch fixup below sparse errors > > ${RENESAS_USB} = ${LINUX}/drivers/usb/renesas_usbhs > > CHECK ${RENESAS_USB}/common.c > ${RENESAS_USB}/common.c:313:17: error: incompatible types in conditional > expression (different

Re: [PATCH v3 01/11] usb: phy: Add APIs for runtime power management

2013-04-02 Thread Felipe Balbi
On Mon, Apr 01, 2013 at 07:24:00PM +0530, Vivek Gautam wrote: > Adding APIs to handle runtime power management on PHY > devices. PHY consumers may need to wake-up/suspend PHYs > when they work across autosuspend. > > Signed-off-by: Vivek Gautam > --- > include/linux/usb/phy.h | 141 >

Re: [PATCH v3 02/11] USB: dwc3: Adjust runtime pm to allow autosuspend

2013-04-02 Thread Felipe Balbi
On Mon, Apr 01, 2013 at 07:24:01PM +0530, Vivek Gautam wrote: > The current code in the dwc3 probe effectively disables runtime pm > from ever working because it calls a get() that was never put() until > device removal. Change the runtime pm code to match the standard > formula and allow runtime

Re: [PATCH v3 04/11] usb: dwc3: Add runtime power management callbacks

2013-04-02 Thread Felipe Balbi
Hi, On Mon, Apr 01, 2013 at 07:24:03PM +0530, Vivek Gautam wrote: > +#else > +#define dwc3_runtime_suspend NULL > +#define dwc3_runtime_resume NULL this #else branch is unnecessary. Look at the definition for SET_RUNTIME_PM_OPS() -- balbi signature.asc Description: Digital si

Re: [PATCH v3 05/11] usb: dwc3: exynos: Enable runtime power management

2013-04-02 Thread Felipe Balbi
On Mon, Apr 01, 2013 at 07:24:04PM +0530, Vivek Gautam wrote: > Enabling runtime power management on dwc3-exynos > letting dwc3 controller to be autosuspended on exynos > platform when not in use. > > Signed-off-by: Vivek Gautam > --- > drivers/usb/dwc3/dwc3-exynos.c | 12 > 1 fil

Re: [RESEND/PATCH] usb: host: ehci-tegra: fix PHY error handling

2013-04-02 Thread Felipe Balbi
Hi again, On Thu, Mar 21, 2013 at 11:19:51AM -0600, Stephen Warren wrote: > On 03/21/2013 06:23 AM, Felipe Balbi wrote: > > PHY layer no longer returns NULL, we must > > switch from IS_ERR_OR_NULL() to IS_ERR(). > > The patches that I'll put into my topic branch are not yet complete; > Venu first

Re: [PATCH v4 1/6] drivers: phy: add generic PHY framework

2013-04-02 Thread Kishon Vijay Abraham I
Hi, On Thursday 28 March 2013 09:15 PM, Stephen Warren wrote: On 03/27/2013 11:43 PM, Kishon Vijay Abraham I wrote: The PHY framework provides a set of APIs for the PHY drivers to create/destroy a PHY and APIs for the PHY users to obtain a reference to the diff --git a/Documentation/devicetr

Re: [PATCH v4 1/6] drivers: phy: add generic PHY framework

2013-04-02 Thread Kishon Vijay Abraham I
Hi, On Tuesday 02 April 2013 01:04 AM, Sylwester Nawrocki wrote: Just couple minor comments... On 03/28/2013 06:43 AM, Kishon Vijay Abraham I wrote: The PHY framework provides a set of APIs for the PHY drivers to create/destroy a PHY and APIs for the PHY users to obtain a reference to the PHY

RE: [PATCH V2 6/6] usb: mv_usb: remove clock name from pdata

2013-04-02 Thread Yu Xu
Hi, > -Original Message- > From: Felipe Balbi [mailto:ba...@ti.com] > Sent: 2013年4月2日 16:15 > To: Chao Xie > Cc: linux-usb@vger.kernel.org; linux-arm-ker...@lists.infradead.org; > haojian.zhu...@gmail.com; ba...@ti.com; xiechao.m...@gmail.com; Yu Xu > Subject: Re: [PATCH V2 6/6] usb: mv_us

Re: [PATCH v9 7/8] usb: chipidea: udc: prepare qhead with dma_alloc_coherent

2013-04-02 Thread Michael Grzeschik
On Mon, Apr 01, 2013 at 10:49:26AM +0800, Peter Chen wrote: > On Fri, Mar 29, 2013 at 12:32:00AM +0100, Michael Grzeschik wrote: [snip] > What's the value of sizeof(struct ci13xxx_qh) after you pack it > as 64 bytes aligned? > With the struct attribute aligned(64) the result of sizeof(struct ci

Re: [PATCH v9 7/8] usb: chipidea: udc: prepare qhead with dma_alloc_coherent

2013-04-02 Thread Peter Chen
On Tue, Apr 02, 2013 at 11:31:47AM +0200, Michael Grzeschik wrote: > > > dma_pool_destroy(ci->td_pool); > > > free_qh_pool: > > > - dma_pool_destroy(ci->qh_pool); > > > > You may need dma_free_coherent. > > Will add that here. > The same for de-init procedure. > > > -} __attribute__ ((packe

Re: [PATCH v3 01/11] usb: phy: Add APIs for runtime power management

2013-04-02 Thread Vivek Gautam
Hi, On Tue, Apr 2, 2013 at 1:53 PM, Felipe Balbi wrote: > On Mon, Apr 01, 2013 at 07:24:00PM +0530, Vivek Gautam wrote: >> Adding APIs to handle runtime power management on PHY >> devices. PHY consumers may need to wake-up/suspend PHYs >> when they work across autosuspend. >> >> Signed-off-by:

Re: [PATCH 1/2] ARM: imx_v6_v7_defconfig: add CONFIG_USB_PHY

2013-04-02 Thread Shawn Guo
On Tue, Apr 02, 2013 at 11:07:06AM +0300, Felipe Balbi wrote: > On Sun, Mar 24, 2013 at 10:06:04PM +0800, Shawn Guo wrote: > > Commit edc7cb2 (usb: phy: make it a menuconfig) makes USB_MXS_PHY > > be a sub-item of menuconfig symbol USB_PHY. This change gets the > > selection of CONFIG_USB_MXS_PHY

[PATCH v2 1/2] usb: gadget: fusb300_udc: add FUSB300_EPSET0_STL_CLR for clearing EP0 stall

2013-04-02 Thread Yuan-Hsin Chen
The final version of fusb300 controller adds EPSET0_STL_CLR for clearing EP0 stall and also removes EPSET0_EPn_TX0BYTE. fusb300_udc driver is tested on FARADAY platform a369 with FUSB300 FPGA v1.8 Signed-off-by: Yuan-Hsin Chen --- v2: split patch drivers/usb/gadget/fusb300_udc.c |2 +- dr

[PATCH v2 2/2] usb: gadget: fusb300_udc: bug fix of not doing idma reset for each time

2013-04-02 Thread Yuan-Hsin Chen
Enter IDMA_RESET only when the controller has been reset or the device has been plugged in to or out from a host. In IDMA_RESET, we should disable the corresponding PRD interrupt. Also there is a redundant space eliminated. fusb300_udc driver is tested on FARADAY platform a369 with FUSB300 FPGA v1

Re: [PATCH v3 01/11] usb: phy: Add APIs for runtime power management

2013-04-02 Thread Felipe Balbi
Hi, On Tue, Apr 02, 2013 at 04:04:01PM +0530, Vivek Gautam wrote: > > On Mon, Apr 01, 2013 at 07:24:00PM +0530, Vivek Gautam wrote: > >> Adding APIs to handle runtime power management on PHY > >> devices. PHY consumers may need to wake-up/suspend PHYs > >> when they work across autosuspend. > >>

Re: [PATCH v3 01/11] usb: phy: Add APIs for runtime power management

2013-04-02 Thread Vivek Gautam
Hi, On Tue, Apr 2, 2013 at 5:40 PM, Felipe Balbi wrote: > Hi, > > On Tue, Apr 02, 2013 at 04:04:01PM +0530, Vivek Gautam wrote: >> > On Mon, Apr 01, 2013 at 07:24:00PM +0530, Vivek Gautam wrote: >> >> Adding APIs to handle runtime power management on PHY >> >> devices. PHY consumers may need to

Re: [PATCH 1/2] ARM: imx_v6_v7_defconfig: add CONFIG_USB_PHY

2013-04-02 Thread Felipe Balbi
Hi, On Tue, Apr 02, 2013 at 07:12:47PM +0800, Shawn Guo wrote: > On Tue, Apr 02, 2013 at 11:07:06AM +0300, Felipe Balbi wrote: > > On Sun, Mar 24, 2013 at 10:06:04PM +0800, Shawn Guo wrote: > > > Commit edc7cb2 (usb: phy: make it a menuconfig) makes USB_MXS_PHY > > > be a sub-item of menuconfig sy

Re: [PATCH 0/9] Towards configfs in mass storage

2013-04-02 Thread Felipe Balbi
Hi Andrejz, On Wed, Jan 23, 2013 at 12:45:31PM +0100, Andrzej Pietrasiewicz wrote: > The prerequisite for providing the configfs interface for mass storage and all > its users is converting them to the new function interface from Sebastian. > > This patch series serves the purpose stated above. >

Re: Linux USB file storage gadget with new UDC

2013-04-02 Thread Alan Stern
On Tue, 2 Apr 2013, victor yeo wrote: > Hi, > > >> Here is the fresh usbmon trace. Four SCSI commands are shown. The > >> first SCSI_READ_10 command has LBA of 0. The second SCSI_READ_10 > >> command has LBA of 0x00ed2900, which is wrong. Somehow, the first > >> SCSI_READ_10 command got the wrong

Re: cdc_acm device - unexpected characters sent to USB device

2013-04-02 Thread Alan Stern
On Tue, 2 Apr 2013, Oliver Neukum wrote: > On Monday 01 April 2013 22:05:47 Mike Verstegen wrote: > > Hi, > > > Such a simple question you asked -- but it lead to a useful discovery. > > > > My logs show that acm_tty_write is called multiple times > > > > - The application opens the device and

Re: FTDI FT2232C issue

2013-04-02 Thread Alan Stern
On Tue, 2 Apr 2013, Yegor Yefremov wrote: > I'm making a burn-in test (see serialtest.py > http://pastebin.com/pz47gaar) for our devices, that have built-in FTDI > chips. If FT2232C is attached directly to the USB host controller > port, the tests run properly. If I connect the chip to a USB-hub s

[PATCH] usb: gadget: pxa27x_udc: fix Section Mismatches

2013-04-02 Thread Felipe Balbi
Remove all section annotations to fix the following section mismatches: >> WARNING: drivers/usb/gadget/pxa27x_udc.o(.text+0x597c): Section mismatch in reference from the function .pxa_udc_probe() to the function .init.text:.udc_init_data.constprop.11() The function .pxa_udc_probe() references

[PATCH] usb: gadget: pxa27x_udc: fix Section Mismatches

2013-04-02 Thread Felipe Balbi
Remove all section annotations to fix the following section mismatches: >> WARNING: drivers/usb/gadget/pxa27x_udc.o(.text+0x597c): Section mismatch in reference from the function .pxa_udc_probe() to the function .init.text:.udc_init_data.constprop.11() The function .pxa_udc_probe() references

Re: [PATCH 1/2] ARM: imx_v6_v7_defconfig: add CONFIG_USB_PHY

2013-04-02 Thread Shawn Guo
On Tue, Apr 02, 2013 at 03:44:07PM +0300, Felipe Balbi wrote: > alright, in that case can you rebase on next branch ? patch 2 didn't > apply. Have you tried "git am -3"? Shawn -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kerne

Re: FTDI FT2232C issue

2013-04-02 Thread Yegor Yefremov
On Tue, Apr 2, 2013 at 4:14 PM, Alan Stern wrote: > On Tue, 2 Apr 2013, Yegor Yefremov wrote: > >> I'm making a burn-in test (see serialtest.py >> http://pastebin.com/pz47gaar) for our devices, that have built-in FTDI >> chips. If FT2232C is attached directly to the USB host controller >> port, th

Re: FTDI FT2232C issue

2013-04-02 Thread Alan Stern
On Tue, 2 Apr 2013, Yegor Yefremov wrote: > On Tue, Apr 2, 2013 at 4:14 PM, Alan Stern wrote: > > On Tue, 2 Apr 2013, Yegor Yefremov wrote: > > > >> I'm making a burn-in test (see serialtest.py > >> http://pastebin.com/pz47gaar) for our devices, that have built-in FTDI > >> chips. If FT2232C is a

[PATCH] EHCI: Quirk flag for port power handling on overcurrent.

2013-04-02 Thread Christian Engelmayer
Commit 756aa6b3d536afe85e151138cb03a293998887b3 added port power cycling on overcurrent indications as needed by the MPC8349 USB controller after resolving of the overcurrent situation in order to have the host state machine assert the correct port status again. Commit 81463c1d707186adbbe534016cd1

Re: [PATCH] EHCI: Quirk flag for port power handling on overcurrent.

2013-04-02 Thread Alan Stern
On Tue, 2 Apr 2013, Christian Engelmayer wrote: > Commit 756aa6b3d536afe85e151138cb03a293998887b3 added port power cycling on > overcurrent indications as needed by the MPC8349 USB controller after > resolving of the overcurrent situation in order to have the host state machine > assert the correc

RE: cdc_acm device - unexpected characters sent to USB device

2013-04-02 Thread Mike Verstegen
> -Original Message- > From: Alan Stern [mailto:st...@rowland.harvard.edu] > Sent: Tuesday, April 02, 2013 7:04 AM > To: Oliver Neukum > Cc: Mike Verstegen; linux-usb@vger.kernel.org > Subject: Re: cdc_acm device - unexpected characters sent to USB device > > On Tue, 2 Apr 2013, Oliver

Re: [PATCH] usb: host: tegra: Reset Tegra USB controller before init

2013-04-02 Thread Stephen Warren
On 04/02/2013 01:12 AM, Venu Byravarasu wrote: >> gre...@linuxfoundation.org wrote at Tuesday, March 05, 2013 6:04 AM: >> On Mon, Mar 04, 2013 at 09:55:44AM -0700, Stephen Warren wrote: >>> On 03/04/2013 12:55 AM, Venu Byravarasu wrote: Stephen Warren wrote at Thursday, February 28, 2013 11:47

Re: [PATCH v2] usb host: Faraday FUSBH200 HCD driver

2013-04-02 Thread Alan Stern
On Mon, 1 Apr 2013, Yuan-Hsin Chen wrote: > FUSBH200 is an ehci-like controller with some differences. > First, register layout of FUSBH200 is incompatible with EHCI. > We use a quirk flag and modify struct ehci_regs with anonymous > union and struct to make sure driver of FUSBH200 and EHCI could

Re: [RESEND/PATCH] usb: host: ehci-tegra: fix PHY error handling

2013-04-02 Thread Stephen Warren
On 04/02/2013 02:36 AM, Felipe Balbi wrote: > Hi again, > > On Thu, Mar 21, 2013 at 11:19:51AM -0600, Stephen Warren wrote: >> On 03/21/2013 06:23 AM, Felipe Balbi wrote: >>> PHY layer no longer returns NULL, we must switch from >>> IS_ERR_OR_NULL() to IS_ERR(). >> >> The patches that I'll put in

Re: [PATCH v4 1/6] drivers: phy: add generic PHY framework

2013-04-02 Thread Stephen Warren
On 04/02/2013 02:37 AM, Kishon Vijay Abraham I wrote: > Hi, > > On Thursday 28 March 2013 09:15 PM, Stephen Warren wrote: >> On 03/27/2013 11:43 PM, Kishon Vijay Abraham I wrote: >>> The PHY framework provides a set of APIs for the PHY drivers to >>> create/destroy a PHY and APIs for the PHY users

Re: [RESEND/PATCH] usb: host: ehci-tegra: fix PHY error handling

2013-04-02 Thread Felipe Balbi
Hi, On Tue, Apr 02, 2013 at 09:33:56AM -0600, Stephen Warren wrote: > On 04/02/2013 02:36 AM, Felipe Balbi wrote: > > Hi again, > > > > On Thu, Mar 21, 2013 at 11:19:51AM -0600, Stephen Warren wrote: > >> On 03/21/2013 06:23 AM, Felipe Balbi wrote: > >>> PHY layer no longer returns NULL, we must

[PATCH] usb: chipidea: udc: configure iso endpoints

2013-04-02 Thread Michael Grzeschik
The implementation is derived from the fsl_udc_core code in fsl_ep_enable and makes basic iso handling possible. Signed-off-by: Michael Grzeschik Signed-off-by: Marc Kleine-Budde Reviewed-by: Felipe Balbi --- drivers/usb/chipidea/core.c | 2 +- drivers/usb/chipidea/udc.c | 12 d

[PATCH V5 5/6] USB: EHCI: make ehci-msm a separate driver

2013-04-02 Thread Arnd Bergmann
From: Manjunath Goudar Separate the Qualcomm QSD/MSM on-chip host controller driver from ehci-hcd host code so that it can be built as a separate driver module. This work is part of enabling multi-platform kernels on ARM; however, note that other changes are still needed before Qualcomm QSD/MSM

[PATCH V5 0/6] USB: EHCI multiplatform for 3.10

2013-04-02 Thread Arnd Bergmann
Hi Greg, Here are the EHCI patches that I think are good for inclusion in 3.10, I hope you are willing to include them after the debacle over these patches in 3.9. The patches are all logically independent but sorted by priority, so decide for yourself how many you want to take, starting at the f

[PATCH V5 3/6] USB: EHCI: make ehci-s5p a separate driver

2013-04-02 Thread Arnd Bergmann
From: Manjunath Goudar Separate the Samsung S5P/EXYNOS host controller driver from ehci-hcd host code so that it can be built as a separate driver module. This work is part of enabling multi-platform kernels on ARM; however, note that other changes are still needed before S5P/EXYNOS can be boote

[PATCH V5 6/6] USB: OHCI: avoid conflicting platform drivers

2013-04-02 Thread Arnd Bergmann
Like the EHCI driver, OHCI supports a large number of different platform glue drivers by directly including them, which causes problems with conflicting macro definitions in some cases. As more ARM architecture specific back-ends are required to coexist in a single build, we should split those out

[PATCH V5 2/6] USB: EHCI: make ehci-spear a separate driver

2013-04-02 Thread Arnd Bergmann
From: Manjunath Goudar Separate the SPEAr host controller driver from ehci-hcd host code so that it can be built as a separate driver module. This work is part of enabling multi-platform kernels on ARM; however, note that other changes are still needed before SPEAr can be booted with a multi-plat

[PATCH V5 1/6] USB: EHCI: make ehci-orion a separate driver

2013-04-02 Thread Arnd Bergmann
From: Manjunath Goudar Separate the Orion host controller driver from ehci-hcd host code into its own driver module because of following reason. With the multiplatform changes in arm-soc tree, it becomes possible to enable the mvebu platform (which uses ehci-orion) at the same time as other plat

[PATCH V5 4/6] USB: EHCI: make ehci-atmel a separate driver

2013-04-02 Thread Arnd Bergmann
From: Manjunath Goudar Separate the Atmel host controller driver from ehci-hcd host code so that it can be built as a separate driver module. This work is part of enabling multi-platform kernels on ARM; however, note that other changes are still needed before Atmel can be booted with a multi-plat

[PATCH 1/5] USB: regroup all depends on USB within an if USB block

2013-04-02 Thread Florian Fainelli
This patch removes the depends on USB from all config symbols in drivers/usb/host/Kconfig and replace that with an if USB / endif block as suggested by Alan Stern. Some source ... Kconfig lines have been shuffled around to permit a better regroupment of the Kconfig files depending on "config USB" i

[PATCH 0/5] USB: Kconfig cleanups

2013-04-02 Thread Florian Fainelli
Hello Alan, Greg, These 5 patches contain my Kconfig cleanup on which I based the removal of the USB_ARCH_HAS_* patches. They have been suggested by Alan Stern as part of an earlier conversations. Let me know what you think about it so I can post subsequent work based on it. This time I dropped t

[PATCH 2/5] USB: remove USB_EHCI_BIG_ENDIAN_{DESC,MMIO} depends on architecture symbol

2013-04-02 Thread Florian Fainelli
Just like the OHCI counter part we just can remove the architecture specific symbols which prevent these configuration symbols from being selected by platforms/architectures requiring it. The original implementation did not scale at all since it required each and every single architecture to be add

[PATCH 5/5] USB: enclose USB_XHCI_HCD related symbols within a if USB_XHCI_HCD block

2013-04-02 Thread Florian Fainelli
This patch encloses all symbols depending on USB_XHCI_HCD within an if USB_XHCI_HCD / endif block. Signed-off-by: Florian Fainelli --- drivers/usb/host/Kconfig |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig index 4

[PATCH 3/5] USB: enclose EHCI HCD drivers within an if USB_EHCI_HCD block

2013-04-02 Thread Florian Fainelli
Thist patch removes the depends on USB_EHCI_HCD that the various USB EHCI HCD drivers use and encloses every driver within an if USB_EHCI_HCD / endif block. The EHCI HCD platform and Octeon drivers have been moved around to remain enclosed within this block. Signed-off-by: Florian Fainelli --- d

[PATCH 4/5] USB: enclose all depends on USB_OHCI_HCD within an if USB_OHCI_HCD block

2013-04-02 Thread Florian Fainelli
This patch removes the various depends on USB_OHCI_HCD from the OHCI HCD drivers and enclose them within an if USB_OHCI_HCD / endif block. The Octeon OHCI HCD driver has been moved around to remain in this block. Signed-off-by: Florian Fainelli --- drivers/usb/host/Kconfig | 51 +++

[PATCH 2/5 v2] USB: remove USB_EHCI_BIG_ENDIAN_{DESC,MMIO} depends on architecture symbol

2013-04-02 Thread Florian Fainelli
Just like the OHCI counter part we just can remove the architecture specific symbols which prevent these configuration symbols from being selected by platforms/architectures requiring it. The original implementation did not scale at all since it required each and every single architecture to be add

Re: [PATCH 0/5] USB: Kconfig cleanups

2013-04-02 Thread Florian Fainelli
Le 04/02/13 19:05, Florian Fainelli a écrit : Hello Alan, Greg, These 5 patches contain my Kconfig cleanup on which I based the removal of the USB_ARCH_HAS_* patches. They have been suggested by Alan Stern as part of an earlier conversations. Let me know what you think about it so I can post su

[PATCH 1/5 v2] USB: regroup all depends on USB within an if USB block

2013-04-02 Thread Florian Fainelli
This patch removes the depends on USB from all config symbols in drivers/usb/host/Kconfig and replace that with an if USB / endif block as suggested by Alan Stern. Some source ... Kconfig lines have been shuffled around to permit a better regroupment of the Kconfig files depending on "config USB" i

[PATCH 0/5 v2] USB: Kconfig cleanups

2013-04-02 Thread Florian Fainelli
Hello Alan, Greg, These 5 patches contain my Kconfig cleanup on which I based the removal of the USB_ARCH_HAS_* patches. They have been suggested by Alan Stern as part of an earlier conversations. Let me know what you think about it so I can post subsequent work based on it. This time I dropped t

[PATCH 3/5 v2] USB: enclose EHCI HCD drivers within an if USB_EHCI_HCD block

2013-04-02 Thread Florian Fainelli
Thist patch removes the depends on USB_EHCI_HCD that the various USB EHCI HCD drivers use and encloses every driver within an if USB_EHCI_HCD / endif block. The EHCI HCD platform and Octeon drivers have been moved around to remain enclosed within this block. Signed-off-by: Florian Fainelli --- d

[PATCH 4/5 v2] USB: enclose all depends on USB_OHCI_HCD within an if USB_OHCI_HCD block

2013-04-02 Thread Florian Fainelli
This patch removes the various depends on USB_OHCI_HCD from the OHCI HCD drivers and enclose them within an if USB_OHCI_HCD / endif block. The Octeon OHCI HCD driver has been moved around to remain in this block. Signed-off-by: Florian Fainelli --- drivers/usb/host/Kconfig | 51 +++

[PATCH 5/5 v2] USB: enclose USB_XHCI_HCD related symbols within a if USB_XHCI_HCD block

2013-04-02 Thread Florian Fainelli
This patch encloses all symbols depending on USB_XHCI_HCD within an if USB_XHCI_HCD / endif block. Signed-off-by: Florian Fainelli --- drivers/usb/host/Kconfig |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig index 4

[PATCH] musb: ti81xx: drop spurious unplugging a device

2013-04-02 Thread Shane Whalen
based on commit 6ff1f3d3bd7c69c62ca5773b1b684bce42eff06a. On TI81xx, tx and rx interrupt are detected together with the disconnect event. This generates a kernel panic in musb_interrupt, because rx / tx are handled after disconnect. Signed-off-by: Shane Whalen --- drivers/usb/musb/musb_dsps.c |

Re: [PATCH v4 01/21] usb: phy: nop: Add some parameters to platform data

2013-04-02 Thread Tony Lindgren
* Felipe Balbi [130320 09:24]: > On Wed, Mar 20, 2013 at 09:13:24AM -0700, Tony Lindgren wrote: > > * Felipe Balbi [130320 09:00]: > > > On Wed, Mar 20, 2013 at 05:44:40PM +0200, Roger Quadros wrote: > > > > Add clk_rate parameter to platform data. If supplied, the > > > > NOP phy driver will pro

Re: [PATCH] EHCI: Quirk flag for port power handling on overcurrent.

2013-04-02 Thread Sergei Shtylyov
Hello. On 04/02/2013 06:54 PM, Christian Engelmayer wrote: Commit 756aa6b3d536afe85e151138cb03a293998887b3 added port power cycling on overcurrent indications as needed by the MPC8349 USB controller after resolving of the overcurrent situation in order to have the host state machine assert the

Re: [RESEND/PATCH] usb: host: ehci-tegra: fix PHY error handling

2013-04-02 Thread Sergei Shtylyov
Hello. On 04/02/2013 07:44 PM, Felipe Balbi wrote: Hi again, On Thu, Mar 21, 2013 at 11:19:51AM -0600, Stephen Warren wrote: On 03/21/2013 06:23 AM, Felipe Balbi wrote: PHY layer no longer returns NULL, we must switch from IS_ERR_OR_NULL() to IS_ERR(). The patches that I'll put into my topi

Re: [RESEND/PATCH] usb: host: ehci-tegra: fix PHY error handling

2013-04-02 Thread Felipe Balbi
Hi, On Tue, Apr 02, 2013 at 09:39:57PM +0400, Sergei Shtylyov wrote: > On 03/21/2013 06:23 AM, Felipe Balbi wrote: > >PHY layer no longer returns NULL, we must switch from > >IS_ERR_OR_NULL() to IS_ERR(). > The patches that I'll put into my topic branch are not yet > complete;

Re: [PATCH 1/5 v2] USB: regroup all depends on USB within an if USB block

2013-04-02 Thread Alan Stern
On Tue, 2 Apr 2013, Florian Fainelli wrote: > This patch removes the depends on USB from all config symbols in > drivers/usb/host/Kconfig and replace that with an if USB / endif block > as suggested by Alan Stern. Some source ... Kconfig lines have been > shuffled around to permit a better regroup

Re: [PATCH 2/2] xhci: Rename SEGMENT_SIZE and SEGMENT_SHIFT as the former is used in a.out.h

2013-04-02 Thread David Howells
Sarah Sharp wrote: > I guess my question is a deeper one: do we need to rename all the xHCI > macros to have the XHCI_ prefix, in order to avoid future collision? > For example, one of the macros is MAX_HC_PORTS, which could possibly be > used by other host drivers in the future. Hmmm... I susp

Re: [PATCH 1/5 v2] USB: regroup all depends on USB within an if USB block

2013-04-02 Thread balbi
Hi, On Tue, Apr 02, 2013 at 07:10:22PM +0200, Florian Fainelli wrote: > diff --git a/drivers/usb/musb/Kconfig b/drivers/usb/musb/Kconfig > index 05e5143..ab5a3b9 100644 > --- a/drivers/usb/musb/Kconfig > +++ b/drivers/usb/musb/Kconfig > @@ -6,7 +6,6 @@ > # (M)HDRC = (Multipoint) Highspeed Dual-Ro

Re: [PATCH 2/5 v2] USB: remove USB_EHCI_BIG_ENDIAN_{DESC,MMIO} depends on architecture symbol

2013-04-02 Thread Alan Stern
On Tue, 2 Apr 2013, Florian Fainelli wrote: > Just like the OHCI counter part we just can remove the architecture > specific symbols which prevent these configuration symbols from being > selected by platforms/architectures requiring it. The original > implementation did not scale at all since it

Re: [PATCH 3/5 v2] USB: enclose EHCI HCD drivers within an if USB_EHCI_HCD block

2013-04-02 Thread Alan Stern
On Tue, 2 Apr 2013, Florian Fainelli wrote: > Thist patch removes the depends on USB_EHCI_HCD that the various USB > EHCI HCD drivers use and encloses every driver within an if USB_EHCI_HCD > / endif block. The EHCI HCD platform and Octeon drivers have been moved > around to remain enclosed within

Re: [PATCH 4/5 v2] USB: enclose all depends on USB_OHCI_HCD within an if USB_OHCI_HCD block

2013-04-02 Thread Alan Stern
On Tue, 2 Apr 2013, Florian Fainelli wrote: > This patch removes the various depends on USB_OHCI_HCD from the OHCI HCD > drivers and enclose them within an if USB_OHCI_HCD / endif block. The > Octeon OHCI HCD driver has been moved around to remain in this block. > > Signed-off-by: Florian Fainell

Re: [PATCH 5/5 v2] USB: enclose USB_XHCI_HCD related symbols within a if USB_XHCI_HCD block

2013-04-02 Thread Alan Stern
On Tue, 2 Apr 2013, Florian Fainelli wrote: > This patch encloses all symbols depending on USB_XHCI_HCD within an if > USB_XHCI_HCD / endif block. > > Signed-off-by: Florian Fainelli Acked-by: Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a

Re: [PATCH 2/2] xhci: Rename SEGMENT_SIZE and SEGMENT_SHIFT as the former is used in a.out.h

2013-04-02 Thread Sarah Sharp
On Tue, Apr 02, 2013 at 07:07:36PM +0100, David Howells wrote: > Sarah Sharp wrote: > > > I guess my question is a deeper one: do we need to rename all the xHCI > > macros to have the XHCI_ prefix, in order to avoid future collision? > > For example, one of the macros is MAX_HC_PORTS, which could

[PATCH] usb: host: ehci-tegra: Fix oops in error cleanup

2013-04-02 Thread Thierry Reding
The cleanup path checks whether the transceiver was properly initialized using IS_ERR(). However it can also happen that the cleanup path is run before the transceiver was initialized (or the operating mode isn't set to TEGRA_USB_OTG) and is therefore NULL. Add a separate label for error unwinding

Re: [PATCH] usb: host: ehci-tegra: Fix oops in error cleanup

2013-04-02 Thread Stephen Warren
On 04/02/2013 02:40 PM, Thierry Reding wrote: > The cleanup path checks whether the transceiver was properly initialized > using IS_ERR(). However it can also happen that the cleanup path is run > before the transceiver was initialized (or the operating mode isn't set > to TEGRA_USB_OTG) and is the

Re: [PATCH v4 1/6] drivers: phy: add generic PHY framework

2013-04-02 Thread Sylwester Nawrocki
On 04/02/2013 12:38 AM, Stephen Warren wrote: On 04/01/2013 04:27 PM, Sylwester Nawrocki wrote: On 03/28/2013 06:43 AM, Kishon Vijay Abraham I wrote: diff --git a/Documentation/devicetree/bindings/phy/phy-bindings.txt +example2: +phys: phy { +compatible = "xxx"; +reg =<...>; +. +

Re: Linux USB file storage gadget with new UDC

2013-04-02 Thread victor yeo
Hi, >> > It looks like the data is wrong, but I have no way of knowing what the >> > data actually should be. Only you know that. >> > >> >> f31a9740 4037054141 S Bo:2:071:1 -115 31 = 55534243 0c00 0010 >> >> 8a28 0008 00 >> >> f31a9740 4037054176 C Bo:2:071:

Re: [PATCH] usb: chipidea: udc: configure iso endpoints

2013-04-02 Thread Peter Chen
On Tue, Apr 02, 2013 at 06:10:54PM +0200, Michael Grzeschik wrote: > /* first nuke then test link, e.g. previous status has not sent */ > if (!list_empty(&mReq->queue)) { > dev_err(mEp->ci->dev, "request already in queue\n"); > @@ -1071,6 +1077,9 @@ static int ep_enable(st

Re: [PATCH v3 04/11] usb: dwc3: Add runtime power management callbacks

2013-04-02 Thread Vivek Gautam
Hi Balbi, On Tue, Apr 2, 2013 at 2:02 PM, Felipe Balbi wrote: > Hi, > > On Mon, Apr 01, 2013 at 07:24:03PM +0530, Vivek Gautam wrote: >> +#else >> +#define dwc3_runtime_suspend NULL >> +#define dwc3_runtime_resume NULL > > this #else branch is unnecessary. Look at the definition

Re: [PATCH v3 01/11] usb: phy: Add APIs for runtime power management

2013-04-02 Thread Kishon Vijay Abraham I
Hi, On Monday 01 April 2013 07:24 PM, Vivek Gautam wrote: Adding APIs to handle runtime power management on PHY devices. PHY consumers may need to wake-up/suspend PHYs when they work across autosuspend. Signed-off-by: Vivek Gautam --- include/linux/usb/phy.h | 141 +

Re: [PATCH v4 1/6] drivers: phy: add generic PHY framework

2013-04-02 Thread Kishon Vijay Abraham I
On Tuesday 02 April 2013 09:10 PM, Stephen Warren wrote: On 04/02/2013 02:37 AM, Kishon Vijay Abraham I wrote: Hi, On Thursday 28 March 2013 09:15 PM, Stephen Warren wrote: On 03/27/2013 11:43 PM, Kishon Vijay Abraham I wrote: The PHY framework provides a set of APIs for the PHY drivers to cr

Re: [PATCH v4 0/6] Generic PHY Framework

2013-04-02 Thread Kishon Vijay Abraham I
Hi, On Friday 29 March 2013 12:01 AM, David Miller wrote: You really need to CC: net...@vger.kernel.org rather than me explicitly on this patch set. I was CC'ing whatever get_maintainer shows. I'll make sure to CC net...@vger.kernel.org though there's nothing related to network in this patc

Re: [PATCH v3 02/11] USB: dwc3: Adjust runtime pm to allow autosuspend

2013-04-02 Thread Vivek Gautam
Hi Felipe, On Tue, Apr 2, 2013 at 1:59 PM, Felipe Balbi wrote: > On Mon, Apr 01, 2013 at 07:24:01PM +0530, Vivek Gautam wrote: >> The current code in the dwc3 probe effectively disables runtime pm >> from ever working because it calls a get() that was never put() until >> device removal. Change

Re: [PATCH v3 01/11] usb: phy: Add APIs for runtime power management

2013-04-02 Thread Vivek Gautam
Hi Kishon, On Wed, Apr 3, 2013 at 10:38 AM, Kishon Vijay Abraham I wrote: > Hi, > > > On Monday 01 April 2013 07:24 PM, Vivek Gautam wrote: >> >> Adding APIs to handle runtime power management on PHY >> devices. PHY consumers may need to wake-up/suspend PHYs >> when they work across autosuspend

Re: [PATCH v4 0/6] Generic PHY Framework

2013-04-02 Thread David Miller
From: Kishon Vijay Abraham I Date: Wed, 3 Apr 2013 11:29:53 +0530 > Hi, > > On Friday 29 March 2013 12:01 AM, David Miller wrote: >> >> You really need to CC: net...@vger.kernel.org rather than me >> explicitly >> on this patch set. > > I was CC'ing whatever get_maintainer shows. I'll make sure

Re: [PATCH v4 0/6] Generic PHY Framework

2013-04-02 Thread Kishon Vijay Abraham I
Hi, On Wednesday 03 April 2013 12:01 PM, David Miller wrote: From: Kishon Vijay Abraham I Date: Wed, 3 Apr 2013 11:29:53 +0530 Hi, On Friday 29 March 2013 12:01 AM, David Miller wrote: You really need to CC: net...@vger.kernel.org rather than me explicitly on this patch set. I was CC'ing