On Tue, Mar 26, 2013 at 7:34 AM, Tony Prisk wrote:
>
> On Mon, 2013-03-25 at 19:03 +, Arnd Bergmann wrote:
> > On Monday 25 March 2013, Tony Prisk wrote:
> > > I'll take a look at this and get back to you before Easter.
> > >
> >
> > Great, thanks a lot!
> >
> > Arnd
>
> I couldn't get t
Hi,
>> >> In the log file, is there any invalid request received on endpoint 0?
>> >
>> > In the usbmon file there is. It is this line:
>> >
>> >> f4ae6f40 1217192721 S Co:2:018:0 s 21 ff 0
>>
>> ok, i will add code to UDC to instruct hardware to send NAK upon
>> receiving invalid
By commit 39d35681d5380b403855202dcd75575a8d5b0ec1, comma followed by
ehci_hcd_sh_remove has been deleted. This fixes the error by the correction.
Signed-off-by: Nobuhiro Iwamatsu
CC: Dmitry Torokhov
---
drivers/usb/host/ehci-sh.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -
Signed-off-by: Nobuhiro Iwamatsu
---
drivers/usb/host/ehci-sh.c |1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/usb/host/ehci-sh.c b/drivers/usb/host/ehci-sh.c
index b0f2268..b44d716 100644
--- a/drivers/usb/host/ehci-sh.c
+++ b/drivers/usb/host/ehci-sh.c
@@ -77,7 +77,6 @@ static co
On Tue, Mar 26, 2013 at 10:49:55AM +0800, Ming Lei wrote:
> Johan's 'fix use-after-free in TIOCMIWAIT' patchset[1] introduces
> one bug which can cause kernel hang when opening port.
>
> This patch initialized the 'port->delta_msr_wait' waitqueue head
> to fix the bug which is introduced in 3.9-rc
Hello again Alan, we read that the patch broke. Damn, our fear was
justified. If we are right, it will break again because it affects
various
devices using different busses, each one with its limitations and
defects. That's why we wrote to Sarah(and got no reply yet) that
vendors
should fix their h
Hi Alan,
I noticed when testing Arnd's patch that I get an unused function
warning:
drivers/usb/host/ehci-q.c:1320:13: warning:
‘unlink_empty_async_suspended’ defined but not used [-Wunused-function]
It looks like this function is called from ehci-hub.c:ehci_bus_suspend()
which is wrapped in a
On 26/03/13 06:03, Kishon Vijay Abraham I wrote:
> Hi,
>
> On Monday 25 March 2013 03:16 PM, Laxman Dewangan wrote:
>> On Monday 25 March 2013 03:02 PM, Kishon Vijay Abraham I wrote:
>>> From: Graeme Gregory
>>>
>>> This is the driver for the OTG transceiver built into the Palmas
>>> chip. It
>>>
On Tuesday 26 March 2013 02:31 PM, Graeme Gregory wrote:
On 26/03/13 06:03, Kishon Vijay Abraham I wrote:
+static int palmas_usb_read(struct palmas *palmas, unsigned int reg,
+ unsigned int *dest)
+{
+ unsigned int addr;
+ int slave;
+
+ slave = PALMAS_BASE_TO_SLA
Use the newly introduced devm_ioremap_resource() instead of
devm_request_and_ioremap() which provides more consistent error handling.
devm_ioremap_resource() provides its own error messages; so all explicit
error messages can be removed from the failure code paths.
Signed-off-by: Sachin Kamat
--
Marc Kleine-Budde writes:
> On 03/20/2013 02:37 PM, Alexander Shishkin wrote:
>> Marc Kleine-Budde writes:
>>
>>> On 03/20/2013 12:23 PM, Alexander Shishkin wrote:
Marc Kleine-Budde writes:
> On 03/20/2013 12:04 PM, Alexander Shishkin wrote:
>> Peter Chen writes:
>>
On 26/03/13 09:12, Laxman Dewangan wrote:
> On Tuesday 26 March 2013 02:31 PM, Graeme Gregory wrote:
>> On 26/03/13 06:03, Kishon Vijay Abraham I wrote:
+static int palmas_usb_read(struct palmas *palmas, unsigned int reg,
+ unsigned int *dest)
+{
+ unsigned i
On Tuesday 26 March 2013 02:57 PM, Graeme Gregory wrote:
On 26/03/13 09:12, Laxman Dewangan wrote:
On Tuesday 26 March 2013 02:31 PM, Graeme Gregory wrote:
But still you are using the PALMAS macro here and indirectly it is
tied up. It is not completely independent.
If need to be independent the
On 26/03/13 09:34, Laxman Dewangan wrote:
> On Tuesday 26 March 2013 02:57 PM, Graeme Gregory wrote:
>> On 26/03/13 09:12, Laxman Dewangan wrote:
>>> On Tuesday 26 March 2013 02:31 PM, Graeme Gregory wrote:
>>>
>>> But still you are using the PALMAS macro here and indirectly it is
>>> tied up. It i
Hi,
On Tue, Mar 26, 2013 at 11:33:44AM +0530, Kishon Vijay Abraham I wrote:
> >>+static int palmas_usb_write(struct palmas *palmas, unsigned int reg,
> >>+ unsigned int data)
> >>+{
> >>+ unsigned int addr;
> >>+ int slave;
> >>+
> >>+ slave = PALMAS_BASE_TO_SLAVE(P
Hi,
On Tue, Mar 26, 2013 at 09:01:42AM +, Graeme Gregory wrote:
> >>> From: Graeme Gregory
> >>>
> >>> This is the driver for the OTG transceiver built into the Palmas
> >>> chip. It
> >>> handles the various USB OTG events that can be generated by cable
> >>> insertion/removal.
> >>>
> >>> S
Okay, found the reason why no hidraw was created.
hid_scan_report in hid-core.c sets the hid->group to
HID_GROUP_SENSOR_HUB for devices that use the sensor page.
hid-generic cannot bind to this device group, unless I add a second
entry to its hid_table, with group HID_GROUP_SENSOR_HUB.
Woul
On Tuesday 26 March 2013 03:51 PM, Felipe Balbi wrote:
* PGP Signed by an unknown key
Hi,
On Tue, Mar 26, 2013 at 09:01:42AM +, Graeme Gregory wrote:
From: Graeme Gregory
This is the driver for the OTG transceiver built into the Palmas
chip. It
handles the various USB OTG events that can
On 25 March 2013 18:07, Alan Stern wrote:
> On Mon, 25 Mar 2013, David Linares wrote:
>
>> > Start with usbmon (see Documentation/usb/usbmon.txt).
>>
>> Thanks Alan. I have just compiled my kernel with debugfs and usbmon.
>> I can now easily capture raw text traces after boot-up. But I am interest
Peter Chen writes:
> On Wed, Mar 20, 2013 at 01:04:33PM +0200, Alexander Shishkin wrote:
>> Peter Chen writes:
>>
>> > On Fri, Mar 15, 2013 at 05:17:08PM +0200, Alexander Shishkin wrote:
>> >>
>> >> > Eg, for tablet or phone, the dr_mode may be "gadget", but the
>> >> > otg_capable = 1.
>> >>
On Tuesday 26 March 2013 03:21 PM, Graeme Gregory wrote:
On 26/03/13 09:34, Laxman Dewangan wrote:
Kishon,
I think it is very much possible. You can pass the interrupt throough
IRQ_RESOURCE and populate it from DT. If you provide proper interrupt
parent and irq number then irq framework take ca
On Tue, Mar 26, 2013 at 04:14:54PM +0800, victor yeo wrote:
> Hi,
>
> >> >> In the log file, is there any invalid request received on endpoint 0?
> >> >
> >> > In the usbmon file there is. It is this line:
> >> >
> >> >> f4ae6f40 1217192721 S Co:2:018:0 s 21 ff 0
> >>
> >> ok, i wi
Hi,
On Mon, Mar 25, 2013 at 05:03:35PM -0700, Paul Zimmerman wrote:
> Remove the unneeded struct device *dev argument from dwc2_hcd_init()
> and dwc2_hcd_remove(), and pass in the value through the hsotg->dev
> member instead
>
> Signed-off-by: Paul Zimmerman
looks alright:
Reviewed-by: Felipe
On Monday, March 25, 2013 04:33:02 PM Sarah Sharp wrote:
> On Mon, Mar 25, 2013 at 11:14:15PM +0100, Rafael J. Wysocki wrote:
> > On Monday, March 25, 2013 02:35:37 PM Sarah Sharp wrote:
> > > Alan,
> > >
> > > Is there a way to disable runtime PM for a PCI host controller, but
> > > still allow t
Michael Grzeschik writes:
> Hi Alexander, Fabio, Greg,
>
> On Mon, Mar 25, 2013 at 10:11:15AM -0300, Fabio Estevam wrote:
>> Hi Alexander,
>>
>> On Thu, Jan 24, 2013 at 7:42 AM, Alexander Shishkin
>> wrote:
>> > Peter Chen writes:
>> >
>> >> On Tue, Nov 27, 2012 at 05:16:55PM +0100, Michael Gr
Hi,
On Tue, Mar 26, 2013 at 03:58:41PM +0530, Laxman Dewangan wrote:
> On Tuesday 26 March 2013 03:51 PM, Felipe Balbi wrote:
> >* PGP Signed by an unknown key
> >
> >Hi,
> >
> >On Tue, Mar 26, 2013 at 09:01:42AM +, Graeme Gregory wrote:
> >From: Graeme Gregory
> >
> >This is the
Hi,
On Tue, Mar 26, 2013 at 02:08:05PM +0200, Alexander Shishkin wrote:
> > http://git.pengutronix.de/git/mgr/linux.git v3.9/topic/usb-phy
> > 4414a59 Merge 'v3.9/topic/usb-phy' into usb-3.9
> > a806027 usb: otg: mxs-phy: remove clkgate/sftrst clearing
> > 026881b usb: otg: mxs-phy: Improve mxs ph
Michael Grzeschik writes:
> Hi Alexander, Fabio, Greg,
>
Some more fun:
> /*
> * Peters branch already contain the usbmisc series,
> * but they never made it to ci-for-greg, although
> * Alexander already mentioned (24 Jan 2013) to queue them.
> */
> https://github.com/hzpeterchen/linux-usb
Greg KH writes:
> Ugh, this is getting to be a horrible mess.
>
> Alexander, what is going on here? You can't just constantly ignore
> patches, that's reserved for kernel developers with more experience :)
Long story short, I'm waiting for a coherent set of patches to arrive to
my inbox (I gues
Hi Alexander,
On Tue, Mar 26, 2013 at 02:29:40PM +0200, Alexander Shishkin wrote:
> Michael Grzeschik writes:
> Some more fun:
>
> > /*
> > * Peters branch already contain the usbmisc series,
> > * but they never made it to ci-for-greg, although
> > * Alexander already mentioned (24 Jan 2013)
Hello.
On 26-03-2013 12:26, Nobuhiro Iwamatsu wrote:
By commit 39d35681d5380b403855202dcd75575a8d5b0ec1,
Please also specify that commit's summary line in parens (or however you
like).
comma followed by
ehci_hcd_sh_remove has been deleted. This fixes the error by the correction.
Sig
On 26-03-2013 12:26, Nobuhiro Iwamatsu wrote:
By commit 39d35681d5380b403855202dcd75575a8d5b0ec1, comma followed by
Also, you probably wanted to say "following" instead of "followed by".
ehci_hcd_sh_remove has been deleted. This fixes the error by the correction.
Signed-off-by: Nobuhir
Greg KH writes:
> On Fri, Mar 22, 2013 at 04:32:35PM +0100, Henrik Grindal Bakken wrote:
>>
>> Hi. I work on a product which, sadly, is stuck on a vendor kernel based
>> on 2.6.37.
>
> Then I strongly suggest you get support for this issue from the vendor
> who is giving you this kernel, as you
On Mon, 25 Mar 2013, Sarah Sharp wrote:
> On Mon, Mar 25, 2013 at 11:14:15PM +0100, Rafael J. Wysocki wrote:
> > On Monday, March 25, 2013 02:35:37 PM Sarah Sharp wrote:
> > > Alan,
> > >
> > > Is there a way to disable runtime PM for a PCI host controller, but
> > > still allow the system to sus
On Tue, Mar 26, 2013 at 06:33:27AM +, Paul Zimmerman wrote:
> > From: Peter Chen
> > Sent: Monday, March 25, 2013 7:58 PM
> >
> > On Fri, Mar 22, 2013 at 02:20:23PM +0100, Michael Grzeschik wrote:
> > > The udc uses an shared dma memory space between hard and software. This
> > > memory layou
On Fri, Mar 22, 2013 at 06:04:29PM +0400, Sergei Shtylyov wrote:
> Hello.
>
> On 22-03-2013 17:20, Michael Grzeschik wrote:
>
> >The implementation is derived from the fsl_udc_core code in
> >fsl_ep_enable and makes basic iso handling possible.
>
> >Signed-off-by: Michael Grzeschik
> >Signed-of
On Fri, Mar 22, 2013 at 02:36:40PM +0100, Marc Kleine-Budde wrote:
> On 03/22/2013 02:20 PM, Michael Grzeschik wrote:
> > The implementation is derived from the fsl_udc_core code in
> > fsl_ep_enable and makes basic iso handling possible.
>
> If iso endpoints are fully supported you can update the
On Fri, Mar 22, 2013 at 06:07:26PM +0400, Sergei Shtylyov wrote:
> Hello.
>
> On 22-03-2013 17:20, Michael Grzeschik wrote:
>
> >The option gfp_flags is prepared in ep_queue and currently
> >not used. This patch propagates the flag through all users
> >down to the dma_pool_alloc function to consu
On Tue, 26 Mar 2013, victor yeo wrote:
> Hi,
>
> >> >> In the log file, is there any invalid request received on endpoint 0?
> >> >
> >> > In the usbmon file there is. It is this line:
> >> >
> >> >> f4ae6f40 1217192721 S Co:2:018:0 s 21 ff 0
> >>
> >> ok, i will add code to UDC t
On Tue, 26 Mar 2013, Tony Prisk wrote:
> Hi Alan,
>
> I noticed when testing Arnd's patch that I get an unused function
> warning:
>
> drivers/usb/host/ehci-q.c:1320:13: warning:
> ‘unlink_empty_async_suspended’ defined but not used [-Wunused-function]
>
>
> It looks like this function is call
This patch series intends to improve handling of SoC-specific differences
in Samsung USB PHY drivers, by reducing the need to explicitly check
SoC type using if and switch statements.
In addition, last patch adds support for Exynos 4x12, as this is simply
a matter of adding appropriate driver data
Since phy-samsung-usb library can be used only by phy-samsung-usb2 and
phy-samsung-usb3 drivers, there is no need to give explicit control over
its Kconfig symbol.
This patch makes CONFIG_SAMSUNG_USBPHY symbol hidden and selected
implicitly by CONFIG_SAMSUNG_USB2PHY and CONFIG_SAMSUNG_USB3PHY.
Si
There is no need to use devm_clk_get to get a clock that is being put
at the end of the function.
This patch changes the code getting reference clock to use clk_get
instead of useless in this case devm_clk_get.
Signed-off-by: Tomasz Figa
Signed-off-by: Kyungmin Park
---
drivers/usb/phy/phy-sam
This patch cleans up handling of reference clock rate in Samsung USB PHY
drivers. It is mostly a cosmetic change but improves error handling in
case of failing to get reference clock or invalid clock rate.
Signed-off-by: Tomasz Figa
Signed-off-by: Kyungmin Park
---
drivers/usb/phy/phy-samsung-u
This patch extends driver data structure with set_isolation callback,
which allows to remove the need for checking for SoC type in a switch
statement.
Signed-off-by: Tomasz Figa
Signed-off-by: Kyungmin Park
---
drivers/usb/phy/phy-samsung-usb.c | 36
driver
To remove unnecessary if statements, this patch introduces phy_enable
and phy_disable callbacks in driver data structure that implement
SoC-specific PHY initialization and deinitialization.
Signed-off-by: Tomasz Figa
Signed-off-by: Kyungmin Park
---
drivers/usb/phy/phy-samsung-usb.h | 2 ++
d
This patch adds driver data for Exynos 4x12 USB 2.0 PHY.
Signed-off-by: Tomasz Figa
Signed-off-by: Kyungmin Park
---
drivers/usb/phy/phy-samsung-usb.h | 1 +
drivers/usb/phy/phy-samsung-usb2.c | 18 ++
2 files changed, 19 insertions(+)
diff --git a/drivers/usb/phy/phy-samsung
Am Freitag, den 22.03.2013, 14:20 +0100 schrieb Michael Grzeschik:
> The udc uses an shared dma memory space between hard and software. This
> memory layout is described in ci13xxx_qh and ci13xxx_td which are marked
> with the attribute ((packed)).
>
> The packed attribute leads the compiler to ge
Hi,
>> >> ok, i will add code to UDC to instruct hardware to send NAK upon
>> >> receiving invalid request on endpoint 0. Does it mean that UDC driver
>> >> has to check for invalid request on endpoint 0?
>> >
>> > No. The UDC driver has no way to know whether a request is valid or
>> > not. Rea
On Tue, 26 Mar 2013, Noone Nowhere wrote:
> Hello again Alan, we read that the patch broke.
What patch? The one that works around the Intel/AMD hardware problem?
Yes, it had a mistake, which has now been fixed. (Although the fix has
not yet been released in a 3.8.stable kernel.)
> Damn, ou
On Tue, 26 Mar 2013, David Linares wrote:
> >> While enabling usbmon, I noticed something that can be related.
> >> There is a config: "Maximum VBUS Power usage" which is currently set to
> >> 300mA in my case.
> >
> > That option (USB_GADGET_VBUS_DRAW) applies only to gadgets. That is,
> > it's
On Tue, 26 Mar 2013, victor yeo wrote:
> Understand, UDC driver will call driver->setup(), and if the return
> value is negative, UDC driver has to set dev->protocol_stall = 1 and
> maybe call usb_ep_set_halt(). However, the hardware won't be able to
> send out zero length response.
Don't be sill
On Mon, 25 Mar 2013, Arnd Bergmann wrote:
> On Monday 25 March 2013, Alan Stern wrote:
> > >
> > > + if (!dev->dev.platform_data) {
> > > + dev->dev.platform_data = &ehci_platform_defaults;
> > > + dev->dev.dma_mask = &dev->dev.coherent_dma_mask;
> > > + d
On Mon, 25 Mar 2013, Sarah Sharp wrote:
Hi Petko,
I'm testing a USB to ethernet adapter with Greg's usb-linus branch (based
on 3.9-rc4). I'm seeing an odd behavior, and I'm suspicious that a
second behavior found by Stephen Hemminger may also be related:
http://marc.info/?l=linux-usb&m=136364
3.5.7.9 -stable review patch. If anyone has any objections, please let me know.
--
From: =?UTF-8?q?Fernando=20Luis=20V=C3=A1zquez=20Cao?=
commit 99d249021abd4341771523ed8dd7946276103432 upstream.
Document what the fix-up is does and make it more robust by ensuring
that it is on
3.5.7.9 -stable review patch. If anyone has any objections, please let me know.
--
From: =?UTF-8?q?Fernando=20Luis=20V=C3=A1zquez=20Cao?=
commit a464918419f94a0043d2f549d6defb4c3f69f68a upstream.
Some Vaio desktop computers, among them the VGC-LN51JGB multimedia PC, have
a RF r
On Tuesday 26 March 2013, Alan Stern wrote:
> That's up to platform guys. I wasn't aware of any common practice
> whereby drivers would fill in a missing dma_mask, except in the DT
> case.
I don't think we are consistent in any way. PowerPC sets up a 32 bit
DMA mask for all devices during DT pr
On Tue, Mar 26, 2013 at 04:15:36PM +0100, Lucas Stach wrote:
> Am Freitag, den 22.03.2013, 14:20 +0100 schrieb Michael Grzeschik:
> > The udc uses an shared dma memory space between hard and software. This
> > memory layout is described in ci13xxx_qh and ci13xxx_td which are marked
> > with the att
On 03/26/2013 04:28 AM, Laxman Dewangan wrote:
> On Tuesday 26 March 2013 03:51 PM, Felipe Balbi wrote:
>> On Tue, Mar 26, 2013 at 09:01:42AM +, Graeme Gregory wrote:
...
> + return regmap_read(palmas->regmap[slave], addr, dest);
>
>
> Please use the generic api for palmas
On 03/26/2013 03:27 AM, Graeme Gregory wrote:
...
> If we are tightly coupling as above then using platform_irq is an extra
> inefficiency. You both have to populate this then parse it afterwards.
> Why not just use the regmap helper? Ill admit this code is like this as
> there was a period where p
On Tue, Mar 26, 2013 at 01:12:25PM +0100, Rafael J. Wysocki wrote:
> On Monday, March 25, 2013 04:33:02 PM Sarah Sharp wrote:
> > On Mon, Mar 25, 2013 at 11:14:15PM +0100, Rafael J. Wysocki wrote:
> > > On Monday, March 25, 2013 02:35:37 PM Sarah Sharp wrote:
> > > > Alan,
> > > >
> > > > Is there
On Tue, Mar 26, 2013 at 12:11:13PM +0100, Yann Sionneau wrote:
> Le 25/03/2013 19:13, Sarah Sharp a écrit :
> > On Mon, Mar 25, 2013 at 05:43:40PM +0100, Yann Sionneau wrote:
> > Please compile with CONFIG_USB_DEBUG and CONFIG_USB_XHCI_HCD_DEBUGGING
> > turned on. If you can't reproduce your bug o
On 26/03/13 16:22, Stephen Warren wrote:
> On 03/26/2013 03:27 AM, Graeme Gregory wrote:
> ...
>> If we are tightly coupling as above then using platform_irq is an extra
>> inefficiency. You both have to populate this then parse it afterwards.
>> Why not just use the regmap helper? Ill admit this c
Its not needed to change the ZLT flag before every ep_prime. This patch moves
this to the ep_enable and applies it only for non configuration endpoints.
Signed-off-by: Michael Grzeschik
---
Changes since v1:
- rebased on the new alignment patch
drivers/usb/chipidea/udc.c | 3 ++-
1 file change
The datasheet of the synopsys core describes only to overwrite the
active and halted bits in the qhead before priming any endpoint.
Signed-off-by: Michael Grzeschik
---
Changes since v1:
- rebased on the new alignment patch
drivers/usb/chipidea/udc.c | 2 +-
1 file changed, 1 insertion(+), 1 d
The udc uses an shared dma memory space between hard and software. This
memory layout is described in ci13xxx_qh and ci13xxx_td which are marked
with the attribute ((packed)).
The compiler currently does not know about the alignment of the memory
layout, and will create strb and ldrb operations.
The prepared memory for the qhead needs to be contiguos and 2K aligned.
We change the code from allocating extra buffer for every ep qhead to
one big area. This patch lowers the amount of code to prepare the
memory.
Signed-off-by: Michael Grzeschik
---
Changes since v2:
- rebased on the new alig
The option gfp_flags is prepared in ep_queue and currently
not used. This patch propagates the flag through all users
down to the dma_pool_alloc function to consume it.
Signed-off-by: Michael Grzeschik
---
Changes since v1:
- rebased on the new alignment patch
- wrapped function definition of h
This patch reworks the cap value from several read
and write operations to one single operation.
Signed-off-by: Michael Grzeschik
---
Changes since v1:
- rebased on the new alignment patch
drivers/usb/chipidea/udc.c | 17 -
1 file changed, 8 insertions(+), 9 deletions(-)
diff
A static count of transfer descriptors was used everywhere in the driver
with the fixed number 5. This patch adds a define, named TD_PAGE_COUNT,
and replaces all users of this value. This way its possible to have only
one parameter to change and limit the amount of buffer pointers per TD.
Signed-o
The implementation is derived from the fsl_udc_core code in
fsl_ep_enable and makes basic iso handling possible.
Signed-off-by: Michael Grzeschik
Signed-off-by: Marc Kleine-Budde
---
Changes since v4:
- rebased on the new alignment patch
- changed indention to tabs
- removed spare brakets
-
Hi all,
this series fixes an issue which leads the hardware to get stuck after
reading dirty values from the shared memory mapped QHs and TDs. It also
changes the code to be more precise with the constraints from the
datasheet.
It adds support to handle requests which spawns into several TDs. And
There is no need to call ep_queue unlocked inside the own driver. We
move its functionionality into an unlocked version.
This patch removes potential unlocked timeslots inside
isr_setup_status_phase and isr_get_status_response, in which the lock
got released just before acquired again inside usb_e
This patch changes the read of the td status to one atomic operation to
analyse coherent bits.
Signed-off-by: Michael Grzeschik
---
Changes since v2:
- rebased on the new alignment patch
Changes since v1:
- fixed patch description
drivers/usb/chipidea/udc.c | 8 +---
1 file changed, 5 ins
This patch removes the limitation of having a limited amount of only
four active tds on one endpoint. We use the linked list implementation
to manage all tds which get added and removed by hardware_{en,de}queue.
Signed-off-by: Michael Grzeschik
---
Changes since v3:
- rebased on the new alignmen
Instead of having a limited number of usable tds in the udc we use a
linked list to support dynamic amount of needed tds for all special
gadget types. This improves throughput.
This patch also adresses a possible momory leak in _ep_nuke found
while porting the request handling to an linked list.
On Tue, Mar 26, 2013 at 05:22:07PM +0200, Petko Manolov wrote:
> On Mon, 25 Mar 2013, Sarah Sharp wrote:
>
> >Hi Petko,
> >
> >I'm testing a USB to ethernet adapter with Greg's usb-linus branch (based
> >on 3.9-rc4). I'm seeing an odd behavior, and I'm suspicious that a
> >second behavior found b
On Tue, 26 Mar 2013, Arnd Bergmann wrote:
> I think it's a horrible mess and if anyone has an idea of what the
> right solution is, we should probably implement that, but from what
> I see here, setting a 32-bit dma mask unless there is already one
> is a reasonable choice.
Okay.
> > Don't forge
On Tue, Mar 26, 2013 at 05:58:38PM +0100, Michael Grzeschik wrote:
> The datasheet of the synopsys core describes only to overwrite the
> active and halted bits in the qhead before priming any endpoint.
>
> Signed-off-by: Michael Grzeschik
> ---
> Changes since v1:
> - rebased on the new alignme
On Tue, Mar 26, 2013 at 05:58:37PM +0100, Michael Grzeschik wrote:
> The udc uses an shared dma memory space between hard and software. This
> memory layout is described in ci13xxx_qh and ci13xxx_td which are marked
> with the attribute ((packed)).
>
> The compiler currently does not know about th
Hi,
On Tue, Mar 26, 2013 at 05:58:40PM +0100, Michael Grzeschik wrote:
> Its not needed to change the ZLT flag before every ep_prime. This patch moves
> this to the ep_enable and applies it only for non configuration endpoints.
>
> Signed-off-by: Michael Grzeschik
> ---
> Changes since v1:
> -
On Tue, Mar 26, 2013 at 07:09:18PM +0200, Felipe Balbi wrote:
> Hi,
>
> On Tue, Mar 26, 2013 at 05:58:40PM +0100, Michael Grzeschik wrote:
> > Its not needed to change the ZLT flag before every ep_prime. This patch
> > moves
> > this to the ep_enable and applies it only for non configuration endp
On Tue, Mar 26, 2013 at 07:06:19PM +0200, Felipe Balbi wrote:
> On Tue, Mar 26, 2013 at 05:58:37PM +0100, Michael Grzeschik wrote:
> > The udc uses an shared dma memory space between hard and software. This
> > memory layout is described in ci13xxx_qh and ci13xxx_td which are marked
> > with the at
On Tue, Mar 26, 2013 at 07:05:35PM +0200, Felipe Balbi wrote:
> On Tue, Mar 26, 2013 at 05:58:38PM +0100, Michael Grzeschik wrote:
> > The datasheet of the synopsys core describes only to overwrite the
> > active and halted bits in the qhead before priming any endpoint.
> >
> > Signed-off-by: Mich
On Tue, 26 Mar 2013, Sarah Sharp wrote:
On Tue, Mar 26, 2013 at 05:22:07PM +0200, Petko Manolov wrote:
On Mon, 25 Mar 2013, Sarah Sharp wrote:
Hi Petko,
I'm testing a USB to ethernet adapter with Greg's usb-linus branch (based
on 3.9-rc4). I'm seeing an odd behavior, and I'm suspicious that
Hi,
On Tue, Mar 26, 2013 at 06:15:42PM +0100, Michael Grzeschik wrote:
> > > Its not needed to change the ZLT flag before every ep_prime. This patch
> > > moves
> > > this to the ep_enable and applies it only for non configuration endpoints.
> > >
> > > Signed-off-by: Michael Grzeschik
> > > --
On Tue, Mar 26, 2013 at 06:17:57PM +0100, Michael Grzeschik wrote:
> On Tue, Mar 26, 2013 at 07:06:19PM +0200, Felipe Balbi wrote:
> > On Tue, Mar 26, 2013 at 05:58:37PM +0100, Michael Grzeschik wrote:
> > > The udc uses an shared dma memory space between hard and software. This
> > > memory layout
Hi,
On Tue, Mar 26, 2013 at 06:18:13PM +0100, Michael Grzeschik wrote:
> > > The datasheet of the synopsys core describes only to overwrite the
> > > active and halted bits in the qhead before priming any endpoint.
> > >
> > > Signed-off-by: Michael Grzeschik
> > > ---
> > > Changes since v1:
>
Hi,
On Tue, Mar 26, 2013 at 05:58:41PM +0100, Michael Grzeschik wrote:
> This patch reworks the cap value from several read
> and write operations to one single operation.
>
> Signed-off-by: Michael Grzeschik
> ---
> Changes since v1:
> - rebased on the new alignment patch
>
> drivers/usb/chi
The current lpc32xx_defconfig breaks like this, caused by recent phy
restructuring:
LD init/built-in.o
drivers/built-in.o: In function `usb_hcd_nxp_probe':
drivers/usb/host/ohci-nxp.c:224: undefined reference to `isp1301_get_client'
drivers/built-in.o: In function `lpc32xx_udc_probe':
drive
Hi,
On Tue, Mar 26, 2013 at 05:58:42PM +0100, Michael Grzeschik wrote:
> The implementation is derived from the fsl_udc_core code in
> fsl_ep_enable and makes basic iso handling possible.
>
> Signed-off-by: Michael Grzeschik
> Signed-off-by: Marc Kleine-Budde
> ---
> Changes since v4:
> - reba
On Tue, Mar 26, 2013 at 05:58:43PM +0100, Michael Grzeschik wrote:
> There is no need to call ep_queue unlocked inside the own driver. We
> move its functionionality into an unlocked version.
>
> This patch removes potential unlocked timeslots inside
> isr_setup_status_phase and isr_get_status_res
Hi,
On Tue, Mar 26, 2013 at 05:58:44PM +0100, Michael Grzeschik wrote:
> The option gfp_flags is prepared in ep_queue and currently
> not used. This patch propagates the flag through all users
> down to the dma_pool_alloc function to consume it.
>
> Signed-off-by: Michael Grzeschik
makes sense:
Hi,
On Tue, Mar 26, 2013 at 05:58:45PM +0100, Michael Grzeschik wrote:
> A static count of transfer descriptors was used everywhere in the driver
> with the fixed number 5. This patch adds a define, named TD_PAGE_COUNT,
> and replaces all users of this value. This way its possible to have only
> o
Hi,
On Tue, Mar 26, 2013 at 05:58:47PM +0100, Michael Grzeschik wrote:
> Instead of having a limited number of usable tds in the udc we use a
> linked list to support dynamic amount of needed tds for all special
> gadget types. This improves throughput.
>
> This patch also adresses a possible mom
Hi,
On Tue, Mar 26, 2013 at 05:58:48PM +0100, Michael Grzeschik wrote:
> @@ -415,7 +409,19 @@ static int add_td_to_list(struct ci13xxx_ep *mEp, struct
> ci13xxx_req *mReq, unsi
> return -ENOMEM;
> }
>
> - setup_td_bits(node, length);
> + memset(node->ptr, 0, sizeof(s
On Tue, Mar 26, 2013 at 05:58:36PM +0100, Michael Grzeschik wrote:
> Hi all,
>
> this series fixes an issue which leads the hardware to get stuck after
> reading dirty values from the shared memory mapped QHs and TDs. It also
> changes the code to be more precise with the constraints from the
> da
Hi,
On Tue, Mar 26, 2013 at 06:36:01PM +0100, Roland Stigge wrote:
> The current lpc32xx_defconfig breaks like this, caused by recent phy
> restructuring:
which commit actually caused this ? I need to know to make sure if this
should be sent to stable or not.
--
balbi
signature.asc
Descriptio
Compiling with !CONFIG_PM generates an unused function warning on
unlink_empty_async_suspended().
Enclose the function and its forward declaration in a #ifdef CONFIG_PM
Signed-off-by: Tony Prisk
---
drivers/usb/host/ehci-q.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git
On Tuesday 26 March 2013, Florian Fainelli wrote:
>
> Just like the OHCI counter part we just can remove the architecture
> specific symbols which prevent these configuration symbols from being
> selected by platforms/architectures requiring it. The original
> implementation did not scale at all s
1 - 100 of 165 matches
Mail list logo
