Hi Paul,
> + /* Set device flags indicating whether the HCD supports DMA */
> + if (hsotg->core_params->dma_enable > 0) {
> + if (dma_set_mask(hsotg->dev, DMA_BIT_MASK(32)) < 0)
> + dev_warn(hsotg->dev,
> + "can't enable workarou
Hi Paul,
> I would prefer to keep that part of the code as-is for now. I haven't
> quite convinced myself that the function can never be called with
> halt_status = DWC2_HC_XFER_URB_DEQUEUE.
Ok. For arguments sake, it should be easy to convince yourself:
dwc2_hc_chhltd_intr is a static function o
On 2013/3/23 1:35, Alan Stern wrote:> Tianyu:
>
> Did you ever test the port power-off mechanism with system suspend?
> Right now it doesn't seem like it would work, because it relies on
> runtime PM to turn off the port power, and runtime PM doesn't operate
> normally during a system suspend.
>
Hi,
On Fri, Mar 22, 2013 at 05:27:26PM -0700, Paul Zimmerman wrote:
> We were setting the DMA masks in dwc2_driver_probe(), but that is
> before the driver parameters have been set to their default values.
> That meant the DMA masks could be set wrong. Fix it by moving the
> DMA mask setting into
On Fri, Mar 22, 2013 at 05:47:53PM -0700, Paul Zimmerman wrote:
> Previously, when an active urb was dequeued, its host channel would
> not always be released. There is some special handling for this in
> dwc2_hc_chhltd_intr_dma, but when it was the last urb/qtd in its qh, a
> safeguard in dwc2_hc_
On Fri, Mar 22, 2013 at 4:28 AM, Frank Rowand wrote:
>> I play upstream kernel on Pandaboard A1 frequently, looks not
>> see the failure problem before. Maybe the problem is config dependent.
>>
>> If you may share your config file, I'd like to do the test too.
3.9-rc2-20130314 doesn't have the p
