This patch reworks the videobuffer management logic present in the UVC
webcam gadget and ports it to use the "more apt" videobuf2 framework for
video buffer management.
To support routing video data captured from a real V4L2 video capture
device with a "zero copy" operation on videobuffers (as the
This patch adds the support for 'get_unmapped_area' in UVC gadget
which is called when the 'mmap' system call is executed on MMUless
architectures.
Signed-off-by: Bhupesh Sharma
---
drivers/usb/gadget/uvc_queue.c | 18 ++
drivers/usb/gadget/uvc_v4l2.c | 15 +++
2
This patchset tries to enhance the UVC webcam gadget driver and is based on
Laurent's git tree available here (head uvc-gadget):
git://linuxtv.org/pinchartl/uvcvideo.git
Note that to ease review and integration of these patches, I have rebased them
on Laurent's repo and all the relevant patches af
Usb port isn't assigned to any bus_type. This seems not good from
Greg's comments.
http://marc.info/?l=linux-usb&m=136200364929942&w=2
This patch is to register usb port to usb_bus_type. The usb port's
original name is "portX". This will cause name confilct after adding
usb port to usb_bus
Hi Frank,
On Thu, Mar 21, 2013 at 11:29 AM, Frank Rowand wrote:
>
> I found the problem on 3.6.11, but have not replicated it on 3.9-rcX
> yet because my config fails to build on 3.9-rc1 and 3.9-rc2. I'll try
> to work on that issue tomorrow.
I play upstream kernel on Pandaboard A1 frequently,
On Wed, Mar 20, 2013 at 9:09 PM, Felipe Balbi wrote:
> On Mon, Mar 18, 2013 at 03:55:29AM -0400, Chao Xie wrote:
>> The origianl understanding of clock is wrong. The OTG controller
>> only have one clock input.
>> Passing clock name by pdata is wrong. The clock is defined by device
>> iteself.
>>
Hi,
On Thursday 21 March 2013 02:46 PM, Chao Xie wrote:
On Wed, Mar 20, 2013 at 9:09 PM, Felipe Balbi wrote:
On Mon, Mar 18, 2013 at 03:55:29AM -0400, Chao Xie wrote:
The origianl understanding of clock is wrong. The OTG controller
only have one clock input.
Passing clock name by pdata is wro
On Thu, Mar 21, 2013 at 05:16:15PM +0800, Chao Xie wrote:
> On Wed, Mar 20, 2013 at 9:09 PM, Felipe Balbi wrote:
> > On Mon, Mar 18, 2013 at 03:55:29AM -0400, Chao Xie wrote:
> >> The origianl understanding of clock is wrong. The OTG controller
> >> only have one clock input.
> >> Passing clock na
Fix the following sparse warnings:
drivers/usb/gadget/net2272.c:916:13: warning: Using plain integer as NULL
pointer
drivers/usb/gadget/net2272.c:1624:9: warning: Using plain integer as NULL
pointer
drivers/usb/gadget/net2272.c:1552:30: warning: right shift by bigger than
source value
Note tha
Hi Greg,
Hopefully, this is my last round of fixes for v3.9-rc. Things seem to be
calming down.
Patches have been in my fixes branch for quite a while and I haven't heard
anything from Fengguang's 0-day kernel build.
I have also built this branch with the following defconfigs:
omap2plus
Remove redundant comments and fix some minor coding style issues.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/usb-serial.c | 20 +---
1 file changed, 5 insertions(+), 15 deletions(-)
diff --git a/drivers/usb/serial/usb-serial.c b/drivers/usb/serial/usb-serial.c
index a5e8
Pass usb-serial port rather than usb device to set_control_lines, and
make sure port device is used for all port related debugging.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/pl2303.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/usb/serial/pl230
This is v3 of the USB-disconnect series rebased on Linus tree of last
week (c41b3810c09) and the recently submitted fixes-series:
USB: fixes for 3.9-final
I retained Alan's ACK on the urb-poison patch.
This series fixes a bunch of issues related to device disconnect. As
the diffstat sho
Remove unnecessary disconnect test in tiocmset. No ioctls will be made
after disconnect returns.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/pl2303.c | 15 ---
1 file changed, 4 insertions(+), 11 deletions(-)
diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl230
Always try to disable the uart on close.
Since the switch to tty ports, close will be called as part of shutdown
before disconnect returns. Hence there is no need to check the
disconnected flag, and we can put devices in disabled states also on
driver unbind.
Signed-off-by: Johan Hovold
---
dri
Always try to disable the uart on close.
Since the switch to tty ports, close will be called as part of shutdown
before disconnect returns. Hence there is no need to check the
disconnected flag, and we can put devices in disabled states also on
driver unbind.
Signed-off-by: Johan Hovold
---
dri
Rename the tty-port callbacks using a common prefix to more clearly
separate them from the tty and usb driver callbacks.
Rename serial_down to serial_port_shutdown to match the callback name.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/usb-serial.c | 18 +-
1 file changed
Always try to disable the uart on close.
Since the switch to tty ports, close will be called as part of shutdown
before disconnect returns. Hence there is no need to check the
disconnected flag, and we can put devices in disabled states also on
driver unbind.
Signed-off-by: Johan Hovold
---
dri
Always try to disable the uart on close.
Since the switch to tty ports, close will be called as part of shutdown
before disconnect returns. Hence there is no need to check the
disconnected flag, and we can put devices in disabled states also on
driver unbind.
Signed-off-by: Johan Hovold
---
dri
Switch to the generic TIOCMIWAIT implementation which does not suffer
from the races involved when using the deprecated sleep_on functions.
This also fixes the issue with processes waiting for
modem-status-changes not being woken up at disconnect.
Signed-off-by: Johan Hovold
---
drivers/usb/ser
Remove bogus (and unnecessary) test for serial->dev being NULL in close.
The device is never cleared, and close is never called after a completed
disconnect anyway.
Remove some out-commented bogus code while at it.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/keyspan.c | 26 +++--
Remove kill of interrupt-in urb on close as it has never been submitted.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/iuu_phoenix.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/usb/serial/iuu_phoenix.c b/drivers/usb/serial/iuu_phoenix.c
index ff77027..a3bfcb3 100644
--- a/dri
Remove kill of interrupt-in urb on close as it has never been submitted.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/kl5kusb105.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/usb/serial/kl5kusb105.c b/drivers/usb/serial/kl5kusb105.c
index 769d910..57fd001 100644
--- a/dri
Use interface rather than usb-serial device for debugging interface
related operations. This gives more descriptive messages, such as
[ 905.669436] pl2303 1-4.1:1.0: 0x40:0x1:0x8:0x0 0
rather than
[ 341.943535] usb 1-4.1: 0x40:0x1:0x8:0x0 0
Signed-off-by: Johan Hovold
---
drivers/usb/seri
Failed allocations already get an OOM message and a stack dump.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/usb-serial.c | 37 +
1 file changed, 9 insertions(+), 28 deletions(-)
diff --git a/drivers/usb/serial/usb-serial.c b/drivers/usb/serial/usb-seri
Remove redundant port number from debug output (already printed as part
of device name).
Signed-off-by: Johan Hovold
---
drivers/usb/serial/generic.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/usb/serial/generic.c b/drivers/usb/serial/generic.c
index 4
Remove the port data refcounting and release the private data
explicitly at port remove.
The port data refcounting was used to make sure the port data was not
freed until the last tty reference was closed. Since moving over to tty
ports, the underlying assumptions are no longer valid as close is n
Remove redundant port number from debug output (already printed as part
of device name).
Signed-off-by: Johan Hovold
---
drivers/usb/serial/usb-serial.c | 39 ---
1 file changed, 20 insertions(+), 19 deletions(-)
diff --git a/drivers/usb/serial/usb-serial.c b
Hi!
Where could I read about it?
and where is the code?
I've found something looks like a pooling loop - drivers/usb/core/hub.c in the
"hub_events" function
is this it?
--
with best regards
Dmitry Bolshakov
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a
Add tiocmiwait operation to struct usb_serial_driver.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/usb-serial.c | 15 +++
include/linux/usb/serial.h | 1 +
2 files changed, 12 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/serial/usb-serial.c b/drivers/usb/serial
Remove bogus disconnect test for serial device being NULL in close. This
can never happen as close is guaranteed to be called before the last tty
reference is dropped (and port->serial is cleared).
Signed-off-by: Johan Hovold
---
drivers/usb/serial/garmin_gps.c | 4
1 file changed, 4 deleti
Switch to the generic TIOCMIWAIT implementation.
This also fixes the issue with processes waiting for
modem-status-changes not being woken up at disconnect.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/io_edgeport.c | 35 +--
drivers/usb/serial/io_tables.h
Reimplement device type detection using the device id table and quirks.
Device type was used to detect one device type which did not support to
control functions. Add quirks to the device table and store them in the
private port data at probe instead.
Signed-off-by: Johan Hovold
---
drivers/usb
Use tty-port modem-status-change wait queue on which processes are woken
up at hangup and disconnect.
Currently a process waiting on modem-status changes will not be woken on
device disconnect.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/cypress_m8.c | 4 ++--
1 file changed, 2 insertion
Break out TIOCMIWAIT handling from custom ioctl operation and use
tiocmiwait operation field instead.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/pl2303.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c
Switch to the generic get_icount implementation.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/ftdi_sio.c | 24 +---
1 file changed, 1 insertion(+), 23 deletions(-)
diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/ftdi_sio.c
index fa3077f..1199dc5 100644
Make sure processes waiting for modem-status changes are woken up at
disconnect.
This is needed for custom subdriver TIOCMIWAIT-implementations which do
not yet handle hangup.
Even though processes on the tty-port wait queue are woken up at hangup
the wake-up call in usb-serial disconnect is stil
Clean up this driver somewhat.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/spcp8x5.c | 72 +++-
1 file changed, 37 insertions(+), 35 deletions(-)
diff --git a/drivers/usb/serial/spcp8x5.c b/drivers/usb/serial/spcp8x5.c
index f34930c..a5c3a36 100644
Switch to the generic get_icount implementation.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/ti_usb_3410_5052.c | 44 ++-
1 file changed, 7 insertions(+), 37 deletions(-)
diff --git a/drivers/usb/serial/ti_usb_3410_5052.c
b/drivers/usb/serial/ti_usb_3410_
Replace custom ioctl operation with tiocmiwait.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/oti6858.c | 26 --
1 file changed, 4 insertions(+), 22 deletions(-)
diff --git a/drivers/usb/serial/oti6858.c b/drivers/usb/serial/oti6858.c
index 87c71cc..fd5dcb8 100644
-
Remove bogus (and unnecessary) test for serial->dev being NULL in close.
The device is never cleared, and close is never called after a completed
disconnect anyway.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/keyspan_pda.c | 9 ++---
1 file changed, 2 insertions(+), 7 deletions(-)
d
Switch to the generic TIOCMIWAIT implementation.
This also fixes the issue with processes waiting for
modem-status-changes not being woken up at disconnect.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/mct_u232.c | 58 ++-
1 file changed, 2 insertio
Switch to the generic get_icount implementation.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/ssu100.c | 55 +
1 file changed, 15 insertions(+), 40 deletions(-)
diff --git a/drivers/usb/serial/ssu100.c b/drivers/usb/serial/ssu100.c
index 45b8c29
Remove bogus (and unnecessary) test for serial->dev being NULL in close.
The device is never cleared, and close is never called after a completed
disconnect anyway.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/digi_acceleport.c | 92 ++--
1 file changed, 45
Remove bogus (and unnecessary) test for serial->dev being NULL in
dtr_rts.
The device is never cleared, and disconnect is handled for dtr_rts in
usb-serial core anyway.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/keyspan_pda.c | 10 --
1 file changed, 4 insertions(+), 6 deletions
Use tty-port modem-status-change wait queue on which processes are woken
up at hangup and disconnect.
Currently a process waiting on modem-status changes will not be woken on
device disconnect.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/f81232.c | 4 ++--
1 file changed, 2 insertions(+)
Use tty-port modem-status-change wait queue on which processes are woken
up at hangup and disconnect.
Currently a process waiting on modem-status changes will not be woken on
device disconnect.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/pl2303.c | 6 +++---
1 file changed, 3 insertions(
Remove broken TIOCMIWAIT support.
This drivers appears to implement TIOCMIWAIT but has no means of
receiving modem-status interrupts.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/spcp8x5.c | 68
1 file changed, 68 deletions(-)
diff --git a/dri
Remove disconnected test from close which did not protect any device IO
at all.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/cypress_m8.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/usb/serial/cypress_m8.c b/drivers/usb/serial/cypress_m8.c
index e4a62cf..d341555 10064
Use tty-port modem-status-change wait queue on which processes are woken
up at hangup and disconnect.
Currently a process waiting on modem-status changes will not be woken on
device disconnect.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/oti6858.c | 4 ++--
1 file changed, 2 insertions(+
Switch to the generic TIOCMIWAIT implementation.
This also fixes the issue with processes waiting for
modem-status-changes not being woken up at disconnect.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/quatech2.c | 50 ++-
1 file changed, 2 insertio
Switch to the generic get_icount implementation.
Note that the interrupt counters will no longer be reset at open which
is in accordance with which how the other drivers work.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/mos7840.c | 56 +++-
1 file
There is no need for the generic disconnect callback to stop the read
and write urbs a second time as this has already been taken care of by
close (which is called from hangup as part of disconnect).
Signed-off-by: Johan Hovold
---
drivers/usb/serial/generic.c | 12 +---
1 file changed,
Always try to disable the uart on close.
Since the switch to tty ports, close will be called as part of shutdown
before disconnect returns. Hence there is no need to check the
disconnected flag, and we can put devices in disabled states also on
driver unbind.
Signed-off-by: Johan Hovold
---
dri
Switch to the generic get_icount implementation.
Note that the interrupt counters will no longer be reset at open which
is in accordance with which how the other drivers work.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/io_edgeport.c | 45 +++-
drivers
Remove broken get_icount and TIOCMIWAIT support.
The driver has an icount structure but it is never been updated which
makes get_icount rather pointless and causes TIOCMIWAIT to always return
-EIO.
Note that the TIOCMIWAIT implementation has always been broken and would
not work even if icount su
Clean up modem status retrieval.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/spcp8x5.c | 18 +++---
1 file changed, 7 insertions(+), 11 deletions(-)
diff --git a/drivers/usb/serial/spcp8x5.c b/drivers/usb/serial/spcp8x5.c
index 5779dd8..e0093dd 100644
--- a/drivers/usb/serial
Always try to disable the uart on close.
Since the switch to tty ports, close will be called as part of shutdown
before disconnect returns. Hence there is no need to check the
disconnected flag, and we can put devices in disabled states also on
driver unbind.
Signed-off-by: Johan Hovold
---
dri
Update copyright information.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/ftdi_sio.c | 2 +-
drivers/usb/serial/generic.c| 2 +-
drivers/usb/serial/usb-serial.c | 1 +
3 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/f
Replace custom ioctl operation with tiocmiwait.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/ch341.c | 25 +++--
1 file changed, 3 insertions(+), 22 deletions(-)
diff --git a/drivers/usb/serial/ch341.c b/drivers/usb/serial/ch341.c
index 07d4650..1a97985 100644
--- a/dr
Remove bogus disconnect test for serial device being NULL in close. This
can never happen as close is guaranteed to be called before the last tty
reference is dropped (and port->serial is cleared).
Signed-off-by: Johan Hovold
---
drivers/usb/serial/iuu_phoenix.c | 5 -
1 file changed, 5 dele
Switch to the generic TIOCMIWAIT implementation which does not suffer
from the races involved when using the deprecated sleep_on functions.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/ftdi_sio.c | 36 ++--
1 file changed, 2 insertions(+), 34 deletions(-)
d
Remove SMP memory barriers from icount handling and rely on the barriers
implied by wait_event, sleep and locks, while using the port lock to
guarantee atomicity.
This is a step in moving over to the generic icount implementations.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/mos7840.c |
Use the port-data icount for interrupt counters.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/ftdi_sio.c | 31 ++-
1 file changed, 14 insertions(+), 17 deletions(-)
diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/ftdi_sio.c
index c575738..ea7433
Remove unnecessary disconnect test in tiocmset. No ioctls will be made
after disconnect returns.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/opticon.c | 16
1 file changed, 4 insertions(+), 12 deletions(-)
diff --git a/drivers/usb/serial/opticon.c b/drivers/usb/serial/op
Remove bogus (and unnecessary) test for serial->dev being NULL in close.
The device is never cleared, and close is never called after a completed
disconnect anyway.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/sierra.c | 39 +--
1 file changed, 17 inser
Remove unused, private modem-status wait queue from driver. If
TIOCMIWAIT is ever implemented it must not rely on a private wait queue
which may have been released when woken up.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/iuu_phoenix.c | 2 --
1 file changed, 2 deletions(-)
diff --git a
Switch to the generic TIOCMIWAIT implementation.
This also fixes the issue with processes waiting for
modem-status-changes not being woken up at disconnect.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/mos7840.c | 48 ++--
1 file changed, 2 insertio
Switch to the generic get_icount implementation.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/mct_u232.c | 40
1 file changed, 4 insertions(+), 36 deletions(-)
diff --git a/drivers/usb/serial/mct_u232.c b/drivers/usb/serial/mct_u232.c
index 06d5a60
Switch to the generic TIOCMIWAIT implementation which does not suffer
from the races involved when using the deprecated sleep_on functions.
This also fixes the issue with processes waiting for
modem-status-changes not being woken up at disconnect.
Signed-off-by: Johan Hovold
---
drivers/usb/ser
Remove bogus (and unnecessary) test for serial->dev being NULL in close.
The device is never cleared, and close is never called after a completed
disconnect anyway.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/iuu_phoenix.c | 13 +
1 file changed, 5 insertions(+), 8 deletions(
Remove the now empty generic disconnect callback and make the disconnect
callback non-mandatory.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/generic.c| 6 --
drivers/usb/serial/usb-serial.c | 4 ++--
include/linux/usb/serial.h | 1 -
3 files changed, 2 insertions(+), 9 deleti
Remove unused, private modem-status wait queue from driver. If
TIOCMIWAIT is ever implemented it must not rely on a private wait queue
which may have been released when woken up.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/digi_acceleport.c | 3 ---
1 file changed, 3 deletions(-)
diff --
Make sure we return 0 or a negative error number appropriate for
userspace on errors.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/pl2303.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c
index 997eba4..4d
Add generic TIOCMIWAIT implementation which correctly handles hangup,
USB-device disconnect, does not rely on the deprecated sleep_on
functions and hence does not suffer from the races currently affecting
several usb-serial drivers.
This makes it much easier to add TIOCMIWAIT support to subdrivers
Remove bogus (and unnecessary) test for serial->dev being NULL in close.
The device is never cleared, and close is never called after a completed
disconnect anyway.
Simplify urb killing, and remove some related debug and dead code while
at it.
Signed-off-by: Johan Hovold
---
drivers/usb/serial
Use tty-port modem-status-change wait queue on which processes are woken
up at hangup and disconnect.
Currently a process waiting on modem-status changes will not be woken on
device disconnect as wake up was only done in dtr_rts which isn't
guaranteed to be called (e.g. if HUPCL is not set).
Also
Switch to the generic get_icount implementation.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/quatech2.c | 51 ++-
1 file changed, 12 insertions(+), 39 deletions(-)
diff --git a/drivers/usb/serial/quatech2.c b/drivers/usb/serial/quatech2.c
index 75f
Remove empty generic release implementation and make the release
callback non-mandatory (like attach, probe and disconnect).
Signed-off-by: Johan Hovold
---
drivers/usb/serial/generic.c| 5 -
drivers/usb/serial/usb-serial.c | 3 +--
include/linux/usb/serial.h | 1 -
3 files changed,
Pass usb-serial port to the control functions for uart status and work
mode.
Use port device for debugging and use dev_err to report errors.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/spcp8x5.c | 54 +++-
1 file changed, 28 insertions(+), 26 delet
Make sure the interrupt urb submitted in port_probe is killed in
port_remove.
The interrupt-urb completion handler references the port and may get
called after port_remove has returned and the port has been
unregistered (although this is currently prevented by usb-serial core as
we are using a non
Remove bogus (and unnecessary) test for serial->dev being NULL in close.
The device is never cleared, and close is never called after a completed
disconnect anyway.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/ark3116.c | 17 +++--
1 file changed, 7 insertions(+), 10 deletions
Switch to the generic TIOCMIWAIT implementation which does not suffer
from the races involved when using the deprecated sleep_on functions.
This also fixes the issue with processes waiting for
modem-status-changes not being woken up at disconnect.
Signed-off-by: Johan Hovold
---
drivers/usb/ser
We should not call kill_traffic (and usb_kill_urb) once disconnect
returns. Any pending urbs are killed at disconnect and new submissions
are prevented by usb_unbind_interface (and usb_disable_interface).
Signed-off-by: Johan Hovold
---
drivers/usb/serial/usb-serial.c | 7 ---
1 file changed
Remove bogus (and unnecessary) test for serial->dev being NULL in close.
The device is never cleared, and close is never called after a completed
disconnect anyway.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/usb_wwan.c | 25 -
1 file changed, 12 insertions(+), 13
Remove bogus (and unnecessary) test for serial->dev being NULL in
cleanup.
The device is never cleared, and cleanup is never called after a
completed disconnect anyway.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/generic.c | 24 ++--
1 file changed, 10 insertions(+),
The disconnect callback is set to the generic implementation by
usb-serial core if NULL.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/ssu100.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/usb/serial/ssu100.c b/drivers/usb/serial/ssu100.c
index 4b2a197..97aca3f 100644
--- a/dr
Make sure to unregister the tty-device before calling subdriver
port_remove.
This way remove will reverse probe, and specifically any port data
released in port_remove will be available throughout tty unregister.
Note that the order currently does not matter as the tty-layer can make
callbacks al
The calls to usb_poison_urb and usb_unpoison_urb are expected to be
balanced. However, if an urb that has not yet been submitted is
poisoned, its reject counter will not be increased as its ep-field is
NULL. A consecutive call to unpoison will thus in fact poison the urb
as its reject counter will
Break out TIOCMIWAIT handling from custom ioctl operation and use
tiocmiwait operation field instead.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/f81232.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/usb/serial/f81232.c b/drivers/usb/serial/f81232.c
Remove broken uart-error handling.
This driver appears to implement uart-error handling but does not
receive status interrupts or status information with bulk in transfers.
Instead status was retrieved at open and used to flag only the first
bulk in transfer.
Signed-off-by: Johan Hovold
---
dr
Switch to the generic TIOCMIWAIT implementation.
This also fixes the issue with processes waiting for
modem-status-changes not being woken up at disconnect.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/ssu100.c | 50 ++---
1 file changed, 2 insertio
Switch to the generic get_icount implementation.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/ark3116.c | 58 ++--
1 file changed, 18 insertions(+), 40 deletions(-)
diff --git a/drivers/usb/serial/ark3116.c b/drivers/usb/serial/ark3116.c
index 3b811
Always try to disable the uart on close.
Since the switch to tty ports, close will be called as part of shutdown
before disconnect returns. Hence there is no need to check the
disconnected flag, and we can put devices in disabled states also on
driver unbind.
Signed-off-by: Johan Hovold
---
dri
Make sure we return 0 or a negative error number appropriate for
userspace on errors.
Currently 1 rather than 0 is returned on successful operation.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/opticon.c | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/driv
Use usb_poison_urb to reliably kill all urbs on disconnect and suspend.
This way there will be no question that the urbs cannot be resubmitted
by buggy subdrivers.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/usb-serial.c | 55 +++--
1 file changed, 37
Remove bogus disconnect test for serial device being NULL in read bulk
callback. This can never happen as the port read urb is killed (and
poisoned) at close, which in turn is guaranteed to be called before the
last tty reference is dropped (and port->serial is cleared).
Signed-off-by: Johan Hovol
Most USB serial drivers are, and should be, using as much of the generic
implementation as possible.
Rename the fixup_generic function to a more descriptive name.
Reword the related debug message in a more neutral tone (and remember to
add the missing newline).
Finally, move the operations initial
Remove the port MSR-wait queue now that all drivers have been migrated
to the tty-port queue.
Signed-off-by: Johan Hovold
---
include/linux/usb/serial.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/include/linux/usb/serial.h b/include/linux/usb/serial.h
index c786ee7..b9b0f7b4 100644
---
Remove bogus (and unnecessary) test for serial->dev being NULL in close.
The device is never cleared, and close is never called after a completed
disconnect anyway.
Signed-off-by: Johan Hovold
---
drivers/usb/serial/cyberjack.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff
1 - 100 of 154 matches
Mail list logo
