Re: [PATCH net,stable-3.8] net: cdc_ncm, cdc_mbim: allow user to prefer NCM for backwards compatibility

2013-03-15 Thread Bjørn Mork
Ben Hutchings writes: > On Thu, 2013-03-14 at 12:05 +0100, Bjørn Mork wrote: >> commit bd329e1 ("net: cdc_ncm: do not bind to NCM compatible MBIM devices") >> introduced a new policy, preferring MBIM for dual NCM/MBIM functions if >> the cdc_mbim driver was enabled. This caused a regression for

Re: Linux USB file storage gadget with new UDC

2013-03-15 Thread Felipe Balbi
Hi, On Fri, Mar 15, 2013 at 01:59:30PM +0800, victor yeo wrote: > For bulk transfer, the new UDC driver has one problem. When SCSI > Inquiry command is received, the UDC driver interrupt routine will > receive it first. However, the queue function is not yet called, and > queue buffer is not yet a

Re: [PATCH] drivers/usb/gadget: beautify code, delete unused code

2013-03-15 Thread Felipe Balbi
On Thu, Mar 14, 2013 at 03:34:31PM -0400, Alan Stern wrote: > On Thu, 14 Mar 2013, Felipe Balbi wrote: > > > Here's the diff which needs testing: > > Can't test the net2272 part. > > > diff --git a/drivers/usb/gadget/net2280.c b/drivers/usb/gadget/net2280.c > > index 691cc65..d23c1b8 100644 > >

Re: ccg USB gadget driver is now dead

2013-03-15 Thread Felipe Balbi
On Thu, Mar 14, 2013 at 03:25:05PM -0700, Greg KH wrote: > FYI, I just applied this patch to my staging and USB trees, hopefully > this makes some people here happy. > > > > From: Greg Kroah-Hartman > Date: Thu, 14 Mar 2013 15:22:40 -0700 > Subject: Staging: ccg: rem

Re: [PATCH] usb: gadget: f_mass_storage: add missing memory barrier for thread_wakeup_needed

2013-03-15 Thread Felipe Balbi
Hi, On Fri, Mar 15, 2013 at 09:25:28AM +0900, UCHINO Satoshi wrote: > Without this memory barrier, the file-storage thread may fail to > escape from the following while loop, because it may observe new > common->thread_wakeup_needed and old bh->state which are updated by > the callback functions.

Re: [PATCH 2/2] usb: dwc3: exynos: use clk_prepare_enable and clk_disable_unprepare

2013-03-15 Thread Felipe Balbi
Hi, On Fri, Mar 15, 2013 at 11:36:00AM +0530, Vivek Gautam wrote: > >> Convert clk_enable/clk_disable to clk_prepare_enable/clk_disable_unprepare > >> calls as required by common clock framework. > >> > >> Signed-off-by: Vivek Gautam > >> CC: Felipe Balbi > >> CC: Kukjin Kim > >> --- > >> driv

Re: [PATCH 14/14] usb: udc-core: add judgement logic for usb_gadget_connect

2013-03-15 Thread Felipe Balbi
Hi, On Fri, Mar 15, 2013 at 02:06:16PM +0800, Peter Chen wrote: > > > > > @@ -278,7 +278,10 @@ static int udc_bind_to_driver(struct usb_udc > > > > > *udc, struct usb_gadget_driver *dri > > > > > driver->unbind(gadget); > > > > > goto err1; > > > > > } > > > > >

Re: [PATCH 2/3] usb: phy: introduce ->set_vbus() method

2013-03-15 Thread Felipe Balbi
On Fri, Mar 15, 2013 at 02:15:16PM +0800, Peter Chen wrote: > On Thu, Mar 14, 2013 at 12:12:47PM +0200, Felipe Balbi wrote: > > Hi, > > > > On Thu, Mar 14, 2013 at 05:38:03PM +0800, Peter Chen wrote: > > > > > > @@ -160,6 +163,24 @@ usb_phy_shutdown(struct usb_phy *x) > > > > > > x->sh

[PATCH v4 0/2] ARM: Exynos5250: Enabling samsung usb phy

2013-03-15 Thread Vivek Gautam
Based on 'for-next' of linux-samsung tree with following patches from Doug on top: usb: Document clocks in samsung, exynos4210-ehci/ohci bindings ARM: dts: add usb 2.0 clock references to exynos5250 device tree Also depending upon following patch-series for Samsung-usb-phy driver: [PATCH v7 0/2] A

[PATCH v4 1/2] ARM: Exynos5250: Enabling samsung-usb2phy driver

2013-03-15 Thread Vivek Gautam
Adding usbphy node for Exynos5250 along with the necessary device data to be parsed. Signed-off-by: Vivek Gautam --- arch/arm/boot/dts/exynos5250.dtsi | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/ex

[PATCH v4 2/2] ARM: Exynos5250: Enabling samsung-usb3phy driver

2013-03-15 Thread Vivek Gautam
Adding usb3.0 phy node for Exynos5250 along with the necessary device data to be parsed. Signed-off-by: Vivek Gautam --- arch/arm/boot/dts/exynos5250.dtsi | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts

Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt responses)

2013-03-15 Thread Jiri Kosina
On Thu, 14 Mar 2013, Rafael J. Wysocki wrote: > > > commit 181380b702eee1a9aca51354d7b87c7b08541fcf > > > Author: Yinghai Lu > > > Date: Sat Feb 16 11:58:34 2013 -0700 > > > > > > PCI/ACPI: Don't cache _PRT, and don't associate them with bus numbers > > > > This patch __fixed__ this probl

[PATCH v5 3/3] ARM: exynos5: Enable XHCI support on exynos5

2013-03-15 Thread Vivek Gautam
This patch enables support for XHCI on exynos5 series of SOCs, to support host side USB 3.0 support. Signed-off-by: Vivek Gautam --- arch/arm/mach-exynos/Kconfig |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig i

[PATCH v5 0/3] ARM: Exynos5250: Enabling dwc3-exynos driver

2013-03-15 Thread Vivek Gautam
This patch-set is in continuation with patch-series: [PATCH v4 0/4] Enable ehci, ohci and dwc3 devices on exynos5250 out of which follwowing patches have been picked up: ARM: Exynos5250: Enabling ehci-s5p driver ARM: Exynos5250: Enabling ohci-exynos driver Based on following patch-set for Samsung'

[PATCH v5 2/3] ARM: exynos5250: dts: Enabling dwc3-exynos driver

2013-03-15 Thread Vivek Gautam
Adding DWC3 device tree node for Exynos5250 needed to parse device tree data. Signed-off-by: Vivek Gautam --- arch/arm/boot/dts/exynos5250.dtsi | 20 ++-- 1 files changed, 18 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exyn

[PATCH v5 1/3] usb: Add device tree bindings for dwc3-exynos

2013-03-15 Thread Vivek Gautam
Document device tree binding information as required by the Samsung' USB 3.0 controller. Signed-off-by: Vivek Gautam --- .../devicetree/bindings/usb/exynos-usb.txt | 34 1 files changed, 34 insertions(+), 0 deletions(-) diff --git a/Documentation/devicetree/bindin

Re: [PATCH 2/3] usb: phy: introduce ->set_vbus() method

2013-03-15 Thread Peter Chen
On Fri, Mar 15, 2013 at 09:53:27AM +0200, Felipe Balbi wrote: > On Fri, Mar 15, 2013 at 02:15:16PM +0800, Peter Chen wrote: > > On Thu, Mar 14, 2013 at 12:12:47PM +0200, Felipe Balbi wrote: > > > Hi, > > > > > > On Thu, Mar 14, 2013 at 05:38:03PM +0800, Peter Chen wrote: > > > > > > > @@ -160,6 +1

Re: [PATCH] usb: gadget: f_mass_storage: add missing memory barrier for thread_wakeup_needed

2013-03-15 Thread UCHINO Satoshi
Hi, On Fri, 15 Mar 2013 07:39:02, "Felipe Balbi" wrote: > Hi, > > On Fri, Mar 15, 2013 at 09:25:28AM +0900, UCHINO Satoshi wrote: >> Without this memory barrier, the file-storage thread may fail to >> escape from the following while loop, because it may observe new >> common->thread_wakeup_need

Re: [PATCH 2/3] usb: phy: introduce ->set_vbus() method

2013-03-15 Thread Felipe Balbi
Hi, On Fri, Mar 15, 2013 at 04:05:52PM +0800, Peter Chen wrote: > > > > > > > > @@ -160,6 +163,24 @@ usb_phy_shutdown(struct usb_phy *x) > > > > > > > > x->shutdown(x); > > > > > > > > } > > > > > > > > > > > > > > > > +static inline int > > > > > > > > +usb_phy_vbus_on(struct u

Re: Linux USB file storage gadget with new UDC

2013-03-15 Thread victor yeo
Hi, > On Fri, Mar 15, 2013 at 01:59:30PM +0800, victor yeo wrote: >> For bulk transfer, the new UDC driver has one problem. When SCSI >> Inquiry command is received, the UDC driver interrupt routine will >> receive it first. However, the queue function is not yet called, and >> queue buffer is not

Re: [PATCH 2/3] usb: phy: introduce ->set_vbus() method

2013-03-15 Thread Peter Chen
On Fri, Mar 15, 2013 at 10:11:04AM +0200, Felipe Balbi wrote: > Hi, > > > if you look at your PCB, VBUS, D+ and D- are directly routed to the PHY, > not the USB controller itself. > > If you read ULPI and UTMI specs, you'll see that there are methods for > the PHY to tell the USB controller abou

Re: Linux USB file storage gadget with new UDC

2013-03-15 Thread Felipe Balbi
On Fri, Mar 15, 2013 at 04:26:10PM +0800, victor yeo wrote: > Hi, > > > On Fri, Mar 15, 2013 at 01:59:30PM +0800, victor yeo wrote: > >> For bulk transfer, the new UDC driver has one problem. When SCSI > >> Inquiry command is received, the UDC driver interrupt routine will > >> receive it first. H

Re: [PATCH v3 2/7] USB: serial: comments on suspend failure

2013-03-15 Thread Johan Hovold
On Fri, Mar 15, 2013 at 12:08:54PM +0800, Ming Lei wrote: > If suspend callback fails in system sleep context, usb core will > ignore the failure and let system sleep go ahead further, so > this patch comments on the case and requires that serial->type->suspend() > MUST return 0 in system sleep con

[PATCH 0/9] usb: fix PHY error handling

2013-03-15 Thread Felipe Balbi
Hi Folks, this patch set depends on [1] which makes PHY layer *always* return an error as suggested by Alan Stern. I have compiled what I could, please go over the patches and give your Acked-by or NAK it if you think there's something wrong with any of the patches. cheers [1] http://marc.info/

[PATCH 1/9] usb: dwc3: fix PHY error handling

2013-03-15 Thread Felipe Balbi
PHY layer no longer returns NULL. It will return -ENXIO when PHY layer isn't enabled and we can use that to bail out instead of request a probe deferral. Signed-off-by: Felipe Balbi --- drivers/usb/dwc3/core.c | 24 ++-- 1 file changed, 22 insertions(+), 2 deletions(-) diff

[PATCH 2/9] usb: gadget: mv_udc_core: fix PHY error handling

2013-03-15 Thread Felipe Balbi
PHY layer no longer returns NULL. It will return -ENXIO when PHY layer isn't enabled and we can use that to bail out instead of request a probe deferral. Signed-off-by: Felipe Balbi --- drivers/usb/gadget/mv_udc_core.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git

[PATCH 3/9] usb: gadget: s3c-hsotg: fix PHY error handling

2013-03-15 Thread Felipe Balbi
PHY laye rno longer return NULL. We need to switch over from IS_ERR_OR_NULL() to IS_ERR(). Signed-off-by: Felipe Balbi --- drivers/usb/gadget/s3c-hsotg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/s3c-hsotg.c b/drivers/usb/gadget/s3c-hsotg.c index f1ce

[PATCH 4/9] usb: musb: omap2430: fix PHY error handling

2013-03-15 Thread Felipe Balbi
PHY layer no longer returns NULL. It will return -ENXIO when PHY layer isn't enabled and we can use that to bail out instead of request a probe deferral. Signed-off-by: Felipe Balbi --- drivers/usb/musb/omap2430.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/

[PATCH 6/9] usb: host: ehci-mv: fix PHY error handling

2013-03-15 Thread Felipe Balbi
PHY layer no longer returns NULL. We must switch from IS_ERR_OR_NULL() to IS_ERR(). Signed-off-by: Felipe Balbi --- drivers/usb/host/ehci-mv.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/usb/host/ehci-mv.c b/drivers/usb/host/ehci-mv.c index 97

[PATCH 8/9] usb: host: ehci-tegra: fix PHY error handling

2013-03-15 Thread Felipe Balbi
PHY layer no longer returns NULL, we must switch from IS_ERR_OR_NULL() to IS_ERR(). Signed-off-by: Felipe Balbi --- drivers/usb/host/ehci-tegra.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/usb/host/ehci-tegra.c b/drivers/usb/host/ehci-tegra.c index f

[PATCH 7/9] usb: host: ehci-s5p: fix PHY error handling

2013-03-15 Thread Felipe Balbi
PHY layer no longer returns NULL. We must switch from IS_ERR_OR_NULL() to IS_ERR(). Signed-off-by: Felipe Balbi --- drivers/usb/host/ehci-s5p.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/ehci-s5p.c b/drivers/usb/host/ehci-s5p.c index 20ebf6a..867a923 100

[PATCH 9/9] usb: host: ohci-exynos: fix PHY error handling

2013-03-15 Thread Felipe Balbi
PHY layer no longer returns NULL. We must switch from IS_ERR_OR_NULL() to IS_ERR(). Signed-off-by: Felipe Balbi --- drivers/usb/host/ohci-exynos.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/ohci-exynos.c b/drivers/usb/host/ohci-exynos.c index e3b7e85..4b

[PATCH 5/9] usb: host: ehci-msm: fix PHY error handling

2013-03-15 Thread Felipe Balbi
PHY layer no longer returns NULL. We must switch from IS_ERR_OR_NULL() to IS_ERR(). Signed-off-by: Felipe Balbi --- drivers/usb/host/ehci-msm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/ehci-msm.c b/drivers/usb/host/ehci-msm.c index 88a49c8..ebf4103 100

Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt responses)

2013-03-15 Thread Harald Arnesen
I have the same problem on my Lenovo T500. I think the graphics card is involved. This laptop has "hybrid graphics" - one Intel GMA 4500MHD and one ATI Mobility Radeon HD 3650. When I boot with the Intel card, I get "irq 16: nobody cared" during boot, not when I boot with the ATI card. And /proc/

Re: [PATCH 00/24] ARM: OMAP2+: Adapt to ehci-omap changes for 3.10

2013-03-15 Thread Roger Quadros
On 03/14/2013 06:54 PM, Tony Lindgren wrote: > * Roger Quadros [130314 08:45]: >> >> OK. Let me know how the below patch looks. After that, the board code >> will look like. >> >> static struct usbhs_phy_data phy_data[] = { >> { >> .reset_gpio = 147, >> .vcc_gpio = 1

Re: [PATCH v3 3/6] TTY: fix DTR being raised on hang up

2013-03-15 Thread Johan Hovold
On Wed, Mar 13, 2013 at 03:43:43PM -0400, Peter Hurley wrote: > On Thu, 2013-03-07 at 15:55 +0100, Johan Hovold wrote: > > Make sure to check ASYNC_INITIALISED before raising DTR when waking up > > from blocked open in tty_port_block_til_ready. > > > > Currently DTR could get raised at hang up as

Re: [PATCH v3 0/6] TTY: port hangup and close fixes

2013-03-15 Thread Johan Hovold
On Wed, Mar 13, 2013 at 03:50:32PM -0400, Peter Hurley wrote: > On Thu, 2013-03-07 at 15:55 +0100, Johan Hovold wrote: > > These patches against 3.9-rc1 fix a few issues with tty-port hangup and > > close. > > > > The first and fifth patch are essentially clean ups. > > > > The second and third p

Re: [PATCH 14/14] usb: udc-core: add judgement logic for usb_gadget_connect

2013-03-15 Thread Peter Chen
On Fri, Mar 15, 2013 at 09:51:29AM +0200, Felipe Balbi wrote: > > that's all wrong and needs to be fixed. UDC-core has to be the central > point for all these details. We start with the easiest way (call connect > unconditionally after gadget driver is loaded) and optimize it as we go > (making su

Re: [PATCH v3 0/7] ARM: dts: omap: Add dts data for USB

2013-03-15 Thread Benoit Cousson
Hi Kishon, On 03/13/2013 10:11 AM, kishon wrote: > Benoit, > > Will you be queuing this patch series? I'm reviewing them right now. Regards, Benoit > > Thanks > Kishon > > On Thursday 07 March 2013 07:05 PM, Kishon Vijay Abraham I wrote: >> Hi Benoit, >> >> Here are the dt data patches to ge

Re: Two remain problems at chipidea driver

2013-03-15 Thread Alexander Shishkin
Peter Chen writes: > On Thu, Mar 14, 2013 at 12:31:38PM +0200, Alexander Shishkin wrote: >> Peter Chen writes: >> >> > Hi Alex and all, >> > >> > Currently, we have two problems to block chipidea driver coming >> > development. >> > >> > As there are so many chipidea versions, we impossible to

Re: [PATCH 14/14] usb: udc-core: add judgement logic for usb_gadget_connect

2013-03-15 Thread Felipe Balbi
Hi, On Fri, Mar 15, 2013 at 06:04:08PM +0800, Peter Chen wrote: > On Fri, Mar 15, 2013 at 09:51:29AM +0200, Felipe Balbi wrote: > > > > that's all wrong and needs to be fixed. UDC-core has to be the central > > point for all these details. We start with the easiest way (call connect > > unconditi

Re: [PATCH v3 3/6] TTY: fix DTR being raised on hang up

2013-03-15 Thread Peter Hurley
On Fri, 2013-03-15 at 10:24 +0100, Johan Hovold wrote: > On Wed, Mar 13, 2013 at 03:43:43PM -0400, Peter Hurley wrote: > > On Thu, 2013-03-07 at 15:55 +0100, Johan Hovold wrote: > > > Make sure to check ASYNC_INITIALISED before raising DTR when waking up > > > from blocked open in tty_port_block_ti

Re: [PATCH v3 3/6] TTY: fix DTR being raised on hang up

2013-03-15 Thread Johan Hovold
On Fri, Mar 15, 2013 at 07:03:08AM -0400, Peter Hurley wrote: > On Fri, 2013-03-15 at 10:24 +0100, Johan Hovold wrote: > > On Wed, Mar 13, 2013 at 03:43:43PM -0400, Peter Hurley wrote: > > > On Thu, 2013-03-07 at 15:55 +0100, Johan Hovold wrote: > > > > Make sure to check ASYNC_INITIALISED before r

Re: [PATCH v3 3/6] TTY: fix DTR being raised on hang up

2013-03-15 Thread Peter Hurley
On Fri, 2013-03-15 at 12:30 +0100, Johan Hovold wrote: > On Fri, Mar 15, 2013 at 07:03:08AM -0400, Peter Hurley wrote: > > On Fri, 2013-03-15 at 10:24 +0100, Johan Hovold wrote: > > > On Wed, Mar 13, 2013 at 03:43:43PM -0400, Peter Hurley wrote: > > > > On Thu, 2013-03-07 at 15:55 +0100, Johan Hovo

Re: [PATCH v2 2/4] usb: otg: twl4030: use devres API for regulator get and request irq

2013-03-15 Thread Grazvydas Ignotas
On Thu, Mar 14, 2013 at 5:48 PM, Felipe Balbi wrote: > On Thu, Mar 14, 2013 at 11:53:57AM +0530, Kishon Vijay Abraham I wrote: >> Used devres APIs devm_request_threaded_irq and devm_regulator_get for >> requesting irq and for getting regulator respectively. >> >> Signed-off-by: Kishon Vijay Abraha

Re: [PATCH v2 33/85] USB: serial: clean up usb-serial bus device removal

2013-03-15 Thread Peter Hurley
On Thu, 2013-03-14 at 19:30 +0100, Johan Hovold wrote: > On Thu, Mar 14, 2013 at 01:39:39PM -0400, Peter Hurley wrote: > > On Thu, 2013-03-14 at 16:23 +0100, Johan Hovold wrote: > > > Make sure to unregister the tty-device before calling subdriver > > > port_remove. > > > > > > This way remove wil

Re: [PATCH v2 2/4] usb: otg: twl4030: use devres API for regulator get and request irq

2013-03-15 Thread Felipe Balbi
On Fri, Mar 15, 2013 at 02:00:33PM +0200, Grazvydas Ignotas wrote: > On Thu, Mar 14, 2013 at 5:48 PM, Felipe Balbi wrote: > > On Thu, Mar 14, 2013 at 11:53:57AM +0530, Kishon Vijay Abraham I wrote: > >> Used devres APIs devm_request_threaded_irq and devm_regulator_get for > >> requesting irq and f

Re: Two remain problems at chipidea driver

2013-03-15 Thread Peter Chen
On Fri, Mar 15, 2013 at 12:38:07PM +0200, Alexander Shishkin wrote: > >> > >> I'd say, in the core driver: > >> 1) get dr_mode from platform data > >> 2) only if that's DR_MODE_UNKNOWN (iirc), read DCCPARAMS, since it's > >> not guaranteed to work across all chipideas; > >> 3) if dr_mode =

Re: [PATCH v3] usb: phy: add R-Car USB phy driver

2013-03-15 Thread Sergei Shtylyov
Hello. On 15-03-2013 4:25, Kuninori Morimoto wrote: 0x === EHCI -- 0x0094 PHY 0x009C PHY -- EHCI 0x0400 == ... 0x0800 -- PHY 0x0900

Re: [PATCH 14/14] usb: udc-core: add judgement logic for usb_gadget_connect

2013-03-15 Thread Peter Chen
On Fri, Mar 15, 2013 at 12:37:01PM +0200, Felipe Balbi wrote: > > */ > > static inline int usb_gadget_disconnect(struct usb_gadget *gadget) > > { > > + int ret = 0; > > + > > if (!gadget->ops->pullup) > > return -EOPNOTSUPP; > > - return gadget->ops->pullup(gadget, 0); > > +

Re: Testing for hardware bug in EHCI controllers

2013-03-15 Thread Noone Nowhere
Hello Alan again, we will clear things up. Sorry for the late reply, dark forces delayed us. > Intel probably doesn't care, because they don't make the affected > chipsets any more. I don't know what AMD is currently making. Do you? Yes we do. One of our ICH5 board uses ICH5 with SL7YC SL spec

Re: Testing for hardware bug in EHCI controllers

2013-03-15 Thread Noone Nowhere
Hello ,here are the logs from the failing EHCI hosts(chipset-SL Spec/revision@mainboard-system): ICH4-SL66K@FIC VC37 00:1d.7 USB Controller [0c03]: Intel Corporation 82801DB/DBM (ICH4/ICH4-M) USB2 EHCI Controller [8086:24cd] (rev 01) (prog-if 20 [EHCI]) Subsystem: FIRST INTERNATIONAL Comp

Re: [PATCH v3 0/7] ARM: dts: omap: Add dts data for USB

2013-03-15 Thread Benoit Cousson
+ Jon Hi Kishon, On 03/07/2013 02:35 PM, Kishon Vijay Abraham I wrote: > Hi Benoit, > > Here are the dt data patches to get usb device functional in OMAP platforms. > > All the patches deal with modifying arch/arm/boot except one which modifies > Documentation/../usb/omap-usb.txt > > Changes f

Re: Two remain problems at chipidea driver

2013-03-15 Thread Matthieu CASTET
Peter Chen a écrit : > On Fri, Mar 15, 2013 at 12:38:07PM +0200, Alexander Shishkin wrote: Do you see any problems with this? >>> How to know vbus status if dr_mode == gadget, we need to indicate connection >>> and disconnection? >> We don't. Do we need to indicate vbus session valid for gadge

[PATCH 4/4] usb: otg: twl4030: fix cold plug on OMAP3

2013-03-15 Thread Kishon Vijay Abraham I
Having twl4030_usb_phy_init() (detects if a cable is connected before twl4030 is probed) in twl4030 probe makes cable connect events to be missed by musb glue, since it gets loaded after twl4030. Having twl4030_usb_phy_init as a usb_phy ops lets twl4030_usb_phy_init to be called when glue is ready.

[PATCH 3/4] usb: otg: twl4030: use devres API for regulator get and request irq

2013-03-15 Thread Kishon Vijay Abraham I
Used devres APIs devm_request_threaded_irq and devm_regulator_get for requesting irq and for getting regulator respectively. Signed-off-by: Kishon Vijay Abraham I Tested-by: Grazvydas Ignotas --- drivers/usb/phy/phy-twl4030-usb.c | 28 1 file changed, 8 insertions

[PATCH 2/4] usb: musb: gadget: do *unmap_dma_buffer* only for valid DMA addr

2013-03-15 Thread Kishon Vijay Abraham I
musb does not use DMA buffer for ep0 but it uses the same giveback function *musb_g_giveback* for all endpoints (*musb_g_ep0_giveback* calls *musb_g_giveback*). So for ep0 case request.dma will be '0' and will result in kernel OOPS if tried to *unmap_dma_buffer* for requests in ep0. Fixed it by doi

[PATCH 1/4] usb: Fix linker errors during build

2013-03-15 Thread Kishon Vijay Abraham I
commit 63378a (usb: phy: remove CONFIG_USB_OTG_UTILS) removed CONFIG_USB_OTG_UTILS from Kconfig but failed to removed from Makefile. Fixed it here. Signed-off-by: Kishon Vijay Abraham I --- drivers/usb/Makefile |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/Ma

Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt responses)

2013-03-15 Thread Jiri Kosina
On Fri, 15 Mar 2013, Harald Arnesen wrote: > I have the same problem on my Lenovo T500. I think the graphics card is > involved. > > This laptop has "hybrid graphics" - one Intel GMA 4500MHD and one ATI > Mobility Radeon HD 3650. When I boot with the Intel card, I get "irq 16: > nobody cared" dur

Re: [PATCH v3 0/7] ARM: dts: omap: Add dts data for USB

2013-03-15 Thread kishon
On Friday 15 March 2013 06:11 PM, Benoit Cousson wrote: + Jon Hi Kishon, On 03/07/2013 02:35 PM, Kishon Vijay Abraham I wrote: Hi Benoit, Here are the dt data patches to get usb device functional in OMAP platforms. All the patches deal with modifying arch/arm/boot except one which modifies D

Re: [PATCH] usb: gadget: f_mass_storage: add missing memory barrier for thread_wakeup_needed

2013-03-15 Thread Michal Nazarewicz
On Fri, Mar 15 2013, UCHINO Satoshi wrote: > Without this memory barrier, the file-storage thread may fail to > escape from the following while loop, because it may observe new > common->thread_wakeup_needed and old bh->state which are updated by > the callback functions. > > /* Wait for the

Re: [PATCH 1/4] usb: Fix linker errors during build

2013-03-15 Thread Felipe Balbi
On Fri, Mar 15, 2013 at 06:58:49PM +0530, Kishon Vijay Abraham I wrote: > commit 63378a (usb: phy: remove CONFIG_USB_OTG_UTILS) removed > CONFIG_USB_OTG_UTILS from Kconfig but failed to removed from Makefile. > Fixed it here. > > Signed-off-by: Kishon Vijay Abraham I I can fold it in original co

Re: [PATCH 2/4] usb: musb: gadget: do *unmap_dma_buffer* only for valid DMA addr

2013-03-15 Thread Felipe Balbi
On Fri, Mar 15, 2013 at 06:58:50PM +0530, Kishon Vijay Abraham I wrote: > musb does not use DMA buffer for ep0 but it uses the same giveback > function *musb_g_giveback* for all endpoints (*musb_g_ep0_giveback* calls > *musb_g_giveback*). So for ep0 case request.dma will be '0' > and will result in

Re: [PATCH] USB: EHCI: fix for leaking isochronous data

2013-03-15 Thread Alan Stern
On Fri, 15 Mar 2013, Soeren Moch wrote: > > The log shows a 1-1 match between allocations and deallocations, except > > for three excess allocations about 45 lines before the end. I have no > > idea what's up with those. They may be an artifact arising from where > > you stopped copying the log

[PATCH] usb: musb: gadget: do *unmap_dma_buffer* only for valid DMA addr

2013-03-15 Thread Felipe Balbi
From: Kishon Vijay Abraham I musb does not use DMA buffer for ep0 but it uses the same giveback function *musb_g_giveback* for all endpoints (*musb_g_ep0_giveback* calls *musb_g_giveback*). So for ep0 case request.dma will be '0' and will result in kernel OOPS if tried to *unmap_dma_buffer* for r

Re: [PATCH 1/1] usb: xhci: fix build warning

2013-03-15 Thread Alan Stern
On Fri, 15 Mar 2013, Peter Chen wrote: > On Thu, Mar 14, 2013 at 10:59:45AM -0400, Alan Stern wrote: > > On Thu, 14 Mar 2013, Peter Chen wrote: > > > > > /home/b29397/work/code/git/linus/linux-2.6/drivers/usb/host/xhci-ring.c: > > > In function ‘handle_port_status’: > > > /home/b29397/work/code/

Re: [PATCH] drivers/usb/gadget: beautify code, delete unused code

2013-03-15 Thread Alan Stern
On Fri, 15 Mar 2013, Felipe Balbi wrote: > > Adding this back in revealed a bug in udc-core. It is fixed as > > follows: > > > > Index: usb-3.9/drivers/usb/gadget/udc-core.c > > === > > --- usb-3.9.orig/drivers/usb/gadget/udc-core.

Re: Linux USB file storage gadget with new UDC

2013-03-15 Thread Alan Stern
On Fri, 15 Mar 2013, Felipe Balbi wrote: > On Fri, Mar 15, 2013 at 04:26:10PM +0800, victor yeo wrote: > > Hi, > > > > > On Fri, Mar 15, 2013 at 01:59:30PM +0800, victor yeo wrote: > > >> For bulk transfer, the new UDC driver has one problem. When SCSI > > >> Inquiry command is received, the UDC

Re: [PATCH 0/9] usb: fix PHY error handling

2013-03-15 Thread Alan Stern
On Fri, 15 Mar 2013, Felipe Balbi wrote: > Hi Folks, > > this patch set depends on [1] which makes PHY layer > *always* return an error as suggested by Alan Stern. > > I have compiled what I could, please go over the > patches and give your Acked-by or NAK it if you think > there's something wro

Re: Testing for hardware bug in EHCI controllers

2013-03-15 Thread Alan Stern
On Fri, 15 Mar 2013, Noone Nowhere wrote: > Hello Alan again, we will clear things up. Sorry for the late reply, > dark forces delayed us. > > > > Intel probably doesn't care, because they don't make the affected > > chipsets any more. I don't know what AMD is currently making. Do you? > > Ye

Re: ccg USB gadget driver is now dead

2013-03-15 Thread Greg KH
On Fri, Mar 15, 2013 at 09:37:02AM +0200, Felipe Balbi wrote: > On Thu, Mar 14, 2013 at 03:25:05PM -0700, Greg KH wrote: > > FYI, I just applied this patch to my staging and USB trees, hopefully > > this makes some people here happy. > > > > > > > > From: Greg Kroah-H

Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt responses)

2013-03-15 Thread Jiri Kosina
On Fri, 15 Mar 2013, Jiri Kosina wrote: > > I have the same problem on my Lenovo T500. I think the graphics card is > > involved. > > > > This laptop has "hybrid graphics" - one Intel GMA 4500MHD and one ATI > > Mobility Radeon HD 3650. When I boot with the Intel card, I get "irq 16: > > nobody c

Re: Two remain problems at chipidea driver

2013-03-15 Thread Alexander Shishkin
Peter Chen writes: > On Fri, Mar 15, 2013 at 12:38:07PM +0200, Alexander Shishkin wrote: >> >> >> >> I'd say, in the core driver: >> >> 1) get dr_mode from platform data >> >> 2) only if that's DR_MODE_UNKNOWN (iirc), read DCCPARAMS, since it's >> >> not guaranteed to work across all chipi

[PATCH v2 22/23] ARM: dts: OMAP3: Add HS USB Host IP nodes

2013-03-15 Thread Roger Quadros
Adds device nodes for HS USB Host module, TLL module, OHCI and EHCI controllers. CC: Benoît Cousson Signed-off-by: Roger Quadros --- arch/arm/boot/dts/omap3.dtsi | 31 +++ 1 files changed, 31 insertions(+), 0 deletions(-) diff --git a/arch/arm/boot/dts/omap3.dtsi

[PATCH v2 23/23] ARM: dts: omap3-beagle: Add USB Host support

2013-03-15 Thread Roger Quadros
Provide RESET and Power regulators for the USB PHY, the USB Host port mode and the PHY device. Also provide pin multiplexer information for USB host pins. CC: Benoît Cousson Signed-off-by: Roger Quadros --- arch/arm/boot/dts/omap3-beagle.dts | 71 1 files

[PATCH v2 15/23] ARM: OMAP3: omap3pandora: Adapt to ehci-omap changes

2013-03-15 Thread Roger Quadros
Add platform device for 'nop-usb-xceiv'. This will be used as a PHY for HS USB Port 2, so provide binding information for it. Use usbhs_init_phys() to register the PHY's RESET regulator. VAUX2 supplies the PHY's VCC. Signed-off-by: Roger Quadros --- arch/arm/mach-omap2/board-omap3pandora.c |

[PATCH v2 17/23] ARM: OMAP3: omap3touchbook: Adapt to ehci-omap changes

2013-03-15 Thread Roger Quadros
Add 2 platform devices for 'nop-usb-xceiv'. These will be used as a PHY for HS USB Ports 1 and 2, so provide binding information for them. Use usbhs_init_phys() to register the PHY's RESET regulator. Signed-off-by: Roger Quadros --- arch/arm/mach-omap2/board-omap3touchbook.c | 38

[PATCH v2 16/23] ARM: OMAP3: omap3stalker: Adapt to ehci-omap changes

2013-03-15 Thread Roger Quadros
Add platform device for 'nop-usb-xceiv'. This will be used as a PHY for HS USB Port 2, so provide binding information for it. Use usbhs_init_phys() to register the PHY's RESET regulator. Signed-off-by: Roger Quadros --- arch/arm/mach-omap2/board-omap3stalker.c | 29 ++-

[PATCH v2 20/23] ARM: dts: OMAP4: Add HS USB Host IP nodes

2013-03-15 Thread Roger Quadros
Adds device nodes for HS USB Host module, TLL module, OHCI and EHCI controllers. CC: Benoît Cousson Signed-off-by: Roger Quadros --- arch/arm/boot/dts/omap4.dtsi | 30 ++ 1 files changed, 30 insertions(+), 0 deletions(-) diff --git a/arch/arm/boot/dts/omap4.dtsi b

[PATCH v2 21/23] ARM: dts: omap4-panda: Add USB Host support

2013-03-15 Thread Roger Quadros
Provide the RESET and Power regulators for the USB PHY, the USB Host port mode and the PHY device. Also provide pin multiplexer information for the USB host pins. CC: Benoît Cousson Signed-off-by: Roger Quadros --- arch/arm/boot/dts/omap4-panda.dts | 56 +

[PATCH v2 19/23] ARM: OMAP: zoom: Adapt to ehci-omap changes

2013-03-15 Thread Roger Quadros
Add platform device for 'nop-usb-xceiv'. This will be used as a PHY for HS USB Port 2, so provide binding information for it. Use usbhs_init_phys() to register the PHY's RESET regulator. Signed-off-by: Roger Quadros --- arch/arm/mach-omap2/board-zoom.c | 32 ++-- 1

[PATCH v2 18/23] ARM: OMAP3: overo: Adapt to ehci-omap changes

2013-03-15 Thread Roger Quadros
Add platform device for 'nop-usb-xceiv'. This will be used as a PHY for HS USB Port 2, so provide binding information for it. Use usbhs_init_phys() to register the PHY's RESET regulator. Signed-off-by: Roger Quadros --- arch/arm/mach-omap2/board-overo.c | 32 ++--

[PATCH v2 06/23] ARM: OMAP3: 3430SDP: Adapt to ehci-omap changes

2013-03-15 Thread Roger Quadros
Add 2 platform devices for 'nop-usb-xceiv'. These will be used as PHYs for HS USB ports 1 and 2 so provide binding information for them. Use usbhs_init_phys() to register the PHY's RESET regulators. Signed-off-by: Roger Quadros --- arch/arm/mach-omap2/board-3430sdp.c | 47

[PATCH v2 08/23] ARM: OMAP: AM3517crane: Adapt to ehci-omap changes

2013-03-15 Thread Roger Quadros
Add platform device for 'nop-usb-xceiv'. This will be used as a PHY for HS USB Port 1, so provide binding information for it. Use usbhs_init_phys() to register the PHY's VCC and RESET regulators. Signed-off-by: Roger Quadros --- arch/arm/mach-omap2/board-am3517crane.c | 38 +++

[PATCH v2 10/23] ARM: OMAP3: cm-t35: Adapt to ehci-omap changes

2013-03-15 Thread Roger Quadros
Add 2 platform devices for 'nop-usb-xceiv'. These will be used as PHYs for HS USB ports 1 and 2 so provide binding information for them. Use usbhs_init_phys() to register the PHY's RESET regulators. Signed-off-by: Roger Quadros --- arch/arm/mach-omap2/board-cm-t35.c | 45 +

[PATCH v2 13/23] ARM: OMAP3: igep0020: Adapt to ehci-omap changes

2013-03-15 Thread Roger Quadros
Add 2 platform devices for 'nop-usb-xceiv'. These will be used as PHYs for HS USB ports 1 and 2 so provide binding information for them. Use usbhs_init_phys() to register the PHY's RESET regulators. Signed-off-by: Roger Quadros --- arch/arm/mach-omap2/board-igep0020.c | 66 +++

[PATCH v2 14/23] ARM: OMAP3: omap3evm: Adapt to ehci-omap changes

2013-03-15 Thread Roger Quadros
Add platform device for 'nop-usb-xceiv'. This will be used as a PHY for HS USB Port 2, so provide binding information for it. Use usbhs_init_phys() to register the PHY's RESET regulator. VAUX2 supplies the PHY's VCC. Signed-off-by: Roger Quadros --- arch/arm/mach-omap2/board-omap3evm.c | 41 +

[PATCH v2 12/23] ARM: OMAP: devkit8000: Adapt to ehci-omap changes

2013-03-15 Thread Roger Quadros
Add platform device for 'nop-usb-xceiv'. This will be used as a PHY for HS USB Port 1, so provide binding information for it. Signed-off-by: Roger Quadros Acked-by: Felipe Balbi --- arch/arm/mach-omap2/board-devkit8000.c | 20 1 files changed, 12 insertions(+), 8 deletion

Re: [PATCH v2 33/85] USB: serial: clean up usb-serial bus device removal

2013-03-15 Thread Johan Hovold
On Fri, Mar 15, 2013 at 08:02:45AM -0400, Peter Hurley wrote: > On Thu, 2013-03-14 at 19:30 +0100, Johan Hovold wrote: > > On Thu, Mar 14, 2013 at 01:39:39PM -0400, Peter Hurley wrote: > > > On Thu, 2013-03-14 at 16:23 +0100, Johan Hovold wrote: > > > > Make sure to unregister the tty-device before

Re: Testing for hardware bug in EHCI controllers

2013-03-15 Thread Alan Stern
On Fri, 15 Mar 2013, Noone Nowhere wrote: > USB stick on 12 different EHCI USB hosts. On VT8235M it took ages to > go to 1000. A human readable timestamp could be used. Evidently the VT8235M is very slow for some of the operations used by the test program. > To sum up printing a start up messag

[PATCH v2 11/23] ARM: OMAP3: cm-t3517: Adapt to ehci-omap changes

2013-03-15 Thread Roger Quadros
Add 2 platform devices for 'nop-usb-xceiv'. These will be used as PHYs for HS USB ports 1 and 2 so provide binding information for them. Use usbhs_init_phys() to register the PHY's RESET regulators. Signed-off-by: Roger Quadros --- arch/arm/mach-omap2/board-cm-t3517.c | 45 +++

[PATCH v2 09/23] ARM: OMAP: AM3517evm: Adapt to ehci-omap changes

2013-03-15 Thread Roger Quadros
Add 2 platform devices for 'nop-usb-xceiv'. These will be used as a PHY for HS USB Port 1 and 2, so provide binding information for them. Use usbhs_init_phys() to register the PHY's RESET regulators. Signed-off-by: Roger Quadros --- arch/arm/mach-omap2/board-am3517evm.c | 41 +

[PATCH v2 07/23] ARM: OMAP3: 3630SDP: Adapt to ehci-omap changes

2013-03-15 Thread Roger Quadros
Add 2 platform devices for 'nop-usb-xceiv'. These will be used as PHYs for HS USB ports 1 and 2 so provide binding information for them. Use usbhs_init_phys() to register the PHY's RESET regulators. Signed-off-by: Roger Quadros --- arch/arm/mach-omap2/board-3630sdp.c | 48

[PATCH v2 05/23] ARM: OMAP3: Beagle: Adapt to ehci-omap changes

2013-03-15 Thread Roger Quadros
Add platform device for 'nop-usb-xceiv'. This will be used as a PHY for HS USB Port 2, so provide binding information for it. Use usbhs_init_phys() to register the PHY's VCC and RESET regulators. Signed-off-by: Roger Quadros --- arch/arm/mach-omap2/board-omap3beagle.c | 44 +++

[PATCH v2 00/23] ARM: OMAP2+: Adapt to ehci-omap changes for 3.10

2013-03-15 Thread Roger Quadros
Hi Tony, These patches provide the SoC side code required to support the changes in the OMAP USB Host drivers done in [1], [2] & [3]. Device tree support is added for Beagleboard and Panda. NOTE: The first patch needs to be shared between the OMAP tree and Felipe's USB tree. v2: - Added helper

[PATCH v2 02/23] ARM: OMAP2+: omap-usb-host: Add usbhs_init_phys()

2013-03-15 Thread Roger Quadros
This helper allows board support code to add the PHY's VCC and RESET regulators which are GPIO controlled. It also links the "vcc" and "reset" supplies to the PHY's device ID that is supplied in the struct usbhs_phy_data argument. Signed-off-by: Roger Quadros --- arch/arm/mach-omap2/usb-host.c

[PATCH v2 04/23] ARM: OMAP2+: omap4panda: Adapt to ehci-omap changes

2013-03-15 Thread Roger Quadros
Use usbhs_init_phys() to register the PHY's VCC and RESET regulators. The VCC and RESET will then be managed by the PHY driver. Signed-off-by: Roger Quadros --- arch/arm/mach-omap2/board-omap4panda.c | 37 +-- 1 files changed, 11 insertions(+), 26 deletions(-) dif

[PATCH v2 03/23] ARM: OMAP2+: omap4panda: Provide USB Host's PHY platform data

2013-03-15 Thread Roger Quadros
Add platform device and data for 'nop-usb-xceiv'. This will be used as PHY for HS USB port 1, so provide binding information for it. Get rid of managing the PHY clock as it will be done by the PHY driver. For that to work we create a clock alias that links the PHY clock name to the PHY device name

[PATCH v2 01/23] usb: phy: nop: Add some parameters to platform data

2013-03-15 Thread Roger Quadros
Add clk_rate parameter to platform data. If supplied, the NOP phy driver will program the clock to that rate during probe. Also add 2 flags, needs_vcc and needs_reset. If the flag is set and the regulator couldn't be found then the driver will bail out with -EPROBE_DEFER. Signed-off-by: Roger Qua

Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt responses)

2013-03-15 Thread Greg KH
On Fri, Mar 15, 2013 at 02:33:13PM +0100, Jiri Kosina wrote: > On Fri, 15 Mar 2013, Harald Arnesen wrote: > > > I have the same problem on my Lenovo T500. I think the graphics card is > > involved. > > > > This laptop has "hybrid graphics" - one Intel GMA 4500MHD and one ATI > > Mobility Radeon H

  1   2   >