Re: [RFC PATCH] qmi_wwan: set correct altsetting for Gobi 1K devices

2013-03-13 Thread Bjørn Mork
Bjørn Mork writes: > > Risking that I am trying to be too smart again. .. But I really think > we can fix this in a more generic way by making the probe behave more > like it did before. How about just letting it continue without erring > out until it has called usbnet_get_endpoints? That should

Re: [PATCH] usb: gadget: u_serial: fix typo which cause build warning

2013-03-13 Thread Felipe Balbi
On Wed, Mar 13, 2013 at 11:37:21AM +0800, Bo Shen wrote: > fix typo which cause following build warning > > warning: "pr_vdebug" redefined make sure to note which commit has introduced the problem. hint: it was commit ea0e6276 > Signed-off-by: Bo Shen > --- > drivers/usb/gadget/u_serial.c |

Re: [RFC PATCH 2/3] usb: udc: delete the vbus indicator at individual driver

2013-03-13 Thread Felipe Balbi
On Wed, Mar 13, 2013 at 11:10:43AM +0800, Peter Chen wrote: > On Tue, Mar 12, 2013 at 11:46:49AM +0200, Felipe Balbi wrote: > > On Tue, Mar 12, 2013 at 05:03:18PM +0800, Peter Chen wrote: > > > Let the common struct usb_gadget own it. > > > > > > CC: Alexander Shishkin > > > CC: Jean-Christophe P

Re: [RFC PATCH 2/3] usb: udc: delete the vbus indicator at individual driver

2013-03-13 Thread Peter Chen
On Wed, Mar 13, 2013 at 09:44:09AM +0200, Felipe Balbi wrote: > On Wed, Mar 13, 2013 at 11:10:43AM +0800, Peter Chen wrote: > > On Tue, Mar 12, 2013 at 11:46:49AM +0200, Felipe Balbi wrote: > > > On Tue, Mar 12, 2013 at 05:03:18PM +0800, Peter Chen wrote: > > > > Let the common struct usb_gadget ow

Re: [PATCH] usb: gadget: u_serial: fix typo which cause build warning

2013-03-13 Thread Bo Shen
Hi Felipe, On 3/13/2013 15:42, Felipe Balbi wrote: On Wed, Mar 13, 2013 at 11:37:21AM +0800, Bo Shen wrote: fix typo which cause following build warning warning: "pr_vdebug" redefined make sure to note which commit has introduced the problem. I will resend this patch and add this info. h

[Resend] usb: gadget: u_serial: fix typo which cause build warning

2013-03-13 Thread Bo Shen
fix typo error in commit ea0e6276 cause the following build warning warning: "pr_vdebug" redefined Signed-off-by: Bo Shen --- Resend: Add which commit let this slip in --- drivers/usb/gadget/u_serial.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget

Re: [Resend] usb: gadget: u_serial: fix typo which cause build warning

2013-03-13 Thread Felipe Balbi
On Wed, Mar 13, 2013 at 03:57:59PM +0800, Bo Shen wrote: > fix typo error in commit ea0e6276 cause the following build warning maybe I should've been more explicit, but when you 'blame' a commit you also add the commit subject is parentheses: "fix typo error introduced by commit ea0e6276 (usb: ga

Re: [usb-storage] Re: usb3.0 device recognized as usb2.1

2013-03-13 Thread Richard Genoud
2013/2/14 Richard Genoud : > 2013/2/12 Sarah Sharp : >> On Sun, Feb 03, 2013 at 09:52:42PM -0500, Alan Stern wrote: >>> On Sun, 3 Feb 2013, Richard Genoud wrote: >>> >>> > [previously] >>> > I tried to use this device : usb3.0 HDD dock ( >>> > http://www.icydock.com/goods.php?id=130 ) based on JMic

Re: mfd: omap-usb-host: bug fix for 3.9

2013-03-13 Thread Samuel Ortiz
Hi Roger, On Wed, Feb 27, 2013 at 04:02:53PM +0200, Roger Quadros wrote: > Hi Samuel, > > One of my patch that I sent for 3.9 introduces a bug that fails to > update the port mode hostconfig register. Because of that, the port modes will > always be 0 (i.e. EHCI PHY mode) and other modes will not

Re: [Resend] usb: gadget: u_serial: fix typo which cause build warning

2013-03-13 Thread Bo Shen
Hi Felipe, On 3/13/2013 16:19, Felipe Balbi wrote: On Wed, Mar 13, 2013 at 03:57:59PM +0800, Bo Shen wrote: fix typo error in commit ea0e6276 cause the following build warning maybe I should've been more explicit, but when you 'blame' a commit you also add the commit subject is parentheses:

Re: [RFC PATCH 2/3] usb: udc: delete the vbus indicator at individual driver

2013-03-13 Thread Felipe Balbi
On Wed, Mar 13, 2013 at 03:49:19PM +0800, Peter Chen wrote: > On Wed, Mar 13, 2013 at 09:44:09AM +0200, Felipe Balbi wrote: > > On Wed, Mar 13, 2013 at 11:10:43AM +0800, Peter Chen wrote: > > > On Tue, Mar 12, 2013 at 11:46:49AM +0200, Felipe Balbi wrote: > > > > On Tue, Mar 12, 2013 at 05:03:18PM

[PATCH 5/5] usb: otg: twl4030: fix cold plug on OMAP3

2013-03-13 Thread Kishon Vijay Abraham I
Having twl4030_usb_phy_init() (detects if a cable is connected before twl4030 is probed) in twl4030 probe makes cable connect events to be missed by musb glue, since it gets loaded after twl4030. Having twl4030_usb_phy_init as a usb_phy ops lets twl4030_usb_phy_init to be called when glue is ready.

[PATCH 2/5] usb: musb: omap: always glue have the correct vbus/id status

2013-03-13 Thread Kishon Vijay Abraham I
In the case where omap glue is loaded and musb core is not, glue->status wont have a valid status if the phy drivers call omap_musb_mailbox. So fixed the conditions here. Signed-off-by: Kishon Vijay Abraham I --- drivers/usb/musb/omap2430.c | 11 +-- 1 file changed, 5 insertions(+), 6

[PATCH 1/5] usb: musb: omap: remove the check before calling otg_set_vbus

2013-03-13 Thread Kishon Vijay Abraham I
No functional change. otg_set_vbus is already protected so removed the check before calling otg_set_vbus. Signed-off-by: Kishon Vijay Abraham I --- drivers/usb/musb/omap2430.c |9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/usb/musb/omap2430.c b/drivers/us

[PATCH 4/5] usb: musb: omap: add usb_phy_init in omap2430_musb_init

2013-03-13 Thread Kishon Vijay Abraham I
Some PHYs load too early (twl4030) making omap glue to miss cable connect events if the board is booted with cable connected. So adding usb_phy_init in omap2430_musb_init lets PHYs to report events once glue is ready. Signed-off-by: Kishon Vijay Abraham I --- drivers/usb/musb/omap2430.c |2 +

[PATCH 3/5] usb: otg: twl4030: use devres API for regulator get and request irq

2013-03-13 Thread Kishon Vijay Abraham I
Used devres APIs devm_request_threaded_irq and devm_regulator_get for requesting irq and for getting regulator respectively. Signed-off-by: Kishon Vijay Abraham I --- drivers/usb/otg/twl4030-usb.c | 28 1 file changed, 8 insertions(+), 20 deletions(-) diff --git a

[PATCH 0/5] usb: musb/otg: cleanup and fixes

2013-03-13 Thread Kishon Vijay Abraham I
This series has some misc cleanup and fixes. The fix solves the cold plug issue in omap3 which some have reported. Developed these patches on Linux 3.9-rc2 after applying http://www.spinics.net/lists/linux-usb/msg81563.html (Grazvydas Ignotas patch series) Tested for g_zero enumeration in pandabo

[Patch v2] usb: gadget: u_serial: fix typo which cause build warning

2013-03-13 Thread Bo Shen
fix typo error introduced by commit ea0e6276 (usb: gadget: add multiple definition guards) which causes the following build warning: warning: "pr_vdebug" redefined Signed-off-by: Bo Shen --- Change in v2: reword commit message which make it more explicitly with commit id and subject --- dri

Re: [PATCH v3 0/7] ARM: dts: omap: Add dts data for USB

2013-03-13 Thread kishon
Benoit, Will you be queuing this patch series? Thanks Kishon On Thursday 07 March 2013 07:05 PM, Kishon Vijay Abraham I wrote: Hi Benoit, Here are the dt data patches to get usb device functional in OMAP platforms. All the patches deal with modifying arch/arm/boot except one which modifies D

Re: [PATCH] usb: dwc3: Set DWC3 context's mode based on selected mode.

2013-03-13 Thread Vivek Gautam
Hi Balbi, On Sat, Mar 2, 2013 at 6:55 PM, Vivek Gautam wrote: > Now that machines may select the mode of working of DWC3 (HOST only, > GADGET only or DUAL_ROLE), lets set DWC3 mode based on that > rather than fixing it to whatever DWC3 hardware says. > This way we can skip initializing Gadget/Ho

Re: [PATCH] usb: dwc3: Set DWC3 context's mode based on selected mode.

2013-03-13 Thread Felipe Balbi
On Wed, Mar 13, 2013 at 02:42:22PM +0530, Vivek Gautam wrote: > Hi Balbi, > > > On Sat, Mar 2, 2013 at 6:55 PM, Vivek Gautam wrote: > > Now that machines may select the mode of working of DWC3 (HOST only, > > GADGET only or DUAL_ROLE), lets set DWC3 mode based on that > > rather than fixing it t

Re: [PATCH] usb: dwc3: Set DWC3 context's mode based on selected mode.

2013-03-13 Thread Vivek Gautam
On Wed, Mar 13, 2013 at 2:44 PM, Felipe Balbi wrote: > On Wed, Mar 13, 2013 at 02:42:22PM +0530, Vivek Gautam wrote: >> Hi Balbi, >> >> >> On Sat, Mar 2, 2013 at 6:55 PM, Vivek Gautam >> wrote: >> > Now that machines may select the mode of working of DWC3 (HOST only, >> > GADGET only or DUAL_ROL

Re: [PATCH 3/9] USB: add devicetree helpers for determining dr_mode and phy_type

2013-03-13 Thread Peter Chen
On Mon, Feb 04, 2013 at 02:24:29PM +0100, Sascha Hauer wrote: > From: Michael Grzeschik > > This adds two little devicetree helper functions for determining the > dr_mode (host, peripheral, otg) and phy_type (utmi, ulpi,...) from > the devicetree. > > Signed-off-by: Michael Grzeschik > Signed-o

Re: [PATCH] drivers/usb/gadget: beautify code, delete unused code

2013-03-13 Thread Chen Gang
Hello Felipe Balbi: I have communicate with related member of net2272 and net2280. net2272 and net2280 belong to PLX Tech Corporation. they say: "PLX is not longer maintain these drivers". (it means: they can not help us to test this patch). please see the FWD mail at the botto

Re: [PATCH v6 0/2] Adding USB 3.0 DRD-phy support for exynos5250

2013-03-13 Thread Vivek Gautam
Hi Felipe, On Wed, Feb 27, 2013 at 8:13 PM, Vivek Gautam wrote: > Based on 'usb-next' > > Changes from v5: > - Squashed the following change from Felipe in this patch-set: >[PATCH] usb: phy: samsung: let it be built as a module > - Using EXPORT_SYMBOL_GPL() to export symbols in "samsung-us

Re: [PATCH v6 0/2] Adding USB 3.0 DRD-phy support for exynos5250

2013-03-13 Thread Felipe Balbi
On Wed, Mar 13, 2013 at 03:41:15PM +0530, Vivek Gautam wrote: > Hi Felipe, > > > On Wed, Feb 27, 2013 at 8:13 PM, Vivek Gautam > wrote: > > Based on 'usb-next' > > > > Changes from v5: > > - Squashed the following change from Felipe in this patch-set: > >[PATCH] usb: phy: samsung: let it b

Re: [PATCH v2 12/12] USB: ehci-omap: Fix detection in HSIC mode

2013-03-13 Thread Roger Quadros
On 03/12/2013 06:07 PM, Alan Stern wrote: > On Tue, 12 Mar 2013, Roger Quadros wrote: > >> The HSIC devices need to be kept in reset while the EHCI controller >> is being initialized and only brought out of reset after the >> initialization is complete, else HSIC devices will not be detected. > >

Re: PROBLEM: since linux kernel 3.8 Apple Cinema Display's usb hub spits errors randomly at boot.

2013-03-13 Thread Jenya Y
On Tuesday 12 March 2013 13:29:17 Alan Stern wrote: > On Tue, 12 Mar 2013, Jenya Y wrote: > > > I'll try to work out a patch in the next few days. Can you recreate > > > the arrangement where all the errors occurred, in order to test the > > > patch when it is ready? > > > > > > Alan Stern > > >

[PATCH net,stable-3.8] net: qmi_wwan: set correct altsetting for Gobi 1K devices

2013-03-13 Thread Bjørn Mork
commit bd877e4 ("net: qmi_wwan: use a single bind function for all device types") made Gobi 1K devices fail probing. Using the number of endpoints in the default altsetting to decide whether the function use one or two interfaces is wrong. Other altsettings may provide more endpoints. With Gobi

RE: [PATCH] usb: phy: rename all phy drivers to phy-$name.c

2013-03-13 Thread Venu Byravarasu
> -Original Message- > From: Felipe Balbi [mailto:ba...@ti.com] > Sent: Friday, March 08, 2013 1:08 PM > To: Venu Byravarasu > Cc: Stephen Warren; Felipe Balbi; Linux USB Mailing List; Greg KH; linux- > te...@vger.kernel.org; s.ha...@pengutronix.de; sachin.ka...@linaro.org; > aletes@gma

Re: [PATCH] usb: phy: rename all phy drivers to phy-$name.c

2013-03-13 Thread Felipe Balbi
On Wed, Mar 13, 2013 at 06:01:13PM +0530, Venu Byravarasu wrote: > > -Original Message- > > From: Felipe Balbi [mailto:ba...@ti.com] > > Sent: Friday, March 08, 2013 1:08 PM > > To: Venu Byravarasu > > Cc: Stephen Warren; Felipe Balbi; Linux USB Mailing List; Greg KH; linux- > > te...@vger.

[PATCH v3 12/13] USB: ehci-omap: Fix detection in HSIC mode

2013-03-13 Thread Roger Quadros
Move PHY initialization until after EHCI initialization is complete, instead of initializing the PHYs first, shutting them down again, and then initializing them a second time. This fixes HSIC device detection. Signed-off-by: Roger Quadros CC: Alan Stern --- drivers/usb/host/ehci-omap.c | 32

[PATCH 13/13] USB: ehci-omap: Get rid of omap_ehci_init()

2013-03-13 Thread Roger Quadros
As it does almost nothing, get rid of omap_ehci_init() and move the ehci->caps initialization part into probe(). Also remove the outdated TODO list from header. Signed-off-by: Roger Quadros CC: Alan Stern --- drivers/usb/host/ehci-omap.c | 21 + 1 files changed, 1 inserti

Re: [PATCH] cdc-wdm: fix buffer overflow

2013-03-13 Thread Sergei Shtylyov
Hello. On 12-03-2013 17:52, oli...@neukum.org wrote: From: Oliver Neukum The buffer for responses must not overflow. If this would happen, set a flag, drop the data and return an error after user space has read all remaining data. Signed-off-by: Oliver Neukum Are different email ad

Re: [Resend] usb: gadget: u_serial: fix typo which cause build warning

2013-03-13 Thread Sergei Shtylyov
Hello. On 13-03-2013 11:57, Bo Shen wrote: fix typo error in commit ea0e6276 cause the following build warning Pleas ealso specify that commit's summary line in parens (or however you like). warning: "pr_vdebug" redefined Signed-off-by: Bo Shen WBR, Sergei -- To unsubscribe

Re: [PATCH 00/24] ARM: OMAP2+: Adapt to ehci-omap changes for 3.10

2013-03-13 Thread Roger Quadros
On 03/12/2013 06:40 PM, Tony Lindgren wrote: > * Roger Quadros [130312 04:47]: >> Hi Tony, >> >> These patches provide the SoC side code required to support >> the changes in the OMAP USB Host drivers done in [1], [2] & [3]. > ... > >> arch/arm/mach-omap2/board-3430sdp.c| 97 +

Re: [PATCH net,stable-3.8] net: qmi_wwan: set correct altsetting for Gobi 1K devices

2013-03-13 Thread Dan Williams
On Wed, 2013-03-13 at 13:25 +0100, Bjørn Mork wrote: > commit bd877e4 ("net: qmi_wwan: use a single bind function for > all device types") made Gobi 1K devices fail probing. > > Using the number of endpoints in the default altsetting to decide > whether the function use one or two interfaces is wr

[PATCH] USB: quatech2: only write to the tty if the port is open.

2013-03-13 Thread Bill Pemberton
The commit 2e124b4a390ca85325fae75764bef92f0547fa25 removed the checks that prevented qt2_process_read_urb() from trying to put chars into ttys that weren't actually opened. This resulted in 'tty is NULL' warnings from flush_to_ldisc() when the device was used. The devices use just one read urb f

PROBLEM: since linux kernel 3.8 Apple Cinema Display's usb hub spits errors randomly at boot.

2013-03-13 Thread Jenya Y
-- Forwarded Message -- Not sure if it's better or worse but that's where we are right now. :) So I'm back to 3.9 where everything works beautifully (well, almost) I think I should mention that one thing has chnaged in my installation. I've updated my systemd to 198, but it

Re: [PATCH] USB: quatech2: only write to the tty if the port is open.

2013-03-13 Thread Sergei Shtylyov
Hello. On 13-03-2013 17:50, Bill Pemberton wrote: The commit 2e124b4a390ca85325fae75764bef92f0547fa25 removed the checks Please also specify that commit's summary line in parens (or however you like). that prevented qt2_process_read_urb() from trying to put chars into ttys that weren't

[PATCH] USB: usb-skeleton.c: fix blocked forever in skel_read

2013-03-13 Thread Du Xing
From: Du Xing duxing2...@gmail.com In skel_read,the reader blocked in wait_for_completion before submit bulk in urb. Using processed_urb is totally unnecessary, remove it can fix the bug. --- Signed-off-by: Du Xing duxing2...@gmail.com --- diff --git a/drivers/usb/usb-skeleton.c b/drivers/usb/usb

Re: [PATCH] USB: ehci-s5p: Fix phy reset

2013-03-13 Thread Alan Stern
On Wed, 13 Mar 2013, Alexander Graf wrote: > On my Exynos 5 based Arndale system, I need to pull the reset line down > and then let it go up again to actually perform a reset. Without that > reset, I can't find any USB hubs on my bus, rendering the USB controller > useless. > > So this patch impl

Re: [PATCH v3 12/13] USB: ehci-omap: Fix detection in HSIC mode

2013-03-13 Thread Alan Stern
On Wed, 13 Mar 2013, Roger Quadros wrote: > Move PHY initialization until after EHCI initialization is > complete, instead of initializing the PHYs first, shutting > them down again, and then initializing them a second time. > > This fixes HSIC device detection. > > Signed-off-by: Roger Quadros

Re: [PATCH 13/13] USB: ehci-omap: Get rid of omap_ehci_init()

2013-03-13 Thread Alan Stern
On Wed, 13 Mar 2013, Roger Quadros wrote: > As it does almost nothing, get rid of omap_ehci_init() > and move the ehci->caps initialization part into probe(). > > Also remove the outdated TODO list from header. > > Signed-off-by: Roger Quadros > CC: Alan Stern Acked-by: Alan Stern -- To uns

Re: Isochronous transfer error on USB3

2013-03-13 Thread jean-philippe francois
2013/3/12 jean-philippe francois : > 2013/3/12 jean-philippe francois : >> 2013/3/12 Sarah Sharp : >>> On Mon, Mar 11, 2013 at 01:21:48PM +0100, jean-philippe francois wrote: Hi, The company I work for is doing USB cameras, for which I wrote the drivers (out of tree). >>> >>> Ke

Re: [PATCH] USB: usb-skeleton.c: fix blocked forever in skel_read

2013-03-13 Thread Oliver Neukum
On Wednesday 13 March 2013 22:22:53 Du Xing wrote: > From: Du Xing duxing2...@gmail.com > > In skel_read,the reader blocked in wait_for_completion before submit bulk in > urb. > Using processed_urb is totally unnecessary, remove it can fix the bug. The processed_urb is intended for the case that

Re: [PATCH] USB: usb-skeleton.c: fix blocked forever in skel_read

2013-03-13 Thread Ming Lei
On Wed, Mar 13, 2013 at 10:36 PM, Oliver Neukum wrote: > On Wednesday 13 March 2013 22:22:53 Du Xing wrote: >> From: Du Xing duxing2...@gmail.com >> >> In skel_read,the reader blocked in wait_for_completion before submit bulk in >> urb. >> Using processed_urb is totally unnecessary, remove it can

Re: [PATCH] USB: usb-skeleton.c: fix blocked forever in skel_read

2013-03-13 Thread Oliver Neukum
On Wednesday 13 March 2013 22:42:37 Ming Lei wrote: > On Wed, Mar 13, 2013 at 10:36 PM, Oliver Neukum wrote: > > On Wednesday 13 March 2013 22:22:53 Du Xing wrote: > >> From: Du Xing duxing2...@gmail.com > >> > >> In skel_read,the reader blocked in wait_for_completion before submit bulk > >> in u

[PATCH] qcserial: bind to DM/DIAG port on Gobi 1K devices

2013-03-13 Thread Dan Williams
Turns out we just need altsetting 1 and then we can talk to it. Signed-off-by: Dan Williams --- diff --git a/drivers/usb/serial/qcserial.c b/drivers/usb/serial/qcserial.c index 2466254..59b32b7 100644 --- a/drivers/usb/serial/qcserial.c +++ b/drivers/usb/serial/qcserial.c @@ -197,12 +197,15 @@ st

Re: [PATCH] USB: usb-skeleton.c: fix blocked forever in skel_read

2013-03-13 Thread Ming Lei
On Wed, Mar 13, 2013 at 10:55 PM, Oliver Neukum wrote: > > But it will be run when the next read() call is made. The question is what > happens When next read() is called, looks it won't be reached if 'ongoing_read' is set, and it needn't run without ongoing URBs. Thanks, -- Ming Lei -- To un

Re: [PATCH] qcserial: bind to DM/DIAG port on Gobi 1K devices

2013-03-13 Thread Greg KH
On Wed, Mar 13, 2013 at 09:58:18AM -0500, Dan Williams wrote: > Turns out we just need altsetting 1 and then we can talk to it. > > Signed-off-by: Dan Williams Should this go to the -stable releases as well? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-us

Re: [PATCH] USB: usb-skeleton.c: fix blocked forever in skel_read

2013-03-13 Thread Oliver Neukum
On Wednesday 13 March 2013 23:02:32 Ming Lei wrote: > On Wed, Mar 13, 2013 at 10:55 PM, Oliver Neukum wrote: > > > > But it will be run when the next read() call is made. The question is what > > happens > > When next read() is called, looks it won't be reached if > 'ongoing_read' is set, and >

Re: [PATCH 1/8] usb: phy: nop: Add some parameters to platform data

2013-03-13 Thread Peter Ujfalusi
On 03/12/2013 04:20 PM, Roger Quadros wrote: > Adding Peter to the loop. I faintly remember him mentioning this issue before > for beagle. We really need the deferred probe mechanism or we need to resort > to device registering order. Yes, BeagleBoard is a good example. Long story short: we have e

Re: [PATCH net,stable-3.8] net: qmi_wwan: set correct altsetting for Gobi 1K devices

2013-03-13 Thread David Miller
From: Dan Williams Date: Wed, 13 Mar 2013 08:43:36 -0500 > On Wed, 2013-03-13 at 13:25 +0100, Bjørn Mork wrote: >> commit bd877e4 ("net: qmi_wwan: use a single bind function for >> all device types") made Gobi 1K devices fail probing. >> >> Using the number of endpoints in the default altsetting

Re: [PATCH] qcserial: bind to DM/DIAG port on Gobi 1K devices

2013-03-13 Thread Dan Williams
On Wed, 2013-03-13 at 08:11 -0700, Greg KH wrote: > On Wed, Mar 13, 2013 at 09:58:18AM -0500, Dan Williams wrote: > > Turns out we just need altsetting 1 and then we can talk to it. > > > > Signed-off-by: Dan Williams > > Should this go to the -stable releases as well? Yeah, likely. Want a res

Re: USB Mouse Disconnect Kernel-3.7/3.8

2013-03-13 Thread Jiri Kosina
On Mon, 11 Mar 2013, Frank Peters wrote: > When I boot my x64 Linux system to the console a continuous series > of "USB disconnect/reconnect" messages appears in the kernel log. > The disconnect/reconnect messages concern the USB mouse: > > usb 1-1.3: USB disconnect, device number N > usb 1-1.3:

Re: [PATCH 1/8] usb: phy: nop: Add some parameters to platform data

2013-03-13 Thread Roger Quadros
On 03/13/2013 05:17 PM, Peter Ujfalusi wrote: > On 03/12/2013 04:20 PM, Roger Quadros wrote: >> Adding Peter to the loop. I faintly remember him mentioning this issue before >> for beagle. We really need the deferred probe mechanism or we need to resort >> to device registering order. > > Yes, Bea

Re: [PATCH] qcserial: bind to DM/DIAG port on Gobi 1K devices

2013-03-13 Thread Greg KH
On Wed, Mar 13, 2013 at 10:38:46AM -0500, Dan Williams wrote: > On Wed, 2013-03-13 at 08:11 -0700, Greg KH wrote: > > On Wed, Mar 13, 2013 at 09:58:18AM -0500, Dan Williams wrote: > > > Turns out we just need altsetting 1 and then we can talk to it. > > > > > > Signed-off-by: Dan Williams > > >

Re: [PATCH 1/8] usb: phy: nop: Add some parameters to platform data

2013-03-13 Thread Marc Kleine-Budde
On 03/13/2013 04:17 PM, Peter Ujfalusi wrote: > On 03/12/2013 04:20 PM, Roger Quadros wrote: >> Adding Peter to the loop. I faintly remember him mentioning this issue before >> for beagle. We really need the deferred probe mechanism or we need to resort >> to device registering order. > > Yes, Bea

Re: [PATCH 00/24] ARM: OMAP2+: Adapt to ehci-omap changes for 3.10

2013-03-13 Thread Tony Lindgren
* Roger Quadros [130313 06:46]: > On 03/12/2013 06:40 PM, Tony Lindgren wrote: > > * Roger Quadros [130312 04:47]: > >> Hi Tony, > >> > >> These patches provide the SoC side code required to support > >> the changes in the OMAP USB Host drivers done in [1], [2] & [3]. > > ... > > > >> arch/arm

Re: [PATCH 00/24] ARM: OMAP2+: Adapt to ehci-omap changes for 3.10

2013-03-13 Thread Roger Quadros
On 03/13/2013 06:24 PM, Tony Lindgren wrote: > * Roger Quadros [130313 06:46]: >> On 03/12/2013 06:40 PM, Tony Lindgren wrote: >>> * Roger Quadros [130312 04:47]: Hi Tony, These patches provide the SoC side code required to support the changes in the OMAP USB Host drivers done

Re: [RFC] net: cdc_ncm, cdc_mbim: allow user to prefer NCM for backwards compatibility

2013-03-13 Thread Bjørn Mork
Bjørn Mork writes: > +#if IS_ENABLED(CONFIG_USB_NET_CDC_MBIM) > +static bool prefer_mbim = true; > +#else > +static bool prefer_mbim; > +#endif > +module_param(prefer_mbim, bool, S_IRUGO | S_IWUSR); > +MODULE_PARM_DESC(prefer_mbim, "Prefer MBIM on NCM/MBIM backwards compatible > functions"); So

Re: [PATCH 00/24] ARM: OMAP2+: Adapt to ehci-omap changes for 3.10

2013-03-13 Thread Tony Lindgren
* Roger Quadros [130313 09:40]: > On 03/13/2013 06:24 PM, Tony Lindgren wrote: > > * Roger Quadros [130313 06:46]: > >> On 03/12/2013 06:40 PM, Tony Lindgren wrote: > >>> * Roger Quadros [130312 04:47]: > Hi Tony, > > These patches provide the SoC side code required to support > >

Re: [PATCH] USB: ehci-s5p: Fix phy reset

2013-03-13 Thread Doug Anderson
Alexander, On Tue, Mar 12, 2013 at 6:09 PM, Alexander Graf wrote: > - err = gpio_request_one(gpio, GPIOF_OUT_INIT_HIGH, "ehci_vbus_gpio"); > - if (err) > + /* reset pulls the line down, then up again */ > + err = gpio_request_one(gpio, GPIOF_OUT_INIT_LOW, "ehci_vbus_gpio")

Re: [PATCH] USB: ehci-s5p: Fix phy reset

2013-03-13 Thread Alexander Graf
On 13.03.2013, at 18:28, Doug Anderson wrote: > Alexander, > > On Tue, Mar 12, 2013 at 6:09 PM, Alexander Graf wrote: >> - err = gpio_request_one(gpio, GPIOF_OUT_INIT_HIGH, "ehci_vbus_gpio"); >> - if (err) >> + /* reset pulls the line down, then up again */ >> + err = gp

Re: PROBLEM: since linux kernel 3.8 Apple Cinema Display's usb hub spits errors randomly at boot.

2013-03-13 Thread Alan Stern
On Wed, 13 Mar 2013, Jenya Y wrote: > Here how it went. > I did fresh rebuild of 3.8.2 kernel with my previous settings (where all of > the mentioned flags were set as 'm') restarted to check the errors - they > were > there (-71). Then I went back and applied your patch and this time I got >

Re: [PATCH] USB: ehci-s5p: Fix phy reset

2013-03-13 Thread Doug Anderson
Alexander, On Wed, Mar 13, 2013 at 10:45 AM, Alexander Graf wrote: > >>> + gpio_free(gpio); >> >> Freeing the gpio is a little on the iffy side since you actually care >> about keeping the value. Perhaps you can change this to >> devm_gpio_request_one() and avoid the free? I was about to

Re: [usb-storage] Re: usb3.0 device recognized as usb2.1

2013-03-13 Thread Sarah Sharp
On Wed, Mar 13, 2013 at 09:33:01AM +0100, Richard Genoud wrote: > 2013/2/14 Richard Genoud : > > 2013/2/12 Sarah Sharp : > >> On Sun, Feb 03, 2013 at 09:52:42PM -0500, Alan Stern wrote: > >>> On Sun, 3 Feb 2013, Richard Genoud wrote: > >>> > >>> > [previously] > >>> > I tried to use this device : u

[PATCH 0/1] USB: Added quirk to recognize GE0301 3G modem as an interface.

2013-03-13 Thread manoj . iyer
From: Manoj Iyer This patch enables GE0301 3G modem as an interface, the patch has been part of the Ubuntu kernel for a while but I forgot to upstream. Test details can be found in the bug http://bugs.launchpad.net/bugs/348861 Please consider this patch for upstream. Manoj Iyer (1): USB: A

[PATCH 1/1] USB: Added quirk to recognize GE0301 3G modem as an interface.

2013-03-13 Thread manoj . iyer
From: Manoj Iyer Signed-off-by: Manoj Iyer Reported-by: Timo Aaltonen Original-author: Timo Aaltonen BugLink: http://bugs.launchpad.net/bugs/348861 --- drivers/usb/storage/unusual_devs.h |7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/usb/storage/unusual_devs.h b/drive

Re: [PATCH 1/1] USB: Added quirk to recognize GE0301 3G modem as an interface.

2013-03-13 Thread Bjørn Mork
manoj.i...@canonical.com writes: > +/* Reported by Timo Aaltonen */ > +UNUSUAL_DEV( 0x0af0, 0x7011, 0x, 0x, > + "Option", > + "Mass Storage", > + USB_SC_DEVICE, USB_PR_DEVICE, option_ms_init, > + 0 ), > + > /* Reported by F. Aben > * Thi

RE: Problem with linux-3.7.7 (Stern - d01875f11f05f76fc471cec94d701201c1b34389)

2013-03-13 Thread Alan Stern
On Mon, 11 Mar 2013, Adrian Bassett wrote: > I have applied this new patch to an otherwise un-modified 3.8.2 tree: > > Hunk #1 succeeded at 1298 (offset -18 lines). > patch unexpectedly ends in middle of line > > So far I have not been able to trigger a hanging suspend/resume so it rather > lo

Re: USB Mouse Disconnect Kernel-3.7/3.8

2013-03-13 Thread Frank Peters
On Wed, 13 Mar 2013 16:45:35 +0100 (CET) Jiri Kosina wrote: > > Do you have USB autosuspend enabled on that device? > The CONFIG_USB_SUSPEND, which controls USB autosuspend, is not available to me during kernel configuration because I do not enable "Run-time PM core functionality" (PM_RUNTIME)

Re: [PATCH v3 3/6] TTY: fix DTR being raised on hang up

2013-03-13 Thread Peter Hurley
On Thu, 2013-03-07 at 15:55 +0100, Johan Hovold wrote: > Make sure to check ASYNC_INITIALISED before raising DTR when waking up > from blocked open in tty_port_block_til_ready. > > Currently DTR could get raised at hang up as a blocked process would > raise DTR unconditionally before checking for

Re: [PATCH v3 0/6] TTY: port hangup and close fixes

2013-03-13 Thread Peter Hurley
On Thu, 2013-03-07 at 15:55 +0100, Johan Hovold wrote: > These patches against 3.9-rc1 fix a few issues with tty-port hangup and > close. > > The first and fifth patch are essentially clean ups. > > The second and third patch fix the fact that DTR could get raised > (rather than dropped) at hangu

Re: [PATCH v6] usb: phy: add R-Car USB phy driver

2013-03-13 Thread Sergei Shtylyov
Hello. On 11/01/2012 05:03 AM, Kuninori Morimoto wrote: Sorry for the late feedback but I'm studying this driver just now (in order to port it to R-Car M1A). diff --git a/drivers/usb/phy/rcar-phy.c b/drivers/usb/phy/rcar-phy.c new file mode 100644 index 000..792f505 --- /dev/null +++

[GIT PATCH] USB fixes for 3.9-rc2

2013-03-13 Thread Greg KH
The following changes since commit 6dbe51c251a327e012439c4772097a13df43c5b8: Linux 3.9-rc1 (2013-03-03 15:11:05 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/ tags/usb-3.9-rc2 for you to fetch changes up to 27b351c5546008c640b3e6

Re: [PATCH 2/5] usb: musb: omap: always glue have the correct vbus/id status

2013-03-13 Thread Grazvydas Ignotas
On Wed, Mar 13, 2013 at 10:47 AM, Kishon Vijay Abraham I wrote: > In the case where omap glue is loaded and musb core is not, glue->status > wont have a valid status if the phy drivers call omap_musb_mailbox. So > fixed the conditions here. There already seems to be another patch named "usb: musb

Re: [PATCH 0/5] usb: musb/otg: cleanup and fixes

2013-03-13 Thread Grazvydas Ignotas
On Wed, Mar 13, 2013 at 10:47 AM, Kishon Vijay Abraham I wrote: > This series has some misc cleanup and fixes. The fix solves the cold > plug issue in omap3 which some have reported. Developed these patches on > Linux 3.9-rc2 after applying > http://www.spinics.net/lists/linux-usb/msg81563.html >

Re: [PATCH resend 0/5] USB: fixes for 3.9-rc

2013-03-13 Thread Johan Hovold
On Wed, Feb 27, 2013 at 01:52:25PM +0100, Johan Hovold wrote: > Johan Hovold (5): > USB: cdc-acm: fix device unregistration > USB: ftdi_sio: fix use after free in TIOCMIWAIT > USB: garmin_gps: fix memory leak on disconnect > USB: io_ti: fix get_icount for two port adapters > USB: serial:

Re: [PATCH v3] usb: phy: add R-Car USB phy driver

2013-03-13 Thread Sergei Shtylyov
Hello. On 09/11/2012 08:51 AM, Felipe Balbi wrote: On Mon, Sep 10, 2012 at 06:46:50PM -0700, Kuninori Morimoto wrote: Hi Felipe Thank you for checking this patch +/* USBH common register */ +#define USBPCTRL0 0x0800 +#define USBPCTRL1 0x0804 +#define USBST 0x0808 +#define

Re: [PATCH resend 0/5] USB: fixes for 3.9-rc

2013-03-13 Thread Greg KH
On Wed, Mar 13, 2013 at 11:14:35PM +0100, Johan Hovold wrote: > On Wed, Feb 27, 2013 at 01:52:25PM +0100, Johan Hovold wrote: > > Johan Hovold (5): > > USB: cdc-acm: fix device unregistration > > USB: ftdi_sio: fix use after free in TIOCMIWAIT > > USB: garmin_gps: fix memory leak on disconnec

[PATCH] usb: Make USB persist default configurable

2013-03-13 Thread Julius Werner
Commit 9214d1d8 set the USB persist flag as a default for all devices. This might be desirable for some distributions, but it certainly has its trade-offs... most importantly, it can significantly increase system resume time, because the kernel blocks on resuming (and sometimes resetting) USB devic

Re: [PATCH v6] usb: phy: add R-Car USB phy driver

2013-03-13 Thread Kuninori Morimoto
Hi Sergei Thank you for pointing it > > + /* set platform specific port settings */ > > + iowrite32(0x, (reg0 + USBPCTRL0)); > > This register contains completely board specific setting, > hard-coding it to 0 is wrong. > Shouldn't you have passed its value as pl

Re: [PATCH] USB: ehci-s5p: Fix phy reset

2013-03-13 Thread Alexander Graf
On 13.03.2013, at 18:59, Doug Anderson wrote: > Alexander, > > On Wed, Mar 13, 2013 at 10:45 AM, Alexander Graf wrote: >> + gpio_free(gpio); >>> >>> Freeing the gpio is a little on the iffy side since you actually care >>> about keeping the value. Perhaps you can change this to >>

[PATCH v2] USB: ehci-s5p: Fix phy reset

2013-03-13 Thread Alexander Graf
On my Exynos 5 based Arndale system, I need to pull the reset line down and then let it go up again to actually perform a reset. Without that reset, I can't find any USB hubs on my bus, rendering the USB controller useless. We also only need to reset the line after the phy node has been found. Thi

Re: [PATCH v3] usb: phy: add R-Car USB phy driver

2013-03-13 Thread Kuninori Morimoto
Hi Sergei Thank you for pointing it > >> 0x === > >> EHCI > >> -- > >> 0x0094 PHY > >> 0x009C PHY > >> -- > >> EHCI > >> 0x0400 == > >> ... > >> 0x0800 -- > >>

Re: [Resend] usb: gadget: u_serial: fix typo which cause build warning

2013-03-13 Thread Bo Shen
Hi Sergei, On 3/13/2013 21:35, Sergei Shtylyov wrote: Hello. On 13-03-2013 11:57, Bo Shen wrote: fix typo error in commit ea0e6276 cause the following build warning Pleas ealso specify that commit's summary line in parens (or however you like). Thanks for you information. With Felipe

[PATCH 1/1] usb: xhci: fix build warning

2013-03-13 Thread Peter Chen
/home/b29397/work/code/git/linus/linux-2.6/drivers/usb/host/xhci-ring.c: In function ‘handle_port_status’: /home/b29397/work/code/git/linus/linux-2.6/drivers/usb/host/xhci-ring.c:1580: warning: ‘hcd’ may be used uninitialized in this function Signed-off-by: Peter Chen --- drivers/usb/host/xhci

Re: [PATCH v2] USB: ehci-s5p: Fix phy reset

2013-03-13 Thread Doug Anderson
Alexander, On Wed, Mar 13, 2013 at 4:59 PM, Alexander Graf wrote: > On my Exynos 5 based Arndale system, I need to pull the reset line down > and then let it go up again to actually perform a reset. Without that > reset, I can't find any USB hubs on my bus, rendering the USB controller > useless.

Re: [PATCH] USB: usb-skeleton.c: fix blocked forever in skel_read

2013-03-13 Thread Ming Lei
On Wed, Mar 13, 2013 at 11:15 PM, Oliver Neukum wrote: > On Wednesday 13 March 2013 23:02:32 Ming Lei wrote: >> On Wed, Mar 13, 2013 at 10:55 PM, Oliver Neukum wrote: >> > >> > But it will be run when the next read() call is made. The question is what >> > happens >> >> When next read() is calle

Re: [PATCH v2] USB: ehci-s5p: Fix phy reset

2013-03-13 Thread Thomas Abraham
On 14 March 2013 05:29, Alexander Graf wrote: > On my Exynos 5 based Arndale system, I need to pull the reset line down > and then let it go up again to actually perform a reset. Without that > reset, I can't find any USB hubs on my bus, rendering the USB controller > useless. > > We also only nee

Re: [PATCH 2/5] usb: musb: omap: always glue have the correct vbus/id status

2013-03-13 Thread kishon
On Thursday 14 March 2013 03:29 AM, Grazvydas Ignotas wrote: On Wed, Mar 13, 2013 at 10:47 AM, Kishon Vijay Abraham I wrote: In the case where omap glue is loaded and musb core is not, glue->status wont have a valid status if the phy drivers call omap_musb_mailbox. So fixed the conditions here.

[PATCH 00/14] Add vbus status to udc-core

2013-03-13 Thread Peter Chen
Vbus event is a common event for gadget, this patchset move vbus status from individual driver private data to common struct usb_gadget, after that, the udc core can know vbus status well. The last patch uses this vbus_active to determine if we can pullup dp when load gadget module. CC: Alexander

[PATCH 02/14] usb: chipidea: using common vbus_active

2013-03-13 Thread Peter Chen
Using common vbus_active to indicate vbus status CC: Alexander Shishkin Signed-off-by: Peter Chen --- drivers/usb/chipidea/ci.h |2 -- drivers/usb/chipidea/udc.c |6 +++--- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/usb/chipidea/ci.h b/drivers/usb/chipidea/c

[PATCH 03/14] usb: at91_udc: using common vbus_active

2013-03-13 Thread Peter Chen
Using common vbus_active to indicate vbus status CC: Felipe Balbi Signed-off-by: Peter Chen --- drivers/usb/gadget/at91_udc.c | 16 drivers/usb/gadget/at91_udc.h |1 - 2 files changed, 8 insertions(+), 9 deletions(-) diff --git a/drivers/usb/gadget/at91_udc.c b/drivers/u

[PATCH 04/14] usb: fsl_udc_core: using common vbus_active

2013-03-13 Thread Peter Chen
Using common vbus_active to indicate vbus status CC: Li Yang Signed-off-by: Peter Chen --- drivers/usb/gadget/fsl_udc_core.c |4 ++-- drivers/usb/gadget/fsl_usb2_udc.h |1 - 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/usb/gadget/fsl_udc_core.c b/drivers/usb/g

[PATCH 06/14] usb: mv_u3d_core: using common vbus_active

2013-03-13 Thread Peter Chen
Using common vbus_active to indicate vbus status CC: Yu Xu Signed-off-by: Peter Chen --- drivers/usb/gadget/mv_u3d.h |1 - drivers/usb/gadget/mv_u3d_core.c | 14 +++--- 2 files changed, 7 insertions(+), 8 deletions(-) diff --git a/drivers/usb/gadget/mv_u3d.h b/drivers/usb/ga

[PATCH 05/14] usb: lpc32xx_udc: using common vbus_active

2013-03-13 Thread Peter Chen
Using common vbus_active to indicate vbus status CC: Felipe Balbi Signed-off-by: Peter Chen --- drivers/usb/gadget/lpc32xx_udc.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/usb/gadget/lpc32xx_udc.c b/drivers/usb/gadget/lpc32xx_udc.c index aa04089..13270a9 10

[PATCH 07/14] usb: mv_udc: using common vbus_active

2013-03-13 Thread Peter Chen
Using common vbus_active to indicate vbus status CC: Chao Xie Signed-off-by: Peter Chen --- drivers/usb/gadget/mv_udc.h |1 - drivers/usb/gadget/mv_udc_core.c | 14 +++--- 2 files changed, 7 insertions(+), 8 deletions(-) diff --git a/drivers/usb/gadget/mv_udc.h b/drivers/usb

  1   2   >