Re: [PATCH v2 06/10] usb: xhci: Enable runtime pm in xhci-plat

2013-03-04 Thread Vivek Gautam
Hi, On Sat, Mar 2, 2013 at 9:23 PM, Alan Stern wrote: > On Sat, 2 Mar 2013, Vivek Gautam wrote: > >> By enabling runtime pm in this driver allows users of >> xhci-plat to enter into runtime pm. This is not full >> runtime pm support (AKA xhci-plat doesn't actually power >> anything off when in r

[PATCH][v2] xhci: correctly enable interrupts

2013-03-04 Thread Hannes Reinecke
xhci has its own interrupt enabling routine, which will try to use MSI-X/MSI if present. So the usb core shouldn't try to enable legacy interrupts; on some machines the xhci legacy IRQ setting is invalid. Cc: Bjorn Helgaas Cc: Oliver Neukum Cc: Thomas Renninger Cc: Yinghai Lu Cc: Frederik Himp

[PATCH 1/3] usb: phy: samsung: Convert to devm_ioremap_resource()

2013-03-04 Thread Sachin Kamat
Use the newly introduced devm_ioremap_resource() instead of devm_request_and_ioremap() which provides more consistent error handling. devm_ioremap_resource() provides its own error messages; so all explicit error messages can be removed from the failure code paths. Signed-off-by: Sachin Kamat --

[PATCH 2/3] usb: phy: omap-usb3: Convert to devm_ioremap_resource()

2013-03-04 Thread Sachin Kamat
Use the newly introduced devm_ioremap_resource() instead of devm_request_and_ioremap() which provides more consistent error handling. devm_ioremap_resource() provides its own error messages; so all explicit error messages can be removed from the failure code paths. Signed-off-by: Sachin Kamat Cc

[PATCH 3/3] usb: phy: omap-control-usb: Convert to devm_ioremap_resource()

2013-03-04 Thread Sachin Kamat
Use the newly introduced devm_ioremap_resource() instead of devm_request_and_ioremap() which provides more consistent error handling. devm_ioremap_resource() provides its own error messages; so all explicit error messages can be removed from the failure code paths. Signed-off-by: Sachin Kamat Cc

Re: Testing for hardware bug in EHCI controllers

2013-03-04 Thread Lan Tianyu
2013/2/26 Alan Stern : > Sarah (and anyone else who's interested): > > A while ago I wrote about a hardware bug in my Intel ICH5 and ICH8 EHCI > controllers. You pointed out that these are rather old components, not > being used in current systems, which is quite true. > > Now I have figured out a

Re: [PATCH] fusb300_udc: modify stall clear and idma reset procedure

2013-03-04 Thread Yuan-Hsin Chen
Hi, On Wed, Feb 27, 2013 at 1:59 AM, Felipe Balbi wrote: > Hi, > > On Fri, Feb 22, 2013 at 07:09:39AM +, Yuan-Hsin Chen wrote: >> From: Yuan-Hsin Chen >> >> Due to fusb300 controller modification, stall clear procedure should be >> modified consistantly. This patch also fixes software bugs:

Re: [PATCH 1/3] usb: phy: samsung: Convert to devm_ioremap_resource()

2013-03-04 Thread Thierry Reding
On Mon, Mar 04, 2013 at 02:05:41PM +0530, Sachin Kamat wrote: > Use the newly introduced devm_ioremap_resource() instead of > devm_request_and_ioremap() which provides more consistent error handling. > > devm_ioremap_resource() provides its own error messages; so all explicit > error messages can

Re: [PATCH 2/3] usb: phy: omap-usb3: Convert to devm_ioremap_resource()

2013-03-04 Thread Thierry Reding
On Mon, Mar 04, 2013 at 02:05:42PM +0530, Sachin Kamat wrote: > Use the newly introduced devm_ioremap_resource() instead of > devm_request_and_ioremap() which provides more consistent error handling. > > devm_ioremap_resource() provides its own error messages; so all explicit > error messages can

Re: [PATCH 3/3] usb: phy: omap-control-usb: Convert to devm_ioremap_resource()

2013-03-04 Thread Thierry Reding
On Mon, Mar 04, 2013 at 02:05:43PM +0530, Sachin Kamat wrote: > Use the newly introduced devm_ioremap_resource() instead of > devm_request_and_ioremap() which provides more consistent error handling. > > devm_ioremap_resource() provides its own error messages; so all explicit > error messages can

[PATCH 3.8-stable] usbnet: smsc95xx: fix suspend failure

2013-03-04 Thread Ming Lei
The three below functions: smsc95xx_enter_suspend0() smsc95xx_enter_suspend1() smsc95xx_enter_suspend2() return > 0 in case of success, so they will cause smsc95xx_suspend() to return > 0 and suspend failure. This patch is backported from the upstream commit: Fro

Re: [PATCH v2 1/5] usb: chipidea: udc: move _ep_queue into an unlocked function

2013-03-04 Thread Michael Grzeschik
On Mon, Mar 04, 2013 at 10:44:25AM +0800, Peter Chen wrote: > On Fri, Mar 01, 2013 at 03:42:23PM +0100, Michael Grzeschik wrote: > > There is no need to call ep_queue unlocked inside the own driver. We > > move its functionionality into an unlocked version. > > > > This patch removes potential unl

Re: [PATCH v10 6/8] usb: chipidea: imx: add internal vbus regulator control

2013-03-04 Thread Felipe Balbi
Hi Greg, On Wed, Feb 27, 2013 at 04:43:22PM +0200, Darius Augulis wrote: > Hi balbi, > > actually no. I don't work with this hardware any more and don't have > free time to support it. > Please feel free to remove it if it breaks other things. since nobody seems to care about imx_udc and it's cu

Re: [PATCH][v2] xhci: correctly enable interrupts

2013-03-04 Thread David Härdeman
On Mon, Mar 04, 2013 at 09:22:04AM +0100, Hannes Reinecke wrote: >xhci has its own interrupt enabling routine, which will try to >use MSI-X/MSI if present. So the usb core shouldn't try to enable >legacy interrupts; on some machines the xhci legacy IRQ setting >is invalid. > >Cc: Bjorn Helgaas >Cc

v3.8 regression: Huawei mode switching fails (was Re: [PATCH 2/2]linux-usb:optimize to match the Huawei USB storage devices and support new switch command)

2013-03-04 Thread Bjørn Mork
Hello Franko, This patch causes a number of regressions for both the Huawei devices I have available for testing. One of them is completely unusable in v3.8 (unable to switch to modem mode) unless the usb-storage driver is disabled. I realize that some devices are historically handled by the usb-

[GIT PULL] usb: fixes for v3.9-rc2

2013-03-04 Thread Felipe Balbi
Hi Greg, Here's my first set of fixes for the v3.9-rc cycle. Nothing scary, all fixes have been pending for a while now. I ran a few randconfig cycles with my own seed, all looks good. Let me know if you want any changes. The following changes since commit 6dbe51c251a327e012439c4772097a13df43c5b

[PATCH -v3 13/23] uwb: rename random32() to prandom_u32()

2013-03-04 Thread Akinobu Mita
Use more preferable function name which implies using a pseudo-random number generator. Signed-off-by: Akinobu Mita Cc: linux-usb@vger.kernel.org --- No change from v2 drivers/uwb/rsv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/uwb/rsv.c b/drivers/uwb/rsv.

[PATCH] USB: storage: fix Huawei mode switching regression

2013-03-04 Thread Bjørn Mork
This reverts commit 200e0d99 ("USB: storage: optimize to match the Huawei USB storage devices and support new switch command" and the followup bugfix commit cd060956 ("USB: storage: properly handle the endian issues of idProduct"). The commit effectively added a large number of Huawei devices to t

Re: [PATCH][v2] xhci: correctly enable interrupts

2013-03-04 Thread Sergei Shtylyov
Hello. On 04-03-2013 12:22, Hannes Reinecke wrote: xhci has its own interrupt enabling routine, which will try to use MSI-X/MSI if present. So the usb core shouldn't try to enable legacy interrupts; on some machines the xhci legacy IRQ setting is invalid. Cc: Bjorn Helgaas Cc: Oliver Neukum

Re: [V8 PATCH 01/16] usb: phy: mv_usb2: add PHY driver for marvell usb2 controller

2013-03-04 Thread Felipe Balbi
On Wed, Feb 20, 2013 at 11:07:11PM -0500, Chao Xie wrote: > The PHY is seperated from usb controller. > The usb controller used in marvell pxa168/pxa910/mmp2 are same, > but PHY initialization may be different. > the usb controller can support udc/otg/ehci, and for each of > the mode, it need PHY t

Re: [V8 PATCH 02/16] usb: gadget: mv_udc: use PHY driver for udc

2013-03-04 Thread Felipe Balbi
On Wed, Feb 20, 2013 at 11:07:12PM -0500, Chao Xie wrote: > Originaly, udc driver will call the callbacks in platform data > for PHY initialization and shut down. > With PHY driver, it will call the APIs provided by PHY driver > for PHY initialization and shut down. It removes the callbacks > in pl

Re: [PATCH] USB: storage: fix Huawei mode switching regression

2013-03-04 Thread Ben Hutchings
On Mon, 2013-03-04 at 14:19 +0100, Bjørn Mork wrote: [...] > In-kernel mode switching was deprecated years ago with the > development of the more user friendly userspace alternatives. The > existing list of devices in usb-storage was only kept to prevent > breaking already working systems. The lon

Re: [PATCH] drivers/usb/gadget: beautify code, delete unused code

2013-03-04 Thread Felipe Balbi
Hi, On Thu, Feb 28, 2013 at 04:13:01PM +0800, Chen Gang wrote: > > originally, when deleted the relative code, left some 'another'. > need delete 'another', too. > the relative patches are: > > commit 96f8db6a77e3490608e5b5b3f57e7201f8c85496 > Author: Felipe Balbi > Date: Mo

Re: [PATCH 3/5] usb: musb: ux500: add otg notifier support

2013-03-04 Thread Felipe Balbi
On Thu, Feb 28, 2013 at 11:38:52AM +0100, Fabio Baltieri wrote: > Add transceiver notifier event handling to the ux500 driver to set vbus > on specific transceiver events. > > Acked-by: Linus Walleij > Signed-off-by: Fabio Baltieri > --- > drivers/usb/musb/ux500.c | 41 +

Re: [PATCH RFC] usb: dwc3: Get PHY from platform specific dwc3 dt node.

2013-03-04 Thread Felipe Balbi
Hi, On Fri, Mar 01, 2013 at 08:41:29AM +0200, Felipe Balbi wrote: > > >> >> >> Moreover, SoCs having multiple dwc3 controllers will have multiple > > >> >> >> PHYs, which eventually be added using usb_add_phy_dev(), and not > > >> >> >> using usb_add_phy(). So each dwc3 controller won't be able to

Re: Testing for hardware bug in EHCI controllers

2013-03-04 Thread Alan Stern
On Mon, 4 Mar 2013, Ming Lei wrote: > On Tue, Feb 26, 2013 at 4:54 AM, Alan Stern wrote: > > > > > I'd be interested to hear the results of testing on a variety of > > controllers. (This computer also has an NEC EHCI controller, and that > > one does not have the bug.) Do the EHCI controllers

Re: Testing for hardware bug in EHCI controllers

2013-03-04 Thread Alan Stern
On Mon, 4 Mar 2013, Bo Shen wrote: > Hi Alan, > > On 02/26/2013 04:54 AM, Alan Stern wrote: > > Sarah (and anyone else who's interested): > > > > A while ago I wrote about a hardware bug in my Intel ICH5 and ICH8 EHCI > > controllers. You pointed out that these are rather old components, not > >

Re: [PATCH][v2] xhci: correctly enable interrupts

2013-03-04 Thread Alan Stern
On Mon, 4 Mar 2013, Hannes Reinecke wrote: > xhci has its own interrupt enabling routine, which will try to > use MSI-X/MSI if present. So the usb core shouldn't try to enable > legacy interrupts; on some machines the xhci legacy IRQ setting > is invalid. This version of the patch is much better

Re: [PATCH v2 06/10] usb: xhci: Enable runtime pm in xhci-plat

2013-03-04 Thread Alan Stern
On Mon, 4 Mar 2013, Vivek Gautam wrote: > >> @@ -149,6 +150,8 @@ static int xhci_plat_probe(struct platform_device > >> *pdev) > >> if (ret) > >> goto put_usb3_hcd; > >> > >> + pm_runtime_enable(&pdev->dev); > > > > This is generally not a good idea. You shouldn't enable

Re: [PATCH v2 01/10] usb: phy: Add APIs for runtime power management

2013-03-04 Thread Felipe Balbi
Hi, On Sat, Mar 02, 2013 at 06:53:02PM +0530, Vivek Gautam wrote: > Adding APIs to handle runtime power management on PHY > devices. PHY consumers may need to wake-up/suspend PHYs > when they work across autosuspend. > > Signed-off-by: Vivek Gautam > --- > include/linux/usb/phy.h | 26 ++

Re: Testing for hardware bug in EHCI controllers

2013-03-04 Thread Alan Stern
On Mon, 4 Mar 2013, Lan Tianyu wrote: > Test on the Sandybridge platform. > At the first time, I get following output. But after that, I was > hard to get any output. And test on the v3.8. You have to unplug the flash drive after running the test each time. By the way, be sure to apply Clemens L

Re: [PATCH v2 06/10] usb: xhci: Enable runtime pm in xhci-plat

2013-03-04 Thread Alan Stern
On Sun, 3 Mar 2013, Felipe Balbi wrote: > > > this is good point and, in fact, a doubt I have myself. How are we > > > supposed to check if device is suspended ? In case it _is_ suspended we > > > might not be able to read device's registers due to clocks possibly > > > being gated. > > > > That'

Re: [PATCH][v2] xhci: correctly enable interrupts

2013-03-04 Thread Thomas Renninger
On Monday, March 04, 2013 10:26:40 AM Alan Stern wrote: > On Mon, 4 Mar 2013, Hannes Reinecke wrote: > > xhci has its own interrupt enabling routine, which will try to > > use MSI-X/MSI if present. So the usb core shouldn't try to enable > > legacy interrupts; on some machines the xhci legacy IRQ s

[PATCH][v3] xhci: correctly enable interrupts

2013-03-04 Thread Thomas Renninger
From: Hannes Reinecke xhci has its own interrupt enabling routine, which will try to use MSI-X/MSI if present. So the usb core shouldn't try to enable legacy interrupts; on some machines the xhci legacy IRQ setting is invalid. v3: Be careful to not break XHCI_BROKEN_MSI workaround (by trenn) Cc

Re: [PATCH] USB: storage: fix Huawei mode switching regression

2013-03-04 Thread Bjørn Mork
Ben Hutchings writes: > On Mon, 2013-03-04 at 14:19 +0100, Bjørn Mork wrote: > [...] >> In-kernel mode switching was deprecated years ago with the >> development of the more user friendly userspace alternatives. The >> existing list of devices in usb-storage was only kept to prevent >> breaking al

Re: [PATCH] usb: host: tegra: Reset Tegra USB controller before init

2013-03-04 Thread Stephen Warren
On 03/04/2013 12:55 AM, Venu Byravarasu wrote: > Stephen Warren wrote at Thursday, February 28, 2013 11:47 PM: >> On 02/27/2013 11:36 PM, Venu Byravarasu wrote: >>> To clear any configurations made by U-Boot on Tegra USB controller, >>> reset it before init in probe. >> >>> diff --git a/drivers/usb

Re: [PATCH] USB: storage: fix Huawei mode switching regression

2013-03-04 Thread Matthew Dharm
Frankly, I consider it appropriate. The question is not one of reminding me of what I said earlier it's one of pointing people in the right direction. Frankly, some of the fault for this patch lies with Greg and myself for letting it through. I had just assumed that the Huawei guys had alrea

Re: [PATCH][v3] xhci: correctly enable interrupts

2013-03-04 Thread Sergei Shtylyov
Hello. On 03/04/2013 07:14 PM, Thomas Renninger wrote: From: Hannes Reinecke xhci has its own interrupt enabling routine, which will try to use MSI-X/MSI if present. So the usb core shouldn't try to enable legacy interrupts; on some machines the xhci legacy IRQ setting is invalid. v3: Be care

Re: [PATCH][v3] xhci: correctly enable interrupts

2013-03-04 Thread Alan Stern
On Mon, 4 Mar 2013, Sergei Shtylyov wrote: > > @@ -371,6 +371,7 @@ static int xhci_try_enable_msi(struct usb_hcd *hcd) > > return -EINVAL; > > } > > > > + legacy_irq: > > > > Labels shouldn't be indented by a space (unless the existing coding > style has them indented alr

Re: [PATCH] usb: host: tegra: Reset Tegra USB controller before init

2013-03-04 Thread Alan Stern
On Mon, 4 Mar 2013, Stephen Warren wrote: > On 03/04/2013 12:55 AM, Venu Byravarasu wrote: > > Stephen Warren wrote at Thursday, February 28, 2013 11:47 PM: > >> On 02/27/2013 11:36 PM, Venu Byravarasu wrote: > >>> To clear any configurations made by U-Boot on Tegra USB controller, > >>> reset it

Re: Testing for hardware bug in EHCI controllers

2013-03-04 Thread Frank Schäfer
Am 25.02.2013 21:54, schrieb Alan Stern: > Sarah (and anyone else who's interested): > > A while ago I wrote about a hardware bug in my Intel ICH5 and ICH8 EHCI > controllers. You pointed out that these are rather old components, not > being used in current systems, which is quite true. > > Now I

Re: Testing for hardware bug in EHCI controllers

2013-03-04 Thread Alan Stern
On Mon, 4 Mar 2013, [ISO-8859-1] Frank Sch�fer wrote: > Here is the result of your test procedure (fix applied, running kernel > 3.9-rc1) for the following device: > > 00:02.1 USB controller [0c03]: NVIDIA Corporation MCP61 USB 2.0 > Controller [10de:03f2] (rev a2) (prog-if 20 [EHCI]) > S

Re: [PATCH 3.8-stable] usbnet: smsc95xx: fix suspend failure

2013-03-04 Thread David Miller
From: Ming Lei Date: Mon, 4 Mar 2013 18:07:13 +0800 > The three below functions: > > smsc95xx_enter_suspend0() > smsc95xx_enter_suspend1() > smsc95xx_enter_suspend2() > > return > 0 in case of success, so they will cause smsc95xx_suspend() > to return > 0 and suspend fa

Re: [PATCH] USB: storage: fix Huawei mode switching regression

2013-03-04 Thread Bjørn Mork
Matthew Dharm writes: > Frankly, I consider it appropriate. OK, I'll try to cook something up. > The question is not one of reminding me of what I said earlier > it's one of pointing people in the right direction. Frankly, some of > the fault for this patch lies with Greg and myself for le

[PATCH v6 0/7] DWC2 DesignWare HS OTG driver

2013-03-04 Thread Paul Zimmerman
Hi Greg, Here is the latest version of the DWC2 patch set. This version includes changes suggested by Felipe in his last review, plus a couple of changes requested by Alan Stern. Please consider applying these to usb-next. Felipe thought these should go in through your tree, since they don't cont

[PATCH v6 1/7] usb: common: add a routine to print the OTG state

2013-03-04 Thread Paul Zimmerman
Add a usb_otg_state_string() routine to print the OTG state for debugging Signed-off-by: Paul Zimmerman Acked-by: Felipe Balbi --- drivers/usb/usb-common.c | 26 ++ include/linux/usb/phy.h | 8 2 files changed, 34 insertions(+) diff --git a/drivers/usb/usb-co

[PATCH v6 4/7] HCD descriptor DMA support for the DWC2 driver

2013-03-04 Thread Paul Zimmerman
This file contains code to support the HCD descriptor DMA mode of the controller Signed-off-by: Paul Zimmerman Reviewed-by: Felipe Balbi --- drivers/usb/dwc2/hcd_ddma.c | 1183 +++ 1 file changed, 1183 insertions(+) create mode 100644 drivers/usb/dwc2/hc

[PATCH v6 5/7] PCI bus interface for the DWC2 driver

2013-03-04 Thread Paul Zimmerman
This file contains the PCI bus interface "glue" for the DWC2 driver Signed-off-by: Paul Zimmerman Reviewed-by: Felipe Balbi --- drivers/usb/dwc2/pci.c | 198 + 1 file changed, 198 insertions(+) create mode 100644 drivers/usb/dwc2/pci.c diff --gi

[PATCH v6 6/7] Hook the DWC2 driver into the build system

2013-03-04 Thread Paul Zimmerman
Add the DWC2 Kconfig and Makefile, and modify the USB Kconfig and Makefile to include them Signed-off-by: Paul Zimmerman Acked-by: Felipe Balbi --- drivers/usb/Kconfig | 2 ++ drivers/usb/Makefile | 2 ++ drivers/usb/dwc2/Kconfig | 41 + dri

[PATCH v6 7/7] Add a MAINTAINERS entry for the DWC2 driver

2013-03-04 Thread Paul Zimmerman
Add myself as maintainer of the DWC2 driver Signed-off-by: Paul Zimmerman --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index e95b1e9..27874f0 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2470,6 +2470,12 @@ M: Matthew Garrett S:

[PATCH] usb/gadget: initialize gadget functions helper befor functions & gadgets

2013-03-04 Thread Sebastian Andrzej Siewior
Fengguang Wu run into a kernel ops after he complied dummy_hcd and g_cdc into the kernel. The problem was that u_serial was used by g_cdc before u_serial was initialized. In the module case eveything is initialized in the correct order but if we compile it into the kernel we rely on Makefile order

[RFC] USB: storage: in-kernel modeswitching is deprecated

2013-03-04 Thread Bjørn Mork
Signed-off-by: Bjørn Mork --- So, is something like this good enough? Bjørn drivers/usb/storage/unusual_devs.h |8 1 file changed, 8 insertions(+) diff --git a/drivers/usb/storage/unusual_devs.h b/drivers/usb/storage/unusual_devs.h index d305a5a..1e03a45 100644 --- a/drivers/usb

Re: [RFC] USB: storage: in-kernel modeswitching is deprecated

2013-03-04 Thread Sergei Shtylyov
Hello. On 03/05/2013 12:57 AM, Bjørn Mork wrote: Signed-off-by: Bjørn Mork --- So, is something like this good enough? Bjørn drivers/usb/storage/unusual_devs.h |8 1 file changed, 8 insertions(+) diff --git a/drivers/usb/storage/unusual_devs.h b/drivers/usb/storage/unusual

Re: [PATCH] usb/gadget: initialize gadget functions helper befor functions & gadgets

2013-03-04 Thread Michal Nazarewicz
On Mon, Mar 04 2013, Sebastian Andrzej Siewior wrote: > Fengguang Wu run into a kernel ops after he complied dummy_hcd and g_cdc > into the kernel. The problem was that u_serial was used by g_cdc before > u_serial was initialized. In the module case eveything is initialized in > the correct order b

Re: [RFC] USB: storage: in-kernel modeswitching is deprecated

2013-03-04 Thread Ben Hutchings
On Mon, Mar 04, 2013 at 10:57:22PM +0100, Bjørn Mork wrote: > Signed-off-by: Bjørn Mork > --- > So, is something like this good enough? > > > Bjørn [...] I think this comment is good, but then it's not my driver. Ben. -- Ben Hutchings We get into the habit of living before acquiring the hab

[PATCH] USB: fix trivial usb_device kernel-doc errors

2013-03-04 Thread Nishanth Menon
Fix trivial kernel-doc warnings: Warning(include/linux/usb.h:574): No description found for parameter 'usb3_lpm_enabled' Warning(include/linux/usb.h:574): Excess struct/union/enum/typedef member 'usb_classdev' description in 'usb_device' Warning(include/linux/usb.h:574): Excess struct/union/enum/

[PATCH] usb: gadget: composite: fix kernel-doc warnings

2013-03-04 Thread Nishanth Menon
A few trivial fixes for composite driver. Fixes: Warning(include/linux/usb/composite.h:165): No description found for parameter 'fs_descriptors' Warning(include/linux/usb/composite.h:165): Excess struct/union/enum/typedef member 'descriptors' description in 'usb_function' Warning(include/linux/us

Re: [RFC] USB: storage: in-kernel modeswitching is deprecated

2013-03-04 Thread Matthew Dharm
I'm happy with it, modulo Sergi's grammer comment. ACKed-by: Matthew Dharm mdharm-...@one-eyed-alien.net Matt On Mon, Mar 4, 2013 at 1:57 PM, Bjørn Mork wrote: > Signed-off-by: Bjørn Mork > --- > So, is something like this good enough? > > > Bjørn > > drivers/usb/storage/unusual_devs.h |8

Re: [PATCH] USB: storage: fix Huawei mode switching regression

2013-03-04 Thread Josua Dietze
Am 04.03.2013 20:22, schrieb Bjørn Mork: Matthew Dharm writes: The question is not one of reminding me of what I said earlier it's one of pointing people in the right direction. Frankly, some of the fault for this patch lies with Greg and myself for letting it through. I had just assumed

Re: [PATCH v6 0/7] DWC2 DesignWare HS OTG driver

2013-03-04 Thread Greg KH
On Mon, Mar 04, 2013 at 12:21:43PM -0800, Paul Zimmerman wrote: > Hi Greg, > > Here is the latest version of the DWC2 patch set. This version includes > changes suggested by Felipe in his last review, plus a couple of changes > requested by Alan Stern. > > Please consider applying these to usb-ne

Re: [PATCH] usb: host: tegra: Reset Tegra USB controller before init

2013-03-04 Thread gre...@linuxfoundation.org
On Mon, Mar 04, 2013 at 09:55:44AM -0700, Stephen Warren wrote: > On 03/04/2013 12:55 AM, Venu Byravarasu wrote: > > Stephen Warren wrote at Thursday, February 28, 2013 11:47 PM: > >> On 02/27/2013 11:36 PM, Venu Byravarasu wrote: > >>> To clear any configurations made by U-Boot on Tegra USB contro

Re: [GIT PULL] usb: fixes for v3.9-rc2

2013-03-04 Thread Greg KH
On Mon, Mar 04, 2013 at 02:24:20PM +0200, Felipe Balbi wrote: > Hi Greg, > > Here's my first set of fixes for the v3.9-rc cycle. Nothing scary, all fixes > have been pending for a while now. I ran a few randconfig cycles with my > own seed, all looks good. > > Let me know if you want any changes.

Re: [PATCH] drivers/usb/gadget: using strlcpy instead of strncpy

2013-03-04 Thread Chen Gang
于 2013年03月02日 03:47, Laurent Pinchart 写道: > I've taken the patch in my tree. > > I've just sent a consolidated series of most pending UVC gadget patches to > the > list, and I will send you a pull request as soon as I receive a Tested-by. thanks -- Chen Gang Asianux Corporation -- To unsub

Re: [PATCH] drivers/usb/gadget: beautify code, delete unused code

2013-03-04 Thread Chen Gang
于 2013年03月04日 22:35, Felipe Balbi 写道: > this is the wrong fix, I believe. Looks like when I wrote the commits > you mention, I deleted more code then I should. Looks like the real fix > would be to add back: > > /* report disconnect; the driver is already quiesced */ > if (driver) { >

Re: [V8 PATCH 01/16] usb: phy: mv_usb2: add PHY driver for marvell usb2 controller

2013-03-04 Thread Chao Xie
On Mon, Mar 4, 2013 at 10:21 PM, Felipe Balbi wrote: > On Wed, Feb 20, 2013 at 11:07:11PM -0500, Chao Xie wrote: >> The PHY is seperated from usb controller. >> The usb controller used in marvell pxa168/pxa910/mmp2 are same, >> but PHY initialization may be different. >> the usb controller can sup

Re: [V8 PATCH 02/16] usb: gadget: mv_udc: use PHY driver for udc

2013-03-04 Thread Chao Xie
On Mon, Mar 4, 2013 at 10:24 PM, Felipe Balbi wrote: > On Wed, Feb 20, 2013 at 11:07:12PM -0500, Chao Xie wrote: >> Originaly, udc driver will call the callbacks in platform data >> for PHY initialization and shut down. >> With PHY driver, it will call the APIs provided by PHY driver >> for PHY in

RE: [PATCH] USB: storage: fix Huawei mode switching regression

2013-03-04 Thread Fangxiaozhi (Franko)
> -Original Message- > From: Bjørn Mork [mailto:bj...@mork.no] > Sent: Monday, March 04, 2013 9:19 PM > To: linux-usb@vger.kernel.org > Cc: linux-ker...@vger.kernel.org; Fangxiaozhi (Franko); Xueguiying (Zihan); > Linlei (Lei Lin); Greg KH; Yili (Neil); Wangyuhua (Roger, Credit); Huqiao (

RE: v3.8 regression: Huawei mode switching fails (was Re: [PATCH 2/2]linux-usb:optimize to match the Huawei USB storage devices and support new switch command)

2013-03-04 Thread Fangxiaozhi (Franko)
Dear Mork: Thank you very much for your test. > -Original Message- > From: Bjørn Mork [mailto:bj...@mork.no] > Sent: Monday, March 04, 2013 7:41 PM > To: Fangxiaozhi (Franko) > Cc: linux-usb@vger.kernel.org; linux-ker...@vger.kernel.org; Xueguiying > (Zihan); Linlei (Lei Lin); g..

Re: [PATCH] drivers/usb/gadget: using strlcpy instead of strncpy

2013-03-04 Thread Chen Gang
于 2013年03月04日 01:35, Laurent Pinchart 写道: > On Sunday 03 March 2013 01:23:46 Felipe Balbi wrote: >> > On Fri, Mar 01, 2013 at 08:47:34PM +0100, Laurent Pinchart wrote: >>> > > On Wednesday 27 February 2013 10:26:23 Felipe Balbi wrote: > > > On Sat, Feb 02, 2013 at 03:48:54PM +0800, Chen Gang w

Re: Testing for hardware bug in EHCI controllers

2013-03-04 Thread Bo Shen
Hi Alan, On 3/4/2013 23:16, Alan Stern wrote: On Mon, 4 Mar 2013, Bo Shen wrote: Hi Alan, On 02/26/2013 04:54 AM, Alan Stern wrote: Sarah (and anyone else who's interested): A while ago I wrote about a hardware bug in my Intel ICH5 and ICH8 EHCI controllers. You pointed out that these are

[PATCH 0/7] USB: don't recover device if suspend fails in system sleep

2013-03-04 Thread Ming Lei
Hi, This patch adds comments on interface driver suspend callback to emphasize that the failure return value is ignored by USB core in system sleep context, so do not try to recover device for this case, otherwise the URB traffic scheduled in recovery of failure path may cross system sleep, and ma

[PATCH 1/7] USB: adds comment on suspend callback

2013-03-04 Thread Ming Lei
This patch adds comments on interface driver suspend callback to emphasize that the failure return value is ignored by USB core in system sleep context, so do not try to recover device for this case. Signed-off-by: Ming Lei --- include/linux/usb.h |5 - 1 file changed, 4 insertions(+), 1

[PATCH 2/7] USB: serial: handle suspend failure path correctly

2013-03-04 Thread Ming Lei
This patch kills traffic even though type->suspend returns failure inside usb_serial_suspend from system sleep context because USB core ignores the failiure and lets system sleep go ahread, so the serial URB traffic need to be killed in this case. Cc: Johan Hovold Signed-off-by: Ming Lei --- dr

[PATCH 3/7] USBHID: don't recover device if suspend fails in system sleep

2013-03-04 Thread Ming Lei
If suspend callback fails in system sleep context, usb core will ignore the failure and let the system sleep go ahead further, so this patch doesn't recover device under this situation. Cc: Jiri Kosina Signed-off-by: Ming Lei --- drivers/hid/usbhid/hid-core.c | 14 +- 1 file chang

[PATCH 4/7] usbnet: cdc_mbim: don't recover device if suspend fails in system sleep

2013-03-04 Thread Ming Lei
If suspend callback fails in system sleep context, usb core will ignore the failure and let system sleep go ahead further, so this patch doesn't recover device under this situation. Cc: Bjørn Mork Signed-off-by: Ming Lei --- drivers/net/usb/cdc_mbim.c |2 +- 1 file changed, 1 insertion(+),

[PATCH 5/7] usbnet: smsc95xx: don't recover device if suspend fails in system sleep

2013-03-04 Thread Ming Lei
If suspend callback fails in system sleep context, usb core will ignore the failure and let system sleep go ahead further, so this patch doesn't recover device under this situation. Cc: Steve Glendinning Signed-off-by: Ming Lei --- drivers/net/usb/smsc95xx.c |2 +- 1 file changed, 1 inserti

[PATCH 6/7] usbnet: smsc75xx: don't recover device if suspend fails in system sleep

2013-03-04 Thread Ming Lei
If suspend callback fails in system sleep context, usb core will ignore the failure and let system sleep go ahead further, so this patch doesn't recover device under this situation. Cc: Steve Glendinning Signed-off-by: Ming Lei --- drivers/net/usb/smsc75xx.c |2 +- 1 file changed, 1 inserti

[PATCH 7/7] usbnet: qmi_wwan: don't recover device if suspend fails in system sleep

2013-03-04 Thread Ming Lei
If suspend callback fails in system sleep context, usb core will ignore the failure and let system sleep go ahead further, so this patch doesn't recover device under this situation. Cc: Bjørn Mork Signed-off-by: Ming Lei --- drivers/net/usb/qmi_wwan.c |2 +- 1 file changed, 1 insertion(+),

[PATCH 1/1] usb: gadget: fsl_udc_core: Use module_platform_driver_probe macro

2013-03-04 Thread Sachin Kamat
module_platform_driver_probe() eliminates the boilerplate and simplifies the code. Signed-off-by: Sachin Kamat Cc: Li Yang --- drivers/usb/gadget/fsl_udc_core.c | 16 +--- 1 files changed, 1 insertions(+), 15 deletions(-) diff --git a/drivers/usb/gadget/fsl_udc_core.c b/drivers/

Re: [PATCH 0/7] USB: don't recover device if suspend fails in system sleep

2013-03-04 Thread Ming Lei
On Tue, Mar 5, 2013 at 12:01 PM, Ming Lei wrote: > Hi, > > This patch adds comments on interface driver suspend callback > to emphasize that the failure return value is ignored by > USB core in system sleep context, so do not try to recover > device for this case, otherwise the URB traffic schedul

Re: [PATCH 0/7] USB: don't recover device if suspend fails in system sleep

2013-03-04 Thread Bjørn Mork
Ming Lei writes: > Hi, > > This patch adds comments on interface driver suspend callback > to emphasize that the failure return value is ignored by > USB core in system sleep context, so do not try to recover > device for this case, otherwise the URB traffic scheduled > in recovery of failure pat

Re: [PATCH 4/7] usbnet: cdc_mbim: don't recover device if suspend fails in system sleep

2013-03-04 Thread Bjørn Mork
Ming Lei writes: > If suspend callback fails in system sleep context, usb core will > ignore the failure and let system sleep go ahead further, so > this patch doesn't recover device under this situation. > > Cc: Bjørn Mork > Signed-off-by: Ming Lei > --- > drivers/net/usb/cdc_mbim.c |2 +-

Re: [PATCH 7/7] usbnet: qmi_wwan: don't recover device if suspend fails in system sleep

2013-03-04 Thread Bjørn Mork
Ming Lei writes: > If suspend callback fails in system sleep context, usb core will > ignore the failure and let system sleep go ahead further, so > this patch doesn't recover device under this situation. > > Cc: Bjørn Mork > Signed-off-by: Ming Lei > --- > drivers/net/usb/qmi_wwan.c |2 +-