[PATCH v8 0/8] Add tested id switch and vbus connect detect support for Chipidea

2013-02-05 Thread Peter Chen
Changes for v7: - Add ci_supports_gadget helper to know if the controller supports gadget, if the controller supports gadget, it needs to read otgsc to know the vbus value, basically, if the controller supports gadget, it will support host as well [3/8] - At ci_hdrc_probe, it needs to add free memo

[PATCH v8 1/8] Revert "USB: chipidea: add vbus detect for udc"

2013-02-05 Thread Peter Chen
vbus register is at otgsc, and vbus detect does not belong to device function. Revert this patch, and will move vbus detect function to drivers/usb/chipidea/udc.c This reverts commit 8c4fc031954b4eb72daf13d3c907a985a3eee208. Signed-off-by: Peter Chen diff --git a/drivers/usb/chipidea/ci.h b/dri

[PATCH v8 2/8] usb: chipidea: add otg file

2013-02-05 Thread Peter Chen
Implement struct usb_otg, In that way, calling otg_set_peripheral will not be failed at udc.c. Signed-off-by: Peter Chen diff --git a/drivers/usb/chipidea/Makefile b/drivers/usb/chipidea/Makefile index d92ca32..11f513c 100644 --- a/drivers/usb/chipidea/Makefile +++ b/drivers/usb/chipidea/Makefil

[PATCH v8 3/8] usb: chipidea: add otg id switch and vbus connect/disconnect detect

2013-02-05 Thread Peter Chen
The main design flow is the same with msm otg driver, that is the id and vbus interrupt are handled at core driver, others are handled by individual drivers. - At former design, when switch usb role from device->host, it will call udc_stop, it will remove the gadget driver, so when switch role fro

[PATCH v8 5/8] usb: chipidea: udc: add pullup/pulldown dp at hw_device_state

2013-02-05 Thread Peter Chen
- During the connect/disconnect host, we need to pullup and pulldown dp - Make sure the dp is not pullup until the vbus is on when flag CI13XXX_PULLUP_ON_VBUS is set - Using hw_device_state when set run/stop bit Signed-off-by: Peter Chen diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chip

[PATCH v8 6/8] usb: chipidea: udc: retire the flag CI13_PULLUP_ON_VBUS

2013-02-05 Thread Peter Chen
(change CI13XXX to CI13 to avoid junk email check) Now, we have handled vbus session in core driver when the vbus interrupt occurs, so our pullup operations are all according to vbus. Of cource, the software can still call .pullup when device connects to host if it wants to connect/disconnect with

[PATCH v8 7/8] usb: chipidea: imx: add internal vbus regulator control

2013-02-05 Thread Peter Chen
- For host, the vbus should always be on. - For otg, the vbus is off defaultly, the vbus needs to be turned on/off when usb role switches. Signed-off-by: Peter Chen diff --git a/drivers/usb/chipidea/ci.h b/drivers/usb/chipidea/ci.h index 3ebe87a..bd78078 100644 --- a/drivers/usb/chipidea/ci.h ++

[PATCH v8 8/8] usb: chipidea: udc: fix the oops when plugs in usb cable after rmmod gadget

2013-02-05 Thread Peter Chen
When we rmmod gadget, the ci->driver needs to be cleared. Otherwise, we plug in usb cable again, the driver will consider gadget is there, in fact, it is removed. Below is the oops this patch fixes. root@freescale ~$ ci_hdrc ci_hdrc.0: Connected to host Unable to handle kernel paging request at vi

[PATCH v8 4/8] usb: chipidea: consolidate kinds of APIs for both roles

2013-02-05 Thread Peter Chen
- Create/destroy the gadget at udc's init and destory function - start/stop API are used at otg id switch and probe routine - Defer some gadget operations at ci's delayed work queue Signed-off-by: Peter Chen diff --git a/drivers/usb/chipidea/ci.h b/drivers/usb/chipidea/ci.h index 325d790..3ebe87

Re: Linux USB file storage gadget with new UDC

2013-02-05 Thread victor yeo
Hi, >>> Thanks, i added in UDC driver to call bulk_in_complete for every >>> request over a bulk in ep, now the gadget driver is able to process >> >> UDC shouldn't call bulk_in_complete() directly, you should be calling >> request->complete() instead. >> > > Yes, the UDC driver calls the request-

Re: [PATCH 01/13] usb: phy: nop: Add device tree support and binding information

2013-02-05 Thread Roger Quadros
On 02/05/2013 09:26 AM, Felipe Balbi wrote: > Hi, > > On Mon, Feb 04, 2013 at 05:58:48PM +0200, Roger Quadros wrote: >> The PHY clock, clock rate, VCC regulator and RESET regulator >> can now be provided via device tree. >> >> Signed-off-by: Roger Quadros >> --- >> .../devicetree/bindings/usb/us

Re: [PATCH 02/13] USB: phy: nop: Defer probe if device needs VCC/RESET

2013-02-05 Thread Roger Quadros
On 02/05/2013 07:54 AM, kishon wrote: > On Monday 04 February 2013 09:28 PM, Roger Quadros wrote: >> Add 2 flags, needs_vcc and needs_reset to platform data. >> If the flag is set and the regulator couldn't be found >> then we bail out with -EPROBE_DEFER. >> >> For device tree boot we depend on pre

Re: [PATCH 04/13] mfd: omap-usb-tll: Add device tree support

2013-02-05 Thread Roger Quadros
On 02/05/2013 08:04 AM, kishon wrote: > On Monday 04 February 2013 09:28 PM, Roger Quadros wrote: >> Enable this driver to probe in device tree boot. >> >> CC: Samuel Ortiz >> Signed-off-by: Roger Quadros >> --- >> .../devicetree/bindings/mfd/omap-usb-tll.txt | 17 + >>

Re: [PATCH 09/13] mfd: omap-usb-host: Add device tree support and binding information

2013-02-05 Thread Roger Quadros
On 02/05/2013 08:16 AM, kishon wrote: > On Monday 04 February 2013 09:28 PM, Roger Quadros wrote: >> Allows the OMAP HS USB host controller to be specified >> via device tree. >> >> CC: Samuel Ortiz >> Signed-off-by: Roger Quadros >> --- >> .../devicetree/bindings/mfd/omap-usb-host.txt |

Re: [PATCH 10/13] ARM: dts: OMAP4: Add HS USB Host IP nodes

2013-02-05 Thread Roger Quadros
On 02/05/2013 08:24 AM, kishon wrote: > On Monday 04 February 2013 09:28 PM, Roger Quadros wrote: >> Adds device nodes for HS USB Host module, TLL module, >> OHCI and EHCI controllers. >> >> Signed-off-by: Roger Quadros >> --- >> arch/arm/boot/dts/omap4.dtsi | 30 ++

Re: [PATCH 10/13] ARM: dts: OMAP4: Add HS USB Host IP nodes

2013-02-05 Thread kishon
On Tuesday 05 February 2013 02:24 PM, Roger Quadros wrote: On 02/05/2013 08:24 AM, kishon wrote: On Monday 04 February 2013 09:28 PM, Roger Quadros wrote: Adds device nodes for HS USB Host module, TLL module, OHCI and EHCI controllers. Signed-off-by: Roger Quadros --- arch/arm/boot/dts/oma

Re: [PATCH 10/13] ARM: dts: OMAP4: Add HS USB Host IP nodes

2013-02-05 Thread Roger Quadros
On 02/05/2013 09:41 AM, Felipe Balbi wrote: > On Mon, Feb 04, 2013 at 05:58:57PM +0200, Roger Quadros wrote: >> Adds device nodes for HS USB Host module, TLL module, >> OHCI and EHCI controllers. >> >> Signed-off-by: Roger Quadros >> --- >> arch/arm/boot/dts/omap4.dtsi | 30

Re: [PATCH 01/13] usb: phy: nop: Add device tree support and binding information

2013-02-05 Thread Felipe Balbi
On Tue, Feb 05, 2013 at 10:30:49AM +0200, Roger Quadros wrote: > On 02/05/2013 09:26 AM, Felipe Balbi wrote: > > Hi, > > > > On Mon, Feb 04, 2013 at 05:58:48PM +0200, Roger Quadros wrote: > >> The PHY clock, clock rate, VCC regulator and RESET regulator > >> can now be provided via device tree. >

Re: [PATCH 02/13] USB: phy: nop: Defer probe if device needs VCC/RESET

2013-02-05 Thread Felipe Balbi
On Tue, Feb 05, 2013 at 10:44:05AM +0200, Roger Quadros wrote: > >> diff --git a/include/linux/usb/nop-usb-xceiv.h > >> b/include/linux/usb/nop-usb-xceiv.h > >> index 3265b61..148d351 100644 > >> --- a/include/linux/usb/nop-usb-xceiv.h > >> +++ b/include/linux/usb/nop-usb-xceiv.h > >> @@ -6,6 +6,1

Re: [PATCH 01/30] USB: EHCI: split ehci-omap out to a separate driver

2013-02-05 Thread Felipe Balbi
On Mon, Jan 28, 2013 at 01:30:02PM +0200, Roger Quadros wrote: > From: Alan Stern > > This patch (as1645) converts ehci-omap over to the new "ehci-hcd is a > library" approach, so that it can coexist peacefully with other EHCI > platform drivers and can make use of the private area allocated at >

Re: [PATCH v3 10/30] USB: ehci-omap: Use PHY APIs to get the PHY device and put it out of suspend

2013-02-05 Thread Felipe Balbi
On Tue, Jan 29, 2013 at 10:30:05AM -0500, Alan Stern wrote: > On Tue, 29 Jan 2013, Roger Quadros wrote: > > > For each port that is in PHY mode we obtain a PHY device using the USB PHY > > library and put it out of suspend. > > > > It is up to platform code to associate the PHY to the controller'

Re: [PATCH 02/30] usb: phy: nop: use devm_kzalloc()

2013-02-05 Thread Felipe Balbi
On Mon, Jan 28, 2013 at 01:30:03PM +0200, Roger Quadros wrote: > Use resource managed kzalloc. > > Signed-off-by: Roger Quadros > --- Acked-by: Felipe Balbi > drivers/usb/otg/nop-usb-xceiv.c | 16 > 1 files changed, 4 insertions(+), 12 deletions(-) > > diff --git a/drivers

Re: [PATCH v2 03/30] usb: phy: nop: Manage PHY clock

2013-02-05 Thread Felipe Balbi
Hi, On Mon, Jan 28, 2013 at 01:30:04PM +0200, Roger Quadros wrote: > If the PHY has a clock associated to it then manage the clock. > We just enable the clock in .init() and disable it in .shutdown(). > > Add clk_rate parameter in platform data and configure the > clock rate during probe if suppl

Re: [PATCH v2 04/30] usb: phy: nop: Handle power supply regulator for the PHY

2013-02-05 Thread Felipe Balbi
On Mon, Jan 28, 2013 at 01:30:05PM +0200, Roger Quadros wrote: > We use "vcc" as the supply name for the PHY's power supply. > The power supply will be enabled during .init() and disabled > during .shutdown() > > Signed-off-by: Roger Quadros Acked-by: Felipe Balbi > --- > drivers/usb/otg/nop-

Re: [PATCH v2 05/30] usb: phy: nop: Handle RESET for the PHY

2013-02-05 Thread Felipe Balbi
On Mon, Jan 28, 2013 at 01:30:06PM +0200, Roger Quadros wrote: > We expect the RESET line to be modeled as a regulator with supply > name "reset". The regulator should be modeled such that enabling > the regulator brings the PHY device out of RESET and disabling the > regulator holds the device in

Re: [PATCH 06/30] usb: phy: nop: use new PHY API to register PHY

2013-02-05 Thread Felipe Balbi
On Mon, Jan 28, 2013 at 01:30:07PM +0200, Roger Quadros wrote: > We would need to support multiple PHYs of the same type > so use the new PHY API usb_add_phy_dev() to register the PHY. > > Signed-off-by: Roger Quadros Acked-by: Felipe Balbi > --- > drivers/usb/otg/nop-usb-xceiv.c |3 ++- >

Re: [PATCH 07/30] mfd: omap-usb-host: update nports in platform_data

2013-02-05 Thread Felipe Balbi
On Mon, Jan 28, 2013 at 01:30:08PM +0200, Roger Quadros wrote: > EHCI driver would need to know the number of ports available > on the platform. We set the nports parameter of platform_data > based on IP version if it was not already provided. > > Signed-off-by: Roger Quadros > Acked-by: Samuel O

Re: [PATCH 08/30] mfd: omap-usb-host: Remove PHY reset handling code

2013-02-05 Thread Felipe Balbi
On Mon, Jan 28, 2013 at 01:30:09PM +0200, Roger Quadros wrote: > PHY reset GPIO handling will be done in the PHY driver > > Signed-off-by: Roger Quadros > Acked-by: Samuel Ortiz Acked-by: Felipe Balbi > --- > drivers/mfd/omap-usb-host.c | 47 > --- >

Re: [PATCH 09/30] USB: ehci-omap: Use devm_request_and_ioremap()

2013-02-05 Thread Felipe Balbi
On Mon, Jan 28, 2013 at 01:30:10PM +0200, Roger Quadros wrote: > Make use of devm_request_and_ioremap() and correct comment. > > Signed-off-by: Roger Quadros Acked-by: Felipe Balbi > --- > drivers/usb/host/ehci-omap.c | 19 +-- > 1 files changed, 5 insertions(+), 14 deletion

Re: [PATCH v3 10/30] USB: ehci-omap: Use PHY APIs to get the PHY device and put it out of suspend

2013-02-05 Thread Felipe Balbi
On Tue, Jan 29, 2013 at 10:30:05AM -0500, Alan Stern wrote: > On Tue, 29 Jan 2013, Roger Quadros wrote: > > > For each port that is in PHY mode we obtain a PHY device using the USB PHY > > library and put it out of suspend. > > > > It is up to platform code to associate the PHY to the controller'

Re: [PATCH v2 11/30] usb: ehci-omap: Remove PHY reset handling code

2013-02-05 Thread Felipe Balbi
On Mon, Jan 28, 2013 at 12:34:16PM -0500, Alan Stern wrote: > On Mon, 28 Jan 2013, Roger Quadros wrote: > > > Reset GPIO handling for the PHY must be done in the PHY > > driver. We use the PHY helpers instead to reset the PHY. > > > > Signed-off-by: Roger Quadros > > Acked-by: Alan Stern Acke

Re: [PATCH v2 12/30] usb: ehci-omap: Remove PHY regulator handling code

2013-02-05 Thread Felipe Balbi
On Mon, Jan 28, 2013 at 12:35:25PM -0500, Alan Stern wrote: > On Mon, 28 Jan 2013, Roger Quadros wrote: > > > PHY regulator handling must be done in the PHY driver > > > > Signed-off-by: Roger Quadros > > Acked-by: Alan Stern Acked-by: Felipe Balbi -- balbi signature.asc Description: Dig

Re: [PATCH v2 13/30] ARM: OMAP2+: omap4panda: Provide USB Host's PHY platform data

2013-02-05 Thread Felipe Balbi
On Mon, Jan 28, 2013 at 01:30:14PM +0200, Roger Quadros wrote: > Add platform device and data for 'nop-usb-xceiv'. This will be used > as PHY for HS USB port 1, so provide binding information for it. > > Get rid of managing the PHY clock as it will be done by the PHY driver. > For that to work we

Re: [PATCH v2 14/30] ARM: OMAP2+: omap4panda: Adapt to ehci-omap changes

2013-02-05 Thread Felipe Balbi
On Mon, Jan 28, 2013 at 01:30:15PM +0200, Roger Quadros wrote: > Model RESET and Power for HS USB Port 1 as GPIO fixed regulators > and link them to the 'nop-usb-xceiv' PHY by making them as "reset" > and "vcc" supplies. > > The RESET and Power will then be managed by the PHY driver. > > Signed-o

Re: [PATCH 17/30] ARM: OMAP3: 3630SDP: Adapt to ehci-omap changes

2013-02-05 Thread Felipe Balbi
On Mon, Jan 28, 2013 at 01:30:18PM +0200, Roger Quadros wrote: > Add 2 platform devices for 'nop-usb-xceiv'. These will be used > as PHYs for HS USB ports 1 and 2 so provide binding information > for them. > > Model RESET for HS USB Ports 1 and 2 as GPIO fixed regulators and > link them to the 2 P

Re: [PATCH 15/30] ARM: OMAP3: Beagle: Adapt to ehci-omap changes

2013-02-05 Thread Felipe Balbi
On Mon, Jan 28, 2013 at 01:30:16PM +0200, Roger Quadros wrote: > Add platform device for 'nop-usb-xceiv'. This will be used as a > PHY for HS USB Port 2, so provide binding information for it. > > Model RESET and Power for HS USB Port 2 as GPIO fixed regulators > and link them to the 'nop-usb-xcei

Re: [PATCH 19/30] ARM: OMAP: AM3517evm: Adapt to ehci-omap changes

2013-02-05 Thread Felipe Balbi
On Mon, Jan 28, 2013 at 01:30:20PM +0200, Roger Quadros wrote: > Add 2 platform devices for 'nop-usb-xceiv'. These will be used as a > PHY for HS USB Port 1 and 2, so provide binding information for them. > > Model RESET for HS USB Port 1 as GPIO fixed regulator and link it > to the 'nop-usb-xceiv

Re: [PATCH 21/30] ARM: OMAP3: cm-t3517: Adapt to ehci-omap changes

2013-02-05 Thread Felipe Balbi
On Mon, Jan 28, 2013 at 01:30:22PM +0200, Roger Quadros wrote: > Add 2 platform devices for 'nop-usb-xceiv'. These will be used > as PHYs for HS USB ports 1 and 2 so provide binding information > for them. > > Model RESET for HS USB Ports 1 and 2 as GPIO fixed regulators and > link them to the 2 P

Re: [PATCH 20/30] ARM: OMAP3: cm-t35: Adapt to ehci-omap changes

2013-02-05 Thread Felipe Balbi
On Mon, Jan 28, 2013 at 01:30:21PM +0200, Roger Quadros wrote: > Add 2 platform devices for 'nop-usb-xceiv'. These will be used > as PHYs for HS USB ports 1 and 2 so provide binding information > for them. > > Model RESET for HS USB Ports 1 and 2 as GPIO fixed regulators and > link them to the 2 P

Re: [PATCH 22/30] ARM: OMAP: devkit8000: Adapt to ehci-omap changes

2013-02-05 Thread Felipe Balbi
On Mon, Jan 28, 2013 at 01:30:23PM +0200, Roger Quadros wrote: > Add platform device for 'nop-usb-xceiv'. This will be used as a > PHY for HS USB Port 1, so provide binding information for it. > > Signed-off-by: Roger Quadros Acked-by: Felipe Balbi -- balbi signature.asc Description: Digita

Re: [PATCH 23/30] ARM: OMAP3: igep0020: Adapt to ehci-omap changes

2013-02-05 Thread Felipe Balbi
On Mon, Jan 28, 2013 at 01:30:24PM +0200, Roger Quadros wrote: > Add 2 platform devices for 'nop-usb-xceiv'. These will be used > as PHYs for HS USB ports 1 and 2 so provide binding information > for them. > > Model RESET for HS USB Ports 1 and 2 as GPIO fixed regulators and > link them to the 2 P

Re: [PATCH 24/30] ARM: OMAP3: omap3evm: Adapt to ehci-omap changes

2013-02-05 Thread Felipe Balbi
On Mon, Jan 28, 2013 at 01:30:25PM +0200, Roger Quadros wrote: > Add platform device for 'nop-usb-xceiv'. This will be used as a > PHY for HS USB Port 2, so provide binding information for it. > > Model RESET for HS USB Port 2 as GPIO fixed regulator and link > it to the 'nop-usb-xceiv' PHY. > >

Re: [PATCH 25/30] ARM: OMAP3: omap3pandora: Adapt to ehci-omap changes

2013-02-05 Thread Felipe Balbi
On Mon, Jan 28, 2013 at 01:30:26PM +0200, Roger Quadros wrote: > Add platform device for 'nop-usb-xceiv'. This will be used as a > PHY for HS USB Port 2, so provide binding information for it. > > Model RESET for HS USB Port 2 as GPIO fixed regulator and link > it to the 'nop-usb-xceiv' PHY. > >

Re: [PATCH 26/30] ARM: OMAP3: omap3stalker: Adapt to ehci-omap changes

2013-02-05 Thread Felipe Balbi
On Mon, Jan 28, 2013 at 01:30:27PM +0200, Roger Quadros wrote: > Add platform device for 'nop-usb-xceiv'. This will be used as a > PHY for HS USB Port 2, so provide binding information for it. > > Model RESET for HS USB Port 2 as GPIO fixed regulator and link > it to the 'nop-usb-xceiv' PHY. > >

how to specify an OMAP clock in device tree?

2013-02-05 Thread Roger Quadros
Hi Rajendra, On 02/04/2013 05:58 PM, Roger Quadros wrote: > Provide the RESET and Power regulators for the USB PHY, > the USB Host port mode and the PHY device. > > Also provide pin multiplexer information for the USB host > pins. > > Signed-off-by: Roger Quadros > --- > arch/arm/boot/dts/omap

Re: [PATCH 27/30] ARM: OMAP3: omap3touchbook: Adapt to ehci-omap changes

2013-02-05 Thread Felipe Balbi
On Mon, Jan 28, 2013 at 01:30:28PM +0200, Roger Quadros wrote: > Add 2 platform devices for 'nop-usb-xceiv'. These will be used as a > PHY for HS USB Ports 1 and 2, so provide binding information for them. > > Model RESET for HS USB Port 2 as GPIO fixed regulator and link it > to the respective 'n

Re: [PATCH 16/30] ARM: OMAP3: 3430SDP: Adapt to ehci-omap changes

2013-02-05 Thread Felipe Balbi
On Mon, Jan 28, 2013 at 01:30:17PM +0200, Roger Quadros wrote: > Add 2 platform devices for 'nop-usb-xceiv'. These will be used > as PHYs for HS USB ports 1 and 2 so provide binding information > for them. > > Model RESET for HS USB Ports 1 and 2 as GPIO fixed regulators and > link them to the 2 P

Re: [PATCH 18/30] ARM: OMAP: AM3517crane: Adapt to ehci-omap changes

2013-02-05 Thread Felipe Balbi
On Mon, Jan 28, 2013 at 01:30:19PM +0200, Roger Quadros wrote: > Add platform device for 'nop-usb-xceiv'. This will be used as a > PHY for HS USB Port 1, so provide binding information for it. > > Model RESET and Power for HS USB Port 1 as GPIO fixed regulators > and link them to the 'nop-usb-xcei

Re: [PATCH 29/30] ARM: OMAP: zoom: Adapt to ehci-omap changes

2013-02-05 Thread Felipe Balbi
On Mon, Jan 28, 2013 at 01:30:30PM +0200, Roger Quadros wrote: > Add platform device for 'nop-usb-xceiv'. This will be used as a > PHY for HS USB Port 2, so provide binding information for it. > > Model RESET for HS USB Port 2 as GPIO fixed regulator and link > it to the 'nop-usb-xceiv' PHY. > >

Re: [PATCH 30/30] ARM: OMAP: USB: Remove unused fields from struct usbhs_omap_platform_data

2013-02-05 Thread Felipe Balbi
On Mon, Jan 28, 2013 at 01:30:31PM +0200, Roger Quadros wrote: > All users have been adapted to the changes in ehci-omap. We can now > get rid of the unused fields from usbhs_omap_platform_data. > > Signed-off-by: Roger Quadros Acked-by: Felipe Balbi -- balbi signature.asc Description: Digi

Re: [PATCH 31/31] USB: ehci-omap: Select NOP USB transceiver driver

2013-02-05 Thread Felipe Balbi
On Mon, Feb 04, 2013 at 04:03:10PM -0500, Alan Stern wrote: > On Mon, 4 Feb 2013, Roger Quadros wrote: > > > In PHY mode we need to have the nop-usb-xceiv transceiver > > driver to operate, so select it in Kconfig. > > > > CC: Alan Stern > > Signed-off-by: Roger Quadros > > --- > > drivers/usb

Re: [PATCH 28/30] ARM: OMAP3: overo: Adapt to ehci-omap changes

2013-02-05 Thread Felipe Balbi
On Mon, Jan 28, 2013 at 01:30:29PM +0200, Roger Quadros wrote: > Add platform device for 'nop-usb-xceiv'. This will be used as a > PHY for HS USB Port 2, so provide binding information for it. > > Model RESET for HS USB Port 2 as GPIO fixed regulator and link > it to the 'nop-usb-xceiv' PHY. > >

Re: [PATCH 02/13] USB: phy: nop: Defer probe if device needs VCC/RESET

2013-02-05 Thread Roger Quadros
On 02/05/2013 11:09 AM, Felipe Balbi wrote: > On Tue, Feb 05, 2013 at 10:44:05AM +0200, Roger Quadros wrote: diff --git a/include/linux/usb/nop-usb-xceiv.h b/include/linux/usb/nop-usb-xceiv.h index 3265b61..148d351 100644 --- a/include/linux/usb/nop-usb-xceiv.h +++ b/inclu

Re: [PATCH 09/13] mfd: omap-usb-host: Add device tree support and binding information

2013-02-05 Thread Roger Quadros
On 02/05/2013 08:16 AM, kishon wrote: > On Monday 04 February 2013 09:28 PM, Roger Quadros wrote: >> Allows the OMAP HS USB host controller to be specified >> via device tree. >> >> CC: Samuel Ortiz >> Signed-off-by: Roger Quadros >> --- >> .../devicetree/bindings/mfd/omap-usb-host.txt |

Re: how to specify an OMAP clock in device tree?

2013-02-05 Thread Rajendra Nayak
On Tuesday 05 February 2013 03:04 PM, Roger Quadros wrote: Hi Rajendra, On 02/04/2013 05:58 PM, Roger Quadros wrote: Provide the RESET and Power regulators for the USB PHY, the USB Host port mode and the PHY device. Also provide pin multiplexer information for the USB host pins. Signed-off-by

Re: [PATCH v8 19/22] ARM: OMAP3: clock data: get rid of unused USB host clock aliases and dummies

2013-02-05 Thread Roger Quadros
Hi Paul, On 01/21/2013 05:03 PM, Paul Walmsley wrote: > Hi > > On Mon, 21 Jan 2013, Roger Quadros wrote: > >> On 01/18/2013 10:27 PM, Paul Walmsley wrote: >>> On Fri, 18 Jan 2013, Roger Quadros wrote: >>> We don't need multiple aliases for the OMAP USB host clocks and neither the dummy

Re: [PATCH 00/13] Device tree support for OMAP HS USB Host

2013-02-05 Thread Rajendra Nayak
On Monday 04 February 2013 09:28 PM, Roger Quadros wrote: This patchset adds device tree support for OMAP's High Speed USB Host subsystem. Board adaptation for Panda and Beagleboard is also provided. Tested on Beagleboard. Will only work with Panda if we provide a reference to the PHY clock B

Re: [PATCH v2 00/30] USB: omap-ehci: Move PHY management to PHY driver

2013-02-05 Thread Roger Quadros
Hi Tony & Greg, What's the best way to get these patches in? All patches have been acked by respective maintainers. If Tony can Ack the arch/arm/mach-omap2 stuff then should I send a pull request directly to Greg? or the other way round? Tony, fyi, these patches should not interfere with the d

Re: [PATCH 00/13] Device tree support for OMAP HS USB Host

2013-02-05 Thread Roger Quadros
On 02/05/2013 01:25 PM, Rajendra Nayak wrote: > On Monday 04 February 2013 09:28 PM, Roger Quadros wrote: >> This patchset adds device tree support for OMAP's High Speed USB Host >> subsystem. Board adaptation for Panda and Beagleboard is also provided. >> >> Tested on Beagleboard. >> >> Will only

Re: [PATCH 9/9] USB chipidea i.MX: use devm_usb_get_phy_by_phandle to get phy

2013-02-05 Thread Sergei Shtylyov
Hello. On 04-02-2013 17:24, Sascha Hauer wrote: Signed-off-by: Sascha Hauer --- drivers/usb/chipidea/ci13xxx_imx.c | 39 +--- 1 file changed, 18 insertions(+), 21 deletions(-) diff --git a/drivers/usb/chipidea/ci13xxx_imx.c b/drivers/usb/chipidea/ci13xx

Re: [PATCH 9/9] USB chipidea i.MX: use devm_usb_get_phy_by_phandle to get phy

2013-02-05 Thread Sascha Hauer
On Tue, Feb 05, 2013 at 03:45:12PM +0400, Sergei Shtylyov wrote: > Hello. > > On 04-02-2013 17:24, Sascha Hauer wrote: > > >Signed-off-by: Sascha Hauer > >--- > > drivers/usb/chipidea/ci13xxx_imx.c | 39 > > +--- > > 1 file changed, 18 insertions(+), 21 deleti

Re: [PATCH 09/13] mfd: omap-usb-host: Add device tree support and binding information

2013-02-05 Thread kishon
Hi, On Tuesday 05 February 2013 04:28 PM, Roger Quadros wrote: On 02/05/2013 08:16 AM, kishon wrote: On Monday 04 February 2013 09:28 PM, Roger Quadros wrote: Allows the OMAP HS USB host controller to be specified via device tree. CC: Samuel Ortiz Signed-off-by: Roger Quadros --- .../dev

Re: [PATCH 09/13] mfd: omap-usb-host: Add device tree support and binding information

2013-02-05 Thread Roger Quadros
On 02/05/2013 02:11 PM, kishon wrote: > Hi, > > On Tuesday 05 February 2013 04:28 PM, Roger Quadros wrote: >> On 02/05/2013 08:16 AM, kishon wrote: >>> On Monday 04 February 2013 09:28 PM, Roger Quadros wrote: Allows the OMAP HS USB host controller to be specified via device tree. >

Re: [PATCH 08/13] USB: ehci-omap: Add device tree support and binding information

2013-02-05 Thread Mark Rutland
On Mon, Feb 04, 2013 at 03:58:55PM +, Roger Quadros wrote: > Allows the OMAP EHCI controller to be specified via device tree. > > Signed-off-by: Roger Quadros > --- > .../devicetree/bindings/usb/omap-ehci.txt | 34 ++ > drivers/usb/host/ehci-omap.c

[PATCH v5 0/2] Adding USB 3.0 DRD-phy support for exynos5250

2013-02-05 Thread Vivek Gautam
Based on 'usb-next' Changes from v4: - Modifying function names and driver names to follow a common naming convention. "usb2phy" for samsung-usb2phy driver "usb3phy" for samsung-usb3phy driver - Changing file names "samsung-usb2.c" to "samsung-usb2phy.c" and, "samsung-usb3.

[PATCH v5 1/2] usb: phy: samsung: Common out the generic stuff

2013-02-05 Thread Vivek Gautam
Moving register and structure definitions to header file, and keeping the generic functions to be used across multiple PHYs in common phy helper driver under SAMSUNG_USBPHY, and moving USB 2.0 PHY driver under SAMSUNG_USB2PHY. Signed-off-by: Vivek Gautam --- drivers/usb/phy/Kconfig |

[PATCH v5 2/2] usb: phy: samsung: Add PHY support for USB 3.0 controller

2013-02-05 Thread Vivek Gautam
Adding PHY driver support for USB 3.0 controller for Samsung's SoCs. Signed-off-by: Vivek Gautam --- drivers/usb/phy/Kconfig |8 + drivers/usb/phy/Makefile |1 + drivers/usb/phy/samsung-usb3phy.c | 349 + drivers/usb/phy/samsung-usb

Re: [PATCH 08/13] USB: ehci-omap: Add device tree support and binding information

2013-02-05 Thread Roger Quadros
On 02/05/2013 02:33 PM, Mark Rutland wrote: > On Mon, Feb 04, 2013 at 03:58:55PM +, Roger Quadros wrote: >> Allows the OMAP EHCI controller to be specified via device tree. >> >> Signed-off-by: Roger Quadros >> --- >> .../devicetree/bindings/usb/omap-ehci.txt | 34 +

[PATCH v3 0/2] ARM: Exynos5250: Enabling samsung usb phy

2013-02-05 Thread Vivek Gautam
Based on for-next of 'linux-samsung' tree. Aligned with following patches for separate PHY drivers for USB 2.0 and USB 3.0 for Samsung SoCs. [PATCH v5 1/2] usb: phy: samsung: Common out the generic stuff [PATCH v5 2/2] usb: phy: samsung: Add PHY support for USB 3.0 controller Changes from v2: -

[PATCH v3 1/2] ARM: Exynos5250: Enabling samsung-usb2phy driver

2013-02-05 Thread Vivek Gautam
Adding device node for Samsung USB 2.0 PHY controller driver on Exynos5250 along with the necessary device data to be parsed. Signed-off-by: Vivek Gautam --- arch/arm/boot/dts/exynos5250.dtsi | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/arch/arm/boot/dts/

[PATCH v3 2/2] ARM: Exynos5250: Enabling samsung-usb3phy driver

2013-02-05 Thread Vivek Gautam
Adding device node for Samsung USB 3.0 PHY controller driver on Exynos5250 along with the necessary device data to be parsed. Signed-off-by: Vivek Gautam --- arch/arm/boot/dts/exynos5250.dtsi | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/arch/arm/boot/dts/e

[PATCH RFC] usb: dwc3: Set GCTL.PrtCapDir based on selected mode.

2013-02-05 Thread Vivek Gautam
Now that machines may select the mode of working of DWC3, we can set the Port capability direction based on selected mode. Signed-off-by: Vivek Gautam --- drivers/usb/dwc3/core.c | 11 --- 1 files changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/usb/dwc3/core.c b/drivers/

usbip-utils USBIP_VERSION

2013-02-05 Thread Alexander Zubkov
Hi. I was trying to bring together Linux & Windows usbip and faced a problem with currently published on SourceForge windows driver and tools. usbip.exe -l is saying: usbip err: ... (usbip_recv_op_common) recv op_common, -1 ... Debugging and tcpdumping showed that problem lies in that Windows

Re: how to specify an OMAP clock in device tree?

2013-02-05 Thread Roger Quadros
On 02/05/2013 01:15 PM, Rajendra Nayak wrote: > On Tuesday 05 February 2013 03:04 PM, Roger Quadros wrote: >> Hi Rajendra, >> >> On 02/04/2013 05:58 PM, Roger Quadros wrote: >>> Provide the RESET and Power regulators for the USB PHY, >>> the USB Host port mode and the PHY device. >>> >>> Also provi

Re: how to specify an OMAP clock in device tree?

2013-02-05 Thread Rajendra Nayak
On Tuesday 05 February 2013 07:16 PM, Roger Quadros wrote: Fixing the device name doesn't really solve the problem. Not all OMAP boards will use the same clock for the external device. Are you saying different OMAP boards will use different Internal clocks? Or different OMAP boards will use a s

Re: how to specify an OMAP clock in device tree?

2013-02-05 Thread Roger Quadros
On 02/05/2013 04:13 PM, Rajendra Nayak wrote: > On Tuesday 05 February 2013 07:16 PM, Roger Quadros wrote: >> Fixing the device name doesn't really solve the problem. >> Not all OMAP boards will use the same clock for the external device. > > Are you saying different OMAP boards will use different

Re: [PATCH 09/13] mfd: omap-usb-host: Add device tree support and binding information

2013-02-05 Thread Mark Rutland
Hi, I have a few comments on the binding and the way it's parsed. On Mon, Feb 04, 2013 at 03:58:56PM +, Roger Quadros wrote: > Allows the OMAP HS USB host controller to be specified > via device tree. > > CC: Samuel Ortiz > Signed-off-by: Roger Quadros > --- > .../devicetree/bindings/mfd/

Re: how to specify an OMAP clock in device tree?

2013-02-05 Thread Rajendra Nayak
On Tuesday 05 February 2013 07:48 PM, Roger Quadros wrote: On 02/05/2013 04:13 PM, Rajendra Nayak wrote: On Tuesday 05 February 2013 07:16 PM, Roger Quadros wrote: Fixing the device name doesn't really solve the problem. Not all OMAP boards will use the same clock for the external device. Are

Re: how to specify an OMAP clock in device tree?

2013-02-05 Thread Roger Quadros
On 02/05/2013 04:21 PM, Rajendra Nayak wrote: > On Tuesday 05 February 2013 07:48 PM, Roger Quadros wrote: >> On 02/05/2013 04:13 PM, Rajendra Nayak wrote: >>> On Tuesday 05 February 2013 07:16 PM, Roger Quadros wrote: Fixing the device name doesn't really solve the problem. Not all OMAP

Re: how to specify an OMAP clock in device tree?

2013-02-05 Thread Rajendra Nayak
On Tuesday 05 February 2013 07:59 PM, Roger Quadros wrote: On 02/05/2013 04:21 PM, Rajendra Nayak wrote: On Tuesday 05 February 2013 07:48 PM, Roger Quadros wrote: On 02/05/2013 04:13 PM, Rajendra Nayak wrote: On Tuesday 05 February 2013 07:16 PM, Roger Quadros wrote: Fixing the device name d

Re: [PATCH 09/13] mfd: omap-usb-host: Add device tree support and binding information

2013-02-05 Thread Roger Quadros
On 02/05/2013 04:20 PM, Mark Rutland wrote: > Hi, > > I have a few comments on the binding and the way it's parsed. > > On Mon, Feb 04, 2013 at 03:58:56PM +, Roger Quadros wrote: >> Allows the OMAP HS USB host controller to be specified >> via device tree. >> >> CC: Samuel Ortiz >> Signed-of

Re: [PATCH 1/2] usb: phy: Add USB host phy support on Exyno4412

2013-02-05 Thread Praveen Paneri
Hi, On Tue, Feb 5, 2013 at 6:55 AM, Dongjin Kim wrote: > This patch adds host phy support for Samsung's Exynos4412 SoC to > samsung-usbphy driver. This patch is created upon > "http://git.kernel.org/?p=linux/kernel/git/balbi/usb.git;a=commit;h=2564b526b8cf01e6c36285edfd40a438e683c2b8"; > > Cc: P

Re: how to specify an OMAP clock in device tree?

2013-02-05 Thread Roger Quadros
On 02/05/2013 04:36 PM, Rajendra Nayak wrote: > On Tuesday 05 February 2013 07:59 PM, Roger Quadros wrote: >> On 02/05/2013 04:21 PM, Rajendra Nayak wrote: >>> On Tuesday 05 February 2013 07:48 PM, Roger Quadros wrote: On 02/05/2013 04:13 PM, Rajendra Nayak wrote: > On Tuesday 05 February

[GIT PULL] ARM part of USB patches

2013-02-05 Thread kishon
Hi Tony, As discussed, I'm sending a pull request for the arch/arm part of my USB patches. These patches are necessary to get MUSB functional in both dt and non-dt boot. Also added dt data for dwc3 present in OMAP. This patch series *depends* on some of the patches which are merged in usb-next

Re: [GIT PULL] ARM part of USB patches

2013-02-05 Thread kishon
Hi Tony, Greg, On Tuesday 05 February 2013 08:54 PM, kishon wrote: Hi Tony, As discussed, I'm sending a pull request for the arch/arm part of my USB patches. These patches are necessary to get MUSB functional in both dt and non-dt boot. Also added dt data for dwc3 present in OMAP. This patch se

Re: [REVERT][v3.x.y] EHCI: Update qTD next pointer in QH overlay region during unlink

2013-02-05 Thread Joseph Salisbury
On 02/04/2013 05:04 PM, Alan Stern wrote: On Fri, 1 Feb 2013, Joseph Salisbury wrote: Hi Alan, There is a tar file[0] attached to the bug report[1]. The tar file contains a few examples of failed and successful recording attempts while collecting usbmon traces. There is a readme.txt file ava

Re: [PATCH 09/13] mfd: omap-usb-host: Add device tree support and binding information

2013-02-05 Thread Mark Rutland
[...] > >> + > >> +- single_ulpi_bypass: Must be present if the controller contains a single > >> + ULPI bypass control bit. e.g. OMAP3 silicon <= ES2.1 > > > > Again it would be nicer to have '-' rather than '_' here. It might be worth > > prefixing this "ti,". > > Is prefixing with "ti" reall

Re: [PATCH 12/15] USB: gadget/freescale: disable non-multiplatform drivers

2013-02-05 Thread Arnd Bergmann
On Monday 21 January 2013, Greg Kroah-Hartman wrote: > On Mon, Jan 21, 2013 at 08:41:38PM +0200, Felipe Balbi wrote: > > Hi, > > > > On Mon, Jan 21, 2013 at 05:16:05PM +, Arnd Bergmann wrote: > > > Both the fsl_mxc gadget and the imx_udc gadget drivers fail to build > > > without the mach/hard

Re: Linux USB file storage gadget with new UDC

2013-02-05 Thread Alan Stern
On Tue, 5 Feb 2013, victor yeo wrote: > Thanks, i added in UDC driver to call bulk_in_complete for every > request over a bulk in ep, now the gadget driver is able to process > the SCSI Inquiry command. When it comes to SCSI Read Format Capacities > command, the gadget driver gives attention condi

Re: [REVERT][v3.x.y] EHCI: Update qTD next pointer in QH overlay region during unlink

2013-02-05 Thread Alan Stern
On Tue, 5 Feb 2013, Joseph Salisbury wrote: > > I have replied to the original report at bugs.launchpad.net with a > > diagnostic patch. Maybe it will help indicate what's going wrong. > > > > Alan Stern > > > Thanks so much for the assistance, Alan. I'll work with the bug > reporter to build a

Re: [PATCH v2 00/30] USB: omap-ehci: Move PHY management to PHY driver

2013-02-05 Thread Greg KH
On Tue, Feb 05, 2013 at 01:28:51PM +0200, Roger Quadros wrote: > Hi Tony & Greg, > > What's the best way to get these patches in? > > All patches have been acked by respective maintainers. > > If Tony can Ack the arch/arm/mach-omap2 stuff then should I send a > pull request directly to Greg? or

Re: [PATCH 12/15] USB: gadget/freescale: disable non-multiplatform drivers

2013-02-05 Thread Greg Kroah-Hartman
On Tue, Feb 05, 2013 at 04:27:18PM +, Arnd Bergmann wrote: > On Monday 21 January 2013, Greg Kroah-Hartman wrote: > > On Mon, Jan 21, 2013 at 08:41:38PM +0200, Felipe Balbi wrote: > > > Hi, > > > > > > On Mon, Jan 21, 2013 at 05:16:05PM +, Arnd Bergmann wrote: > > > > Both the fsl_mxc gadg

Re: [PATCH v2 00/30] USB: omap-ehci: Move PHY management to PHY driver

2013-02-05 Thread Tony Lindgren
* Greg KH [130205 09:00]: > On Tue, Feb 05, 2013 at 01:28:51PM +0200, Roger Quadros wrote: > > Hi Tony & Greg, > > > > What's the best way to get these patches in? > > > > All patches have been acked by respective maintainers. > > > > If Tony can Ack the arch/arm/mach-omap2 stuff then should I

Re: [GIT PULL] ARM part of USB patches

2013-02-05 Thread gre...@linuxfoundation.org
On Tue, Feb 05, 2013 at 08:56:13PM +0530, kishon wrote: > Hi Tony, Greg, > > On Tuesday 05 February 2013 08:54 PM, kishon wrote: > >Hi Tony, > > > >As discussed, I'm sending a pull request for the arch/arm part of my USB > >patches. These patches are necessary to get MUSB functional in both dt > >

[GIT PATCH] USB fixes for 3.8-rc6

2013-02-05 Thread Greg KH
The following changes since commit 949db153b6466c6f7cad5a427ecea94985927311: Linux 3.8-rc5 (2013-01-25 11:57:28 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/ tags/usb-3.8-rc6 for you to fetch changes up to 200e0d994d9d1919b28c87

Re: [GIT PULL] ARM part of USB patches

2013-02-05 Thread Tony Lindgren
* gre...@linuxfoundation.org [130205 09:28]: > On Tue, Feb 05, 2013 at 08:56:13PM +0530, kishon wrote: > > Hi Tony, Greg, > > > > On Tuesday 05 February 2013 08:54 PM, kishon wrote: > > >Hi Tony, > > > > > >As discussed, I'm sending a pull request for the arch/arm part of my USB > > >patches. The

Re: [PATCH 1/2] usb: phy: Add USB host phy support on Exyno4412

2013-02-05 Thread Dongjin Kim
Hello Praveen, Thank you for reviewing. I was also considered to use TYPE_4X12, but in some other thread some people prefer to use 4412 instead of 4X12 because no 4212 based hardware yet. :) Anyway, TYPE_4X12 is also fine to me. And as you pointed out about PHY0, while testing my patch with my ha

Re: [GIT PULL] ARM part of USB patches

2013-02-05 Thread gre...@linuxfoundation.org
On Tue, Feb 05, 2013 at 10:19:47AM -0800, Tony Lindgren wrote: > * gre...@linuxfoundation.org [130205 09:28]: > > On Tue, Feb 05, 2013 at 08:56:13PM +0530, kishon wrote: > > > Hi Tony, Greg, > > > > > > On Tuesday 05 February 2013 08:54 PM, kishon wrote: > > > >Hi Tony, > > > > > > > >As discusse

[-next-20130204] usb/hcd: irq 18: nobody cared

2013-02-05 Thread Peter Hurley
With -next-20130204: [ 33.855570] irq 18: nobody cared (try booting with the "irqpoll" option) [ 33.855580] Pid: 0, comm: swapper/4 Not tainted 3.8.0-next-20130204-xeon #20130204 [ 33.855582] Call Trace: [ 33.855585][] __report_bad_irq+0x36/0xe0 [ 33.855600] [] note_interrupt+0x1aa

Re: [-next-20130204] usb/hcd: irq 18: nobody cared

2013-02-05 Thread Alan Stern
On Tue, 5 Feb 2013, Peter Hurley wrote: > With -next-20130204: > > [ 33.855570] irq 18: nobody cared (try booting with the "irqpoll" option) > [ 33.855580] Pid: 0, comm: swapper/4 Not tainted 3.8.0-next-20130204-xeon > #20130204 > [ 33.855582] Call Trace: > [ 33.855585][] __report_ba

  1   2   >