[PATCH] usb: phy: fix Kconfig warning

2013-01-28 Thread Felipe Balbi
Recent commits introduced the following Kconfig warning: warning: (USB_MUSB_HDRC && OMAP_USB3) selects \ OMAP_CONTROL_USB which has unmet direct \ dependencies (USB_SUPPORT && ARCH_OMAP2PLUS) This patch just fixes it, by removing the unnecessary OMAP dependency. Signed-off-by: Fe

Re: [PATCH, resubmit] ax88179_178a: ASIX AX88179_178A USB 3.0/2.0 to gigabit ethernet adapter driver

2013-01-28 Thread Bjørn Mork
Hello Michael, Michael Leun writes: > I would vote to not accept that driver for mainline as long as this > issues are not fixed. > > The vendor should not be able to claim "hooray, hooray, great device, > we even have an driver in linux main line" when it is actually such an > useless crap. W

Re: [PATCH 2/2] usb-uas: update MAINTAINERS entry

2013-01-28 Thread Gerd Hoffmann
Hi, >> Problem is that uas is pretty much the only device using streams, >> so uas will be the one who triggers any stream bugs in xhci. >> I have no idea how solid xhci streams support is at the moment. > > The xHCI streams support isn't well tested, because the UAS devices I > had were so bug

Page allocation failure on v3.8-rc5

2013-01-28 Thread Felipe Balbi
Hi, The following page allocation failure triggers sometimes when I plug my memory card reader on a USB port. [850845.928795] usb 1-4: new high-speed USB device number 48 using ehci-pci [850846.300702] usb 1-4: New USB device found, idVendor=0bda, idProduct=0119 [850846.300707] usb 1-4: New USB

[PATCH v2 corrected] usb/gadget: nokia: use function framework for ACM

2013-01-28 Thread Andrzej Pietrasiewicz
From: Sebastian Andrzej Siewior This patch converts the nokia gadget to make use of the function framework to request the ACM function. The "old" include interface for acm is now removed since nokia was the last user of it (for ACM). Signed-off-by: Sebastian Andrzej Siewior [Andrzej Pietrasie

RE: [PATCH 1/3] usb: otg: nop: add dt support

2013-01-28 Thread Mohammed, Afzal
Hi Michael, On Mon, Jan 28, 2013 at 03:10:05, Michael Grzeschik wrote: > On Thu, Sep 27, 2012 at 11:15:05AM +0530, Afzal Mohammed wrote: > > From: "B, Ravi" > > > > Added device tree support for nop transceiver driver and updated the > > Documentation with device tree binding information for am

Re: UAS questions

2013-01-28 Thread Gerd Hoffmann
On 01/27/13 13:54, Vlad Silman wrote: > Hello, > > I have a few questions regarding Linux UAS host-side and device-side drivers. > I've seen that Linux UAS host driver supports the task management > commands as defined by T10 UAS spec, such as ABORT TASK and LOGICAL > UNIT RESET. > I'm trying to w

[PATCH v4 1/2] usb: phy: samsung: Common out the generic stuff

2013-01-28 Thread Vivek Gautam
Moving register and structure definitions to header file, and keeping the generic functions to be used across multiple PHYs in common file "samsung-usbphy.c". Also renaming the usb 2.0 phy driver to "samsung-usb2.c" Signed-off-by: Vivek Gautam --- Changes from v3: - Using separate config SAMSUN

[PATCH v4 2/2] usb: phy: samsung: Add PHY support for USB 3.0 controller

2013-01-28 Thread Vivek Gautam
Adding PHY driver support for USB 3.0 controller for Samsung's SoCs. Signed-off-by: Vivek Gautam --- Changes from v3: - Making SAMSUNG_USB3PHY dependent on SAMSUNG_USBPHY. - Adding USB_DWC3 to dependencies of SAMSUNG_USB2PHY since dwc3 controller also looks for USB2 type PHY. drivers/usb/

[PATCH 02/30] usb: phy: nop: use devm_kzalloc()

2013-01-28 Thread Roger Quadros
Use resource managed kzalloc. Signed-off-by: Roger Quadros --- drivers/usb/otg/nop-usb-xceiv.c | 16 1 files changed, 4 insertions(+), 12 deletions(-) diff --git a/drivers/usb/otg/nop-usb-xceiv.c b/drivers/usb/otg/nop-usb-xceiv.c index a3ce24b..7ffb0c8 100644 --- a/drivers/us

[PATCH v2 00/30] USB: omap-ehci: Move PHY management to PHY driver

2013-01-28 Thread Roger Quadros
Hi, The OMAP's High Speed Host controller can interface to ULPI/UTMI PHYs transparently i.e. whithout requiring the device drivers to access the PHY. However, the OS must ensure that the PHY has the necessary resources (power/clock/reset) enabled before it is used. Till now, the omap-ehci driver

[PATCH v2 03/30] usb: phy: nop: Manage PHY clock

2013-01-28 Thread Roger Quadros
If the PHY has a clock associated to it then manage the clock. We just enable the clock in .init() and disable it in .shutdown(). Add clk_rate parameter in platform data and configure the clock rate during probe if supplied. Signed-off-by: Roger Quadros --- drivers/usb/otg/nop-usb-xceiv.c |

[PATCH v2 13/30] ARM: OMAP2+: omap4panda: Provide USB Host's PHY platform data

2013-01-28 Thread Roger Quadros
Add platform device and data for 'nop-usb-xceiv'. This will be used as PHY for HS USB port 1, so provide binding information for it. Get rid of managing the PHY clock as it will be done by the PHY driver. For that to work we create a clock alias that links the PHY clock name to the PHY device name

[PATCH 21/30] ARM: OMAP3: cm-t3517: Adapt to ehci-omap changes

2013-01-28 Thread Roger Quadros
Add 2 platform devices for 'nop-usb-xceiv'. These will be used as PHYs for HS USB ports 1 and 2 so provide binding information for them. Model RESET for HS USB Ports 1 and 2 as GPIO fixed regulators and link them to the 2 PHYs we just created. Signed-off-by: Roger Quadros --- arch/arm/mach-omap

[PATCH 27/30] ARM: OMAP3: omap3touchbook: Adapt to ehci-omap changes

2013-01-28 Thread Roger Quadros
Add 2 platform devices for 'nop-usb-xceiv'. These will be used as a PHY for HS USB Ports 1 and 2, so provide binding information for them. Model RESET for HS USB Port 2 as GPIO fixed regulator and link it to the respective 'nop-usb-xceiv' PHY. Signed-off-by: Roger Quadros --- arch/arm/mach-omap

[PATCH 29/30] ARM: OMAP: zoom: Adapt to ehci-omap changes

2013-01-28 Thread Roger Quadros
Add platform device for 'nop-usb-xceiv'. This will be used as a PHY for HS USB Port 2, so provide binding information for it. Model RESET for HS USB Port 2 as GPIO fixed regulator and link it to the 'nop-usb-xceiv' PHY. Signed-off-by: Roger Quadros --- arch/arm/mach-omap2/board-zoom.c | 56 ++

[PATCH 20/30] ARM: OMAP3: cm-t35: Adapt to ehci-omap changes

2013-01-28 Thread Roger Quadros
Add 2 platform devices for 'nop-usb-xceiv'. These will be used as PHYs for HS USB ports 1 and 2 so provide binding information for them. Model RESET for HS USB Ports 1 and 2 as GPIO fixed regulators and link them to the 2 PHYs we just created. Signed-off-by: Roger Quadros --- arch/arm/mach-omap

[PATCH 22/30] ARM: OMAP: devkit8000: Adapt to ehci-omap changes

2013-01-28 Thread Roger Quadros
Add platform device for 'nop-usb-xceiv'. This will be used as a PHY for HS USB Port 1, so provide binding information for it. Signed-off-by: Roger Quadros --- arch/arm/mach-omap2/board-devkit8000.c | 20 1 files changed, 12 insertions(+), 8 deletions(-) diff --git a/arch/

[PATCH 23/30] ARM: OMAP3: igep0020: Adapt to ehci-omap changes

2013-01-28 Thread Roger Quadros
Add 2 platform devices for 'nop-usb-xceiv'. These will be used as PHYs for HS USB ports 1 and 2 so provide binding information for them. Model RESET for HS USB Ports 1 and 2 as GPIO fixed regulators and link them to the 2 PHYs we just created. Signed-off-by: Roger Quadros --- arch/arm/mach-omap

[PATCH 26/30] ARM: OMAP3: omap3stalker: Adapt to ehci-omap changes

2013-01-28 Thread Roger Quadros
Add platform device for 'nop-usb-xceiv'. This will be used as a PHY for HS USB Port 2, so provide binding information for it. Model RESET for HS USB Port 2 as GPIO fixed regulator and link it to the 'nop-usb-xceiv' PHY. Signed-off-by: Roger Quadros --- arch/arm/mach-omap2/board-omap3stalker.c |

[PATCH 25/30] ARM: OMAP3: omap3pandora: Adapt to ehci-omap changes

2013-01-28 Thread Roger Quadros
Add platform device for 'nop-usb-xceiv'. This will be used as a PHY for HS USB Port 2, so provide binding information for it. Model RESET for HS USB Port 2 as GPIO fixed regulator and link it to the 'nop-usb-xceiv' PHY. Signed-off-by: Roger Quadros --- arch/arm/mach-omap2/board-omap3pandora.c |

[PATCH 30/30] ARM: OMAP: USB: Remove unused fields from struct usbhs_omap_platform_data

2013-01-28 Thread Roger Quadros
All users have been adapted to the changes in ehci-omap. We can now get rid of the unused fields from usbhs_omap_platform_data. Signed-off-by: Roger Quadros --- include/linux/platform_data/usb-omap.h |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/include/linux/platfor

[PATCH 28/30] ARM: OMAP3: overo: Adapt to ehci-omap changes

2013-01-28 Thread Roger Quadros
Add platform device for 'nop-usb-xceiv'. This will be used as a PHY for HS USB Port 2, so provide binding information for it. Model RESET for HS USB Port 2 as GPIO fixed regulator and link it to the 'nop-usb-xceiv' PHY. Signed-off-by: Roger Quadros --- arch/arm/mach-omap2/board-overo.c | 55 +

[PATCH 24/30] ARM: OMAP3: omap3evm: Adapt to ehci-omap changes

2013-01-28 Thread Roger Quadros
Add platform device for 'nop-usb-xceiv'. This will be used as a PHY for HS USB Port 2, so provide binding information for it. Model RESET for HS USB Port 2 as GPIO fixed regulator and link it to the 'nop-usb-xceiv' PHY. Signed-off-by: Roger Quadros --- arch/arm/mach-omap2/board-omap3evm.c | 6

[PATCH 19/30] ARM: OMAP: AM3517evm: Adapt to ehci-omap changes

2013-01-28 Thread Roger Quadros
Add 2 platform devices for 'nop-usb-xceiv'. These will be used as a PHY for HS USB Port 1 and 2, so provide binding information for them. Model RESET for HS USB Port 1 as GPIO fixed regulator and link it to the 'nop-usb-xceiv' PHY on port 1. Signed-off-by: Roger Quadros --- arch/arm/mach-omap2/

[PATCH 15/30] ARM: OMAP3: Beagle: Adapt to ehci-omap changes

2013-01-28 Thread Roger Quadros
Add platform device for 'nop-usb-xceiv'. This will be used as a PHY for HS USB Port 2, so provide binding information for it. Model RESET and Power for HS USB Port 2 as GPIO fixed regulators and link them to the 'nop-usb-xceiv' PHY. Signed-off-by: Roger Quadros --- arch/arm/mach-omap2/board-oma

[PATCH v2 10/30] USB: ehci-omap: Use PHY APIs to get the PHY device and put it out of suspend

2013-01-28 Thread Roger Quadros
For each port that is in PHY mode we obtain a PHY device using the USB PHY library and put it out of suspend. It is upto platform code to associate the PHY to the controller's port and it is upto the PHY driver to manage the PHY's resources. Signed-off-by: Roger Quadros --- drivers/usb/host/ehc

[PATCH 18/30] ARM: OMAP: AM3517crane: Adapt to ehci-omap changes

2013-01-28 Thread Roger Quadros
Add platform device for 'nop-usb-xceiv'. This will be used as a PHY for HS USB Port 1, so provide binding information for it. Model RESET and Power for HS USB Port 1 as GPIO fixed regulators and link them to the 'nop-usb-xceiv' PHY. Signed-off-by: Roger Quadros --- arch/arm/mach-omap2/board-am3

[PATCH 17/30] ARM: OMAP3: 3630SDP: Adapt to ehci-omap changes

2013-01-28 Thread Roger Quadros
Add 2 platform devices for 'nop-usb-xceiv'. These will be used as PHYs for HS USB ports 1 and 2 so provide binding information for them. Model RESET for HS USB Ports 1 and 2 as GPIO fixed regulators and link them to the 2 PHYs we just created. Signed-off-by: Roger Quadros --- arch/arm/mach-omap

[PATCH 16/30] ARM: OMAP3: 3430SDP: Adapt to ehci-omap changes

2013-01-28 Thread Roger Quadros
Add 2 platform devices for 'nop-usb-xceiv'. These will be used as PHYs for HS USB ports 1 and 2 so provide binding information for them. Model RESET for HS USB Ports 1 and 2 as GPIO fixed regulators and link them to the 2 PHYs we just created. Signed-off-by: Roger Quadros --- arch/arm/mach-omap

[PATCH v2 14/30] ARM: OMAP2+: omap4panda: Adapt to ehci-omap changes

2013-01-28 Thread Roger Quadros
Model RESET and Power for HS USB Port 1 as GPIO fixed regulators and link them to the 'nop-usb-xceiv' PHY by making them as "reset" and "vcc" supplies. The RESET and Power will then be managed by the PHY driver. Signed-off-by: Roger Quadros --- arch/arm/mach-omap2/board-omap4panda.c | 93

[PATCH 0/4] usb: dwc3/xhci: Enable runtime power management

2013-01-28 Thread Vivek Gautam
This patch-series enables runtime power management on xhci-plat, dwc3-core, dwc3-exynos as well as on samsung-usb3 type PHY. This allows usb 3.0 host ports to be power managed at runtime. We also turn off the PHY ref_clk PLL, which supplies reference clock to USB3 type phy, when ports are not in us

[PATCH v2 12/30] usb: ehci-omap: Remove PHY regulator handling code

2013-01-28 Thread Roger Quadros
PHY regulator handling must be done in the PHY driver Signed-off-by: Roger Quadros --- drivers/usb/host/ehci-omap.c | 34 -- 1 files changed, 0 insertions(+), 34 deletions(-) diff --git a/drivers/usb/host/ehci-omap.c b/drivers/usb/host/ehci-omap.c index 3c63619

[PATCH 1/4] usb: xhci: Enable runtime pm in xhci-plat

2013-01-28 Thread Vivek Gautam
By enabling runtime pm in this driver is allows users of xhci-plat to enter into runtime pm. This is not full runtime pm support (AKA xhci-plat doesn't actually power anything off when in runtime suspend mode) but just basic enablement. Signed-off-by: Vivek Gautam Signed-off-by: Doug Anderson -

[PATCH 09/30] USB: ehci-omap: Use devm_request_and_ioremap()

2013-01-28 Thread Roger Quadros
Make use of devm_request_and_ioremap() and correct comment. Signed-off-by: Roger Quadros --- drivers/usb/host/ehci-omap.c | 19 +-- 1 files changed, 5 insertions(+), 14 deletions(-) diff --git a/drivers/usb/host/ehci-omap.c b/drivers/usb/host/ehci-omap.c index 30fc482..fd2f545

[PATCH 2/4] USB: dwc3: Adjust runtime pm the dwc3 driver to allow runtime suspend

2013-01-28 Thread Vivek Gautam
The current code in the dwc3 probe effectively disables runtime pm from ever working because it calls a get() that was never put() until device removal. Change the runtime pm code to match the standard formula and allow runtime pm to function. Note that this doesn't enable full runtime pm on the

[PATCH 08/30] mfd: omap-usb-host: Remove PHY reset handling code

2013-01-28 Thread Roger Quadros
PHY reset GPIO handling will be done in the PHY driver Signed-off-by: Roger Quadros Acked-by: Samuel Ortiz --- drivers/mfd/omap-usb-host.c | 47 --- 1 files changed, 0 insertions(+), 47 deletions(-) diff --git a/drivers/mfd/omap-usb-host.c b/drivers/mf

[PATCH 07/30] mfd: omap-usb-host: update nports in platform_data

2013-01-28 Thread Roger Quadros
EHCI driver would need to know the number of ports available on the platform. We set the nports parameter of platform_data based on IP version if it was not already provided. Signed-off-by: Roger Quadros Acked-by: Samuel Ortiz --- drivers/mfd/omap-usb-host.c |1 + 1 files changed, 1 inserti

[PATCH v2 05/30] usb: phy: nop: Handle RESET for the PHY

2013-01-28 Thread Roger Quadros
We expect the RESET line to be modeled as a regulator with supply name "reset". The regulator should be modeled such that enabling the regulator brings the PHY device out of RESET and disabling the regulator holds the device in RESET. They PHY will be held in RESET in .shutdown() and brought out o

[PATCH 3/4] usb: dwc3: exynos: Enable runtime power management

2013-01-28 Thread Vivek Gautam
Enabling runtime power management on dwc3-exynos to save power and allow its PHY's power to be managed at runtime. Signed-off-by: Vivek Gautam --- drivers/usb/dwc3/dwc3-exynos.c | 47 1 files changed, 47 insertions(+), 0 deletions(-) diff --git a/drive

[PATCH v2 04/30] usb: phy: nop: Handle power supply regulator for the PHY

2013-01-28 Thread Roger Quadros
We use "vcc" as the supply name for the PHY's power supply. The power supply will be enabled during .init() and disabled during .shutdown() Signed-off-by: Roger Quadros --- drivers/usb/otg/nop-usb-xceiv.c | 18 ++ 1 files changed, 18 insertions(+), 0 deletions(-) diff --git a/

[PATCH 06/30] usb: phy: nop: use new PHY API to register PHY

2013-01-28 Thread Roger Quadros
We would need to support multiple PHYs of the same type so use the new PHY API usb_add_phy_dev() to register the PHY. Signed-off-by: Roger Quadros --- drivers/usb/otg/nop-usb-xceiv.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/usb/otg/nop-usb-xceiv.c b/driv

[PATCH 4/4] usb: phy: samsung: Enable runtime power management on samsung-usb3

2013-01-28 Thread Vivek Gautam
Enabling runtime power management support on samsung-usb3 phy and further adding support to turn off the PHY ref_clk PLL. It thereby requires PHY ref_clk to be switched between internal core clock and external PLL clock. Signed-off-by: Vivek Gautam --- drivers/usb/phy/samsung-usb3.c | 107 +++

[PATCH 01/30] USB: EHCI: split ehci-omap out to a separate driver

2013-01-28 Thread Roger Quadros
From: Alan Stern This patch (as1645) converts ehci-omap over to the new "ehci-hcd is a library" approach, so that it can coexist peacefully with other EHCI platform drivers and can make use of the private area allocated at the end of struct ehci_hcd. Signed-off-by: Alan Stern --- drivers/usb/h

[PATCH v2 11/30] usb: ehci-omap: Remove PHY reset handling code

2013-01-28 Thread Roger Quadros
Reset GPIO handling for the PHY must be done in the PHY driver. We use the PHY helpers instead to reset the PHY. Signed-off-by: Roger Quadros --- drivers/usb/host/ehci-omap.c | 70 + 1 files changed, 9 insertions(+), 61 deletions(-) diff --git a/drivers

Re: [PATCH 2/4] USB: dwc3: Adjust runtime pm the dwc3 driver to allow runtime suspend

2013-01-28 Thread Felipe Balbi
On Mon, Jan 28, 2013 at 05:12:26PM +0530, Vivek Gautam wrote: > The current code in the dwc3 probe effectively disables runtime pm > from ever working because it calls a get() that was never put() until > device removal. Change the runtime pm code to match the standard > formula and allow runtime

Re: [PATCH 3/4] usb: dwc3: exynos: Enable runtime power management

2013-01-28 Thread Felipe Balbi
On Mon, Jan 28, 2013 at 05:12:27PM +0530, Vivek Gautam wrote: > Enabling runtime power management on dwc3-exynos to save > power and allow its PHY's power to be managed at runtime. > > Signed-off-by: Vivek Gautam > --- > drivers/usb/dwc3/dwc3-exynos.c | 47 > ++

Re: [PATCH 3/4] usb: dwc3: exynos: Enable runtime power management

2013-01-28 Thread Vivek Gautam
Hi Balbi, On Mon, Jan 28, 2013 at 5:17 PM, Felipe Balbi wrote: > On Mon, Jan 28, 2013 at 05:12:27PM +0530, Vivek Gautam wrote: >> Enabling runtime power management on dwc3-exynos to save >> power and allow its PHY's power to be managed at runtime. >> >> Signed-off-by: Vivek Gautam >> --- >> dr

Re: [PATCH 4/4] usb: phy: samsung: Enable runtime power management on samsung-usb3

2013-01-28 Thread Felipe Balbi
Hi, On Mon, Jan 28, 2013 at 05:12:28PM +0530, Vivek Gautam wrote: > Enabling runtime power management support on samsung-usb3 phy > and further adding support to turn off the PHY ref_clk PLL. > It thereby requires PHY ref_clk to be switched between internal > core clock and external PLL clock. >

Re: [PATCH 3/4] usb: dwc3: exynos: Enable runtime power management

2013-01-28 Thread Felipe Balbi
Hi, On Mon, Jan 28, 2013 at 05:28:30PM +0530, Vivek Gautam wrote: > >> +static int dwc3_exynos_runtime_resume(struct device *dev) > >> +{ > >> + struct dwc3_exynos *exynos = dev_get_drvdata(dev); > >> + struct platform_device *pdev_dwc = exynos->dwc3; > >> + struct dwc3

Re: [PATCH 3/4] usb: dwc3: exynos: Enable runtime power management

2013-01-28 Thread Vivek Gautam
On Mon, Jan 28, 2013 at 5:42 PM, Felipe Balbi wrote: > Hi, > > On Mon, Jan 28, 2013 at 05:28:30PM +0530, Vivek Gautam wrote: >> >> +static int dwc3_exynos_runtime_resume(struct device *dev) >> >> +{ >> >> + struct dwc3_exynos *exynos = dev_get_drvdata(dev); >> >> + struct platform_dev

Re: [PATCH 3/4] usb: dwc3: exynos: Enable runtime power management

2013-01-28 Thread Felipe Balbi
On Mon, Jan 28, 2013 at 05:57:04PM +0530, Vivek Gautam wrote: > On Mon, Jan 28, 2013 at 5:42 PM, Felipe Balbi wrote: > > Hi, > > > > On Mon, Jan 28, 2013 at 05:28:30PM +0530, Vivek Gautam wrote: > >> >> +static int dwc3_exynos_runtime_resume(struct device *dev) > >> >> +{ > >> >> + struct dwc3

Endpoint flushing is not safe against URB removal

2013-01-28 Thread Anton Tikhomirov
Hello, In drivers/usb/core/hcd.c: usb_hcd_flush_endpoint() uses list_for_each_entry() to unlink URBs pending on endpoint. At the same time unlink1() calls usb_rh_urb_dequeue() where URB is removed from its endpoint queue: void usb_hcd_unlink_urb_from_ep(struct usb_hcd *hcd, struct urb *urb) {

Re: [PATCH 4/4] usb: phy: samsung: Enable runtime power management on samsung-usb3

2013-01-28 Thread Vivek Gautam
Hi Felipe, On Mon, Jan 28, 2013 at 5:39 PM, Felipe Balbi wrote: > Hi, > > On Mon, Jan 28, 2013 at 05:12:28PM +0530, Vivek Gautam wrote: >> Enabling runtime power management support on samsung-usb3 phy >> and further adding support to turn off the PHY ref_clk PLL. >> It thereby requires PHY ref_c

Re: [PATCH 4/4] usb: phy: samsung: Enable runtime power management on samsung-usb3

2013-01-28 Thread Felipe Balbi
Hi, On Mon, Jan 28, 2013 at 06:34:15PM +0530, Vivek Gautam wrote: > >> @@ -65,7 +67,22 @@ static u32 samsung_usb3_phy_set_refclk(struct > >> samsung_usbphy *sphy) > >> return reg; > >> } > >> > >> -static int samsung_exynos5_usb3_phy_enable(struct samsung_usbphy *sphy) > >> +/* > >> + * Se

Re: [PATCH 4/4] usb: phy: samsung: Enable runtime power management on samsung-usb3

2013-01-28 Thread Vivek Gautam
Hi Felipe, On Mon, Jan 28, 2013 at 6:37 PM, Felipe Balbi wrote: > Hi, > > On Mon, Jan 28, 2013 at 06:34:15PM +0530, Vivek Gautam wrote: >> >> @@ -65,7 +67,22 @@ static u32 samsung_usb3_phy_set_refclk(struct >> >> samsung_usbphy *sphy) >> >> return reg; >> >> } >> >> >> >> -static int sam

Re: [PATCH 4/4] usb: phy: samsung: Enable runtime power management on samsung-usb3

2013-01-28 Thread Felipe Balbi
On Mon, Jan 28, 2013 at 06:54:42PM +0530, Vivek Gautam wrote: > Hi Felipe, > > > On Mon, Jan 28, 2013 at 6:37 PM, Felipe Balbi wrote: > > Hi, > > > > On Mon, Jan 28, 2013 at 06:34:15PM +0530, Vivek Gautam wrote: > >> >> @@ -65,7 +67,22 @@ static u32 samsung_usb3_phy_set_refclk(struct > >> >> sa

Re: [PATCH 2/4] USB: dwc3: Adjust runtime pm the dwc3 driver to allow runtime suspend

2013-01-28 Thread Vivek Gautam
Hi Felipe, On Mon, Jan 28, 2013 at 5:15 PM, Felipe Balbi wrote: > On Mon, Jan 28, 2013 at 05:12:26PM +0530, Vivek Gautam wrote: >> The current code in the dwc3 probe effectively disables runtime pm >> from ever working because it calls a get() that was never put() until >> device removal. Chang

RE: [PATCH, resubmit] ax88179_178a: ASIX AX88179_178A USB 3.0/2.0 to gigabit ethernet adapter driver

2013-01-28 Thread Freddy
> I would vote to not accept that driver for mainline as long as this > issues are not fixed. Michael, could you give me more information about how do you test this driver? I have tried to reproduce the issue by using "ifconfig ethX mtu 1500", but I didn't confront the same issue. Thank you in

Re: [PATCH, resubmit] ax88179_178a: ASIX AX88179_178A USB 3.0/2.0 to gigabit ethernet adapter driver

2013-01-28 Thread Bjørn Mork
"Freddy" writes: > Bjørn, I am trying to reproduce the issue mentioned by Michael and I > have a question about submitting this driver. > > Should I merge this driver into asix_devices.c and asix_common.c even > through the usb command, tx_fixup, and rx_fixup functions are totally > different? T

Re: [PATCH] usb: phy: fix Kconfig warning

2013-01-28 Thread Greg KH
On Mon, Jan 28, 2013 at 10:20:47AM +0200, Felipe Balbi wrote: > Recent commits introduced the following > Kconfig warning: > > warning: (USB_MUSB_HDRC && OMAP_USB3) selects \ > OMAP_CONTROL_USB which has unmet direct \ > dependencies (USB_SUPPORT && ARCH_OMAP2PLUS) > > This patch just

Re: [PATCH] usb: phy: fix Kconfig warning

2013-01-28 Thread Felipe Balbi
Hi, On Mon, Jan 28, 2013 at 06:41:54AM -0800, Greg KH wrote: > On Mon, Jan 28, 2013 at 10:20:47AM +0200, Felipe Balbi wrote: > > Recent commits introduced the following > > Kconfig warning: > > > > warning: (USB_MUSB_HDRC && OMAP_USB3) selects \ > > OMAP_CONTROL_USB which has unmet direct \ >

Re: [PATCH 09/30] USB: ehci-omap: Use devm_request_and_ioremap()

2013-01-28 Thread Alan Stern
On Mon, 28 Jan 2013, Roger Quadros wrote: > Make use of devm_request_and_ioremap() and correct comment. Didn't a big patch come through recently converting all usages of devm_request_and_ioremap() to another function (I forget the name) that does its own error reporting and returns an ERR_PTR v

Re: [PATCH 09/30] USB: ehci-omap: Use devm_request_and_ioremap()

2013-01-28 Thread Russell King - ARM Linux
On Mon, Jan 28, 2013 at 10:17:33AM -0500, Alan Stern wrote: > On Mon, 28 Jan 2013, Roger Quadros wrote: > > > Make use of devm_request_and_ioremap() and correct comment. > > Didn't a big patch come through recently converting all usages of > devm_request_and_ioremap() to another function (I forg

Re: Endpoint flushing is not safe against URB removal

2013-01-28 Thread Alan Stern
On Mon, 28 Jan 2013, Anton Tikhomirov wrote: > Hello, > > In drivers/usb/core/hcd.c: usb_hcd_flush_endpoint() uses > list_for_each_entry() to unlink URBs pending on > endpoint. At the same time unlink1() calls usb_rh_urb_dequeue() > where URB is removed from its endpoint queue: > > void usb_hcd_

[PATCH 0/8] usb: gadget: convert to usb_gadget_map/unmap_request()

2013-01-28 Thread Felipe Balbi
Hi folks, we have generic implementations for a reason, right ? This patchset converts a few more of the UDC drivers to use the generic usb_gadget_map/unmap_request() calls. After this series, only the following UDC drivers are offending: drivers/usb/gadget/fsl_qe_udc.c drivers/usb/gadget/mv_u3

[PATCH 1/8] usb: gadget: s3c-hsotg: switch over to usb_gadget_map/unmap_request()

2013-01-28 Thread Felipe Balbi
we have generic implementations for a reason, let's use them. Signed-off-by: Felipe Balbi --- drivers/usb/gadget/s3c-hsotg.c | 46 +- 1 file changed, 5 insertions(+), 41 deletions(-) diff --git a/drivers/usb/gadget/s3c-hsotg.c b/drivers/usb/gadget/s3c-hso

[PATCH 2/8] usb: gadget: amd5536udc: remove unused structure member

2013-01-28 Thread Felipe Balbi
that member isn't used anywhere in the driver and be removed with no mercy. Signed-off-by: Felipe Balbi --- drivers/usb/gadget/amd5536udc.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/gadget/amd5536udc.h b/drivers/usb/gadget/amd5536udc.h index f1bf32e..6744d3b 100644 --- a/dri

[PATCH 3/8] usb: gadget: atmel_usba_udc: switch over to usb_gadget_map/unmap_request()

2013-01-28 Thread Felipe Balbi
we have generic implementations for a reason, let's use them. Signed-off-by: Felipe Balbi --- drivers/usb/gadget/atmel_usba_udc.c | 27 ++- 1 file changed, 6 insertions(+), 21 deletions(-) diff --git a/drivers/usb/gadget/atmel_usba_udc.c b/drivers/usb/gadget/atmel_usba_

[PATCH 4/8] usb: gadget: fsl_udc_core: switch over to usb_gadget_map/unmap_request()

2013-01-28 Thread Felipe Balbi
we have generic implementations for a reason, let's use them Signed-off-by: Felipe Balbi --- drivers/usb/gadget/fsl_udc_core.c | 51 ++- 1 file changed, 13 insertions(+), 38 deletions(-) diff --git a/drivers/usb/gadget/fsl_udc_core.c b/drivers/usb/gadget/fsl

[PATCH 5/8] usb: gadget: fusb300: switch over to usb_gadget_map/unmap_request()

2013-01-28 Thread Felipe Balbi
we have generic implementations for a reason, let's use them Signed-off-by: Felipe Balbi --- drivers/usb/gadget/fusb300_udc.c | 17 +++-- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/drivers/usb/gadget/fusb300_udc.c b/drivers/usb/gadget/fusb300_udc.c index bf51625..

[PATCH 6/8] usb: gadget: lpc32xx_udc: switch over to usb_gadget_map/unmap_request()

2013-01-28 Thread Felipe Balbi
we have generic implementations for a reason, let's use them Signed-off-by: Felipe Balbi --- drivers/usb/gadget/lpc32xx_udc.c | 39 --- 1 file changed, 4 insertions(+), 35 deletions(-) diff --git a/drivers/usb/gadget/lpc32xx_udc.c b/drivers/usb/gadget/lpc32xx

[PATCH 7/8] usb: gadget: mv_udc_core: switch over to usb_gadget_map/unmap_request()

2013-01-28 Thread Felipe Balbi
we have generic implementations for a reason, let's use them Signed-off-by: Felipe Balbi --- drivers/usb/gadget/mv_udc_core.c | 53 +--- 1 file changed, 6 insertions(+), 47 deletions(-) diff --git a/drivers/usb/gadget/mv_udc_core.c b/drivers/usb/gadget/mv_udc

[PATCH 8/8] usb: musb: gadget: switch over to usb_gadget_map/unmap_request()

2013-01-28 Thread Felipe Balbi
we have generic implementations for a reason, let's use them Signed-off-by: Felipe Balbi --- drivers/usb/musb/musb_gadget.c | 158 ++--- 1 file changed, 53 insertions(+), 105 deletions(-) diff --git a/drivers/usb/musb/musb_gadget.c b/drivers/usb/musb/musb_gad

Re: [PATCH v2 10/30] USB: ehci-omap: Use PHY APIs to get the PHY device and put it out of suspend

2013-01-28 Thread Alan Stern
On Mon, 28 Jan 2013, Roger Quadros wrote: > For each port that is in PHY mode we obtain a PHY device using the USB PHY > library and put it out of suspend. > > It is upto platform code to associate the PHY to the controller's > port and it is upto the PHY driver to manage the PHY's resources. "u

[PATCH 1/1] USB: qcserial: add Telit Gobi QDL device

2013-01-28 Thread Daniele Palmas
Add VID and PID for Telit Gobi QDL device Signed-off-by: Daniele Palmas --- drivers/usb/serial/qcserial.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/usb/serial/qcserial.c b/drivers/usb/serial/qcserial.c index aa148c2..2466254 100644 --- a/drivers/usb/serial/

[PATCH 1/1] USB: option: add support for Telit LE920

2013-01-28 Thread Daniele Palmas
From: danielepa Add PID and special handling for Telit LE920 Signed-off-by: Daniele Palmas --- drivers/usb/serial/option.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c index 0d9dac9..384bb92 100644 ---

[PATCH 1/1] NET: qmi_wwan: add Telit LE920 support

2013-01-28 Thread Daniele Palmas
Add VID, PID and fixed interface for Telit LE920 Signed-off-by: Daniele Palmas --- drivers/net/usb/qmi_wwan.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c index 6a1ca50..e32f9a1 100644 --- a/drivers/net/usb/qmi_w

Re: [PATCH v2 10/30] USB: ehci-omap: Use PHY APIs to get the PHY device and put it out of suspend

2013-01-28 Thread Roger Quadros
On 01/28/2013 05:40 PM, Alan Stern wrote: > On Mon, 28 Jan 2013, Roger Quadros wrote: > >> For each port that is in PHY mode we obtain a PHY device using the USB PHY >> library and put it out of suspend. >> >> It is upto platform code to associate the PHY to the controller's >> port and it is upto

Re: [PATCH, resubmit] ax88179_178a: ASIX AX88179_178A USB 3.0/2.0 to gigabit ethernet adapter driver

2013-01-28 Thread Michael Leun
On Mon, 28 Jan 2013 21:36:20 +0800 "Freddy" wrote: > > I would vote to not accept that driver for mainline as long as this > > issues are not fixed. > > > Michael, could you give me more information about how do you test > this driver? I have tried to reproduce the issue by using "ifconfig > e

Re: [PATCH 1/1] NET: qmi_wwan: add Telit LE920 support

2013-01-28 Thread Bjørn Mork
Daniele Palmas writes: > Add VID, PID and fixed interface for Telit LE920 > > Signed-off-by: Daniele Palmas > --- > drivers/net/usb/qmi_wwan.c |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c > index 6a1ca50..e

[PATCH] Revert "usb: Register usb port's acpi power resources"

2013-01-28 Thread Lan Tianyu
This reverts commit 88bb965ed711e8a5984e70208ebc901a6ff4141f. The linux-next branch of linux-pm tree has replaced acpi_power_resource_(un)register_device() with new routines. Commit 88bb965 will cause conflict in the linux-next tree. So revert it and this will not affect other functions. Will send

Re: [PATCH v2 11/30] usb: ehci-omap: Remove PHY reset handling code

2013-01-28 Thread Alan Stern
On Mon, 28 Jan 2013, Roger Quadros wrote: > Reset GPIO handling for the PHY must be done in the PHY > driver. We use the PHY helpers instead to reset the PHY. > > Signed-off-by: Roger Quadros Acked-by: Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the b

Re: [PATCH v2 12/30] usb: ehci-omap: Remove PHY regulator handling code

2013-01-28 Thread Alan Stern
On Mon, 28 Jan 2013, Roger Quadros wrote: > PHY regulator handling must be done in the PHY driver > > Signed-off-by: Roger Quadros Acked-by: Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH v2] usb: host: tegra: make use of PHY pointer of HCD

2013-01-28 Thread Stephen Warren
On 01/24/2013 03:27 AM, Venu Byravarasu wrote: > As pointer to PHY structure can be stored in struct usb_hcd > making use of it, to call Tegra PHY APIs. > > Call to usb_phy_shutdown() is moved up in tegra_ehci_remove(), > so that to avoid dereferencing of hcd after its freed up. I have applied th

[PATCH 01/13] MIPS: BCM63XX: add USB host clock enable delay

2013-01-28 Thread Florian Fainelli
Knowledge of the clock setup delay should remain at the clock level (so it can be clock specific and CPU specific). Add the 100 milliseconds required clock delay for the USB host clock when it gets enabled. Signed-off-by: Florian Fainelli --- arch/mips/bcm63xx/clk.c |5 + 1 file changed,

[PATCH 02/13] MIPS: BCM63XX: add USB device clock enable delay to clock code

2013-01-28 Thread Florian Fainelli
This patch adds the required 10 micro seconds delay to the USB device clock enable operation. Put this where the correct clock knowledege is, which is in the clock code, and remove this delay from the bcm63xx_udc gadget driver where it was before. Signed-off-by: Florian Fainelli --- arch/mips/bc

[PATCH 03/13] MIPS: BCM63XX: move code touching the USB private register

2013-01-28 Thread Florian Fainelli
This patch moves the code touching the USB private register in the bcm63xx USB gadget driver to arch/mips/bcm63xx/usb-common.c in preparation for adding support for OHCI and EHCI host controllers which will also touch the USB private register. Signed-off-by: Florian Fainelli --- arch/mips/bcm63x

[PATCH 10/13] MIPS: BCM63XX: register EHCI controller if board enables it

2013-01-28 Thread Florian Fainelli
BCM63XX-based board can control the registration of the EHCI controller by setting their has_ehci0 flag to 1. Handle this in the generic code dealing with board registration and call the actual helper to register the EHCI controller. Signed-off-by: Florian Fainelli --- arch/mips/bcm63xx/boards/b

[PATCH 05/13] MIPS: BCM63XX: introduce BCM63XX_OHCI configuration symbol

2013-01-28 Thread Florian Fainelli
This configuration symbol can be used by CPUs supporting the on-chip OHCI controller, and ensures that all relevant OHCI-related configuration options are correctly selected. So far, OHCI support is available for the 6328, 6348, 6358 and 6358 SoCs. Signed-off-by: Florian Fainelli --- arch/mips/b

[PATCH 04/13] MIPS: BCM63XX: add OHCI/EHCI configuration bits to common USB code

2013-01-28 Thread Florian Fainelli
This patch updates the common USB code touching the USB private registers with the specific bits to properly enable OHCI and EHCI controllers on BCM63xx SoCs. As a result we now need to protect access to Read Modify Write sequences using a spinlock because we cannot guarantee that any of the expose

[PATCH 12/13] MIPS: BCM63XX: EHCI controller does not support overcurrent

2013-01-28 Thread Florian Fainelli
This patch sets the ignore_oc flag for the BCM63XX EHCI controller as it does not support proper overcurrent reporting. Signed-off-by: Florian Fainelli --- arch/mips/bcm63xx/dev-usb-ehci.c |1 + 1 file changed, 1 insertion(+) diff --git a/arch/mips/bcm63xx/dev-usb-ehci.c b/arch/mips/bcm63xx

[PATCH 09/13] MIPS: BCM63XX: add support for the on-chip EHCI controller

2013-01-28 Thread Florian Fainelli
Broadcom BCM63XX SoCs include an on-chip EHCI controller which can be driven by the generic ehci-platform driver by using specific power on/off/suspend callbacks to manage clocks and hardware specific configuration. Signed-off-by: Maxime Bizon Signed-off-by: Florian Fainelli --- arch/mips/bcm63

[PATCH 13/13] MIPS: BCM63XX: update defconfig

2013-01-28 Thread Florian Fainelli
This patch updates the BCM63XX defconfig with the USB OHCI and EHCI host drivers as well as the USB gadget driver. Signed-off-by: Florian Fainelli --- arch/mips/configs/bcm63xx_defconfig | 22 +- 1 file changed, 9 insertions(+), 13 deletions(-) diff --git a/arch/mips/confi

[PATCH 07/13] MIPS: BCM63XX: register OHCI controller if board enables it

2013-01-28 Thread Florian Fainelli
BCM63XX-based boards can control the registration of the OHCI controller by setting their has_ohci0 flag to 1. Handle this in the generic code dealing with board registration and call the actual helper to register the OHCI controller. Signed-off-by: Florian Fainelli --- arch/mips/bcm63xx/boards/

[PATCH 06/13] MIPS: BCM63XX: add support for the on-chip OHCI controller

2013-01-28 Thread Florian Fainelli
Broadcom BCM63XX SoCs include an on-chip OHCI controller which can be driven by the ohci-platform generic driver by using specific power on/off/suspend callback to manage clocks and hardware specific configuration. Signed-off-by: Maxime Bizon Signed-off-by: Florian Fainelli --- arch/mips/bcm63x

[PATCH 11/13] USB: EHCI: add ignore_oc flag to disable overcurrent checking

2013-01-28 Thread Florian Fainelli
This patch adds an ignore_oc flag which can be set by EHCI controller not supporting or wanting to disable overcurrent checking. The EHCI platform data in include/linux/usb/ehci_pdriver.h is also augmented to take advantage of this new flag. Signed-off-by: Florian Fainelli --- drivers/usb/host/e

[PATCH 00/13] MIPS: BCM63XX: support for OHCI and EHCI integrated controllers

2013-01-28 Thread Florian Fainelli
Hi all, This patch series adds support for the Broadcom BCM63xx OHCI and EHCI integrated controllers. Thanks to the latest developments of the OHCI and EHCI platform drivers we no longer need a dedicated ohci or ehci driver stub and can use the generic platform drivers instead. This serie was ini

[PATCH 08/13] MIPS: BCM63XX: introduce BCM63XX_EHCI configuration symbol

2013-01-28 Thread Florian Fainelli
This configuration symbol can be used by CPUs supporting the on-chip EHCI controller, and ensures that all relevant EHCI-related configuration options are selected. So far BCM6328, BCM6358 and BCM6368 have an EHCI controller and do select this symbol. Update drivers/usb/host/Kconfig with BCM63XX to

Re: [PATCH 08/13] MIPS: BCM63XX: introduce BCM63XX_EHCI configuration symbol

2013-01-28 Thread David Daney
On 01/28/2013 11:06 AM, Florian Fainelli wrote: This configuration symbol can be used by CPUs supporting the on-chip EHCI controller, and ensures that all relevant EHCI-related configuration options are selected. So far BCM6328, BCM6358 and BCM6368 have an EHCI controller and do select this symbo

  1   2   >