Hi,
On Sun, Jan 20, 2013 at 11:17:31AM +0100, Pali Rohár wrote:
> On Sunday 20 January 2013 10:25:37 Felipe Balbi wrote:
> > On Sun, Jan 20, 2013 at 03:58:13AM +0100, Pali Rohár wrote:
> > > Signed-off-by: Pali Rohár
> >
> > NAK for two reasons:
> >
> > a) the original Nokia kernel used a separ
Hi,
On Mon, Jan 21, 2013 at 01:32:09PM +0800, victor yeo wrote:
> >> > This log looks oddly incomplete. A lot of debugging messages are
> >> > missing.
> >> >
> >> >> g_file_storage gadget: ep0-setup, length 8:
> >> >> : 80 06 00 01 00 00 40 00
> >> >> g_file_storage gadget: get device de
Hi,
On Sun, Jan 20, 2013 at 05:24:05PM -0800, Chao Xie wrote:
> -Original Message-
> From: Felipe Balbi [mailto:ba...@ti.com]
> Sent: Friday, January 18, 2013 8:05 PM
> To: kbuild test robot
> Cc: Chao Xie; linux-usb@vger.kernel.org; Felipe Balbi
> Subject: Re: [balbi-usb:gadget 19/61]
>
Hi,
>> >> >> g_file_storage gadget: ep0-setup, length 8:
>> >> >> : 80 06 00 01 00 00 40 00
>> >> >> g_file_storage gadget: get device descriptor
>> >> >
>> >> > For example, right here we should see the device descriptor data that
>> >> > was sent back to the host.
>> >>
>> >> I checked t
Hi everyone,
(please Cc)
I am currently running 3.8.0-rc4 and see the following behaviour:
When I plug/eject my kindle a few times, suddenly the kernel does
not see any USB activity any more. Nothing. PLugging in the kindle -
no reaction, plugging in a usb kbd - no reaction, plugging in a
usb mo
Hi,
On Mon, Jan 21, 2013 at 04:15:32PM +0800, victor yeo wrote:
> Hi,
>
> >> >> >> g_file_storage gadget: ep0-setup, length 8:
> >> >> >> : 80 06 00 01 00 00 40 00
> >> >> >> g_file_storage gadget: get device descriptor
> >> >> >
> >> >> > For example, right here we should see the device
Thank you David. yes in the core driver, FLAG_NOARP will be translated
to IFF_NOARP
2013/1/21, David Miller :
> From: Wei Shuai
> Date: Mon, 21 Jan 2013 10:20:22 +0800
>
>> The main problem is that these devices don't support ethernet.
>
> He's saying your comment is referring to the wrong thing,
Hi,
On Mon, Jan 21, 2013 at 04:51:28PM +0900, Norbert Preining wrote:
> Hi everyone,
> (please Cc)
>
> I am currently running 3.8.0-rc4 and see the following behaviour:
> When I plug/eject my kindle a few times, suddenly the kernel does
> not see any USB activity any more. Nothing. PLugging in th
Hi,
On Mon, Jan 21, 2013 at 12:15:10PM +0530, Vivek Gautam wrote:
> Hi Felipe,
>
>
> On Mon, Jan 14, 2013 at 6:29 PM, Vivek Gautam
> wrote:
> > Changes from v2:
> > - Renaming 'samsung-usbphy.c' driver to 'samsung-usb2.c' indicating
> >usb 2.0 phy controller's driver for Samsung's SoCs.
>
Alexey Orishko writes:
> On Fri, Jan 18, 2013 at 10:17 PM, Bjørn Mork wrote:
>
Some Sierra Wireless firmwares support CDC MBIM but have no CDC
Union funtional descriptor. This violates the MBIM specification,
>
> I don't believe Sierra Wireless violates MBIM specification.
> See in the
On Mon, Jan 21, 2013 at 10:13:43AM +0200, Felipe Balbi wrote:
> On Sun, Jan 20, 2013 at 05:24:05PM -0800, Chao Xie wrote:
[snip]
> > I am formatting and re-test the patches. I will send out today.
> > Thanks.
>
>
> great, please make sure to compile test on x86 and ARM with
> allyesconfig, allnoc
Hi,
>> > ep0_complete() should be called by your UDC driver. Seriously dude, read
>> > the documentation and read other drivers to figure out how things should
>> > be called. A quick look in the storage drivers would have shown you that
>> > ep0_complete() is passed in as req->complete() through
Hi,
On Mon, Jan 21, 2013 at 04:38:32PM +0800, Fengguang Wu wrote:
> On Mon, Jan 21, 2013 at 10:13:43AM +0200, Felipe Balbi wrote:
> > On Sun, Jan 20, 2013 at 05:24:05PM -0800, Chao Xie wrote:
> [snip]
> > > I am formatting and re-test the patches. I will send out today.
> > > Thanks.
> >
> >
> >
On Mon, Jan 21, 2013 at 04:45:03PM +0800, victor yeo wrote:
> Hi,
>
> >> > ep0_complete() should be called by your UDC driver. Seriously dude, read
> >> > the documentation and read other drivers to figure out how things should
> >> > be called. A quick look in the storage drivers would have shown
The standard suspend sequence involves runtime_resuming
devices before suspending the system.
So just saving context in runtime_suspend and restoring it
in runtime resume isn't enough. We must also save in "suspend"
and restore in "resume".
Without this patch, and OMAP3 system with off_mode en
On 01/18/2013 10:27 PM, Paul Walmsley wrote:
> Hi Roger,
>
> On Fri, 18 Jan 2013, Roger Quadros wrote:
>
>> We don't need multiple aliases for the OMAP USB host clocks and neither
>> the dummy clocks so remove them.
>>
>> CC: Paul Walmsley
>> CC: Rajendra Nayak
>> CC: Benoit Cousson
>> CC: Mik
Hi Kukjin,
On Fri, Jan 18, 2013 at 8:37 PM, Felipe Balbi wrote:
> On Fri, Jan 18, 2013 at 07:59:52PM +0530, Vivek Gautam wrote:
>> HI Balbi,
>>
>>
>> On Fri, Jan 18, 2013 at 7:52 PM, Felipe Balbi wrote:
>> > On Fri, Jan 18, 2013 at 07:51:08PM +0530, Vivek Gautam wrote:
>> >> Hi Felipe,
>> >>
>>
The patches are divied into 4 parts
1. bug fixes
usb: gadget: mv_udc: use udc_start and udc_stop functions
usb: gadget: mv_udc: use devm_xxx for probe
usb: gadget: mv_udc: fix the warning of mv_udc_remove
usb: otg: mv_otg: use devm_xxx for probe
usb: host: ehci-mv: remove unused variable
This patches converts the driver into the new style start/stop
interface. As a result the driver no longer uses the static
global the_conroller variable.
Signed-off-by: Chao Xie
---
drivers/usb/gadget/mv_udc_core.c | 79 +-
1 files changed, 35 insertions(+),
use devm_xxx for udc driver probe. So we do need care about
the resources release in driver remove or failure handling
in driver probe.
Signed-off-by: Chao Xie
---
drivers/usb/gadget/mv_udc_core.c | 156 ++
1 files changed, 56 insertions(+), 100 deletions(-)
Signed-off-by: Chao Xie
Acked-by: Alan Stern
---
drivers/usb/host/ehci-mv.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/usb/host/ehci-mv.c b/drivers/usb/host/ehci-mv.c
index 6c56297..3065809 100644
--- a/drivers/usb/host/ehci-mv.c
+++ b/drivers/usb/host/ehci-
usally we will use udc->tranceiver == NULL or
udc->tranceiver != NULL.
So when failed to get the udc->tranceiver by usb_get_phy(), we
directly set udc->tranceiver to be NULL.
Then the source code will not need macro IS_ERR_OR_NULL() for
udc->tranceiver judgement. It can reduce the line size and mak
The __exit_p() will be NULL if MODULE is no defined.
It will cause the warning. Removing __exit_p to remove
the warning.
Signed-off-by: Chao Xie
---
drivers/usb/gadget/mv_udc_core.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/usb/gadget/mv_udc_core.c b/drive
Only ARCH_PXA and ARCH_MMP will use mv_udc.
Signed-off-by: Chao Xie
---
drivers/usb/gadget/Kconfig |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig
index 14625fd..53943f7 100644
--- a/drivers/usb/gadget/Kconfig
+++ b
Originaly, udc driver will call the callbacks in platform data
for PHY initialization and shut down.
With PHY driver, it will call the APIs provided by PHY driver
for PHY initialization and shut down. It removes the callbacks
in platform data, and at same time it removes one block in the
way of ena
The PHY is seperated from usb controller.
The usb controller used in marvell pxa168/pxa910/mmp2 are same,
but PHY initialization may be different.
the usb controller can support udc/otg/ehci, and for each of
the mode, it need PHY to initialized before use the controller.
Direclty writing the phy dr
use devm_xxx for otg driver probe. So we do need care about
the resources release in driver remove or failure handling
in driver probe.
Signed-off-by: Chao Xie
---
drivers/usb/otg/mv_otg.c | 82 -
1 files changed, 22 insertions(+), 60 deletions(-)
d
Originaly, ehci driver will call the callbacks in platform data
for PHY initialization and shut down.
With PHY driver, it will call the APIs provided by PHY driver
for PHY initialization and shut down. It removes the callbacks
in platform data, and at same time it removes one block in the
way of en
Originaly, otg driver will call the callbacks in platform data
for PHY initialization and shut down.
With PHY driver, it will call the APIs provided by PHY driver
for PHY initialization and shut down. It removes the callbacks
in platform data, and at same time it removes one block in the
way of ena
add the udc/otg/ehci devices for mmp2
Signed-off-by: Chao Xie
---
arch/arm/mach-mmp/include/mach/mmp2.h |4
arch/arm/mach-mmp/mmp2.c |4
2 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-mmp/include/mach/mmp2.h
b/arch/arm/mach-mmp/includ
for brownstone board, add the udc/otg/ehci support
Signed-off-by: Chao Xie
---
arch/arm/mach-mmp/brownstone.c | 47
1 files changed, 47 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-mmp/brownstone.c b/arch/arm/mach-mmp/brownstone.c
index 5cb
because phy is seperated from the usb controller driver,
we can use the common pxa_device_desc for device register.
Signed-off-by: Chao Xie
---
arch/arm/mach-mmp/include/mach/pxa910.h |7 ---
arch/arm/mach-mmp/pxa910.c |4
2 files changed, 8 insertions(+), 3 deletio
phy setting are formatted into a phy driver at drivers/usb/phy,
we do not need do the setting in SOC files.
Signed-off-by: Chao Xie
---
arch/arm/mach-mmp/devices.c | 278 -
arch/arm/mach-mmp/include/mach/regs-usb.h | 253 --
2 f
Signed-off-by: Chao Xie
---
arch/arm/mach-mmp/pxa168.c | 42 --
1 files changed, 0 insertions(+), 42 deletions(-)
diff --git a/arch/arm/mach-mmp/pxa168.c b/arch/arm/mach-mmp/pxa168.c
index b7f074f..dd3a68b 100644
--- a/arch/arm/mach-mmp/pxa168.c
+++ b/ar
Because arch-mmp will make use of irq domain for irq
allocation, the irqs allocated for PMIC is dynamical.
The vbus/idpin irqs from PMIC can not be passed by platform data.
Using the extern chip APIs provides by PHY driver can solve this
problem.
Marvell usb PHY driver provides a middle layer.
The
For the vbus and idpin detection. It may be completed by some
external chip, for example the pmic chip 88pm860x in driver/mfd
can do it.
Although the usb controller can detect the vbus and id pin, but
it need clock on and PHY enabled to detect the
vbus/idpin. It will increase the power.
Using the e
It does the similar things as what we do for udc driver.
Signed-off-by: Chao Xie
Acked-by: Alan Stern
---
drivers/usb/host/ehci-mv.c | 12 ++--
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/usb/host/ehci-mv.c b/drivers/usb/host/ehci-mv.c
index be504fd..171e145
It does the similar things as what we do for udc driver.
Signed-off-by: Chao Xie
---
drivers/usb/otg/mv_otg.c | 63 -
drivers/usb/otg/mv_otg.h |3 ++
2 files changed, 31 insertions(+), 35 deletions(-)
diff --git a/drivers/usb/otg/mv_otg.c b/driv
Change the board support for usb as extern chip is supported
in marvell usb PHY driver
Signed-off-by: Chao Xie
---
arch/arm/mach-mmp/brownstone.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-mmp/brownstone.c b/arch/arm/mach-mmp/brownstone.c
index 90c034
Change the board support for usb as extern chip is supported
in marvell usb PHY driver.
Signed-off-by: Chao Xie
---
arch/arm/mach-mmp/ttc_dkb.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-mmp/ttc_dkb.c b/arch/arm/mach-mmp/ttc_dkb.c
index 0962791..eb346
All blocks are removed. Add the device tree support for otg.
Signed-off-by: Chao Xie
---
drivers/usb/otg/mv_otg.c | 128 +
drivers/usb/otg/mv_otg.h |6 +-
2 files changed, 108 insertions(+), 26 deletions(-)
diff --git a/drivers/usb/otg/mv_otg.c b
In original driver, we have callbacks in platform data, and some
dynamically allocations variables in platform data.
Now, these blocks are removed, the device tree support is easier
now.
Signed-off-by: Chao Xie
---
drivers/usb/gadget/mv_udc.h |5 +-
drivers/usb/gadget/mv_udc_core.c | 1
All blocks are removed. Add the device tree support for ehci.
Signed-off-by: Chao Xie
Acked-by: Alan Stern
---
drivers/usb/host/ehci-mv.c | 105 +--
1 files changed, 80 insertions(+), 25 deletions(-)
diff --git a/drivers/usb/host/ehci-mv.c b/drivers/usb
for ttc_dkb board, add udc/otg/ehci support
Signed-off-by: Chao Xie
---
arch/arm/mach-mmp/ttc_dkb.c | 30 +++---
1 files changed, 19 insertions(+), 11 deletions(-)
diff --git a/arch/arm/mach-mmp/ttc_dkb.c b/arch/arm/mach-mmp/ttc_dkb.c
index ce55fd8..0962791 100644
---
Convert all uses of devm_request_and_ioremap() to the newly introduced
devm_ioremap_resource() which provides more consistent error handling.
devm_ioremap_resource() provides its own error messages so all explicit
error messages can be removed from the failure code paths.
Signed-off-by: Thierry R
Every channel has a functional clock that is similarly named.
It makes sense to use a for loop to manage these clocks as OMAPs
can come with up to 3 channels.
Dynamically allocate and get channel clocks depending on the
number of clocks avaiable on the platform.
Signed-off-by: Roger Quadros
Revi
This is a handy macro to check if the port requires the
USB TLL module or not. Use it to Enable the TLL module and manage
the clocks.
Signed-off-by: Roger Quadros
Reviewed-by: Felipe Balbi
---
drivers/mfd/omap-usb-tll.c | 20
1 files changed, 12 insertions(+), 8 deletions
All ports have similarly named port clocks so we can
bunch them into a port data structure and use for loop
to enable/disable the clocks.
Dynamically allocate and get clocks based on number of ports
available on the platform
Signed-off-by: Roger Quadros
Reviewed-by: Felipe Balbi
---
drivers/mf
Enable the optional HSIC clocks (60MHz and 480MHz) for the ports
that are configured in HSIC mode.
Signed-off-by: Roger Quadros
Reviewed-by: Felipe Balbi
---
drivers/mfd/omap-usb-host.c | 97 --
1 files changed, 83 insertions(+), 14 deletions(-)
diff -
Hi,
>> >> Yes, ep0_complete() is called in UDC driver queue function, i just
>> >> added it in and ep0_complete() is called now. The dmesg output is
>> >> below.
>> >
>> > not in queue function, you should call it when completing.
>> >
>>
>> Is there any mistake in my understanding of ep0 setup da
Hello.
On 21-01-2013 6:20, Wei Shuai wrote:
The main problem is that these devices don't support ethernet. They
support IP (v4 and _maybe_ v6) with an ethernet header. Many of them
will do ARP (and IPv6 ND) as well to complete the picture, but some of
them don't and that's what these drivers
for NUL terminated string, better notice '\0' in the end.
Signed-off-by: Chen Gang
---
drivers/usb/gadget/uvc_v4l2.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/gadget/uvc_v4l2.c b/drivers/usb/gadget/uvc_v4l2.c
index 2ca9386..a9934c7 100644
--- a/d
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Hi Neil,
On 01/21/13 11:28, NeilBrown wrote:
>
>
> The standard suspend sequence involves runtime_resuming
> devices before suspending the system.
> So just saving context in runtime_suspend and restoring it
> in runtime resume isn't enough. We mu
Hi,
On Mon, Jan 21, 2013 at 07:13:03PM +0800, victor yeo wrote:
> >> >> Yes, ep0_complete() is called in UDC driver queue function, i just
> >> >> added it in and ep0_complete() is called now. The dmesg output is
> >> >> below.
> >> >
> >> > not in queue function, you should call it when completin
From: Julia Lawall
Delete successive tests to the same location. Data is the just previously
allocated and tested value. Test the result of the allocation made here
instead.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
//
@s e
From: Julia Lawall
Delete successive tests to the same location. In this case res has already
been tested for being NULL, and calling devm_request_and_ioremap will not
make it NULL. On the other hand, devm_request_and_ioremap can return NULL
on failure.
A simplified version of the semantic mat
Hi,
On Mon, Jan 21, 2013 at 02:02:57PM +0100, Julia Lawall wrote:
> From: Julia Lawall
>
> Delete successive tests to the same location. Data is the just previously
> allocated and tested value. Test the result of the allocation made here
> instead.
>
> A simplified version of the semantic ma
Hi Felipe,
On Friday 18 January 2013 20:46:59 Felipe Balbi wrote:
> On Thu, Jan 17, 2013 at 04:23:48PM +0530, Bhupesh Sharma wrote:
> > This patchset tries to enhance the UVC webcam gadget driver and
> > is based on Laurent's git tree available here (head uvc-gadget):
> > git://linuxtv.org/pinchar
On 01/16/2013 05:01 PM, Kishon Vijay Abraham I wrote:
> The OMAP glue has been modified to get PHY by phandle for dt boot.
>
> Signed-off-by: Kishon Vijay Abraham I
> ---
> drivers/usb/musb/omap2430.c |7 ++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/
On 01/16/2013 05:01 PM, Kishon Vijay Abraham I wrote:
> Added an API devm_usb_get_phy_by_phandle(), to get usb phy by passing a
> device node phandle value. This function will return a pointer to
> the phy on success, -EPROBE_DEFER if there is a device_node for the phandle,
> but the phy has not be
On Monday 21 January 2013 06:51 PM, Roger Quadros wrote:
On 01/16/2013 05:01 PM, Kishon Vijay Abraham I wrote:
Added an API devm_usb_get_phy_by_phandle(), to get usb phy by passing a
device node phandle value. This function will return a pointer to
the phy on success, -EPROBE_DEFER if there is a
Hi,
I think I've found a debug in fsl_udc_core.c and hope for some review of the
fix. It's pretty complex so apologies in advance if my explanation misses
anything.
The background is that I started with the 3.0.59 stable branch (which shows the
problem), then merged down the specific changes
Hi,
On Monday 21 January 2013 06:48 PM, Roger Quadros wrote:
On 01/16/2013 05:01 PM, Kishon Vijay Abraham I wrote:
The OMAP glue has been modified to get PHY by phandle for dt boot.
Signed-off-by: Kishon Vijay Abraham I
---
drivers/usb/musb/omap2430.c |7 ++-
1 file changed, 6 inse
Dropping __devinit, __devexit_p, __exit annotations since they are
nop and no longer supported.
Signed-off-by: Vivek Gautam
---
drivers/usb/phy/samsung-usbphy.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/phy/samsung-usbphy.c b/drivers/usb/phy/samsun
Hello Alexey,
I have another issue with the Sierra firmware which I hope you can help
me with: The MC7710 device requires at ZLP even if we send
dwNtbOutMaxSize sized NTBs. This is a problem because the current code
explicitly prevents this.
The following code in the v3.8 cdc-ncm was written to k
Added has_mailbox to the musb platform data to specify that omap uses
an external mailbox (in control module) to communicate with the musb
core during device connect and disconnect.
Signed-off-by: Kishon Vijay Abraham I
---
arch/arm/mach-omap2/usb-musb.c |3 +++
include/linux/usb/musb.h
Added a new driver for the usb part of control module. This has an API
to power on the USB2 phy and an API to write to the mailbox depending on
whether MUSB has to act in host mode or in device mode.
Writing to control module registers for doing the above task which was
previously done in omap glu
A seperate driver has been added to handle the usb part of control
module. A device for the above driver is created here, using the register
address information to be used by the driver for powering on the PHY and
for writing to the mailbox.
Signed-off-by: Kishon Vijay Abraham I
---
arch/arm/mac
Start using the control module driver for powering on the PHY and for
writing to the mailbox instead of writing to the control module
registers on their own.
Signed-off-by: Kishon Vijay Abraham I
---
Documentation/devicetree/bindings/usb/omap-usb.txt |4 ++
Documentation/devicetree/bindings/
Added a new driver for the usb part of control module. This has an API
to power on the USB2 phy and an API to write to the mailbox depending on
whether MUSB has to act in host mode or in device mode.
Writing to control module registers for doing the above task which was
previously done in omap glu
Change since v1:
optimize the export connect type patch and adjust the DeviceRemovalbe
flag
in the rh_call_control() after GetHubDescriptor request being processed.
move all debounce operation to usb port's runtime resume callback(). Add
did_runtime_put in the struct usb_port to call
ACPI provide "_PLD" and "_UPC" aml methods to describe usb port
visibility and connectability. This patch is to add
usb_hub_adjust_DeviceRemovable()
to adjust usb hub port's DeviceRemovable according ACPI information and invoke
it in
the rh_call_control(). When hub descriptor request is issued at
This patch is to register usb port's acpi power resources. Create
link between usb port device and its acpi power resource.
Acked-by: Alan Stern
Signed-off-by: Lan Tianyu
---
drivers/usb/core/port.c |3 +++
drivers/usb/core/usb-acpi.c | 20
drivers/usb/core/usb.h
The dev_pm_qos_flags() will be used in the usb core which could be
compiled as a module. This patch is to export it.
Acked-by: Alan Stern
Signed-off-by: Lan Tianyu
---
drivers/base/power/qos.c |1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/base/power/qos.c b/drivers/base/power/q
This patch is to add runtime pm callback for usb port device.
Set/clear PORT_POWER feature in the resume/suspend callbak.
Add portnum for struct usb_port to record port number. Do
pm_rumtime_get_sync/put(portdev) when a device is plugged/unplugged
to prevent it from being powered off when it is act
This patch is to expose usb port's pm qos flags(pm_qos_no_power_off,
pm_qos_remote_wakeup) to user space. User can set pm_qos_no_power_off
flag to prohibit the port from being powered off.
Acked-by: Alan Stern
Signed-off-by: Lan Tianyu
---
drivers/usb/core/port.c | 11 ++-
1 file chan
Signed-off-by: Lan Tianyu
---
drivers/usb/core/port.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/core/port.c b/drivers/usb/core/port.c
index 0334d91..50b646e 100644
--- a/drivers/usb/core/port.c
+++ b/drivers/usb/core/port.c
@@ -215,7 +215,7 @@ int usb_hub_
On Friday 18 of January 2013 14:30:21 Praveen Paneri wrote:
> Changes from v8:
> Resending this patch series after rebasing to the latest usb-next
> branch. Rewording inline comments for better readability.
> Removed IS_ENABLED(CONFIG_OF) as pdev->dev.of_node is enough to check
> for dt support. Us
On 01/21/2013 03:34 PM, kishon wrote:
> On Monday 21 January 2013 06:51 PM, Roger Quadros wrote:
>> On 01/16/2013 05:01 PM, Kishon Vijay Abraham I wrote:
>>> Added an API devm_usb_get_phy_by_phandle(), to get usb phy by passing a
>>> device node phandle value. This function will return a pointer to
On 01/21/2013 03:41 PM, kishon wrote:
> Hi,
>
> On Monday 21 January 2013 06:48 PM, Roger Quadros wrote:
>> On 01/16/2013 05:01 PM, Kishon Vijay Abraham I wrote:
>>> The OMAP glue has been modified to get PHY by phandle for dt boot.
>>>
>>> Signed-off-by: Kishon Vijay Abraham I
>>> ---
>>> driv
Bjørn Mork writes:
> I have another issue with the Sierra firmware which I hope you can help
> me with: The MC7710 device requires at ZLP even if we send
> dwNtbOutMaxSize sized NTBs. This is a problem because the current code
> explicitly prevents this.
If anyone found this more than normally c
No functional change. Just added a missing newline character.
Signed-off-by: Kishon Vijay Abraham I
---
drivers/usb/musb/musb_core.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
index f1c6c54..c534131 100644
--
On Monday 21 January 2013 15:47:13 Bjørn Mork wrote:
> But I wonder if this isn't really a generic problem in usbnet. The
> FLAG_MULTI_PACKET test here seems completely bogus:
>
> if (length % dev->maxpacket == 0) {
> if (!(info->flags & FLAG_SEND_ZLP)) {
>
Hi
On Mon, 21 Jan 2013, Roger Quadros wrote:
> On 01/18/2013 10:27 PM, Paul Walmsley wrote:
> > On Fri, 18 Jan 2013, Roger Quadros wrote:
> >
> >> We don't need multiple aliases for the OMAP USB host clocks and neither
> >> the dummy clocks so remove them.
> >>
> >> CC: Paul Walmsley
> >> CC: R
Hi,
>> >> >> Yes, ep0_complete() is called in UDC driver queue function, i just
>> >> >> added it in and ep0_complete() is called now. The dmesg output is
>> >> >> below.
>> >> >
>> >> > not in queue function, you should call it when completing.
>> >> >
>> >>
>> >> Is there any mistake in my under
Oliver Neukum writes:
> On Monday 21 January 2013 15:47:13 Bjørn Mork wrote:
>> But I wonder if this isn't really a generic problem in usbnet. The
>> FLAG_MULTI_PACKET test here seems completely bogus:
>>
>> if (length % dev->maxpacket == 0) {
>> if (!(info->flags & FLAG_
On Mon, Jan 21, 2013 at 11:14:19PM +0800, victor yeo wrote:
> Hi,
>
> >> >> >> Yes, ep0_complete() is called in UDC driver queue function, i just
> >> >> >> added it in and ep0_complete() is called now. The dmesg output is
> >> >> >> below.
> >> >> >
> >> >> > not in queue function, you should cal
Adding support for the MBIM mode in some Sierra Wireless devices.
Some Sierra Wireless firmwares support CDC MBIM but have no CDC
Union funtional descriptor. This violates the MBIM specification,
but we can easily work around the bug by looking at the Interface
Association Descriptor instead. Thi
The 2 first patches in this series are required to make the Sierra
Wireless MC7710 card work in MBIM mode. They may also be
required for other Qualcomm firmware based MBIM devices.
Patch #1 was previously posted as a standalone patch. This version
is a replacement, removing a theoretical NULL po
commit bbc8d92 (net: cdc_ncm: add Huawei devices) implemented
support for devices with a single combined control and data
interface. Fix up the error path so that we do not double
release such interfaces in case of probing failures.
Signed-off-by: Bjørn Mork
---
drivers/net/usb/cdc_ncm.c |3
We normally avoid sending ZLPs by padding NTBs with a zero byte
if the NTB is shorter than dwNtbOutMaxSize, resulting in a short
USB packet instead of a ZLP. But in the case where the NTB length
is exactly dwNtbOutMaxSize and this is an exact multiplum of
wMaxPacketSize, then we must send a ZLP.
On Mon, Jan 21, 2013 at 05:07:36AM -0500, Chao Xie wrote:
> + mv_phy->extern_chip.head = devm_kzalloc(&pdev->dev,
> + sizeof(*mv_phy->extern_chip.head),
> + GFP_KERNEL);
> + if (mv_phy->extern_chip.head == NULL)
> +
We do have some USB net devices, which cannot do ARP.
so we can introduce a new flag FLAG_NOARP, then client drivers
can easily handle this kind of devices
Signed-off-by: Wei Shuai
---
drivers/net/usb/usbnet.c |4
include/linux/usb/usbnet.h |1 +
2 files changed, 5 insertions(+
On Mon, Jan 21, 2013 at 01:04:46PM +0200, Roger Quadros wrote:
> Every channel has a functional clock that is similarly named.
> It makes sense to use a for loop to manage these clocks as OMAPs
> can come with up to 3 channels.
>
> Dynamically allocate and get channel clocks depending on the
> num
Infineon(now Intel) HSPA Modem platform NCM cannot support ARP.
we can define a new common structure wwan_noarp_info.
Then more similiar NO ARP devices can be handled easily
Signed-off-by: Wei Shuai
---
drivers/net/usb/cdc_ncm.c | 21 +
1 files changed, 21 insertions(+), 0
On Fri, 18 Jan 2013, Greg KH wrote:
> On Sat, Jan 12, 2013 at 11:18:03PM +0800, Chen Gang wrote:
> >
> > for function uhci_sprint_schedule:
> > the buffer len is MAX_OUTPUT: 64 * 1024, which may not be enough:
> > may loop UHCI_NUMFRAMES times (UHCI_NUMFRAMES is 1024)
> > each t
Hello.
On 01/21/2013 05:52 PM, Kishon Vijay Abraham I wrote:
> No functional change. Just added a missing newline character.
> Signed-off-by: Kishon Vijay Abraham I
> ---
> drivers/usb/musb/musb_core.c |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/drivers/usb/musb/
> -Original Message-
> From: Bjørn Mork [mailto:bj...@mork.no]
>
> We normally avoid sending ZLPs by padding NTBs with a zero byte if the
> NTB is shorter than dwNtbOutMaxSize, resulting in a short USB packet
> instead of a ZLP. But in the case where the NTB length is exactly
> dwNtbOutMa
Hi, Bjørn!
> "BM" == Bjørn Mork writes:
> We normally avoid sending ZLPs by padding NTBs with a zero byte
> if the NTB is shorter than dwNtbOutMaxSize, resulting in a short
> USB packet instead of a ZLP. But in the case where the NTB length
> is exactly dwNtbOutMaxSize and this is an ex
On Mon, Jan 21, 2013 at 03:37:15AM +, Fangxiaozhi (Franko) wrote:
> Dear Greg:
>
> > I get the following errors:
> >
> > drivers/usb/storage/unusual_devs.h:1530:1: error: implicit declaration of
> > function ‘UNUSUAL_VENDOR_INTF’ [-Werror=implicit-function-declaration]
> > drivers/usb/s
1 - 100 of 166 matches
Mail list logo
