Re: [PATCH v5 2/4] usb: phy: samsung: Add host phy support to samsung-phy driver

2013-01-14 Thread Vivek Gautam
Hi Doug, On Mon, Jan 14, 2013 at 11:15 AM, Vivek Gautam wrote: > Hi Doug, > > > On Sat, Jan 12, 2013 at 6:20 AM, Doug Anderson wrote: >> Vivek, >> >> On Fri, Jan 11, 2013 at 4:40 AM, Vivek Gautam >> wrote: > +#define HOST_CTRL0_REFCLKSEL_MASK (0x3) > +#define HOST_CTRL0_R

Re: [PATCH v2 1/1] usb: fsl-mxc-udc: fix build error due to mach/hardware.h

2013-01-14 Thread Peter Chen
On Mon, Jan 14, 2013 at 09:48:58AM +0200, Felipe Balbi wrote: > Hi, > > On Mon, Jan 14, 2013 at 03:18:17PM +0800, Peter Chen wrote: > > It changes the driver to use platform_device_id rather than cpu_is_xxx > > to determine the SoC type, and updates the platform code accordingly. > > > > Compile

Re: USB device cannot be reconnected and khubd "blocked for more than 120 seconds"

2013-01-14 Thread Oliver Neukum
On Monday 14 January 2013 11:47:57 Ming Lei wrote: > [ 181.175323] "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" > disables this message. > [ 181.183624] modprobeD c04f1920 0 2462 2461 0x > [ 181.183685] [] (__schedule+0x5fc/0x6d4) from [] > (async_synchronize_cookie_

Re: [RFC PATCH 1/6] Core files for the DWC2 driver

2013-01-14 Thread Felipe Balbi
Hi, On Fri, Jan 11, 2013 at 10:22:08PM +, Paul Zimmerman wrote: > > From: Felipe Balbi [mailto:ba...@ti.com] > > Sent: Friday, January 11, 2013 1:44 AM > > > > Hi, > > Hi Felipe, thanks for the review. > > > On Mon, Jan 07, 2013 at 11:51:36AM -0800, Paul Zimmerman wrote: > > > > > > Signed-

Re: USB device cannot be reconnected and khubd "blocked for more than 120 seconds"

2013-01-14 Thread Ming Lei
On Mon, Jan 14, 2013 at 4:22 PM, Oliver Neukum wrote: > > OK, your trace is totally different. If your hangs are related, as is likely, > my explanation goes out of the window. If I run 'shutdown' after unplugging usb storage device, another hang trace same with Alex's can be triggered too, so it

Re: [PATCH v2 1/1] usb: fsl-mxc-udc: fix build error due to mach/hardware.h

2013-01-14 Thread Felipe Balbi
Hi, On Mon, Jan 14, 2013 at 04:17:35PM +0800, Peter Chen wrote: > On Mon, Jan 14, 2013 at 09:48:58AM +0200, Felipe Balbi wrote: > > Hi, > > > > On Mon, Jan 14, 2013 at 03:18:17PM +0800, Peter Chen wrote: > > > It changes the driver to use platform_device_id rather than cpu_is_xxx > > > to determi

Re: [PATCH RFC] usb: dwc3: Remove dwc3 dependency on gadget.

2013-01-14 Thread Vivek Gautam
Hi Felipe, On Mon, Jan 14, 2013 at 1:27 PM, Felipe Balbi wrote: > On Fri, Jan 11, 2013 at 07:58:23PM +0530, Vivek Gautam wrote: >> Hi, >> >> >> On Fri, Jan 11, 2013 at 7:29 PM, Felipe Balbi wrote: >> > Hi, >> > >> > On Fri, Jan 11, 2013 at 07:13:55PM +0530, Vivek Gautam wrote: >> >> On Thu, Jan

Re: [PATCH v2 1/1] usb: fsl-mxc-udc: fix build error due to mach/hardware.h

2013-01-14 Thread Peter Chen
On Mon, Jan 14, 2013 at 10:50:27AM +0200, Felipe Balbi wrote: > Hi, > > On Mon, Jan 14, 2013 at 04:17:35PM +0800, Peter Chen wrote: > > On Mon, Jan 14, 2013 at 09:48:58AM +0200, Felipe Balbi wrote: > > > Hi, > > > > > > On Mon, Jan 14, 2013 at 03:18:17PM +0800, Peter Chen wrote: > > > > It change

Re: [PATCH v2 1/1] usb: fsl-mxc-udc: fix build error due to mach/hardware.h

2013-01-14 Thread Felipe Balbi
On Mon, Jan 14, 2013 at 05:13:44PM +0800, Peter Chen wrote: > On Mon, Jan 14, 2013 at 10:50:27AM +0200, Felipe Balbi wrote: > > Hi, > > > > On Mon, Jan 14, 2013 at 04:17:35PM +0800, Peter Chen wrote: > > > On Mon, Jan 14, 2013 at 09:48:58AM +0200, Felipe Balbi wrote: > > > > Hi, > > > > > > > > O

Re: [PATCH 07/14] usb: ehci-omap: Instantiate PHY devices if required

2013-01-14 Thread Roger Quadros
On 01/11/2013 06:32 PM, Russell King - ARM Linux wrote: > On Fri, Jan 11, 2013 at 06:03:21PM +0200, Roger Quadros wrote: >> diff --git a/include/linux/platform_data/usb-omap.h >> b/include/linux/platform_data/usb-omap.h >> index d63eb7d..927b8a1 100644 >> --- a/include/linux/platform_data/usb-omap.

Re: [PATCH 04/14] usb: phy: nop: Handle power supply regulator for the PHY

2013-01-14 Thread Roger Quadros
On 01/11/2013 07:17 PM, Russell King - ARM Linux wrote: > On Thu, Jan 10, 2013 at 06:51:24PM +0200, Roger Quadros wrote: >> We use "vcc" as the supply name for the PHY's power supply. >> The power supply will be enabled during .init() and disabled >> during .shutdown() >> >> Signed-off-by: Roger Qu

[PATCH v3 0/3] Fix the Build error for fsl_mxc_udc.c

2013-01-14 Thread Peter Chen
Changes for v3: - Split the one big patch into three patches Changes for v2: - Add const for fsl_udc_devtype - Do ioremap for phy address at fsl-mxc-udc Peter Chen (3): usb: fsl-mxc-udc: replace cpu_is_xxx() with platform_device_id usb: fsl_mxc_udc: replace MX35_IO_ADDRESS to ioremap ARM: i

[PATCH v3 1/3] usb: fsl-mxc-udc: replace cpu_is_xxx() with platform_device_id

2013-01-14 Thread Peter Chen
As mach/hardware.h is deleted, we need to use platform_device_id to differentiate SoCs. Besides we update the platform code accordingly. Signed-off-by: Peter Chen --- arch/arm/mach-imx/devices/devices-common.h|1 + arch/arm/mach-imx/devices/platform-fsl-usb2-udc.c | 15 +++--- dri

[PATCH v3 2/3] usb: fsl_mxc_udc: replace MX35_IO_ADDRESS to ioremap

2013-01-14 Thread Peter Chen
As mach/hardware.h is deleted, we can't visit platform code at driver. It has no phy driver to combine with this controller, so it has to use ioremap to map phy address as a workaround. Signed-off-by: Peter Chen --- drivers/usb/gadget/fsl_mxc_udc.c | 12 +++- 1 files changed, 7 inserti

[PATCH v3 3/3] ARM: i.MX clock: Change the connection-id for fsl-usb2-udc

2013-01-14 Thread Peter Chen
As we use platform_device_id for fsl-usb2-udc driver, it needs to change clk connection-id, or the related devm_clk_get will be failed. Signed-off-by: Peter Chen --- arch/arm/mach-imx/clk-imx25.c |6 +++--- arch/arm/mach-imx/clk-imx27.c |6 +++--- arch/arm/mach-imx/clk-imx31.

Re: [PATCH v3 1/3] usb: fsl-mxc-udc: replace cpu_is_xxx() with platform_device_id

2013-01-14 Thread Felipe Balbi
Hi, On Mon, Jan 14, 2013 at 06:12:39PM +0800, Peter Chen wrote: > @@ -2756,22 +2753,41 @@ static int fsl_udc_otg_resume(struct device *dev) > > return fsl_udc_resume(NULL); > } > - > /*- > Register entry point

Re: [PATCH v3 2/3] usb: fsl_mxc_udc: replace MX35_IO_ADDRESS to ioremap

2013-01-14 Thread Felipe Balbi
On Mon, Jan 14, 2013 at 06:12:40PM +0800, Peter Chen wrote: > As mach/hardware.h is deleted, we can't visit platform code at driver. > It has no phy driver to combine with this controller, so it has to use > ioremap to map phy address as a workaround. > > Signed-off-by: Peter Chen > --- > driver

Re: [PATCH v3 1/3] usb: fsl-mxc-udc: replace cpu_is_xxx() with platform_device_id

2013-01-14 Thread Marc Kleine-Budde
On 01/14/2013 11:16 AM, Felipe Balbi wrote: > Hi, > > On Mon, Jan 14, 2013 at 06:12:39PM +0800, Peter Chen wrote: >> @@ -2756,22 +2753,41 @@ static int fsl_udc_otg_resume(struct device *dev) >> >> return fsl_udc_resume(NULL); >> } >> - >> /*

Re: [PATCH v3 1/3] usb: fsl-mxc-udc: replace cpu_is_xxx() with platform_device_id

2013-01-14 Thread Felipe Balbi
On Mon, Jan 14, 2013 at 11:18:53AM +0100, Marc Kleine-Budde wrote: > On 01/14/2013 11:16 AM, Felipe Balbi wrote: > > Hi, > > > > On Mon, Jan 14, 2013 at 06:12:39PM +0800, Peter Chen wrote: > >> @@ -2756,22 +2753,41 @@ static int fsl_udc_otg_resume(struct device *dev) > >> > >>return fsl_udc_

[PATCH V2 0/8] usb/dwc3: misc patches rebased at dwc3-for-v3.8

2013-01-14 Thread Pratyush Anand
Most of these patches have alreday been posted in past but still they have not been applied to tree. These are rebased on tag dwc3-for-v3.8. Changes since v1: -- Commit log updated for patch "usb/dwc3: Fix missed isoc". -- unnecessary parenthesis around list_empty() in patch "usb/dwc3: Fix skip L

[PATCH V2 1/8] usb/dwc3: Enable usb2 LPM only when connected as usb2.0

2013-01-14 Thread Pratyush Anand
Synopsys says: The HIRD Threshold field must be set to ‘0’ when the device core is operating in super speed mode. This patch implements above statement. Signed-off-by: Pratyush Anand --- drivers/usb/dwc3/gadget.c | 31 ++- 1 files changed, 18 insertions(+), 13 dele

[PATCH V2 2/8] usb/dwc3: Fix missed isoc

2013-01-14 Thread Pratyush Anand
There are two reasons to generate missed isoc. 1. when the host does not poll for all the data. 2. because of application-side delays that prevent all the data from being transferred in programmed microframe. Current code was able to handle first case only. This patch handles scenario 2 as well.

[PATCH V2 3/8] usb/dwc3: Correct Return from ep_queue

2013-01-14 Thread Pratyush Anand
Its better to return from each if condition as they are mutually exclusive. Signed-off-by: Pratyush Anand --- drivers/usb/dwc3/gadget.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c index bbbcd2e..4d24711 100644

[PATCH V2 5/8] usb/dwc3: Fix skip LINK-TRB on ISOC

2013-01-14 Thread Pratyush Anand
When we reach to link trb, we just need to increase free_slot and then calculate TRB. Return is not correct, as it will cause wrong TRB DMA address to fetch in case of update transfer. Signed-off-by: Pratyush Anand --- drivers/usb/dwc3/gadget.c | 13 + 1 files changed, 5 insertions

[PATCH V2 4/8] usb/dwc3: fix isoc END TRANSFER Condition

2013-01-14 Thread Pratyush Anand
There were still some corner cases where isoc transfer was not able to restart, specially when missed isoc does not happen , and in fact gadget does not queue any new request during giveback. Cleanup function calls giveback first, which provides a way to queue another request to gadget. But gadget

[PATCH V2 6/8] usb/dwc3: No need to pass params in case of UPDATE TRANSFER

2013-01-14 Thread Pratyush Anand
UPDATE transfer does not need any parameters. So, no need to prepare it. Signed-off-by: Pratyush Anand --- drivers/usb/dwc3/gadget.c |9 + 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c index c7f1cdb..0ac2ec3 10064

[PATCH V2 7/8] usb/dwc3: Fix scatter gather implementation

2013-01-14 Thread Pratyush Anand
To work with scatter gather properly, fixes have been done in number of functions. I will explain requirement of each fixes one by one. start_slot: used to retrieve all request of SG during cleanup dwc3_gadget_giveback: We need to skip link TRB if it was one of the intermediate TRB of SG. dwc3_p

[PATCH V2 8/8] usb/dwc3: req->queued must be forced to false in cleanup

2013-01-14 Thread Pratyush Anand
I am not sure, why I found it during SG debugging. But, I noticed that even when req_queued list was empty, there were some request in request_list having queued flag true. If I run test second time, it first removes all request from request_list and hence busy_slot was wrongly incremented. Signed

Re: [PATCH v3 1/3] usb: fsl-mxc-udc: replace cpu_is_xxx() with platform_device_id

2013-01-14 Thread Marc Kleine-Budde
On 01/14/2013 11:24 AM, Felipe Balbi wrote: > On Mon, Jan 14, 2013 at 11:18:53AM +0100, Marc Kleine-Budde wrote: >> On 01/14/2013 11:16 AM, Felipe Balbi wrote: >>> Hi, >>> >>> On Mon, Jan 14, 2013 at 06:12:39PM +0800, Peter Chen wrote: @@ -2756,22 +2753,41 @@ static int fsl_udc_otg_resume(stru

Re: [PATCH V2 1/8] usb/dwc3: Enable usb2 LPM only when connected as usb2.0

2013-01-14 Thread Felipe Balbi
Hi, On Mon, Jan 14, 2013 at 03:59:31PM +0530, Pratyush Anand wrote: > Synopsys says: > The HIRD Threshold field must be set to ‘0’ when the device core is > operating in super speed mode. > > This patch implements above statement. why move HIRD settings to another part of the code ? Patch otherw

Re: [PATCH v3 1/3] usb: fsl-mxc-udc: replace cpu_is_xxx() with platform_device_id

2013-01-14 Thread Felipe Balbi
On Mon, Jan 14, 2013 at 11:34:05AM +0100, Marc Kleine-Budde wrote: > On 01/14/2013 11:24 AM, Felipe Balbi wrote: > > On Mon, Jan 14, 2013 at 11:18:53AM +0100, Marc Kleine-Budde wrote: > >> On 01/14/2013 11:16 AM, Felipe Balbi wrote: > >>> Hi, > >>> > >>> On Mon, Jan 14, 2013 at 06:12:39PM +0800, Pe

Re: [PATCH v3 1/3] usb: fsl-mxc-udc: replace cpu_is_xxx() with platform_device_id

2013-01-14 Thread Marc Kleine-Budde
On 01/14/2013 11:39 AM, Felipe Balbi wrote: > On Mon, Jan 14, 2013 at 11:34:05AM +0100, Marc Kleine-Budde wrote: >> On 01/14/2013 11:24 AM, Felipe Balbi wrote: >>> On Mon, Jan 14, 2013 at 11:18:53AM +0100, Marc Kleine-Budde wrote: On 01/14/2013 11:16 AM, Felipe Balbi wrote: > Hi, > >>>

Re: [PATCH v3 1/3] usb: fsl-mxc-udc: replace cpu_is_xxx() with platform_device_id

2013-01-14 Thread Felipe Balbi
Hi, On Mon, Jan 14, 2013 at 11:50:41AM +0100, Marc Kleine-Budde wrote: > On 01/14/2013 11:39 AM, Felipe Balbi wrote: > > On Mon, Jan 14, 2013 at 11:34:05AM +0100, Marc Kleine-Budde wrote: > >> On 01/14/2013 11:24 AM, Felipe Balbi wrote: > >>> On Mon, Jan 14, 2013 at 11:18:53AM +0100, Marc Kleine-B

Re: [PATCH v3 1/3] usb: fsl-mxc-udc: replace cpu_is_xxx() with platform_device_id

2013-01-14 Thread Marc Kleine-Budde
On 01/14/2013 11:53 AM, Felipe Balbi wrote: > Hi, > > On Mon, Jan 14, 2013 at 11:50:41AM +0100, Marc Kleine-Budde wrote: >> On 01/14/2013 11:39 AM, Felipe Balbi wrote: >>> On Mon, Jan 14, 2013 at 11:34:05AM +0100, Marc Kleine-Budde wrote: On 01/14/2013 11:24 AM, Felipe Balbi wrote: > On M

Re: [PATCH V2 1/8] usb/dwc3: Enable usb2 LPM only when connected as usb2.0

2013-01-14 Thread Pratyush Anand
I think, Paul can comment better. What I got feedback from SNPS that if HIRD settings are programmed in SS mode, it might result in some weird issue. However, our issue was resolved with some other fix in application and this patch did not had any effect. Since SNPS suggests to follow it so I b

Re: [PATCH v3 1/3] usb: fsl-mxc-udc: replace cpu_is_xxx() with platform_device_id

2013-01-14 Thread Felipe Balbi
On Mon, Jan 14, 2013 at 12:03:04PM +0100, Marc Kleine-Budde wrote: > On 01/14/2013 11:53 AM, Felipe Balbi wrote: > > Hi, > > > > On Mon, Jan 14, 2013 at 11:50:41AM +0100, Marc Kleine-Budde wrote: > >> On 01/14/2013 11:39 AM, Felipe Balbi wrote: > >>> On Mon, Jan 14, 2013 at 11:34:05AM +0100, Marc

Re: [PATCH V2 1/8] usb/dwc3: Enable usb2 LPM only when connected as usb2.0

2013-01-14 Thread Felipe Balbi
Hi, On Mon, Jan 14, 2013 at 04:36:11PM +0530, Pratyush Anand wrote: > I think, Paul can comment better. What I got feedback from SNPS that > if HIRD settings are > programmed in SS mode, it might result in some weird issue. However, > our issue was resolved > with some other fix in application and

Re: [PATCH V2 1/8] usb/dwc3: Enable usb2 LPM only when connected as usb2.0

2013-01-14 Thread Pratyush Anand
Hi, On 1/14/2013 4:42 PM, Felipe Balbi wrote: Hi, On Mon, Jan 14, 2013 at 04:36:11PM +0530, Pratyush Anand wrote: I think, Paul can comment better. What I got feedback from SNPS that if HIRD settings are programmed in SS mode, it might result in some weird issue. However, our issue was resolve

Re: [PATCH 04/14] usb: phy: nop: Handle power supply regulator for the PHY

2013-01-14 Thread Russell King - ARM Linux
On Mon, Jan 14, 2013 at 11:54:42AM +0200, Roger Quadros wrote: > On 01/11/2013 07:17 PM, Russell King - ARM Linux wrote: > > On Thu, Jan 10, 2013 at 06:51:24PM +0200, Roger Quadros wrote: > >> We use "vcc" as the supply name for the PHY's power supply. > >> The power supply will be enabled during .

Re: [PATCH 01/14] mfd: omap-usb-host: Consolidate OMAP USB-HS platform data

2013-01-14 Thread Roger Quadros
On 01/11/2013 08:13 PM, Tony Lindgren wrote: > * Roger Quadros [130111 01:43]: >> Tony, >> >> On 01/11/2013 01:45 AM, Tony Lindgren wrote: >>> * Roger Quadros [130110 08:54]: Let's have a single platform data structure for the OMAP's High-Speed USB host subsystem instead of having 3 sep

Re: [PATCH 04/14] usb: phy: nop: Handle power supply regulator for the PHY

2013-01-14 Thread Roger Quadros
On 01/14/2013 01:25 PM, Russell King - ARM Linux wrote: > On Mon, Jan 14, 2013 at 11:54:42AM +0200, Roger Quadros wrote: >> On 01/11/2013 07:17 PM, Russell King - ARM Linux wrote: >>> On Thu, Jan 10, 2013 at 06:51:24PM +0200, Roger Quadros wrote: We use "vcc" as the supply name for the PHY's p

[PATCH v7 2/4] usb: phy: samsung: Add host phy support to samsung-phy driver

2013-01-14 Thread Vivek Gautam
This patch adds host phy support to samsung-usbphy driver and further adds support for samsung's exynos5250 usb-phy. Signed-off-by: Praveen Paneri Signed-off-by: Vivek Gautam --- Changes from v6: - Changing macro names from 'HOST_CTRL0_FSEL_CLKSEL_XX' to 'FSEL_CLKSEL_XX' since it's being us

Re: [PATCH 04/14] usb: phy: nop: Handle power supply regulator for the PHY

2013-01-14 Thread Russell King - ARM Linux
On Mon, Jan 14, 2013 at 01:51:07PM +0200, Roger Quadros wrote: > On 01/14/2013 01:25 PM, Russell King - ARM Linux wrote: > > Also consider... is dev_err() appropriate for an "error", for which you > > print a message and continue as if nothing went wrong. To me that sounds > > more like a warning

[PATCH v3 0/2] Adding USB 3.0 DRD-phy support for exynos5250

2013-01-14 Thread Vivek Gautam
Changes from v2: - Renaming 'samsung-usbphy.c' driver to 'samsung-usb2.c' indicating usb 2.0 phy controller's driver for Samsung's SoCs. - Moving the register definitions and strcuture definitions to common header file 'samsung-usbphy.h' to be used across usb 2.0 and usb 3.0 phy. - Keep

[PATCH v3 1/2] usb: phy: samsung: Common out the generic stuff

2013-01-14 Thread Vivek Gautam
Moving register and structure definitions to header file, and keeping the generic functions to be used across multiple PHYs in common file "samsung-usbphy.c". Also renaming the usb 2.0 phy driver to "samsung-usb2.c" Signed-off-by: Vivek Gautam --- drivers/usb/phy/Makefile |2 +- driv

[PATCH v3 2/2] usb: phy: samsung: Add PHY support for USB 3.0 controller

2013-01-14 Thread Vivek Gautam
Adding PHY driver support for USB 3.0 controller for Samsung's SoCs. Signed-off-by: Vivek Gautam --- drivers/usb/phy/Kconfig |8 + drivers/usb/phy/Makefile |1 + drivers/usb/phy/samsung-usb3.c | 349 ++ drivers/usb/phy/samsung-usbph

Re: [PATCH v3 1/3] usb: fsl-mxc-udc: replace cpu_is_xxx() with platform_device_id

2013-01-14 Thread Peter Chen
On Mon, Jan 14, 2013 at 01:06:00PM +0200, Felipe Balbi wrote: > On Mon, Jan 14, 2013 at 12:03:04PM +0100, Marc Kleine-Budde wrote: > > On 01/14/2013 11:53 AM, Felipe Balbi wrote: > > > Hi, > > > > > > On Mon, Jan 14, 2013 at 11:50:41AM +0100, Marc Kleine-Budde wrote: > > >> On 01/14/2013 11:39 AM,

Re: [PATCH v3 2/3] usb: fsl_mxc_udc: replace MX35_IO_ADDRESS to ioremap

2013-01-14 Thread Peter Chen
On Mon, Jan 14, 2013 at 12:17:08PM +0200, Felipe Balbi wrote: > On Mon, Jan 14, 2013 at 06:12:40PM +0800, Peter Chen wrote: > > As mach/hardware.h is deleted, we can't visit platform code at driver. > > It has no phy driver to combine with this controller, so it has to use > > ioremap to map phy ad

Re: [PATCH v3 2/3] usb: fsl_mxc_udc: replace MX35_IO_ADDRESS to ioremap

2013-01-14 Thread Russell King - ARM Linux
On Mon, Jan 14, 2013 at 06:12:40PM +0800, Peter Chen wrote: > @@ -83,15 +84,16 @@ void fsl_udc_clk_finalize(enum fsl_udc_type devtype, > struct fsl_usb2_platform_data *pdata = pdev->dev.platform_data; > if (devtype == IMX35_UDC) { > unsigned int v; > + void __i

Re: [PATCH v3 2/3] usb: fsl_mxc_udc: replace MX35_IO_ADDRESS to ioremap

2013-01-14 Thread Peter Chen
On Mon, Jan 14, 2013 at 01:10:56PM +, Russell King - ARM Linux wrote: > On Mon, Jan 14, 2013 at 06:12:40PM +0800, Peter Chen wrote: > > @@ -83,15 +84,16 @@ void fsl_udc_clk_finalize(enum fsl_udc_type devtype, > > struct fsl_usb2_platform_data *pdata = pdev->dev.platform_data; > > if (de

[PATCH v4 0/3] Fix the Build error for fsl_mxc_udc.c

2013-01-14 Thread Peter Chen
Changes for v4: - Using pdev's struct resource to do ioremap - Add ioremap return value check Changes for v3: - Split the one big patch into three patches Changes for v2: - Add const for fsl_udc_devtype - Do ioremap for phy address at fsl-mxc-udc Peter Chen (3): usb: fsl-mxc-udc: replace cpu_i

[PATCH v4 1/3] usb: fsl-mxc-udc: replace cpu_is_xxx() with platform_device_id

2013-01-14 Thread Peter Chen
As mach/hardware.h is deleted, we need to use platform_device_id to differentiate SoCs. Besides we update the platform code accordingly. Signed-off-by: Peter Chen --- arch/arm/mach-imx/devices/devices-common.h|1 + arch/arm/mach-imx/devices/platform-fsl-usb2-udc.c | 15 +++--- dri

[PATCH v4 2/3] usb: fsl_mxc_udc: replace MX35_IO_ADDRESS to ioremap

2013-01-14 Thread Peter Chen
As mach/hardware.h is deleted, we can't visit platform code at driver. It has no phy driver to combine with this controller, so it has to use ioremap to map phy address as a workaround. Signed-off-by: Peter Chen --- drivers/usb/gadget/fsl_mxc_udc.c | 27 +-- drivers/us

[PATCH v4 3/3] ARM: i.MX clock: Change the connection-id for fsl-usb2-udc

2013-01-14 Thread Peter Chen
As we use platform_device_id for fsl-usb2-udc driver, it needs to change clk connection-id, or the related devm_clk_get will be failed. Signed-off-by: Peter Chen --- arch/arm/mach-imx/clk-imx25.c |6 +++--- arch/arm/mach-imx/clk-imx27.c |6 +++--- arch/arm/mach-imx/clk-imx31.

Re: [PATCH V2 1/8] usb/dwc3: Enable usb2 LPM only when connected as usb2.0

2013-01-14 Thread Felipe Balbi
On Mon, Jan 14, 2013 at 04:52:58PM +0530, Pratyush Anand wrote: > Hi, > > On 1/14/2013 4:42 PM, Felipe Balbi wrote: > >Hi, > > > >On Mon, Jan 14, 2013 at 04:36:11PM +0530, Pratyush Anand wrote: > >>I think, Paul can comment better. What I got feedback from SNPS that > >>if HIRD settings are > >>pr

Re: USB issue with kernel 3.6

2013-01-14 Thread Alan Stern
On Sun, 13 Jan 2013, Piergiorgio Sartor wrote: > Hi Alan, > > Happy New Year! I hope you had a good holiday break. > I removed the previous short patch to ehci-q.c and applied > this second one. > > After some extensive testing, I could not reproduce the > issue and dmesg showed the ususl "asy

Re: [Patch] Problem in drivers/usb/serial/io_ti - Kernel oops when disconnecting an opened device

2013-01-14 Thread Johan Hovold
On Thu, Jan 03, 2013 at 11:21:08PM +0100, Wolfgang Frisch wrote: > The attached patch fixes the symptom. > > The NULL dereference is caused by "chase_port" in > drivers/usb/serial/io_ti.c as tty == NULL. > Unfortunately I'm not familiar with the usb-serial system. > I guess the tty is already clea

[PATCH 1/5] USB: io_ti: move write-fifo flushing to close

2013-01-14 Thread Johan Hovold
Move write-fifo flushing from chase_port to close where it belongs. Signed-off-by: Johan Hovold --- drivers/usb/serial/io_ti.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/usb/serial/io_ti.c b/drivers/usb/serial/io_ti.c index 58184f3..596f8c9 100644

[PATCH 0/5] USB: io-ti: remove custom closing-wait implementation

2013-01-14 Thread Johan Hovold
Replace custom closing-wait implementation with the corresponding generic implementations. This fixes a null-pointer deref on close as well as access to USB interface after disconnect. Greg, I asked Wolfgang to resubmit his minimal patch for the oops as it is more appropriate for the stable trees

[PATCH 3/5] USB: serial: grab disconnect mutex in chars_in_buffer

2013-01-14 Thread Johan Hovold
Grab disconnect mutex in chars_in_buffer before checking disconnected flag or calling driver specific function. This allows subdrivers to query any hardware buffer status without having to handle the locking themselves. Signed-off-by: Johan Hovold --- drivers/usb/serial/usb-serial.c | 14 ++

[PATCH 4/5] USB: io_ti: query hardware-buffer status in chars_in_buffer

2013-01-14 Thread Johan Hovold
Query hardware-buffer status in chars_in_buffer should the write fifo be empty. This is needed to make the tty layer wait for hardware buffers to drain on close. Signed-off-by: Johan Hovold --- drivers/usb/serial/io_ti.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/usb/ser

[PATCH 2/5] USB: io_ti: use tty-port drain delay

2013-01-14 Thread Johan Hovold
Use tty-port drain delay rather than custom implementation in chase_port. Signed-off-by: Johan Hovold --- drivers/usb/serial/io_ti.c | 14 ++ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/drivers/usb/serial/io_ti.c b/drivers/usb/serial/io_ti.c index 596f8c9..3abbdaa

[PATCH 5/5] USB: io_ti: kill custom closing_wait implementation

2013-01-14 Thread Johan Hovold
Kill custom closing_wait implementation and let the tty layer handle it instead. Signed-off-by: Johan Hovold --- drivers/usb/serial/io_ti.c | 57 -- 1 file changed, 9 insertions(+), 48 deletions(-) diff --git a/drivers/usb/serial/io_ti.c b/drivers/usb

Re: USB device cannot be reconnected and khubd "blocked for more than 120 seconds"

2013-01-14 Thread Alex Riesen
On Mon, Jan 14, 2013 at 3:39 AM, Alan Stern wrote: > On Sun, 13 Jan 2013, Oliver Neukum wrote: >> This is not a USB problem. You need to involve the SCSI people. >> khubd just stops working because disconnects are processed >> in its context and the removal deadlocks. > > The why whould building t

Re: [PATCH] CDC_NCM adding support IFF_NOARP for infineon modem platform

2013-01-14 Thread Dan Williams
On Sat, 2013-01-12 at 15:35 -0800, David Miller wrote: > From: Wei Shuai > Date: Sat, 12 Jan 2013 19:34:39 +0800 > > > Infineon(now Intel) HSPA Modem platform NCM cannot support ARP. so I > > introduce a flag CDC_NCM_DRIVER_DATA_NOARP which is defined in > > driver_info:data. so later on, if more

Re: [PATCH 01/14] mfd: omap-usb-host: Consolidate OMAP USB-HS platform data

2013-01-14 Thread Tony Lindgren
* Roger Quadros [130114 03:31]: > On 01/11/2013 08:13 PM, Tony Lindgren wrote: > > * Roger Quadros [130111 01:43]: > >> Tony, > >> > >> On 01/11/2013 01:45 AM, Tony Lindgren wrote: > >>> * Roger Quadros [130110 08:54]: > Let's have a single platform data structure for the OMAP's High-Speed

Re: USB device cannot be reconnected and khubd "blocked for more than 120 seconds"

2013-01-14 Thread Linus Torvalds
On Sun, Jan 13, 2013 at 11:15 PM, Ming Lei wrote: > > The deadlock problem is caused by calling request_module() inside > async function of do_scan_async(), and it was introduced by Linus's > below commit: > > commit d6de2c80e9d758d2e36c21699117db6178c0f517 > Author: Linus Torvalds > Date: Fri

Re: USB issue with kernel 3.6

2013-01-14 Thread Piergiorgio Sartor
Hi Alan, On Mon, Jan 14, 2013 at 10:17:52AM -0500, Alan Stern wrote: > On Sun, 13 Jan 2013, Piergiorgio Sartor wrote: > > > Hi Alan, > > > > Happy New Year! > > I hope you had a good holiday break. thanks, holiday was fine, I trust you had some rest too. [...] > > Next step? > > Okay, I figu

Re: close blocks, if FIFO full on gagdet serial

2013-01-14 Thread Dan Williams
On Sun, 2013-01-13 at 20:09 +0100, mas...@georadis.com wrote: > Hello guys, > I've found a following problems on BeagleBoard and Kernel 3.0.8 with > gadget serial driver. > > Attached is a small program, which opens gadget serial tty at > /dev/ttyGS0. USB is NOT connected to host. Then it fills

Re: [PATCH v3 1/3] usb: fsl-mxc-udc: replace cpu_is_xxx() with platform_device_id

2013-01-14 Thread Felipe Balbi
Hi, On Mon, Jan 14, 2013 at 08:56:33PM +0800, Peter Chen wrote: > > > Usually there isn't any Changelog between IP cores used in the different > > > fsl processors (at least available outside of fsl), that makes it quite > > > difficult to say if something found on one imx is really the same as

Re: [PATCH 1/2] usbnet: allow status interrupt URB to always be active

2013-01-14 Thread Dan Williams
On Sat, 2013-01-05 at 12:01 +0100, Oliver Neukum wrote: > On Friday 04 January 2013 19:26:33 Dan Williams wrote: > > On Fri, 2013-01-04 at 23:16 +0100, Oliver Neukum wrote: > > > On Friday 04 January 2013 10:48:16 Dan Williams wrote: > > > > Some drivers (ex sierra_net) need the status interrupt UR

Re: [PATCH 1/2] usbnet: allow status interrupt URB to always be active

2013-01-14 Thread Dan Williams
On Fri, 2013-01-11 at 11:06 +0800, Ming Lei wrote: > On Sat, Jan 5, 2013 at 9:26 AM, Dan Williams wrote: > > On Fri, 2013-01-04 at 23:16 +0100, Oliver Neukum wrote: > >> On Friday 04 January 2013 10:48:16 Dan Williams wrote: > >> > Some drivers (ex sierra_net) need the status interrupt URB > >> >

Re: close blocks, if FIFO full on gagdet serial

2013-01-14 Thread Felipe Balbi
Hi, On Sun, Jan 13, 2013 at 08:09:14PM +0100, mas...@georadis.com wrote: > Hello guys, > I've found a following problems on BeagleBoard and Kernel 3.0.8 with > gadget serial driver. > > Attached is a small program, which opens gadget serial tty at > /dev/ttyGS0. USB is NOT connected to host. Then

Re: [PATCH v3 1/3] usb: fsl-mxc-udc: replace cpu_is_xxx() with platform_device_id

2013-01-14 Thread Marc Kleine-Budde
On 01/14/2013 06:40 PM, Felipe Balbi wrote: > Hi, > > On Mon, Jan 14, 2013 at 08:56:33PM +0800, Peter Chen wrote: > > > Usually there isn't any Changelog between IP cores used in the different fsl processors (at least available outside of fsl), that makes it quite difficult to sa

Re: [PATCH v3 1/3] usb: fsl-mxc-udc: replace cpu_is_xxx() with platform_device_id

2013-01-14 Thread Felipe Balbi
On Mon, Jan 14, 2013 at 06:54:22PM +0100, Marc Kleine-Budde wrote: > On 01/14/2013 06:40 PM, Felipe Balbi wrote: > > Hi, > > > > On Mon, Jan 14, 2013 at 08:56:33PM +0800, Peter Chen wrote: > > > > > > > Usually there isn't any Changelog between IP cores used in the different > fsl pro

Re: USB device cannot be reconnected and khubd "blocked for more than 120 seconds"

2013-01-14 Thread Alan Stern
On Mon, 14 Jan 2013, Linus Torvalds wrote: > > - from view of driver, introducing async_synchronize_full() after > > do_one_initcall() inside do_init_module() is like a sync probe > > for drivers built as module, and cause this kind of deadlock easily. > > > > So could we revert the commit and fix

Re: [PATCH] CDC_NCM adding support IFF_NOARP for infineon modem platform

2013-01-14 Thread David Miller
From: Dan Williams Date: Mon, 14 Jan 2013 11:19:13 -0600 > On Sat, 2013-01-12 at 15:35 -0800, David Miller wrote: >> From: Wei Shuai >> Date: Sat, 12 Jan 2013 19:34:39 +0800 >> >> > Infineon(now Intel) HSPA Modem platform NCM cannot support ARP. so I >> > introduce a flag CDC_NCM_DRIVER_DATA_NO

Re: USB device cannot be reconnected and khubd "blocked for more than 120 seconds"

2013-01-14 Thread Linus Torvalds
On Mon, Jan 14, 2013 at 10:04 AM, Alan Stern wrote: > > How about skipping that call if the current thread is one of the async > helpers? Is it possible to detect when that happens? > > Or maybe such a check should go inside async_synchronize_full() itself. Do we have some idea of exactly what i

[PATCH] USB: prevent overlapping access by usb-storage and usbfs

2013-01-14 Thread Sergei Shtylyov
Serialize usb-storage operations with usbfs and 'cat /proc/bus/usb/devices', so that they cannot disturb storage by seemingly harmless control reads. This patch was adapted from 2.4.28 patch by Pete Zaitcev -- which I even had to reconstruct as I have never found it in its final form. That patch

Re: [PATCH] USB: prevent overlapping access by usb-storage and usbfs

2013-01-14 Thread Sergei Shtylyov
Hello. On 01/14/2013 11:36 PM, Sergei Shtylyov wrote: > Serialize usb-storage operations with usbfs and 'cat /proc/bus/usb/devices', > so that they cannot disturb storage by seemingly harmless control reads. > This patch was adapted from 2.4.28 patch by Pete Zaitcev -- which I even had > to > r

Re: [PATCH] USB: prevent overlapping access by usb-storage and usbfs

2013-01-14 Thread Alan Stern
On Mon, 14 Jan 2013, Sergei Shtylyov wrote: > Serialize usb-storage operations with usbfs and 'cat /proc/bus/usb/devices', > so that they cannot disturb storage by seemingly harmless control reads. > > This patch was adapted from 2.4.28 patch by Pete Zaitcev -- which I even had > to > reconstruc

Re: [PATCH] USB: prevent overlapping access by usb-storage and usbfs

2013-01-14 Thread Greg KH
On Mon, Jan 14, 2013 at 11:42:09PM +0300, Sergei Shtylyov wrote: > Hello. > > On 01/14/2013 11:36 PM, Sergei Shtylyov wrote: > > > Serialize usb-storage operations with usbfs and 'cat /proc/bus/usb/devices', > > so that they cannot disturb storage by seemingly harmless control reads. > > > This

Re: [PATCH v9] usb_8dev: Add support for USB2CAN interface from 8 devices

2013-01-14 Thread Oliver Hartkopp
Hi Bernd, On 16.12.2012 08:01, Bernd Krumboeck wrote: > Add device driver for USB2CAN interface from "8 devices" > (http://www.8devices.com). > > changes since v8: > * remove all sysfs files > > changes since v7: > * add sysfs documentation > * fix minor styling issue > * fixed can state for p

Re: xhci problem

2013-01-14 Thread Sarah Sharp
On Sun, Jan 13, 2013 at 09:34:58AM -0500, Allan Dennis wrote: > I left this problem for awhile, then finally got back to it. I upgraded > the gentoo kernel to 3.6.11 and was partially successful: the 3TB drive > mounted ok, but then had some serious trouble transferring files and I > believe that l

Re: [PATCH] usb: phy: samsung: Add support to set pmu isolation

2013-01-14 Thread Doug Anderson
Vivek, Sorry for being so absent from these reviews. I'll try to look over a few patches today, but please don't hold up anything on account of my reviews. I'm definitely a bit of an interested bystander in USB land. ;) In general things look pretty good here. :) One last comment below... O

Re: [PATCH v5 2/4] usb: phy: samsung: Add host phy support to samsung-phy driver

2013-01-14 Thread Doug Anderson
Vivek, On Mon, Jan 14, 2013 at 12:06 AM, Vivek Gautam wrote: >> Is it fine if we don't use macro for SHIFT, earlier code also doesn't use it. >> Can we just do like this .. >> #define HOST_CTRL0_FSEL_MASK (0x7 << 16) >> #define HOST_CTRL0_FSEL_CLKSEL_50M(0x7 <<

Re: [PATCH] CDC_NCM adding support IFF_NOARP for infineon modem platform

2013-01-14 Thread Peter Stuge
David Miller wrote: > > should all WWAN drivers be moved to only POINTTOPOINT? > > I can't answer any of your questions unless you tell me what the > real limitation of these devices is. It's rather about the network than any given devices, right? //Peter -- To unsubscribe from this list: send

Re: [Resend PATCH V4 0/10] usb: usb port power off mechanism anc expose usb port connect type

2013-01-14 Thread Lan Tianyu
On 2013年01月11日 20:10, Lan Tianyu wrote: > Change since v1: >optimize the export connect type patch and adjust the DeviceRemovalbe > flag > in the rh_call_control() after GetHubDescriptor request being processed. >move all debounce operation to usb port's runtime resume callback().

Re: [PATCH 1/2] usbnet: allow status interrupt URB to always be active

2013-01-14 Thread Ming Lei
On Tue, Jan 15, 2013 at 1:23 AM, Dan Williams wrote: > On Fri, 2013-01-11 at 11:06 +0800, Ming Lei wrote: >> I am curious who are interested in the 'custom Restart indication' >> information after the interface is closed. > > It's actually before the interface is even opened. It's really just a >

Re: [PATCH v3 1/3] usb: fsl-mxc-udc: replace cpu_is_xxx() with platform_device_id

2013-01-14 Thread Peter Chen
On Mon, Jan 14, 2013 at 07:57:24PM +0200, Felipe Balbi wrote: > On Mon, Jan 14, 2013 at 06:54:22PM +0100, Marc Kleine-Budde wrote: > > On 01/14/2013 06:40 PM, Felipe Balbi wrote: > > > Hi, > > > > > > On Mon, Jan 14, 2013 at 08:56:33PM +0800, Peter Chen wrote: > > > > > > > > > > > Usually

Re: USB device cannot be reconnected and khubd "blocked for more than 120 seconds"

2013-01-14 Thread Ming Lei
On Tue, Jan 15, 2013 at 1:30 AM, Linus Torvalds wrote: > On Sun, Jan 13, 2013 at 11:15 PM, Ming Lei wrote: >> >> The deadlock problem is caused by calling request_module() inside >> async function of do_scan_async(), and it was introduced by Linus's >> below commit: >> >> commit d6de2c80e9d758d2e

[PATCH v5 0/3] Fix the Build error for fsl_mxc_udc.c

2013-01-14 Thread Peter Chen
Changes for v5: - Using strcmp to get specific SoC - Delete one cpu_is_mx35() as it has already pdata runtime check Changes for v4: - Using pdev's struct resource to do ioremap - Add ioremap return value check Changes for v3: - Split the one big patch into three patches Changes for v2: - Add con

[PATCH v5 1/3] usb: fsl-mxc-udc: replace cpu_is_xxx() with platform_device_id

2013-01-14 Thread Peter Chen
As mach/hardware.h is deleted, we need to use platform_device_id to differentiate SoCs. Besides, one cpu_is_mx35 is useless as it has already used pdata to differentiate runtime Meanwhile we update the platform code accordingly. Signed-off-by: Peter Chen --- arch/arm/mach-imx/devices/devices-co

[PATCH v5 2/3] usb: fsl_mxc_udc: replace MX35_IO_ADDRESS to ioremap

2013-01-14 Thread Peter Chen
As mach/hardware.h is deleted, we can't visit platform code at driver. It has no phy driver to combine with this controller, so it has to use ioremap to map phy address as a workaround. Signed-off-by: Peter Chen --- drivers/usb/gadget/fsl_mxc_udc.c | 30 +++--- drivers

[PATCH v5 3/3] ARM: i.MX clock: Change the connection-id for fsl-usb2-udc

2013-01-14 Thread Peter Chen
As we use platform_device_id for fsl-usb2-udc driver, it needs to change clk connection-id, or the related devm_clk_get will be failed. Signed-off-by: Peter Chen --- arch/arm/mach-imx/clk-imx25.c |6 +++--- arch/arm/mach-imx/clk-imx27.c |6 +++--- arch/arm/mach-imx/clk-imx31.

[PATCH] HID: add support for Sony RF receiver with USB product id 0x0374

2013-01-14 Thread Fernando Luis Vázquez Cao
Some Vaio desktop computers, among them the VGC-LN51JGB multimedia PC, have a RF receiver, multi-interface USB device 054c:0374, that is used to connect a wireless keyboard and a wireless mouse. The keyboard works flawlessly, but the mouse (VGP-WMS3 in my case) does not seem to be generating any p

Re: [PATCH] usb: phy: samsung: Add support to set pmu isolation

2013-01-14 Thread Vivek Gautam
Hi Doug, On Tue, Jan 15, 2013 at 3:41 AM, Doug Anderson wrote: > Vivek, > > Sorry for being so absent from these reviews. I'll try to look over a > few patches today, but please don't hold up anything on account of my > reviews. I'm definitely a bit of an interested bystander in USB land. > ;

[PATCH] usbnet: dm9601: Fix incorrect command

2013-01-14 Thread Tushar Behera
commit 24b1042c4eb2 ("usbnet: dm9601: apply introduced usb command APIs") removes the distiction between DM_WRITE_REG and DM_WRITE_REGS command. The distiction is reintroduced to the driver so that the functionality of the driver remains same. CC: Ming Lei Signed-off-by: Tushar Behera --- drive

RE: [PATCH V2 1/8] usb/dwc3: Enable usb2 LPM only when connected as usb2.0

2013-01-14 Thread Paul Zimmerman
> From: Pratyush Anand [mailto:pratyush.an...@st.com] > Sent: Monday, January 14, 2013 2:30 AM > > Synopsys says: > The HIRD Threshold field must be set to ‘0’ when the device core is > operating in super speed mode. > > This patch implements above statement. > > Signed-off-by: Pratyush Anand >

[PATCH v7] usb: phy: samsung: Add support to set pmu isolation

2013-01-14 Thread Vivek Gautam
Adding support to parse device node data in order to get required properties to set pmu isolation for usb-phy. Signed-off-by: Vivek Gautam Reviewed-by: Sylwester Nawrocki Reviewed-by: Doug Anderson --- Changes from v6: - Returning error code in samsung_usbphy_parse_dt() when 'usbphy-sys' s

  1   2   >