Re: [PATCH v4 3/7] usb: chipidea: add otg id switch and vbus connect/disconnect detect

2012-12-27 Thread Peter Chen
On Thu, Dec 27, 2012 at 08:21:55AM +0100, Marek Vasut wrote: > Dear Peter Chen, > > [...] > > + > > +#define CI_VBUS_STABLE_TIMEOUT 500 > > Shall we not change this to static const int instead ? Is it a must? I find the similar at drivers/usb/core/hub.c 2433 #define PORT_RESET_TRIES5 243

Re: [PATCH v4 3/7] usb: chipidea: add otg id switch and vbus connect/disconnect detect

2012-12-27 Thread Marek Vasut
Dear Peter Chen, > On Thu, Dec 27, 2012 at 08:21:55AM +0100, Marek Vasut wrote: > > Dear Peter Chen, > > > > [...] > > > > > + > > > +#define CI_VBUS_STABLE_TIMEOUT 500 > > > > Shall we not change this to static const int instead ? > > Is it a must? > I find the similar at drivers/usb/core/hub

Re: [PATCH v4] usb: phy: samsung: Add support to set pmu isolation

2012-12-27 Thread Vivek Gautam
Hi Russell, On Thu, Dec 27, 2012 at 5:56 AM, Russell King - ARM Linux wrote: > On Wed, Dec 26, 2012 at 05:58:32PM +0530, Vivek Gautam wrote: >> + if (!ret) >> + sphy->phyctrl_pmureg = ioremap(reg[0], reg[1]); >> + >> + of_node_put(usbphy_pmu); >> + >> + if (IS_ERR_OR_NULL

Re: [PATCH v4 2/7] usb: chipidea: add otg file

2012-12-27 Thread Sascha Hauer
On Thu, Dec 27, 2012 at 02:59:58PM +0800, Peter Chen wrote: > Implement struct usb_otg, In that way, calling otg_set_peripheral > will not be failed at udc.c. > > Signed-off-by: Peter Chen > --- > Changes for v4: > - Some tiny changes, like delete unused header files > > drivers/usb/chipidea/Ma

Re: [PATCH v4] usb: phy: samsung: Add support to set pmu isolation

2012-12-27 Thread Vivek Gautam
Hi Sylwester, On Thu, Dec 27, 2012 at 4:00 AM, Sylwester Nawrocki wrote: > On 12/26/2012 01:28 PM, Vivek Gautam wrote: >> >> Adding support to parse device node data in order to get >> required properties to set pmu isolation for usb-phy. >> >> Signed-off-by: Vivek Gautam >> --- >> .../devicet

Re: [PATCH 2/2] USB: ehci-s5p: Add to get interrupt from DT

2012-12-27 Thread Dongjin Kim
Hi Sergei, Yes, you are right. I made this patch to read its interrupt number from dtb directly. But now platform_get_irq() returns correct irq since "OF_DEV_AUXDATA(...)" is added as my first patch. This patch is useless. Thanks and best regards, Dongjin. On Thu, Dec 27, 2012 at 5:18 AM, Serge

Re: Regression in kernel 3.8-rc1 bisected to commit adfa79d: I now get many "unable to enumerate USB device" messages

2012-12-27 Thread Larry Finger
On 12/26/2012 09:56 PM, Alan Stern wrote: This looks like a matter of getting modules to load in the right order. Apparently your OHCI controller doesn't work right if the EHCI driver isn't present. Before the troublesome commit, this meant ehci-hcd had to be loaded before ohci-hcd. Now it mean

Re: [PATCH v3 0/3] ARM: dts: omap: add dt data for MUSB

2012-12-27 Thread Aaro Koskinen
Hi, On Thu, Sep 20, 2012 at 05:21:15AM +0200, Benoit Cousson wrote: > On 09/19/2012 11:32 AM, Kishon Vijay Abraham I wrote: > > This patch series adds dt data to get MUSB working in omap4 and omap3 > > > > Changes from v2: > > * Changes the subject of all the patches to include "ARM: dts:" > > *

Re: BUG: usb ports freeze with 0471:206c Philips (or NXP) MCE IR Receiver - Spinel plusf0r ASUS connected at boot time

2012-12-27 Thread Eugene Lipchansky
Hi guys, Does anyone have any ideas about this problem yet? Did anyone even see this message?:) I'm sorry for capturing your attention but I'm not even sure if I'm right posting this bug here. Is it correct place? Or is there some bug tracker I could use? Any additional info required? I'd perform

Re: Regression in kernel 3.8-rc1 bisected to commit adfa79d: I now get many "unable to enumerate USB device" messages

2012-12-27 Thread Alan Stern
On Thu, 27 Dec 2012, Larry Finger wrote: > I could not do exactly the experiment that you wanted, as ehci-hcd was loaded > even though it was blacklisted. Rather than solve that problem, I generated a > kernel from just before commit adfa79d with ohci-hcd built in and ehci-hcd as > a > module.

Re: help with dummy_hcd and g_zero

2012-12-27 Thread Alan Stern
Questions like this should always be posted to the linux-usb mailing list. On Thu, 27 Dec 2012, Dan Clapp wrote: > Hello Alan, > > First, let me start by thanking you for supplying you code. I > appreciate it. I think this is the way we would like to go to test our > system before we actual

Re: Regression in kernel 3.8-rc1 bisected to commit adfa79d: I now get many "unable to enumerate USB device" messages

2012-12-27 Thread Larry Finger
On 12/27/2012 05:18 PM, Alan Stern wrote: On Thu, 27 Dec 2012, Larry Finger wrote: I could not do exactly the experiment that you wanted, as ehci-hcd was loaded even though it was blacklisted. Rather than solve that problem, I generated a kernel from just before commit adfa79d with ohci-hcd bui

Re: How to add USB device ID

2012-12-27 Thread Kevin K
On 12/21/12 10:22 PM, "Greg KH" wrote: >On Fri, Dec 21, 2012 at 05:54:33PM -0600, Kevin K wrote: >> I use an USB device that looks like a serial port to the kernel. >>However, >> since the Device ID is unknown, I have to either modprobe usbserial with >> the vendor/id codes as parameters, or mo

Re: Bug#677472: [3.1->3.2 regression] Immediate wake on suspend, associated with OHCI on MCP51

2012-12-27 Thread Alan Stern
On Wed, 26 Dec 2012, Octavio Alvarez wrote: > >> It can't hurt to try the test. Does the patch below make any > >> difference? > > > > Thank you for the patch, but it makes no difference. :( Too bad. > I looked for more instances of "linux immediate wakeup" and found > interesting links. They a

Re: [PATCH v4 2/7] usb: chipidea: add otg file

2012-12-27 Thread Peter Chen
On Thu, Dec 27, 2012 at 11:47:58AM +0100, Sascha Hauer wrote: > On Thu, Dec 27, 2012 at 02:59:58PM +0800, Peter Chen wrote: > > struct ci13xxx { > > struct device *dev; > > @@ -164,6 +165,7 @@ struct ci13xxx { > > boolglobal_phy; > > struct