[PATCH v3] usb: phy: samsung: Add support to set pmu isolation

2012-12-21 Thread Vivek Gautam
Changes from v2: - Removed the phandle type of device node properties, instead using sub-nodes now. - Removed the property 'samsung,enable-mask' since it is SoC dependent (SoCs like S5PV210 and S3C64XX have different bits to enable/disable phy controller in comparison to exysno4210 onwar

[PATCH v3] usb: phy: samsung: Add support to set pmu isolation

2012-12-21 Thread Vivek Gautam
Adding support to parse device node data in order to get required properties to set pmu isolation for usb-phy. Signed-off-by: Vivek Gautam --- .../devicetree/bindings/usb/samsung-usbphy.txt | 28 drivers/usb/phy/samsung-usbphy.c | 145 +--- 2 files c

Re: [PATCH 0/2] usb: exynos: Fix compatible strings used for device

2012-12-21 Thread Vivek Gautam
Hi all, On Wed, Dec 19, 2012 at 7:16 PM, Vivek Gautam wrote: > CC: Doug Anderson > > > On Sat, Dec 15, 2012 at 12:50 PM, Grant Likely > wrote: >> On Thu, 13 Dec 2012 20:22:26 +0530, Vivek Gautam >> wrote: >>> Using chip specific compatible string as it should be. >>> So fixing this for ehci-s

Re: [PATCH v3 1/2] ARM: Exynos5250: Enabling ehci-s5p driver

2012-12-21 Thread Vivek Gautam
Hi all, On Wed, Dec 19, 2012 at 7:20 PM, Vivek Gautam wrote: > CC: Doug Anderson > > > On Sat, Dec 15, 2012 at 12:53 PM, Grant Likely > wrote: >> On Thu, 13 Dec 2012 22:06:01 +0530, Vivek Gautam >> wrote: >>> Adding EHCI device tree node for Exynos5250 along with >>> the device base adress an

Re: [PATCH] arm/davinci/musb: fix mispint introduced by commit 032ec49f5351e9cb242b1a1c367d14415043ab95

2012-12-21 Thread Felipe Balbi
On Fri, Dec 21, 2012 at 01:59:06AM +0400, Mikhail Kshevetskiy wrote: please respin this patch with a real commit log. > Signed-off-by: Mikhail Kshevetskiy > --- > drivers/usb/musb/da8xx.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/musb/da8xx.c b/dri

Re: 3.7 kernel hangs when doing scp

2012-12-21 Thread Fabio Estevam
Hi Peter, On Fri, Dec 21, 2012 at 12:22 AM, Peter Chen wrote: > Current chipidea driver only considers disable stream mode at device > mode, in fact, it may be related to below chipidea bug, and needs > to consider all usb modes. > > STAR 9000378958 > Title: Non-Double Word Aligned Buffer Addres

Re: [PATCH] usb: phy: samsung: Add support for USB 3.0 phy for exynos5250

2012-12-21 Thread Vivek Gautam
Hi Felipe, On Wed, Dec 19, 2012 at 1:25 PM, Felipe Balbi wrote: > Hi, > > On Wed, Dec 19, 2012 at 11:52:01AM +0530, Vivek Gautam wrote: >> >>> @@ -736,7 +1035,41 @@ static int __devinit samsung_usbphy_probe(struct >> >>> platform_device *pdev) >> >>> >> >>> sphy->clk = clk; >> >>> >> >>>

Re: 3.7 kernel hangs when doing scp

2012-12-21 Thread Wolfram Sang
On Fri, Dec 21, 2012 at 07:24:14AM -0200, Fabio Estevam wrote: > Hi Peter, > > On Fri, Dec 21, 2012 at 12:22 AM, Peter Chen wrote: > > > Current chipidea driver only considers disable stream mode at device > > mode, in fact, it may be related to below chipidea bug, and needs > > to consider all

Re: 3.7 kernel hangs when doing scp

2012-12-21 Thread Fabio Estevam
On Fri, Dec 21, 2012 at 9:49 AM, Wolfram Sang wrote: >> Yes, setting CI13XXX_DISABLE_STREAMING inside ci_role_start does work. >> >> If you think the patch below is fine I can properly submit it. > > Why did you need to move this function? Only to make the compiler happy. hw_write() is now used

Re: 3.7 kernel hangs when doing scp

2012-12-21 Thread Wolfram Sang
> Only to make the compiler happy. hw_write() is now used by > ci_role_start(), so I re-ordered so that hw_write comes first in the > code and compiler does not complain. Yup, spotted this on second glance. If you submit the patch, might be helpful to mention this. -- Pengutronix e.K.

[PATCH] usb: chipidea: Allow disabling streaming not only in udc mode

2012-12-21 Thread Fabio Estevam
From: Fabio Estevam When running a scp transfer using a USB/Ethernet adapter the following crash happens: $ scp test.tar.gz fabio@192.168.1.100:/home/fabio fabio@192.168.1.100's password: test.tar.gz 0%0 0.0KB/s --:-- ETA [ cut here ]---

Re: Remove CONFIG_USB_SUSPEND?

2012-12-21 Thread Greg KH
On Fri, Dec 21, 2012 at 01:21:18PM +0800, Peter Chen wrote: > On Thu, Dec 20, 2012 at 08:55:33PM -0800, Greg KH wrote: > > On Fri, Dec 21, 2012 at 12:28:38PM +0800, Peter Chen wrote: > > > On Tue, Dec 18, 2012 at 11:11:15AM -0500, Alan Stern wrote: > > > > I suggest that we remove the CONFIG_USB_SU

Re: Bug#677472: [3.1->3.2 regression] Immediate wake on suspend, associated with OHCI on MCP51

2012-12-21 Thread Frank Schäfer
Am 21.12.2012 01:59, schrieb Alan Stern: > On Thu, 20 Dec 2012, Frank Schäfer wrote: > >>> Yes runtime suspend works (tested with a mouse) and lspci -vv doesn't >>> change. >>> >>> With >>> /sys/devices/pci:00/:00:02.0/usb2/2-9/power: >>> control = on >>> runtime_status = active >>> >>> 00:

Re: Remove CONFIG_USB_SUSPEND?

2012-12-21 Thread Alan Stern
On Fri, 21 Dec 2012, Greg KH wrote: > On Fri, Dec 21, 2012 at 01:21:18PM +0800, Peter Chen wrote: > > On Thu, Dec 20, 2012 at 08:55:33PM -0800, Greg KH wrote: > > > On Fri, Dec 21, 2012 at 12:28:38PM +0800, Peter Chen wrote: > > > > On Tue, Dec 18, 2012 at 11:11:15AM -0500, Alan Stern wrote: > > >

Re: Bug#677472: [3.1->3.2 regression] Immediate wake on suspend, associated with OHCI on MCP51

2012-12-21 Thread Alan Stern
On Fri, 21 Dec 2012, Frank Schäfer wrote: > > The lspci output above shows that the host controller is _not_ > > suspended. Or at least, that's what it looks like -- maybe for some > > reason the runtime suspend code didn't put the controller into D3. > > Yes, but I checked > /sys/devices/pc

Re: Can you take a look the echi log?

2012-12-21 Thread Alan Stern
Problems like this should always be sent to the mailing list. On Fri, 21 Dec 2012, Kuo Shou-Chien wrote: > Hi Alan, > > Can you help take a look the log and suggest me where I can start trouble > shooting? > The usb communication stops at root hub suspend.� > I plugged in the barcode code reade

Re: [PATCH v3] usb: phy: samsung: Add support to set pmu isolation

2012-12-21 Thread Doug Anderson
Vivek, Nothing really serious below and things look good to me, but figured I'd put a few nits in (sorry!). On Fri, Dec 21, 2012 at 12:16 AM, Vivek Gautam wrote: > diff --git a/Documentation/devicetree/bindings/usb/samsung-usbphy.txt > b/Documentation/devicetree/bindings/usb/samsung-usbphy.txt

Re: [PATCH 0/2] usb: exynos: Fix compatible strings used for device

2012-12-21 Thread Doug Anderson
On Fri, Dec 21, 2012 at 12:14 AM, Vivek Gautam wrote: > On Wed, Dec 19, 2012 at 7:16 PM, Vivek Gautam > wrote: >> >> On Sat, Dec 15, 2012 at 12:50 PM, Grant Likely >> wrote: >>> On Thu, 13 Dec 2012 20:22:26 +0530, Vivek Gautam >>> wrote: Using chip specific compatible string as it should

Re: [PATCH v3 1/2] ARM: Exynos5250: Enabling ehci-s5p driver

2012-12-21 Thread Doug Anderson
Vivek, On Fri, Dec 21, 2012 at 12:16 AM, Vivek Gautam wrote: > Hi all, > > > On Wed, Dec 19, 2012 at 7:20 PM, Vivek Gautam > wrote: >> CC: Doug Anderson >> >> >> On Sat, Dec 15, 2012 at 12:53 PM, Grant Likely >> wrote: >>> On Thu, 13 Dec 2012 22:06:01 +0530, Vivek Gautam >>> wrote: dif

Re: [PATCH v3] usb: phy: use kzalloc to allocate struct tegra_usb_phy

2012-12-21 Thread Stephen Warren
On 12/20/2012 11:34 PM, Venu Byravarasu wrote: > Use kzalloc instead of kmalloc to allocate struct tegra_usb_phy. > This ensures that all function pointers in member u_phy are > initialized to NULL. Seems fine to me. For the record, I'd like to take this through the Tegra tree with all the other T

Re: [PATCH] usb: tegra: Removing dependency on PHY instance number

2012-12-21 Thread Stephen Warren
On 12/20/2012 11:58 PM, Venu Byravarasu wrote: > Tegra2 has two varieties of USB PHYs: > Instance 0 - legacy PHY interface and > Instace 1 & 2 - non-legacy standard PHY interfaces. > > PHY driver is using instance numbers to identify the > interface type. > > With this patch Modified PHY driver t

Re: USB root hub suspend the device during negotiate, Atmel AT91SAM9G45-EKES, kernel 2.6.30 Re: Can you take a look the echi log?

2012-12-21 Thread Alan Stern
On Fri, 21 Dec 2012, Kuo Shou-Chien wrote: > Hi Alan, > > Thank you for your replay and sorry for the lengthy log from booting. Kernel > version is 2.6.30. > Yes, the board has OHCI controller. By the way, the dmesg output is the output from the dmesg command. It is not the contents of a syst

How to add USB device ID

2012-12-21 Thread Kevin K
I use an USB device that looks like a serial port to the kernel. However, since the Device ID is unknown, I have to either modprobe usbserial with the vendor/id codes as parameters, or modify generic.c so it knows to handle the device. I have been going with the code modification since there are

[PATCH 22/25] usb/at91_udc: don't use [delayed_]work_pending()

2012-12-21 Thread Tejun Heo
There's no need to test whether a (delayed) work item in pending before queueing, flushing or cancelling it. Most uses are unnecessary and quite a few of them are buggy. Remove unnecessary pending tests from at91_udc. Only compile tested. Signed-off-by: Tejun Heo Cc: Andrew Victor Cc: Nicolas

Re: [PATCH] usb: chipidea: Allow disabling streaming not only in udc mode

2012-12-21 Thread Peter Chen
On Fri, Dec 21, 2012 at 10:27:30AM -0200, Fabio Estevam wrote: > From: Fabio Estevam > > When running a scp transfer using a USB/Ethernet adapter the following crash > happens: > > $ scp test.tar.gz fabio@192.168.1.100:/home/fabio > fabio@192.168.1.100's password: > test.tar.gz

Re: Remove CONFIG_USB_SUSPEND?

2012-12-21 Thread Peter Chen
On Fri, Dec 21, 2012 at 07:00:58AM -0800, Greg KH wrote: > On Fri, Dec 21, 2012 at 01:21:18PM +0800, Peter Chen wrote: > > On Thu, Dec 20, 2012 at 08:55:33PM -0800, Greg KH wrote: > > > On Fri, Dec 21, 2012 at 12:28:38PM +0800, Peter Chen wrote: > > > > On Tue, Dec 18, 2012 at 11:11:15AM -0500, Ala

Re: Remove CONFIG_USB_SUSPEND?

2012-12-21 Thread Peter Chen
On Fri, Dec 21, 2012 at 11:53:40AM -0500, Alan Stern wrote: > On Fri, 21 Dec 2012, Greg KH wrote: > > > On Fri, Dec 21, 2012 at 01:21:18PM +0800, Peter Chen wrote: > > > On Thu, Dec 20, 2012 at 08:55:33PM -0800, Greg KH wrote: > > > > On Fri, Dec 21, 2012 at 12:28:38PM +0800, Peter Chen wrote: > >

Re: How to add USB device ID

2012-12-21 Thread Greg KH
On Fri, Dec 21, 2012 at 05:54:33PM -0600, Kevin K wrote: > I use an USB device that looks like a serial port to the kernel. However, > since the Device ID is unknown, I have to either modprobe usbserial with > the vendor/id codes as parameters, or modify generic.c so it knows to > handle the devic