[PATCH v2] usb: phy: using kzalloc instead of kmalloc

2012-12-20 Thread Venu Byravarasu
As Tegra PHY driver open is using kmalloc, changing it to kzalloc. Signed-off-by: Venu Byravarasu --- This patch is v2 patch for the patch discussed at http://marc.info/?l=linux-usb&m=135593869431766&w=2 drivers/usb/phy/tegra_usb_phy.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

RE: [PATCH] usb: phy: tegra: Using devm API for memory allocation

2012-12-20 Thread Venu Byravarasu
> -Original Message- > From: Stephen Warren [mailto:swar...@wwwdotorg.org] > Sent: Wednesday, December 19, 2012 11:08 PM > To: Venu Byravarasu > Cc: ba...@ti.com; gre...@linuxfoundation.org; linux- > ker...@vger.kernel.org; linux-usb@vger.kernel.org > Subject: Re: [PATCH] usb: phy: tegra: U

Re: 3.7 kernel hangs when doing scp

2012-12-20 Thread Fabio Estevam
Hi Peter, On Thu, Dec 20, 2012 at 2:39 AM, Peter Chen wrote: > Please to see if the Stream mode disable (bit4, usbmode) is set or not? > If it is not, please try below patch > > diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c > index c97503b..258bc02 100644 > --- a/drivers

Re: 3.7 kernel hangs when doing scp

2012-12-20 Thread Fabio Estevam
On Thu, Dec 20, 2012 at 8:20 AM, Fabio Estevam wrote: > Hi Peter, > > On Thu, Dec 20, 2012 at 2:39 AM, Peter Chen wrote: > >> Please to see if the Stream mode disable (bit4, usbmode) is set or not? >> If it is not, please try below patch >> >> diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/us

Re: 3.7 kernel hangs when doing scp

2012-12-20 Thread Fabio Estevam
On Thu, Dec 20, 2012 at 8:20 AM, Fabio Estevam wrote: > Excellent! Your suggestion made scp work with mx6 on 3.7. > > I assume that this "fix" or workaround would need a better place, right? > > Should this fix go into the chipidea host driver instead? Also, we are already passing the CI13XXX_DI

Re: 3.7 kernel hangs when doing scp

2012-12-20 Thread Fabio Estevam
On Thu, Dec 20, 2012 at 8:45 AM, Fabio Estevam wrote: > Would this be the correct fix? > > --- a/include/linux/usb/chipidea.h > +++ b/include/linux/usb/chipidea.h > @@ -18,7 +18,7 @@ struct ci13xxx_platform_data { > #define CI13XXX_REGS_SHAREDBIT(0) > #define CI13XXX_REQUIRE_TRANSCE

Re: [PATCH 08/10] usb: add usb port auto power off mechanism

2012-12-20 Thread Lan Tianyu
On 2012年12月19日 23:39, Alan Stern wrote: > On Wed, 19 Dec 2012, lantianyu wrote: > I just find busy_bits is set or clear in the usb_port_resume() and usb_reset_and_verify_device(). So currently we should keep my changes mutually exclusive with them, right? >>> >>> Don't forget about

[PATCH] drivers/usb/host/uhci-* : check buffer length to avoid memory overflow

2012-12-20 Thread Chen Gang
reason (why): for function uhci_sprint_schedule: the buffer len is MAX_OUTPUT: 64 * 1024 the buffer may not be enough: may loop UHCI_NUMFRAMES times (UHCI_NUMFRAMES is 1024) each time of loop may get more than 64 bytes so need check the buffer length to avoi

Re: [PATCH] ehci: make debug port in-use detection functional again

2012-12-20 Thread Sergei Shtylyov
Hello. On 19-12-2012 20:15, Jan Beulich wrote: Debug port in-use determination must be done before the controller gets reset the first time, i.e. before the call to ehci_setup() as of commit 1a49e2ac9651df7349867a5cf44e2c83de1046af. That commit effectively rendered commit 9fa5780beea1274d498a22

Re: [PATCH v2] usb: phy: using kzalloc instead of kmalloc

2012-12-20 Thread Sergei Shtylyov
Hello. On 20-12-2012 12:25, Venu Byravarasu wrote: As Tegra PHY driver open is using kmalloc, changing it to kzalloc. This description doesn't make sense. Signed-off-by: Venu Byravarasu WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of

Re: xHCI immediately wakes up Asus P8Z68-V LX in S5

2012-12-20 Thread lantianyu
于 2012/12/16 8:37, Ben Hutchings 写道: 'echo disabled > /sys/bus/pci/devices/:04:00.0/power/wakeup' does *not* work around this. This is strange. Normally, If disable the xhci's wakeup, the xhci's gpe would not be opened and so xhci couldn't wakeup the system. Can you attach the output of "

Re: [PATCH v5 1/4] ARM: EXYNOS: Update & move usb-phy types to generic include layer

2012-12-20 Thread Doug Anderson
Vivek, On Wed, Dec 19, 2012 at 9:51 PM, Vivek Gautam wrote: > Hi Doug, > > > On Thu, Dec 20, 2012 at 3:18 AM, Doug Anderson wrote: >> Vivek, >> >> Since you're changing the name, I would have expected to see a removal >> of the old enum type in this patch. I don't see it. After applying >> all

Re: [PATCH v2] usb: phy: using kzalloc instead of kmalloc

2012-12-20 Thread Stephen Warren
On 12/20/2012 05:44 AM, Sergei Shtylyov wrote: > Hello. > > On 20-12-2012 12:25, Venu Byravarasu wrote: > >> As Tegra PHY driver open is using kmalloc, >> changing it to kzalloc. Indeed, better might be: usb: phy: use kzalloc to allocate struct tegra_usb_phy Use kzalloc instead of kmalloc to a

Re: Bug#677472: [3.1->3.2 regression] Immediate wake on suspend, associated with OHCI on MCP51

2012-12-20 Thread Frank Schäfer
Am 19.12.2012 20:35, schrieb Alan Stern: > On Wed, 19 Dec 2012, [ISO-8859-1] Frank Sch�fer wrote: > >> I can confirm that MCP55 has this bug and it should be safe to add >> MCP65-78S, too, because MCP79 still has the bug. > By the way, you mentioned that runtime suspend seemed to work okay, > righ

Re: [PATCH v5 3/4] USB: ehci-s5p: Add phy driver support

2012-12-20 Thread Doug Anderson
On Wed, Dec 19, 2012 at 10:37 PM, Vivek Gautam wrote: > > On Thu, Dec 20, 2012 at 5:00 AM, Doug Anderson wrote: >> >> On Tue, Dec 18, 2012 at 6:43 AM, Vivek Gautam >> wrote: >>> +static void s5p_ehci_phy_enable(struct s5p_ehci_hcd *s5p_ehci) >>> +{ >>> + struct platform_device *pdev = to_

Re: Bug#677472: [3.1->3.2 regression] Immediate wake on suspend, associated with OHCI on MCP51

2012-12-20 Thread Frank Schäfer
Am 20.12.2012 18:34, schrieb Frank Schäfer: > Am 19.12.2012 20:35, schrieb Alan Stern: >> On Wed, 19 Dec 2012, [ISO-8859-1] Frank Sch�fer wrote: >> >>> I can confirm that MCP55 has this bug and it should be safe to add >>> MCP65-78S, too, because MCP79 still has the bug. >> By the way, you mentione

Re: [PATCH v5 1/4] ARM: EXYNOS: Update & move usb-phy types to generic include layer

2012-12-20 Thread Vivek Gautam
Hi Doug, On Thu, Dec 20, 2012 at 10:23 PM, Doug Anderson wrote: > Vivek, > > On Wed, Dec 19, 2012 at 9:51 PM, Vivek Gautam > wrote: >> Hi Doug, >> >> >> On Thu, Dec 20, 2012 at 3:18 AM, Doug Anderson wrote: >>> Vivek, >>> >>> Since you're changing the name, I would have expected to see a remov

Re: Bug#677472: [3.1->3.2 regression] Immediate wake on suspend, associated with OHCI on MCP51

2012-12-20 Thread Alan Stern
On Thu, 20 Dec 2012, Frank Schäfer wrote: > > Yes runtime suspend works (tested with a mouse) and lspci -vv doesn't > > change. > > > > With > > /sys/devices/pci:00/:00:02.0/usb2/2-9/power: > > control = on > > runtime_status = active > > > > 00:02.0 USB controller: NVIDIA Corporation MCP6

Re: 3.7 kernel hangs when doing scp

2012-12-20 Thread Peter Chen
On Thu, Dec 20, 2012 at 09:18:43AM -0200, Fabio Estevam wrote: > On Thu, Dec 20, 2012 at 8:45 AM, Fabio Estevam wrote: > > > Would this be the correct fix? > > > > --- a/include/linux/usb/chipidea.h > > +++ b/include/linux/usb/chipidea.h > > @@ -18,7 +18,7 @@ struct ci13xxx_platform_data { > > #

Re: Remove CONFIG_USB_SUSPEND?

2012-12-20 Thread Peter Chen
On Tue, Dec 18, 2012 at 11:11:15AM -0500, Alan Stern wrote: > I suggest that we remove the CONFIG_USB_SUSPEND option, starting in > 3.9. Practically everyone enables it, and the amount of code it > protects is fairly small (just portions of usbcore, nothing in the > drivers). > > Basically, if p

Re: Remove CONFIG_USB_SUSPEND?

2012-12-20 Thread Greg KH
On Fri, Dec 21, 2012 at 12:28:38PM +0800, Peter Chen wrote: > On Tue, Dec 18, 2012 at 11:11:15AM -0500, Alan Stern wrote: > > I suggest that we remove the CONFIG_USB_SUSPEND option, starting in > > 3.9. Practically everyone enables it, and the amount of code it > > protects is fairly small (just p

Re: Remove CONFIG_USB_SUSPEND?

2012-12-20 Thread Peter Chen
On Thu, Dec 20, 2012 at 08:55:33PM -0800, Greg KH wrote: > On Fri, Dec 21, 2012 at 12:28:38PM +0800, Peter Chen wrote: > > On Tue, Dec 18, 2012 at 11:11:15AM -0500, Alan Stern wrote: > > > I suggest that we remove the CONFIG_USB_SUSPEND option, starting in > > > 3.9. Practically everyone enables i

[PATCH v3] usb: phy: use kzalloc to allocate struct tegra_usb_phy

2012-12-20 Thread Venu Byravarasu
Use kzalloc instead of kmalloc to allocate struct tegra_usb_phy. This ensures that all function pointers in member u_phy are initialized to NULL. Signed-off-by: Venu Byravarasu --- This patch is v3 patch for the patch discussed at http://marc.info/?l=linux-kernel&m=135599303216132&w=2 drivers/u

[PATCH] usb: tegra: Removing dependency on PHY instance number

2012-12-20 Thread Venu Byravarasu
Tegra2 has two varieties of USB PHYs: Instance 0 - legacy PHY interface and Instace 1 & 2 - non-legacy standard PHY interfaces. PHY driver is using instance numbers to identify the interface type. With this patch Modified PHY driver to make use of DT property for handling this. ULPI PHY is used