Re: [PATCH] usb: phy: samsung: Add support for USB 3.0 phy for exynos5250

2012-12-19 Thread Felipe Balbi
Hi, On Wed, Dec 19, 2012 at 11:52:01AM +0530, Vivek Gautam wrote: > >>> @@ -736,7 +1035,41 @@ static int __devinit samsung_usbphy_probe(struct > >>> platform_device *pdev) > >>> > >>> sphy->clk = clk; > >>> > >>> - return usb_add_phy(&sphy->phy, USB_PHY_TYPE_USB2); > >>> + sphy->has

Re: help with f_loopback

2012-12-19 Thread Sebastian Andrzej Siewior
On Tue, Dec 18, 2012 at 07:29:40PM -0600, ricardo garcia wrote: > > my controller its: PHY dwc_otg (Broadcom BCMxxx) That one is not in tree. I'm afraid you are on your own here. It might be the fault of the UDC. > im not currently able to test this with 3.7, can somebody give it a > try to rule

Re: [PATCH 5/5] staging: usbip: userspace: suppress a bogus error

2012-12-19 Thread David Chang
Hi, 2012/12/8 Ilija Hadzic : > If mkdir() of VHCI_STATE_PATH fails because the directory > already exists, that's not an error. This patch fixes > annoying "record connection" errors that would typically > come up on attach. > > Signed-off-by: Ilija Hadzic > --- > drivers/staging/usbip/userspace

Re: [PATCH 2/2]linux-usb:optimize to match the Huawei USB storage devices and support new switch command

2012-12-19 Thread Sebastian Andrzej Siewior
On Wed, Dec 19, 2012 at 03:13:32AM +, Fangxiaozhi (Franko) wrote: > By the way, I found the kernel is updated to 3.7.1 today. So I have to > update my patch based on 3.7.1, and resubmit it? > Right? You should rebase your patch on top of Greg's usb-next branch of his usb tree. h

Re: help with f_loopback

2012-12-19 Thread Felipe Balbi
On Wed, Dec 19, 2012 at 09:19:53AM +0100, Sebastian Andrzej Siewior wrote: > On Tue, Dec 18, 2012 at 07:29:40PM -0600, ricardo garcia wrote: > > > > my controller its: PHY dwc_otg (Broadcom BCMxxx) > > That one is not in tree. I'm afraid you are on your own here. It might be the > fault of the UD

[PATCH V2] usb: gadget zero: avoid unnecessary reinit of data in f_sourcesink

2012-12-19 Thread Armando Visconti
In the IN case, since the USB request is allocated only when the source/sink function is started and never freed, the USB ept buffer needs to be initialized only at the beginning. This change results into a more performant g_zero module, especially when 'pattern=1' is selected. Signed-off-by: Arma

Re: [PATCH 08/10] usb: add usb port auto power off mechanism

2012-12-19 Thread lantianyu
于 2012/12/18 23:58, Alan Stern 写道: On Tue, 18 Dec 2012, lantianyu wrote: What you want here is sort of an alternate debounce routine. The normal routine waits until the connect status has been stable for 100 ms. But you want to wait until the status has stable in the "connected" state for 100

Re: xhci_hcd fails USB2.0 camera that worked on ehci_hcd

2012-12-19 Thread Marius Silaghi
I am told by camera manufacturers that a first version of the Windows drivers also had such problems with their camera, but that it was fixed in subsequent Windows drivers of xHCI. I reattach the same ehci lsusb.txt. On Tuesday 18 December 2012 16:19:18 Sarah Sharp wrote: > On Tue, Dec 18, 20

Re: Bug#677472: [3.1->3.2 regression] Immediate wake on suspend, associated with OHCI on MCP51

2012-12-19 Thread lantianyu
于 2012/12/18 4:06, Alan Stern 写道: On Mon, 17 Dec 2012, Octavio Alvarez wrote: On Thu, 13 Dec 2012 00:45:05 -0800, Lan Tianyu wrote: diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c index f034716..9335f1b 100644 --- a/drivers/usb/core/hcd.c +++ b/drivers/usb/core/hcd.c @@ -2509,7

Re: [PATCH v2] usb: phy: samsung: Add support to set pmu isolation

2012-12-19 Thread Vivek Gautam
Hi Sylwester, On Wed, Dec 19, 2012 at 11:05 AM, Vivek Gautam wrote: > CC: Doug Anderson > > > On Wed, Dec 19, 2012 at 4:49 AM, Sylwester Nawrocki > wrote: >> Hi Vivek, >> >> >> On 12/18/2012 02:56 PM, Vivek Gautam wrote: >>> >>> Adding support to parse device node data in order to get >>> requi

Re: [PATCH 0/2] usb: exynos: Fix compatible strings used for device

2012-12-19 Thread Vivek Gautam
CC: Doug Anderson On Sat, Dec 15, 2012 at 12:50 PM, Grant Likely wrote: > On Thu, 13 Dec 2012 20:22:26 +0530, Vivek Gautam > wrote: >> Using chip specific compatible string as it should be. >> So fixing this for ehci-s5p, ohci-exynos and dwc3-exynos >> which till now used a generic 'exynos' in

Re: [PATCH 1/2] usb: ehci-s5p/ohci-exynos: Fix compatible strings for the device

2012-12-19 Thread Vivek Gautam
CC: Doug Anderson On Thu, Dec 13, 2012 at 9:39 PM, Vivek Gautam wrote: > On Thu, Dec 13, 2012 at 8:22 PM, Vivek Gautam > wrote: >> Using specific chip in compatible strings. Newer SOCs can claim >> device by using older string in the compatible list. >> >> Signed-off-by: Vivek Gautam >> --- >

Re: [PATCH 2/2] usb: dwc3-exynos: Fix compatible strings for the device

2012-12-19 Thread Vivek Gautam
CC: Doug Anderson On Thu, Dec 13, 2012 at 9:40 PM, Vivek Gautam wrote: > CC: LKML > > On Thu, Dec 13, 2012 at 8:22 PM, Vivek Gautam > wrote: >> Using specific chip in compatible strings. Newer SOCs can claim >> device by using older string in the compatible list. >> >> Signed-off-by: Vivek Gau

Re: [PATCH v3 1/2] ARM: Exynos5250: Enabling ehci-s5p driver

2012-12-19 Thread Vivek Gautam
CC: Doug Anderson On Sat, Dec 15, 2012 at 12:53 PM, Grant Likely wrote: > On Thu, 13 Dec 2012 22:06:01 +0530, Vivek Gautam > wrote: >> Adding EHCI device tree node for Exynos5250 along with >> the device base adress and gpio line for vbus. >> >> Signed-off-by: Vivek Gautam >> Acked-by: Jingoo

Re: [PATCH v3] ARM: Exynos5250: Enabling dwc3-exynos driver

2012-12-19 Thread Vivek Gautam
CC: Doug Anderson On Thu, Dec 13, 2012 at 10:17 PM, Vivek Gautam wrote: > Adding DWC3 device tree node for Exynos5250 along with the > device address and clock support needed for the controller. > > Signed-off-by: Vivek Gautam > --- > Changes from v2: > - Changed the compatible string to chip

[PATCH] USB: option: blacklist network interface on ZTE MF880

2012-12-19 Thread Bjørn Mork
The driver description files gives these names to the vendor specific functions on this modem: diag: VID_19D2&PID_0284&MI_00 nmea: VID_19D2&PID_0284&MI_01 at: VID_19D2&PID_0284&MI_02 mdm: VID_19D2&PID_0284&MI_03 net: VID_19D2&PID_0284&MI_04 Signed-off-by: Bjørn Mork --- drivers/usb/ser

[PATCH net] net: qmi_wwan: add ZTE MF880

2012-12-19 Thread Bjørn Mork
The driver description files gives these names to the vendor specific functions on this modem: diag: VID_19D2&PID_0284&MI_00 nmea: VID_19D2&PID_0284&MI_01 at: VID_19D2&PID_0284&MI_02 mdm: VID_19D2&PID_0284&MI_03 net: VID_19D2&PID_0284&MI_04 Signed-off-by: Bjørn Mork --- drivers/net/usb

Re: Remove CONFIG_USB_SUSPEND?

2012-12-19 Thread Martin Mokrejs
Hi, I just subscribed to the linux-usb list as an occasional user ... I glanced through this thread backwards ... and am somehow surprised nobody objects. I am no expert but it is my impression a lot of us want CPU powersaving, maybe LCD powersaving and don't care about external USB devices. It

Re: 3.7 kernel hangs when doing scp

2012-12-19 Thread Fabio Estevam
Hi Greg, On Tue, Dec 18, 2012 at 12:43 AM, Greg KH wrote: > On Tue, Dec 18, 2012 at 12:01:35AM -0200, Fabio Estevam wrote: >> Hi, >> >> Booting a 3.7 kernel on a mx6qsabrelite board via NFS and using an >> asix USB/Ethernet adapter and then I try to transfer a 10MB file from >> the target to the

Re: [PATCH v2] drivers/usb/host/ohci* : set urb->hcpriv = NULL immediately, after free it

2012-12-19 Thread Alan Stern
On Wed, 19 Dec 2012, Chen Gang wrote: > although we can not say it is surely a bug. > it is better to set urb->hcpriv = NULL, after finish calling urb_free_priv. > > > Signed-off-by: Chen Gang > --- > drivers/usb/host/ohci-q.c |1 + > 1 file changed, 1 insertion(+) > > diff --git a/dr

Re: [Suggestion] drivers/usb/host/uhci* : sprintf, need check len when use buf

2012-12-19 Thread Alan Stern
On Wed, 19 Dec 2012, Chen Gang wrote: > Hello Alan Stern > > I finished constructing envrionments. > let uhci-debug.c has effect (#define DEBUG, debug = 3 in > drivers/usb/host/uhci-hcd.c) > build kernel and install, and restart machine. > can cat /sys/kernel/debug/usb/uhci/* to ge

Re: Bug#677472: [3.1->3.2 regression] Immediate wake on suspend, associated with OHCI on MCP51

2012-12-19 Thread Alan Stern
On Wed, 19 Dec 2012, Lan Tianyu wrote: > Hi Alan: > > How about this patch? > > Index: linux-pm/drivers/usb/host/ohci-pci.c > === > --- linux-pm.orig/drivers/usb/host/ohci-pci.c 2012-11-01 > 18:21:33.604460469 +0800 > +++ linux-pm

Re: Bug. Can't read uvcvideo (usb video / webcams) devices

2012-12-19 Thread Alan Stern
On Wed, 19 Dec 2012, Егор Орлов wrote: > Alan, thank you for your reply. May be in the future this bug will be > fixed. I understand it's not a simple bug. I will not send any > messages concerning this bug anymore. > > When I tested the camera on other two machines running Ubuntu it > showed the

Re: [PATCH 08/10] usb: add usb port auto power off mechanism

2012-12-19 Thread Alan Stern
On Wed, 19 Dec 2012, lantianyu wrote: > >> I just find busy_bits is set or clear in the usb_port_resume() and > >> usb_reset_and_verify_device(). So currently we should keep my changes > >> mutually exclusive with them, right? > > > > Don't forget about what happens when a device is removed. > I a

Re: Bug#677472: [3.1->3.2 regression] Immediate wake on suspend, associated with OHCI on MCP51

2012-12-19 Thread Alan Stern
On Wed, 19 Dec 2012, lantianyu wrote: > Oh. I forget to mention the issue also takes place on the uhci. > https://bugzilla.kernel.org/show_bug.cgi?id=42721 > So we also should make such a patch for uhci. That bug report shows clearly that it is a software problem or a device problem, not an erro

Re: [PATCH 2/2]linux-usb:optimize to match the Huawei USB storage devices and support new switch command

2012-12-19 Thread Matthew Dharm
On Wed, Dec 19, 2012 at 12:34 AM, Sebastian Andrzej Siewior wrote: > On Wed, Dec 19, 2012 at 03:13:32AM +, Fangxiaozhi (Franko) wrote: >> > And shouldn't you read something from the us->recv_bulk_pipe after >> > that? >> Well, because our device will re-connect to switch the ports if it

Re: Remove CONFIG_USB_SUSPEND?

2012-12-19 Thread Alan Stern
On Wed, 19 Dec 2012, Martin Mokrejs wrote: > Hi, > I just subscribed to the linux-usb list as an occasional user ... > I glanced through this thread backwards ... and am somehow surprised > nobody objects. I am no expert but it is my impression a lot of us > want CPU powersaving, maybe LCD powe

Re: Remove CONFIG_USB_SUSPEND?

2012-12-19 Thread Greg KH
On Wed, Dec 19, 2012 at 03:24:34PM +0100, Martin Mokrejs wrote: > Hi, > I just subscribed to the linux-usb list as an occasional user ... > I glanced through this thread backwards ... and am somehow surprised > nobody objects. I am no expert but it is my impression a lot of us > want CPU powersa

[PATCH] ehci: make debug port in-use detection functional again

2012-12-19 Thread Jan Beulich
Debug port in-use determination must be done before the controller gets reset the first time, i.e. before the call to ehci_setup() as of commit 1a49e2ac9651df7349867a5cf44e2c83de1046af. That commit effectively rendered commit 9fa5780beea1274d498a224822397100022da7d4 useless. While moving that code

Re: Bug#677472: [3.1->3.2 regression] Immediate wake on suspend, associated with OHCI on MCP51

2012-12-19 Thread Octavio Alvarez
On Wed, 19 Dec 2012 07:29:23 -0800, Alan Stern wrote: + ohci_dbg(ohci, "marked as bad wakeup.\n"); I'd prefer the message to be something more like "enabled nVidia/SiS wakeup quirk". To me, the stupid end-user, both messages are useless. I don't know that that means or implies. I woul

Re: Remove CONFIG_USB_SUSPEND?

2012-12-19 Thread Martin Mokrejs
Greg KH wrote: > On Wed, Dec 19, 2012 at 03:24:34PM +0100, Martin Mokrejs wrote: >> Hi, >> I just subscribed to the linux-usb list as an occasional user ... >> I glanced through this thread backwards ... and am somehow surprised >> nobody objects. I am no expert but it is my impression a lot of

Re: [PATCH] ehci: make debug port in-use detection functional again

2012-12-19 Thread Alan Stern
On Wed, 19 Dec 2012, Jan Beulich wrote: > Debug port in-use determination must be done before the controller gets > reset the first time, i.e. before the call to ehci_setup() as of commit > 1a49e2ac9651df7349867a5cf44e2c83de1046af. That commit effectively > rendered commit 9fa5780beea1274d498a2248

Re: Bug#677472: [3.1->3.2 regression] Immediate wake on suspend, associated with OHCI on MCP51

2012-12-19 Thread Alan Stern
On Wed, 19 Dec 2012, Octavio Alvarez wrote: > On Wed, 19 Dec 2012 07:29:23 -0800, Alan Stern > wrote: > >> + ohci_dbg(ohci, "marked as bad wakeup.\n"); > > > > I'd prefer the message to be something more like "enabled nVidia/SiS > > wakeup quirk". > > To me, the stupid end-user, both mes

Re: Bug#677472: [3.1->3.2 regression] Immediate wake on suspend, associated with OHCI on MCP51

2012-12-19 Thread Octavio Alvarez
On Wed, 19 Dec 2012 08:57:00 -0800, Alan Stern wrote: You, the stupid end-user, would not see this message at all under normal circumstances. It uses the ohci_dbg macro and therefore will not appear unless your kernel is built with CONFIG_USB_DEBUG enabled. Shouldn't it be exposed to dmesg

Re: [PATCH] ehci: make debug port in-use detection functional again

2012-12-19 Thread Greg KH
On Wed, Dec 19, 2012 at 11:52:42AM -0500, Alan Stern wrote: > On Wed, 19 Dec 2012, Jan Beulich wrote: > > > Debug port in-use determination must be done before the controller gets > > reset the first time, i.e. before the call to ehci_setup() as of commit > > 1a49e2ac9651df7349867a5cf44e2c83de1046

Re: [PATCH] usb: phy: tegra: Using devm API for memory allocation

2012-12-19 Thread Stephen Warren
On 12/18/2012 10:38 PM, Venu Byravarasu wrote: >> -Original Message- >> From: Stephen Warren [mailto:swar...@wwwdotorg.org] >> Sent: Tuesday, December 18, 2012 10:03 PM >> To: Venu Byravarasu >> Cc: ba...@ti.com; gre...@linuxfoundation.org; linux- >> ker...@vger.kernel.org; linux-usb@vger.k

Re: Bug#677472: [3.1->3.2 regression] Immediate wake on suspend, associated with OHCI on MCP51

2012-12-19 Thread Alan Stern
On Wed, 19 Dec 2012, Octavio Alvarez wrote: > On Wed, 19 Dec 2012 08:57:00 -0800, Alan Stern > wrote: > > > You, the stupid end-user, would not see this message at all under > > normal circumstances. It uses the ohci_dbg macro and therefore will > > not appear unless your kernel is built with

Re: Bug#677472: [3.1->3.2 regression] Immediate wake on suspend, associated with OHCI on MCP51

2012-12-19 Thread Frank Schäfer
Am 19.12.2012 16:29, schrieb Alan Stern: > On Wed, 19 Dec 2012, Lan Tianyu wrote: ... > /* List of quirks for OHCI */ > static const struct pci_device_id ohci_pci_quirks[] = { > { > @@ -238,6 +247,31 @@ > PCI_DEVICE(PCI_VENDOR_ID_ATI, 0x4399), > .driver_dat

Re: Bug#677472: [3.1->3.2 regression] Immediate wake on suspend, associated with OHCI on MCP51

2012-12-19 Thread Alan Stern
On Wed, 19 Dec 2012, [ISO-8859-1] Frank Sch�fer wrote: > I can confirm that MCP55 has this bug and it should be safe to add > MCP65-78S, too, because MCP79 still has the bug. By the way, you mentioned that runtime suspend seemed to work okay, right? It might be worthwhile testing this again, ju

Re: [PATCH v2] usb: phy: samsung: Add support to set pmu isolation

2012-12-19 Thread Sylwester Nawrocki
Hi, On 12/19/2012 02:44 PM, Vivek Gautam wrote: --- a/Documentation/devicetree/bindings/usb/samsung-usbphy.txt +++ b/Documentation/devicetree/bindings/usb/samsung-usbphy.txt @@ -9,3 +9,15 @@ Required properties: - compatible : should be "samsung,exynos4210-usbphy" - reg : base physical add

Re: [PATCH net] net: qmi_wwan: add ZTE MF880

2012-12-19 Thread David Miller
From: Bjørn Mork Date: Wed, 19 Dec 2012 15:15:51 +0100 > The driver description files gives these names to the vendor specific > functions on this modem: > > diag: VID_19D2&PID_0284&MI_00 > nmea: VID_19D2&PID_0284&MI_01 > at: VID_19D2&PID_0284&MI_02 > mdm: VID_19D2&PID_0284&MI_03 > net:

[PATCH] USB: xhci - fix bit definitions for IMAN register

2012-12-19 Thread Dmitry Torokhov
According to XHCI specification (5.5.2.1) the IP is bit 0 and IE is bit 1 of IMAN register. Previously their definitions were reversed. Signed-off-by: Dmitry Torokhov --- Sarah, I did not see any ill effects from using the old definitions (I think because IMAN_IP is RW1C and in legacy PCI case

Re: [PATCH v5 1/4] ARM: EXYNOS: Update & move usb-phy types to generic include layer

2012-12-19 Thread Doug Anderson
Vivek, On Tue, Dec 18, 2012 at 6:43 AM, Vivek Gautam wrote: > Updating the names of usb-phy types to more generic names: > USB_PHY_TYPE_DEIVCE & USB_PHY_TYPE_HOST; and further update > its dependencies. Since you're changing the name, I would have expected to see a removal of the old enum type i

Re: [PATCH v5 2/4] usb: phy: samsung: Add host phy support to samsung-phy driver

2012-12-19 Thread Doug Anderson
Vivek, I don't really have a good 1 foot view about how all of the USB bits fit together, but a few detail-oriented comments below. On Tue, Dec 18, 2012 at 6:43 AM, Vivek Gautam wrote: > This patch adds host phy support to samsung-usbphy.c and > further adds support for samsung's exynos5250

Re: [PATCH v5 3/4] USB: ehci-s5p: Add phy driver support

2012-12-19 Thread Doug Anderson
Vivek, Again, not a high-level review, but... On Tue, Dec 18, 2012 at 6:43 AM, Vivek Gautam wrote: > Adding the phy driver to ehci-s5p. Keeping the platform data > for continuing the smooth operation for boards which still uses it > > Signed-off-by: Vivek Gautam > Acked-by: Jingoo Han > --- >

Re: 3.4.17: OOPs in xhci_irq() probably due to sleeping disks on a Prolific USB-to-SATA dongle

2012-12-19 Thread Sarah Sharp
Hi Martin, Thanks for the bug report. Yes, I would like full dmesg from your system, including the oops if you have it. Can you reproduce this bug on an updated 3.4.24 kernel? It sounds like a difficult bug to trigger, but the oops wasn't helpful enough for me to pinpoint the problem. If you c

Re: xHCI immediately wakes up Asus P8Z68-V LX in S5

2012-12-19 Thread Sarah Sharp
On Wed, Dec 19, 2012 at 03:15:09AM +, Ben Hutchings wrote: > On Mon, 2012-12-17 at 13:28 -0800, Sarah Sharp wrote: > > On Sun, Dec 16, 2012 at 12:37:00AM +, Ben Hutchings wrote: > > > Since Linux 3.2.16, my desktop with an Asus P8Z68-V LX motherboard > > > always wakes up a few seconds afte

Re: Bug#677472: [3.1->3.2 regression] Immediate wake on suspend, associated with OHCI on MCP51

2012-12-19 Thread Octavio Alvarez
On Wed, 19 Dec 2012 11:35:50 -0800, Alan Stern wrote: As far as the OHCI hardware is concerned, there shouldn't be any difference between runtime suspend and system suspend. This strongly suggests that the bug doesn't lie in the controller itself but in the firmware (BIOS or ACPI). Is there

Re: Bug#677472: [3.1->3.2 regression] Immediate wake on suspend, associated with OHCI on MCP51

2012-12-19 Thread Alan Stern
[CC: list trimmed slightly] On Wed, 19 Dec 2012, Octavio Alvarez wrote: > On Wed, 19 Dec 2012 11:35:50 -0800, Alan Stern > wrote: > > > As far as the OHCI hardware is concerned, there shouldn't be any > > difference between runtime suspend and system suspend. This strongly > > suggests that th

Re: 3.7 kernel hangs when doing scp

2012-12-19 Thread Peter Chen
On Wed, Dec 19, 2012 at 12:56:12PM -0200, Fabio Estevam wrote: > Hi Greg, > > On Tue, Dec 18, 2012 at 12:43 AM, Greg KH wrote: > > On Tue, Dec 18, 2012 at 12:01:35AM -0200, Fabio Estevam wrote: > >> Hi, > >> > >> Booting a 3.7 kernel on a mx6qsabrelite board via NFS and using an > >> asix USB/Eth

Re: [PATCH v5 1/4] ARM: EXYNOS: Update & move usb-phy types to generic include layer

2012-12-19 Thread Vivek Gautam
Hi Doug, On Thu, Dec 20, 2012 at 3:18 AM, Doug Anderson wrote: > Vivek, > > On Tue, Dec 18, 2012 at 6:43 AM, Vivek Gautam > wrote: >> Updating the names of usb-phy types to more generic names: >> USB_PHY_TYPE_DEIVCE & USB_PHY_TYPE_HOST; and further update >> its dependencies. > > Since you're

Re: [PATCH v5 3/4] USB: ehci-s5p: Add phy driver support

2012-12-19 Thread Vivek Gautam
Hi Doug, On Thu, Dec 20, 2012 at 5:00 AM, Doug Anderson wrote: > Vivek, > > Again, not a high-level review, but... > Thanks for reviewing. :-) > > On Tue, Dec 18, 2012 at 6:43 AM, Vivek Gautam > wrote: >> Adding the phy driver to ehci-s5p. Keeping the platform data >> for continuing the smoot