Re: [PATCH v8] usb_8dev: Add support for USB2CAN interface from 8 devices

2012-12-15 Thread Oliver Hartkopp
On 15.12.2012 07:53, Bernd Krumboeck wrote: > +++ b/Documentation/ABI/testing/sysfs-driver-usb_8dev > @@ -0,0 +1,13 @@ > +What:/sys/bus/usb/devices/-: num>./firmware > +Date:December 2012 > +Contact: Bernd Krumboeck > +Description: > + Returns the f

[Suggestion] drivers/usb/host/ohci* : not setting urb->hcpriv = NULL after kfree it.

2012-12-15 Thread Chen Gang
Hello Alan Stern: in drivers/usb/host/ohci-q.c, function finish_urb: when we finish call urb_free_priv, we not set urb->hcpriv = NULL (line 46) urb_free_priv call kfree for urb_priv (which is urb->hcpriv, line 29) within finish_urb, we not set urb->hcpriv = NULL (line 43..81) in d

Re: [PATCH v8] usb_8dev: Add support for USB2CAN interface from 8 devices

2012-12-15 Thread Bernd Krumböck
This informations could be useful for configuration scripts. Various drivers do the same. regards, Bernd 2012/12/15 Oliver Hartkopp On 15.12.2012 07:53, Bernd Krumboeck wrote: > +++ b/Documentation/ABI/testing/sysfs-driver-usb_8dev > @@ -0,0 +1,13 @@ > +What:/

Re: [PATCH v8] usb_8dev: Add support for USB2CAN interface from 8 devices

2012-12-15 Thread Wolfgang Grandegger
On 12/15/2012 11:12 AM, "Bernd Krumböck" wrote: > This informations could be useful for configuration scripts. Various > drivers do the same. Well, "could be" is not a strong argument. Is there a real use-case? If not I'm also in favor of removing these entries, as I already said. Wolfgang. -- T

Re: [PATCH v8] usb_8dev: Add support for USB2CAN interface from 8 devices

2012-12-15 Thread Bernd Krumböck
> On 12/15/2012 11:12 AM, "Bernd Krumböck" wrote: >> This informations could be useful for configuration scripts. Various >> drivers do the same. > > Well, "could be" is not a strong argument. Is there a real use-case? If > not I'm also in favor of removing these entries, as I already said. > Ok,

Re: [PATCH 4/4] regulator: fixed: Properly use input_supply parameter from device tree

2012-12-15 Thread Mark Brown
On Fri, Nov 16, 2012 at 12:23:43PM +0200, Roger Quadros wrote: > How is this supposed to work? How does phandle supplied in vin-supply > map to config->input_supply? You should provide a separate property to name the supply, or just pick a fixed name in the fixed voltage driver. signature.asc D

Re: USB issue with kernel 3.6

2012-12-15 Thread Piergiorgio Sartor
On Fri, Dec 14, 2012 at 11:02:07AM -0500, Alan Stern wrote: > On Mon, 10 Dec 2012, Piergiorgio Sartor wrote: > > > > Here's an idea. This just occurred to me. Maybe when the driver is > > > waiting for the async schedule to turn off, new QH's should not be > > > added to the schedule. The drive

Re: [Suggestion] drivers/usb/host/uhci* : sprintf, need check len when use buf

2012-12-15 Thread Alan Stern
On Sat, 15 Dec 2012, Chen Gang wrote: > 于 2012年12月14日 23:46, Alan Stern 写道: > > > > The easiest fix is to increase MAX_OUTPUT. Can you figure out how > > large it needs to be? > > > for me, it seems only increasing MAX_OUTPUT is not a good idea. > > maybe we can reference usb_device_dump:

Re: [Suggestion] drivers/usb/host/ohci* : not setting urb->hcpriv = NULL after kfree it.

2012-12-15 Thread Alan Stern
On Sat, 15 Dec 2012, Chen Gang wrote: > Hello Alan Stern: > > in drivers/usb/host/ohci-q.c, function finish_urb: > when we finish call urb_free_priv, we not set urb->hcpriv = NULL (line 46) > urb_free_priv call kfree for urb_priv (which is urb->hcpriv, line 29) > within finish_urb,

Re: USB issue with kernel 3.6

2012-12-15 Thread Alan Stern
On Sat, 15 Dec 2012, Piergiorgio Sartor wrote: > Hi Alan, > > thanks for the patch, I applied it and tested. > > I've bad news... > Unless I made some mistake (which can always be), I did not > see any of the logs of this patch in the output, despite > having seen the problem occuring (this time

xHCI immediately wakes up Asus P8Z68-V LX in S5

2012-12-15 Thread Ben Hutchings
Since Linux 3.2.16, my desktop with an Asus P8Z68-V LX motherboard always wakes up a few seconds after I shutdown. I then have to switch it off a second time. This still occurs in Linux 3.6.9 (haven't tried 3.7 yet). I initially bisected this to: commit 13a307e1a4a10502d688ce058141bc503933214e

[PATCH 1/1] usb: host: xhci: remove unused trb var in xhci_irq()

2012-12-15 Thread Javier Martinez Canillas
The union xhci_trb *trb variable is defined and assigned inside the xHCI IRQ handler function but is never used. Signed-off-by: Javier Martinez Canillas --- drivers/usb/host/xhci-ring.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/xhci-ring.c b/drive

[PATCH v9] usb_8dev: Add support for USB2CAN interface from 8 devices

2012-12-15 Thread Bernd Krumboeck
Add device driver for USB2CAN interface from "8 devices" (http://www.8devices.com). changes since v8: * remove all sysfs files changes since v7: * add sysfs documentation * fix minor styling issue * fixed can state for passive mode * changed handling for crc errors changes since v6: * changed s